GNU bug report logs - #31954
[PATCH] gnu: Add emacs-org-brain.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31954 in the body.
You can then email your comments to 31954 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vasile Dumitrascu <va511e <at> yahoo.com>
To: guix-patches <at> gnu.org
Cc: Vasile Dumitrascu <va511e <at> yahoo.com>
Subject: [PATCH] gnu: Add emacs-org-brain.
Date: Sun, 24 Jun 2018 11:29:37 +0200

* gnu/packages/emacs.scm (emacs-org-brain): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 3b2c41c5d..616175d54 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -11277,3 +11277,28 @@ file.")
        "@code{wgrep-helm} allows you to edit a @code{helm-grep-mode} buffer and
 apply those changes to the file buffer.")
       (license license:gpl3+))))
+
+(define-public emacs-org-brain
+  (let ((version "20180522")  ; no proper tag, use date of commit
+        (commit "3faf9303af3f2356e3444e69c22dc6c5774047d1")
+        (revision "1"))
+    (package
+      (name "emacs-org-brain")
+      (version (git-version version revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/Kungsgeten/org-brain.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1ad681zk6kckw2zbk0r4iaj4bw8cfqrbd1s3gdwgdjlzq81q9mmj"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/Kungsgeten/org-brain")
+      (synopsis "Org-mode wiki and concept-mapping for Emacs")
+      (description "@code{emacs-org-brain} implements a variant of concept
+mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of
+software called The Brain.")
+      (license license:expat))))
-- 
2.18.0

Message #8 received at 31954 <at> debbugs.gnu.org (full text, mbox):

From: Charlie Ritter <chewzerita <at> posteo.net>
To: Vasile Dumitrascu <va511e <at> yahoo.com>
Cc: 31954 <at> debbugs.gnu.org
Subject: Re: [bug#31954] [PATCH] gnu: Add emacs-org-brain.
Date: Sun, 24 Jun 2018 08:30:50 -0400

Thank you kind stranger!!!

Message #11 received at 31954 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vasile Dumitrascu <va511e <at> yahoo.com>, 31954 <at> debbugs.gnu.org
Cc: Vasile Dumitrascu <va511e <at> yahoo.com>
Subject: Re: [bug#31954] [PATCH] gnu: Add emacs-org-brain.
Date: Mon, 25 Jun 2018 21:36:31 +0200

[Message part 1 (text/plain, inline)]

Vasile Dumitrascu <va511e <at> yahoo.com> writes:

> * gnu/packages/emacs.scm (emacs-org-brain): New variable.

Thanks for this patch!  Overall it LGTM, but it does not apply to my git
checkout, so here are some nitpicks that I'd normally fix myself:

[...]

> +(define-public emacs-org-brain
> +  (let ((version "20180522")  ; no proper tag, use date of commit

'org-brain.el' has "Version: 0.5" in the source header.  Perhaps we
should use that instead?

[...]

> +      (description "@code{emacs-org-brain} implements a variant of concept
> +mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of
> +software called The Brain.")

Make sure to use double spaces in descriptions (guix lint should complain
about this).  We also should not refer to nonfree software, can you try
to expand on this description without mentioning the inspiration?

The commentary inside 'org-brain.el' contains a pretty good description.

Can you send an updated patch please?  Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 31954 <at> debbugs.gnu.org (full text, mbox):

From: Vasile Dumitrascu <va511e <at> yahoo.com>
To: Marius Bakke <mbakke <at> fastmail.com>, 31954 <at> debbugs.gnu.org,
 chewzerita <at> posteo.net
Subject: Re: [bug#31954] [PATCH] gnu: Add emacs-org-brain.
Date: Wed, 04 Jul 2018 16:30:00 +0000

[Message part 1 (text/plain, inline)]

  Hi

@Marius: Please find attached an updated patch with the requested
changes. Do let me know if anything else is to be adjusted.

@Charlie: I am glad you find it useful. You are welcome!

  Thank you,

  Vasile

Marius Bakke:
> Vasile Dumitrascu <va511e <at> yahoo.com> writes:
> 
>> * gnu/packages/emacs.scm (emacs-org-brain): New variable.
> 
> Thanks for this patch!  Overall it LGTM, but it does not apply to my git
> checkout, so here are some nitpicks that I'd normally fix myself:
> 
> [...]
> 
>> +(define-public emacs-org-brain
>> +  (let ((version "20180522")  ; no proper tag, use date of commit
> 
> 'org-brain.el' has "Version: 0.5" in the source header.  Perhaps we
> should use that instead?
> 
> [...]
> 
>> +      (description "@code{emacs-org-brain} implements a variant of concept
>> +mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of
>> +software called The Brain.")
> 
> Make sure to use double spaces in descriptions (guix lint should complain
> about this).  We also should not refer to nonfree software, can you try
> to expand on this description without mentioning the inspiration?
> 
> The commentary inside 'org-brain.el' contains a pretty good description.
> 
> Can you send an updated patch please?  Thanks in advance!
> 

[0001-gnu-Add-emacs-org-brain.patch (text/x-patch, attachment)]

Message #19 received at 31954-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Vasile Dumitrascu <va511e <at> yahoo.com>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 31954-done <at> debbugs.gnu.org,
 chewzerita <at> posteo.net
Subject: Re: [bug#31954] [PATCH] gnu: Add emacs-org-brain.
Date: Sat, 07 Jul 2018 17:51:56 +0200

Hello Vasile,

Vasile Dumitrascu <va511e <at> yahoo.com> skribis:

> @Marius: Please find attached an updated patch with the requested
> changes. Do let me know if anything else is to be adjusted.

This updated patch appears to address Marius’ concerns so I’ve applied
it.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.