From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jun 2018 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 31951@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15297709864511 (code B ref -1); Sat, 23 Jun 2018 16:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2018 16:23:06 +0000 Received: from localhost ([127.0.0.1]:33376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWlJa-0001Ah-8m for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:23:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWlJY-00019z-Hi for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWlJS-0001vP-D2 for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:22:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, FROM_EXCESS_BASE64,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWlJS-0001vF-97 for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:22:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWlJR-0005mE-7L for bug-gnu-emacs@gnu.org; Sat, 23 Jun 2018 12:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWlJO-0001uP-38 for bug-gnu-emacs@gnu.org; Sat, 23 Jun 2018 12:22:57 -0400 Received: from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]:44203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWlJN-0001u1-SP for bug-gnu-emacs@gnu.org; Sat, 23 Jun 2018 12:22:54 -0400 Received: by mail-wr0-x234.google.com with SMTP id p12-v6so7855619wrn.11 for ; Sat, 23 Jun 2018 09:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=3CMVUxTn+gYAW/kzudBdwSSywucS6DaA7rwDXkD2SxA=; b=ZIN8ESh3Goy2/X0VugRtsHB0PWnKVSNedzM7rACkfuZtTjoYd69r6LRcCQFbQf+xY8 NRaBm9nOmhPGRc0RXLwTEacyc89n2X3VVTihzOwICqgWSlbQ2ap9C0wcg0yiIFMhRyVf D84xvJp0Y4BqM0ncU6twymdVYSSQPhg9m55u4MK/fR+IQqPgXI/h7p7ftuCYYQCRuIQl mSs+lJqkVZa20XPEMKhTS5zB+dFukhdwqvzmXNxrXsKFJGvk0unEv7TpEI9qB4Dncexz Mg8ZVbF+79hL/yQVI4e1z2kFtNRvWvoqy0H+9K5BIO26O0ZoB2BoIpEDwAQdYkewBNPJ xNTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=3CMVUxTn+gYAW/kzudBdwSSywucS6DaA7rwDXkD2SxA=; b=EK/Q9T0KIOfQ8EVcCfS7aaNpNedRRvy+wdrQsjTZWQKBzopmPed4Ya0VqEebjm2Ohi ORAsxy66JAit7f6s3YTZm2sFQMT3FBHyTEXpXla8egzwrAa2Fc7V8MSEHM3rjQLP+tHN 5ZKKkgZ7QV4Kly0fsPvOoo+cg+sLqOyjU9tiWc7th0XZzm29Vg9X6Fv1nqwI0aqxVxV1 I0OxTo70I9aEQGo5P186Uzc7Sof3/YCcLozZuTsDuC9+A26XtWR1I0NRSqWBIkBEp3SE R28ZrZvEM7VYotV0FpmMB+UWj6sOg/20BDOWYSKReCLei19PEkxtwAIxlI932PDUOFmD yplw== X-Gm-Message-State: APt69E3vU+/RTWxI9maqG4i2OsCi2sMYX1EJPr55jfT64novFPTs/59s YSQQqwI0eYxH9ZHfyKjbMSZfvuBs X-Google-Smtp-Source: AAOMgpf0CoVN0qiOptPYJTs9Rmqs13PZj//KKukYCABFtGT8JoKzC7M1AcSIKdcOuXkJb3jaqcaKNQ== X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr1366787wri.146.1529770972086; Sat, 23 Jun 2018 09:22:52 -0700 (PDT) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id f24-v6sm3180675wmc.0.2018.06.23.09.22.51 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jun 2018 09:22:51 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 23 Jun 2018 17:22:48 +0100 Message-ID: <87y3f5mq07.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.9 (----) Hi, If the Emacs client was started without an explicit list of buffers to edit, save-some-buffers is called with t for PRED (save all buffers), but that was before save-some-buffers-default-predicate existed. I don't see any reason why save-some-buffers-default-predicate shouldn't be respected in server-save-buffers-kill-terminal (of course if ARG is non-nil, we do pass t so that the previous behaviour remains). Trivial patch attached, Jo=C3=A3o diff --git a/lisp/server.el b/lisp/server.el index ff03cbe622..ac14ef314e 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1670,9 +1670,9 @@ server-save-buffers-kill-terminal ;; and offer to save all buffers. Otherwise, offer to ;; save only the buffers belonging to the client. (save-some-buffers - arg (if buffers - (lambda () (memq (current-buffer) buffers)) - t)) + arg (and buffers + (lambda () (memq (current-buffer) buffers)) + (and arg t))) (server-delete-client proc))) (t (error "Invalid client frame"))))) From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jun 2018 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152984745622087 (code B ref 31951); Sun, 24 Jun 2018 13:38:01 +0000 Received: (at 31951) by debbugs.gnu.org; 24 Jun 2018 13:37:36 +0000 Received: from localhost ([127.0.0.1]:33729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX5Cx-0005kB-Oh for submit@debbugs.gnu.org; Sun, 24 Jun 2018 09:37:35 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:55460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX5Cw-0005jy-LL for 31951@debbugs.gnu.org; Sun, 24 Jun 2018 09:37:34 -0400 Received: by mail-it0-f52.google.com with SMTP id 16-v6so8759171itl.5 for <31951@debbugs.gnu.org>; Sun, 24 Jun 2018 06:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EEw9yEs2FkIkxI4npF3xuDVX5SYe8Og4mHiX8Ip1Ej0=; b=hHojuiuJDNym0DIJBYdiFFww0BR3dl0RcBO01LiHVaSdFsQx9ZGl052ZFawhLX609V Dvp5XiChLd2ptramsE8mn6+EJ6F5+rzzyrqmeMwF5900SnJJ5EpO7/ate5cZsLa2AASp QNWpiG9Jb5E2d9YA9PKGBiFSN/s9nJvJsWbnCuKdkTEkPwi1biQbpafmcwn7UpGl4q76 4z5Zi8vB0C3ybFwHRz5wRG0V4y2gri5+tZws3N8sUfz8TMJhInAbazf9N9BwxCSzH4H+ 8LT/ZEblVqhPgH20IN0bXdJGWMfKWdYepGUokmaRk2OXh3BHOqQnypVitfffDnIpaRWF ByVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EEw9yEs2FkIkxI4npF3xuDVX5SYe8Og4mHiX8Ip1Ej0=; b=cZwLF4R9AqfSKOe0BCFkQCigMgf98+z10iLnRtALwyy5TmLYprW1ngfOjo/5pSnw2U 7/gUmS4/cYvvZVA3Z4zpo+FH19/KqxiJYkADVsb2IBgnpIUmqNs3s5Qd5cVmTp+N6Qtr kpzjjVGLYbtCKb5VCXT4FbT3WtTeA5676BcmTiRuv7HkYGcqpl/GK9P2VLCSNGFXiBri GS6YHBdguDdQ5T1qBxWKO3GgGNGoyc0IGM3JkqMK4OObwM9GEWesm9S6r8s+OB3Ci6wu 8kU79MBThSWvRPH31B9Lxn3Q0vcqXKC7mKR235Zivl0j6Dg8fHOd+JyceVgj1bpRHsd0 q3PQ== X-Gm-Message-State: APt69E2xga9ZEjlEcGBFnvn2svy7c9BWvf42Lkr/YgRL/kFsSyfxKlZl FeeZpK70c1uIM6kLJOH0IFmz9A== X-Google-Smtp-Source: AAOMgpfmRHcyRFzj6M75MljGUaDurl1nn1WYBQePLbZPAmBKdLwz84VZNSDIq4t1/Y1Pqbvqq/UAVA== X-Received: by 2002:a24:154c:: with SMTP id 73-v6mr7473437itq.51.1529847448729; Sun, 24 Jun 2018 06:37:28 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r16-v6sm2735754iod.59.2018.06.24.06.37.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 06:37:27 -0700 (PDT) From: Noam Postavsky References: <87y3f5mq07.fsf@gmail.com> Date: Sun, 24 Jun 2018 09:37:26 -0400 In-Reply-To: <87y3f5mq07.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 23 Jun 2018 17:22:48 +0100") Message-ID: <87vaa8pap5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > If the Emacs client was started without an explicit list of buffers to > edit, save-some-buffers is called with t for PRED (save all buffers), > but that was before save-some-buffers-default-predicate existed. > > I don't see any reason why save-some-buffers-default-predicate shouldn't > be respected in server-save-buffers-kill-terminal (of course if ARG is > non-nil, we do pass t so that the previous behaviour remains). > ;; If client is bufferless, emulate a normal Emacs exit > ;; and offer to save all buffers. Otherwise, offer to > ;; save only the buffers belonging to the client. > (save-some-buffers > - arg (if buffers > - (lambda () (memq (current-buffer) buffers)) > - t)) > + arg (and buffers > + (lambda () (memq (current-buffer) buffers)) > + (and arg t))) I think you meant + arg (if buffers + (lambda () (memq (current-buffer) buffers)) + (and arg t)) But I'm not sure if this change makes sense, seeing as save-buffers-kill-emacs also ignores save-some-buffers-default-predicate: (defun save-buffers-kill-emacs (&optional arg) [...] ;; Don't use save-some-buffers-default-predicate, because we want ;; to ask about all the buffers before killing Emacs. (save-some-buffers arg t) From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jun 2018 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152987178125925 (code B ref 31951); Sun, 24 Jun 2018 20:24:01 +0000 Received: (at 31951) by debbugs.gnu.org; 24 Jun 2018 20:23:01 +0000 Received: from localhost ([127.0.0.1]:34130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBXJ-0006k1-3w for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:23:01 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:51233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBXH-0006jm-1v for 31951@debbugs.gnu.org; Sun, 24 Jun 2018 16:22:59 -0400 Received: by mail-wm0-f45.google.com with SMTP id w137-v6so1681858wmw.1 for <31951@debbugs.gnu.org>; Sun, 24 Jun 2018 13:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=fw6ZZrpdzwZ43hfuz4/D0NND6CXKgIl91pCI+YfXBp4=; b=Z8pjJaFDPCRTyLEVueaLd5l9q2Xb6PmDSECInno6akxMmcGWhN18diiHC1VrMS8oVM VU/6Pkx2Iv8iRgJsafRzuJzOCx88X7QOah70PzBzVjWwjqhTTF1tATR9YD47WgmMrt/c 5uO61TuoOdHQ8cwWVICOCayXy0EXilyZlUpi+qyZPB41aMyuE5K+MrBvb0egpuv6Sl26 WBQ4A+4GZPcUvgUGv2jfKYvh+yjCLsR8ZouKoO0PQojpuZluGScBNynyGp98of9Ou+Lp DQ7iOV4N4HHJZnXdmuIV8dJtH09LM58lSx1C6LVdgRDJ8xljNqbUHbk5INlKq4dchFK2 hCMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=fw6ZZrpdzwZ43hfuz4/D0NND6CXKgIl91pCI+YfXBp4=; b=p2bkDCclkuzTrd9sidYeNZS6Ete+vU8/1/KCAtGNxWZzH2DHiIm+LbCKk+xL22sgsW zYscg0CzNOerJrw1Tyv2ZFlWKt5JBbwy1FxH0NcQpxanwhwA3vULstgG+TA0icyBf/Zf n69nuHo+lV36YV0f04jI3m7JGv9gPEIcVIYlFVrrj1sbLWpH26nic/EXZDHOBrUdrvJt 1SiL/AyBiLaJq6pw8cKW1zb8kaeOJTgay8eiJ5O1eSp+UYt4eMS6K/IhP7ompwJ6t+f7 HgRC2gpjGjZK8+EgqwvMb3Bz4cFF3Mv7XXcp2hIM7zLbbm9GLzpyYs/QQW5yBJyRxlGi 0wlQ== X-Gm-Message-State: APt69E1A09yalSiL7miD7NnkB5LhOlNWcGKZRceBsWezgdQrJYOg9pcG hQarHL3DFVsWrXHg4Ol8q0b5IAXn X-Google-Smtp-Source: ADUXVKJJKTbaeHz/u1RNbaP4IKpzxrYlzaH1tRv59YtD6Ywb6kgf86nmaVwG8Q1QhYxcN4PvX+2oxA== X-Received: by 2002:a1c:2350:: with SMTP id j77-v6mr6967796wmj.108.1529871773068; Sun, 24 Jun 2018 13:22:53 -0700 (PDT) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id f188-v6sm1058987wmf.8.2018.06.24.13.22.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 13:22:52 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: <87vaa8pap5.fsf@gmail.com> (Noam Postavsky's message of "Sun, 24 Jun 2018 09:37:26 -0400") References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sun, 24 Jun 2018 21:22:48 +0100 Message-ID: <87muvklysn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Noam Postavsky writes: > Jo=C3=A3o T=C3=A1vora writes: > >> If the Emacs client was started without an explicit list of buffers to >> edit, save-some-buffers is called with t for PRED (save all buffers), >> but that was before save-some-buffers-default-predicate existed. >> >> I don't see any reason why save-some-buffers-default-predicate shouldn't >> be respected in server-save-buffers-kill-terminal (of course if ARG is >> non-nil, we do pass t so that the previous behaviour remains). > I think you meant > > + arg (if buffers > + (lambda () (memq (current-buffer) buffers)) > + (and arg t)) Yes, of course. > But I'm not sure if this change makes sense, seeing as > save-buffers-kill-emacs also ignores > save-some-buffers-default-predicate: > > (defun save-buffers-kill-emacs (&optional arg) > [...] > ;; Don't use save-some-buffers-default-predicate, because we want > ;; to ask about all the buffers before killing Emacs. > (save-some-buffers arg t) Right, but thats because, when killing Emacs, it is really the last chance to save those buffers before they're potentially gone for good. In contrast, almost since server-save-buffers-kill-terminal's inception, it has had a provision for saving only a subset of buffers, by guessing that the user's intention was to edit only the buffers passed to the emacsclient command. This, of course, may very well not be true, but it's a good thing in my opinion. So I think it's natural that it also respects save-some-buffers-default-predicate, which is also designed to loosen these conditions, but doesn't guess, because it requires customization by the user. Alternatively, we could have some save-some-buffers-default-strict-predicate for the PRED=3Dt situation, but I think that's overenginneering it. Of course I'm open to other ideas. How would you make quitting a client terminal not bother you about those pesky ChangeLog buffers? Jo=C3=A3o From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jun 2018 20:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152987317428036 (code B ref 31951); Sun, 24 Jun 2018 20:47:01 +0000 Received: (at 31951) by debbugs.gnu.org; 24 Jun 2018 20:46:14 +0000 Received: from localhost ([127.0.0.1]:34150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBtm-0007I8-Fm for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:46:14 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:42192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBti-0007Ht-Mh for 31951@debbugs.gnu.org; Sun, 24 Jun 2018 16:46:11 -0400 Received: by mail-io0-f177.google.com with SMTP id r24-v6so10593549ioh.9 for <31951@debbugs.gnu.org>; Sun, 24 Jun 2018 13:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=h9pw2mMb3ceWxVnYrQP5rMuaNGCdO9FoicOa3BTvr50=; b=G6628hMlzzygNO57EBvV/hplz3/nns9zxHHXO1XO2MMO2ndHgB56kk0w0q7ZDJa8jR CjGHRgts9ofqgrEgIPsTkHourT1ciD8bkxHEFfYhMZdvnpRzn/IXRxrsqcUImTAySl4U 5NQCAJo76RDcIysnhqmN37loJq6i6XFFFJmrWAamwv/jer3Tkw0rGE7qvmOLFTa4nU+V I9fTm9xQnA1mEcJ4Nef7qW6EnO30VjSUiR13G+/1zOXL98hv75frku4siZ+tPPqSZTD8 R0kgYW1ANmJkEhnPb89IZmmHkqyUgAIAbker9orrj8xs2K8smdU56SknaArA789JsoPL o62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=h9pw2mMb3ceWxVnYrQP5rMuaNGCdO9FoicOa3BTvr50=; b=NI5ZOFoTxg/lEX+l7B0zpnM4srgAEa0GEJ0ATdLfonXipAcI63LJA+hqrIxri5N3vy 8WwuJXSvo8Js0EmjvPkpmQZmeHhwEm7nQaGZp68OVFYk/o9FtyWBmgJSYakP6lwYKjaq 58FlJctMtU3dc8N8LVKuRXV0NjENY3B82IU/a3XddQnW4kERIpEO1JaQlyU4nESqDB+X PdfiDLSZRy4IcfnwhNT0mSGgLmShZRSokh4Z9n5Y8KYYkvcaHMqbARkaHbk+Sz/WmfW3 +UKMjM7tfnr+faRKSchBVXiN4OgKHOJM4plNJRkW9G+DVAMxcB2AGInjNvw1jCFKZnWE w2tA== X-Gm-Message-State: APt69E2VFuqHGpnLPWhvvgY2bmOrz9DK2NrwbIQZh4WhNcd7fRLWv7DG XjesMLRb0ClSsjVkoTmsm+d/Kw== X-Google-Smtp-Source: AAOMgpeEhUVyC3GYb4zHEcrN0wn8SWBPVAIgTIMA+Oe0ehLTw4WewkGRn/wtMdmEwmlcDBlKvRHZjQ== X-Received: by 2002:a5e:c00c:: with SMTP id u12-v6mr7874928iol.264.1529873164985; Sun, 24 Jun 2018 13:46:04 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i10-v6sm3263927itb.38.2018.06.24.13.46.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 13:46:04 -0700 (PDT) From: Noam Postavsky References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> Date: Sun, 24 Jun 2018 16:46:02 -0400 In-Reply-To: <87muvklysn.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 24 Jun 2018 21:22:48 +0100") Message-ID: <87r2kvq5f9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: >> (defun save-buffers-kill-emacs (&optional arg) >> [...] >> ;; Don't use save-some-buffers-default-predicate, because we want >> ;; to ask about all the buffers before killing Emacs. >> (save-some-buffers arg t) > > Right, but thats because, when killing Emacs, it is really the last > chance to save those buffers before they're potentially gone for good. Oh, I got mixed up by the comment in server-save-buffers-kill-terminal: ;; If client is bufferless, emulate a normal Emacs exit ;; and offer to save all buffers. Otherwise, offer to ;; save only the buffers belonging to the client. So I'd say your change is sensible, we should just update that comment to explain the differences in the "emulation". From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jun 2018 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152992485814977 (code B ref 31951); Mon, 25 Jun 2018 11:08:02 +0000 Received: (at 31951) by debbugs.gnu.org; 25 Jun 2018 11:07:38 +0000 Received: from localhost ([127.0.0.1]:34317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXPLN-0003tU-TP for submit@debbugs.gnu.org; Mon, 25 Jun 2018 07:07:38 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXPLM-0003tJ-8I for 31951@debbugs.gnu.org; Mon, 25 Jun 2018 07:07:36 -0400 Received: by mail-wm0-f65.google.com with SMTP id r125-v6so9497395wmg.2 for <31951@debbugs.gnu.org>; Mon, 25 Jun 2018 04:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=YG+LzzBByAZ+upkkjcStE/HUGQSdxjNU+K+DWeWqvik=; b=D55oMxStZzZC5YD5crVicq0Yps4cDbidS5pT7txjLCAXlZ2Qv3MsT3AQVxrbASGeN7 C/ggJfARSoKMG0LV0K0M4JelNzYIcyCUGEpi6fCJcwZav7S+cm6Xz7wMTA85OQooIReD zenK5irU+LF1fj9u+YAqbYrrRbo31rZA2/0nTAXSV361z7N6VPkYroyQ3Sdmw8zS+7Nz DObmsRWXD16rRDFR3ykKUjkRiN5z2VbgAZmK3YIc1jtM9ilLLEOwEBvlHLtqh5kTcbUl eXQEpRH1DGDeDcCvBpYTcQZLVRhJNIo2m1OkmBFESapaaJuYTum5Q3sCsImaPtxMGq4w nomw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YG+LzzBByAZ+upkkjcStE/HUGQSdxjNU+K+DWeWqvik=; b=EXsNtBX5yyBADCNnNnlmAykhP/OiHFoCLFuCGgPtKITHv8auV3wOxA3RFSbxd02Ul1 r758ZUD0ewCx09ZplnFRSwFytCProJizTF/UlLBLdJJQvwMxZJWMvmufhEjrUp808GLf n+yQYhvX/aYBrnLKUv2n7rRtG5TtHuN2MH77oS0+rYa9wVWexE19yFqMIjM9rlbWhDiW nUbvNMhD9YEuUV3o82l8s4DTf/GadXWqjHoOUWX3N1aTVhBzNYnbmcmFKWNXdgMBp5UJ MoNjIvDleJS9qjDYzNtpPcu3/fUG3uwGIhIKCTkMai8m+WcW8CPdKQnFkWtRITgPa4/X dIag== X-Gm-Message-State: APt69E19MhYrEN5bdgOHk2p54o0U/ILvAFa69iV1IyJUZKk22XrJOuQq jspnMOne7JyJJD/+XNBt6qNr7stx X-Google-Smtp-Source: AAOMgpdR+EmKZMRb1ftXwTjKcWmEK/BSLKoXHNWqA7Ehf+tLENOReOCLgz4UhuhvyimY1zAdU6cg/w== X-Received: by 2002:a1c:c44c:: with SMTP id u73-v6mr597405wmf.99.1529924850274; Mon, 25 Jun 2018 04:07:30 -0700 (PDT) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id j131-v6sm17508627wmg.24.2018.06.25.04.07.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 04:07:29 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> <87r2kvq5f9.fsf@gmail.com> Date: Mon, 25 Jun 2018 12:07:26 +0100 In-Reply-To: <87r2kvq5f9.fsf@gmail.com> (Noam Postavsky's message of "Sun, 24 Jun 2018 16:46:02 -0400") Message-ID: <8736xbm8ep.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Noam Postavsky writes: > Jo=C3=A3o T=C3=A1vora writes: > >>> (defun save-buffers-kill-emacs (&optional arg) >>> [...] >>> ;; Don't use save-some-buffers-default-predicate, because we want >>> ;; to ask about all the buffers before killing Emacs. >>> (save-some-buffers arg t) >> >> Right, but thats because, when killing Emacs, it is really the last >> chance to save those buffers before they're potentially gone for good. > > Oh, I got mixed up by the comment in server-save-buffers-kill-terminal: > > ;; If client is bufferless, emulate a normal Emacs exit > ;; and offer to save all buffers. Otherwise, offer to > ;; save only the buffers belonging to the client. > > So I'd say your change is sensible, we should just update that comment > to explain the differences in the "emulation". Hmmmm OK, what about: diff --git a/lisp/server.el b/lisp/server.el index ff03cbe622..33e88409ca 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1666,13 +1666,16 @@ server-save-buffers-kill-terminal (save-buffers-kill-emacs arg))) ((processp proc) (let ((buffers (process-get proc 'buffers))) - ;; If client is bufferless, emulate a normal Emacs exit - ;; and offer to save all buffers. Otherwise, offer to - ;; save only the buffers belonging to the client. + ;; If the client has buffers, offer to save only those + ;; buffers. Otherwise, this is similar to a normal Emacs + ;; exit (where we offer to save all buffers) with the + ;; exception that, if ARG is nil, then passing nil as the + ;; PRED argument to `save-some-buffers' ensures + ;; `save-some-buffers-default-predicate' is respected. (save-some-buffers arg (if buffers (lambda () (memq (current-buffer) buffers)) - t)) + (and arg t))) (server-delete-client proc))) (t (error "Invalid client frame"))))) I tried to make it terser, but couldn't. If the indentation looks off, it's not, it's because I untabified the changed regions. If nobody complains I'll push this in a few days' time. Jo=C3=A3o From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jun 2018 01:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152997803513500 (code B ref 31951); Tue, 26 Jun 2018 01:54:01 +0000 Received: (at 31951) by debbugs.gnu.org; 26 Jun 2018 01:53:55 +0000 Received: from localhost ([127.0.0.1]:35500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXdB5-0003Vf-EY for submit@debbugs.gnu.org; Mon, 25 Jun 2018 21:53:55 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:54138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXdB3-0003VT-JZ for 31951@debbugs.gnu.org; Mon, 25 Jun 2018 21:53:53 -0400 Received: by mail-it0-f47.google.com with SMTP id a195-v6so15327972itd.3 for <31951@debbugs.gnu.org>; Mon, 25 Jun 2018 18:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rpLicB+bS+yVvBQPBFkj+HnV2d7WMmbbcQbxyrIlPnU=; b=q4ycEBTOHBdZrC7ZOjpvIrQ/uy6m5c21YkSFCfv8g65ElbZw9DHCxXwTKjhB3UYX0P ayHZDXpx3e3ImGA3cs/bEgd7U8qz5WJAHg2ugPpjgXEYYu4v2ruUR9eUIWthGfIilJl1 Li1Bt1kjM5+IL3A/isoeuNvjtXofRlzf5rvmRnIK5nMzv0PkQQWz10OKALoccXzQaXV7 rWld7AOUkcw0tNHMZwOpLi1xxxOIxolYFq/RhyJf4rDWklCazjSZ3zEP+FAYpmv5/E3N N5clV6blka15sFJtU7Vbj08A20XZyFGQg3cYQAZ/yQnZEse2wOoh6r73uraaUTAdweQW PN7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rpLicB+bS+yVvBQPBFkj+HnV2d7WMmbbcQbxyrIlPnU=; b=iPdcwIU/+rJ9yjS+3ixnR3EBbwzJISWiDjgxG179mqBspfMlzWujaiQBREPjMrpL1H ox+Qwg8gNBStDUEKwIUEu0lYizH/f0oI6ukR0Ft+3LOpQnX9+xJbi20Hr+HpepJkFE8V OCBrr9J0tc9YJ6tR4pYZmup0ATCviUzv0H+x6jEJKoP8+PaooCtoVoAj6NbSMb5dYhIl FgyE8v3zyNrqpUfUJ3nbt116048oGsnVyLam4WvFgWG0uPvehwYbLGjak6m4LVpKl1h0 SCNr2kaKjdLv5Gge7OKSIfuE2z6jf8PIAXSgk9z1bFvYsEO+jTkrTSJ4qjLfzSsjWhmB cn1A== X-Gm-Message-State: APt69E2aXTqeaE4efNq0TRfsoIl05JowfYyE/xq3vfh7lEQl15KECalb GynSBrM4kGGKOyRz2kZUHErpNA== X-Google-Smtp-Source: ADUXVKJ7U8Rh1RApyuy4sQrvmozqHLGsF55s7KfL+0iLl4PawuLZ2RJ3bPmw+zGYz9woVjg7yPW8WQ== X-Received: by 2002:a24:cb83:: with SMTP id u125-v6mr2932632itg.76.1529978027942; Mon, 25 Jun 2018 18:53:47 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k71-v6sm434410itk.2.2018.06.25.18.53.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 18:53:47 -0700 (PDT) From: Noam Postavsky References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> <87r2kvq5f9.fsf@gmail.com> <8736xbm8ep.fsf@gmail.com> Date: Mon, 25 Jun 2018 21:53:45 -0400 In-Reply-To: <8736xbm8ep.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 25 Jun 2018 12:07:26 +0100") Message-ID: <87d0wepb2u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I tried to make it terser, but couldn't. Hmm, maybe just concentrate on the save-some-buffers-default-predicate thing. I think the original comment pretty much redundantly repeats what the doc string (and the code itself) say. --- i/lisp/server.el +++ w/lisp/server.el @@ -1639,13 +1639,15 @@ server-save-buffers-kill-terminal (save-buffers-kill-emacs arg))) ((processp proc) (let ((buffers (process-get proc 'buffers))) - ;; If client is bufferless, emulate a normal Emacs exit - ;; and offer to save all buffers. Otherwise, offer to - ;; save only the buffers belonging to the client. (save-some-buffers arg (if buffers - (lambda () (memq (current-buffer) buffers)) - t)) + ;; Only files from emacsclient file list. + (lambda () (memq (current-buffer) buffers)) + ;; No emacsclient file list: don't override + ;; `save-some-buffers-default-predicate' (unless + ;; ARGS is non-nil), since we're not killing + ;; Emacs (unlike `save-buffers-kill-emacs'). + (and arg t))) (server-delete-client proc))) (t (error "Invalid client frame"))))) =20 From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jun 2018 19:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.15300412583229 (code B ref 31951); Tue, 26 Jun 2018 19:28:01 +0000 Received: (at 31951) by debbugs.gnu.org; 26 Jun 2018 19:27:38 +0000 Received: from localhost ([127.0.0.1]:36528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXtco-0000q1-79 for submit@debbugs.gnu.org; Tue, 26 Jun 2018 15:27:38 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:37774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXtcm-0000po-Ce for 31951@debbugs.gnu.org; Tue, 26 Jun 2018 15:27:36 -0400 Received: by mail-wr0-f181.google.com with SMTP id k6-v6so18354434wrp.4 for <31951@debbugs.gnu.org>; Tue, 26 Jun 2018 12:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=icpGjMEkIes5hU4kQ5+61BHYGTUmzxiCJ4PJRZHmnJI=; b=X1of3I2GN8wcEpSEk8WjUpzeQslbEEI1XagQA8LEkdu5y5pYxamR84ZmuKr6pPihhu EXZiibA7aDN22l2uszVP+XP2nZYqU49evkWWfB6Aa9pe6UYJt3GdEhUJTQzp9ksiBWbA YbJzmiNSPIGkQQMnvP+gFOZWn7NdWXjwgLcOtLm1ISqryerkRgSPpZNkS9binkRU5T2p OsqHtNRMBAERneUH4cQWH/pSQfo3Kqf6wcCcsXb/+t818eTjX/vwl3EElGkJRgvOrhmc VivWkF0Hqtbg923aaOT2z7K+lv/XfEj8SBRnZFkr6A7AH6VlhN8MfR/6cI4caUXJecBy m/8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=icpGjMEkIes5hU4kQ5+61BHYGTUmzxiCJ4PJRZHmnJI=; b=nC0SfLjG0R/4av2x5h/QYmpamV6kA97kH/v9Bi1zWB7iqBZvHyCOz74qxu29AV0YGa tZaAkSOX4rXVkH6X1/OJ4+HcaxQ6AWTxnbp4oU57ogE3Q6QTuL2llqK0KiVJzW5J3mZx D60Xzlu7+ovgEP4TCwn6gWR1gUtIiEVPB+U3Kwl/HuLfv+i0AeRFNTaHy2qn7a8rgxKv pBc1JeTJ31RNmm4uDGITAtL4+WoRLT7BnK4kQk+98rwyNJMdKdIrJvlpEU55VUxvXa4m uxtUawlW5MbzhOLLzkBJVj32kVWehS4iCbsq8CFtoOeRP9pgEQ6TSijbVG/9L6Rj75Jc MDOQ== X-Gm-Message-State: APt69E3Z4HdUtqD9GgxyRUxjm7Qs7NsVGDvHTdZNkB1WxwUob3Bt3E5U p/2dC9RTGek8ppBd0aK5PliJMbLR X-Google-Smtp-Source: AAOMgpd3iTOqpi2VaL5sbGIiblrrBGu/fI4YbrB3p4wH7y75PEwsvdQhtd92Q+AHKf5vgv33Lk/ctw== X-Received: by 2002:adf:e644:: with SMTP id b4-v6mr2726756wrn.254.1530041250225; Tue, 26 Jun 2018 12:27:30 -0700 (PDT) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id m3-v6sm1173214wro.27.2018.06.26.12.27.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Jun 2018 12:27:29 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> <87r2kvq5f9.fsf@gmail.com> <8736xbm8ep.fsf@gmail.com> <87d0wepb2u.fsf@gmail.com> Date: Tue, 26 Jun 2018 20:27:26 +0100 In-Reply-To: <87d0wepb2u.fsf@gmail.com> (Noam Postavsky's message of "Mon, 25 Jun 2018 21:53:45 -0400") Message-ID: <87d0wdmjq9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Noam Postavsky writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I tried to make it terser, but couldn't. > > Hmm, maybe just concentrate on the save-some-buffers-default-predicate > thing. I think the original comment pretty much redundantly repeats > what the doc string (and the code itself) say. Heh, I don't think your version is much better (or much worse). But since I'm a fan of sharing responsibility, let's go with yours :-) Jo=C3=A3o From unknown Sat Aug 16 12:44:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jun 2018 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 31951-done@debbugs.gnu.org, 31951@debbugs.gnu.org Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.153010566926925 (code B ref 31951); Wed, 27 Jun 2018 13:22:01 +0000 Received: (at 31951) by debbugs.gnu.org; 27 Jun 2018 13:21:09 +0000 Received: from localhost ([127.0.0.1]:36971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYANg-000708-Ql for submit@debbugs.gnu.org; Wed, 27 Jun 2018 09:21:09 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:52965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYANc-0006zD-P5; Wed, 27 Jun 2018 09:21:05 -0400 Received: by mail-wm0-f52.google.com with SMTP id e69-v6so2886505wme.2; Wed, 27 Jun 2018 06:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2AOZCDPPe8Rq+Q5EXpRxCcZA/7P7ROmvXSeqDXcQO5A=; b=CEGT72yD9b1y167QA9HLC0ed4bnHG4cTnGyy34dOLOwXxKC4Si1judJT98PZdlhVL8 hTMRKArRzbnd+W/Bgj5w4jg2JyqoYsppue3Qrzs0pzO+v3lWnZmCuPc3kqq+23OZWEEf +tpcAWnzk2vWYYEeheqRTPGVPFAZEk2RfVtYhTo2Em4hUx33GEXV56VekyE+7becrIdC eZLB+brd1Fdho45DNC7Waz60ZPHh876CyAYpYjTJhCo1QJKnGoy3Qj9Pu7SHSGVv/aJU SVCg0c37s1YzECtHaq2mR/635xO2xw+fy5e3mEh0Ho15ZtjQMfmPNN9tbRSD1+2hh1mj gRLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2AOZCDPPe8Rq+Q5EXpRxCcZA/7P7ROmvXSeqDXcQO5A=; b=WXcvvCds+0mN4pF8DQbENYvaqzjDnx42U26ZwiK9HHU7uCyhO6PpH47e8ASPUeuY7y o/MDENjB12KGN1SZfwdIruE/QV41zPx8tDxIPWmorf9BCBUGO9OShbD3NQSuNb3hu7/l Ll/Q8QSDVOs9MNhx6rGZFAiJnU4vWqwghBDtTRzfU4c1womnGZSxnLJ6FhJpzyO5pNGE ZHhw6k3lBGANSi+CIWOKYggyP5l5eOyPu7Aci67jHF+Arb+K2SqTlhLlkv1yFLoCfXxs SSM2Rd+Dxi/fk2ytui9ZX5SHu0XnSZci8We4U7JJTGo3WyB721VzNqTbE1AZhCOylKu/ xE4A== X-Gm-Message-State: APt69E0NVa2fmgDru7pYg0WjJHvpfMG5lAI0Ies1iUgx4DxmSosr0kH3 e64/TUMmUy0z2Q4J1z/R0rC2JVBa1lE= X-Google-Smtp-Source: AAOMgpc8FzFGf1CNJ6LouPUF5xcJIFK7TDRIP2TX1lz/Ye4TEkmrpr87xo19pBhhXj0k1PpzBh1hjg== X-Received: by 2002:a1c:c8:: with SMTP id 191-v6mr4882846wma.115.1530105658632; Wed, 27 Jun 2018 06:20:58 -0700 (PDT) Received: from lolita.yourcompany.com ([194.117.2.109]) by smtp.gmail.com with ESMTPSA id e188-v6sm15965924wmf.21.2018.06.27.06.20.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 06:20:57 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> <87r2kvq5f9.fsf@gmail.com> <8736xbm8ep.fsf@gmail.com> <87d0wepb2u.fsf@gmail.com> Date: Wed, 27 Jun 2018 14:20:54 +0100 In-Reply-To: <87d0wepb2u.fsf@gmail.com> (Noam Postavsky's message of "Mon, 25 Jun 2018 21:53:45 -0400") Message-ID: <87r2ksl615.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Noam Postavsky writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I tried to make it terser, but couldn't. > > Hmm, maybe just concentrate on the save-some-buffers-default-predicate > thing. I think the original comment pretty much redundantly repeats > what the doc string (and the code itself) say. > > --- i/lisp/server.el > +++ w/lisp/server.el > @@ -1639,13 +1639,15 @@ server-save-buffers-kill-terminal > (save-buffers-kill-emacs arg))) > ((processp proc) > (let ((buffers (process-get proc 'buffers))) > - ;; If client is bufferless, emulate a normal Emacs exit > - ;; and offer to save all buffers. Otherwise, offer to > - ;; save only the buffers belonging to the client. > (save-some-buffers > arg (if buffers > - (lambda () (memq (current-buffer) buffers)) > - t)) > + ;; Only files from emacsclient file list. > + (lambda () (memq (current-buffer) buffers)) > + ;; No emacsclient file list: don't override > + ;; `save-some-buffers-default-predicate' (unless > + ;; ARGS is non-nil), since we're not killing > + ;; Emacs (unlike `save-buffers-kill-emacs'). > + (and arg t))) > (server-delete-client proc))) > (t (error "Invalid client frame"))))) >=20=20 Pushed as ce54573dacaeb234ac006b71cbaafe1c543515f1. Thanks, Jo=C3=A3o From unknown Sat Aug 16 12:44:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Subject: bug#31951: closed (Re: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate) Message-ID: References: <87r2ksl615.fsf@gmail.com> <87y3f5mq07.fsf@gmail.com> X-Gnu-PR-Message: they-closed 31951 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 31951@debbugs.gnu.org Date: Wed, 27 Jun 2018 13:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1530105722-26996-1" This is a multi-part message in MIME format... ------------=_1530105722-26996-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect s= ave-some-buffers-default-predicate which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31951@debbugs.gnu.org. --=20 31951: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31951 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1530105722-26996-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31951-done) by debbugs.gnu.org; 27 Jun 2018 13:21:08 +0000 Received: from localhost ([127.0.0.1]:36969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYANg-000706-Fu for submit@debbugs.gnu.org; Wed, 27 Jun 2018 09:21:08 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:52965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYANc-0006zD-P5; Wed, 27 Jun 2018 09:21:05 -0400 Received: by mail-wm0-f52.google.com with SMTP id e69-v6so2886505wme.2; Wed, 27 Jun 2018 06:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2AOZCDPPe8Rq+Q5EXpRxCcZA/7P7ROmvXSeqDXcQO5A=; b=CEGT72yD9b1y167QA9HLC0ed4bnHG4cTnGyy34dOLOwXxKC4Si1judJT98PZdlhVL8 hTMRKArRzbnd+W/Bgj5w4jg2JyqoYsppue3Qrzs0pzO+v3lWnZmCuPc3kqq+23OZWEEf +tpcAWnzk2vWYYEeheqRTPGVPFAZEk2RfVtYhTo2Em4hUx33GEXV56VekyE+7becrIdC eZLB+brd1Fdho45DNC7Waz60ZPHh876CyAYpYjTJhCo1QJKnGoy3Qj9Pu7SHSGVv/aJU SVCg0c37s1YzECtHaq2mR/635xO2xw+fy5e3mEh0Ho15ZtjQMfmPNN9tbRSD1+2hh1mj gRLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2AOZCDPPe8Rq+Q5EXpRxCcZA/7P7ROmvXSeqDXcQO5A=; b=WXcvvCds+0mN4pF8DQbENYvaqzjDnx42U26ZwiK9HHU7uCyhO6PpH47e8ASPUeuY7y o/MDENjB12KGN1SZfwdIruE/QV41zPx8tDxIPWmorf9BCBUGO9OShbD3NQSuNb3hu7/l Ll/Q8QSDVOs9MNhx6rGZFAiJnU4vWqwghBDtTRzfU4c1womnGZSxnLJ6FhJpzyO5pNGE ZHhw6k3lBGANSi+CIWOKYggyP5l5eOyPu7Aci67jHF+Arb+K2SqTlhLlkv1yFLoCfXxs SSM2Rd+Dxi/fk2ytui9ZX5SHu0XnSZci8We4U7JJTGo3WyB721VzNqTbE1AZhCOylKu/ xE4A== X-Gm-Message-State: APt69E0NVa2fmgDru7pYg0WjJHvpfMG5lAI0Ies1iUgx4DxmSosr0kH3 e64/TUMmUy0z2Q4J1z/R0rC2JVBa1lE= X-Google-Smtp-Source: AAOMgpc8FzFGf1CNJ6LouPUF5xcJIFK7TDRIP2TX1lz/Ye4TEkmrpr87xo19pBhhXj0k1PpzBh1hjg== X-Received: by 2002:a1c:c8:: with SMTP id 191-v6mr4882846wma.115.1530105658632; Wed, 27 Jun 2018 06:20:58 -0700 (PDT) Received: from lolita.yourcompany.com ([194.117.2.109]) by smtp.gmail.com with ESMTPSA id e188-v6sm15965924wmf.21.2018.06.27.06.20.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 06:20:57 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Noam Postavsky Subject: Re: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> <87r2kvq5f9.fsf@gmail.com> <8736xbm8ep.fsf@gmail.com> <87d0wepb2u.fsf@gmail.com> Date: Wed, 27 Jun 2018 14:20:54 +0100 In-Reply-To: <87d0wepb2u.fsf@gmail.com> (Noam Postavsky's message of "Mon, 25 Jun 2018 21:53:45 -0400") Message-ID: <87r2ksl615.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 31951-done Cc: 31951-done@debbugs.gnu.org, 31951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Noam Postavsky writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I tried to make it terser, but couldn't. > > Hmm, maybe just concentrate on the save-some-buffers-default-predicate > thing. I think the original comment pretty much redundantly repeats > what the doc string (and the code itself) say. > > --- i/lisp/server.el > +++ w/lisp/server.el > @@ -1639,13 +1639,15 @@ server-save-buffers-kill-terminal > (save-buffers-kill-emacs arg))) > ((processp proc) > (let ((buffers (process-get proc 'buffers))) > - ;; If client is bufferless, emulate a normal Emacs exit > - ;; and offer to save all buffers. Otherwise, offer to > - ;; save only the buffers belonging to the client. > (save-some-buffers > arg (if buffers > - (lambda () (memq (current-buffer) buffers)) > - t)) > + ;; Only files from emacsclient file list. > + (lambda () (memq (current-buffer) buffers)) > + ;; No emacsclient file list: don't override > + ;; `save-some-buffers-default-predicate' (unless > + ;; ARGS is non-nil), since we're not killing > + ;; Emacs (unlike `save-buffers-kill-emacs'). > + (and arg t))) > (server-delete-client proc))) > (t (error "Invalid client frame"))))) >=20=20 Pushed as ce54573dacaeb234ac006b71cbaafe1c543515f1. Thanks, Jo=C3=A3o ------------=_1530105722-26996-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Jun 2018 16:23:06 +0000 Received: from localhost ([127.0.0.1]:33376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWlJa-0001Ah-8m for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:23:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWlJY-00019z-Hi for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWlJS-0001vP-D2 for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:22:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, FROM_EXCESS_BASE64,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWlJS-0001vF-97 for submit@debbugs.gnu.org; Sat, 23 Jun 2018 12:22:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWlJR-0005mE-7L for bug-gnu-emacs@gnu.org; Sat, 23 Jun 2018 12:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWlJO-0001uP-38 for bug-gnu-emacs@gnu.org; Sat, 23 Jun 2018 12:22:57 -0400 Received: from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]:44203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWlJN-0001u1-SP for bug-gnu-emacs@gnu.org; Sat, 23 Jun 2018 12:22:54 -0400 Received: by mail-wr0-x234.google.com with SMTP id p12-v6so7855619wrn.11 for ; Sat, 23 Jun 2018 09:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=3CMVUxTn+gYAW/kzudBdwSSywucS6DaA7rwDXkD2SxA=; b=ZIN8ESh3Goy2/X0VugRtsHB0PWnKVSNedzM7rACkfuZtTjoYd69r6LRcCQFbQf+xY8 NRaBm9nOmhPGRc0RXLwTEacyc89n2X3VVTihzOwICqgWSlbQ2ap9C0wcg0yiIFMhRyVf D84xvJp0Y4BqM0ncU6twymdVYSSQPhg9m55u4MK/fR+IQqPgXI/h7p7ftuCYYQCRuIQl mSs+lJqkVZa20XPEMKhTS5zB+dFukhdwqvzmXNxrXsKFJGvk0unEv7TpEI9qB4Dncexz Mg8ZVbF+79hL/yQVI4e1z2kFtNRvWvoqy0H+9K5BIO26O0ZoB2BoIpEDwAQdYkewBNPJ xNTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=3CMVUxTn+gYAW/kzudBdwSSywucS6DaA7rwDXkD2SxA=; b=EK/Q9T0KIOfQ8EVcCfS7aaNpNedRRvy+wdrQsjTZWQKBzopmPed4Ya0VqEebjm2Ohi ORAsxy66JAit7f6s3YTZm2sFQMT3FBHyTEXpXla8egzwrAa2Fc7V8MSEHM3rjQLP+tHN 5ZKKkgZ7QV4Kly0fsPvOoo+cg+sLqOyjU9tiWc7th0XZzm29Vg9X6Fv1nqwI0aqxVxV1 I0OxTo70I9aEQGo5P186Uzc7Sof3/YCcLozZuTsDuC9+A26XtWR1I0NRSqWBIkBEp3SE R28ZrZvEM7VYotV0FpmMB+UWj6sOg/20BDOWYSKReCLei19PEkxtwAIxlI932PDUOFmD yplw== X-Gm-Message-State: APt69E3vU+/RTWxI9maqG4i2OsCi2sMYX1EJPr55jfT64novFPTs/59s YSQQqwI0eYxH9ZHfyKjbMSZfvuBs X-Google-Smtp-Source: AAOMgpf0CoVN0qiOptPYJTs9Rmqs13PZj//KKukYCABFtGT8JoKzC7M1AcSIKdcOuXkJb3jaqcaKNQ== X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr1366787wri.146.1529770972086; Sat, 23 Jun 2018 09:22:52 -0700 (PDT) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id f24-v6sm3180675wmc.0.2018.06.23.09.22.51 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jun 2018 09:22:51 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: bug-gnu-emacs@gnu.org Subject: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Date: Sat, 23 Jun 2018 17:22:48 +0100 Message-ID: <87y3f5mq07.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.9 (----) Hi, If the Emacs client was started without an explicit list of buffers to edit, save-some-buffers is called with t for PRED (save all buffers), but that was before save-some-buffers-default-predicate existed. I don't see any reason why save-some-buffers-default-predicate shouldn't be respected in server-save-buffers-kill-terminal (of course if ARG is non-nil, we do pass t so that the previous behaviour remains). Trivial patch attached, Jo=C3=A3o diff --git a/lisp/server.el b/lisp/server.el index ff03cbe622..ac14ef314e 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1670,9 +1670,9 @@ server-save-buffers-kill-terminal ;; and offer to save all buffers. Otherwise, offer to ;; save only the buffers belonging to the client. (save-some-buffers - arg (if buffers - (lambda () (memq (current-buffer) buffers)) - t)) + arg (and buffers + (lambda () (memq (current-buffer) buffers)) + (and arg t))) (server-delete-client proc))) (t (error "Invalid client frame"))))) ------------=_1530105722-26996-1--