GNU bug report logs - #31948
26.1; smie-indent-forward-token forward-sexp in strings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31948 in the body.
You can then email your comments to 31948 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; smie-indent-forward-token forward-sexp in strings
Date: Sat, 23 Jun 2018 21:22:32 +0800

smie-indent-forward-token appears unpredictable because sometimes it
errs with (scan-error "Unbalanced parentheses" 32 33) sometimes not.

I dug a bit deeper and found the following behaviour that might be
questionable.

For example, in a ruby-mode buffer with the following content, place
point inside the first "", and M-: (smie-indent-forward-token). Point
moves to the subsequent "" no matter how far away the second "" is.

-------- buffer content --------
"",
beg do
end
abc,
abc,
abc,
""
--------------------------------

Is this a bug?

Leo

Message #8 received at 31948 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 31948 <at> debbugs.gnu.org
Subject: Re: bug#31948: 26.1; smie-indent-forward-token forward-sexp in strings
Date: Sat, 23 Jun 2018 14:15:33 -0400

> For example, in a ruby-mode buffer with the following content, place
> point inside the first "", and M-: (smie-indent-forward-token). Point
> moves to the subsequent "" no matter how far away the second "" is.
>
> -------- buffer content --------
> "",
> beg do
> end
> abc,
> abc,
> abc,
> ""
> --------------------------------
>
> Is this a bug?

It doesn't look like a bug, in the sense that smie-indent-forward-token
should be able to assume it's called from a position outside of
a string/comment.

IOW I'd tend to put the blame on the code that calls this function.


        Stefan

Message #11 received at 31948 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 31948 <at> debbugs.gnu.org
Subject: Re: bug#31948: 26.1; smie-indent-forward-token forward-sexp in strings
Date: Sun, 24 Jun 2018 16:23:23 +0800

On 2018-06-23 14:15 -0400, Stefan Monnier wrote:
> It doesn't look like a bug, in the sense that smie-indent-forward-token
> should be able to assume it's called from a position outside of
> a string/comment.
>
> IOW I'd tend to put the blame on the code that calls this function.

I remember reading something along these lines but cannot find it. Is
this documented somewhere? If not should it be documented?

Leo

Message #14 received at 31948 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 31948 <at> debbugs.gnu.org
Subject: Re: bug#31948: 26.1; smie-indent-forward-token forward-sexp in strings
Date: Sun, 24 Jun 2018 09:39:40 -0400

>> It doesn't look like a bug, in the sense that smie-indent-forward-token
>> should be able to assume it's called from a position outside of
>> a string/comment.
>> IOW I'd tend to put the blame on the code that calls this function.
> I remember reading something along these lines but cannot find it.

I don't think it's clearly documented.

> If not should it be documented?

You could try and clarify that the starting point is expected to be
*between* tokens (tho that could also be interpreted to include being
in the middle of a comment).


        Stefan

Message #17 received at 31948 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 31948 <at> debbugs.gnu.org, Leo Liu <sdl.web <at> gmail.com>
Subject: Re: bug#31948: 26.1; smie-indent-forward-token forward-sexp in strings
Date: Thu, 12 Aug 2021 15:40:07 +0200

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> If not should it be documented?
>
> You could try and clarify that the starting point is expected to be
> *between* tokens (tho that could also be interpreted to include being
> in the middle of a comment).

I've now basically copied that sentence to the doc string in Emacs 28,
and I'm therefore closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.