GNU bug report logs - #31942
[PATCH] pack: Fix guix pack -f docker.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#31942: closed (Re: [bug#31942] [PATCH] pack: Fix guix pack -f
 docker.)
Date: Sun, 24 Jun 2018 08:27:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#31942: [PATCH] pack: Fix guix pack -f docker.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 31942 <at> debbugs.gnu.org.

-- 
31942: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31942
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31942-done <at> debbugs.gnu.org
Subject: Re: [bug#31942] [PATCH] pack: Fix guix pack -f docker.
Date: Sun, 24 Jun 2018 09:26:06 +0100

[Message part 3 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Chris!
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Without this change, running guix pack fails as (guix sets) is missing when
>> compiling (guix build store-copy).
>>
>> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
>> the source-module-closure call.
>
> Good catch, got for it!

Great, I've pushed this now.

Note that the squashfs format looks to be similarly broken, but not
quite as simple to fix.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] pack: Fix guix pack -f docker.
Date: Fri, 22 Jun 2018 22:46:37 +0100

Without this change, running guix pack fails as (guix sets) is missing when
compiling (guix build store-copy).

* guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
the source-module-closure call.
---
 guix/scripts/pack.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index ed876b259..443d199be 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -364,9 +364,9 @@ the image."
   (define build
     ;; Guile-JSON is required by (guix docker).
     (with-extensions (list json)
-      (with-imported-modules `(,@(source-module-closure '((guix docker))
+      (with-imported-modules `(,@(source-module-closure '((guix docker)
+                                                          (guix build store-copy))
                                                         #:select? not-config?)
-                               (guix build store-copy)
                                ((guix config) => ,config))
         #~(begin
             (use-modules (guix docker) (srfi srfi-19) (guix build store-copy))
-- 
2.17.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.