GNU bug report logs - #31941
26.1; Moving directory on remote host via tramp scp always performs copy

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31941: closed (26.1; Moving directory on remote host via
 tramp scp always performs copy)
Date: Mon, 25 Jun 2018 06:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 25 Jun 2018 08:43:17 +0200
with message-id <876027v01m.fsf <at> gmx.de>
and subject line Re: bug#31941: 26.1; Moving directory on remote host via tramp scp always performs copy
has caused the debbugs.gnu.org bug report #31941,
regarding 26.1; Moving directory on remote host via tramp scp always performs copy
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31941: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31941
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stephen Nutt <stnutt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1;
 Moving directory on remote host via tramp scp always performs copy
Date: Fri, 22 Jun 2018 14:33:50 -0500

In Emacs 26, when moving a directory within a remote host over Tramp
using the scp method (e.g. with dired-do-rename or mv in eshell), a copy
and delete are always performed, even when a much simpler mv would
suffice. The behavior is the same when running emacs with -q or with
emacs built from master. This is a regression from the behavior in 25.3.

I think I've isolated the change to the commit b500e0 where the
following was added at the beginning of `tramp-do-copy-or-rename-file'
in tramp-sh.el to explicitly call `copy-directory'.

  (if (file-directory-p filename)
      (progn
	(copy-directory filename newname keep-date t)
	(when (eq op 'rename) (delete-directory filename 'recursive)))

I think the conditional should also check if op is a rename and if the
remote of filename and newname are the same, in which case the normal
behavior of the function should proceed which should result in a mv
command.

[Message part 3 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stephen Nutt <stnutt <at> gmail.com>
Cc: 31941-done <at> debbugs.gnu.org
Subject: Re: bug#31941: 26.1;
 Moving directory on remote host via tramp scp always performs copy
Date: Mon, 25 Jun 2018 08:43:17 +0200

Version: 26.2

Stephen Nutt <stnutt <at> gmail.com> writes:

>> The patch is appended, pls check whether it works for you.
>
> The patch fixes it. Thanks.

Thanks for the feedback, I'm closing the bug.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.