From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Jun 2018 12:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 31934@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1529671187809 (code B ref -1); Fri, 22 Jun 2018 12:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jun 2018 12:39:47 +0000 Received: from localhost ([127.0.0.1]:59741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLLv-0000Cy-3M for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLLu-0000Ch-9T for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWLLo-0000hJ-3Q for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWLLn-0000hF-VQ for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWLLm-00059T-Ne for guix-patches@gnu.org; Fri, 22 Jun 2018 08:39:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWLLj-0000g3-J0 for guix-patches@gnu.org; Fri, 22 Jun 2018 08:39:38 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:48128) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWLLj-0000fm-88 for guix-patches@gnu.org; Fri, 22 Jun 2018 08:39:35 -0400 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id bff16b08 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Fri, 22 Jun 2018 12:39:47 +0000 (UTC) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_bb5a26b59575247e5c87ce22f8328432" Date: Fri, 22 Jun 2018 14:39:33 +0200 From: Julien Lepiller Message-ID: X-Sender: julien@lepiller.eu User-Agent: Roundcube Webmail/1.3.6 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=_bb5a26b59575247e5c87ce22f8328432 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, this patch fixes an issue with the patch for alsa-lib and defines a search-path rather than a native-search-path. In order to make the alsa-service work properly, you still need to have alsa-lib and alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR to $PROFILE/lib/alsa-lib. --=_bb5a26b59575247e5c87ce22f8328432 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch Content-Disposition: attachment; filename=0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch; size=3159 RnJvbSBjNjM4NjdlYjUxZjE0NjQyMDdkZTk1MGRlNGQ4Mzk0OTcxYzdlYzVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gTGVwaWxsZXIgPGp1bGllbkBsZXBpbGxlci5ldT4K RGF0ZTogRnJpLCAyMiBKdW4gMjAxOCAxMzo1MjoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogYWxzYS1saWI6IEZpeCBBTFNBX1BMVUdJTl9ESVIgdXNhZ2UuCgoqIGdudS9wYWNrYWdlcy9s aW51eC5zY20gKG5hdGl2ZS1zZWFyY2gtcGF0aHMpOiBVc2Ugc2VhcmNoLXBhdGhzCmluc3RlYWQu CiogZ251L3BhY2thZ2VzL3BhdGNoZXMvYWxzYS1saWItYWRkLWVudmlyb25tZW50LXZhcmlhYmxl LnBhdGNoOiBVc2UKY29tcHV0ZWQgcGx1Z2RpciBpbnN0ZWFkIG9mIGRlZmF1bHQgQUxTQV9QTFVH SU5fRElSLgotLS0KIGdudS9wYWNrYWdlcy9saW51eC5zY20gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAyICstCiAuLi4vcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52aXJvbm1lbnQtdmFy aWFibGUucGF0Y2ggfCAyMSArKysrKysrKysrKysrKy0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTUgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2Fn ZXMvbGludXguc2NtIGIvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQppbmRleCA3ZTgxZjYzODcuLmI4 NmRmZGY4MCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQorKysgYi9nbnUvcGFj a2FnZXMvbGludXguc2NtCkBAIC05ODMsNyArOTgzLDcgQEAgaW50ZXJjZXB0IGFuZCBwcmludCB0 aGUgc3lzdGVtIGNhbGxzIGV4ZWN1dGVkIGJ5IHRoZSBwcm9ncmFtLiIpCiAgICAgICAgICAgICAg ICAiMDk2cHdybmhqMzZ5bmRsZHZzMnBqNHI4NzF6aGNnaXNrczBpczc4ZjFqa2puOXNkNGIyeiIp KQogICAgICAgICAgICAgIChwYXRjaGVzIChzZWFyY2gtcGF0Y2hlcyAiYWxzYS1saWItYWRkLWVu dmlyb25tZW50LXZhcmlhYmxlLnBhdGNoIikpKSkKICAgICAoYnVpbGQtc3lzdGVtIGdudS1idWls ZC1zeXN0ZW0pCi0gICAgKG5hdGl2ZS1zZWFyY2gtcGF0aHMKKyAgICAoc2VhcmNoLXBhdGhzCiAg ICAgIChsaXN0IChzZWFyY2gtcGF0aC1zcGVjaWZpY2F0aW9uCiAgICAgICAgICAgICAgKHZhcmlh YmxlICJBTFNBX1BMVUdJTl9ESVIiKQogICAgICAgICAgICAgIChmaWxlLXR5cGUgJ3JlZ3VsYXIp CmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52aXJvbm1l bnQtdmFyaWFibGUucGF0Y2ggYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52 aXJvbm1lbnQtdmFyaWFibGUucGF0Y2gKaW5kZXggYTQ2OGE3ZmM0Li45ZDEyMjA3OWUgMTAwNjQ0 Ci0tLSBhL2dudS9wYWNrYWdlcy9wYXRjaGVzL2Fsc2EtbGliLWFkZC1lbnZpcm9ubWVudC12YXJp YWJsZS5wYXRjaAorKysgYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52aXJv bm1lbnQtdmFyaWFibGUucGF0Y2gKQEAgLTEsMjEgKzEsMjEgQEAKLUZyb20gMTgyMmZiNDUzMTI4 YTFiNWRlOTNiNGM1OTBjZDI3MmQ2NDg4YTA3NyBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKK0Zy b20gNTE1MjNiN2Q1NDZhZGUwMDJiMGJjOTk5YjJlMDFmOTU5M2U4NTc2ZCBNb24gU2VwIDE3IDAw OjAwOjAwIDIwMDEKIEZyb206IEp1bGllbiBMZXBpbGxlciA8anVsaWVuQGxlcGlsbGVyLmV1Pgot RGF0ZTogRnJpLCAyNSBNYXkgMjAxOCAxOToyNjo1OCArMDIwMAorRGF0ZTogRnJpLCAyMiBKdW4g MjAxOCAxMzo1MDo0NSArMDIwMAogU3ViamVjdDogW1BBVENIXSBBZGQgc3VwcG9ydCBmb3IgYSBB TFNBX1BMVUdJTl9ESVIgZW52aXJvbm1lbnQgdmFyaWFibGUuCiAKIElmIGl0IGlzIG5vdCBzZXQs IGRlZmF1bHQgdG8gcHJldmlvdXMgYmVoYXZpb3IuCiAtLS0KLSBzcmMvY29udHJvbC9jb250cm9s LmMgfCAgNiArKysrKy0KKyBzcmMvY29udHJvbC9jb250cm9sLmMgfCAgOCArKysrKystLQogIHNy Yy9kbG1pc2MuYyAgICAgICAgICB8ICA5ICsrKysrKystLQogIHNyYy9wY20vcGNtLmMgICAgICAg ICB8ICA5ICsrKysrKystLQogIHNyYy9wY20vcGNtX3JhdGUuYyAgICB8IDEzICsrKysrKysrKy0t LS0KLSA0IGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCisg NCBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKIAogZGlm ZiAtLWdpdCBhL3NyYy9jb250cm9sL2NvbnRyb2wuYyBiL3NyYy9jb250cm9sL2NvbnRyb2wuYwot aW5kZXggMTFmNzgxNS4uOWRiYTdkZCAxMDA2NDQKK2luZGV4IDExZjc4MTUuLjkyMGIxYWYgMTAw NjQ0CiAtLS0gYS9zcmMvY29udHJvbC9jb250cm9sLmMKICsrKyBiL3NyYy9jb250cm9sL2NvbnRy b2wuYwotQEAgLTEzMzEsNyArMTMzMSwxMSBAQCBzdGF0aWMgaW50IHNuZF9jdGxfb3Blbl9jb25m KHNuZF9jdGxfdCAqKmN0bHAsIGNvbnN0IGNoYXIgKm5hbWUsCitAQCAtMTMzMSwxMyArMTMzMSwx NyBAQCBzdGF0aWMgaW50IHNuZF9jdGxfb3Blbl9jb25mKHNuZF9jdGxfdCAqKmN0bHAsIGNvbnN0 IGNoYXIgKm5hbWUsCiAgCQkJYnVpbGRfaW4rKzsKICAJCX0KICAJCWlmICgqYnVpbGRfaW4gPT0g TlVMTCkgewpAQCAtMjgsNiArMjgsMTMgQEAgaW5kZXggMTFmNzgxNS4uOWRiYTdkZCAxMDA2NDQK ICAJCQlpZiAoYnVmMSA9PSBOVUxMKSB7CiAgCQkJCWVyciA9IC1FTk9NRU07CiAgCQkJCWdvdG8g X2VycjsKKyAJCQl9CisgCQkJbGliID0gYnVmMTsKKy0JCQlzcHJpbnRmKGJ1ZjEsICIlcy9saWJh c291bmRfbW9kdWxlX2N0bF8lcy5zbyIsIEFMU0FfUExVR0lOX0RJUiwgc3RyKTsKKysJCQlzcHJp bnRmKGJ1ZjEsICIlcy9saWJhc291bmRfbW9kdWxlX2N0bF8lcy5zbyIsIHBsdWdkaXIsIHN0cik7 CisgCQl9CisgCX0KKyAjaWZuZGVmIFBJQwogZGlmZiAtLWdpdCBhL3NyYy9kbG1pc2MuYyBiL3Ny Yy9kbG1pc2MuYwogaW5kZXggMzc1N2QzMy4uOTJhYTg2NCAxMDA2NDQKIC0tLSBhL3NyYy9kbG1p c2MuYwpAQCAtMTA2LDUgKzExMyw1IEBAIGluZGV4IDRlMGM3Y2EuLjg2OTRhMzggMTAwNjQ0CiAg CiAgCXJhdGUtPnJhdGVfbWluID0gU05EX1BDTV9QTFVHSU5fUkFURV9NSU47CiAtLSAKLTIuMTcu MAorMi4xNC40CiAKLS0gCjIuMTQuNAoK --=_bb5a26b59575247e5c87ce22f8328432-- From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Jun 2018 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.15296972957505 (code B ref 31934); Fri, 22 Jun 2018 19:55:02 +0000 Received: (at 31934) by debbugs.gnu.org; 22 Jun 2018 19:54:55 +0000 Received: from localhost ([127.0.0.1]:60607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWS90-0001wz-UA for submit@debbugs.gnu.org; Fri, 22 Jun 2018 15:54:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWS8z-0001wm-H2 for 31934@debbugs.gnu.org; Fri, 22 Jun 2018 15:54:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWS8t-0005LS-60 for 31934@debbugs.gnu.org; Fri, 22 Jun 2018 15:54:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWS8t-0005LO-2j; Fri, 22 Jun 2018 15:54:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47890 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fWS8s-0004pt-MV; Fri, 22 Jun 2018 15:54:46 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: Date: Fri, 22 Jun 2018 21:54:45 +0200 In-Reply-To: (Julien Lepiller's message of "Fri, 22 Jun 2018 14:39:33 +0200") Message-ID: <871scyy4u2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Julien Lepiller skribis: > Hi, this patch fixes an issue with the patch for alsa-lib and defines > a search-path rather than a native-search-path. In order to make the > alsa-service work properly, you still need to have alsa-lib and > alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR > to $PROFILE/lib/alsa-lib. Could you clarify which issue this fixes? Also, I think you really want =E2=80=98native-search-paths=E2=80=99 and not =E2=80=98search-paths=E2=80=99. The latter is meant to be used by things l= ike cross-compilers. Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Jun 2018 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.15296989739988 (code B ref 31934); Fri, 22 Jun 2018 20:23:02 +0000 Received: (at 31934) by debbugs.gnu.org; 22 Jun 2018 20:22:53 +0000 Received: from localhost ([127.0.0.1]:60619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWSa5-0002b2-GQ for submit@debbugs.gnu.org; Fri, 22 Jun 2018 16:22:53 -0400 Received: from lepiller.eu ([89.234.186.109]:37282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWSa3-0002at-I3 for 31934@debbugs.gnu.org; Fri, 22 Jun 2018 16:22:52 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 9a3ce28a (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <31934@debbugs.gnu.org>; Fri, 22 Jun 2018 20:23:05 +0000 (UTC) Date: Fri, 22 Jun 2018 22:22:46 +0200 From: Julien Lepiller Message-ID: <20180622222246.49ea21b5@lepiller.eu> In-Reply-To: <871scyy4u2.fsf@gnu.org> References: <871scyy4u2.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Fri, 22 Jun 2018 21:54:45 +0200, ludo@gnu.org (Ludovic Court=C3=A8s) a =C3=A9crit : > Could you clarify which issue this fixes? >=20 > Also, I think you really want =E2=80=98native-search-paths=E2=80=99 and n= ot > =E2=80=98search-paths=E2=80=99. The latter is meant to be used by things= like > cross-compilers. >=20 > Thanks, > Ludo=E2=80=99. The issue was that a part of the code was only partially patched. It looked like: plugdir =3D ALSA_PLUGIN_DIR; envplugdir =3D getenv("ALSA_PLUGIN_DIR"); if(envplugdir !=3D NULL) plugdir =3D envplugdir; ... sofile =3D malloc(sizeof(plugdir) + ...); ... sprintf(sofile, "%s/whatever.so", ALSA_PLUGIN_DIR); If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime $ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR. The native-search-paths vs search-paths is a bit confusing... I need to read the manual more carefully I guess. From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Jun 2018 21:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.15297908731569 (code B ref 31934); Sat, 23 Jun 2018 21:55:01 +0000 Received: (at 31934) by debbugs.gnu.org; 23 Jun 2018 21:54:33 +0000 Received: from localhost ([127.0.0.1]:33488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWqUL-0000PF-An for submit@debbugs.gnu.org; Sat, 23 Jun 2018 17:54:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWqUJ-0000P2-2Y for 31934@debbugs.gnu.org; Sat, 23 Jun 2018 17:54:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWqUD-0001IA-3f for 31934@debbugs.gnu.org; Sat, 23 Jun 2018 17:54:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWqUD-0001I6-0S; Sat, 23 Jun 2018 17:54:25 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=53106 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fWqUC-0006P1-IG; Sat, 23 Jun 2018 17:54:24 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <871scyy4u2.fsf@gnu.org> <20180622222246.49ea21b5@lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Messidor an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 23 Jun 2018 23:54:22 +0200 In-Reply-To: <20180622222246.49ea21b5@lepiller.eu> (Julien Lepiller's message of "Fri, 22 Jun 2018 22:22:46 +0200") Message-ID: <87lgb5w4mp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Julien Lepiller skribis: > Le Fri, 22 Jun 2018 21:54:45 +0200, > ludo@gnu.org (Ludovic Court=C3=A8s) a =C3=A9crit : > >> Could you clarify which issue this fixes? >>=20 >> Also, I think you really want =E2=80=98native-search-paths=E2=80=99 and = not >> =E2=80=98search-paths=E2=80=99. The latter is meant to be used by thing= s like >> cross-compilers. >>=20 >> Thanks, >> Ludo=E2=80=99. > > The issue was that a part of the code was only partially patched. It > looked like: > > plugdir =3D ALSA_PLUGIN_DIR; > envplugdir =3D getenv("ALSA_PLUGIN_DIR"); > if(envplugdir !=3D NULL) > plugdir =3D envplugdir; > ... > sofile =3D malloc(sizeof(plugdir) + ...); > ... > sprintf(sofile, "%s/whatever.so", ALSA_PLUGIN_DIR); > > If at compilation time ALSA_PLUGIN_DIR is bigger than the runtime > $ALSA_PLUGIN_DIR, we are in trouble: alsa-lib will crash because of a > buffer overflow. Otherwise, it just didn't care about $ALSA_PLUGIN_DIR. Alright, so the patch update can definitely go in! > The native-search-paths vs search-paths is a bit confusing... I need to > read the manual more carefully I guess. The manual doesn=E2=80=99t say much about this, so you have a good excuse. But anyway, that change is surely not necessary. Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] Fix ALSA_PLUGIN_DIR usage Resent-From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 24 Jun 2018 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.15298239543664 (code B ref 31934); Sun, 24 Jun 2018 07:06:02 +0000 Received: (at 31934) by debbugs.gnu.org; 24 Jun 2018 07:05:54 +0000 Received: from localhost ([127.0.0.1]:33607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWz5r-0000wz-54 for submit@debbugs.gnu.org; Sun, 24 Jun 2018 03:05:54 -0400 Received: from rezeros.cc ([45.76.207.221]:35042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWz5o-0000wn-QE for 31934@debbugs.gnu.org; Sun, 24 Jun 2018 03:05:49 -0400 Received: from localhost (223.87.243.217 [223.87.243.217]) by rezeros.cc (OpenSMTPD) with ESMTPSA id e29332ca (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 24 Jun 2018 07:05:35 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 425130f1; Sun, 24 Jun 2018 07:05:17 +0000 (UTC) From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) References: Date: Sun, 24 Jun 2018 15:05:17 +0800 In-Reply-To: (Julien Lepiller's message of "Fri, 22 Jun 2018 14:39:33 +0200") Message-ID: <87a7rkhdg2.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Julien Lepiller writes: > Hi, this patch fixes an issue with the patch for alsa-lib and defines > a search-path rather than a native-search-path. In order to make the > alsa-service work properly, you still need to have alsa-lib and > alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR > to $PROFILE/lib/alsa-lib. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Julien Lepiller writes: > Hi, this patch fixes an issue with the patch for alsa-lib and defines > a search-path rather than a native-search-path. In order to make the > alsa-service work properly, you still need to have alsa-lib and > alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR > to $PROFILE/lib/alsa-lib. Hello, after some hours of searching... I found that we can use the 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path for alsa plugins, e.g: --8<---------------cut here---------------start------------->8--- # Use PulseAudio by default pcm_type.pulse { lib "/gnu/store/icvba55494j4vxb7yp97iya1h6g1l30h-alsa-plugins-1.1.6-pulseaudio/lib/alsa-lib/libasound_module_pcm_pulse.so" } ctl_type.pulse { lib "/gnu/store/icvba55494j4vxb7yp97iya1h6g1l30h-alsa-plugins-1.1.6-pulseaudio/lib/alsa-lib/libasound_module_ctl_pulse.so" } pcm.!default { type pulse fallback "sysdefault" hint { show on description "Default ALSA Output (currently PulseAudio Sound Server)" } } ctl.!default { type pulse fallback "sysdefault" } --8<---------------cut here---------------end--------------->8--- So I think we can make our 'alsa-service' do this, instead of patching alsa-lib for 'ALSA_PLUGIN_DIR'. We could document it in the manual, so that a user wanting to use other alsa plugins get a hint to add: 'lib "/home/xxx/.guix-profile/lib/alsa-lib/libasound_xxx.so"' in '~/.asoundrc'. How's this sound? Also, NixOS did this actually, and they went far to support running 32-bit alsa applications with 64-bit pulseaudio: https://github.com/NixOS/nixpkgs/commit/0c8ad65560fa1df07ea7b7937e02b44b1ce2b498 I think we don't need this now... From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 24 Jun 2018 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) Cc: Julien Lepiller , 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.152983711131463 (code B ref 31934); Sun, 24 Jun 2018 10:46:02 +0000 Received: (at 31934) by debbugs.gnu.org; 24 Jun 2018 10:45:11 +0000 Received: from localhost ([127.0.0.1]:33677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX2W3-0008BM-Lk for submit@debbugs.gnu.org; Sun, 24 Jun 2018 06:45:11 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:40910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX2W1-0008Aa-UO for 31934@debbugs.gnu.org; Sun, 24 Jun 2018 06:45:06 -0400 Received: by mail-lf0-f66.google.com with SMTP id q11-v6so12270939lfc.7 for <31934@debbugs.gnu.org>; Sun, 24 Jun 2018 03:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=v84Ms0Mm8sLq2o7EuY3gyOlVNECcOBCEEw4z7mgHsoc=; b=BrVpjaVg3uAQw+S9Q0DqssWIc7UiFWi2nnzFkodtzx099VImbMPiFKKBwkAIP5IGTA pHg+gsb+o1jtnZTlBuRp8wxGOINZb/s3Gce3PbHElpc6RN/iSg4ACbusheVP2HeVFDrg jQedqJ5O7AftX2JMqwNA14lJDe7d2RU/C9bRVSEPLUNE85rvs9DHVESaBY/O6L2dRNwX RG9OEtnczKhaFJTpjfREYWck4MPqyf73LVmqJNwXTiukQpv3+3bnQsfoQbLZwMCVewOZ p1cOFzI6jGWebSYwtIzwYXBhKCdo4YfIGUxc0zVdKAGqRTXNpj58h24BWnSiXWaup5hA Dzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=v84Ms0Mm8sLq2o7EuY3gyOlVNECcOBCEEw4z7mgHsoc=; b=OWEQkRSLT1PkfUZ3r3/4ZjT5SS5wdbCRC7dauI1xmtEzG5mwOkGKZQ1ZzWypp4Lnnw NI16WQFn90M/QCzy0iJkzhwfUR5wYg/6Owvr1NlZVU5xqLkJBoqRZfS5cBa5vgYewf2o Iq3hqZcxfOqlx2Ms/OkWnc4LJsvRwCnkqyd0bLScpEEbLejOM9zEYNvx7U3OiwwaHw6H c3uMhNfSmSBhOG1qAKk0ZGPauRAW6WttHIuCPCAOk7XGt2tFqfeKjaigBtfYmEZblIbK pkGjv6aOsIFDyjEdvnOOo+S397g4HrwILmG/echlW5TzcmNyye9b6veGRMmzTIxNSXAC TAnQ== X-Gm-Message-State: APt69E3haab7ZWm387BpK4D4o2q4eei1utAMm4mLEp4pBrTIvMUh6ZSF 4M48NBhOir280m6tHFy/UsWbYA== X-Google-Smtp-Source: ADUXVKISLcQXVrkTBYyygwVZrruKUdXPLfx6P7ijD8F96kpMIe4eBNWXTRozXf37RxyTxR8gpY4zyw== X-Received: by 2002:a19:e955:: with SMTP id g82-v6mr3343689lfh.44.1529837099531; Sun, 24 Jun 2018 03:44:59 -0700 (PDT) Received: from magnolia (92-100-136-1.dynamic.avangarddsl.ru. [92.100.136.1]) by smtp.gmail.com with ESMTPSA id y15-v6sm1912564ljj.75.2018.06.24.03.44.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 03:44:58 -0700 (PDT) From: Oleg Pykhalov References: <87a7rkhdg2.fsf@member.fsf.org> Date: Sun, 24 Jun 2018 13:44:54 +0300 In-Reply-To: <87a7rkhdg2.fsf@member.fsf.org> ("=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?="'s message of "Sun, 24 Jun 2018 15:05:17 +0800") Message-ID: <87h8lso449.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > Julien Lepiller writes: [=E2=80=A6] > Hello, after some hours of searching... I found that we can use the > 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path > for alsa plugins, e.g: Thats a nice hack :-) Thank you for working on this. [=E2=80=A6] > So I think we can make our 'alsa-service' do this, instead of patching > alsa-lib for 'ALSA_PLUGIN_DIR'. Done. Here is a patch which I tested on my machine by =E2=80=98system reco= nfigure=E2=80=99: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-services-sound-Properly-handle-alsa-plugins.patch Content-Transfer-Encoding: quoted-printable Content-Description: services: sound: Properly handle alsa-plugins. From=2022186e76d991a47e7057d1abe23af02b52f8153b Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sun, 24 Jun 2018 13:18:53 +0300 Subject: [PATCH] services: sound: Properly handle alsa-plugins. * gnu/services/sound.scm ()[alsa-plugins]: New field. (alsa-config-file): Add this. * doc/guix.texi (Sound Services): Document this. =2D-- doc/guix.texi | 3 +++ gnu/services/sound.scm | 31 +++++++++++++++++++++++-------- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 74c10e4bb..e5366ac6b 100644 =2D-- a/doc/guix.texi +++ b/doc/guix.texi @@ -13152,6 +13152,9 @@ See below for details about @code{alsa-configuratio= n}. Data type representing the configuration for @code{alsa-service}. =20 @table @asis +@item @code{alsa-plugins} (default: @var{alsa-plugins}) +@code{alsa-plugins} package to use. + @item @code{pulseaudio?} (default: @var{#t}) Whether ALSA applications should transparently be made to use the @uref{http://www.pulseaudio.org/, PulseAudio} sound server. diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm index 5fe555e8b..2b2cabd7b 100644 =2D-- a/gnu/services/sound.scm +++ b/gnu/services/sound.scm @@ -26,6 +26,7 @@ #:use-module (guix packages) #:use-module (guix records) #:use-module (guix store) + #:use-module (gnu packages linux) #:use-module (gnu packages pulseaudio) #:use-module (ice-9 match) #:export (alsa-configuration @@ -44,17 +45,31 @@ =20 (define-record-type* alsa-configuration make-alsa-configuration alsa-configuration? + (alsa-plugins alsa-configuration-alsa-plugins ; + (default alsa-plugins)) (pulseaudio? alsa-configuration-pulseaudio? ;boolean (default #t)) (extra-options alsa-configuration-extra-options ;string (default ""))) =20 =2D(define (alsa-config-file config) =2D "Return the ALSA configuration file corresponding to CONFIG." =2D (plain-file "asound.conf" =2D (string-append "# Generated by 'alsa-service'.\n\n" =2D (if (alsa-configuration-pulseaudio? config) =2D "# Use PulseAudio by default +(define alsa-config-file + ;; Return the ALSA configuration file. + (match-lambda + (($ alsa-plugins pulseaudio? extra-options) + (mixed-text-file "asound.conf" + "# Generated by 'alsa-service'.\n\n" + ;; if pulseaudio? + "# Use PulseAudio by default +pcm_type.pulse { + lib " #~(string-append #$alsa-plugins:pulseaudio + "/lib/alsa-lib/libasound_module_pcm_pulse.so") " +} + +ctl_type.pulse { + lib " #~(string-append #$alsa-plugins:pulseaudio + "/lib/alsa-lib/libasound_module_ctl_pulse.so") " +} + pcm.!default { type pulse fallback \"sysdefault\" @@ -69,8 +84,8 @@ ctl.!default { fallback \"sysdefault\" } " =2D "") =2D (alsa-configuration-extra-options config)))) + "" + extra-options)))) =20 (define (alsa-etc-service config) (list `("asound.conf" ,(alsa-config-file config)))) =2D-=20 2.17.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E2=80=A6] Thanks, Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlsvdiYACgkQckbhHGm3 lWkXRBAAtMY8dLzFehiyGG7b17MavQyrMQu7Jn/jIbCvVJ4gJwv7inPb9OptrsIH TCTSG9+1XkJpOoMNmnHXiMue3aJjcxNt8yKU1tZmkkvrooGrPyueKAw0ZnVcGVl+ Bfeni9wr37L+knLRpG+ooM6xxqvd0TAM/58UjEOHLLmdfHiGEsey1fwb1CrJ9Z5n 1HkApb4ZQMlR52N0oZOvic/jH0sUKxTuoI4IEhqy0JrI3HKBtZHti4tmI/0bQtdJ dc77+ps5eVQnFuRxXxGshdOtTXNQudKdfvCxl5DYs4M18n9kWL4l4CCz0nBrWbgO lgm8pcHF9r/O2iQNd6nKqr1vkhwJ9gfsc9F+Uh9XymZUVPDXmYoCh9rSy0kJrNt2 4yDftWyhDWrv3tulurWbcMBPJj4juwQWkr8QOFins5y7Wv3DrxvtcPXvVtVRIu31 Qb9F6wSK/roQJMje99X0N99mptBN6A2ydicfWW3JYcWc2OJ+O0oewf2IPH+vsurr 3+1LM6qUIE2HhuToIunYZ+r350zdgXvucLmU1V8vsnM5RqjjgPLc9C//T/8UtTb4 nQiQto0qs8WpjDG2+2RqEe/Um0YQwsFrFYC82XtRh2fun2oz7LYzs1nPaUZGUjmD 06QDc+bUlGWqeop6Hafum6TlKSSZt4gFku/upYfuiK8HkfZBK3Q= =Jupb -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Jun 2018 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Julien Lepiller , 31934@debbugs.gnu.org, 31591-done@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.152994090822923 (code B ref 31934); Mon, 25 Jun 2018 15:36:02 +0000 Received: (at 31934) by debbugs.gnu.org; 25 Jun 2018 15:35:08 +0000 Received: from localhost ([127.0.0.1]:35091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXTWG-0005xa-7Y for submit@debbugs.gnu.org; Mon, 25 Jun 2018 11:35:08 -0400 Received: from rezeros.cc ([45.76.207.221]:35298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXTWB-0005wz-IH; Mon, 25 Jun 2018 11:35:04 -0400 Received: from localhost (117.173.130.49 [117.173.130.49]) by rezeros.cc (OpenSMTPD) with ESMTPSA id afba3550 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 25 Jun 2018 15:34:49 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 01920731; Mon, 25 Jun 2018 15:34:13 +0000 (UTC) From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> Date: Mon, 25 Jun 2018 23:34:13 +0800 In-Reply-To: <87h8lso449.fsf_-_@gmail.com> (Oleg Pykhalov's message of "Sun, 24 Jun 2018 13:44:54 +0300") Message-ID: <876026ev7u.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Oleg Pykhalov writes: > Hello, > > iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) writes: > >> Julien Lepiller writes: > > =?UTF-8?Q?[=E2=80=A6]?= > >> Hello, after some hours of searching... I found that we can use the >> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >> for alsa plugins, e.g: > > Thats a nice hack :-) Thank you for working on this. > > =?UTF-8?Q?[=E2=80=A6]?= > >> So I think we can make our 'alsa-service' do this, instead of patching >> alsa-lib for 'ALSA_PLUGIN_DIR'. > > Done. Here is a patch which I tested on my machine by =?UTF-8?Q?=E2=80=98system_?= =?UTF-8?Q?reconfigure=E2=80=99:?= > [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Oleg Pykhalov writes: > Hello, > > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > >> Julien Lepiller writes: > > [=E2=80=A6] > >> Hello, after some hours of searching... I found that we can use the >> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >> for alsa plugins, e.g: > > Thats a nice hack :-) Thank you for working on this. > > [=E2=80=A6] > >> So I think we can make our 'alsa-service' do this, instead of patching >> alsa-lib for 'ALSA_PLUGIN_DIR'. > > Done. Here is a patch which I tested on my machine by =E2=80=98system re= configure=E2=80=99: > Thank you, I modified it to keep the 'pulseaudio? #f' function, and pushed :-) From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Jun 2018 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.152994108123218 (code B ref 31934); Mon, 25 Jun 2018 15:38:01 +0000 Received: (at 31934) by debbugs.gnu.org; 25 Jun 2018 15:38:01 +0000 Received: from localhost ([127.0.0.1]:35099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXTZ2-00062Q-QA for submit@debbugs.gnu.org; Mon, 25 Jun 2018 11:38:00 -0400 Received: from lepiller.eu ([89.234.186.109]:37304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXTZ1-00062H-3R for 31934@debbugs.gnu.org; Mon, 25 Jun 2018 11:37:59 -0400 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 49e95056 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <31934@debbugs.gnu.org>; Mon, 25 Jun 2018 15:38:17 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 25 Jun 2018 17:37:56 +0200 From: Julien Lepiller In-Reply-To: <876026ev7u.fsf@member.fsf.org> References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> <876026ev7u.fsf@member.fsf.org> Message-ID: <989ad55f9f17664af266f1f9f5653583@lepiller.eu> X-Sender: julien@lepiller.eu User-Agent: Roundcube Webmail/1.3.6 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit : > Oleg Pykhalov writes: > >> Hello, >> >> iyzsong@member.fsf.org (宋文武) writes: >> >>> Julien Lepiller writes: >> >> […] >> >>> Hello, after some hours of searching... I found that we can use the >>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >>> for alsa plugins, e.g: >> >> Thats a nice hack :-) Thank you for working on this. >> >> […] >> >>> So I think we can make our 'alsa-service' do this, instead of >>> patching >>> alsa-lib for 'ALSA_PLUGIN_DIR'. >> >> Done. Here is a patch which I tested on my machine by ‘system >> reconfigure’: >> > > Thank you, I modified it to keep the 'pulseaudio? #f' function, and > pushed :-) So maybe we can drop our ALSA_PLUGIN_DIR patch now? From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jun 2018 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: rekado@elephly.net, 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.153001320817053 (code B ref 31934); Tue, 26 Jun 2018 11:41:02 +0000 Received: (at 31934) by debbugs.gnu.org; 26 Jun 2018 11:40:08 +0000 Received: from localhost ([127.0.0.1]:35688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXmKN-0004Qz-Li for submit@debbugs.gnu.org; Tue, 26 Jun 2018 07:40:07 -0400 Received: from rezeros.cc ([45.76.207.221]:35398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXmKL-0004Qp-4T for 31934@debbugs.gnu.org; Tue, 26 Jun 2018 07:40:06 -0400 Received: from localhost (117.173.130.49 [117.173.130.49]) by rezeros.cc (OpenSMTPD) with ESMTPSA id b46107a2 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 26 Jun 2018 11:39:51 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 1c12cfc6; Tue, 26 Jun 2018 11:38:44 +0000 (UTC) From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> <876026ev7u.fsf@member.fsf.org> <989ad55f9f17664af266f1f9f5653583@lepiller.eu> Date: Tue, 26 Jun 2018 19:38:44 +0800 In-Reply-To: <989ad55f9f17664af266f1f9f5653583@lepiller.eu> (Julien Lepiller's message of "Mon, 25 Jun 2018 17:37:56 +0200") Message-ID: <87o9fxdbgb.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Julien Lepiller writes: > Le 2018-06-25 17:34, iyzsong@member.fsf.org a =?UTF-8?Q?=C3=A9crit=C2?= : >> Oleg Pykhalov writes: >> >>> Hello, >>> >>> iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=) writes: >>> >>>> Julien Lepiller writes: >>> >>> =?UTF-8?Q?[=E2=80=A6]?= >>> >>>> Hello, after some hours of searching... I found that we can use the >>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >>>> for alsa plugins, e.g: >>> >>> Thats a nice hack :-) Thank you for working on this. >>> >>> =?UTF-8?Q?[=E2=80=A6]?= >>> >>>> So I think we can make our 'alsa-service' do this, instead of >>>> patching >>>> alsa-lib for 'ALSA_PLUGIN_DIR'. >>> >>> Done. Here is a patch which I tested on my machine by =?UTF-8?Q?=E2=80=98system?= >>> =?UTF-8?Q?reconfigure=E2=80=99:?= >>> >> >> Thank you, I modified it to keep the 'pulseaudio? #f' function, and >> pushed :-) > > So maybe we can drop our ALSA_PLUGIN_DIR patch now? [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Julien Lepiller writes: > Le 2018-06-25 17:34, iyzsong@member.fsf.org a =C3=A9crit=C2=A0: >> Oleg Pykhalov writes: >> >>> Hello, >>> >>> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: >>> >>>> Julien Lepiller writes: >>> >>> [=E2=80=A6] >>> >>>> Hello, after some hours of searching... I found that we can use the >>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >>>> for alsa plugins, e.g: >>> >>> Thats a nice hack :-) Thank you for working on this. >>> >>> [=E2=80=A6] >>> >>>> So I think we can make our 'alsa-service' do this, instead of >>>> patching >>>> alsa-lib for 'ALSA_PLUGIN_DIR'. >>> >>> Done. Here is a patch which I tested on my machine by =E2=80=98system >>> reconfigure=E2=80=99: >>> >> >> Thank you, I modified it to keep the 'pulseaudio? #f' function, and >> pushed :-) > > So maybe we can drop our ALSA_PLUGIN_DIR patch now? Yes, I think so. @Ricardo, should we do it in core-updates? From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jun 2018 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , Julien Lepiller Cc: rekado@elephly.net, 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.153001379617939 (code B ref 31934); Tue, 26 Jun 2018 11:50:02 +0000 Received: (at 31934) by debbugs.gnu.org; 26 Jun 2018 11:49:56 +0000 Received: from localhost ([127.0.0.1]:35703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXmTr-0004fG-W5 for submit@debbugs.gnu.org; Tue, 26 Jun 2018 07:49:56 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXmTq-0004f9-Rv for 31934@debbugs.gnu.org; Tue, 26 Jun 2018 07:49:55 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5A4FD21B98; Tue, 26 Jun 2018 07:49:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 26 Jun 2018 07:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=IR1Bq3U/hbGrqpvGFuIevgx6L8e5wTIekjf45dpMAFQ=; b=J8NVojhS VtdGOolcZ7KOfb2VgSWmYL3ud8NP97VCWwQ7NiHK+6kWxQiWD8KWLGBE6q7swPox jmHN7XU1K3BHwNUSWqi8szsr4yET1Uu7x3yxx/l43eHey/ttfFbt8WssRxntgJTj LBIEBD+T+UziVYP47ys4jqcOEuTcjGPQxPwOFdP9UrFILueqhHdq5OnEgicgrAYF 4h27699hxS54t/lXL6P1lNKjz5vkSPQE8wzlbFFYhadKW50q+AX3f7WDFOeBwvCA IJoYW/YcfoqahE6xKkrAa/PwoDESLo3zF4IVnUv5FLKVCp4mP7HaziEuKRO2smPe 7nZD+Fzl+L0TGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=IR1Bq3U/hbGrqpvGFuIevgx6L8e5w TIekjf45dpMAFQ=; b=oq4jQlTGjLgKa3kiZVmmWgx+DcD0r2qTzJ8CaxZ/jHfQp 9bCiDS0OsqDPBvRUH4svDLFnX0ETJBRN41r4klWA9VqmgWIrAulY2dFk4WdHqDqp yYHdi+OxPxDX1ejlysAtFiiqupGwe+u27+k8ygdCvbU7qbDmCRlugUqM+uiklgxp 5bwv5wqCtTsLNdYeWRx8HrVxwNPflnY6LPQkCqxXOyPH+4IdF5n/+2KSOb0AVxhx vClDhq3sKfxpnuzo1hjjgyAeG3aULMXv5/PpUM8ge0WNqxFCPfDgkkPSH5PpC2Z+ TnEexuNuy8EZ6GY9FIrGzxMxAJP8BfUvbU1k8+huA== X-ME-Proxy: X-ME-Sender: Received: from localhost (cm-84.214.174.185.getinternet.no [84.214.174.185]) by mail.messagingengine.com (Postfix) with ESMTPA id D24AB1025D; Tue, 26 Jun 2018 07:49:53 -0400 (EDT) From: Marius Bakke In-Reply-To: <87o9fxdbgb.fsf@member.fsf.org> References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> <876026ev7u.fsf@member.fsf.org> <989ad55f9f17664af266f1f9f5653583@lepiller.eu> <87o9fxdbgb.fsf@member.fsf.org> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Tue, 26 Jun 2018 13:49:52 +0200 Message-ID: <87po0dydgf.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > Julien Lepiller writes: > >> Le 2018-06-25 17:34, iyzsong@member.fsf.org a =C3=A9crit=C2=A0: >>> Oleg Pykhalov writes: >>> >>>> Hello, >>>> >>>> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: >>>> >>>>> Julien Lepiller writes: >>>> >>>> [=E2=80=A6] >>>> >>>>> Hello, after some hours of searching... I found that we can use the >>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >>>>> for alsa plugins, e.g: >>>> >>>> Thats a nice hack :-) Thank you for working on this. >>>> >>>> [=E2=80=A6] >>>> >>>>> So I think we can make our 'alsa-service' do this, instead of >>>>> patching >>>>> alsa-lib for 'ALSA_PLUGIN_DIR'. >>>> >>>> Done. Here is a patch which I tested on my machine by =E2=80=98system >>>> reconfigure=E2=80=99: >>>> >>> >>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and >>> pushed :-) >> >> So maybe we can drop our ALSA_PLUGIN_DIR patch now? > > Yes, I think so. @Ricardo, should we do it in core-updates? If you're quick, you can do it on 'staging' which I'll attempt to re-start during today. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsyKGAACgkQoqBt8qM6 VPq8Fgf/awSxWQDHJQcsL2QnzYw8tmBV5R7iO9XNH/BtFhIA/0pyBmqiBcU/nYu3 S6Wabv3Gcr23NnVT1h1zL2t07s8bJ0pBbS6SJsK79nzx5yhCZTnyds1xdFDMzON0 fCdNXlk4JYpTwwEHOiE120GyeWhepOsKkgPkorkrEjTXE7lDcktsXK3IeddA9HU9 2akMKJrW54mj6EBVBHEp9QfAcD+Bo3BKarGXWzZQNcWARsm4tC2OhFQrO/M7kdv8 6m+T5BVU0oQWZqNn3EawcpabvGyNHZs+d0IJ4M296sYmhIPobRq4ddMiWM4inCbv ixFq9Kacmn8okGkKI9tM+rane6oo1w== =2JNb -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 11:41:08 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Julien Lepiller Subject: bug#31934: closed (Re: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins.) Message-ID: References: <87k1qld8uq.fsf@member.fsf.org> X-Gnu-PR-Message: they-closed 31934 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 31934@debbugs.gnu.org Date: Tue, 26 Jun 2018 12:36:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1530016562-22160-1" This is a multi-part message in MIME format... ------------=_1530016562-22160-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31934: [PATCH] Fix ALSA_PLUGIN_DIR usage which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31934@debbugs.gnu.org. --=20 31934: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31934 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1530016562-22160-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31934-done) by debbugs.gnu.org; 26 Jun 2018 12:35:36 +0000 Received: from localhost ([127.0.0.1]:35729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXnC3-0005kl-TN for submit@debbugs.gnu.org; Tue, 26 Jun 2018 08:35:36 -0400 Received: from rezeros.cc ([45.76.207.221]:35436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXnC1-0005kd-G3 for 31934-done@debbugs.gnu.org; Tue, 26 Jun 2018 08:35:34 -0400 Received: from localhost (117.173.130.49 [117.173.130.49]) by rezeros.cc (OpenSMTPD) with ESMTPSA id ae1c7deb (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 26 Jun 2018 12:35:19 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id c0897c89; Tue, 26 Jun 2018 12:34:53 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Marius Bakke Subject: Re: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> <876026ev7u.fsf@member.fsf.org> <989ad55f9f17664af266f1f9f5653583@lepiller.eu> <87o9fxdbgb.fsf@member.fsf.org> <87po0dydgf.fsf@fastmail.com> Date: Tue, 26 Jun 2018 20:34:53 +0800 In-Reply-To: <87po0dydgf.fsf@fastmail.com> (Marius Bakke's message of "Tue, 26 Jun 2018 13:49:52 +0200") Message-ID: <87k1qld8uq.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Marius Bakke writes: > iyzsong@member.fsf.org (宋文武) writes: > >> Julien Lepiller writes: >> >>> Le 2018-06-25 17:34, iyzsong@member.fsf.org a écrit : >>>> Oleg Pykhalov writes: >>>> >>>>> Hello, >>>>> >>>>> iyzsong@member.fsf.org (宋文武) writes: >>>>> >>>>>> Julien Lepiller writes: >>>>> >>>>> […] >>>>> >>>>>> Hello, after some hours of searching... I found that we can use the >>>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >>>>>> for alsa plugins, e.g: >>>>> >>>>> Thats a nice hack :-) Thank you for working on this. >>>>> >>>>> […] >>>>> >>>>>> So I think we can make our 'alsa-service' do this, instead of >>>>>> patching >>>>>> alsa-lib for 'ALSA_PLUGIN_DIR'. >>>>> >>>>> Done. Here is a patch which I tested on my machine by ‘system >>>>> reconfigure’: >>>>> >>>> >>>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and >>>> pushed :-) >>> >>> So maybe we can drop our ALSA_PLUGIN_DIR patch now? >> >> Yes, I think so. @Ricardo, should we do it in core-updates? > > If you're quick, you can do it on 'staging' which I'll attempt to > re-start during today. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 31934-done Cc: Julien Lepiller , 31934-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Marius Bakke writes: > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > >> Julien Lepiller writes: >> >>> Le 2018-06-25 17:34, iyzsong@member.fsf.org a =C3=A9crit=C2=A0: >>>> Oleg Pykhalov writes: >>>> >>>>> Hello, >>>>> >>>>> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: >>>>> >>>>>> Julien Lepiller writes: >>>>> >>>>> [=E2=80=A6] >>>>> >>>>>> Hello, after some hours of searching... I found that we can use the >>>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library path >>>>>> for alsa plugins, e.g: >>>>> >>>>> Thats a nice hack :-) Thank you for working on this. >>>>> >>>>> [=E2=80=A6] >>>>> >>>>>> So I think we can make our 'alsa-service' do this, instead of >>>>>> patching >>>>>> alsa-lib for 'ALSA_PLUGIN_DIR'. >>>>> >>>>> Done. Here is a patch which I tested on my machine by =E2=80=98system >>>>> reconfigure=E2=80=99: >>>>> >>>> >>>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and >>>> pushed :-) >>> >>> So maybe we can drop our ALSA_PLUGIN_DIR patch now? >> >> Yes, I think so. @Ricardo, should we do it in core-updates? > > If you're quick, you can do it on 'staging' which I'll attempt to > re-start during today. Done, thanks! And we can close this patch now... ------------=_1530016562-22160-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jun 2018 12:39:47 +0000 Received: from localhost ([127.0.0.1]:59741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLLv-0000Cy-3M for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLLu-0000Ch-9T for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWLLo-0000hJ-3Q for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWLLn-0000hF-VQ for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:39:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWLLm-00059T-Ne for guix-patches@gnu.org; Fri, 22 Jun 2018 08:39:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWLLj-0000g3-J0 for guix-patches@gnu.org; Fri, 22 Jun 2018 08:39:38 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:48128) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWLLj-0000fm-88 for guix-patches@gnu.org; Fri, 22 Jun 2018 08:39:35 -0400 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id bff16b08 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Fri, 22 Jun 2018 12:39:47 +0000 (UTC) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_bb5a26b59575247e5c87ce22f8328432" Date: Fri, 22 Jun 2018 14:39:33 +0200 From: Julien Lepiller To: guix-patches@gnu.org Subject: [PATCH] Fix ALSA_PLUGIN_DIR usage Message-ID: X-Sender: julien@lepiller.eu User-Agent: Roundcube Webmail/1.3.6 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=_bb5a26b59575247e5c87ce22f8328432 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, this patch fixes an issue with the patch for alsa-lib and defines a search-path rather than a native-search-path. In order to make the alsa-service work properly, you still need to have alsa-lib and alsa-plugins:pulseaudio in the same profile, and point ALSA_PLUGIN_DIR to $PROFILE/lib/alsa-lib. --=_bb5a26b59575247e5c87ce22f8328432 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch Content-Disposition: attachment; filename=0001-gnu-alsa-lib-Fix-ALSA_PLUGIN_DIR-usage.patch; size=3159 RnJvbSBjNjM4NjdlYjUxZjE0NjQyMDdkZTk1MGRlNGQ4Mzk0OTcxYzdlYzVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gTGVwaWxsZXIgPGp1bGllbkBsZXBpbGxlci5ldT4K RGF0ZTogRnJpLCAyMiBKdW4gMjAxOCAxMzo1MjoxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogYWxzYS1saWI6IEZpeCBBTFNBX1BMVUdJTl9ESVIgdXNhZ2UuCgoqIGdudS9wYWNrYWdlcy9s aW51eC5zY20gKG5hdGl2ZS1zZWFyY2gtcGF0aHMpOiBVc2Ugc2VhcmNoLXBhdGhzCmluc3RlYWQu CiogZ251L3BhY2thZ2VzL3BhdGNoZXMvYWxzYS1saWItYWRkLWVudmlyb25tZW50LXZhcmlhYmxl LnBhdGNoOiBVc2UKY29tcHV0ZWQgcGx1Z2RpciBpbnN0ZWFkIG9mIGRlZmF1bHQgQUxTQV9QTFVH SU5fRElSLgotLS0KIGdudS9wYWNrYWdlcy9saW51eC5zY20gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAyICstCiAuLi4vcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52aXJvbm1lbnQtdmFy aWFibGUucGF0Y2ggfCAyMSArKysrKysrKysrKysrKy0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTUgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2Fn ZXMvbGludXguc2NtIGIvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQppbmRleCA3ZTgxZjYzODcuLmI4 NmRmZGY4MCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQorKysgYi9nbnUvcGFj a2FnZXMvbGludXguc2NtCkBAIC05ODMsNyArOTgzLDcgQEAgaW50ZXJjZXB0IGFuZCBwcmludCB0 aGUgc3lzdGVtIGNhbGxzIGV4ZWN1dGVkIGJ5IHRoZSBwcm9ncmFtLiIpCiAgICAgICAgICAgICAg ICAiMDk2cHdybmhqMzZ5bmRsZHZzMnBqNHI4NzF6aGNnaXNrczBpczc4ZjFqa2puOXNkNGIyeiIp KQogICAgICAgICAgICAgIChwYXRjaGVzIChzZWFyY2gtcGF0Y2hlcyAiYWxzYS1saWItYWRkLWVu dmlyb25tZW50LXZhcmlhYmxlLnBhdGNoIikpKSkKICAgICAoYnVpbGQtc3lzdGVtIGdudS1idWls ZC1zeXN0ZW0pCi0gICAgKG5hdGl2ZS1zZWFyY2gtcGF0aHMKKyAgICAoc2VhcmNoLXBhdGhzCiAg ICAgIChsaXN0IChzZWFyY2gtcGF0aC1zcGVjaWZpY2F0aW9uCiAgICAgICAgICAgICAgKHZhcmlh YmxlICJBTFNBX1BMVUdJTl9ESVIiKQogICAgICAgICAgICAgIChmaWxlLXR5cGUgJ3JlZ3VsYXIp CmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52aXJvbm1l bnQtdmFyaWFibGUucGF0Y2ggYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52 aXJvbm1lbnQtdmFyaWFibGUucGF0Y2gKaW5kZXggYTQ2OGE3ZmM0Li45ZDEyMjA3OWUgMTAwNjQ0 Ci0tLSBhL2dudS9wYWNrYWdlcy9wYXRjaGVzL2Fsc2EtbGliLWFkZC1lbnZpcm9ubWVudC12YXJp YWJsZS5wYXRjaAorKysgYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9hbHNhLWxpYi1hZGQtZW52aXJv bm1lbnQtdmFyaWFibGUucGF0Y2gKQEAgLTEsMjEgKzEsMjEgQEAKLUZyb20gMTgyMmZiNDUzMTI4 YTFiNWRlOTNiNGM1OTBjZDI3MmQ2NDg4YTA3NyBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKK0Zy b20gNTE1MjNiN2Q1NDZhZGUwMDJiMGJjOTk5YjJlMDFmOTU5M2U4NTc2ZCBNb24gU2VwIDE3IDAw OjAwOjAwIDIwMDEKIEZyb206IEp1bGllbiBMZXBpbGxlciA8anVsaWVuQGxlcGlsbGVyLmV1Pgot RGF0ZTogRnJpLCAyNSBNYXkgMjAxOCAxOToyNjo1OCArMDIwMAorRGF0ZTogRnJpLCAyMiBKdW4g MjAxOCAxMzo1MDo0NSArMDIwMAogU3ViamVjdDogW1BBVENIXSBBZGQgc3VwcG9ydCBmb3IgYSBB TFNBX1BMVUdJTl9ESVIgZW52aXJvbm1lbnQgdmFyaWFibGUuCiAKIElmIGl0IGlzIG5vdCBzZXQs IGRlZmF1bHQgdG8gcHJldmlvdXMgYmVoYXZpb3IuCiAtLS0KLSBzcmMvY29udHJvbC9jb250cm9s LmMgfCAgNiArKysrKy0KKyBzcmMvY29udHJvbC9jb250cm9sLmMgfCAgOCArKysrKystLQogIHNy Yy9kbG1pc2MuYyAgICAgICAgICB8ICA5ICsrKysrKystLQogIHNyYy9wY20vcGNtLmMgICAgICAg ICB8ICA5ICsrKysrKystLQogIHNyYy9wY20vcGNtX3JhdGUuYyAgICB8IDEzICsrKysrKysrKy0t LS0KLSA0IGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCisg NCBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKIAogZGlm ZiAtLWdpdCBhL3NyYy9jb250cm9sL2NvbnRyb2wuYyBiL3NyYy9jb250cm9sL2NvbnRyb2wuYwot aW5kZXggMTFmNzgxNS4uOWRiYTdkZCAxMDA2NDQKK2luZGV4IDExZjc4MTUuLjkyMGIxYWYgMTAw NjQ0CiAtLS0gYS9zcmMvY29udHJvbC9jb250cm9sLmMKICsrKyBiL3NyYy9jb250cm9sL2NvbnRy b2wuYwotQEAgLTEzMzEsNyArMTMzMSwxMSBAQCBzdGF0aWMgaW50IHNuZF9jdGxfb3Blbl9jb25m KHNuZF9jdGxfdCAqKmN0bHAsIGNvbnN0IGNoYXIgKm5hbWUsCitAQCAtMTMzMSwxMyArMTMzMSwx NyBAQCBzdGF0aWMgaW50IHNuZF9jdGxfb3Blbl9jb25mKHNuZF9jdGxfdCAqKmN0bHAsIGNvbnN0 IGNoYXIgKm5hbWUsCiAgCQkJYnVpbGRfaW4rKzsKICAJCX0KICAJCWlmICgqYnVpbGRfaW4gPT0g TlVMTCkgewpAQCAtMjgsNiArMjgsMTMgQEAgaW5kZXggMTFmNzgxNS4uOWRiYTdkZCAxMDA2NDQK ICAJCQlpZiAoYnVmMSA9PSBOVUxMKSB7CiAgCQkJCWVyciA9IC1FTk9NRU07CiAgCQkJCWdvdG8g X2VycjsKKyAJCQl9CisgCQkJbGliID0gYnVmMTsKKy0JCQlzcHJpbnRmKGJ1ZjEsICIlcy9saWJh c291bmRfbW9kdWxlX2N0bF8lcy5zbyIsIEFMU0FfUExVR0lOX0RJUiwgc3RyKTsKKysJCQlzcHJp bnRmKGJ1ZjEsICIlcy9saWJhc291bmRfbW9kdWxlX2N0bF8lcy5zbyIsIHBsdWdkaXIsIHN0cik7 CisgCQl9CisgCX0KKyAjaWZuZGVmIFBJQwogZGlmZiAtLWdpdCBhL3NyYy9kbG1pc2MuYyBiL3Ny Yy9kbG1pc2MuYwogaW5kZXggMzc1N2QzMy4uOTJhYTg2NCAxMDA2NDQKIC0tLSBhL3NyYy9kbG1p c2MuYwpAQCAtMTA2LDUgKzExMyw1IEBAIGluZGV4IDRlMGM3Y2EuLjg2OTRhMzggMTAwNjQ0CiAg CiAgCXJhdGUtPnJhdGVfbWluID0gU05EX1BDTV9QTFVHSU5fUkFURV9NSU47CiAtLSAKLTIuMTcu MAorMi4xNC40CiAKLS0gCjIuMTQuNAoK --=_bb5a26b59575247e5c87ce22f8328432-- ------------=_1530016562-22160-1-- From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jun 2018 13:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: Julien Lepiller , 31934-done@debbugs.gnu.org Received: via spool by 31934-done@debbugs.gnu.org id=D31934.153001796824335 (code D ref 31934); Tue, 26 Jun 2018 13:00:03 +0000 Received: (at 31934-done) by debbugs.gnu.org; 26 Jun 2018 12:59:28 +0000 Received: from localhost ([127.0.0.1]:35756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXnZA-0006KR-In for submit@debbugs.gnu.org; Tue, 26 Jun 2018 08:59:28 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXnZ8-0006KJ-Jj for 31934-done@debbugs.gnu.org; Tue, 26 Jun 2018 08:59:26 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 57FE021EE3; Tue, 26 Jun 2018 08:59:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 26 Jun 2018 08:59:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=06zKtzuDwW7INLEcF0b5W0pGXUPs3dtCCf1y8eSpkXY=; b=FmdHUI18 oo8nCyeSX9Ka6TPad37t++acpRFRvLEwdhWAwabQ3ahSbV6RSRSEUINeiZvkUoTB NkOZFZafy6SS7GuGzHSJfkXJ/Ss+kpG1tmAFijdwzrgQ9xIOSqXCufDAhVZQuQOm +94q/9bujwdpKqdogEBrRud5R5tlLC804oYjmjwA/I0GAI3Kbhs8inDJdN/ApP20 PZZfAtQM0D4uAU474IS3UyEkkJnS6FW34p6z4iUu1vYF2lkRHIPr6CpkrSe1aVJ9 Bwf5XMZ1L+aciQ71WZbmX5uHM3KW6Wxpwzm3FUzMJt+qK9M9+jZ4whVNmA9KE0aq UPDV4rluhJUy7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=06zKtzuDwW7INLEcF0b5W0pGXUPs3 dtCCf1y8eSpkXY=; b=svTPSVGfJbcf+6MhJH5SNkMH7A6O2WEb2A5uE9eQcSui1 LX9SP/O56hCdHIvuYWVI2AyX/yFBAuFdq/vmiEf/ADNWd38Ijv+6RQ0oubBbF05n ZB+LufvmtTBn+fRyg4iqHKHhwjj7EIZiiZjmpSSc01Bn25jGo0VkW46xrB4h1L17 fvt1qtfBSTZ7ur8NZUPoSbfxx76YtZS94++2btBwtlWqfj96WAxYiSRHbmfX9ihZ FvFOFQSkFjPJvgGqjL3ku8rKdWv8QCkUQACjEhvr4cHwp+6gDiGIurvsd62kCXux Kl0ea+BTL9scaFVQmnfnx28IWHKEPr1Ms3IHb1eIw== X-ME-Proxy: X-ME-Sender: Received: from localhost (cm-84.214.174.185.getinternet.no [84.214.174.185]) by mail.messagingengine.com (Postfix) with ESMTPA id D46B610293; Tue, 26 Jun 2018 08:59:25 -0400 (EDT) From: Marius Bakke In-Reply-To: <87k1qld8uq.fsf@member.fsf.org> References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> <876026ev7u.fsf@member.fsf.org> <989ad55f9f17664af266f1f9f5653583@lepiller.eu> <87o9fxdbgb.fsf@member.fsf.org> <87po0dydgf.fsf@fastmail.com> <87k1qld8uq.fsf@member.fsf.org> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Tue, 26 Jun 2018 14:59:24 +0200 Message-ID: <87muvhya8j.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > Marius Bakke writes: > >> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: >> >>> Julien Lepiller writes: >>> >>>> Le 2018-06-25 17:34, iyzsong@member.fsf.org a =C3=A9crit=C2=A0: >>>>> Oleg Pykhalov writes: >>>>> >>>>>> Hello, >>>>>> >>>>>> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: >>>>>> >>>>>>> Julien Lepiller writes: >>>>>> >>>>>> [=E2=80=A6] >>>>>> >>>>>>> Hello, after some hours of searching... I found that we can use the >>>>>>> 'lib' option in 'pcm_type' and 'ctl_type' to specify the library pa= th >>>>>>> for alsa plugins, e.g: >>>>>> >>>>>> Thats a nice hack :-) Thank you for working on this. >>>>>> >>>>>> [=E2=80=A6] >>>>>> >>>>>>> So I think we can make our 'alsa-service' do this, instead of >>>>>>> patching >>>>>>> alsa-lib for 'ALSA_PLUGIN_DIR'. >>>>>> >>>>>> Done. Here is a patch which I tested on my machine by =E2=80=98syst= em >>>>>> reconfigure=E2=80=99: >>>>>> >>>>> >>>>> Thank you, I modified it to keep the 'pulseaudio? #f' function, and >>>>> pushed :-) >>>> >>>> So maybe we can drop our ALSA_PLUGIN_DIR patch now? >>> >>> Yes, I think so. @Ricardo, should we do it in core-updates? >> >> If you're quick, you can do it on 'staging' which I'll attempt to >> re-start during today. > > Done, thanks! Thanks! I've spun the Hydra lucky wheel: https://hydra.gnu.org/jobset/gnu/staging If we won, the new build jobs will start in about 8 hours. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsyOKwACgkQoqBt8qM6 VPp9eQf4sBS43Q+TsSJ0l096aovA+A/OplegobJMhMl2kZCGdPXblYHP7jIHCdW9 NNQe9pKAJ72Or98QSeJYc+K6pU6e7ya8axXICKwqhcPXMNbXdovqzTbDojtvqH4F U2sxO/Rbe7AikD60cJWwvd+f07lfp2U0tclerfvIHV2NqLcRy/qLuC3YgwWtM70j zu3Y+mHaIijLgvFFCIDSzMl5o7+xR7+bOXiu79GAXe1cbM5Y3UusVXe+I2OQkguL asa6We7bcpr6BfUGmoDhW2bFyaQmpnk6gzd8PIYAaIgYp3WDftWd0rgjEek+YtK1 dRRCF3Wsmy+GL9iL1NGQJB5EyH9L =EwHY -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 11:41:08 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#31934] [PATCH] services: sound: Properly handle alsa-plugins. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jun 2018 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 31934@debbugs.gnu.org Received: via spool by 31934-submit@debbugs.gnu.org id=B31934.153002179431097 (code B ref 31934); Tue, 26 Jun 2018 14:04:02 +0000 Received: (at 31934) by debbugs.gnu.org; 26 Jun 2018 14:03:14 +0000 Received: from localhost ([127.0.0.1]:36311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXoYq-00085T-DL for submit@debbugs.gnu.org; Tue, 26 Jun 2018 10:03:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXoYp-00085F-IB for 31934@debbugs.gnu.org; Tue, 26 Jun 2018 10:03:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXoYe-0001b6-JX for 31934@debbugs.gnu.org; Tue, 26 Jun 2018 10:03:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXoYe-0001Zk-Fg; Tue, 26 Jun 2018 10:03:00 -0400 Received: from [193.50.110.137] (port=37216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fXoYe-0006u6-0z; Tue, 26 Jun 2018 10:03:00 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87a7rkhdg2.fsf@member.fsf.org> <87h8lso449.fsf_-_@gmail.com> <876026ev7u.fsf@member.fsf.org> <989ad55f9f17664af266f1f9f5653583@lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Messidor an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 26 Jun 2018 16:02:58 +0200 In-Reply-To: <989ad55f9f17664af266f1f9f5653583@lepiller.eu> (Julien Lepiller's message of "Mon, 25 Jun 2018 17:37:56 +0200") Message-ID: <8736x94pd9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Julien Lepiller skribis: > So maybe we can drop our ALSA_PLUGIN_DIR patch now? It may still be useful on foreign distros, no? Ludo=E2=80=99.