GNU bug report logs - #31929
27.0.50; Have make install copy the emacs-module.h to the destination install dir

Previous Next

Package: emacs;

Reported by: Kaushal Modi <kaushal.modi <at> gmail.com>

Date: Thu, 21 Jun 2018 16:05:01 UTC

Severity: minor

Merged with 32763, 33228

Found in versions 26.1, 27.0.50

Fixed in versions 26.2, 27.1

Done: Philipp Stephani <p.stephani2 <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: p.stephani2 <at> gmail.com, 31929 <at> debbugs.gnu.org, kaushal.modi <at> gmail.com
Subject: bug#31929: [PATCH] Install emacs-module.h (Bug#31929)
Date: Mon, 15 Oct 2018 16:04:49 -0400
Eli Zaretskii wrote:

>> After the fact, I'm wondering if this should obey the EMACS_NAME
>> transformation? My initial feeling is, yes.
>
> I'm not sure.  If we edit the name, a given module couldn't be
> compiled against differently-named Emacs distributions, which I think
> is undesirable. 

I think it is what users of the --program-prefix|suffix|transform
configure options will probably expect to happen.
Ie if someone wants "emacs" installed as "emacs27", I think they want
"emacs27-module.h" as well.

> Lastly, we name the file explicitly in the documentation.

The documentation also names eg the "emacs" and "emacslient"
executables, which are rather more fundamental. The documentation does
not account for the --program-transform etc options anywhere, and I
don't think it should. It's a specialized feature, and people who use it
should be able to deal with the consequences.





This bug report was last modified 6 years and 199 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.