GNU bug report logs - #31929
27.0.50; Have make install copy the emacs-module.h to the destination install dir

Previous Next

Package: emacs;

Reported by: Kaushal Modi <kaushal.modi <at> gmail.com>

Date: Thu, 21 Jun 2018 16:05:01 UTC

Severity: minor

Merged with 32763, 33228

Found in versions 26.1, 27.0.50

Fixed in versions 26.2, 27.1

Done: Philipp Stephani <p.stephani2 <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #21 received at 31929 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: phst <at> google.com, 31929 <at> debbugs.gnu.org
Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929)
Date: Fri, 21 Sep 2018 18:56:37 +0200

[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> schrieb am Fr., 21. Sep. 2018 um 15:46 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Fri, 21 Sep 2018 15:27:48 +0200
> > Cc: Philipp Stephani <phst <at> google.com>
> >
> > +     $(MKDIR_P) -m 0755 $(includedir)
> > +     $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h
>
> Thanks.  I wonder whether we should install in $(includedir)/emacs.
> It sounds rude to me to invade the top-level include directory; other
> packages install into package-specific subdirectories.
>

I think it's not necessary to include "emacs" twice in the file name: using
"emacs-module.h" should already be unique enough, and including "emacs"
twice doesn't make it more unique.


>
> If you agree, we may need to change mod-test.c and perhaps also the
> place where we keep emacs-module.h in the Emacs tree.
>
> We should also think what will happen when we change the interface in
> some backward-incompatible way: how do we allow end-users to compile
> modules for several Emacs versions on the same system? does that
> require a new version of the header, or can we provide a header that
> will work with any Emacs version?
>

I don't think we can ever have backward-incompatible changes: only
additions are possible. This isn't different from other headers. That is,
the header for version N should also work for all versions older than N.

[Message part 2 (text/html, inline)]
This bug report was last modified 6 years and 199 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.