GNU bug report logs - #31929
27.0.50; Have make install copy the emacs-module.h to the destination install dir

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: phst <at> google.com, 31929 <at> debbugs.gnu.org
Subject: bug#31929: [PATCH] Install emacs-module.h (Bug#31929)
Date: Fri, 21 Sep 2018 16:45:34 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Fri, 21 Sep 2018 15:27:48 +0200
> Cc: Philipp Stephani <phst <at> google.com>
> 
> +	$(MKDIR_P) -m 0755 $(includedir)
> +	$(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h

Thanks.  I wonder whether we should install in $(includedir)/emacs.
It sounds rude to me to invade the top-level include directory; other
packages install into package-specific subdirectories.

If you agree, we may need to change mod-test.c and perhaps also the
place where we keep emacs-module.h in the Emacs tree.

We should also think what will happen when we change the interface in
some backward-incompatible way: how do we allow end-users to compile
modules for several Emacs versions on the same system? does that
require a new version of the header, or can we provide a header that
will work with any Emacs version?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.