From unknown Tue Jun 17 20:17:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31929 <31929@debbugs.gnu.org> To: bug#31929 <31929@debbugs.gnu.org> Subject: Status: 27.0.50; Have make install copy the emacs-module.h to the destination install dir Reply-To: bug#31929 <31929@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:17:16 +0000 retitle 31929 27.0.50; Have make install copy the emacs-module.h to the des= tination install dir reassign 31929 emacs submitter 31929 Kaushal Modi severity 31929 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 21 12:04:54 2018 Received: (at submit) by debbugs.gnu.org; 21 Jun 2018 16:04:55 +0000 Received: from localhost ([127.0.0.1]:59314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW24s-0003fr-MY for submit@debbugs.gnu.org; Thu, 21 Jun 2018 12:04:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fW24q-0003fe-JX for submit@debbugs.gnu.org; Thu, 21 Jun 2018 12:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fW24k-0002J9-Nc for submit@debbugs.gnu.org; Thu, 21 Jun 2018 12:04:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55746) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fW24k-0002J5-Jp for submit@debbugs.gnu.org; Thu, 21 Jun 2018 12:04:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW24h-0007v3-S2 for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 12:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fW24h-0002FM-3G for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 12:04:43 -0400 Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:43743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fW24g-0002Ev-RJ for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 12:04:43 -0400 Received: by mail-lf0-x22a.google.com with SMTP id x13-v6so5064106lff.10 for ; Thu, 21 Jun 2018 09:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=+loHRY8pFs30gO2QzShFjGBRx6iBnpmKe7xoKAezqhg=; b=eJSV0Aow/mTdyveJMfRcDvuyYVErY5HPliITd+HuUUrvax/3QrOjH2ZaEooTRPTo0n kAN3G+OlQ+Q0XVald46An++9PyUy0uS4gWPcRbZ9t6CW9s15YbBkpO1W9YSm6Rhr1n46 bzl/nNI6Nfnx4OZOrmisGjcyRX1X45grMuM1xii9rcmnlYUuSeWdU32ir9EXYapm8z8f Z7DwDu35SFsdZSbfkNTR3FgQl69QTUUbvP6rW9GauLn0yBOg8FuzNyA4oIGEWeK3IC7g TJrFpEFknbGYg70WyDLlgGjrxI5w446UaxnO5yw9+Ndp3iCoa2Nmtt5HoNuiJR813AR4 axNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+loHRY8pFs30gO2QzShFjGBRx6iBnpmKe7xoKAezqhg=; b=cuWHksaRplxejME5lTu2hh1DeViVT4rNOfnkJiP3iuVidHGbERb8ubgwGLhdUA5f2V BbKdOAX7fcu+c1B7FBkkSeT4GgmVO77NkY8p0ZMMqe6A6EgBTUCFrkKVKoQ70damx23L gAlA+rGt3uKMsYfq+6i4+IhxDWclR45SanLXabqa87Vi3F/a2f1ja63AGhzhQ3F1hRcP /WEb9KO/g3gDE8JPr8ThuuAwj51b2Zz4QVf3h61Odu1er4EOPZFFXHegMeC7MzgwcD78 auKmw+/itnvWntRoiZa6pdyX3NjMwtTJ51xbEHTvqUS/Q/lKrDy1Wl19L576dRKhsMYQ 7Y7g== X-Gm-Message-State: APt69E1m/WLa/Ze/kVV6/coQBCxwjAmnDgSdAn6Ak+VN8ZreFUTiKg0q nYp7m3uMW84Z1IKoudZAJT/xRE9c16lWOP0RINI= X-Google-Smtp-Source: ADUXVKIb1KuwSnvIZVW2IN3XT0G5mPz5MKlRz8Wcgwc7PU3IySkJGsZ3RpsuP8BwIVq7pGE2R5vZr1pEpvHrehqy+bM= X-Received: by 2002:a19:4342:: with SMTP id m2-v6mr11942184lfj.72.1529597081207; Thu, 21 Jun 2018 09:04:41 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Thu, 21 Jun 2018 12:04:28 -0400 Message-ID: Subject: 27.0.50; Have make install copy the emacs-module.h to the destination install dir To: "bug-gnu-emacs@gnu.org" Content-Type: multipart/alternative; boundary="000000000000acc890056f29120c" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --000000000000acc890056f29120c Content-Type: text/plain; charset="UTF-8" Hello, When building emacs locally, the emacs-module.h is not copied over to an include/ directory in the destination installation directory. This prevents one to have version-specific emacs-module.h for folks building emacs themselves. Ref: https://lists.gnu.org/r/help-gnu-emacs/2018-06/msg00303.html -- Kaushal Modi --000000000000acc890056f29120c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

When building emacs l= ocally, the emacs-module.h is not copied over to an include/ directory in t= he destination installation directory. This prevents one to have version-sp= ecific emacs-module.h for folks building emacs themselves.
--

Kaushal Modi

--000000000000acc890056f29120c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 14:19:23 2018 Received: (at control) by debbugs.gnu.org; 18 Sep 2018 18:19:23 +0000 Received: from localhost ([127.0.0.1]:44746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Kap-0002kd-9F for submit@debbugs.gnu.org; Tue, 18 Sep 2018 14:19:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Kan-0002kQ-Ui for control@debbugs.gnu.org; Tue, 18 Sep 2018 14:19:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Kai-000604-Dw for control@debbugs.gnu.org; Tue, 18 Sep 2018 14:19:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Kai-0005zy-AT for control@debbugs.gnu.org; Tue, 18 Sep 2018 14:19:16 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g2Kai-0004DI-7L for control@debbugs.gnu.org; Tue, 18 Sep 2018 14:19:16 -0400 Subject: control message for bug 32763 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 18 Sep 2018 14:19:16 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) forcemerge 31929 32763 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 14:33:26 2018 Received: (at control) by debbugs.gnu.org; 18 Sep 2018 18:33:26 +0000 Received: from localhost ([127.0.0.1]:44761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2KoQ-000598-3G for submit@debbugs.gnu.org; Tue, 18 Sep 2018 14:33:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2KoO-00058s-Q4 for control@debbugs.gnu.org; Tue, 18 Sep 2018 14:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2KoC-00086S-GT for control@debbugs.gnu.org; Tue, 18 Sep 2018 14:33:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2KoA-000862-2t; Tue, 18 Sep 2018 14:33:10 -0400 Received: from [176.228.60.248] (port=3581 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g2Ko6-0003Cw-SS; Tue, 18 Sep 2018 14:33:08 -0400 Date: Tue, 18 Sep 2018 21:33:06 +0300 Message-Id: <83bm8ufyfx.fsf@gnu.org> From: Eli Zaretskii To: Vasilij Schneidermann In-reply-to: <20180918180810.yu2em4j4635xbou4@odonien.localdomain> (message from Vasilij Schneidermann on Tue, 18 Sep 2018 20:08:10 +0200) Subject: Re: bug#32763: 26.1; emacs-module.h isn't installed with Emacs for module development References: <20180918180810.yu2em4j4635xbou4@odonien.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control Cc: 32763@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 32763 31929 thanks > Date: Tue, 18 Sep 2018 20:08:10 +0200 > From: Vasilij Schneidermann > > I've recently developed a simple module and ran into a surprising issue > with the skeleton: I couldn't locate the emacs-module.h in my system > matching the Emacs installation the module is compiled against. I > eventually gave up and just bundled the emacs-module.h from a Git > checkout with my module's source code. It makes up for most of the code > in the project. Yes, this is bug#31929. The header should be installed by "make install" into the system header file's tree. > Is this an oversight in the installation process or a deliberate > design decision? Oversight. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 09:28:17 2018 Received: (at 31929) by debbugs.gnu.org; 21 Sep 2018 13:28:17 +0000 Received: from localhost ([127.0.0.1]:47744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3LTl-000061-BX for submit@debbugs.gnu.org; Fri, 21 Sep 2018 09:28:17 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:36809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3LTj-00005m-Iz for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 09:28:16 -0400 Received: by mail-wr1-f45.google.com with SMTP id e1-v6so12886861wrt.3 for <31929@debbugs.gnu.org>; Fri, 21 Sep 2018 06:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UXsqqtbQ4ZfKKK6VDAk9Ql85/KCNE5q/qiBwJ3/NT/0=; b=fgUqKmx1OGrs68v7exAzCLBFN7LZGJmCnUFwJwc9203WpHnL30KtdUCrQNPwKxJUcZ FU/SyiAFYfOJtFZFsgqkq+cw1KivsOYIDSnDtqY8Bm+8CbSIpZsolKwEhta5a3M9pZiQ 8jwI1meyfhyPxoVViz5sv8g3X+bzd/Z3tZYi6/RpxtGt4OjfSdio3aqHQNt/4oJbAT1T VN85fQu9pUCZKojN+A4OMgjyHGLybTHTU7YBPkZzbQNKYgc5Wa/4GXsmBLMU/+VLv7SE CHgfV9dZajoB6nmAOPxmUz2geIs2DEPCpOCZfumv2Itx/eS4aAMmW8EaqLsCmJuRP5P3 JpHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UXsqqtbQ4ZfKKK6VDAk9Ql85/KCNE5q/qiBwJ3/NT/0=; b=cicDs2m0Kr22EHx/XR/yEBH0/80ZCMDxiqyYryK1b2oq+xuY29CB3IQPW7p78ZvwMY oTaVqrAASuBAKIfoPIP+OqZP9k89lR7i7nQ6hidpOJrpVtdsklMFvEUJS8os9zKli4Mi 0RJRgG4LtKkEZ8S+FaNsu6IfZT6SbIh9RcM30U/DCCxixN5dvhbhq0SfY6/gTb6QBL9n LfJNENqN5zI6mODM20mrZmw4qRQHVnLOLZotEihfyrnF3PMijh0QmZGZTyqTeeCnvh+A GY31Y84tXmRra8yppXpPvryw7S2DqVSXBySPsyTBRNUQuiLuq5fFEQyRA5W+DaKNEMJ5 NfRg== X-Gm-Message-State: ABuFfohPJBJV+5WILVOM4A/9x101JHG39Y6qtxaKDnvMFj4KMqGbAuEx NFPDJC0GNNYYZstaLE86kpQC5Yp4 X-Google-Smtp-Source: ACcGV60PMzrmAlKv8XOeUez1JU+NRh4knOm5Z5wtJNOalQnmYf8vjxUN5ERIo9l3QDqle0aW0YINkw== X-Received: by 2002:adf:f842:: with SMTP id d2-v6mr6500910wrq.172.1537536489158; Fri, 21 Sep 2018 06:28:09 -0700 (PDT) Received: from p.fritz.box (p5B13F720.dip0.t-ipconnect.de. [91.19.247.32]) by smtp.gmail.com with ESMTPSA id v2-v6sm24456403wrs.54.2018.09.21.06.28.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Sep 2018 06:28:08 -0700 (PDT) From: Philipp Stephani X-Google-Original-From: Philipp Stephani To: 31929@debbugs.gnu.org Subject: [PATCH] Install emacs-module.h (Bug#31929) Date: Fri, 21 Sep 2018 15:27:48 +0200 Message-Id: <20180921132748.95945-1-phst@google.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 31929 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * Makefile.in (includedir): New variable. (install-arch-indep): Install emacs-module.h. (uninstall): Uninstall emacs-module.h. --- Makefile.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Makefile.in b/Makefile.in index 19bf7c423f..5346429264 100644 --- a/Makefile.in +++ b/Makefile.in @@ -151,6 +151,9 @@ libexecdir= # Currently only used for the systemd service file. libdir=@libdir@ +# Where to install emacs-module.h. +includedir=@includedir@ + # Where to install Emacs's man pages. # Note they contain cross-references that expect them to be in section 1. mandir=@mandir@ @@ -558,6 +561,8 @@ set_installuser= ## See also these comments from 2004 about cp -r working fine: ## https://lists.gnu.org/r/autoconf-patches/2004-11/msg00005.html install-arch-indep: lisp install-info install-man ${INSTALL_ARCH_INDEP_EXTRA} + $(MKDIR_P) -m 0755 $(includedir) + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h -set ${COPYDESTS} ; \ unset CDPATH; \ $(set_installuser); \ @@ -741,6 +746,7 @@ install-strip: ### ### Don't delete the lisp and etc directories if they're in the source tree. uninstall: uninstall-$(NTDIR) uninstall-doc + rm -f $(includedir)/emacs-module.h $(MAKE) -C lib-src uninstall -unset CDPATH; \ for dir in "$(DESTDIR)${lispdir}" "$(DESTDIR)${etcdir}" ; do \ -- 2.19.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 09:46:03 2018 Received: (at 31929) by debbugs.gnu.org; 21 Sep 2018 13:46:03 +0000 Received: from localhost ([127.0.0.1]:47751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Lkw-0000XR-Vd for submit@debbugs.gnu.org; Fri, 21 Sep 2018 09:46:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Lku-0000Ww-VS for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 09:46:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Lko-0002zs-Uh for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 09:45:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Lkk-0002sk-N1; Fri, 21 Sep 2018 09:45:50 -0400 Received: from [176.228.60.248] (port=1886 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g3Lkk-0006oM-41; Fri, 21 Sep 2018 09:45:50 -0400 Date: Fri, 21 Sep 2018 16:45:34 +0300 Message-Id: <83va6zc6bl.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: <20180921132748.95945-1-phst@google.com> (message from Philipp Stephani on Fri, 21 Sep 2018 15:27:48 +0200) Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: phst@google.com, 31929@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Philipp Stephani > Date: Fri, 21 Sep 2018 15:27:48 +0200 > Cc: Philipp Stephani > > + $(MKDIR_P) -m 0755 $(includedir) > + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h Thanks. I wonder whether we should install in $(includedir)/emacs. It sounds rude to me to invade the top-level include directory; other packages install into package-specific subdirectories. If you agree, we may need to change mod-test.c and perhaps also the place where we keep emacs-module.h in the Emacs tree. We should also think what will happen when we change the interface in some backward-incompatible way: how do we allow end-users to compile modules for several Emacs versions on the same system? does that require a new version of the header, or can we provide a header that will work with any Emacs version? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 11:36:35 2018 Received: (at 31929) by debbugs.gnu.org; 21 Sep 2018 15:36:36 +0000 Received: from localhost ([127.0.0.1]:48370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3NTv-0003dY-Ny for submit@debbugs.gnu.org; Fri, 21 Sep 2018 11:36:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3NTu-0003dM-7f for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 11:36:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3NTn-0005bq-Bm for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 11:36:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3NTl-0005Y3-0h; Fri, 21 Sep 2018 11:36:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g3NTe-0006uy-G3; Fri, 21 Sep 2018 11:36:19 -0400 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> X-Spook: al-Qaida Emergency underground Rubin ANZUS Attorney X-Ran: 9$a$oTvUs6!DHxoee/;KhXy+LpjDaCS$!XUZoDb"WBH;\^YjfHH+|eXEx_bZDY|vLI4{'U X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 21 Sep 2018 11:36:17 -0400 In-Reply-To: <20180921132748.95945-1-phst@google.com> (Philipp Stephani's message of "Fri, 21 Sep 2018 15:27:48 +0200") Message-ID: <0d7ejerhfy.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: Philipp Stephani , 31929@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Philipp Stephani wrote: > + $(MKDIR_P) -m 0755 $(includedir) I don't remember how portable that is, but everywhere else in Emacs's Makefiles uses: umask 022 && ${MKDIR_P} "...". And should this file only be installed in a --with-modules build? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 12:56:58 2018 Received: (at 31929) by debbugs.gnu.org; 21 Sep 2018 16:56:58 +0000 Received: from localhost ([127.0.0.1]:48415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Ojh-0005lU-Rl for submit@debbugs.gnu.org; Fri, 21 Sep 2018 12:56:58 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:39513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Ojf-0005lH-Pd for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 12:56:56 -0400 Received: by mail-ot1-f54.google.com with SMTP id c12-v6so13666174otl.6 for <31929@debbugs.gnu.org>; Fri, 21 Sep 2018 09:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jj1toL25r98AcV1SCYlP/S/5kDOmNWk02gZf7Ur6Xhc=; b=og3l46to5IOGaO7+jkrpXjClk17anCTZ4+vYj0HNZ7m3TZmdq/iwF3wZbFUbW5Wtrk aLziwbK5MqhQPWhzrU5ky6+VwPGdGBs5Wnv2K2FAUJgE8FaB5FqvIKuI/r5JMM/MKsj1 J3B6jmh5iTEIwA5sANejm/67tGdZ65WGA3ZyIwZ0Jk24ZoURRMP5tmN195B9f7x/4wU/ kjoM0h5cNfI+pJry61PBFs8egoclVZKlphbcZA/YwSED5FD2g7l1HUpFREnJxS1Uo2Sf XiIrgPDbbsDQj9Fy051EtX5r4hEOJO7Tm6m6rfLGZJYPX3/2j1f3kLS/Gb6RpyepbZD9 lQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jj1toL25r98AcV1SCYlP/S/5kDOmNWk02gZf7Ur6Xhc=; b=mcNgi6v0NzHjZXFeHmGTQ219kUlq26HpxlozbihqgLJBtvtQoddL1qKPRUK4MyzA4O kEqIEYBGB072g5xWNR/fMPhj2MHaiu24l+nHeVtEQXDmUEJqSkKTv4zJuUcbzhiD8ST3 ijGHTtpvhUA1OXytkZ+L6kyN9l2QPt0C3bfI+CaQI+QsJ6eKFUHkZOMUvmFp2umezjEu 7SA66twA4OhY/6iebOyYfE+eqE4xxh3nMFty5ttCqHJsHCClpxNgPTghyF5c8hJcWr3p 5RRmi2Q+hatky8op0bQcLuuQvEO7c1SjKGWjTLQuQXOrJiMdVWGqNbt03BWO+AFGOaFs YRMA== X-Gm-Message-State: APzg51Cq5t+pbJsWcu/viAfFEDytI8WTzdQCGv3y8B5+qbbwqkrstXXO Jye3meKut/PFtLkeEdjdc2wNOf/t+zqRAW4L6fg= X-Google-Smtp-Source: ANB0VdaD2XVd1a9CqSTejrjsxB8MocqMm8sGT+vgly2KJXjh1e8xEhYvcwozpqWWlS1bBhO73cRLpDckfWb+E0EDHUE= X-Received: by 2002:a9d:d7:: with SMTP id 23-v6mr24348678otk.372.1537549009576; Fri, 21 Sep 2018 09:56:49 -0700 (PDT) MIME-Version: 1.0 References: <20180921132748.95945-1-phst@google.com> <83va6zc6bl.fsf@gnu.org> In-Reply-To: <83va6zc6bl.fsf@gnu.org> From: Philipp Stephani Date: Fri, 21 Sep 2018 18:56:37 +0200 Message-ID: Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000008a686b057664862e" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 31929 Cc: phst@google.com, 31929@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000008a686b057664862e Content-Type: text/plain; charset="UTF-8" Eli Zaretskii schrieb am Fr., 21. Sep. 2018 um 15:46 Uhr: > > From: Philipp Stephani > > Date: Fri, 21 Sep 2018 15:27:48 +0200 > > Cc: Philipp Stephani > > > > + $(MKDIR_P) -m 0755 $(includedir) > > + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h > > Thanks. I wonder whether we should install in $(includedir)/emacs. > It sounds rude to me to invade the top-level include directory; other > packages install into package-specific subdirectories. > I think it's not necessary to include "emacs" twice in the file name: using "emacs-module.h" should already be unique enough, and including "emacs" twice doesn't make it more unique. > > If you agree, we may need to change mod-test.c and perhaps also the > place where we keep emacs-module.h in the Emacs tree. > > We should also think what will happen when we change the interface in > some backward-incompatible way: how do we allow end-users to compile > modules for several Emacs versions on the same system? does that > require a new version of the header, or can we provide a header that > will work with any Emacs version? > I don't think we can ever have backward-incompatible changes: only additions are possible. This isn't different from other headers. That is, the header for version N should also work for all versions older than N. --0000000000008a686b057664862e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 21. Sep. 2018 um 15:46=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 21 Sep 2018 15:27:48 +0200
> Cc: Philipp Stephani <phst@google.com>
>
> +=C2=A0 =C2=A0 =C2=A0$(MKDIR_P) -m 0755 $(includedir)
> +=C2=A0 =C2=A0 =C2=A0$(INSTALL_DATA) src/emacs-module.h $(includedir)/= emacs-module.h

Thanks.=C2=A0 I wonder whether we should install in $(includedir)/emacs. It sounds rude to me to invade the top-level include directory; other
packages install into package-specific subdirectories.

I think it's not necessary to include "emacs"= twice in the file name: using "emacs-module.h" should already be= unique enough, and including "emacs" twice doesn't make it m= ore unique.
=C2=A0

If you agree, we may need to change mod-test.c and perhaps also the
place where we keep emacs-module.h in the Emacs tree.

We should also think what will happen when we change the interface in
some backward-incompatible way: how do we allow end-users to compile
modules for several Emacs versions on the same system? does that
require a new version of the header, or can we provide a header that
will work with any Emacs version?

I don= 't think we can ever have backward-incompatible changes: only additions= are possible. This isn't different from other headers. That is, the he= ader for version N should also work for all versions older than N.=C2=A0
--0000000000008a686b057664862e-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 12:57:52 2018 Received: (at 31929) by debbugs.gnu.org; 21 Sep 2018 16:57:52 +0000 Received: from localhost ([127.0.0.1]:48419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Oka-0005nA-7B for submit@debbugs.gnu.org; Fri, 21 Sep 2018 12:57:52 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:34841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3OkX-0005mu-OA for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 12:57:49 -0400 Received: by mail-ot1-f54.google.com with SMTP id j9-v6so13690132otl.2 for <31929@debbugs.gnu.org>; Fri, 21 Sep 2018 09:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eT4nQU2Bor/uo0ws1s+0tfMI17KuV8q/ZQaGQHR9fDQ=; b=Z4aurQcpVwwAXM+4+hevXWm2jPKkIPIIOm94+BgudwMZhRGlDtqvfqD3k8B6rjJntv /8okVRZBoQlSYdaG5xr5R7WR2apRixfKe4OIXAiIAOSvbLZ3RLxaEOyCAg+0FHYGz9DM tLGZk1zllxfuRuCMMzP2qkjEHf3iko046MmD2V3fPwTLEheO8VszpaKlopy/fbSnX6bm dlj2tfD2Iu/6koc2UHCxCnxrcNEHyKNfFkDAF7gO8B7xIUbaYKXvIDx+OIr1YZcv7c0D I2xfHKTEeRf8Rk6GtswBdpGCofDdoJZg0q1zYwoA3aLVIQXaboVlxwGkWqy3Y/Y9h6JC By1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eT4nQU2Bor/uo0ws1s+0tfMI17KuV8q/ZQaGQHR9fDQ=; b=nm/2Q7RY5msHFjVA+t0hxbeqXyd6FKmY3T66HP55MHzEwvklZjj3mXEtmg2mEYp0Q9 1xSgz/cTQuI/r+U+10ossITJ1A6wMXulC7Kk9+B4IvJqDn0tgZE6hkrt0/qecMiKA89y ufn2QFcgr+ph+bdUuBzmB5H0NXJutgXYqIlhUDQnJ1JN6x5Raj4zj7BiWJXnJ0zPcFAa IbcmE1fi9vOq5hk9OkcG7WlArwN7zWcIYX12gVqDwNApICjGIiPJJiu6Hf6mu/699ll0 QwDj78cdsi5tMVwunwGboBswlGHUw3X1Xai8HDIhzGfqwCRxLz4nEtHeSTsAokj9go7w FzHA== X-Gm-Message-State: APzg51CtlnPs9jOwyvPP0K7YSdE/1SOv4q45JiQyMYfmoGBG8d0Fvy2h t+e9zFL4glXy9LTMZ5dn2Rj8LzUUmFUUQc+hLvM= X-Google-Smtp-Source: ANB0VdYFxsM46w6JKPx4fJfRlUXNhJqDYRHdEfzQar88SI0bUSNFk7ggCw2vrFqQM2Kk3CUeoh0hr59JnOt2rkvclIA= X-Received: by 2002:a9d:2868:: with SMTP id h37-v6mr14651858otd.42.1537549064205; Fri, 21 Sep 2018 09:57:44 -0700 (PDT) MIME-Version: 1.0 References: <20180921132748.95945-1-phst@google.com> <0d7ejerhfy.fsf@fencepost.gnu.org> In-Reply-To: <0d7ejerhfy.fsf@fencepost.gnu.org> From: Philipp Stephani Date: Fri, 21 Sep 2018 18:57:32 +0200 Message-ID: Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) To: Glenn Morris Content-Type: multipart/alternative; boundary="000000000000cbfbc2057664895d" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 31929 Cc: Philipp Stephani , 31929@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000cbfbc2057664895d Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Fr., 21. Sep. 2018 um 17:36 Uhr: > Philipp Stephani wrote: > > > + $(MKDIR_P) -m 0755 $(includedir) > > I don't remember how portable that is, but everywhere else in Emacs's > Makefiles uses: umask 022 && ${MKDIR_P} "...". > Good idea, done. > > And should this file only be installed in a --with-modules build? > I considered that, but I think it's simpler to install it unconditionally. Users can use emacs-module.h to build modules even if their version of Emacs doesn't support them. --000000000000cbfbc2057664895d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Fr= ., 21. Sep. 2018 um 17:36=C2=A0Uhr:
Philipp Stephani wrote:

> +=C2=A0 =C2=A0 =C2=A0$(MKDIR_P) -m 0755 $(includedir)

I don't remember how portable that is, but everywhere else in Emacs'= ;s
Makefiles uses: umask 022 && ${MKDIR_P} "...".

Good idea, done.
=C2=A0

And should this file only be installed in a --with-modules build?

I considered that, but I think it's simpler = to install it unconditionally. Users can use emacs-module.h to build module= s even if their version of Emacs doesn't support them.=C2=A0
--000000000000cbfbc2057664895d-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 16:02:27 2018 Received: (at 31929-done) by debbugs.gnu.org; 3 Oct 2018 20:02:27 +0000 Received: from localhost ([127.0.0.1]:36094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7nLm-0003K7-OP for submit@debbugs.gnu.org; Wed, 03 Oct 2018 16:02:27 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:33626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7nLl-0003Jw-KM for 31929-done@debbugs.gnu.org; Wed, 03 Oct 2018 16:02:26 -0400 Received: by mail-ot1-f67.google.com with SMTP id q50so2698948otd.0 for <31929-done@debbugs.gnu.org>; Wed, 03 Oct 2018 13:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4w9eTS2C+4LEH5xxv/M/hETpCGOk72isPAPwALLUERQ=; b=qAlPLddyLYYGwEcGJHeCic/f/KeDCeXnfKJ5C3BpM58kSLhYuYjHwYSZH7d4I4CsK7 2h2K3L6pfErWsl+jdIBNBhGGzCy6swJ0rz/oRdd7KRnAE3q9TWXM1HXEs1DJNdfWGtVA xw0Vp7aWMoqtKAXkHn3+yplAskn4UG40VTvaBXl1TjI09KIZQ1VFlO0WhvXlxvfGqFQT E4lRykXA/3q86OCC3KxSMpXv+o8tT2HBRKI4CukQhrwKRKRxJI6ITkYKdb2bLbfPLazr R8wjd/QI/1djkFpK+/n+drDIKgbUx112w3FK4dkkC9BErKzjtTcU2WwvFI3U5QYFpsBQ O4wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4w9eTS2C+4LEH5xxv/M/hETpCGOk72isPAPwALLUERQ=; b=B80y1j8TrRRH+NOL63ooesmZlL/YuJOK6dvjjTTvDLlc4+j2mVS3v95VV6ocGOZlpZ DRVqZg6g/XFXcANdFDXar6y6lqD6fD2ys2arLh5nuDLPdCevQlkWY7PqoUyfPV9kZEIE ANMtxZDt+bXD+vXi3saBoBmC1ZBCEjMF/cpmWZuJOrF6OZ8SMfEszZZ4OPhTrRbV9zol LFsS+B4r5NkfFnaCuKAtZtOo8evt6R4tZVE7OHqUNqY1eNvaM47Nl4155ap9X6eFVTfk kIEZngTl3b9qXqCw+8/3z/1u6rXlbEytHCSaRh0sS3lhC9XaATqEY4nkeQ4ZDyaylpVd oMcA== X-Gm-Message-State: ABuFfogvQacxR5v4NdoxEI3D+MaqtwHSrbGN+a0sAgRdeHvkCetLFGBW 8z5cZMz1D5+wOyvR0VOg3b9HLmQTgwFh20Eq7C/3sQYN X-Google-Smtp-Source: ACcGV61arTgNID7mT/wjhiHWh7rkctcd003qpr3L6f9xRzSsRtB2rpiNqT4GZKLwop6nwGs6zoVLOcaTnocbOdpM3/Q= X-Received: by 2002:a9d:4b89:: with SMTP id k9-v6mr1705012otf.51.1538596939718; Wed, 03 Oct 2018 13:02:19 -0700 (PDT) MIME-Version: 1.0 References: <20180921132748.95945-1-phst@google.com> In-Reply-To: <20180921132748.95945-1-phst@google.com> From: Philipp Stephani Date: Wed, 3 Oct 2018 22:02:08 +0200 Message-ID: Subject: Re: [PATCH] Install emacs-module.h (Bug#31929) To: 31929-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="0000000000000b65990577588434" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 31929-done Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000000b65990577588434 Content-Type: text/plain; charset="UTF-8" Since there were no more comments, I've installed (a tiny variant of) this patch as 00ea749f2a. Philipp Stephani schrieb am Fr., 21. Sep. 2018 um 15:28 Uhr: > * Makefile.in (includedir): New variable. > (install-arch-indep): Install emacs-module.h. > (uninstall): Uninstall emacs-module.h. > --- > Makefile.in | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Makefile.in b/Makefile.in > index 19bf7c423f..5346429264 100644 > --- a/Makefile.in > +++ b/Makefile.in > @@ -151,6 +151,9 @@ libexecdir= > # Currently only used for the systemd service file. > libdir=@libdir@ > > +# Where to install emacs-module.h. > +includedir=@includedir@ > + > # Where to install Emacs's man pages. > # Note they contain cross-references that expect them to be in section 1. > mandir=@mandir@ > @@ -558,6 +561,8 @@ set_installuser= > ## See also these comments from 2004 about cp -r working fine: > ## https://lists.gnu.org/r/autoconf-patches/2004-11/msg00005.html > install-arch-indep: lisp install-info install-man > ${INSTALL_ARCH_INDEP_EXTRA} > + $(MKDIR_P) -m 0755 $(includedir) > + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h > -set ${COPYDESTS} ; \ > unset CDPATH; \ > $(set_installuser); \ > @@ -741,6 +746,7 @@ install-strip: > ### > ### Don't delete the lisp and etc directories if they're in the source > tree. > uninstall: uninstall-$(NTDIR) uninstall-doc > + rm -f $(includedir)/emacs-module.h > $(MAKE) -C lib-src uninstall > -unset CDPATH; \ > for dir in "$(DESTDIR)${lispdir}" "$(DESTDIR)${etcdir}" ; do \ > -- > 2.19.0 > > --0000000000000b65990577588434 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Since there were no more comments, I've installed (a t= iny variant of) this patch as 00ea749f2a.

Philipp Stephani <p.stephani2@gmail.com> schrieb am Fr., 21. Sep. 2018 um 15:28= =C2=A0Uhr:
* Makefile.in (includedi= r): New variable.
(install-arch-indep): Install emacs-module.h.
(uninstall): Uninstall emacs-module.h.
---
=C2=A0Makefile.in | 6 ++++++
=C2=A01 file changed, 6 insertions(+)

diff --git a/Makefile.in b/Makefile.in
index 19bf7c423f..5346429264 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -151,6 +151,9 @@ libexecdir=3D
=C2=A0# Currently only used for the systemd service file.
=C2=A0libdir=3D@libdir@

+# Where to install emacs-module.h.
+includedir=3D@includedir@
+
=C2=A0# Where to install Emacs's man pages.
=C2=A0# Note they contain cross-references that expect them to be in sectio= n 1.
=C2=A0mandir=3D@mandir@
@@ -558,6 +561,8 @@ set_installuser=3D
=C2=A0## See also these comments from 2004 about cp -r working fine:
=C2=A0## https://lists.gnu.org/r/autoc= onf-patches/2004-11/msg00005.html
=C2=A0install-arch-indep: lisp install-info install-man ${INSTALL_ARCH_INDE= P_EXTRA}
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(MKDIR_P) -m 0755 $(includedir)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(INSTALL_DATA) src/emacs-module.h $(includedir= )/emacs-module.h
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -set ${COPYDESTS} ; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 unset CDPATH; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(set_installuser); \
@@ -741,6 +746,7 @@ install-strip:
=C2=A0###
=C2=A0### Don't delete the lisp and etc directories if they're in t= he source tree.
=C2=A0uninstall: uninstall-$(NTDIR) uninstall-doc
+=C2=A0 =C2=A0 =C2=A0 =C2=A0rm -f $(includedir)/emacs-module.h
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(MAKE) -C lib-src uninstall
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -unset CDPATH; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 for dir in "$(DESTDIR)${lispdir}" &qu= ot;$(DESTDIR)${etcdir}" ; do=C2=A0 =C2=A0 \
--
2.19.0

--0000000000000b65990577588434-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 16:28:23 2018 Received: (at 31929) by debbugs.gnu.org; 3 Oct 2018 20:28:23 +0000 Received: from localhost ([127.0.0.1]:36111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7nks-0003yg-DS for submit@debbugs.gnu.org; Wed, 03 Oct 2018 16:28:23 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:36618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7nkp-0003yO-U9 for 31929@debbugs.gnu.org; Wed, 03 Oct 2018 16:28:20 -0400 Received: by mail-lj1-f194.google.com with SMTP id p89-v6so6364503ljb.3 for <31929@debbugs.gnu.org>; Wed, 03 Oct 2018 13:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=1vOQ6Ll5Obcfe9upTO3+mx+50RaHP07hLwR0GWSHTOY=; b=fvIthEXINOZdm7Nh8mNEbwhJIRdvdhbt58MFqagyrp84YGmOwo5xGmWCXTSH08lEm7 tbT9n9RlbpeUh3a7jrdKbuext1DxyQSQeqUaaYCegObq88u8LL6VBSXvHLiOqI7V9qnG 1UXkNjbNVIVMOIMiyst6iH/+C6MjgXvitrx0s+QkaMg8x8XPrWo4QUCvNeqcTMzPfpKC KhuffizagImrNZ1POFmwz4zvyn2fL2YYDQmj6C51EzenEgWVfji3cgJ+A+wzZ9UxGfVa N2OUuVLIKA9U12vImUmswpratoBiyF+UIIbXRPEEQr7mghMyOi/0u8cfytbyjHwHdefr RRGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=1vOQ6Ll5Obcfe9upTO3+mx+50RaHP07hLwR0GWSHTOY=; b=QQOzdPmwbpcR0KsMm6jgIi6GbAb7LP96MXifDRdCHAMymYsaFk/R7UEg/G9shpElBY Ur29TcsHCh6A9yscNUtPMqZD6KO2cmWbCmdfTnH/zGCL4ou6FOPBb+s+5E7YTpdmtmsh wAC1bJQe2sT408+xNm9sVy1E1mAK9rOhVvClzANvs1vf8LB6G8uxZe+EOZABQNzI+lY0 t89/x6L+bQnswvtnlx7sXFFhEs3e9o+1s8vYzp3Jc28Q/sraf3xzoSux/HhaBLOPuz+X tLKB8hObKTTD/n038Jx+Acz/a+JRCsovxbdNXhrLDjYHB3vkOZt6GT8qpzK0o7c8u4pa xqvg== X-Gm-Message-State: ABuFfoiTxOde9ERkGJtug0AzRU3TqrJEKBlS9bEwCXu9L7+KlUHY0Am/ 1UhfElyLigxGpbOhoVKthNj5lHqaZqrxBphdPyaQZsjq X-Google-Smtp-Source: ACcGV621zi7YUDGoFlKMxH3bamVRaJWDGj7vuhGYGIxTJcTMMZf3ulNNa/yy2ChGTDqbWWWd9h6l0whZ3qWzpKEY4Bo= X-Received: by 2002:a2e:9e55:: with SMTP id g21-v6mr2181926ljk.116.1538598493319; Wed, 03 Oct 2018 13:28:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kaushal Modi Date: Wed, 3 Oct 2018 16:27:36 -0400 Message-ID: Subject: Re: bug#31929: closed (Re: [PATCH] Install emacs-module.h (Bug#31929)) To: 31929@debbugs.gnu.org, Philipp Stephani Content-Type: multipart/alternative; boundary="000000000000a57e62057758e0dc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000a57e62057758e0dc Content-Type: text/plain; charset="UTF-8" On Wed, Oct 3, 2018 at 4:03 PM GNU bug Tracking System wrote: > Your bug report > > #31929: 27.0.50; Have make install copy the emacs-module.h to the > destination install dir > > which was filed against the emacs package, has been closed.Since there > were no more comments, I've installed (a tiny variant of) this patch as > 00ea749f2a. > Hi Philipp, Thanks for fixing this. Interestingly this only the second email I got from GNU debbugs. The first email was acknowledge email when I filed that bug. Now when I see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31929, I notice that a lot of conversation happened, but I got none of those emails. In any case, I see that this bug was closed in http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=00ea749f2af44bff6ea8c1259477fbf0ead8a306, and that commit looks good. Thanks again. Kaushal --000000000000a57e62057758e0dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Oct 3, 2018 at 4:03 PM GNU bug Tracking System = <help-debbugs@= gnu.org> wrote:
Your bug report

#31929: 27.0.50; Have make install copy the emacs-module.h to the destinati= on install dir

which was filed against the emacs package, has been closed.Since there were= no more comments, I've installed (a tiny variant of) this patch as 00e= a749f2a.

Hi Philipp,

Thanks for fixing this. Interestingly this only the second email I g= ot from GNU debbugs. The first email was acknowledge email when I filed tha= t bug.

Now when I see https://debbugs.gnu.org/cgi/bugreport= .cgi?bug=3D31929, I notice that a lot of conversation happened, but I g= ot none of those emails.

In any case, I see that t= his bug was closed in http://git.savannah= .gnu.org/cgit/emacs.git/commit/?id=3D00ea749f2af44bff6ea8c1259477fbf0ead8a3= 06, and that commit looks good.

Thanks again.<= /div>

Kaushal
--000000000000a57e62057758e0dc-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 16:49:35 2018 Received: (at 31929) by debbugs.gnu.org; 3 Oct 2018 20:49:35 +0000 Received: from localhost ([127.0.0.1]:36125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7o5P-0004Wa-H8 for submit@debbugs.gnu.org; Wed, 03 Oct 2018 16:49:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7o5O-0004WN-84 for 31929@debbugs.gnu.org; Wed, 03 Oct 2018 16:49:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7o5H-0003Go-Lj for 31929@debbugs.gnu.org; Wed, 03 Oct 2018 16:49:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7o59-0002ty-Vc; Wed, 03 Oct 2018 16:49:21 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g7o56-0007om-Ry; Wed, 03 Oct 2018 16:49:17 -0400 From: Glenn Morris To: Kaushal Modi Subject: Re: bug#31929: closed (Re: [PATCH] Install emacs-module.h (Bug#31929)) References: X-Spook: Michoacna Trojan data haven government FSF STARLAN X-Ran: -pSwk^2XT^0dvDf(D%k)OSDkX|g"#S}NXyx[eO$4 (Kaushal Modi's message of "Wed, 3 Oct 2018 16:27:36 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: Philipp Stephani , 31929@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Kaushal Modi wrote: > Thanks for fixing this. Interestingly this only the second email I got from > GNU debbugs. The first email was acknowledge email when I filed that bug. > > Now when I see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31929, I > notice that a lot of conversation happened, but I got none of those emails. This is what happens when people don't use reply-to-all. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 16:51:22 2018 Received: (at 31929) by debbugs.gnu.org; 3 Oct 2018 20:51:22 +0000 Received: from localhost ([127.0.0.1]:36129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7o77-0004ZQ-1O for submit@debbugs.gnu.org; Wed, 03 Oct 2018 16:51:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7o75-0004ZD-Gi for 31929@debbugs.gnu.org; Wed, 03 Oct 2018 16:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7o6v-0004i4-48 for 31929@debbugs.gnu.org; Wed, 03 Oct 2018 16:51:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7o6q-0004gU-RA; Wed, 03 Oct 2018 16:51:05 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g7o6q-00083R-Mt; Wed, 03 Oct 2018 16:51:04 -0400 From: Glenn Morris To: 31929@debbugs.gnu.org Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> X-Spook: Security Council Cloud Red Cross Torreon Chemical spill X-Ran: :QZD6A}w^S=lOt4g_`,r2fmKE5yc==|-(u^1~9M;{@KX\4r*$_LIPoNowWx>p*Z)|;'njF X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 03 Oct 2018 16:51:04 -0400 In-Reply-To: (Philipp Stephani's message of "Wed, 3 Oct 2018 22:02:08 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: p.stephani2@gmail.com, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) After the fact, I'm wondering if this should obey the EMACS_NAME transformation? My initial feeling is, yes. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 03 16:52:56 2018 Received: (at control) by debbugs.gnu.org; 3 Oct 2018 20:52:56 +0000 Received: from localhost ([127.0.0.1]:36133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7o8d-0004bx-PY for submit@debbugs.gnu.org; Wed, 03 Oct 2018 16:52:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7o8Z-0004bi-JG for control@debbugs.gnu.org; Wed, 03 Oct 2018 16:52:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7o8T-0006BE-AK for control@debbugs.gnu.org; Wed, 03 Oct 2018 16:52:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7o8S-00068f-05 for control@debbugs.gnu.org; Wed, 03 Oct 2018 16:52:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g7o8R-0008Bm-9Q for control@debbugs.gnu.org; Wed, 03 Oct 2018 16:52:43 -0400 Subject: control message for bug 31929 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 03 Oct 2018 16:52:43 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) # 00ea749 fixed 31929 27.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 04 12:16:58 2018 Received: (at 31929) by debbugs.gnu.org; 4 Oct 2018 16:16:58 +0000 Received: from localhost ([127.0.0.1]:36859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g86J6-0008IM-Mc for submit@debbugs.gnu.org; Thu, 04 Oct 2018 12:16:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g86J5-0008I6-94 for 31929@debbugs.gnu.org; Thu, 04 Oct 2018 12:16:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g86Iv-0007tN-F6 for 31929@debbugs.gnu.org; Thu, 04 Oct 2018 12:16:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g86Ib-0007UD-Id; Thu, 04 Oct 2018 12:16:29 -0400 Received: from [176.228.60.248] (port=4713 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g86IZ-0006B9-VW; Thu, 04 Oct 2018 12:16:25 -0400 Date: Thu, 04 Oct 2018 19:16:08 +0300 Message-Id: <837eix3cxj.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Wed, 3 Oct 2018 22:02:08 +0200) Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: 31929@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Philipp Stephani > Date: Wed, 3 Oct 2018 22:02:08 +0200 > Cc: Philipp Stephani > > Since there were no more comments, I've installed (a tiny variant of) this patch as 00ea749f2a. Please cherry-pick this to the release branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 06 06:19:50 2018 Received: (at 31929) by debbugs.gnu.org; 6 Oct 2018 10:19:50 +0000 Received: from localhost ([127.0.0.1]:38323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8jgb-0004rP-Ol for submit@debbugs.gnu.org; Sat, 06 Oct 2018 06:19:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8jga-0004rA-2h for 31929@debbugs.gnu.org; Sat, 06 Oct 2018 06:19:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8jgU-0002XP-7W for 31929@debbugs.gnu.org; Sat, 06 Oct 2018 06:19:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8jgP-0002VD-EQ; Sat, 06 Oct 2018 06:19:37 -0400 Received: from [176.228.60.248] (port=3327 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g8jgO-00053e-V5; Sat, 06 Oct 2018 06:19:37 -0400 Date: Sat, 06 Oct 2018 13:19:24 +0300 Message-Id: <83in2f1ioj.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Wed, 03 Oct 2018 16:51:04 -0400) Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: p.stephani2@gmail.com, 31929@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Glenn Morris > Date: Wed, 03 Oct 2018 16:51:04 -0400 > Cc: p.stephani2@gmail.com, kaushal.modi@gmail.com > > After the fact, I'm wondering if this should obey the EMACS_NAME > transformation? My initial feeling is, yes. I'm not sure. If we edit the name, a given module couldn't be compiled against differently-named Emacs distributions, which I think is undesirable. Also, compiling a module inside the Emacs tree and outside it will need source-level changes to support both. Lastly, we name the file explicitly in the documentation. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 15 16:04:59 2018 Received: (at 31929) by debbugs.gnu.org; 15 Oct 2018 20:04:59 +0000 Received: from localhost ([127.0.0.1]:51500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC96o-0003AI-6h for submit@debbugs.gnu.org; Mon, 15 Oct 2018 16:04:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC96n-0003A6-7F for 31929@debbugs.gnu.org; Mon, 15 Oct 2018 16:04:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gC96h-0003Mp-F4 for 31929@debbugs.gnu.org; Mon, 15 Oct 2018 16:04:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gC96h-0003Ml-B7; Mon, 15 Oct 2018 16:04:51 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gC96g-0005lu-0M; Mon, 15 Oct 2018 16:04:50 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> <83in2f1ioj.fsf@gnu.org> X-Spook: Operation Iraqi Freedom Wave counter terrorism Federal X-Ran: J\IM[.pF#,mQc&^BPxP>V5E%+crpzBI*G5>daB6G4;;<;CfL5,sFgW>|O!pm+V[<'' (Eli Zaretskii's message of "Sat, 06 Oct 2018 13:19:24 +0300") Message-ID: <1x1s8rf02m.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: p.stephani2@gmail.com, 31929@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Eli Zaretskii wrote: >> After the fact, I'm wondering if this should obey the EMACS_NAME >> transformation? My initial feeling is, yes. > > I'm not sure. If we edit the name, a given module couldn't be > compiled against differently-named Emacs distributions, which I think > is undesirable. I think it is what users of the --program-prefix|suffix|transform configure options will probably expect to happen. Ie if someone wants "emacs" installed as "emacs27", I think they want "emacs27-module.h" as well. > Lastly, we name the file explicitly in the documentation. The documentation also names eg the "emacs" and "emacslient" executables, which are rather more fundamental. The documentation does not account for the --program-transform etc options anywhere, and I don't think it should. It's a specialized feature, and people who use it should be able to deal with the consequences. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 15 22:29:55 2018 Received: (at 31929) by debbugs.gnu.org; 16 Oct 2018 02:29:55 +0000 Received: from localhost ([127.0.0.1]:51687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCF7K-0001cH-TB for submit@debbugs.gnu.org; Mon, 15 Oct 2018 22:29:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCF7K-0001c6-6j for 31929@debbugs.gnu.org; Mon, 15 Oct 2018 22:29:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCF7E-0001rJ-0w for 31929@debbugs.gnu.org; Mon, 15 Oct 2018 22:29:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCF72-0001g6-O4; Mon, 15 Oct 2018 22:29:36 -0400 Received: from [176.228.60.248] (port=4159 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gCF71-0005e2-Om; Mon, 15 Oct 2018 22:29:36 -0400 Date: Tue, 16 Oct 2018 05:29:47 +0300 Message-Id: <83pnwasjxg.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: <1x1s8rf02m.fsf@fencepost.gnu.org> (message from Glenn Morris on Mon, 15 Oct 2018 16:04:49 -0400) Subject: Re: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) References: <20180921132748.95945-1-phst@google.com> <83in2f1ioj.fsf@gnu.org> <1x1s8rf02m.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31929 Cc: p.stephani2@gmail.com, 31929@debbugs.gnu.org, kaushal.modi@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Glenn Morris > Cc: 31929@debbugs.gnu.org, p.stephani2@gmail.com, kaushal.modi@gmail.com > Date: Mon, 15 Oct 2018 16:04:49 -0400 > > > Lastly, we name the file explicitly in the documentation. > > The documentation also names eg the "emacs" and "emacslient" I mean the examples in which there's an #include statement. It's not the same as naming executables, IMO. I think we should wait until we hear real-life use cases where the fixed name is a problem, before we decide on a solution. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 01 11:50:42 2018 Received: (at control) by debbugs.gnu.org; 1 Nov 2018 15:50:42 +0000 Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIFF4-0006pC-35 for submit@debbugs.gnu.org; Thu, 01 Nov 2018 11:50:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIFF3-0006ow-AK for control@debbugs.gnu.org; Thu, 01 Nov 2018 11:50:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIFEx-0003f9-CZ for control@debbugs.gnu.org; Thu, 01 Nov 2018 11:50:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIFEr-0003dA-HB for control@debbugs.gnu.org; Thu, 01 Nov 2018 11:50:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gIFEo-0001AR-IY for control@debbugs.gnu.org; Thu, 01 Nov 2018 11:50:29 -0400 Subject: control message for bug 33228 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 01 Nov 2018 11:50:26 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) fixed 33228 26.2 forcemerge 31929 33228 From unknown Tue Jun 17 20:17:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 Nov 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator