GNU bug report logs - #31923
FAIL: t0501-duplicate on Alpine Linux s390x

Previous Next

Full log

Message #14 received at 31923 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: "A. Wilcox" <awilfox <at> adelielinux.org>
Cc: 31923 <at> debbugs.gnu.org
Subject: Re: bug#31923: FAIL: t0501-duplicate on Alpine Linux s390x
Date: Mon, 5 Aug 2019 09:03:03 -0700

On Mon, Aug 05, 2019 at 12:55:08AM -0500, A. Wilcox wrote:
> found 31923 3.2
> 
> We've hit this on Adélie Linux on ppc64.  This actually is an endianness
> bug.
> 
> The attached patch fixes the bug and allows it to pass the test suite
> and correctly create a new BSD disk label on big endian computers.
> 
> If this patch is acceptable, I can create it in Git format.  Or you can
> yourself, my Author line should be:
> 
> Author: A. Wilcox <AWilcox <at> Wilcox-Tech.com>
> 
> 
> Best,
> --arw
> 
> -- 
> A. Wilcox (awilfox)
> Project Lead, Adélie Linux
> https://www.adelielinux.org

> See-Also: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31923
> 
> --- parted-3.2/libparted/labels/bsd.c.old	2014-06-15 18:17:43.000000000 +0000
> +++ parted-3.2/libparted/labels/bsd.c	2019-08-05 05:48:52.914401379 +0000
> @@ -364,7 +364,7 @@
>  		max_part = i;
>  	}
>  
> -	label->d_npartitions = PED_CPU_TO_LE16 (max_part) + 1;
> +	label->d_npartitions = PED_CPU_TO_LE16 (max_part + 1);
>  	label->d_checksum = xbsd_dkcksum (label);
>  
>  	alpha_bootblock_checksum (bsd_specific->boot_code);


Ack, thanks!



-- 
Brian C. Lane (PST8PDT) - weldr.io - lorax - parted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.