GNU bug report logs - #31914
[PATCH] gnu: Add emacs-atom-one-dark-theme.

Previous Next

Full log

View this message in rfc822 format

From: Peter Mikkelsen <peter <at> alaok.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31914 <at> debbugs.gnu.org
Subject: [bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.
Date: Fri, 29 Jun 2018 12:54:29 +0200

[Message part 1 (text/plain, inline)]

Hi, sorry for the delay

Marius Bakke writes:

> Hello Peter,
>
> Peter Mikkelsen <peter <at> alaok.org> writes:
>
>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>> User-agent: mu4e 1.0; emacs 26.1
>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>
> [...]
>   
>> +(define-public emacs-atom-one-dark-theme
>> +  (package
>> +   (name "emacs-atom-one-dark-theme")
>> +   (version "20180607.1638")
>> +   (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "https://melpa.org/packages/atom-one-dark-theme-"
>> +                   version ".el"))
>
> Could you change this to use a git checkout or release tarball instead?
> MELPA does not preserve old versions, so this version might not be
> around for long.

I didn't know that, but since the last release is quite old, I decided
to use a git checkout.

>> +             (sha256
>> +              (base32
>> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>> +   (build-system emacs-build-system)
>> +   (home-page
>> +    "https://github.com/jonathanchu/atom-one-dark-theme")
>> +   (synopsis "Atom One Dark color theme for Emacs")
>> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>> +   (license license:gpl3)))
>
> This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
> an updated patch please?

I have attached an updated patch :)
Thanks

[0001-gnu-Add-emacs-atom-one-dark-theme.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.