From unknown Fri Jun 20 07:09:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31911 <31911@debbugs.gnu.org> To: bug#31911 <31911@debbugs.gnu.org> Subject: Status: [PATCH] services: Add prometheus-node-exporter-service-type. Reply-To: bug#31911 <31911@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:09:12 +0000 retitle 31911 [PATCH] services: Add prometheus-node-exporter-service-type. reassign 31911 guix-patches submitter 31911 G=C3=A1bor Boskovits severity 31911 normal tag 31911 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 20 09:00:25 2018 Received: (at submit) by debbugs.gnu.org; 20 Jun 2018 13:00:25 +0000 Received: from localhost ([127.0.0.1]:57170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVcim-0005ld-Qu for submit@debbugs.gnu.org; Wed, 20 Jun 2018 09:00:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVcil-0005et-8R for submit@debbugs.gnu.org; Wed, 20 Jun 2018 09:00:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVcia-0001ey-59 for submit@debbugs.gnu.org; Wed, 20 Jun 2018 09:00:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVcia-0001es-1Z for submit@debbugs.gnu.org; Wed, 20 Jun 2018 09:00:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVciR-00079X-Jz for guix-patches@gnu.org; Wed, 20 Jun 2018 09:00:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVciM-0001Yp-V6 for guix-patches@gnu.org; Wed, 20 Jun 2018 09:00:03 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:54917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVciM-0001YU-NN for guix-patches@gnu.org; Wed, 20 Jun 2018 08:59:58 -0400 Received: by mail-wm0-x244.google.com with SMTP id o13-v6so5820030wmf.4 for ; Wed, 20 Jun 2018 05:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XK30QMSMN3pVPnBqFVpWVdUHjlAh2cnwc44nY1VFo/8=; b=b+YWmUetNksmDbxaal8Z7hW4n7KhQ9cXpC6F0+Ka0AxWxu6dh5JuBQubzk1BXJ4czv FFptuUcp+TaUG6UvtEf9kubjcwy1p/lBbiFYlJaaOuzbR1dEPTHgZgIP+9P9RncRyNIq +YE50YhDgT+yCRhehbNJ/gC0jvcqxP5m/fhVu65IuB1F6Pcw8Rp8WCwCko110FY8eIK1 z/cDrfgVP6epiELmYtPptz1O7JlBe4MWSFSt6BaQANlCs7PatITeHAL9Zpg1fQbjeitD AjnfUw+dG79cjawqzqhPR0qzkYmx1laGzCx0ULOJiUnqMepoTkKtGYtFxltA0z+I2Cdj SCiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XK30QMSMN3pVPnBqFVpWVdUHjlAh2cnwc44nY1VFo/8=; b=nzwqAt3Yz/s2Hr6BME+lIrH2HrYlv3/WIWCAq7tp0Ee3A+AintGBTRLoFMpFqyruEh LMvFGNAIAsIwUFxHGBtVU5sLT6w1aAfquxNVj/JAb2DKtKecoIW0sXFwfq1+xlT1dCPW vhJFWxqaSz11WCvbCNO0n6L0GPfRk6vMToh9KI8sYzD7P+4ppjCfOX+U2EjuVDM7rjgL PkesZKtASfdeFd5RW7zgIMkyQnTKX+GoLRgSQLfxlMPhdz7GrwUKXDTVlzmerPfkDGkz JVcOOJYv5pcIIohV/0L4m+giBCB185m41zWNKgdL9dI/xhDR9SnUcUzx0GRY3psur1yv KXEw== X-Gm-Message-State: APt69E28pOINB2ro/kfyBWDiINropHs9Nj/+olbXUkHOOZg+qcwfc+6j psWTQot6mgtkoaOZ3XIBTn1dLF8= X-Google-Smtp-Source: ADUXVKLg+HNwfybSgaKpPPb7Eof9KGqDKNsQhSyu+Zm70i6FCA/NL6jG256n1H0f1Q9a0fG4uqNH1A== X-Received: by 2002:a1c:7409:: with SMTP id p9-v6mr1584448wmc.43.1529499597032; Wed, 20 Jun 2018 05:59:57 -0700 (PDT) Received: from localhost.localdomain (5400B769.dsl.pool.telekom.hu. [84.0.183.105]) by smtp.gmail.com with ESMTPSA id e81-v6sm4035507wmi.28.2018.06.20.05.59.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 05:59:56 -0700 (PDT) From: =?UTF-8?q?G=C3=A1bor=20Boskovits?= To: guix-patches@gnu.org Subject: [PATCH] services: Add prometheus-node-exporter-service-type. Date: Wed, 20 Jun 2018 14:59:46 +0200 Message-Id: <20180620125946.7264-1-boskovits@gmail.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?G=C3=A1bor=20Boskovits?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/services/monitoring.scm (prometheus-node-exporter-service-type): New variable. (): New record type. (prometheus-node-exporter-shepherd-service): New procedure. * gnu/doc/guix.texi (Monitoring Services): Document it. --- doc/guix.texi | 32 ++++++++++++++++++++++++++++++++ gnu/services/monitoring.scm | 37 ++++++++++++++++++++++++++++++++++++- 2 files changed, 68 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 1ecb11002..6a649c549 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -15570,6 +15570,38 @@ Specify the path of the base URL. This can be useful if @end table @end deftp +@subsubheading Prometheus Node Exporter Service +@cindex prometheus-node-exporter +Prometheus node exporter is a Prometheus exporter. It makes hardware and +operating system statistics provided by *NIX kernels available for the +Prometheus monitoring system. This service should be deployed on all +physical nodes and virtual machines, where monitoring these statistics is +desirable. + +@defvar {Scheme variable} prometheus-node-exporter-service-type +This is the service type for the +@uref{https://github.com/prometheus/node_exporter/, prometheus-node-exporter} +service, its value must be a @code{prometheus-node-exporter-configuration} +record as in this example: + +@example +(service prometheus-node-exporter-service-type + (prometheus-node-exporter-configuration + (web-listen-address ":9100"))) +@end example +@end defvar + +@deftp {Data Type} prometheus-node-exporter-configuration +Data type representing the configuration of @command{node_exporter}. + +@table @asis +@item @code{package} (default: @code{go-github-com-prometheus-node-exporter}) +The prometheus-node-exporter package to use. +@item @code{web-listen-address} (default: @code{":9100"}) +Bind the web interface to the specified address. + +@end table +@end deftp @node Kerberos Services @subsubsection Kerberos Services diff --git a/gnu/services/monitoring.scm b/gnu/services/monitoring.scm index 49a65db4b..2fc90c867 100644 --- a/gnu/services/monitoring.scm +++ b/gnu/services/monitoring.scm @@ -26,7 +26,9 @@ #:use-module (guix records) #:use-module (ice-9 match) #:export (darkstat-configuration - darkstat-service-type)) + prometheus-node-exporter-configuration + darkstat-service-type + prometheus-node-exporter-service-type)) ;;; @@ -89,3 +91,36 @@ HTTP.") (const %darkstat-accounts)) (service-extension shepherd-root-service-type (compose list darkstat-shepherd-service)))))) + +(define-record-type* + prometheus-node-exporter-configuration + make-prometheus-node-exporter-configuration + prometheus-node-exporter-configuration? + (package prometheus-node-exporter-configuration-package + (default go-github-com-prometheus-node-exporter)) + (web-listen-address prometheus-node-exporter-web-listen-address + (default ":9100"))) + +(define prometheus-node-exporter-shepherd-service + (match-lambda + (( $ + package web-listen-address) + (shepherd-service + (documentation "Prometheus node exporter.") + (provision '(prometheus-node-exporter)) + (requirement '(networking)) + (start #~(make-forkexec-constructor + (list #$(file-append package "/bin/node_exporter") + "--web.listen-address" #$web-listen-address))) + (stop #~(make-kill-destructor)))))) + +(define prometheus-node-exporter-service-type + (service-type + (name 'prometheus-node-exporter) + (description + "Run @command{node_exporter} to serve hardware and OS metrics to +prometheus.") + (extensions + (list (service-extension + shepherd-root-service-type + (compose list prometheus-node-exporter-shepherd-service)))))) -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 23 17:51:53 2018 Received: (at 31911) by debbugs.gnu.org; 23 Jun 2018 21:51:53 +0000 Received: from localhost ([127.0.0.1]:33484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWqRk-0000LF-TW for submit@debbugs.gnu.org; Sat, 23 Jun 2018 17:51:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWqRj-0000L3-MB for 31911@debbugs.gnu.org; Sat, 23 Jun 2018 17:51:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWqRd-0008NN-Kn for 31911@debbugs.gnu.org; Sat, 23 Jun 2018 17:51:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWqRd-0008NH-Gr; Sat, 23 Jun 2018 17:51:45 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=53104 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fWqRc-0006Hv-Vv; Sat, 23 Jun 2018 17:51:45 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type. References: <20180620125946.7264-1-boskovits@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Messidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 23 Jun 2018 23:51:43 +0200 In-Reply-To: <20180620125946.7264-1-boskovits@gmail.com> (=?utf-8?Q?=22G?= =?utf-8?Q?=C3=A1bor?= Boskovits"'s message of "Wed, 20 Jun 2018 14:59:46 +0200") Message-ID: <87po0hw4r4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31911 Cc: 31911@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello G=C3=A1bor! G=C3=A1bor Boskovits skribis: > * gnu/services/monitoring.scm (prometheus-node-exporter-service-type): > New variable. > (): New record type. > (prometheus-node-exporter-shepherd-service): New procedure. > * gnu/doc/guix.texi (Monitoring Services): Document it. That=E2=80=99s very useful! Hopefully we can start using it on our build f= arm, though we=E2=80=99ll need Grafena (?) or something to visualize those stats, right? OTOH apparently it already provides a web interface, so=E2=80=A6? It would be nice to add a system test for this service. It could ensure that representative URLs return 200 or 404, for instance (see the hpcguix-web test in (gnu tests web) as an example.) WDYT? Minor comments: > +@subsubheading Prometheus Node Exporter Service Leave a newline here. > +@cindex prometheus-node-exporter > +Prometheus node exporter is a Prometheus exporter. It makes hardware and > +operating system statistics provided by *NIX kernels available for the The first sentence looks like a tautology. :-) I=E2=80=99m also unconvinced by the =E2=80=9C*NIX=E2=80=9D notation. What about: The Prometheus ``node exporter'' makes hardware and operating system statistics available for the=E2=80=A6 Please leave two spaces after end-of-sentence periods. > +@defvar {Scheme variable} prometheus-node-exporter-service-type Should be @defvr instead of @defvar. > +@deftp {Data Type} prometheus-node-exporter-configuration > +Data type representing the configuration of @command{node_exporter}. > + > +@table @asis > +@item @code{package} (default: @code{go-github-com-prometheus-node-expor= ter}) > +The prometheus-node-exporter package to use. > +@item @code{web-listen-address} (default: @code{":9100"}) > +Bind the web interface to the specified address. Please add a newline before the second @item. With these changes and ideally a simple test, this is ready to go IMO! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 04:32:04 2018 Received: (at 31911) by debbugs.gnu.org; 25 Jun 2018 08:32:04 +0000 Received: from localhost ([127.0.0.1]:34247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXMuq-0000Eg-Eo for submit@debbugs.gnu.org; Mon, 25 Jun 2018 04:32:04 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:39070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXMuo-0000EC-KG for 31911@debbugs.gnu.org; Mon, 25 Jun 2018 04:32:02 -0400 Received: by mail-io0-f179.google.com with SMTP id f1-v6so11731106ioh.6 for <31911@debbugs.gnu.org>; Mon, 25 Jun 2018 01:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4F8itfDJ6gENUdg+7hjuVLTRekHIuz94PEAdsJ/oEt0=; b=dZyc7d5KcdijKw5nOm1GoMp4whuFWVzmsbaGnMoFN5lhBBNWEhGnkIc0dbrXivYtzQ uksTi6bVKkG79yA2opiHNKBNyTZ/3+SWI+8hmtwzLI1m6QEaz4/kHKc7AON09wc9dkUR dVxpiFyDNcvRLhXL1rzIW8IKOujrcj35U2gru4/D2BzVxB+ha2ZYvUv8KVbDSxdDOmJB bsSNYshN1ofYRI/b2e7Fl+QyPnv2wJ2u5R3iMJhb33pUj6tAUPFYNN3M+pc9oJDQti9u dxVzVplZBMWhJy0MbHGqr29HEyAP1m1ezXCnEAvFQ0jCxE1BXWvHlU+PvoarLsPNPcZp 89GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4F8itfDJ6gENUdg+7hjuVLTRekHIuz94PEAdsJ/oEt0=; b=cfZ4SzX1x5iodz8lOvFD5SlTi1whLddo4mjsms6Alc1O/1NxriQ0YDO5uKWjG/VsNS I7eRQcFGu4bj+xNikPyP1u/jml4SJtOSNL+yk8jGXiBoYlqCZHFEngYvHY2CR4lG4Bbd umMagv0a4Qpt81eWGcljDDnXoYyazzJYZWYO+4+DFoXrCZTUhRAXKVynnvkubiFiLvg1 W53njLL0z2/YhP4W9OAZWwf6+52NmA8wAxq/X3CNQh09RUNn6b53J3Yli9AeyI9y97X4 yDZXaQqupg4xfH0dh2ZYNswOyiuPMRYK0MzikLEtHnzEDB+Gnav+CxoR2yCdx9dOzxVQ rEJw== X-Gm-Message-State: APt69E36wVeeVoowmNxTMkIz/IC8ymLGIyrNvetrs9Wg4pLQCHRcrsMi jKealgQ+HLf0jaSng+5s/9SSxU5e7yizr6lPdM+z X-Google-Smtp-Source: ADUXVKJdfSFjDPDiQL4C/rYqkSeOVkGsV4aVQT0mPjKZ79w8P6XQteRTOdSx7VVZ8RDbwLwkp4bQ+/DnQnUtQxX9ir0= X-Received: by 2002:a5e:940c:: with SMTP id q12-v6mr8827402ioj.224.1529915516838; Mon, 25 Jun 2018 01:31:56 -0700 (PDT) MIME-Version: 1.0 References: <20180620125946.7264-1-boskovits@gmail.com> <87po0hw4r4.fsf@gnu.org> In-Reply-To: <87po0hw4r4.fsf@gnu.org> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Mon, 25 Jun 2018 10:31:45 +0200 Message-ID: Subject: Re: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="000000000000eae8e5056f7336df" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31911 Cc: 31911@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000eae8e5056f7336df Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s ezt =C3=ADrta (id=C5=91pont: 2018. j=C3= =BAn. 23., Szo, 23:51): > Hello G=C3=A1bor! > > G=C3=A1bor Boskovits skribis: > > > * gnu/services/monitoring.scm (prometheus-node-exporter-service-type): > > New variable. > > (): New record type. > > (prometheus-node-exporter-shepherd-service): New procedure. > > * gnu/doc/guix.texi (Monitoring Services): Document it. > > That=E2=80=99s very useful! Hopefully we can start using it on our build= farm, > though we=E2=80=99ll need Grafena (?) or something to visualize those sta= ts, > right? OTOH apparently it already provides a web interface, so=E2=80=A6? > > This is actually only one half of the solution, this provides an endpoint for the prometheus server to scrape. I've not yet packaged the server part. The server has the needed visualization capabilities. > It would be nice to add a system test for this service. It could ensure > that representative URLs return 200 or 404, for instance (see the > hpcguix-web test in (gnu tests web) as an example.) > > WDYT? > > Ok, will do. > Minor comments: > > > +@subsubheading Prometheus Node Exporter Service > > Leave a newline here. > > > +@cindex prometheus-node-exporter > > +Prometheus node exporter is a Prometheus exporter. It makes hardware a= nd > > +operating system statistics provided by *NIX kernels available for the > > The first sentence looks like a tautology. :-) > I=E2=80=99m also unconvinced by the =E2=80=9C*NIX=E2=80=9D notation. > > What about: > > The Prometheus ``node exporter'' makes hardware and operating system > statistics available for the=E2=80=A6 > > Please leave two spaces after end-of-sentence periods. > > > +@defvar {Scheme variable} prometheus-node-exporter-service-type > > Should be @defvr instead of @defvar. > +@deftp {Data Type} prometheus-node-exporter-configuration > > +Data type representing the configuration of @command{node_exporter}. > > + > > +@table @asis > > +@item @code{package} (default: > @code{go-github-com-prometheus-node-exporter}) > > +The prometheus-node-exporter package to use. > > +@item @code{web-listen-address} (default: @code{":9100"}) > > +Bind the web interface to the specified address. > > Please add a newline before the second @item. > > Most of these were copied almost verbatim form darkstat service. Maybe these modification should be also applied there. Will send an updated patch. Should I contact Sou Bunnbu regadring the darkstat documentation, or should I fix it? > With these changes and ideally a simple test, this is ready to go IMO! > > Thanks, > Ludo=E2=80=99. > --000000000000eae8e5056f7336df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ludovic Court= =C3=A8s <ludo@gnu.org> ezt =C3=AD= rta (id=C5=91pont: 2018. j=C3=BAn. 23., Szo, 23:51):
Hello G=C3=A1bor!

G=C3=A1bor Boskovits <boskovits@gmail.com> skribis:

> * gnu/services/monitoring.scm (prometheus-node-exporter-service-type):=
> New variable.
> (<prometheus-node-exporter-configuration>): New record type.
> (prometheus-node-exporter-shepherd-service): New procedure.
> * gnu/doc/guix.texi (Monitoring Services): Document it.

That=E2=80=99s very useful!=C2=A0 Hopefully we can start using it on our bu= ild farm,
though we=E2=80=99ll need Grafena (?) or something to visualize those stats= ,
right?=C2=A0 OTOH apparently it already provides a web interface, so=E2=80= =A6?


This is actually only one half of the = solution, this provides an endpoint for
the prometheus server to = scrape. I've not yet packaged the server part.
The server has= the needed visualization capabilities.
=C2=A0
It would be nice to add a system test for this service.=C2=A0 It could ensu= re
that representative URLs return 200 or 404, for instance (see the
hpcguix-web test in (gnu tests web) as an example.)

WDYT?


Ok, will do.
=C2=A0
Minor comments:

> +@subsubheading Prometheus Node Exporter Service

Leave a newline here.

> +@cindex prometheus-node-exporter
> +Prometheus node exporter is a Prometheus exporter. It makes hardware = and
> +operating system statistics provided by *NIX kernels available for th= e

The first sentence looks like a tautology.=C2=A0 :-)
I=E2=80=99m also unconvinced by the =E2=80=9C*NIX=E2=80=9D notation.

What about:

=C2=A0 The Prometheus ``node exporter'' makes hardware and operatin= g system
=C2=A0 statistics available for the=E2=80=A6

Please leave two spaces after end-of-sentence periods.

> +@defvar {Scheme variable} prometheus-node-exporter-service-type

Should be @defvr instead of @defvar.
> +@deftp {Data Type} prometheus-node-exporter-configuration
> +Data type representing the configuration of @command{node_exporter}.<= br> > +
> +@table @asis
> +@item @code{package} (default: @code{go-github-com-prometheus-node-ex= porter})
> +The prometheus-node-exporter package to use.
> +@item @code{web-listen-address} (default: @code{":9100"}) > +Bind the web interface to the specified address.

Please add a newline before the second @item.


Most of these were copied almost verba= tim form darkstat service. Maybe these modification should be also applied = there.
Will send an updated patch. Should I contact Sou Bunnbu re= gadring the darkstat documentation, or should I fix it?
=C2=A0
With these changes and ideally a simple test, this is ready to go IMO!

Thanks,
Ludo=E2=80=99.
--000000000000eae8e5056f7336df-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 04:56:33 2018 Received: (at 31911) by debbugs.gnu.org; 25 Jun 2018 08:56:33 +0000 Received: from localhost ([127.0.0.1]:34267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXNIX-0000mw-Fz for submit@debbugs.gnu.org; Mon, 25 Jun 2018 04:56:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXNIV-0000mj-IO for 31911@debbugs.gnu.org; Mon, 25 Jun 2018 04:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXNIM-00009E-K1 for 31911@debbugs.gnu.org; Mon, 25 Jun 2018 04:56:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXNIM-000091-Fn; Mon, 25 Jun 2018 04:56:22 -0400 Received: from [193.50.110.137] (port=36086 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fXNIL-0008TI-Tc; Mon, 25 Jun 2018 04:56:22 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type. References: <20180620125946.7264-1-boskovits@gmail.com> <87po0hw4r4.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Messidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 Jun 2018 10:56:19 +0200 In-Reply-To: (=?utf-8?Q?=22G=C3=A1bor?= Boskovits"'s message of "Mon, 25 Jun 2018 10:31:45 +0200") Message-ID: <87zhzjqm6k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31911 Cc: 31911@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, G=C3=A1bor Boskovits skribis: > Ludovic Court=C3=A8s ezt =C3=ADrta (id=C5=91pont: 2018. j= =C3=BAn. 23., Szo, > 23:51): [...] >> That=E2=80=99s very useful! Hopefully we can start using it on our buil= d farm, >> though we=E2=80=99ll need Grafena (?) or something to visualize those st= ats, >> right? OTOH apparently it already provides a web interface, so=E2=80=A6? >> >> > This is actually only one half of the solution, this provides an endpoint > for > the prometheus server to scrape. I've not yet packaged the server part. > The server has the needed visualization capabilities. OK, I see. >> +@deftp {Data Type} prometheus-node-exporter-configuration >> > +Data type representing the configuration of @command{node_exporter}. >> > + >> > +@table @asis >> > +@item @code{package} (default: >> @code{go-github-com-prometheus-node-exporter}) >> > +The prometheus-node-exporter package to use. >> > +@item @code{web-listen-address} (default: @code{":9100"}) >> > +Bind the web interface to the specified address. >> >> Please add a newline before the second @item. >> >> > Most of these were copied almost verbatim form darkstat service. Maybe > these modification should be also applied there. > Will send an updated patch. Should I contact Sou Bunnbu regadring the > darkstat documentation, or should I fix it? You can go ahead and fix them as a separate commit. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 11:54:44 2018 Received: (at 31911) by debbugs.gnu.org; 7 Jul 2018 15:54:44 +0000 Received: from localhost ([127.0.0.1]:50322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbpXo-0007k7-GM for submit@debbugs.gnu.org; Sat, 07 Jul 2018 11:54:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbpXm-0007js-6t for 31911@debbugs.gnu.org; Sat, 07 Jul 2018 11:54:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbpXg-0002aB-1X for 31911@debbugs.gnu.org; Sat, 07 Jul 2018 11:54:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbpXf-0002a4-Tq; Sat, 07 Jul 2018 11:54:35 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59490 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbpXf-0000Yh-Gq; Sat, 07 Jul 2018 11:54:35 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type. References: <20180620125946.7264-1-boskovits@gmail.com> <87po0hw4r4.fsf@gnu.org> <87zhzjqm6k.fsf@gnu.org> Date: Sat, 07 Jul 2018 17:54:34 +0200 In-Reply-To: <87zhzjqm6k.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 25 Jun 2018 10:56:19 +0200") Message-ID: <87k1q73uth.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31911 Cc: 31911@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ping! :-) ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Hello, > > G=C3=A1bor Boskovits skribis: > >> Ludovic Court=C3=A8s ezt =C3=ADrta (id=C5=91pont: 2018. j= =C3=BAn. 23., Szo, >> 23:51): > > [...] > >>> That=E2=80=99s very useful! Hopefully we can start using it on our bui= ld farm, >>> though we=E2=80=99ll need Grafena (?) or something to visualize those s= tats, >>> right? OTOH apparently it already provides a web interface, so=E2=80= =A6? >>> >>> >> This is actually only one half of the solution, this provides an endpoint >> for >> the prometheus server to scrape. I've not yet packaged the server part. >> The server has the needed visualization capabilities. > > OK, I see. > >>> +@deftp {Data Type} prometheus-node-exporter-configuration >>> > +Data type representing the configuration of @command{node_exporter}. >>> > + >>> > +@table @asis >>> > +@item @code{package} (default: >>> @code{go-github-com-prometheus-node-exporter}) >>> > +The prometheus-node-exporter package to use. >>> > +@item @code{web-listen-address} (default: @code{":9100"}) >>> > +Bind the web interface to the specified address. >>> >>> Please add a newline before the second @item. >>> >>> >> Most of these were copied almost verbatim form darkstat service. Maybe >> these modification should be also applied there. >> Will send an updated patch. Should I contact Sou Bunnbu regadring the >> darkstat documentation, or should I fix it? > > You can go ahead and fix them as a separate commit. > > Thanks, > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 14:14:42 2018 Received: (at 31911) by debbugs.gnu.org; 7 Jul 2018 18:14:42 +0000 Received: from localhost ([127.0.0.1]:50397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbrjF-0006yL-Ly for submit@debbugs.gnu.org; Sat, 07 Jul 2018 14:14:41 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:52312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbrjD-0006y6-EA for 31911@debbugs.gnu.org; Sat, 07 Jul 2018 14:14:39 -0400 Received: by mail-it0-f41.google.com with SMTP id p4-v6so20469225itf.2 for <31911@debbugs.gnu.org>; Sat, 07 Jul 2018 11:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NzWhaCfr8l7+/DeRrHJoe4ZTBN93ZwMd4FXg4lchXqQ=; b=kgTEz2Q3X0Y7+qQclwaXHRsrTI+F74f8+/3OuU4kw9PHPtNUw10mmhE7+npH+AuuKB c/aezGrjQht1hLrphpIWfsy7vb3qfMuqAVPLd6MqASsB13iTfWuT3F8LHCJ8rREcngo8 cE8Tj+yc37/x6uImRD3nYvdroEnIvokCaEo18cLEJz/w+fbD39YfaOugidBQsVq0bb5y ekpHD35mvbrCv2B7XWZbJx/fcyXsOgs9T0em8ByCZKck6XTo8ThfHKy3jaLd5nTyuMZ6 Np3TnH+2N/JC7KaE4zPwd7cSi42EpWC7TFDlXnXMeqi/tEjETL69ApdNiDO8Msx2oI1b ACiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NzWhaCfr8l7+/DeRrHJoe4ZTBN93ZwMd4FXg4lchXqQ=; b=msc+P+Eh03JOfyeuFvcX8hrXulC0hAZy+OMBRGJBzEY3PWP1HwAIT1ugxMAz4eehqa w5cSdQeQibcHVd/u57oUc6mZsu+TVwZ43U2NHpDxzRIobexvZ8qQ6g+te2yAbsQXvH9p xZGMj+/4W9HE9CaGJiuiJ1EmPqNupgJz4R1vdrg7SBwju8N8wW0biSKpvG6iDhkMB9n7 /kps50sFLaE3X3iEerT94jWvySJThM4D6+R4neTP3QNH+458AXsKJ65fKiY5sj3Bh3Pb KvlAyHfBOcjb0jvWar/dDJrvYC7MEPLF+FqZk7JjWEwbPgP5RmATfrqkAz8j7SbZf4dM h5Pw== X-Gm-Message-State: APt69E1HbrzHv+v6GBxRZUM6P63qIvj9igrm7W2xQmBaSwl5d1ScHrLs mxesJZDRpke2AzsqmmMAHUoKKIfguWFgGKMRHg== X-Google-Smtp-Source: AAOMgpfMjb6Z0zenD2lpIFjkOdOuQESNYUYHp/FQ0D/HU50x1y3R6VWXafaT3OPudScbrg7dKmT7IONFlbT0VleEhaE= X-Received: by 2002:a24:ad45:: with SMTP id a5-v6mr11712994itj.0.1530987273916; Sat, 07 Jul 2018 11:14:33 -0700 (PDT) MIME-Version: 1.0 References: <20180620125946.7264-1-boskovits@gmail.com> <87po0hw4r4.fsf@gnu.org> <87zhzjqm6k.fsf@gnu.org> <87k1q73uth.fsf@gnu.org> In-Reply-To: <87k1q73uth.fsf@gnu.org> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Sat, 7 Jul 2018 20:14:22 +0200 Message-ID: Subject: Re: [bug#31911] [PATCH] services: Add prometheus-node-exporter-service-type. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="0000000000009e16e905706cc0de" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31911 Cc: 31911@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009e16e905706cc0de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s ezt =C3=ADrta (id=C5=91pont: 2018. j=C3= =BAl. 7., Szo, 17:54): > Ping! :-) > > Will find some time tomorrow to have a look at this :-) > ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > > > Hello, > > > > G=C3=A1bor Boskovits skribis: > > > >> Ludovic Court=C3=A8s ezt =C3=ADrta (id=C5=91pont: 2018.= j=C3=BAn. 23., Szo, > >> 23:51): > > > > [...] > > > >>> That=E2=80=99s very useful! Hopefully we can start using it on our b= uild farm, > >>> though we=E2=80=99ll need Grafena (?) or something to visualize those= stats, > >>> right? OTOH apparently it already provides a web interface, so=E2=80= =A6? > >>> > >>> > >> This is actually only one half of the solution, this provides an > endpoint > >> for > >> the prometheus server to scrape. I've not yet packaged the server part= . > >> The server has the needed visualization capabilities. > > > > OK, I see. > > > >>> +@deftp {Data Type} prometheus-node-exporter-configuration > >>> > +Data type representing the configuration of @command{node_exporter= }. > >>> > + > >>> > +@table @asis > >>> > +@item @code{package} (default: > >>> @code{go-github-com-prometheus-node-exporter}) > >>> > +The prometheus-node-exporter package to use. > >>> > +@item @code{web-listen-address} (default: @code{":9100"}) > >>> > +Bind the web interface to the specified address. > >>> > >>> Please add a newline before the second @item. > >>> > >>> > >> Most of these were copied almost verbatim form darkstat service. Maybe > >> these modification should be also applied there. > >> Will send an updated patch. Should I contact Sou Bunnbu regadring the > >> darkstat documentation, or should I fix it? > > > > You can go ahead and fix them as a separate commit. > > > > Thanks, > > Ludo=E2=80=99. > --0000000000009e16e905706cc0de Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ludovic Court= =C3=A8s <ludo@gnu.org> ezt =C3=AD= rta (id=C5=91pont: 2018. j=C3=BAl. 7., Szo, 17:54):
Ping!=C2=A0 :-)


Will find some time tomorrow to have a= look at this :-)

=C2=A0
ludo@gnu.org (Ludovic= Court=C3=A8s) skribis:

> Hello,
>
> G=C3=A1bor Boskovits <boskovits@gmail.com> skribis:
>
>> Ludovic Court=C3=A8s <ludo@gnu.org> ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BAn. = 23., Szo,
>> 23:51):
>
> [...]
>
>>> That=E2=80=99s very useful!=C2=A0 Hopefully we can start using= it on our build farm,
>>> though we=E2=80=99ll need Grafena (?) or something to visualiz= e those stats,
>>> right?=C2=A0 OTOH apparently it already provides a web interfa= ce, so=E2=80=A6?
>>>
>>>
>> This is actually only one half of the solution, this provides an e= ndpoint
>> for
>> the prometheus server to scrape. I've not yet packaged the ser= ver part.
>> The server has the needed visualization capabilities.
>
> OK, I see.
>
>>> +@deftp {Data Type} prometheus-node-exporter-configuration
>>> > +Data type representing the configuration of @command{nod= e_exporter}.
>>> > +
>>> > +@table @asis
>>> > +@item @code{package} (default:
>>> @code{go-github-com-prometheus-node-exporter})
>>> > +The prometheus-node-exporter package to use.
>>> > +@item @code{web-listen-address} (default: @code{":9= 100"})
>>> > +Bind the web interface to the specified address.
>>>
>>> Please add a newline before the second @item.
>>>
>>>
>> Most of these were copied almost verbatim form darkstat service. M= aybe
>> these modification should be also applied there.
>> Will send an updated patch. Should I contact Sou Bunnbu regadring = the
>> darkstat documentation, or should I fix it?
>
> You can go ahead and fix them as a separate commit.
>
> Thanks,
> Ludo=E2=80=99.
--0000000000009e16e905706cc0de-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 09 04:43:30 2018 Received: (at 31911-done) by debbugs.gnu.org; 9 Jul 2018 08:43:30 +0000 Received: from localhost ([127.0.0.1]:51697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcRla-0003l7-0t for submit@debbugs.gnu.org; Mon, 09 Jul 2018 04:43:30 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:40953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcRlY-0003kv-8z for 31911-done@debbugs.gnu.org; Mon, 09 Jul 2018 04:43:28 -0400 Received: by mail-it0-f52.google.com with SMTP id 188-v6so25265130ita.5 for <31911-done@debbugs.gnu.org>; Mon, 09 Jul 2018 01:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=YwfHhRmeXXkM8NagQxu7D1OJ57NishOuI6k7Niao3i4=; b=aqZ4w5gqioAs3mJULt4KDsZytzO3HzryC4yIweqApDWz5IQ10ds3HC0p1OcyNn8x1C b/5CrtxiZPWLThakBJQgrKXT2q591IhWfrLMrJaahzASoUh9G2wJ47RTo/REHobCV5wm 7Vr+OflOgYfIWKdIR+r2W9534tzFa4DRLY7N3UVDsMiIbuNWRtS4i7hW2ZPOtnHwTOJX oVFRUVSs4VdhPHmF8Nlqi0N9NOzpsD7mY+ZBtTe3UA3kCLYrjWQ4wXWGKZBwAzeyet98 iv6IID+YXk3jtnTTxRpHEtCq0QfKVO2QoWq8VRv67oE/tl+u9yz7cd5gG/C1tFLTej85 R5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YwfHhRmeXXkM8NagQxu7D1OJ57NishOuI6k7Niao3i4=; b=CMBQG1x5zbigSx3K6mZbLco+jMZuBFLN+zL9ACg3W/tafI3SVKQz4wuzhs+8vbqNmu NEu4bflM/EbwrP1hRRfXF8dYCyd8Dcv9gJi3YITld4teykqflWZ1qVPEv0k/HO+W52Al qkbzQt3dUAhv9Ls6AhGtsmSiVoNmUJL0PCPIndnC26hWcAuqZwKLgbA0eobphoYc5sjG ACT28XGMZrOlqbJhyjnOmrjn8XG/uEedhoZ/cuUwADzbVz8ixbijEB3Y1mbo5yLtNIf0 RGEduTOiLlfC8AFZRzF8Yplfujfm8s5AGVt/RR+qm24fc5lY97cAXWU2wtccJd9mnDve 1mdQ== X-Gm-Message-State: APt69E0khlqkvt+Hsb5Nc/HAfL08fh4bKZZKzJ378+2gkdooCUlLa6Ve Y8Hym86Jyf8IVumRQpIsZZgwl40+wlqH6mfhFaw1p6Y= X-Google-Smtp-Source: AAOMgpfKb3I+fsVVrBEvrK7G4ElgWMm8Zvg9ApLWya8GVVY4QdgCjq+XrJpf3p0RnvJMMIR49jbv8YisMvvRhwbb3FA= X-Received: by 2002:a02:5cd3:: with SMTP id w80-v6mr16483054jad.85.1531125802258; Mon, 09 Jul 2018 01:43:22 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Mon, 9 Jul 2018 10:43:11 +0200 Message-ID: Subject: services: Add prometheus-node-exporter-service-type. To: 31911-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="0000000000008cd40005708d0159" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e. Pushed to master asĀ a33652ee336ae9a5d2ab5fd54bf2397caec42a0e. [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (boskovits[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.2 HTML_OBFUSCATE_10_20 BODY: Message is 10% to 20% HTML obfuscation 0.0 HTML_MESSAGE BODY: HTML included in message -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.214.52 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.52 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 TVD_SPACE_RATIO No description available. 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 31911-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --0000000000008cd40005708d0159 Content-Type: text/plain; charset="UTF-8" Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e. --0000000000008cd40005708d0159 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Pushed to master as=C2=A0a33652= ee336ae9a5d2ab5fd54bf2397caec42a0e.
--0000000000008cd40005708d0159-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 09 05:17:12 2018 Received: (at 31911-done) by debbugs.gnu.org; 9 Jul 2018 09:17:12 +0000 Received: from localhost ([127.0.0.1]:51707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcSIC-0004Yg-ML for submit@debbugs.gnu.org; Mon, 09 Jul 2018 05:17:12 -0400 Received: from mail.lassieur.org ([83.152.10.219]:40364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcSIB-0004YY-A5 for 31911-done@debbugs.gnu.org; Mon, 09 Jul 2018 05:17:11 -0400 Received: from newt (smtp.parrot.biz [62.23.167.188]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id f4271123 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Mon, 9 Jul 2018 09:17:09 +0000 (UTC) References: <20180620125946.7264-1-boskovits@gmail.com> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: bug#31911: services: Add prometheus-node-exporter-service-type. In-reply-to: Date: Mon, 09 Jul 2018 11:17:09 +0200 Message-ID: <87sh4s93ai.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31911-done Cc: 31911-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi G=C3=A1bor, G=C3=A1bor Boskovits writes: > Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e. > + (test-assert "prometheus-node-exporter running" > + (marionette-eval > + '(begin > + (use-modules (gnu services herd)) > + (match (start-service 'prometheus-node-exporter) > + (#f #f) > + (('service response-parts ...) > + (match (assq-ref response-parts 'running) > + ((pid) (number? pid)))))) > + marionette)) The PID check is useless because START-SERVICE will return #f if the service fails to start. Instead, I'd use: (test-assert "prometheus-node-exporter running" (marionette-eval '(begin (use-modules (gnu services herd)) (start-service 'prometheus-node-exporter)) marionette)) This would also make the test more robust to service changes (e.g. it would still work if MAKE-FORKEXEC-CONSTRUCTOR is removed). Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 09 10:12:56 2018 Received: (at 31911-done) by debbugs.gnu.org; 9 Jul 2018 14:12:56 +0000 Received: from localhost ([127.0.0.1]:52534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcWuO-0005GG-5I for submit@debbugs.gnu.org; Mon, 09 Jul 2018 10:12:56 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:33371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcWuM-0005G3-CB for 31911-done@debbugs.gnu.org; Mon, 09 Jul 2018 10:12:54 -0400 Received: by mail-io0-f182.google.com with SMTP id z20-v6so17183617iol.0 for <31911-done@debbugs.gnu.org>; Mon, 09 Jul 2018 07:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SVnvJoi9XNCA9S+3oBAijl3P0FEgtS1JkzCzbcyE4lQ=; b=F1a6feeHucCyWR2oJ5Fjr9CcooAhbqY8U1GEh02rD4JoiqenOEoMCzOWl73t2wtLCo T2l5u/jiH90bXEnQm+9u2lWkug2ZWX49kHQg4zDzBrUUt+XZr6nIwvK3ntS++5g/s2qQ k0nwOvPKM9rR0WFTHnu7DEEY7n+Ralil6qvtz5oW5ysgFeyuagwL5sf3d+T261Y2jX2Z /v2c7U7jk3WNObRa1/6UoEXtw0r3KsM6YG3nbMfCrZ6l0y3oGgxqEIasIZpOECMTAQiy 6Y02B2+Jvvw3V19vmBm+CKRS3y1B75Q5RM8d4sTXzqTsntcXtV/B3uuGCocBhzJH5L9S TkHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SVnvJoi9XNCA9S+3oBAijl3P0FEgtS1JkzCzbcyE4lQ=; b=diYOgyx4Fd17TZKSmK8de+TgW6j0HWZLHfbGWPkbrJGej8Ab8qauG+pdwoSGOvnMpV Lc49y1iFVQWfK3CQWBON01Ai2PmPqjQrPjQfPkX9ei+mqPNZpMZr7FYv0B9VJTgJNNyE iukPClg04j37Lty+S4sQmdLaP1UnF3l39T5priPDtY3zVd7aGZk6g/yF6F7p5RYusrtS s+KZFovATdlznrCLzMu27wliFYFSW7ARzrpEaYuUkL9F3U09biuHOPV2338f1QZ3No8E bOCWqN2OWcA9A6VKUR53oBPz499tV3MpBtWVhLRXDY9vlXrJbN1oNgUJ5FWnIay8gxU3 VGPQ== X-Gm-Message-State: APt69E0L1JvXz8YZh+qs3juy310L74N85bRv7JA3bgjYudHO98ChYFZh x913a4AG5PLIzsKEX9Fzuki7VsoBZI5ohjyXLg== X-Google-Smtp-Source: AAOMgpdl/e7cqNrFnlp3ClMACPP1SxhNFcSjoWj7hBPWKqN7HgFpJl/Mj+14tx9JnlE58EwRPZXXOlBi55Nlox7x2yI= X-Received: by 2002:a6b:e211:: with SMTP id z17-v6mr17337380ioc.44.1531145568818; Mon, 09 Jul 2018 07:12:48 -0700 (PDT) MIME-Version: 1.0 References: <20180620125946.7264-1-boskovits@gmail.com> <87sh4s93ai.fsf@lassieur.org> In-Reply-To: <87sh4s93ai.fsf@lassieur.org> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Mon, 9 Jul 2018 16:12:37 +0200 Message-ID: Subject: Re: bug#31911: services: Add prometheus-node-exporter-service-type. To: =?UTF-8?Q?Cl=C3=A9ment_Lassieur?= Content-Type: multipart/alternative; boundary="000000000000ba9bd70570919b81" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31911-done Cc: 31911-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ba9bd70570919b81 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cl=C3=A9ment Lassieur ezt =C3=ADrta (id=C5=91pont: 2= 018. j=C3=BAl. 9., H, 11:17): > Hi G=C3=A1bor, > > G=C3=A1bor Boskovits writes: > > > Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e. > > > + (test-assert "prometheus-node-exporter running" > > + (marionette-eval > > + '(begin > > + (use-modules (gnu services herd)) > > + (match (start-service 'prometheus-node-exporter) > > + (#f #f) > > + (('service response-parts ...) > > + (match (assq-ref response-parts 'running) > > + ((pid) (number? pid)))))) > > + marionette)) > > The PID check is useless because START-SERVICE will return #f if the > service fails to start. Instead, I'd use: > > (test-assert "prometheus-node-exporter running" > (marionette-eval > '(begin > (use-modules (gnu services herd)) > (start-service 'prometheus-node-exporter)) > marionette)) > > This would also make the test more robust to service changes (e.g. it > would still work if MAKE-FORKEXEC-CONSTRUCTOR is removed). > > Thanks, I will adjust accordingly. Incidentally the code is almost the same as in hpcguix-web test. Should we also adjust that? > Cl=C3=A9ment > --000000000000ba9bd70570919b81 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=
Hi G=C3=A1bor,

G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (test-assert "prometheus-node= -exporter running"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (marionette-eval
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'(begin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (use-modules = (gnu services herd))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (match (start= -service 'prometheus-node-exporter)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (#f #f= )
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (('= ;service response-parts ...)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (match (assq-ref response-parts 'running)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0((pid) (number? pid))))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0marionette))

The PID check is useless because START-SERVICE will return #f if the
service fails to start.=C2=A0 Instead, I'd use:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (test-assert "prometheus-node-expor= ter running"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (marionette-eval
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'(begin
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (use-modules (gnu s= ervices herd))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (start-service '= ;prometheus-node-exporter))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0marionette))

This would also make the test more robust to service changes (e.g. it
would still work if MAKE-FORKEXEC-CONSTRUCTOR is removed).


Thanks, I will adjust accordingly. Inc= identally the code is almost the same as in hpcguix-web test. Should we als= o adjust that?
=C2=A0
Cl=C3=A9ment
--000000000000ba9bd70570919b81-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 09 10:21:50 2018 Received: (at 31911-done) by debbugs.gnu.org; 9 Jul 2018 14:21:50 +0000 Received: from localhost ([127.0.0.1]:52548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcX30-0005UJ-KB for submit@debbugs.gnu.org; Mon, 09 Jul 2018 10:21:50 -0400 Received: from mail.lassieur.org ([83.152.10.219]:40374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcX2z-0005UB-7O for 31911-done@debbugs.gnu.org; Mon, 09 Jul 2018 10:21:49 -0400 Received: from newt (smtp.parrot.biz [62.23.167.188]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id e9f63afb (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Mon, 9 Jul 2018 14:21:45 +0000 (UTC) References: <20180620125946.7264-1-boskovits@gmail.com> <87sh4s93ai.fsf@lassieur.org> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: bug#31911: services: Add prometheus-node-exporter-service-type. In-reply-to: Date: Mon, 09 Jul 2018 16:21:44 +0200 Message-ID: <87pnzw8p6v.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31911-done Cc: 31911-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) G=C3=A1bor Boskovits writes: > Cl=C3=A9ment Lassieur ezt =C3=ADrta (id=C5=91pont:= 2018. j=C3=BAl. 9., > H, 11:17): > >> Hi G=C3=A1bor, >> >> G=C3=A1bor Boskovits writes: >> >> > Pushed to master as a33652ee336ae9a5d2ab5fd54bf2397caec42a0e. >> >> > + (test-assert "prometheus-node-exporter running" >> > + (marionette-eval >> > + '(begin >> > + (use-modules (gnu services herd)) >> > + (match (start-service 'prometheus-node-exporter) >> > + (#f #f) >> > + (('service response-parts ...) >> > + (match (assq-ref response-parts 'running) >> > + ((pid) (number? pid)))))) >> > + marionette)) >> >> The PID check is useless because START-SERVICE will return #f if the >> service fails to start. Instead, I'd use: >> >> (test-assert "prometheus-node-exporter running" >> (marionette-eval >> '(begin >> (use-modules (gnu services herd)) >> (start-service 'prometheus-node-exporter)) >> marionette)) >> >> This would also make the test more robust to service changes (e.g. it >> would still work if MAKE-FORKEXEC-CONSTRUCTOR is removed). >> >> > Thanks, I will adjust accordingly. Incidentally the code is almost the sa= me > as in hpcguix-web test. Should we also adjust that? You're welcome :-) It's not urgent, but in the long term, it would be good that all similar code is ajusted accordingly. It's in lots of other places as well if I remember well. From unknown Fri Jun 20 07:09:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Aug 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator