From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 22:34:28 2018 Received: (at submit) by debbugs.gnu.org; 20 Jun 2018 02:34:28 +0000 Received: from localhost ([127.0.0.1]:56779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVSx0-0005Vq-9y for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:34:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVSwy-0005Vd-Rv for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVSws-0004jx-Bc for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:34:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54985) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVSws-0004jn-7v for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:34:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVSwq-0000DI-Hm for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:34:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVSwn-0004gD-Cx for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:34:16 -0400 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:41413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVSwn-0004g2-69 for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:34:13 -0400 Received: by mail-qt0-x22c.google.com with SMTP id y20-v6so1722582qto.8 for ; Tue, 19 Jun 2018 19:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=G9DzSEhDDEhLxrnhp2uHGsqsM/nhWf20vtJyAuMT0mM=; b=s8EN28TUEmJ/dKVgoT6vHVlbh6jXHta2sXrXU92rJfYWM9DBL8T2/fLi4aaa50Pgam VOuCLOb8l7UadXOQQ6n5w39i7H5l/LSDQrDjCLAp2m/AnXK2Xuw0eqW/44BQLm3SNqSF tC3PoHKiGhQz0Mo24gwgJkD6+rX6qQzlaXCjZpzB2HFAtJzXY71a778iD38UsRvhJkfB WtmoIeRwCqTHFTsHoXbi2ZNbLZ0FXFwz159KBKW0axYy4BcGrGyfj/7hVMxdZ84v0H+Y Tm60yClgrNkBrZs37Z10UOMavR5lekbhLii0jKtOk9jH9JLj3QKMFXKe2rbcWUx+/CSH YImg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=G9DzSEhDDEhLxrnhp2uHGsqsM/nhWf20vtJyAuMT0mM=; b=ejIBccj8TUL2rXObQzf+Ld16ElJzh9pUsO9wdUfHHCPyv0oGm31711UjW1DkzQ/bIT BExVuPYiL72QC+LW/OWdr5F1cBql0gwp8Z/s0uyG87bHtMd3Shp0g+4b/bnWj31DCxep v6IDRDRr1b2dg37XgwN7+BhJC9LwNKTeQSZ37kZkbPX/fYu53gy27vRIH6XHRGeo0HAe IyCPn33pqurJAqbWEGJ9zV1P/a+zPrL+oFs83mfz2ReVZDzi7BnBZfIzmTyp66kRxzgF fAQ+jyWEERdw8hKVCvLN2tIj0seAseEEl+Cx2Oy0TblDM35GCw4+vnqHN/VPdtfGFbTs v59w== X-Gm-Message-State: APt69E3M1D0Pl0111wtoTqK/HxmVpNpd8m4ZejhLTuFlb0kSAP7eCXtO 3ytj6DziO3UsVOjc9fa+ULmSaA== X-Google-Smtp-Source: ADUXVKIliiqbHfHE+7wTpfgaYqHjBhZniOlVPjsxhMOllFWPYLjrtZN31cHnKAb0O852WPQ/d3gXzw== X-Received: by 2002:ac8:260f:: with SMTP id u15-v6mr18015037qtu.368.1529462051977; Tue, 19 Jun 2018 19:34:11 -0700 (PDT) Received: from carlos ([190.244.190.18]) by smtp.gmail.com with ESMTPSA id e25-v6sm737494qkm.6.2018.06.19.19.34.10 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 19:34:11 -0700 (PDT) From: Carlos Pita To: bug-gnu-emacs@gnu.org Subject: 26.1.50; Properly set completion-at-point-functions in eshell Date: Tue, 19 Jun 2018 23:34:03 -0300 Message-ID: <87vaaeqj8k.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Currently C-M-i is bound to: (defun eshell-complete-lisp-symbol () "Try to complete the text around point as a Lisp symbol." (interactive) (let ((completion-at-point-functions '(lisp-completion-at-point))) (completion-at-point))) This is fine but interferes with other completion frameworks that peep into completion-at-point-functions, for example company. Why not properly setting the functions for the buffer as most modes do instead of overriding its value on every completion call? --- In GNU Emacs 26.1.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-06-18 built on carlos Repository revision: 0a8b7f365cbc8de02ddb4e806dd76b1bf6302565 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Manjaro Linux Recent messages: Invalid face attribute :inherit nil Invalid face reference: comint-highlight-prompt Invalid face attribute :inherit nil Invalid face reference: comint-highlight-prompt Invalid face attribute :inherit nil Invalid face reference: comint-highlight-prompt Invalid face attribute :inherit nil Invalid face reference: comint-highlight-prompt Invalid face attribute :inherit nil Invalid face reference: comint-highlight-prompt Configured using: 'configure --prefix=/home/carlos/Local/stow/emacs-26 --libexecdir=/home/carlos/Local/stow/emacs-26/lib --with-x-toolkit=gtk3 --with-xft --with-modules' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS LIBSYSTEMD LCMS2 Important settings: value of $LC_MONETARY: en_US.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Shell Minor modes in effect: diff-auto-refine-mode: t pyvenv-mode: t shell-dirtrack-mode: t xclip-mode: t winner-mode: t show-paren-mode: t ido-ubiquitous-mode: t ido-everywhere: t global-company-mode: t company-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail em-rebind em-smart em-tramp cus-dep autoload cus-theme erc-pcomplete erc-goodies erc erc-backend erc-compat misearch multi-isearch noutline outline lisp-mnt jka-compr dabbrev pp cl-print completion face-remap eieio-opt speedbar sb-image ezimage dframe find-func pcmpl-unix em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias sh-script smie executable term/xterm xterm display-line-numbers checkdoc flymake-proc flymake warnings doom-themes-org vc-git cl-extra yasnippet elec-pair highlight-indentation help-fns radix-tree help-mode elpy find-file-in-project ivy delsel ivy-overlay ffap thingatpt windmove diff-mode easy-mmode elpy-shell pyvenv esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util elpy-profile elpy-django elpy-refactor subr-x python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize shell pcomplete parse-time format-spec advice json map grep compile comint ansi-color files-x company-oddmuse company-keywords company-etags etags xref project company-gtags company-dabbrev-code company-dabbrev company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb doom-tomorrow-night-theme doom-themes doom-themes-common xclip winner ring paren ido-completing-read+ memoize s cus-edit minibuf-eldef ido gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit company edmacro kmacro pcase cus-start cus-load finder-inf info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib server time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1196737 80838) (symbols 48 38962 1) (miscs 40 3723 686) (strings 32 105392 2953) (string-bytes 1 2805376) (vectors 16 71622) (vector-slots 8 1810041 127260) (floats 8 334 648) (intervals 56 5454 399) (buffers 992 34)) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 22:41:03 2018 Received: (at submit) by debbugs.gnu.org; 20 Jun 2018 02:41:03 +0000 Received: from localhost ([127.0.0.1]:56785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVT3P-0005fL-Jy for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:41:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVT3O-0005ei-4L for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:41:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVT3I-00009Y-3K for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:40:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVT3H-00009S-WF for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:40:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVT3H-0001t3-2F for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVT3G-00007O-CC for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:40:55 -0400 Received: from mail-it0-x229.google.com ([2607:f8b0:4001:c0b::229]:55683) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVT3G-00007A-6f for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:40:54 -0400 Received: by mail-it0-x229.google.com with SMTP id 16-v6so3346676itl.5 for ; Tue, 19 Jun 2018 19:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=hNSHgknQQhAF33/KMNCgYT78awgT5RIeHsVZ+V5jF+k=; b=Q9K0TgHaqX/yPjwh7LsdoMU4UaekTvTfJyOnh08pdniOLKdmH9boHhyLRiVB+oYhbN tMPjuJQdY2wiF5B1npGBjj9MvrGXpuu9pE4Gf1UxayjmjMtIHWaRzQW1rdZ2q9TNW0dw hlFP/lyQGqqxKfA3gRs1XAAzZhIBQVGguSIug9YLPWaBqcDB+3zX12eR3eDyTsOr+wXv lTYnRzA81XV79SMeC4TYN6AlMist4c/yG3FLUgkS799bs5bAXB3DYZ+MexVlKDrauYmT 6IQLDH+IV+nLeSLHFbZkNnOjZlKUZnizaHafxxE8iPrtxNVhghzOV3yQGY0QIJEcVP8z aPeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=hNSHgknQQhAF33/KMNCgYT78awgT5RIeHsVZ+V5jF+k=; b=glYoE+uZ0Bv5NZE+wtxe6K2DWB7PflX7p7sn/WY98wmayoqSL9uMq9wHQMhGFhR9JK pL2GuwzfNGsykNc/qyZdi8U83amRV7a4wKbxpa45y8zE4xrRRs8gr8LRqrhtkGND/d55 FE5hdWvAjhO/wQpcBXXmvxVrzGSSn32JW6cEU9Y99/KdlwhlWFJd0ew3RmYT1b7eu1Hv y0geE/V9W109dq+DoG2zib3ZcHDbNMBwryi9FAzAKNiCJV9bJCoZ6CNsm/h6f1Q64BVU Mh/MKjQY1EJK424lLlQX5hdkIauA7T9ZUtxX1HlKpRlu6D1npULQ0GgmRQwHLJfWYt5L gX0A== X-Gm-Message-State: APt69E2Gy9uqksO0fuljkCklHB+ZxT4FIB5poC88sFe3zHcc0tIeysnm Xh6i0v2FERG7p+wAHjlg9TjqrRHJpaFCnijSmxLRRg== X-Google-Smtp-Source: AAOMgpdVW6YMmk7RMVVDdNncQqEASu0lCe6fT+OHIJTug+0d3GYMum+gC9CN7PiRXixgOWpXFsP7e+YVZuKY89ZS+1A= X-Received: by 2002:a24:e44a:: with SMTP id o71-v6mr156065ith.86.1529462453292; Tue, 19 Jun 2018 19:40:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 19:40:32 -0700 (PDT) In-Reply-To: <87vaaeqj8k.fsf@gmail.com> References: <87vaaeqj8k.fsf@gmail.com> From: Carlos Pita Date: Tue, 19 Jun 2018 23:40:32 -0300 Message-ID: Subject: Re: 26.1.50; Properly set completion-at-point-functions in eshell To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Oh, by the way: (lisp-completion-at-point &optional PREDICATE) This function is obsolete since 25.1; use =E2=80=98elisp-completion-at-point=E2=80=99 instead. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 23:00:00 2018 Received: (at submit) by debbugs.gnu.org; 20 Jun 2018 03:00:00 +0000 Received: from localhost ([127.0.0.1]:56791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTLk-00065i-7j for submit@debbugs.gnu.org; Tue, 19 Jun 2018 23:00:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTLi-00065T-QT for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:59:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTLc-0007VZ-NP for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:59:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVTLc-0007VT-Jv for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:59:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVTLb-0006h0-Er for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTLa-0007Uv-MU for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:59:51 -0400 Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]:39237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVTLa-0007Ue-Gv for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:59:50 -0400 Received: by mail-io0-x229.google.com with SMTP id f1-v6so2149260ioh.6 for ; Tue, 19 Jun 2018 19:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=JwwcxVXQOog+NiciG6jtPvdyGnJRXm18y6cmziKKSR0=; b=vRlQ1CmWdRYfq0SJu9CzCT79VjNWy8CuUwR1CgbP+RXJqIDZW/+DE1xak5XVSmAM9+ Z5S6n75J+nxRtYfX8eyXO5c5ncQitSWOSmwJv9HmJ8itzFzPBTI/wxLUPQQOTK/JBhnC qSswOksdzms0kFDNyaf4iypwDBvyGjkvo3spTIIfUYhjZBQyA8XxFfXm+IZJJk8t5sXO EpJquZiI809/A9A9+ww1mXHg4q3w2bVO6Psix6pdRPhi4QIRHAxCP1qNlukbuzgNpLqq uPrb5qlw31Izod7E4sztYFRsfyQ7ylLF/ElnKuN1z7y2Js8DlepHExxkdc/usz12au/S SlgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=JwwcxVXQOog+NiciG6jtPvdyGnJRXm18y6cmziKKSR0=; b=IzkVzro8wtrvkG+nU00nQojb2ACuR/UQPGVsJ5ngu2hxTyHzZGjTSQibig8hZ1Zqf9 B4uc+nqGVKvPQfu8egAVyDpnj/TGfptfwJWND+RJ3xnD6sXmWjYohPAg3cep9nF2dG1j 5V2QrWAidVlb6/3f1cco9sPaQv6k9z9s8k+oh8OXRrFk3jDN6a0nnxhBHNT+KoZjQypZ SGvfxotuGgxqPyhNN6ojAIWdhrOKPcbH1d07Xsnb8qO5mrrbSNr2tL7z9b/IDQ2Wje3h Lsh81bR2hjpRWgV0I27gYYeHl+yk7I32h+2WcogaUJ7nPDlwwGL6RVEzXFHTe3jQwihj hG8w== X-Gm-Message-State: APt69E0j6dPUOSy3vo6I96KEGWJPXm56sXiWTnWKSRXNUAb1MeKV2zjR aFpqH2Fx+sWz8nCY8RUC/4hWoisffOsZ7Z1h/vCq7Q== X-Google-Smtp-Source: ADUXVKLJaZCal5fRL7KGzoQ74G0jBvOZ+FYju9VpWShnyFmQ/WDkYxjHaboo0XcsB+0QzkPCSnSjwmLXjFP5TsUebf0= X-Received: by 2002:a6b:de14:: with SMTP id v20-v6mr15859903iog.260.1529463589470; Tue, 19 Jun 2018 19:59:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 19:59:29 -0700 (PDT) In-Reply-To: References: <87vaaeqj8k.fsf@gmail.com> From: Carlos Pita Date: Tue, 19 Jun 2018 23:59:29 -0300 Message-ID: Subject: Re: 26.1.50; Properly set completion-at-point-functions in eshell To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mmmh it seems to be that it's overriding the default pcomplete-completions-at-point. But then why is this default set at all? is directly bound to eshell-pcomplete, a simple wrapper around pcomplete, which AFAICS doesn't rely on completion-at-point-functions. But there is this workaround for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=12838 in the final line of eshell-pcomplete: (defun eshell-pcomplete (&optional interactively) "Eshell wrapper for `pcomplete'." (interactive "p") ;; Pretend to be pcomplete so that cycling works (bug#13293). (setq this-command 'pcomplete) (condition-case nil (if interactively (call-interactively 'pcomplete) (pcomplete)) (text-read-only (completion-at-point)))) ; Workaround for bug#12838. Although I don't fully understand the workaround. So to sum up, what I would have expected is: 1. completion-at-point-functions contains only elisp-completions-at-point. 2. M- is bound to completion-at-point. 3. is bound to a wrapper to pcomplete (that doesn't call completion-at-point). All these expectations are violated. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 23:39:19 2018 Received: (at submit) by debbugs.gnu.org; 20 Jun 2018 03:39:19 +0000 Received: from localhost ([127.0.0.1]:56805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTxm-00075L-Ur for submit@debbugs.gnu.org; Tue, 19 Jun 2018 23:39:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTxk-000757-S5 for submit@debbugs.gnu.org; Tue, 19 Jun 2018 23:39:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTxe-00082t-T4 for submit@debbugs.gnu.org; Tue, 19 Jun 2018 23:39:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVTxe-00082p-PW for submit@debbugs.gnu.org; Tue, 19 Jun 2018 23:39:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVTxd-0008SX-Ru for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:39:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTxd-00082U-7i for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:39:09 -0400 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]:53279) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVTxd-00082Q-1W for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:39:09 -0400 Received: by mail-it0-x236.google.com with SMTP id a195-v6so3501429itd.3 for ; Tue, 19 Jun 2018 20:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=QoRQdDtaCTjgOMjA7qKncMza79+bxZzQTG04/f7dfaY=; b=EL+ks9BzDleNJEyc7HMIqGw73oNWfE5I5ImVJGdPOvGTLHI/HQ2oj9XBsYF50jZoLI lOilA6NbQgjZbfse+HWoOLyLn2d6reyAUOrs1DcIdqM1fHXcjQ2VfX0GVBDdjH6D9++J rscsttiYUsOKXq+InvV9gXEZXdxu0hVHpYxRJqGRkco2cn6br5V7TDWgDbxnBvMEXRP2 l8ZZ/vfVRkIgL+67yGHe5Z6gsRvwr4/GETkCbKtjuTeKtjYYzhxL1ZxPCga1ByhwW13Z MzE8D2q0WRtngKlu0MzaeeF+CCXGNxoz6ku05g/7KLbHox9BNv7CBeRbVuh0arkjC1uJ DKig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=QoRQdDtaCTjgOMjA7qKncMza79+bxZzQTG04/f7dfaY=; b=Y4z1o5OVmoAok58iwkTN25jbjYBF0F3JQDw4MhtYGb6iNLDU2aSwBDAMeMYvfrKJPe fgK/lS73IC2PvdKrzOmLCkXQaLnc3Qj7UNDDIEbBUfu5PMl/aXs7ip9/Q9aycmFS18uy jFbcgJoxnFw/pim7OpTRvSSi8SVsAwgNe8zCX2Vm051Ev0bjG9lb8Ks5UeX++O00T4u4 K0e3EUfkzH5oVuSFIAy/0lL9UT9S13c2luQ2bl5lWFiWe0nOi0RNE+lL6nIq8N2Mm8Jl mIONIpBvLoCceSsv9b9XPdUJXAHkelpTEJwyFFl9o4MS4LpX405ZgmJFUs94nvBTSDTn U+qQ== X-Gm-Message-State: APt69E0YVPaYU+g1O+zQoqL9VaiLjP5VTTx8C4Wp8IfJnZqmS6COL/Za pALXFXty0ZOHIa5VvzLjD9Goph7jWLhC/yK/jO8OmQ== X-Google-Smtp-Source: ADUXVKK5glEfMAEcYiNNNSy3CTMFdx0mmCFv4bKpdvigrfffX7kD8AkEnrgv5Q7L2KWNu3Psep6bzyS5GpmB19/CSco= X-Received: by 2002:a02:8ce9:: with SMTP id n38-v6mr15996828jal.24.1529465947924; Tue, 19 Jun 2018 20:39:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 20:38:47 -0700 (PDT) In-Reply-To: References: <87vaaeqj8k.fsf@gmail.com> From: Carlos Pita Date: Wed, 20 Jun 2018 00:38:47 -0300 Message-ID: Subject: Re: 26.1.50; Properly set completion-at-point-functions in eshell To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Well, inspecting the code a bit more I conclude that all of the above is in order to make completion-at-point work as a fallback for some corner cases that break pcomplete, hence the same completion functions should be installed for both completion mechanisms, although M- can't access them. This has the happy consequence that company sees the more relevant completions (the ones). It's hackish but I think this can be closed (although the obsolete name lisp-completion-at-point could be updated). From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 22:14:40 2019 Received: (at 31906-done) by debbugs.gnu.org; 3 Oct 2019 02:14:41 +0000 Received: from localhost ([127.0.0.1]:38641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqdc-0005e3-NV for submit@debbugs.gnu.org; Wed, 02 Oct 2019 22:14:40 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:43921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFqdb-0005dr-3s for 31906-done@debbugs.gnu.org; Wed, 02 Oct 2019 22:14:39 -0400 Received: by mail-pg1-f172.google.com with SMTP id v27so738268pgk.10 for <31906-done@debbugs.gnu.org>; Wed, 02 Oct 2019 19:14:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=/VKbqIlcC077x0zKERVj4pvGekFxiC+Tuq2CqT1CSEs=; b=bBE2FqAp4Ub3aeKnSzhe8yaZ4dTAyERNWfV6hKPfCCO12tp2E8c3BLlZvlCAA2WziC kHOcpqTIFWAcwuEp51WdvCy2hGo5WRAbouJCrPgQmW68Q2fMHXPrOrhr+iVdSUyouYRD Ewt5zyGs4yNRzMMM/CR8xySxjfbPbeBa2ZuNYA9O8Cz4hh5V3DU8ExOUic8jJ6BZs0Ur 1NplDmO/fqhAMxhRdLfH2V3ZrKOGCypP6A5b7EfDO0dPxOCWgK9xO3hdPlWWfxM2HWKy vMoY1NXNfLX3fWf6kCqFp+rnuuU9zB2ztjf9+vs9OLurRpLkAb1BrVspbp75dPxONYJM WXuA== X-Gm-Message-State: APjAAAWBpY/18zn1zk6ubEyBuUkT/7izU+SH4ZduQw9cCU96c0xlM19g W5JrP0ubS+efSJ3BKINP9Yr4oDk3ssBoAOFY1va2iEaB+xs= X-Google-Smtp-Source: APXvYqw+PN6Q/L1AdlUioRnFTzs6f6TB2WHBmmMOD2X57zdZY1/NOJ+zswd6qaY80523zMQjYQXfV4O030tkhKIE0sk= X-Received: by 2002:a63:720f:: with SMTP id n15mr6757398pgc.198.1570068873043; Wed, 02 Oct 2019 19:14:33 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 3 Oct 2019 04:14:21 +0200 Message-ID: Subject: Re: bug#31906: 26.1.50; Properly set completion-at-point-functions in eshell To: Carlos Pita Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 31906-done Cc: 31906-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Carlos Pita writes: > Well, inspecting the code a bit more I conclude that all of the above > is in order to make completion-at-point work as a fallback for some > corner cases that break pcomplete, hence the same completion functions > should be installed for both completion mechanisms, although M- > can't access them. This has the happy consequence that company sees > the more relevant completions (the ones). It's hackish but I > think this can be closed OK, closing now. > (although the obsolete name lisp-completion-at-point could be > updated). Fixed on master, thanks. Best regards, Stefan Kangas From unknown Sun Jun 15 08:52:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 31 Oct 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator