From unknown Thu Jun 19 13:56:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31903 <31903@debbugs.gnu.org> To: bug#31903 <31903@debbugs.gnu.org> Subject: Status: 26.1; make-network-process :server t signals error with :nowait t instead of ignoring it Reply-To: bug#31903 <31903@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:56:05 +0000 retitle 31903 26.1; make-network-process :server t signals error with :nowa= it t instead of ignoring it reassign 31903 emacs submitter 31903 Helmut Eller severity 31903 minor tag 31903 confirmed patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 14:00:36 2018 Received: (at submit) by debbugs.gnu.org; 19 Jun 2018 18:00:36 +0000 Received: from localhost ([127.0.0.1]:56646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVKvk-0006ec-8K for submit@debbugs.gnu.org; Tue, 19 Jun 2018 14:00:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVKvi-0006eP-Hq for submit@debbugs.gnu.org; Tue, 19 Jun 2018 14:00:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVKvc-0000YR-Bp for submit@debbugs.gnu.org; Tue, 19 Jun 2018 14:00:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVKvc-0000YK-7d for submit@debbugs.gnu.org; Tue, 19 Jun 2018 14:00:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVKva-00013y-UV for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 14:00:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVKvX-0000Su-HW for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 14:00:26 -0400 Received: from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]:43188) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVKvX-0000Rz-An for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 14:00:23 -0400 Received: by mail-wr0-x234.google.com with SMTP id d2-v6so545930wrm.10 for ; Tue, 19 Jun 2018 11:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=ipYmRKinE3jTFl9pbBUSdPfQZg+Slt/QHdU9jr7R6QI=; b=p4YPskMUkqeascpOOKGkFhKfje0gpR9RkI9elfx7yOS8u3j2CIL7ZzWOXIlhDu+yP9 s6oLBcqMn2QLFN/0RLlO0rdQx8WiYL2Rctm8TP1VR/K/JyQSQsKZDbRX/PnpcsN/75E+ sHv3feY4gikbcW2z8Eg5IFT3p34ETpN+Yfr6shbRU2iVyrdAUAJq3U1c0t5XiqkPEN0m 6iSgD4a57sA7LOMA9JZ/8q1HRFeR8svs78R3gZZmm0CE64EXsE+jVIZPw1ReqTvLROG1 5wtokqHGwlS/lmOd6ze3AZ+9Ya5oGA/uEgkI8iqpZxHvzHsnzn2J8u+90FXAPFqgpBZM XUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ipYmRKinE3jTFl9pbBUSdPfQZg+Slt/QHdU9jr7R6QI=; b=t1xsIUeqt1JOe8/MakpWOX+i2pQIkRuN+M0z0KVCmUH0V7d5p46c6lT+ZnsV2UPvaw iVwONtiuB7hwSHfpUfXfm1nCR0qoaz3fhkiDaQJl1iVoD7z8zWZp0NiiBe7AsxTdQRAW KHq1wB3RIM8MKfP/I+IEWf6vLgSZj0AWr72FT7tqHX3wVEMd114UkfdHoid90Ie8o77P DpemqRgIUAWPW2kUAB+ghB9jzsRkkmmcpccKbMHvemQwScUki+WQGmtcrwft+qDc9miX eDRvDMUMg6ekU8HZsF4rIuTZ8Z/85B3HLeqccu6VGPYQmIXcKzfHKy8mF0wuIJz3rK6q Mu7w== X-Gm-Message-State: APt69E1KSdEjZ7dOqNnUG3KtQRyLZ69hf2Fz9rcix8hc3gmqWpeWKVEu As2w6Npfcx7xyqVyG0EhNYMeOA== X-Google-Smtp-Source: ADUXVKLmEwexKouEDAr9X2Aq8EDpD940GDj7Dh7GuIYaxOyT4AiH1VNXxj6q6lvMPV1odLV4kc1/3g== X-Received: by 2002:adf:a4cf:: with SMTP id h15-v6mr15580314wrb.130.1529431221270; Tue, 19 Jun 2018 11:00:21 -0700 (PDT) Received: from caladan ([37.186.161.23]) by smtp.gmail.com with ESMTPSA id o12-v6sm522334wrf.30.2018.06.19.11.00.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 11:00:20 -0700 (PDT) From: Helmut Eller To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Server sockets with :nowait no longer work Date: Tue, 19 Jun 2018 20:00:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) With a file test.el containing this code: (make-network-process :name "*test*" :server t :nowait t :host 'local :service t :family 'ipv4) and starting Emacs with: emacs -Q -batch -l test.el prints: make server process failed: Success, :name, *test*, :server, t, :nowait, t, :host, local, :service, t, :family, ipv4 I'm not sure whether :nowait is supposed to work with server sockets, but this used to work in Emacs 25. Either way, the error message looks pretty wrong. elnode calls make-network-process[1] in a similar way, so it's quite annoying that this has changed (and obviously no one tested elnode). [1] https://github.com/nicferrier/elnode/blob/master/elnode.el In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-06-19 built on caladan Repository revision: a9b720ac5030a4ca84e8ebe8436027da0468624c Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9 (stretch) Configured using: 'configure --with-xpm=no --with-gif=no --with-tiff=no --with-jpeg=no --without-pop' Configured features: PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 01 11:48:54 2018 Received: (at 31903) by debbugs.gnu.org; 1 Jul 2018 15:48:55 +0000 Received: from localhost ([127.0.0.1]:42260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZeas-0005Fl-MB for submit@debbugs.gnu.org; Sun, 01 Jul 2018 11:48:54 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:32944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZeaq-0005FS-Jn; Sun, 01 Jul 2018 11:48:52 -0400 Received: by mail-io0-f175.google.com with SMTP id d185-v6so12633212ioe.0; Sun, 01 Jul 2018 08:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XW58cPT2WphOeytcrgyl4U8gCgGwfOn6lqzBFJRk9tE=; b=Lu9GKdAyUE7xT8QHmawXezy6Ix+05iHfOBVR/xT4EaV2gxZ/v5iO69+a2rwuCSr8ZV RizyjxWTPJkG51/v70EDAUsenzFNMZ3yLEndOpSrm2Wwo+IojJAKnupWvOQL7t5F0XDu mdG7JuMgwoPsTKCv6DduKeu7YBWW/sDj8ffRywKyGufEUUrMyGsOrEP0ZZNqz0fKczuz jCUQXbbx8wnQRUwljjMiCCxDeq0LYM0MfJWZeYhCylrBOPD+jW9wxHUjVUV3SZJuQbF3 X5UXrERVYBKHFRDzMO16Ow8MKMyjihu7wztGc7jOluVBJ1jBs7Ud4lujk/KfZslE3s8E XAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XW58cPT2WphOeytcrgyl4U8gCgGwfOn6lqzBFJRk9tE=; b=a5InfFk6G4pyKuEbWVKdnRDGtc/9iocOp5A0rPMQX2FVEQvYwm6HmQLDETE3zpbQyx 1poL63AEGbF5rfc27Fustw16dWTZpuXt7bANKfQbJgIaHSgyIbh9KHBW0Wsc+xMLC4xN sCBulOM/7S6NXbFB1R2pIPGadMh1w46laXNTAdC3+Koy3UG4EhhGTvfj+cSkUhZrK2I6 5naBetphbYmmy0AbNF3ANd6jtuYDABm6omXrnd0eqvb90ph3GmS6rIdW+fKXVMMnN0bI 0f+BxCFENWWigy2+p+2+mj/VOZyzpsdExHqU6tI4PeSKEqnxjt8uGBVb0rJp5Hz+ejxb DGHw== X-Gm-Message-State: APt69E0OkJH2K/c0HQcRjChouzF9lFCznZg+6Uw6k8ryFARlzS/2GByP XKuhhNvzlo/qZhP29ZTkhHSacg== X-Google-Smtp-Source: AAOMgpeQ1vQ4t1Qp072KiulCyCy7XMuZJmlHUqub+nEYq6W+QqUR3rIEMw7eqytIM+GetaNpH+nqwg== X-Received: by 2002:a6b:da14:: with SMTP id x20-v6mr3922955iob.102.1530460126952; Sun, 01 Jul 2018 08:48:46 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m31-v6sm2798172iti.10.2018.07.01.08.48.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Jul 2018 08:48:46 -0700 (PDT) From: Noam Postavsky To: Helmut Eller Subject: Re: bug#31903: 27.0.50; Server sockets with :nowait no longer work References: Date: Sun, 01 Jul 2018 11:48:45 -0400 In-Reply-To: (Helmut Eller's message of "Tue, 19 Jun 2018 20:00:14 +0200") Message-ID: <87bmbrlzxe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31903 Cc: Lars Ingebrigtsen , 31903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 31903 26.1; make-network-process :server t signals error with :nowait t instead of ignoring it found 31903 26.1 tags 31903 + confirmed severity 31903 minor quit Helmut Eller writes: > I'm not sure whether :nowait is supposed to work with server sockets, > but this used to work in Emacs 25. Either way, the error message looks > pretty wrong. As far as I can tell, Emacs 25 just ignores :nowait when :server is passed. We could change Emacs 26 do that as well, or we just make the error official but give a more a sensible error message when passed both :nowait and :server. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 02 11:25:54 2018 Received: (at 31903) by debbugs.gnu.org; 2 Jul 2018 15:25:54 +0000 Received: from localhost ([127.0.0.1]:43726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa0i6-0006Ij-KD for submit@debbugs.gnu.org; Mon, 02 Jul 2018 11:25:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa0hz-0006IR-JY for 31903@debbugs.gnu.org; Mon, 02 Jul 2018 11:25:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa0hp-0006UC-1Y for 31903@debbugs.gnu.org; Mon, 02 Jul 2018 11:25:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0ho-0006Ty-Fs; Mon, 02 Jul 2018 11:25:32 -0400 Received: from [176.228.60.248] (port=1351 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fa0hn-0001dq-V8; Mon, 02 Jul 2018 11:25:32 -0400 Date: Mon, 02 Jul 2018 18:25:18 +0300 Message-Id: <83va9xk6ch.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87bmbrlzxe.fsf@gmail.com> (message from Noam Postavsky on Sun, 01 Jul 2018 11:48:45 -0400) Subject: Re: bug#31903: 27.0.50; Server sockets with :nowait no longer work References: <87bmbrlzxe.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31903 Cc: larsi@gnus.org, eller.helmut@gmail.com, 31903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Sun, 01 Jul 2018 11:48:45 -0400 > Cc: Lars Ingebrigtsen , 31903@debbugs.gnu.org > > Helmut Eller writes: > > > I'm not sure whether :nowait is supposed to work with server sockets, > > but this used to work in Emacs 25. Either way, the error message looks > > pretty wrong. > > As far as I can tell, Emacs 25 just ignores :nowait when :server is > passed. We could change Emacs 26 do that as well, or we just make the > error official but give a more a sensible error message when passed both > :nowait and :server. Unless someone protests within the next few days, I think I prefer the latter alternative. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 05 20:13:35 2018 Received: (at 31903) by debbugs.gnu.org; 6 Jul 2018 00:13:35 +0000 Received: from localhost ([127.0.0.1]:48080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbENP-00062o-Ie for submit@debbugs.gnu.org; Thu, 05 Jul 2018 20:13:35 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:38530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbENH-00062N-6T; Thu, 05 Jul 2018 20:13:26 -0400 Received: by mail-it0-f46.google.com with SMTP id v71-v6so4290417itb.3; Thu, 05 Jul 2018 17:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7ktsbEN4LPlSrxa74MgPYcFDCKHvCCakZACvxovZQtY=; b=Cu20/o1vjgpbUKZjBOZyilZBuXVSkEqXQpLxcNicLBGmIvnfGQk7cmhlp9fsVqLS+T I/UCzab20DAefxpFIwqjsEuhK/QfLJ1qKyvtIElvLY8QlRh77B4iiX/d1/RbXX4h4qTR uiMIIHmG1IwUrq+auje+99V4UZtjZAtNWPV/ScY+gQiMz/DBfhGpWKWT+vlpbdB6miIW HmKW7XYk+JjB7UTctWFEguFuyynRHkusB846ocNsBSZtf9DsjlniuYtVUvY2EdeuwaXi 0ZRR9/vaLxya5FSrwdj0y8ciPzOqotdlt7yvbUVg21XJUIKB5dCfg5PRNJE4+xbLVcYF iC7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7ktsbEN4LPlSrxa74MgPYcFDCKHvCCakZACvxovZQtY=; b=WwqNy/vC9iEXYTB56Wk10ks+Rz0MfihEs7/NCA4JLiS0OCVjkqo2q9JA0DZOo5J9nQ VutbQ5qhETSki9kGkKRaj+FCEqzXeE15ZEzRQBVS62GFk+PA3AVWi65+kxeO37qcbmJk jyWIL4UE7nYMBzfopy82N5OLTc2RNKLiigrfXdhrzW/g0TVkhu9A7+7yDGdvnlY6MfX6 YMaogbdTxDNqviGgChIyzot1kfTqX17l/jsy075n7OqKfdQ90phbfFnV7oV9dVR1UXTZ dHH78LgeA4jS5Uw/aYZ3kXRXG/kQBcfCZVzpTxUjBWtT3iYa63nuHJel12HhqyZZLdmQ lvBQ== X-Gm-Message-State: APt69E2HjkhA6i4Y3mCwPPCrG/rjiHfInrdDQ9j7V8dq62y+qolK8F+r Usvod5oXFLrTo5b4aDmwAYdKJw== X-Google-Smtp-Source: AAOMgpdg8cX4l+6vHFfenMTZmDlw0wb5IvjVIKm7PZepWafYTDhI1LmMy5Nh69yiuc7f74Uij7yNyQ== X-Received: by 2002:a24:5ccb:: with SMTP id q194-v6mr6069090itb.133.1530835997536; Thu, 05 Jul 2018 17:13:17 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q187-v6sm3282589iof.67.2018.07.05.17.13.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jul 2018 17:13:16 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31903: 27.0.50; Server sockets with :nowait no longer work References: <87bmbrlzxe.fsf@gmail.com> <83va9xk6ch.fsf@gnu.org> Date: Thu, 05 Jul 2018 20:13:14 -0400 In-Reply-To: <83va9xk6ch.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Jul 2018 18:25:18 +0300") Message-ID: <87efghdxwl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31903 Cc: larsi@gnus.org, eller.helmut@gmail.com, 31903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 31903 + patch quit Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Sun, 01 Jul 2018 11:48:45 -0400 >> Cc: Lars Ingebrigtsen , 31903@debbugs.gnu.org >> >> Helmut Eller writes: >> >> > I'm not sure whether :nowait is supposed to work with server sockets, >> > but this used to work in Emacs 25. Either way, the error message looks >> > pretty wrong. >> >> As far as I can tell, Emacs 25 just ignores :nowait when :server is >> passed. We could change Emacs 26 do that as well, or we just make the >> error official but give a more a sensible error message when passed both >> :nowait and :server. > > Unless someone protests within the next few days, I think I prefer the > latter alternative. Okay, here is the patch for that, I will push to emacs-26 in a few days. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Explicitly-reject-server-and-nowait-Bug-31903.patch Content-Description: patch >From a2ec0e58ab979b0a64a097ff0880cb7509d8aced Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 5 Jul 2018 19:37:28 -0400 Subject: [PATCH v1] Explicitly reject :server and :nowait (Bug#31903) * src/process.c (Fmake_network_process): Explicitly check for and signal an error when passed both :server and :nowait non-nil. In Emacs 25, :nowait would be ignored in this case, but as of Emacs 26.1 this gives an error, albeit an unclear one. Also remove obsolete comment regarding configurations lacking non-blocking mode, the corresponding code was removed in 2012-11-17 "Assume POSIX 1003.1-1988 or later for fcntl.h." --- src/process.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/process.c b/src/process.c index 7f6ea1261e..4d7a735652 100644 --- a/src/process.c +++ b/src/process.c @@ -3890,12 +3890,15 @@ failed) connections may be logged in the server process's buffer. filter = Fplist_get (contact, QCfilter); sentinel = Fplist_get (contact, QCsentinel); use_external_socket_p = Fplist_get (contact, QCuse_external_socket); + Lisp_Object server = Fplist_get (contact, QCserver); + bool nowait = !NILP (Fplist_get (contact, QCnowait)); + if (!NILP (server) && nowait) + error ("`:server' is incompatible with `:nowait'"); CHECK_STRING (name); /* :local ADDRESS or :remote ADDRESS */ - tem = Fplist_get (contact, QCserver); - if (NILP (tem)) + if (!NILP (server)) address = Fplist_get (contact, QCremote); else address = Fplist_get (contact, QClocal); @@ -4009,7 +4012,7 @@ failed) connections may be logged in the server process's buffer. } #ifdef HAVE_GETADDRINFO_A - if (!NILP (host) && !NILP (Fplist_get (contact, QCnowait))) + if (!NILP (host) && nowait) { ptrdiff_t hostlen = SBYTES (host); struct req @@ -4154,20 +4157,13 @@ failed) connections may be logged in the server process's buffer. set_network_socket_coding_system (proc, host, service, name); - /* :server BOOL */ - tem = Fplist_get (contact, QCserver); - if (!NILP (tem)) - { - /* Don't support network sockets when non-blocking mode is - not available, since a blocked Emacs is not useful. */ - p->is_server = true; - if (TYPE_RANGED_INTEGERP (int, tem)) - p->backlog = XINT (tem); - } + /* :server QLEN */ + p->is_server = !NILP (server); + if (TYPE_RANGED_INTEGERP (int, server)) + p->backlog = XINT (server); /* :nowait BOOL */ - if (!p->is_server && socktype != SOCK_DGRAM - && !NILP (Fplist_get (contact, QCnowait))) + if (!p->is_server && socktype != SOCK_DGRAM && nowait) p->is_non_blocking_client = true; bool postpone_connection = false; -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 09 20:46:12 2018 Received: (at 31903) by debbugs.gnu.org; 10 Jul 2018 00:46:12 +0000 Received: from localhost ([127.0.0.1]:52874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcgnD-0002su-TM for submit@debbugs.gnu.org; Mon, 09 Jul 2018 20:46:12 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:55044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcgnC-0002sc-CY; Mon, 09 Jul 2018 20:46:10 -0400 Received: by mail-it0-f50.google.com with SMTP id s7-v6so28028056itb.4; Mon, 09 Jul 2018 17:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0JIRpcrKHTTH2xWWaFprxpEZ07+LQjm8V0qd3NE0sd8=; b=RCGCXFt9EEE+N8daSxZSG3f7ll5wXsuV5VRL8yDpd8WC/vIJBcx4o9aseYTJJnvYLw +WW4BzmKARsvJ2/wqqvwMW7kvEAH7RzqELAGUQn4j3itlOlyjQA+oXPAxgktabuxJzLa cSNAe+z0V5EhVEzK5UUsZXhqRoS6qtSwgJSJQpPLx+qz31Dp6VnIue8y/unHtgvTUYMs sG2O2ZO/BtXZATRyjFIVlRPsvnw5s+n/BM6NqLw6NUsrVva+Z08dVCa4IOz2m0UeRmou NTezCVpHkB5CqmMREmdbHsq1mwSoOGbUo6s5MSdnsI9ObWjmc8YLFXq0vByiW4bZ3BzE JPKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0JIRpcrKHTTH2xWWaFprxpEZ07+LQjm8V0qd3NE0sd8=; b=S11P70/y7XPXeyjyIobwVx76VFhjDkUqt0Skm9h7/ZRrAGQdOuzsVcMdF1n8WrVxVm FhcHdIUixOiuNihqRsv4R/2vRdJ0I9gloKuowFFancKGg2md8yvrvnOlnt2zhDPAvzUh PMrKGK8FqwxpLGzqWS+z2RBOSs2x36FPV/d4/cwEDT6r7vXTohFyoJHXTV+AyEYXsljg ZhzhmfrX20ZosbQh6EsfCzrd8WLS/T4+eh4hQWHju4yb7tzl7Vcj8TkSDGxn5G216MRT 9jw+AHuT2pNlspKWf4s9H/VPNz3IpgrVd/uMzJd8iKPzuFHKl7qQCt4Ojwe0qgYOkvyw oEVQ== X-Gm-Message-State: APt69E3y0mhrDmGPskvmHl8xVjkRFmcoM4DiZdwzZ/JvIuRZCce8j/Mp UkaP6wTO2GqVT50nVg+GHOBxOA== X-Google-Smtp-Source: AAOMgpdmBTxnH+4H2Uqt2D3ENlKGNZy50yKFFpe733wYUbZyqqPT0k9V9eAB0VUJH3EVZ3GFUHtWvg== X-Received: by 2002:a24:130c:: with SMTP id 12-v6mr18573872itz.35.1531183564374; Mon, 09 Jul 2018 17:46:04 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id j11-v6sm8714013itb.16.2018.07.09.17.46.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 17:46:03 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31903: 27.0.50; Server sockets with :nowait no longer work References: <87bmbrlzxe.fsf@gmail.com> <83va9xk6ch.fsf@gnu.org> <87efghdxwl.fsf@gmail.com> Date: Mon, 09 Jul 2018 20:46:02 -0400 In-Reply-To: <87efghdxwl.fsf@gmail.com> (Noam Postavsky's message of "Thu, 05 Jul 2018 20:13:14 -0400") Message-ID: <87k1q3dik5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31903 Cc: larsi@gnus.org, eller.helmut@gmail.com, 31903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31903 fixed close 31903 26.2 quit Noam Postavsky writes: > Okay, here is the patch for that, I will push to emacs-26 in a few days. Done. [1: 90d95b000c]: 2018-07-09 19:39:03 -0400 Explicitly reject :server and :nowait (Bug#31903) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90d95b000c37f7e85096716db96c4a940436f387 From unknown Thu Jun 19 13:56:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Aug 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator