From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 09:39:12 2018 Received: (at submit) by debbugs.gnu.org; 19 Jun 2018 13:39:12 +0000 Received: from localhost ([127.0.0.1]:56037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVGql-0000Q8-Nn for submit@debbugs.gnu.org; Tue, 19 Jun 2018 09:39:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV9R4-0004Rd-PJ for submit@debbugs.gnu.org; Tue, 19 Jun 2018 01:44:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV9Qy-00084m-Cw for submit@debbugs.gnu.org; Tue, 19 Jun 2018 01:44:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fV9Qy-00084f-9m for submit@debbugs.gnu.org; Tue, 19 Jun 2018 01:44:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV9Qw-00034J-VE for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 01:44:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV9Qv-00084A-Qf for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 01:44:03 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV9Qv-000844-Mg for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 01:44:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52728) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fV9Qu-0003Sn-Uc for bug-emacs@gnu.org; Tue, 19 Jun 2018 01:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV9Qp-00082X-Ri for bug-emacs@gnu.org; Tue, 19 Jun 2018 01:44:00 -0400 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]:36844) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV9Qp-000828-JK for bug-emacs@gnu.org; Tue, 19 Jun 2018 01:43:55 -0400 Received: by mail-lf0-x231.google.com with SMTP id n24-v6so12431902lfh.3 for ; Mon, 18 Jun 2018 22:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=6N94k3Aus1O4ERLv9Hbk9yj48I2z32GQvPht/9i2Wes=; b=fkOrMAWlCJ3rBNT7pwPZ8MGd3kq5GwoYQijsmdFOKO3WDcC8dNiZbkAkdPiI/DX5VC CkESXLw9aH05l4tix2FRWeFz5LKNb8pD3KbruBE5JsBlZs2JKpLHOzAaOKpzWjeSsG7Z tRRXZkoGQlkcroGfZZWsxJ8NP6r7EI7Y3bZewPX+c+MsEONZyUW1zJaunhyj86toEfnA F2ueFKtIutB0WFU/yuvHCwy4PLEx5EOoH3gnf9aLJvyh3wn66W7wlhDWbm89wMPOiiLl 8v5xeRo5ANGmVgGB3JNPOS3mRs4sGMLCZCOJisJvFsgnTo1CMPMzAZSBkMdW+wssC2i8 NBJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=6N94k3Aus1O4ERLv9Hbk9yj48I2z32GQvPht/9i2Wes=; b=oYlogm/jEiMsyE8kbU09hhGeaTMsm7YAKXtuWbXZNYyZQIAhHpebZlFH85aSauA6bp 92/X+s8+pYgXEndkQf4L0yaNEKFXgmicVseEq4XnbArqVCCA2cFPBDCz2TlFsIzqxvPa nAt21mzI4bcOHE/k5TkH3v/f2bnGhFfDEQgyaS1KxNIyckCc7bL9Kk9WJaxZy0qeOxeW N3Xzd727TTYgknElBPAZh1+mttkKyJoSehtewMa5W6f4M+CaNqie/sBW72fFrw18DJuX s9S1qyFq9hMFxjKrE96RYaVK/8eHC2KKA6v0NblZxW6kyuW/I6p5mZA1523VjyO1gfvN h2Dg== X-Gm-Message-State: APt69E28hfwtmJq5u+jlEwhiOuUox9CsYYAbivFijvNvpZJtxJ0q75fl lhUIMPrMocJ9fo5oYCuv+NTskuQm X-Google-Smtp-Source: ADUXVKI0SM/ESR0F6a0nBAIUuGN+gQUKc/HeTDSK6vS8LQ5M0844lRIDDzJ/cEeODCEgU8a48namVg== X-Received: by 2002:a2e:8184:: with SMTP id e4-v6mr10246266ljg.93.1529387033845; Mon, 18 Jun 2018 22:43:53 -0700 (PDT) Received: from malediction ([46.48.96.28]) by smtp.gmail.com with ESMTPSA id j78-v6sm3011473ljb.10.2018.06.18.22.43.52 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 22:43:53 -0700 (PDT) Date: Tue, 19 Jun 2018 10:43:51 +0500 From: Mike Kazantsev To: bug-emacs@gnu.org Subject: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Message-ID: <20180619104351.41e4e3d1@malediction> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 19 Jun 2018 09:39:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Description: Running (make-network-process ... :family 'local :nowait t) with non-exising socket hangs forever in "open" state without ever calling sentinel function. 100% reproducible on emacs-26.1 in current Archlinux OS. ==== How to reproduce: Run following s-expressions from lisp-interaction-mode buffer in the same sequence: (defun unix-socket-test-func (proc ev) (message "unix-socket-test: %s %s" proc ev)) (defvar socket) (setq socket (make-network-process :name "unix-socket-test" :family 'local :service "/tmp/does-not-exist.sock" :nowait t :coding '(utf-8 . utf-8) :buffer (get-buffer-create "some-ipc-buffer") :noquery t :filter #'unix-socket-test-func :sentinel #'unix-socket-test-func)) (process-live-p socket) (process-status socket) (delete-process socket) Note - assuming that /tmp/does-not-exist.sock does not exist on the filesystem. ==== Expected result: One or more of: - Message "unix-socket-test: failed" or some similar failure is reported by the sentinel function. - Maybe "open" then "failed" states reported, in case socket() call is treated as 'open before connect() is issued. - "socket" variable is set to nil, as it was with ":nowait t" before emacs-26, due to such simple and instant error. - (process-live-p socket) reports nil when run few seconds after make-network-process call. - (process-status socket) reports some kind of failed state, not 'open. None of this happens. ==== Actual result: - socket process is created and stuck forever in 'open state. - strace on emacs process (monitoring syscalls) show this syscall sequence happening immediately when make-network-process call is made: [pid 31590] socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 21 [pid 31590] connect(21, {sa_family=AF_UNIX, sun_path="/tmp/does-not-exist.sock"}, 110) = -1 ENOENT (No such file or directory) [pid 31590] close(21) = 0 - Function passed as :sentinel to make-network-process is never called with any state - neither 'open nor 'failed. - (process-live-p socket) returns non-nil result for process associated with socket that is actually closed, and was closed immediately on connect, without any indication of that in elisp code. - (process-status socket) returns 'open, even though it never sent 'open status to sentinel function, nor is socket actually open at that point. It never succeeded at connecting to anything, in fact. Same thing happens with socket that nothing is listening on, except strace there gives different error on connect(): [pid 31590] socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 21 [pid 31590] connect(21, {sa_family=AF_UNIX, sun_path="/tmp/does-not-exist.sock"}, 110) = -1 ECONNREFUSED (Connection refused) [pid 31590] close(21) This makes using unix sockets with emacs correctly and efficiently very hard, if not impossible, as it there's no way to tell if it is stuck connecting or failed except setting some kind of timeout on sentinel response. As far as I can tell, this is not documented behavior, definitely unexpected, breaks all old code that used unix sockets, and probably unintentional, i.e. a bug. Apart from mentioned Archlinux setup, symptoms of the same issue were also reported on EMMS (emacs multimedia system) mailing list with emacs-26 recently on Ubuntu 18.10 pre-release version. Have tried to find exising reports for such - rather basic, it seems - problem, but haven't found any, so not entirely sure if maybe I'm doing something wrong here. Thanks for reading this far and any assistance. -- Mike Kazantsev // fraggod.net From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 01 11:21:16 2018 Received: (at 31901) by debbugs.gnu.org; 1 Jul 2018 15:21:16 +0000 Received: from localhost ([127.0.0.1]:42249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZeA8-0002as-6G for submit@debbugs.gnu.org; Sun, 01 Jul 2018 11:21:16 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:51202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZeA6-0002aa-Ad; Sun, 01 Jul 2018 11:21:14 -0400 Received: by mail-it0-f42.google.com with SMTP id o5-v6so7942045itc.1; Sun, 01 Jul 2018 08:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hOwTVGXKwBiOzgq+xqvNxK7CDD/IYp8xGWTcMuA7nZk=; b=I0MHJF/yzi6+jazsixrnTtzoyBkwLjbwVYZDNDoBaGQHYfABtzrBzDd/JkZ6KhmeE9 nJ/d238RpgTEN3/r6b0D3b9K8gyygKhJEMAjjJxGQTtA6HStTDAqusfor+0kkZTWcSyV LoVvXCdX5cIzlMLOomeuZ8FO1ZxgRiaan36e9XvVYMwFy44lffx7Jc0rgcLalYIJhw6o nOP01MycYxn7OQ/sujtZ/S+SoFNF2/gxxBoB+Kf/qMIWgWGH/1m9XlcTj/syWXKdx5qa vts/dTlJIP3XzWx4JuYInI+TtPcsP96vtsufj6ebNt+ZjKYpqRZQK4i8n+hGfXKhDOGW Hflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hOwTVGXKwBiOzgq+xqvNxK7CDD/IYp8xGWTcMuA7nZk=; b=LirDhctKvo5QKG7b2K242x848Km7xEI4zUQamSEJJYR0xCk7kCyDpqUiHPDDD5FHEN bhSDvJ4LJPo7EfU+BjRaZIsXGKyUdj/96Pfbp0DHY4lyo8I+hL4HSo2kmoiAL0FOKQTI z48VFBHuyF2sB6HLT/ZM3OQ+VXpx0NZJni0OtItx4+VDqYzmRV6iuadv2Cs503goFCEM d3e+rH+ev4jnGYX/KukRFqfqvGPXX8NBkop1iNupujivkkyHyuDkCg1/D/lfT33d3xFI TdoR81JTlZY3yzY2JgMjXwYqythu7IHtAQW2vimgY8JOmkGtO/IcUJA70ldYB8WcarZ9 HDRg== X-Gm-Message-State: APt69E3Jd+1qrXIBKXaw5PnjfiB8DB+53M1IEfuLM22MserxBW9tXp2h JIq1Mz58DzgCvK61/dr7bpcsNA== X-Google-Smtp-Source: AAOMgpc7vKgmPJG2pb9iS2f0kCfs0mFtFG/x0b5NMAf9LdTY1WHQnlSKdub3r+wrRGANzohgpdGKAw== X-Received: by 2002:a24:eb0e:: with SMTP id h14-v6mr3895937itj.69.1530458468639; Sun, 01 Jul 2018 08:21:08 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i15-v6sm6330637ioh.80.2018.07.01.08.21.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Jul 2018 08:21:07 -0700 (PDT) From: Noam Postavsky To: Mike Kazantsev Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> Date: Sun, 01 Jul 2018 11:21:06 -0400 In-Reply-To: <20180619104351.41e4e3d1@malediction> (Mike Kazantsev's message of "Tue, 19 Jun 2018 10:43:51 +0500") Message-ID: <87efgnm17h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: Lars Ingebrigtsen , 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31901 + confirmed quit Mike Kazantsev writes: > As far as I can tell, this is not documented behavior, definitely > unexpected, breaks all old code that used unix sockets, and probably > unintentional, i.e. a bug. It seems to be due to this is_non_blocking_client check in connect_network_socket: if (s < 0) { /* If non-blocking got this far - and failed - assume non-blocking is not supported after all. This is probably a wrong assumption, but the normal blocking calls to open-network-stream handles this error better. */ if (p->is_non_blocking_client) return; report_file_errno ((p->is_server ? "make server process failed" : "make client process failed"), contact, xerrno); } In Emacs 25, this check was directly in Fmake_network_process before the process object creation code, so we would just return nil in that case. Seems to have changed, I assume accidentally, in [1: e09c0972c3]. [1: e09c0972c3]: 2016-01-28 23:50:47 +0100 Refactor make_network_process https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e09c0972c350e9411683b509414fc598cbf387d3 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 04:59:49 2018 Received: (at 31901) by debbugs.gnu.org; 6 Jul 2018 08:59:49 +0000 Received: from localhost ([127.0.0.1]:48212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMai-0007eD-Q6 for submit@debbugs.gnu.org; Fri, 06 Jul 2018 04:59:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMae-0007du-Tc for 31901@debbugs.gnu.org; Fri, 06 Jul 2018 04:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbMaU-0007Ug-Md for 31901@debbugs.gnu.org; Fri, 06 Jul 2018 04:59:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbMaU-0007UQ-JM; Fri, 06 Jul 2018 04:59:34 -0400 Received: from [176.228.60.248] (port=2551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbMaT-00022g-VQ; Fri, 06 Jul 2018 04:59:34 -0400 Date: Fri, 06 Jul 2018 11:59:35 +0300 Message-Id: <831scgn3ig.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky , larsi@gnus.org In-reply-to: <87efgnm17h.fsf@gmail.com> (message from Noam Postavsky on Sun, 01 Jul 2018 11:21:06 -0400) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ping! Lars, could you please look into this? > From: Noam Postavsky > Date: Sun, 01 Jul 2018 11:21:06 -0400 > Cc: Lars Ingebrigtsen , 31901@debbugs.gnu.org > > tags 31901 + confirmed > quit > > Mike Kazantsev writes: > > > As far as I can tell, this is not documented behavior, definitely > > unexpected, breaks all old code that used unix sockets, and probably > > unintentional, i.e. a bug. > > It seems to be due to this is_non_blocking_client check in > connect_network_socket: > > if (s < 0) > { > /* If non-blocking got this far - and failed - assume non-blocking is > not supported after all. This is probably a wrong assumption, but > the normal blocking calls to open-network-stream handles this error > better. */ > if (p->is_non_blocking_client) > return; > > report_file_errno ((p->is_server > ? "make server process failed" > : "make client process failed"), > contact, xerrno); > } > > In Emacs 25, this check was directly in Fmake_network_process before the > process object creation code, so we would just return nil in that case. > Seems to have changed, I assume accidentally, in [1: e09c0972c3]. > > [1: e09c0972c3]: 2016-01-28 23:50:47 +0100 > Refactor make_network_process > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e09c0972c350e9411683b509414fc598cbf387d3 > > > > From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 14 04:21:12 2018 Received: (at 31901) by debbugs.gnu.org; 14 Jul 2018 08:21:12 +0000 Received: from localhost ([127.0.0.1]:59489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1feFng-00064j-Ly for submit@debbugs.gnu.org; Sat, 14 Jul 2018 04:21:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1feFnc-00063r-07 for 31901@debbugs.gnu.org; Sat, 14 Jul 2018 04:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1feFnR-0005JC-VI for 31901@debbugs.gnu.org; Sat, 14 Jul 2018 04:20:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feFnR-0005J8-Qa; Sat, 14 Jul 2018 04:20:53 -0400 Received: from [176.228.60.248] (port=3025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1feFnR-0001oX-9F; Sat, 14 Jul 2018 04:20:53 -0400 Date: Sat, 14 Jul 2018 11:20:57 +0300 Message-Id: <83in5ib53q.fsf@gnu.org> From: Eli Zaretskii To: larsi@gnus.org In-reply-to: <831scgn3ig.fsf@gnu.org> (message from Eli Zaretskii on Fri, 06 Jul 2018 11:59:35 +0300) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ping! Ping! > Date: Fri, 06 Jul 2018 11:59:35 +0300 > From: Eli Zaretskii > Cc: mk.fraggod@gmail.com, 31901@debbugs.gnu.org > > Ping! > > Lars, could you please look into this? > > > From: Noam Postavsky > > Date: Sun, 01 Jul 2018 11:21:06 -0400 > > Cc: Lars Ingebrigtsen , 31901@debbugs.gnu.org > > > > tags 31901 + confirmed > > quit > > > > Mike Kazantsev writes: > > > > > As far as I can tell, this is not documented behavior, definitely > > > unexpected, breaks all old code that used unix sockets, and probably > > > unintentional, i.e. a bug. > > > > It seems to be due to this is_non_blocking_client check in > > connect_network_socket: > > > > if (s < 0) > > { > > /* If non-blocking got this far - and failed - assume non-blocking is > > not supported after all. This is probably a wrong assumption, but > > the normal blocking calls to open-network-stream handles this error > > better. */ > > if (p->is_non_blocking_client) > > return; > > > > report_file_errno ((p->is_server > > ? "make server process failed" > > : "make client process failed"), > > contact, xerrno); > > } > > > > In Emacs 25, this check was directly in Fmake_network_process before the > > process object creation code, so we would just return nil in that case. > > Seems to have changed, I assume accidentally, in [1: e09c0972c3]. > > > > [1: e09c0972c3]: 2016-01-28 23:50:47 +0100 > > Refactor make_network_process > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e09c0972c350e9411683b509414fc598cbf387d3 > > > > > > > > > > > > From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 20 05:16:37 2018 Received: (at 31901) by debbugs.gnu.org; 20 Jul 2018 09:16:38 +0000 Received: from localhost ([127.0.0.1]:48808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgRWf-0007Mt-IR for submit@debbugs.gnu.org; Fri, 20 Jul 2018 05:16:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgRWd-0007HE-Sf for 31901@debbugs.gnu.org; Fri, 20 Jul 2018 05:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgRWX-0004s9-Td for 31901@debbugs.gnu.org; Fri, 20 Jul 2018 05:16:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgRWX-0004s1-PD; Fri, 20 Jul 2018 05:16:29 -0400 Received: from [176.228.60.248] (port=3414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgRWX-0006Tq-5F; Fri, 20 Jul 2018 05:16:29 -0400 Date: Fri, 20 Jul 2018 12:16:29 +0300 Message-Id: <83muum1d3m.fsf@gnu.org> From: Eli Zaretskii To: npostavs@gmail.com, In-reply-to: <83in5ib53q.fsf@gnu.org> (message from Eli Zaretskii on Sat, 14 Jul 2018 11:20:57 +0300) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: larsi@gnus.org, mk.fraggod@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sat, 14 Jul 2018 11:20:57 +0300 > From: Eli Zaretskii > Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org > > Ping! Ping! Still no response. Noam, would you like to propose a fix for this? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 20 06:08:45 2018 Received: (at 31901) by debbugs.gnu.org; 20 Jul 2018 10:08:45 +0000 Received: from localhost ([127.0.0.1]:48834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgSL7-00030d-G3 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 06:08:45 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:51168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgSL4-00030R-5V for 31901@debbugs.gnu.org; Fri, 20 Jul 2018 06:08:44 -0400 Received: from cm-84.212.221.165.getinternet.no ([84.212.221.165] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fgSKw-0004N7-2U; Fri, 20 Jul 2018 12:08:40 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEUNBQQRCAcaDAs5FxV+ TUSohQhOAAACRklEQVQ4jVVUgZHbMAyjnAUk5geIyAzwFjVAa2n/mQrQzV/r+/g+hAiQIBUp1s3C rOFRvlotVVqTZr0BGR2hrsRra6WZVMVXj9GqlDuhaW+aQDP3LiJFeFZBq01FtHePMJGE6mHWtdcm EAFTxDeiBQk4k0XgmMaYey0zFFNshuE8qeSI84mU4eNlzcNQYGqATKniY3RTH6lxAx49JlIsWzLv JCXVXMP3nuEolB0ijkpEHmuFQx5sxsOItgTescMSAFsvdjcBeM9lIwgMNm2suxQyzStibiaMG+jZ IJlmLDIhBSVbdigyAVzyxXgY/tgHOkyJ+bs8ghr+/RwW/Wi9yWPPPX+VB0VsSLmcAKigveclAGac ZyskPPoNrAlxlLtPZIDR9EUg5mJNSIjT2xOlj/aqBDbYMRG+FbZwUpXAQogm7ulxqlGjlVoJgAs1 TceuFIPF/VAAz02uCSUsy2iaQJWafYDe9yhYEM4JnVd4+EwA4qOUBCxeyml8QZY97PUiMBLDJskb 7SWwsarmH6AKSqI6gYw60+jVXIxmVarJhA+nfksgbd3K2C//CyDmOT3TXGNOEACcxTNjxN0FhnKP FiWRbYNt2EUEALZeYHkieIPcT00TkYFy9ufBfxcvSK6P738ezLH4DwAS2LVRJmSukvsGFx2e52kf qM2vvLm4IMIRbWzKgmkR7865ytFV0ifm0OAZ/f4RgCt39PNcI2/m/wD5AhcN8f4DoMtJDU6cCZrA SoMnbwIuZssrYnLT0MiF/Tk7NNLNP91brLIkzdkrAAAAAElFTkSuQmCC Date: Fri, 20 Jul 2018 12:08:33 +0200 In-Reply-To: <83muum1d3m.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jul 2018 12:16:29 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Still no response. Sorry for the delays; I should have time on Sunday to go through the emacs mail (and also the netsec branch, hopefully). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 20 08:18:15 2018 Received: (at 31901) by debbugs.gnu.org; 20 Jul 2018 12:18:15 +0000 Received: from localhost ([127.0.0.1]:48918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgUMO-0008Tk-34 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 08:18:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgUMJ-0008TR-Qx for 31901@debbugs.gnu.org; Fri, 20 Jul 2018 08:18:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgUMA-0002as-E6 for 31901@debbugs.gnu.org; Fri, 20 Jul 2018 08:18:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgUMA-0002ab-9W; Fri, 20 Jul 2018 08:17:58 -0400 Received: from [176.228.60.248] (port=2575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgUM9-00069D-MM; Fri, 20 Jul 2018 08:17:58 -0400 Date: Fri, 20 Jul 2018 15:17:57 +0300 Message-Id: <83effy14p6.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: (message from Lars Ingebrigtsen on Fri, 20 Jul 2018 12:08:33 +0200) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: npostavs@gmail.com, mk.fraggod@gmail.com, 31901@debbugs.gnu.org > Date: Fri, 20 Jul 2018 12:08:33 +0200 > > Eli Zaretskii writes: > > > Still no response. > > Sorry for the delays; I should have time on Sunday to go through the > emacs mail (and also the netsec branch, hopefully). Great, thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 07:40:57 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 11:40:57 +0000 Received: from localhost ([127.0.0.1]:51608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhCjR-0004tf-2F for submit@debbugs.gnu.org; Sun, 22 Jul 2018 07:40:57 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:57829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhCjP-0004tW-FD for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 07:40:55 -0400 Received: from cm-84.212.221.165.getinternet.no ([84.212.221.165] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fhCjL-00065s-Uq; Sun, 22 Jul 2018 13:40:54 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> Date: Sun, 22 Jul 2018 13:40:51 +0200 In-Reply-To: <83effy14p6.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jul 2018 15:17:57 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) OK, I've now fixed the async error case (on master), I think: (process-live-p socket) nil (process-status socket) file-missing I've fixed this on master, because I'm not 100% sure that my fix is completely correct. Should we perhaps also call a sentinel in the async error case? But we should, in any case, perhaps cherry-pick this fix into Emacs 26.2. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 10:11:51 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 14:11:51 +0000 Received: from localhost ([127.0.0.1]:52477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhF5S-0000Nb-Pg for submit@debbugs.gnu.org; Sun, 22 Jul 2018 10:11:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhF5R-0000NM-5b for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:11:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhF5H-0001ML-0c for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:11:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhF5G-0001MH-Ta; Sun, 22 Jul 2018 10:11:38 -0400 Received: from [176.228.60.248] (port=4354 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhF5G-0001yD-A9; Sun, 22 Jul 2018 10:11:38 -0400 Date: Sun, 22 Jul 2018 17:11:43 +0300 Message-Id: <83zhyjweao.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: (message from Lars Ingebrigtsen on Sun, 22 Jul 2018 13:40:51 +0200) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org > Date: Sun, 22 Jul 2018 13:40:51 +0200 > > OK, I've now fixed the async error case (on master), I think: > > (process-live-p socket) > nil > (process-status socket) > file-missing Thanks! > I've fixed this on master, because I'm not 100% sure that my fix is > completely correct. Should we perhaps also call a sentinel in the async > error case? But we didn't call the sentinel before, did we? > But we should, in any case, perhaps cherry-pick this fix into Emacs > 26.2. It looks like the only visible change in behavior is that we now store the error in the process object, is that right? If so, I think we want this on emacs-26, yes. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 10:32:02 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 14:32:02 +0000 Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFP0-0000rz-0T for submit@debbugs.gnu.org; Sun, 22 Jul 2018 10:32:02 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:58673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFOw-0000ri-Dh for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:32:00 -0400 Received: from cm-84.212.221.165.getinternet.no ([84.212.221.165] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fhFOt-0006Cl-8O; Sun, 22 Jul 2018 16:31:57 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <83zhyjweao.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEVz/2J12VZ0/2Fz/2Nw /2Bz915QiTJv/2NbtkImMhVooORwAAACG0lEQVQ4jXWTMW/bMBCFBbTofqrpqCNpuEi3VKxjeKsQ ukRGuVbdVYshbVUll101hKD/gBH/2xwp0VKQ5IEQTH/37pEHKVBKCCGVkxRWjVK4ggoakQD+e5hI C6SQWHalghQaksB6q6orUU0gJWupqvVHCypIYApQbUWS/4IpAdzlyyBJAEGe7KawlZBMYELyKexU cGiabbKDRFXv8QzYTQB8PWA4xtpADLdnUU0juhM64De9pAeyiozB5XVxND/2TudOpwuQDuijB6IH jbDAaF32xE3IO0xhdNED6QCeyLUqdHHyoGuFt0Cg0bAvnwGUbWX0fv/Jh9+p2l0QQWGwXe+wtbV3 OL0A/94CnUOX++Hm3N2jd5SDY8lHIxkDXo+H+Bw03QVHhrOqlzUPpJLyXrtehe7OVaNchrq3o3r4 n0XEjZ5bIeB3K6x/WENUkPVxAPhAR1614rc5GFN6UC+X724f84z8uYkMX5BF2YOm5vzDY2t+8joz nC8iD77hY3UybZYC6BYi48EN5/HqjGM32riX6NiDv/i4PdvXqQfe8d228o52BLhzOKB7MLuAL75V CwNgMz77fC7MqFXvmMXsGkud8GuCqO0yWMy8ZnHc7WJmwSBscfnJAkYZJZuQpBsKQEMGtENBiqPA lUNImQUhnTNGIQxojoWYSS8OwBoLCMznMAQBpWnISDgO93IpwZxt3gAZghcMQbZ5nTwB3/mBpZ4W IzEAAAAASUVORK5CYII= Date: Sun, 22 Jul 2018 16:31:55 +0200 In-Reply-To: <83zhyjweao.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Jul 2018 17:11:43 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I've fixed this on master, because I'm not 100% sure that my fix is >> completely correct. Should we perhaps also call a sentinel in the async >> error case? > > But we didn't call the sentinel before, did we? I don't think we did, but I'm not completely sure. I tried following the pre-Emacs 26 code flow, and I didn't see a call, but I may be mistaken. >> But we should, in any case, perhaps cherry-pick this fix into Emacs >> 26.2. > > It looks like the only visible change in behavior is that we now store > the error in the process object, is that right? Yup. That is, it should be unless I messed something up in the refactoring of report_file_errno. :-) > If so, I think we want this on emacs-26, yes. Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 10:55:16 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 14:55:16 +0000 Received: from localhost ([127.0.0.1]:52533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFlQ-0001SS-0M for submit@debbugs.gnu.org; Sun, 22 Jul 2018 10:55:15 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:41695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhFlL-0001Ru-Tv for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:55:11 -0400 Received: by mail-lj1-f172.google.com with SMTP id y17-v6so14774480ljy.8 for <31901@debbugs.gnu.org>; Sun, 22 Jul 2018 07:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7c7PGMDx6irUW2yfeUBozIXrMX9LAWDj6xFdoL53ixg=; b=ufZxo5o8V/hZeTkYfDIgCgjhF5rm3tPux/fYbrk/cIHS53bKkKBJuK22i2nKDIDutJ mk3885uoVanIPEKEeLS53y6YwVYuqksqcuXqsS/z+cTvQ4pa4t1CLq1vFK3sEMS3N7ju OStDKJ4SMw19XDfT5XT0zmxQt4oCqcYUw2lR7odgDbe9O//TL+R42RmVDmhwHbpdCSss ORoKYPzS03IufwlgRzYMThsXKk8w64P5KMZaVXr2cMyCMRIu/pRiWXMMADzMwpENCmx3 AkJl4ej8x/RZaZO761ZgbCLPNTB2LnVOhKRQhpDvXOYtNea/bfr4lzIBb0s3gctAb6bh xrvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7c7PGMDx6irUW2yfeUBozIXrMX9LAWDj6xFdoL53ixg=; b=AdD8QfVX22zJ+PcPTsbzFQl17XWwcos1jaeRk/u4v7lSmIKkJImmiAaFv8QKHqMZ43 +uFb3cT5ACcLZpnjV4NzCl565N2o2cLfRaRjznMN5F58hyvGNs691cELYtuUYX2u7cpq io+u8YpykqI5X2aNuICAkFMiHb4NyCBtb3eg8NCuD9JkwGFyubrKVQVBUZYHZbQb46Jh 7+xFWAb1D+U/n7p1namrMcQnX0Y3M6NNSk0DsxQXQ0GA4nDwB0cXL8BZj4SwCu8g7HzC n+ovwx2+mJ1G1iBH8rN4YXsyDJear9xtj+8OEg0UqCqzPKTJkOosNgEPkyaayHhvBzJ0 kbqw== X-Gm-Message-State: AOUpUlGZW1yfIVnx8HOBllwL2Tc2dnl0LifGEMa/TKap5T7zbZGBzAL+ TmXTT/mCdJFxghr0ets5ByA= X-Google-Smtp-Source: AAOMgpcAF6nEtHkkvZRb63jsOICTbf3u5YNgD6/wY41wz5KMKwI4YQFqdMKFiuRiHrVPWXLkb3zMSg== X-Received: by 2002:a2e:1290:: with SMTP id 16-v6mr6836949ljs.94.1532271301116; Sun, 22 Jul 2018 07:55:01 -0700 (PDT) Received: from malediction ([46.48.96.28]) by smtp.gmail.com with ESMTPSA id q16-v6sm1055734lfi.68.2018.07.22.07.54.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Jul 2018 07:55:00 -0700 (PDT) Date: Sun, 22 Jul 2018 19:54:58 +0500 From: Mike Kazantsev To: Lars Ingebrigtsen Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Message-ID: <20180722195458.2e40086f@malediction> In-Reply-To: References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: Eli Zaretskii , npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 22 Jul 2018 13:40:51 +0200 Lars Ingebrigtsen wrote: > OK, I've now fixed the async error case (on master), I think: > > (process-live-p socket) > nil > (process-status socket) > file-missing > > I've fixed this on master, because I'm not 100% sure that my fix is > completely correct. Should we perhaps also call a sentinel in the async > error case? Unless I misunderstood the question, for me as a user, it would be more obvious to get this error in a sentinel call than not with emacs 26, because that's how :nowait is documented to work now: The recommended way to deal with asynchronous sockets is to avoid interacting with them until they have changed status to "run". This is most easily done from a process sentinel. https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS.26 If bool is non-nil for a stream connection, return without waiting for the connection to complete. When the connection succeeds or fails, Emacs will call the sentinel function, with a second argument matching "open" (if successful) or "failed". https://www.gnu.org/software/emacs/manual/html_node/elisp/Network-Processes.html Given either of these guidelines, it'd be more surprising to not get error state in the sentinel call with ":nowait t" in emacs-26. (while ":nowait nil" signaling 'file-error is kinda expected) -- Mike Kazantsev // fraggod.net From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 11:24:06 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 15:24:06 +0000 Received: from localhost ([127.0.0.1]:52592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhGDN-0004Ed-UG for submit@debbugs.gnu.org; Sun, 22 Jul 2018 11:24:06 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:58835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhGDL-0004ET-5I for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 11:24:05 -0400 Received: from cm-84.212.221.165.getinternet.no ([84.212.221.165] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fhGD3-0003i8-Ud; Sun, 22 Jul 2018 17:24:02 +0200 From: Lars Ingebrigtsen To: Mike Kazantsev Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEX3cxL9UAH9QAH7MALw HgP3fXeZAAACVElEQVQ4jTWUi5HbMAxEQU8KIKArQABdQESogNhk/zVlF0p8c7bEJ3x2AVv23pnr 3hmZc6wceeSde8veaybOcyZeC58x8gF5ZdGxJoPnByAL4Lxea+/7uUAKgvs53N8HrM2ksrMiWXkG T2YEj2QvgrqfM1Dpch0jb0TMvMTyNUVaRHjvEmf/JR/B0z1CoouoKs4BJOULkDHG+TqbuhsQwMlU 9QoLZyJVG8hIHRWQ8wi1B9z6gDWtA9hUxKBIpMKVW9ZKkZFuoU8qPabbGAKTRFDALjUtwJsAWLNJ FWYaJUBvaB8WtdZw6SxegE8QQLIcBaq4KvUQ3K11Y3GJMRkhFEodKkzuKD0qRJRPYR5hhg7xkEOM NjSnF8BKPZJAhfkA2IpQud5flMaf4U0bvLFhgr3AjuAsTF7qHa3iZgQEYs7wws3OV3VrsSnwu+gs XYrfr2rphwK9gAXVOiZF8JFGAHejJJvrI0IxfEVETY+2/gcvlS6IwOIQoEYlZI3OsDnSrHTEDO1N mjmAyTWW6QMynhruGJ1gERUTPNE+qnmN463SJC2VQtEiHKsGOndL8O3AYCdSOLaaU+I/ZgevHIfa aGdoazwmwGZ3Maryn5idoHGHUXd2lGLvx0xvlZ8gZOBK9MTkznBEFHDsu50Ev7nnUbWhwlwmtk0w z/H+86yUsgFaIsGRqb0/DaB19krwFX3m9r5YuKETCjFE/Ns+pfcwEdOQcre+ePA0YjiX6gGHOEcB ewbMxYaGDmhqfPdnQGb4GVjaX9Ed+kNo7ail4Y8PbYMGrPlf0EuFeg8gIvUAAAAASUVORK5CYII= Date: Sun, 22 Jul 2018 17:23:45 +0200 In-Reply-To: <20180722195458.2e40086f@malediction> (Mike Kazantsev's message of "Sun, 22 Jul 2018 19:54:58 +0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: Eli Zaretskii , npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mike Kazantsev writes: > Given either of these guidelines, it'd be more surprising to not get > error state in the sentinel call with ":nowait t" in emacs-26. I agree, it would be better to get a sentinel callback. But I don't think that's how it's ever worked, so that's not a regression. But it could be a new feature for Emacs 27... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 11:38:33 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 15:38:33 +0000 Received: from localhost ([127.0.0.1]:52603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhGRJ-0006YT-FF for submit@debbugs.gnu.org; Sun, 22 Jul 2018 11:38:33 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:46429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhGRE-0006YA-OI for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 11:38:28 -0400 Received: by mail-lf1-f67.google.com with SMTP id l16-v6so4735389lfc.13 for <31901@debbugs.gnu.org>; Sun, 22 Jul 2018 08:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uD5nywgXwh559sHNT1IX0psyJ+aUkZqd5NGdB77WgzE=; b=ouCqsuufjSWr0wGAiHHiDMrITFL/XQru/o7roLKRQz3rYnwrkHx/sk3eTQ25jvLaoR BEBaBJ0T3YSarEfSW8cVFDPRRM7vAbp0rMDw3QfI86RnBals/bbOpLIt5gju7IHQ7W4i V2pm/E5J09dRevjmGdyMXZ2OnaFsgZBk3Mbl3J0RGo7MCx7+sVPsp5N3lXcwJr5twxgs nY314jGQld6Tx75m+OOOfGmr7fXbunRtfN0FxZGm+xa7rp3isKLIa5ovSRbjWeyzwBG7 C3o20wbF8xQhaAoH8I6xZoccvnf+2icMiK9p97tISgvZIgtm+B26ptGVcDSwpHsrtCH4 HEEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uD5nywgXwh559sHNT1IX0psyJ+aUkZqd5NGdB77WgzE=; b=Xy2jl5SxAMFKKx/o0Od/OrOiHOjKHneE+IEj1HHgF+Nw0HgHfGmyLu+suObFAXmndW K+WoaEnSYhxzcIqY+JSgmT+XVRfICUmDXqLjTIOuOriYW8vtQ48pGKs23Ux3RLCG2cMW 76UuVBxjxop0H5e6RwHWPThlHd2QbCzWmbfl2fdSZh1GkrmQ1ybCxmTc2/A7uIwgSYGs Q6m0AX/GCFkrEikUjrVy+zlztsJxvlDipxCeCUANnDaLLx/BEefN3XgX2VNda6Y3YuJw zNheRtRkbPUiUx3ii/ZSnOefd6+1ugZT+4hWBeCSGRsVw4AidmeHOdX/G89ol5Zexbfc w6qA== X-Gm-Message-State: AOUpUlFCDsx/jpocHXfjQgi3flCdNQBjyXw11/TtSU3w6x6GBhDRySqA oqyd8OfJYJBHcN2sxFIzMUs= X-Google-Smtp-Source: AAOMgpeDB1/mtN4F77eYYb7VgKPltwI97B6pQnOqWaQLIHWNReeRoCjYN7RdNinWXSIfRVnD9lDqWw== X-Received: by 2002:a19:4895:: with SMTP id v143-v6mr5204550lfa.82.1532273898914; Sun, 22 Jul 2018 08:38:18 -0700 (PDT) Received: from malediction ([46.48.96.28]) by smtp.gmail.com with ESMTPSA id 73-v6sm1062631lfx.75.2018.07.22.08.38.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Jul 2018 08:38:18 -0700 (PDT) Date: Sun, 22 Jul 2018 20:38:16 +0500 From: Mike Kazantsev To: Lars Ingebrigtsen Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Message-ID: <20180722203816.41cb0eb5@malediction> In-Reply-To: References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: Eli Zaretskii , npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 22 Jul 2018 17:23:45 +0200 Lars Ingebrigtsen wrote: > Mike Kazantsev writes: > > > Given either of these guidelines, it'd be more surprising to not get > > error state in the sentinel call with ":nowait t" in emacs-26. > > I agree, it would be better to get a sentinel callback. But I don't > think that's how it's ever worked, so that's not a regression. But it > could be a new feature for Emacs 27... Yeah, guess so. Though I thought how it works was supposed to change in emacs-26 already (as indicated by NEWS/documentation), which is why reverting to emacs-25 behavior looks like a bug in itself. But of course happy with it working either way, thanks for fixing it! -- Mike Kazantsev // fraggod.net From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 11:56:45 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 15:56:45 +0000 Received: from localhost ([127.0.0.1]:52618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhGiw-0006yQ-1Z for submit@debbugs.gnu.org; Sun, 22 Jul 2018 11:56:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhGiq-0006y7-Tl for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 11:56:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhGih-00073k-Nc for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 11:56:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhGih-00073c-J3; Sun, 22 Jul 2018 11:56:27 -0400 Received: from [176.228.60.248] (port=2866 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhGig-0007Wq-TF; Sun, 22 Jul 2018 11:56:27 -0400 Date: Sun, 22 Jul 2018 18:56:31 +0300 Message-Id: <83pnzfw9g0.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: (message from Lars Ingebrigtsen on Sun, 22 Jul 2018 17:23:45 +0200) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , npostavs@gmail.com, 31901@debbugs.gnu.org > Date: Sun, 22 Jul 2018 17:23:45 +0200 > > Mike Kazantsev writes: > > > Given either of these guidelines, it'd be more surprising to not get > > error state in the sentinel call with ":nowait t" in emacs-26. > > I agree, it would be better to get a sentinel callback. But I don't > think that's how it's ever worked, so that's not a regression. But it > could be a new feature for Emacs 27... Yes, I think we should just fix the bug on emacs-26, and introduce the sentinel callback on master. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 12:42:24 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 16:42:24 +0000 Received: from localhost ([127.0.0.1]:52656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhHR6-00087c-MQ for submit@debbugs.gnu.org; Sun, 22 Jul 2018 12:42:24 -0400 Received: from mail-lf1-f53.google.com ([209.85.167.53]:33679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhHR1-00087L-VL for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 12:42:19 -0400 Received: by mail-lf1-f53.google.com with SMTP id u14-v6so4801913lfu.0 for <31901@debbugs.gnu.org>; Sun, 22 Jul 2018 09:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ehNaZchy/JpY+LUgTqbIdy7PyBJdHhLSJfJeF+RmILs=; b=bdA0BbhE3N2RN7L92u5pNt+Gedv0NRFcq0p9GpMT+bIuYA4DkFjv/afHJrqgxjWiif ZxZc/z74oj9Q0GdB+HYdC+XJrPPzidp92WexAiIGIHD79xQY2c6vota0ScDssj7IWZDH QSmy2caDAs5lq6l//WLZhStDhyZ45PTMd4eslIxqRNTNfBx5w0OGnI/IXIzDsSmLYM8d beVnyiwQaYXdqllj74Hhly759MqJL4ulWl0Z9rxfjdEvmskcb2xhXNDZPU1ezssOCrPQ rGWnN9+aXmhXEiJFdHQUzW+FIyvXH1FK44YYdGbqmzAus4qtmEs3jw+rIROzQIlcR8Mc 5Peg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ehNaZchy/JpY+LUgTqbIdy7PyBJdHhLSJfJeF+RmILs=; b=qd5MH7AB9HGFAodrEzFNwYw2ceJxVS6y5EeloWaE0fu8XHm61GwR2PEontS/bJsVZE 02SM1of3+p7oicJQ31KVbu9AjPbtGP/IKS+ue9/7K1hbEKUZ99brPSCT96aK7FQ2WKFu lp3xcy4xBe71lM7MQA7q39NbJbGAGF0BwFROjVw1HZQTSPdLypiIKU9HTYfwG/L86zox qA1/2zOXY0VNpBncGGb+/eIyu4YiNn88b1G+PL1a2Ps9LoyamcnwHWFJIQdJ83k+w6+x yDu3G+FsrAwDQfnUth5KHrjeM6ByrfEpDMSfq4vKAigxMDQiUUlD7x4+dtsNXRFm0lCg NNPQ== X-Gm-Message-State: AOUpUlGhxENrFWX2XxB6HWX8PJW8UoHIJGNEytoaVs300ovB/KBhnKIE aCuW4/otAD2jOblrDDLnx9A= X-Google-Smtp-Source: AAOMgpfhrm2+OL3RGsnmzunWqQxwMrYnqJ7SHqe8Sn2t2XaMAhpFvUpIMUPzWNP3zqCjfdWeMWoY9w== X-Received: by 2002:a19:e546:: with SMTP id c67-v6mr5352665lfh.135.1532277730128; Sun, 22 Jul 2018 09:42:10 -0700 (PDT) Received: from malediction ([46.48.96.28]) by smtp.gmail.com with ESMTPSA id m8-v6sm1434909ljj.10.2018.07.22.09.42.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Jul 2018 09:42:09 -0700 (PDT) Date: Sun, 22 Jul 2018 21:42:07 +0500 From: Mike Kazantsev To: Eli Zaretskii Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Message-ID: <20180722214207.1ccaff3d@malediction> In-Reply-To: <83pnzfw9g0.fsf@gnu.org> References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> <83pnzfw9g0.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 31901 Cc: Lars Ingebrigtsen , npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 22 Jul 2018 18:56:31 +0300 Eli Zaretskii wrote: > > From: Lars Ingebrigtsen > > Cc: Eli Zaretskii , npostavs@gmail.com, 31901@debbugs.gnu.org > > Date: Sun, 22 Jul 2018 17:23:45 +0200 > > > > Mike Kazantsev writes: > > > > > Given either of these guidelines, it'd be more surprising to not get > > > error state in the sentinel call with ":nowait t" in emacs-26. > > > > I agree, it would be better to get a sentinel callback. But I don't > > think that's how it's ever worked, so that's not a regression. But it > > could be a new feature for Emacs 27... > > Yes, I think we should just fix the bug on emacs-26, and introduce the > sentinel callback on master. I just built emacs from git to test how it works, and have to report that unfortunately current behavior is not consistent with what emacs had either before this bug was introduced. More details follow. == How it worked in emacs-25: (make-network-process ... :family 'local :service "/tmp/does-not-exist.sock" :nowait t :sentinel #'unix-socket-test-func) => nil [sentinel never called] (process-live-p socket) => nil (because "socket" will be nil) (process-status socket) => error I.e. nil was returned to indicate failure to create network process. == How it works in emacs-26.1 (with the bug in question): (make-network-process ... :family 'local :service "/tmp/does-not-exist.sock" :nowait t :sentinel #'unix-socket-test-func) => # [sentinel never called] (process-live-p socket) => [non-nil value] (process-status socket) => 'open This is the case described in the original bug report. == How it works in emacs-26.1 with ":nowail nil": (make-network-process ... :family 'local :service "/tmp/does-not-exist.sock" :nowait nil :sentinel #'unix-socket-test-func) => [file-missing signaled] [sentinel never called] (process-live-p socket) => [no socket value] (process-status socket) => [no socket value] Provided here to illustrate the difference with current ":nowait t" case. == How it works in current emacs-git [8f3bca3ad51]: (make-network-process ... :family 'local :service "/tmp/does-not-exist.sock" :nowait t :sentinel #'unix-socket-test-func) => # [sentinel never called] (process-live-p socket) => nil (process-status socket) => 'file-missing Note that this is: - Not consistent with what emacs did before this bug. - Not consistent with what emacs-26 does with ":nowait nil". - Does not seem to be consistent with what documentation describes (as indicated in this thread earlier, might be subjective). So wanted to note that as it is, entirely new unexpected behavior was introduced, which does not line up neither with how this worked previously (and will certainly break the code there), nor how you'd expect it to work after emacs-26 changes (either signal error same as ":nowait nil" does, or via sentinel). As far as I can tell, this applies to both missing unix socket and when it exists, but connection to it is refused (nothing listening there). -- Mike Kazantsev // fraggod.net From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 22 12:55:50 2018 Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 16:55:50 +0000 Received: from localhost ([127.0.0.1]:52660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhHeA-0008S2-8W for submit@debbugs.gnu.org; Sun, 22 Jul 2018 12:55:50 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:34837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhHe8-0008Rp-SM for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 12:55:49 -0400 Received: by mail-lj1-f195.google.com with SMTP id p10-v6so14918714ljg.2 for <31901@debbugs.gnu.org>; Sun, 22 Jul 2018 09:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=141mnbMrvKXMJaQA1e5FAbTO0VR7nuj6xMm6VjZu4HU=; b=P/UL71GvKsDER7qzVUUpKExS0I37Fi1tmyJBAVwSf56487qs/p92OtZnliyucSe1PM SomdJsOqDxYWpeOJ27WqkWTiAh1J11N7h123/zHscGGAOWJJx/K/1ZJvHAT0eNk9VseA jCyfoIBe0h7j+L5vhVuQmM8/bA5RYJHgz0F9OwR++c6fGRYMr5vARkSYalqHwHqvASxm 7s3VG6C6DxsRi8mx31OhvPvJNVfu5cxy6VkjXzDhTxiROqBdxVyq96yAQTuwEgNot/SN aOPiIB7/9KqUoTx3Thp24/OuRwk7ByMMlMgnW9vL9ZyRxM3eAbmFA9IM0iZgVruadUrL /7ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=141mnbMrvKXMJaQA1e5FAbTO0VR7nuj6xMm6VjZu4HU=; b=WVTw18G3HgfBxYxsBDu3+d0+ucW2o4gcaQ02JpwiVTIglY7fjMsEJYNlKUMT9SIUTJ w9yRVGw/GAHOr6llP4QtqOUBUwx4pBozhzJY/whAt7d3fjdCjcx9FO/V5nHaIM0WLHGn ObuB6xxr4Vc8M8CE9cMQFysjzpPMugEBbrTZjhegldRSk+bDrWK9+fk+dgbcqQaQtCfV nnQOX4+fhFsSFDwdaVuRlvl6OvVODrObpg+yq1euMS+J/nXVnxAMocmK6odnvD0fEieM VbOXrLhk75X2350obrutL0j7IFD6OUt1jzgyw6xB2vF6twRVEs7a60J0SAm3sLG5ogvu DCnA== X-Gm-Message-State: AOUpUlFRLBJTaj1o/kq2tUrcu9Dd772ApeLKAK1sQj28Uf4UzKFdnPff i0Ku7MdBZ5tjeyZfPEkrGPo= X-Google-Smtp-Source: AAOMgpcdMmWz+R64db0xyD5gSUrCWT7wBRm3IehU2e2e+4IGasHopWsZWK5yi44WWzc3nSA9x+UzjA== X-Received: by 2002:a2e:6d0a:: with SMTP id i10-v6mr7010444ljc.145.1532278543018; Sun, 22 Jul 2018 09:55:43 -0700 (PDT) Received: from malediction ([46.48.96.28]) by smtp.gmail.com with ESMTPSA id o19-v6sm1094714lfk.65.2018.07.22.09.55.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Jul 2018 09:55:42 -0700 (PDT) Date: Sun, 22 Jul 2018 21:55:40 +0500 From: Mike Kazantsev To: Eli Zaretskii Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Message-ID: <20180722215540.63fc8782@malediction> In-Reply-To: <20180722214207.1ccaff3d@malediction> References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> <83pnzfw9g0.fsf@gnu.org> <20180722214207.1ccaff3d@malediction> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: Lars Ingebrigtsen , npostavs@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 22 Jul 2018 21:42:07 +0500 Mike Kazantsev wrote: > == How it works in current emacs-git [8f3bca3ad51]: > > (make-network-process > ... > :family 'local > :service "/tmp/does-not-exist.sock" > :nowait t > :sentinel #'unix-socket-test-func) > > => # > [sentinel never called] > > (process-live-p socket) => nil > (process-status socket) => 'file-missing > > Note that this is: > > - Not consistent with what emacs did before this bug. After sending previous mail, realized that maybe it is consistent with emacs 26.0 or similar version before the bug which I've never tested, where change was made to behave exactly like that, but then this bug changed it again. If so, this change will be consistent with that, and I'm definitely wrong about this behavior being only introduced here. Which would explain my misunderstanding of how this fix works, and if that's the case, please disregard that previous message, sorry. -- Mike Kazantsev // fraggod.net From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 06 16:36:37 2018 Received: (at 31901) by debbugs.gnu.org; 6 Aug 2018 20:36:37 +0000 Received: from localhost ([127.0.0.1]:42941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmmF2-0007tS-Pl for submit@debbugs.gnu.org; Mon, 06 Aug 2018 16:36:36 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:39477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmmF1-0007tF-Fb for 31901@debbugs.gnu.org; Mon, 06 Aug 2018 16:36:35 -0400 Received: by mail-io0-f175.google.com with SMTP id o22-v6so12174773ioh.6 for <31901@debbugs.gnu.org>; Mon, 06 Aug 2018 13:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OwQ+afNgPIcARKN5E+QaJ15mc1WIIVEPAOEPhZIoaT0=; b=A6LhWOe2z2qiTYztdIxq8WdLd3xzhqIv6wpct9QlQmYyNYkOobi14htXcHiV1OV1Ex 51OEoHKkYf6jbvB30NlJqqEGUrcvBoXk67LxdQ73nOHOXaUR3bd8ybXnGp0FtdTtDHKX sIH4ClpOPAE7n8hpj4EgDb98/BahvEiTwZK/qQww/DEUuAixBlrjpaWyz3RHBPrWwxVx ZMHdzC6yAm8SEZh5dNIAdwKu4vCa72YOTtyz1iARNP4XM/hEYimVoeSB4zbO0KqSCvUP vbmVl9/IMtWHoIZGSn3YYK01GZWRPWx9q45n68+aeYwYlQpKsih9W/ARpkWKeap3RCEk 639g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OwQ+afNgPIcARKN5E+QaJ15mc1WIIVEPAOEPhZIoaT0=; b=j94cRLhGli1QeavHsOdNErZFraBgUbE5Rhcr/9/D3Lm5XWzrPVzx/T+O1Bc9r1YTKb PEfxwXGfH0411axkI3N6IawP4C95Jqpn5SABAkuMeMa8bRKXs3XsuesZx2zoF4//tZtd Vf73Li1TKIFny6aHx8CB162nGeTxws21mr4+3ZP7CmLQfxd9OEuzfLAeIee/sA48QaRe VkLALqHq3P0VKL50kY8qrRCFx9Lhu1jhEz+maf9HCYTGSgjfVl5MOyneNAD68WM0Jz9u L1T3/45DT0b3jTrUZTw8il18ygBCaw9uIiIy8GIM6kJKlTMEUPtCZwLluOUc3kz03psv VHvw== X-Gm-Message-State: AOUpUlG1YC873BZMu2IPE3EysSMO3qS3jqDfe8lC/wsG4uc8MSdd24sX SEV5gK4QWHXR0SIcUpZv/8dPbdAD X-Google-Smtp-Source: AA+uWPyhCFa7d4084hDqKhN1cbO3au+EtOhqFYwg303458q51mAVZGsigEamZxieARaacMpYXxchrw== X-Received: by 2002:a6b:b955:: with SMTP id j82-v6mr16197649iof.158.1533587789691; Mon, 06 Aug 2018 13:36:29 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b19-v6sm4420887itc.24.2018.08.06.13.36.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 13:36:28 -0700 (PDT) From: Noam Postavsky To: Mike Kazantsev Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> <83pnzfw9g0.fsf@gnu.org> <20180722214207.1ccaff3d@malediction> <20180722215540.63fc8782@malediction> Date: Mon, 06 Aug 2018 16:36:28 -0400 In-Reply-To: <20180722215540.63fc8782@malediction> (Mike Kazantsev's message of "Sun, 22 Jul 2018 21:55:40 +0500") Message-ID: <87h8k7xmer.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: Eli Zaretskii , Lars Ingebrigtsen , 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mike Kazantsev writes: > On Sun, 22 Jul 2018 21:42:07 +0500 > Mike Kazantsev wrote: > >> == How it works in current emacs-git [8f3bca3ad51]: >> >> (make-network-process >> ... >> :family 'local >> :service "/tmp/does-not-exist.sock" >> :nowait t >> :sentinel #'unix-socket-test-func) >> >> => # >> [sentinel never called] >> >> (process-live-p socket) => nil >> (process-status socket) => 'file-missing >> >> Note that this is: >> >> - Not consistent with what emacs did before this bug. > > After sending previous mail, realized that maybe it is consistent with > emacs 26.0 or similar version before the bug which I've never tested, > where change was made to behave exactly like that, but then this bug > changed it again. I believe the behaviour changed with the introduction of the bug (by the way, Emacs releases are XX.y where y > 1, so there was never a 26.0 release). So the situation is not ideal, but I do think that it's acceptable as a compromise. Shall we backport and close the bug? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 07 11:48:22 2018 Received: (at 31901) by debbugs.gnu.org; 7 Aug 2018 15:48:22 +0000 Received: from localhost ([127.0.0.1]:43835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fn4Da-00007b-Cj for submit@debbugs.gnu.org; Tue, 07 Aug 2018 11:48:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fn4DV-00007J-IL for 31901@debbugs.gnu.org; Tue, 07 Aug 2018 11:48:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fn4DL-0002lx-GK for 31901@debbugs.gnu.org; Tue, 07 Aug 2018 11:48:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fn4DL-0002lt-BG; Tue, 07 Aug 2018 11:48:03 -0400 Received: from [176.228.60.248] (port=4991 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fn4DK-0001AS-N8; Tue, 07 Aug 2018 11:48:03 -0400 Date: Tue, 07 Aug 2018 18:48:01 +0300 Message-Id: <834lg6qitq.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87h8k7xmer.fsf@gmail.com> (message from Noam Postavsky on Mon, 06 Aug 2018 16:36:28 -0400) Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> <83pnzfw9g0.fsf@gnu.org> <20180722214207.1ccaff3d@malediction> <20180722215540.63fc8782@malediction> <87h8k7xmer.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31901 Cc: larsi@gnus.org, mk.fraggod@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: Eli Zaretskii , Lars Ingebrigtsen , 31901@debbugs.gnu.org > Date: Mon, 06 Aug 2018 16:36:28 -0400 > > So the situation is not ideal, but I do think that it's acceptable as a > compromise. Shall we backport and close the bug? Yes, I believe we already agreed on backporting. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 08 19:52:18 2018 Received: (at 31901) by debbugs.gnu.org; 8 Aug 2018 23:52:18 +0000 Received: from localhost ([127.0.0.1]:45374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnYFS-0004EM-AM for submit@debbugs.gnu.org; Wed, 08 Aug 2018 19:52:17 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:38614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnYFJ-0004D5-5e; Wed, 08 Aug 2018 19:52:08 -0400 Received: by mail-io0-f175.google.com with SMTP id v26-v6so3331679iog.5; Wed, 08 Aug 2018 16:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eF/HP2ErJwN8k8rOb8RF2Hfp8j5W2yA5mluFvlaqPos=; b=goKPo3jq2nB3EVmKWJuQUhbaChVrFcBFmCh60GTFD1Vw6IOvgOF7sh03WYsj4wRMW5 6pS3WlqjUYO1hi0m+2DNfdRZMkPtdCPWvDapWXbFAk56xUFamu4wbLtMpqFlA/MLoFp0 5edCjtnEvX3QKNcINJZgx453ojWmiYsJzUk+OB9YHEmWnjo7cXfODfA82JkLD4UroNPd SUmfc4oClRwPQLIo1jquzTfb2Zib6GRgvKokrkScNXL/8vIZUuS+PjdUNeQjq0zMIA6U h0IH5kQRFRsGUO8BdzMexyIC2KMIBBLYjuNzyREWxdrz2MUogq5zgLOd5xiOqU5IOj79 nbRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eF/HP2ErJwN8k8rOb8RF2Hfp8j5W2yA5mluFvlaqPos=; b=q1qtQPaAOlSQJ4f0OBWSprVrA9I3b7mQLY3gTDrcMuUhtceNVh/3AAS1mdf0Et/9tw tkg5iCAcf5HlDouXqQ/ifvyoQZ3un4yqtibVcHKXDNd+Nmbfauh3xn7E1lfWu1Zm0qV5 C+lBdyyIRcZP1RUW/BOl2OapxMndhqPrK72uqikKg4D9fpt1AcboReCg1JxIS6UgEji0 eYRSJa6gNPT0NnZF6a+wNl4CNy4VdCvsub7tMs/bPC0XOJH+UUI4VtJwmgn/5FTRnM1R jYMN+J2rUDpmSgRadT3v5w9YSnDRRKIAH5SvPe9Kd51+OH0189lYWXT0jRU2ebItPRCj nPZw== X-Gm-Message-State: AOUpUlGUua3zuPLA8P8WTcmaEPMwMkCExKDz1g+jxGchaEm5FWA5bDNC iyj13sEJsfDeV538wrqKRBJ9Wv5f X-Google-Smtp-Source: AA+uWPwWhZ56OdWq/E/jDOagzD4mFnlF+zQhOflQDbJQTGZQ1PVmcTUTx4kmRqwUafKxuvpy74tmVw== X-Received: by 2002:a6b:22ce:: with SMTP id i197-v6mr4315761ioi.74.1533772319619; Wed, 08 Aug 2018 16:51:59 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d10-v6sm1634324ioc.76.2018.08.08.16.51.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 16:51:58 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> <20180722195458.2e40086f@malediction> <83pnzfw9g0.fsf@gnu.org> <20180722214207.1ccaff3d@malediction> <20180722215540.63fc8782@malediction> <87h8k7xmer.fsf@gmail.com> <834lg6qitq.fsf@gnu.org> Date: Wed, 08 Aug 2018 19:51:57 -0400 In-Reply-To: <834lg6qitq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 07 Aug 2018 18:48:01 +0300") Message-ID: <87y3dgwh5u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31901 Cc: larsi@gnus.org, mk.fraggod@gmail.com, 31901@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31901 fixed close 31901 26.2 quit Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: Eli Zaretskii , Lars Ingebrigtsen , 31901@debbugs.gnu.org >> Date: Mon, 06 Aug 2018 16:36:28 -0400 >> >> So the situation is not ideal, but I do think that it's acceptable as a >> compromise. Shall we backport and close the bug? > > Yes, I believe we already agreed on backporting. Done. [1: 18588bce36]: 2018-08-08 19:30:50 -0400 Make async :family 'local failures fail correctly again https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=18588bce36617179cc7c8af74a6197c8e16819ea From unknown Sat Jun 21 05:06:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Sep 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator