GNU bug report logs - #31866
[PATCH] gnu: emacs-image+: Don't propagate inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31866: closed ([PATCH] gnu: emacs-image+: Don't propagate
 inputs.)
Date: Mon, 18 Jun 2018 21:19:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 18 Jun 2018 23:18:22 +0200
with message-id <87in6fu735.fsf <at> gnu.org>
and subject line Re: [bug#31866] [PATCH] gnu: emacs-image+: Don't propagate inputs.
has caused the debbugs.gnu.org bug report #31866,
regarding [PATCH] gnu: emacs-image+: Don't propagate inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31866: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31866
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-image+: Don't propagate inputs.
Date: Sun, 17 Jun 2018 00:32:24 +0200

* gnu/packages/emacs.scm (emacs-image+)[propagated-inputs]: Remove imagemagick
[Inputs]: Add imagemagick
[arguments]: Substitute path to imagemagick commands
---
 gnu/packages/emacs.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 4999dda55..b81706248 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -11204,7 +11204,22 @@ provided by other Emacs packages dealing with pass:
           (base32
            "0v66wk9nh0raih4jhrzmmyi5lbysjnmbv791vm2230ffi2hmwxnd"))))
       (build-system emacs-build-system)
-      (propagated-inputs `(("imagemagick" ,imagemagick)))
+      (inputs `(("imagemagick" ,imagemagick)))
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'configure
+             (lambda* (#:key inputs outputs #:allow-other-keys)
+               (let ((imagemagick (assoc-ref inputs "imagemagick")))
+                 ;; Specify the absolute file names of the various
+                 ;; programs so that everything works out-of-the-box.
+                 (chmod "image+.el" #o666)
+                 (emacs-substitute-variables
+                     "image+.el"
+                   ("imagex-convert-command"
+                    (string-append imagemagick "/bin/convert"))
+                   ("imagex-identify-command"
+                    (string-append imagemagick "/bin/identify")))))))))
       (home-page "https://github.com/mhayashi1120/Emacs-imagex")
       (synopsis "Image manipulation extensions for Emacs")
       (description
-- 
2.17.1

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31866-done <at> debbugs.gnu.org
Subject: Re: [bug#31866] [PATCH] gnu: emacs-image+: Don't propagate inputs.
Date: Mon, 18 Jun 2018 23:18:22 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-image+)[propagated-inputs]: Remove imagemagick
> [Inputs]: Add imagemagick
> [arguments]: Substitute path to imagemagick commands

Good idea.  Applied, thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.