GNU bug report logs - #31863
[PATCH] gnu: emacs-fish-completion: Don't propagate inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31863: closed ([PATCH] gnu: emacs-fish-completion: Don't
 propagate inputs.)
Date: Sat, 16 Jun 2018 22:21:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Jun 2018 00:19:55 +0200
with message-id <87in6iml10.fsf <at> gnu.org>
and subject line Re: [bug#31863] [PATCH] gnu: emacs-fish-completion: Don't propagate inputs.
has caused the debbugs.gnu.org bug report #31863,
regarding [PATCH] gnu: emacs-fish-completion: Don't propagate inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31863: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31863
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-fish-completion: Don't propagate inputs.
Date: Sat, 16 Jun 2018 21:41:04 +0200

* gnu/packages/emacs.scm (emacs-fish-completion)[propagated-inputs]: Remove fish
[inputs]: Add fish
---
 gnu/packages/emacs.scm | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 4999dda55..1bf046b44 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10857,9 +10857,21 @@ Org-mode.  It features:
         (base32
          "16329py7fvid0bap1qhqxhdc68m9qqy1p8gc2bhng81zhm5a5zsm"))))
     (build-system emacs-build-system)
-    (propagated-inputs `(("fish" ,fish)))
+    (inputs `(("fish" ,fish)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'configure
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((fish (assoc-ref inputs "fish")))
+               ;; Specify the absolute file names of the various
+               ;; programs so that everything works out-of-the-box.
+               (emacs-substitute-variables
+                   "fish-completion.el"
+                 ("fish-completion-command"
+                  (string-append fish "/bin/fish")))))))))
     (home-page
-     "https://github.com/Ambrevar/emacs-fish-completion")
+     "https://gitlab.com/Ambrevar/emacs-fish-completion")
     (synopsis "Fish completion for Emacs pcomplete")
     (description
      "This package provides completion for the Fish shell to pcomplete (used
-- 
2.17.1

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31863-done <at> debbugs.gnu.org
Subject: Re: [bug#31863] [PATCH] gnu: emacs-fish-completion: Don't propagate
 inputs.
Date: Sun, 17 Jun 2018 00:19:55 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-fish-completion)[propagated-inputs]: Remove fish
> [inputs]: Add fish

I mentioned ‘arguments’ in the log and committed.  Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.