GNU bug report logs - #31850
[PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31850 in the body.
You can then email your comments to 31850 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable
 "gs".
Date: Sat, 16 Jun 2018 00:56:22 +0530

* gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
the absolute path to "gs" in the store.
---
 gnu/packages/tex.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index b6bc9dda6..91081c64b 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -176,14 +176,16 @@
                            (string-prefix? "mips64" s))))
       #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'fix-unix-detection
+         (add-after 'unpack 'configure-ghostscript-executable
            ;; ps2eps.pl uses the "gswin32c" ghostscript executable on Windows,
            ;; and the "gs" ghostscript executable on Unix. It detects Unix by
            ;; checking for the existence of the /usr/bin directory. Since
            ;; GuixSD does not have /usr/bin, it is also detected as Windows.
-           (lambda _
+           (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "utils/ps2eps/ps2eps-src/bin/ps2eps.pl"
                (("gswin32c") "gs"))
+             (substitute* "texk/texlive/linked_scripts/epstopdf/epstopdf.pl"
+               (("\"gs\"") (string-append "\"" (assoc-ref inputs "ghostscript") "/bin/gs\"")))
              #t))
          (add-after 'install 'postint
            (lambda* (#:key inputs outputs #:allow-other-keys #:rest args)
-- 
2.15.1

Message #8 received at 31850 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 31850 <at> debbugs.gnu.org
Subject: Re: bug#31850: Acknowledgement ([PATCH] gnu: texlive-bin: Use
 absolute path to ghostscript executable "gs".)
Date: Sat, 16 Jun 2018 01:26:37 +0530

I seem to have made one of the lines way too long. I'll fix that before
pushing, once someone has reviewed this patch. Also, should this patch
go to core-updates considering that the texlive package is very tedious
to build?

Message #11 received at 31850 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 31850 <at> debbugs.gnu.org, Ricardo Wurmus <rekado <at> elephly.net>
Subject: Re: [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to
 ghostscript executable "gs".
Date: Sat, 16 Jun 2018 18:13:36 +0200

Hello,

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> * gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
> phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
> the absolute path to "gs" in the store.

LGTM.

> I seem to have made one of the lines way too long. I'll fix that before
> pushing, once someone has reviewed this patch. Also, should this patch
> go to core-updates considering that the texlive package is very tedious
> to build?

‘texlive-bin’ has just 252 dependent it seems, many of which are
‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
OK for master, but I could be missing some other way in which
‘texlive-bin’ is depended on.  Ricardo, WDYT?

Ludo’.

Message #14 received at 31850 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31850 <at> debbugs.gnu.org, Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Re: [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to
 ghostscript executable "gs".
Date: Sat, 16 Jun 2018 22:46:38 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Arun Isaac <arunisaac <at> systemreboot.net> skribis:
>
>> * gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
>> phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
>> the absolute path to "gs" in the store.
>
> LGTM.
>
>> I seem to have made one of the lines way too long. I'll fix that before
>> pushing, once someone has reviewed this patch. Also, should this patch
>> go to core-updates considering that the texlive package is very tedious
>> to build?
>
> ‘texlive-bin’ has just 252 dependent it seems, many of which are
> ‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
> OK for master, but I could be missing some other way in which
> ‘texlive-bin’ is depended on.  Ricardo, WDYT?

Yes, this should be fine.

Thanks!

-- 
Ricardo

Message #17 received at 31850 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>, Ludovic Courtès <ludo <at> gnu.org>
Cc: 31850 <at> debbugs.gnu.org
Subject: Re: [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to
 ghostscript executable "gs".
Date: Sun, 17 Jun 2018 12:36:00 +0530

>> ‘texlive-bin’ has just 252 dependent it seems, many of which are
>> ‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
>> OK for master, but I could be missing some other way in which
>> ‘texlive-bin’ is depended on.

But, we'd be forcing people to download the huge (~ 2.2 GB)
texlive-texmf source tarball. And, the texlive package which depends on
texlive-bin spends a good deal of time in the install phase. Is this
fine?

Message #20 received at 31850 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 31850 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to
 ghostscript executable "gs".
Date: Sun, 17 Jun 2018 13:44:11 +0200

Arun Isaac <arunisaac <at> systemreboot.net> writes:

>>> ‘texlive-bin’ has just 252 dependent it seems, many of which are
>>> ‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
>>> OK for master, but I could be missing some other way in which
>>> ‘texlive-bin’ is depended on.
>
> But, we'd be forcing people to download the huge (~ 2.2 GB)
> texlive-texmf source tarball. And, the texlive package which depends on
> texlive-bin spends a good deal of time in the install phase. Is this
> fine?

Only until this is built, which in the case of texlive should not take a
very long time on the build farm.

--
Ricardo

Message #25 received at 31850-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: 31850-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to
 ghostscript executable "gs".
Date: Sun, 17 Jun 2018 21:31:17 +0530

>> But, we'd be forcing people to download the huge (~ 2.2 GB)
>> texlive-texmf source tarball. And, the texlive package which depends on
>> texlive-bin spends a good deal of time in the install phase. Is this
>> fine?
>
> Only until this is built, which in the case of texlive should not take a
> very long time on the build farm.

Ok, done. Pushed!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.