GNU bug report logs - #31845
27.0.50; Error building master on MacOS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31845 in the body.
You can then email your comments to 31845 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Mastro <john.b.mastro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Error building master on MacOS
Date: Fri, 15 Jun 2018 09:05:53 -0700

Hello,

I get the following warnings and error when building master at 3e7dff8
on MacOS 10.13.5 (High Sierra).

macfont.m:911:27: warning: passing 'CFStringRef' (aka 'const struct
__CFString *')
      to parameter of type 'void *' discards qualifiers
      [-Wincompatible-pointer-types-discards-qualifiers]
                  Fcons (make_mint_ptr (name), make_number (traits)));
                                        ^~~~
./lisp.h:2389:22: note: passing argument to parameter 'a' here
make_mint_ptr (void *a)
                     ^
macfont.m:911:47: error: use of undeclared identifier 'traits'
                  Fcons (make_mint_ptr (name), make_number (traits)));
                                                            ^
macfont.m:987:35: warning: passing 'CFTypeRef' (aka 'const void *') to parameter
      of type 'void *' discards qualifiers
      [-Wincompatible-pointer-types-discards-qualifiers]
  value = string ? make_mint_ptr (CFRetain (string)) : Qnil;
                                  ^~~~~~~~~~~~~~~~~
./lisp.h:2389:22: note: passing argument to parameter 'a' here
make_mint_ptr (void *a)
                     ^
2 warnings and 1 error generated.
make[2]: *** [macfont.o] Error 1
make[1]: *** [src] Error 2
make: *** [bootstrap] Error 2

Thanks

        John

Message #8 received at 31845 <at> debbugs.gnu.org (full text, mbox):

From: John Mastro <john.b.mastro <at> gmail.com>
To: 31845 <at> debbugs.gnu.org
Subject: Re: bug#31845: 27.0.50; Error building master on MacOS
Date: Fri, 15 Jun 2018 09:56:12 -0700

John Mastro <john.b.mastro <at> gmail.com> wrote:
> I get the following warnings and error when building master at 3e7dff8
> on MacOS 10.13.5 (High Sierra).

I just tried again after seeing Paul Eggert pushed a related commit
(850c0c1). The two warnings are gone but this error remains:

macfont.m:911:56: error: use of undeclared identifier 'traits'
                  Fcons (make_mint_ptr ((void *) name), make_number (traits)));
                                                                     ^
1 error generated.
make[2]: *** [macfont.o] Error 1
make[1]: *** [src] Error 2

Thanks

    John

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Moreton <andrewjmoreton <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#31845: 27.0.50; Error building master on MacOS
Date: Fri, 15 Jun 2018 18:25:21 +0100

On Fri 15 Jun 2018, John Mastro wrote:

> John Mastro <john.b.mastro <at> gmail.com> wrote:
>> I get the following warnings and error when building master at 3e7dff8
>> on MacOS 10.13.5 (High Sierra).
>
> I just tried again after seeing Paul Eggert pushed a related commit
> (850c0c1). The two warnings are gone but this error remains:
>
> macfont.m:911:56: error: use of undeclared identifier 'traits'
>                   Fcons (make_mint_ptr ((void *) name), make_number (traits)));
                                                                     ^

This is a typo from commit 6c04c848. Replacing traits with sym_traits
should fix it.

    AndyM

Message #14 received at 31845 <at> debbugs.gnu.org (full text, mbox):

From: John Mastro <john.b.mastro <at> gmail.com>
To: 31845 <at> debbugs.gnu.org
Cc: andrewjmoreton <at> gmail.com
Subject: Re: bug#31845: 27.0.50; Error building master on MacOS
Date: Fri, 15 Jun 2018 12:12:22 -0700

[Message part 1 (text/plain, inline)]

Andy Moreton <andrewjmoreton <at> gmail.com> wrote:
> > macfont.m:911:56: error: use of undeclared identifier 'traits'
> >                   Fcons (make_mint_ptr ((void *) name), make_number (traits)));
>                                                                      ^
> This is a typo from commit 6c04c848. Replacing traits with sym_traits
> should fix it.

Indeed; trivial patch attached

Thanks

    John

[0001-Fix-a-typo-from-commit-6c04c848.patch (application/octet-stream, attachment)]

Message #19 received at 31845-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: John Mastro <john.b.mastro <at> gmail.com>,
 Andy Moreton <andrewjmoreton <at> gmail.com>, 31845-done <at> debbugs.gnu.org,
 31485 <at> debbugs.gnu.org
Subject: Re: bug#31845: 27.0.50; Error building master on MacOS
Date: Sat, 16 Jun 2018 09:32:36 -0700

Ludovic Courtès wrote:
> Hi Paul,
> 
> Paul Eggert <eggert <at> cs.ucla.edu> skribis:
> 
>> Thanks for reporting that; it should be fixed now.
> 
> I was glad to see your name on bug-guix, but it turns out you emailed
> the wrong bug address.  :-)
> 
>    https://bugs.gnu.org/31485

Sorry about that, and thanks for letting me know. Closing the correct bug number 
(31845) now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.