From unknown Wed Aug 20 01:20:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31844: [cuirass] Invalid specs are ignored, should be reported instead Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 15 Jun 2018 12:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31844 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 31844@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.152906627022511 (code B ref -1); Fri, 15 Jun 2018 12:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Jun 2018 12:37:50 +0000 Received: from localhost ([127.0.0.1]:49084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTnzC-0005r1-Bs for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTnzA-0005ql-8B for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTnz3-0000vh-T9 for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTnz3-0000vJ-Pl for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTnz2-0001sQ-O3 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTnyz-0000qM-LU for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:40 -0400 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:55586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTnyz-0000nU-A9 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:37 -0400 Received: from localhost (localhost [127.0.0.1]) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTP id 3840E926FC9 for ; Fri, 15 Jun 2018 14:37:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:user-agent :received:received:received:received; s=mdc; t=1529066250; x= 1530880651; bh=33suMluerg1K+XQr/8Qu6eRIwJqQzRaLdMQmnNPjhBA=; b=b 58O64JoDhURrJCDnnCg+LY5i0H1+R94Qyx5Vjx/UcqJBnkjiRYGHvUBEL6GvP4Y/ W/D59OHaQw//j65DLV18FsdYs4wmyCYGLriOKltsrkXkXET+0xcQPxAXMtbCI/Lk Px2jFenA99/XBtDP1BWtbH6BytuLm3Q3JTSmPu2GGM= X-Virus-Scanned: amavisd-new at mdc-berlin.de Received: from pegasus.bbbm.mdc-berlin.de ([127.0.0.1]) by localhost (pegasus.bbbm.mdc-berlin.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7JYoTOMit4R for ; Fri, 15 Jun 2018 14:37:30 +0200 (CEST) Received: from HTCAONE.mdc-berlin.net (puck.citx.mdc-berlin.de [141.80.36.101]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTPS for ; Fri, 15 Jun 2018 14:37:29 +0200 (CEST) Received: from SW-IT-P-CAS3.mdc-berlin.net (141.80.113.58) by HTCAONE.mdc-berlin.net (141.80.180.120) with Microsoft SMTP Server (TLS) id 14.3.399.0; Fri, 15 Jun 2018 14:37:29 +0200 Received: from localhost (141.80.113.51) by SW-IT-P-CAS3.mdc-berlin.net (141.80.113.58) with Microsoft SMTP Server id 14.3.399.0; Fri, 15 Jun 2018 14:37:29 +0200 User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Fri, 15 Jun 2018 14:37:19 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Originating-IP: [141.80.113.51] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.2.1013-23908.006 X-TM-AS-Result: No-0.090000-8.000000-10 X-TMASE-MatchedRID: 8Sa70/9GQBPE+/p97o4OwAz4VsCc1YW+5Y0kb0hqatxcKZwALwMGs88d Lp7uPvw2585VzGMOFzDBHdWQCJm28tAtbEEX0MxBxEHRux+uk8jQ9TRN0mhS18yP5B/EqfEXzKJ /1BkMk7+ElkIJRUJet3faXfTpdeMaMsTXV/qc6jRooAfw2kxwopgrcFPf0FoOYSOPUI+zd7B7p8 7JOB6q7l6yDvf2QiYn74d8OnDj2Dmp3MK7kvg/QRMVuwczykaNPo3iAZMGHKg= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.090000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.2.1013-23908.006 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) When Cuirass processes a list of specifications it silently ignores those that would result in erroneous SQL statements. Take for example a specification that does not include an #:arguments field. The database schema says that =E2=80=9Carguments=E2=80=9D may not= be NULL, but db-add-specification will produce an INSERT statement that sets =E2=80=9Carguments=E2=80=9D to NULL when it is not part of the specificat= ion alist. Cuirass should either validate the specifications before passing them to =E2=80=9Cdb-add-specification=E2=80=9D or report an error when =E2=80=9Cd= b-add-specification=E2=80=9D fails to add a table record. -- Ricardo From unknown Wed Aug 20 01:20:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ricardo Wurmus Subject: bug#31844: closed (Re: bug#31844: [cuirass] Invalid specs are ignored, should be reported instead) Message-ID: References: <878s6b49s7.fsf@gnu.org> X-Gnu-PR-Message: they-closed 31844 X-Gnu-PR-Package: guix Reply-To: 31844@debbugs.gnu.org Date: Thu, 25 Mar 2021 13:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1616680622-32732-1" This is a multi-part message in MIME format... ------------=_1616680622-32732-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31844: [cuirass] Invalid specs are ignored, should be reported instead which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31844@debbugs.gnu.org. --=20 31844: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31844 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1616680622-32732-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31844-done) by debbugs.gnu.org; 25 Mar 2021 13:56:19 +0000 Received: from localhost ([127.0.0.1]:39098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPQTC-0008VS-Nv for submit@debbugs.gnu.org; Thu, 25 Mar 2021 09:56:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPQTB-0008VM-Tc for 31844-done@debbugs.gnu.org; Thu, 25 Mar 2021 09:56:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51307) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPQT4-0007Vf-DV; Thu, 25 Mar 2021 09:56:10 -0400 Received: from [2a01:cb18:832e:5f00:6893:84b0:dbe3:3cb1] (port=44814 helo=mathieu-HP-EliteBook-840-G1) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lPQT3-0002q3-Qb; Thu, 25 Mar 2021 09:56:10 -0400 From: Mathieu Othacehe To: Ricardo Wurmus Subject: Re: bug#31844: [cuirass] Invalid specs are ignored, should be reported instead References: Date: Thu, 25 Mar 2021 14:56:08 +0100 In-Reply-To: (Ricardo Wurmus's message of "Fri, 15 Jun 2018 14:37:19 +0200") Message-ID: <878s6b49s7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31844-done Cc: 31844-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Invalid specifications are now reported, see for example: --8<---------------cut here---------------start------------->8--- (list (specification (namee "guix-master") (build 'hello))) --8<---------------cut here---------------end--------------->8--- gives, --8<---------------cut here---------------start------------->8--- 2021-03-25T14:52:46 running Fibers on 4 kernel threads /home/mathieu/cuirass/examples/hello.scm:1:6: error: (specification (namee "guix-master") (build (quote hello))): extraneous field initializers (namee) --8<---------------cut here---------------end--------------->8--- Closing this one, Thanks, Mathieu ------------=_1616680622-32732-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Jun 2018 12:37:50 +0000 Received: from localhost ([127.0.0.1]:49084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTnzC-0005r1-Bs for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTnzA-0005ql-8B for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTnz3-0000vh-T9 for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTnz3-0000vJ-Pl for submit@debbugs.gnu.org; Fri, 15 Jun 2018 08:37:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTnz2-0001sQ-O3 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTnyz-0000qM-LU for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:40 -0400 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:55586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTnyz-0000nU-A9 for bug-guix@gnu.org; Fri, 15 Jun 2018 08:37:37 -0400 Received: from localhost (localhost [127.0.0.1]) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTP id 3840E926FC9 for ; Fri, 15 Jun 2018 14:37:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:user-agent :received:received:received:received; s=mdc; t=1529066250; x= 1530880651; bh=33suMluerg1K+XQr/8Qu6eRIwJqQzRaLdMQmnNPjhBA=; b=b 58O64JoDhURrJCDnnCg+LY5i0H1+R94Qyx5Vjx/UcqJBnkjiRYGHvUBEL6GvP4Y/ W/D59OHaQw//j65DLV18FsdYs4wmyCYGLriOKltsrkXkXET+0xcQPxAXMtbCI/Lk Px2jFenA99/XBtDP1BWtbH6BytuLm3Q3JTSmPu2GGM= X-Virus-Scanned: amavisd-new at mdc-berlin.de Received: from pegasus.bbbm.mdc-berlin.de ([127.0.0.1]) by localhost (pegasus.bbbm.mdc-berlin.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7JYoTOMit4R for ; Fri, 15 Jun 2018 14:37:30 +0200 (CEST) Received: from HTCAONE.mdc-berlin.net (puck.citx.mdc-berlin.de [141.80.36.101]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pegasus.bbbm.mdc-berlin.de (Postfix) with ESMTPS for ; Fri, 15 Jun 2018 14:37:29 +0200 (CEST) Received: from SW-IT-P-CAS3.mdc-berlin.net (141.80.113.58) by HTCAONE.mdc-berlin.net (141.80.180.120) with Microsoft SMTP Server (TLS) id 14.3.399.0; Fri, 15 Jun 2018 14:37:29 +0200 Received: from localhost (141.80.113.51) by SW-IT-P-CAS3.mdc-berlin.net (141.80.113.58) with Microsoft SMTP Server id 14.3.399.0; Fri, 15 Jun 2018 14:37:29 +0200 User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus To: Subject: [cuirass] Invalid specs are ignored, should be reported instead X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Fri, 15 Jun 2018 14:37:19 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Originating-IP: [141.80.113.51] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.2.1013-23908.006 X-TM-AS-Result: No-0.090000-8.000000-10 X-TMASE-MatchedRID: 8Sa70/9GQBPE+/p97o4OwAz4VsCc1YW+5Y0kb0hqatxcKZwALwMGs88d Lp7uPvw2585VzGMOFzDBHdWQCJm28tAtbEEX0MxBxEHRux+uk8jQ9TRN0mhS18yP5B/EqfEXzKJ /1BkMk7+ElkIJRUJet3faXfTpdeMaMsTXV/qc6jRooAfw2kxwopgrcFPf0FoOYSOPUI+zd7B7p8 7JOB6q7l6yDvf2QiYn74d8OnDj2Dmp3MK7kvg/QRMVuwczykaNPo3iAZMGHKg= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.090000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.2.1013-23908.006 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) When Cuirass processes a list of specifications it silently ignores those that would result in erroneous SQL statements. Take for example a specification that does not include an #:arguments field. The database schema says that =E2=80=9Carguments=E2=80=9D may not= be NULL, but db-add-specification will produce an INSERT statement that sets =E2=80=9Carguments=E2=80=9D to NULL when it is not part of the specificat= ion alist. Cuirass should either validate the specifications before passing them to =E2=80=9Cdb-add-specification=E2=80=9D or report an error when =E2=80=9Cd= b-add-specification=E2=80=9D fails to add a table record. -- Ricardo ------------=_1616680622-32732-1--