GNU bug report logs - #31800
suggestion of improvement for sort-numeric-fields function.

Previous Next

Full log

Message #19 received at 31800 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: SK Kim <tttuuu888 <at> gmail.com>, 31800 <at> debbugs.gnu.org
Subject: Re: bug#31800: suggestion of improvement for sort-numeric-fields
 function.
Date: Wed, 22 Jan 2020 14:44:36 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> The patch below looks good to me.  Does anyone else have an opinion
> here, or should I go ahead and commit it to master?

[...]

>> -		     (sort-skip-fields field)
>> +                     (unless (string-match-p "^\\s-*$" (thing-at-point 'line))
>> +                       (sort-skip-fields field))

I don't think this patch makes sense as is -- I think that's a
convoluted way of saying `looking-at'?  But it makes conceptual sense, I
think.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.