GNU bug report logs - #31792
27.0.50; Regression in #'labels, recent versions

Previous Next

Package: emacs;

Reported by: Aidan Kehoe <kehoea <at> parhasard.net>

Date: Mon, 11 Jun 2018 23:12:01 UTC

Severity: normal

Tags: fixed, patch

Found in versions 27.0.50, 25.3

Fixed in version 26.2

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #18 received at 31792 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Aidan Kehoe <kehoea <at> parhasard.net>, 31792 <at> debbugs.gnu.org
Subject: Re: bug#31792: 27.0.50; Regression in #'labels, recent versions
Date: Wed, 13 Jun 2018 09:16:01 -0400

> diff --git a/lisp/emacs-lisp/cl.el b/lisp/emacs-lisp/cl.el
> index d53c8e0bbc..85deb8cb4f 100644
> --- a/lisp/emacs-lisp/cl.el
> +++ b/lisp/emacs-lisp/cl.el
> @@ -466,8 +466,9 @@ labels
>  	(push var sets)
>  	(push (cons (car binding)
>                      `(lambda (&rest cl-labels-args)
> -                       (cl-list* 'funcall ',var
> -                                 cl-labels-args)))
> +                       (if (eq (car cl-labels-args) cl--labels-magic)
> +                           (list cl--labels-magic ',var)
> +                         (cl-list* 'funcall ',var cl-labels-args))))
>                newenv)))
>      (macroexpand-all `(lexical-let ,vars (setq ,@sets) ,@body) newenv)))

Looks good, but please add a comment before the call to macroexpand-all
reminding that lexical-let installs a macroexpander for `function` that
ends up calling cl--labels-convert.


        Stefan
This bug report was last modified 7 years and 30 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.