From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 04:27:00 2018 Received: (at submit) by debbugs.gnu.org; 11 Jun 2018 08:27:00 +0000 Received: from localhost ([127.0.0.1]:42750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSIAF-0007C0-U6 for submit@debbugs.gnu.org; Mon, 11 Jun 2018 04:27:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSIAD-0007Bm-Nl for submit@debbugs.gnu.org; Mon, 11 Jun 2018 04:26:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSIA7-00025N-GB for submit@debbugs.gnu.org; Mon, 11 Jun 2018 04:26:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSIA7-00025H-Ch for submit@debbugs.gnu.org; Mon, 11 Jun 2018 04:26:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSIA5-0004bY-TI for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 04:26:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSIA2-000203-KP for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 04:26:49 -0400 Received: from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]:33784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSIA2-0001z3-D9 for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 04:26:46 -0400 Received: by mail-wr0-x234.google.com with SMTP id k16-v6so19390412wro.0 for ; Mon, 11 Jun 2018 01:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=okpsi0GId3eUDwRuDtNYkZcb8ITV4FbAWXAM0ax2PjI=; b=E78erb/KzCkyOzLJYxo3gzcQTiwKWm3KGU8x2PVDqDNBgVeHxXBATJqhLBRVZOayqO D6sgLC95kYmpCPPdeTwNi95k+7v/fI6dipvALi3BST22Af5xsibW1k0a0Fyq2DihK6Ic dGT5BqHLOLEUN/lFlVBmO4t2+IDO5vz49DoU9XcvVACF6rKyuIL1370FIJum8C/mlnEq 8LJ3+PsQccTMR1tYp5Gmd7mFrr3cdha+O+LXzp8H1hjx5Ygvu+O90V1DzCh/7YnJVIPj 4YhoGUwoxO/ELByWGa2Tt7FCAe0foA/9vALGiGBkKYKUTJZcZeIY5PA4F67BXe6VqRKQ 4jyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=okpsi0GId3eUDwRuDtNYkZcb8ITV4FbAWXAM0ax2PjI=; b=orxzwSYRvJEpIrl0dxPJ3Ot8F1BZG4pZRWOFWzmTgxmghRPK/hWppkb/mwB3pqVmcW g79XxownKh1qEZ5r/AdI4ZmSsN8CVSCBy3lFRcLQY6jF0Mv/mAqA+j5oyrC/jzD9Rdmq AG4RX3WBKUG/yWRYmqyYqylcGBjZPSZaWs4qnIso9dv6DFRYVuH42tMhDD7Tq08ZJyMr 51J9sgbsjuCg9ZUhUXsNOjRC5OLyKQUOKzEx5eOYu/yLUM8TfAaLF5+QQuy6pYVZEidm 1tKFODCa/KnBiDIsuKfoOyfi9Z0vmUL+kJpcvkg1LOQhq7JGS12ZelzOGy9yfZpuinI6 91bw== X-Gm-Message-State: APt69E1pJIU6zjpFTWdbXvAuoriFM7jdS1ZBB65XiUjDO4Sjf1noTkD1 3+BrfEmV2hpDZE1jS+AlobI9yJpg X-Google-Smtp-Source: ADUXVKIQ8e8vEL1EKVAqqQMFKVey0lof3xBvZOtOdPHFIE+Ck6trkkEwbhGFIZP/2AwwQKwJHAnlZw== X-Received: by 2002:adf:91e5:: with SMTP id 92-v6mr12189717wri.124.1528705604950; Mon, 11 Jun 2018 01:26:44 -0700 (PDT) Received: from PAD2018L060.Parrot.Biz (smtp.parrot.biz. [62.23.167.188]) by smtp.gmail.com with ESMTPSA id q17-v6sm34623403wrs.5.2018.06.11.01.26.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 01:26:44 -0700 (PDT) From: Christophe Junke To: bug-gnu-emacs@gnu.org Subject: [PATCH v2] ido.el: define a special ido-fallback variable Date: Mon, 11 Jun 2018 10:23:40 +0200 Message-Id: <20180611082340.28727-1-junke.christophe@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <83bmcktpef.fsf@gnu.org> References: <83bmcktpef.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Christophe Junke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) - Introduce a global, special ido-fallback variable - Rename existing occurrences of fallback to ido-fallback This allows to retain the behaviour that was available prior to introducing per-file lexical-scope, namely that other modules could change what fallback command to call when ido-exit is set to 'fallback. --- Hi, I agree that it is simpler to rename the existing variable, and just add a defvar declaration. Here is a different version of the patch which does only this. Thank you for your review and your time. lisp/ido.el | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/lisp/ido.el b/lisp/ido.el index 705e7dd630..358e856d4a 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -1242,6 +1242,9 @@ Only used if `ido-use-virtual-buffers' is non-nil.") ;; Dynamically bound in ido-read-internal. (defvar ido-completing-read) +;; Indicates which fallback command to call when ido-exit is 'fallback. +(defvar ido-fallback nil) + ;;; FUNCTIONS (defun ido-active (&optional merge) @@ -2213,13 +2216,13 @@ If cursor is not at the end of the user input, move to end of input." (exit-minibuffer))) ;;; MAIN FUNCTIONS -(defun ido-buffer-internal (method &optional fallback prompt default initial switch-cmd) +(defun ido-buffer-internal (method &optional ido-fallback prompt default initial switch-cmd) ;; Internal function for ido-switch-buffer and friends (if (not ido-mode) (progn (run-hook-with-args 'ido-before-fallback-functions - (or fallback 'switch-to-buffer)) - (call-interactively (or fallback 'switch-to-buffer))) + (or ido-fallback 'switch-to-buffer)) + (call-interactively (or ido-fallback 'switch-to-buffer))) (let* ((ido-context-switch-command switch-cmd) (ido-current-directory nil) (ido-directory-nonreadable nil) @@ -2245,7 +2248,7 @@ If cursor is not at the end of the user input, move to end of input." ((eq ido-exit 'fallback) (let ((read-buffer-function nil)) - (setq this-command (or fallback 'switch-to-buffer)) + (setq this-command (or ido-fallback 'switch-to-buffer)) (run-hook-with-args 'ido-before-fallback-functions this-command) (call-interactively this-command))) @@ -2337,7 +2340,7 @@ If cursor is not at the end of the user input, move to end of input." ;; Add final slash to result in case it was missing from DEFAULT-DIRECTORY. (ido-final-slash (expand-file-name (or dir default-directory)) t)) -(defun ido-file-internal (method &optional fallback default prompt item initial switch-cmd) +(defun ido-file-internal (method &optional ido-fallback default prompt item initial switch-cmd) ;; Internal function for ido-find-file and friends (unless item (setq item 'file)) @@ -2412,7 +2415,7 @@ If cursor is not at the end of the user input, move to end of input." ;; we don't want to change directory of current buffer. (let ((default-directory ido-current-directory) (read-file-name-function nil)) - (setq this-command (or fallback 'find-file)) + (setq this-command (or ido-fallback 'find-file)) (run-hook-with-args 'ido-before-fallback-functions this-command) (call-interactively this-command))) @@ -2496,10 +2499,10 @@ If cursor is not at the end of the user input, move to end of input." ((eq method 'read-only) (ido-record-work-file filename) (setq filename (concat ido-current-directory filename)) - (ido-record-command fallback filename) + (ido-record-command ido-fallback filename) (ido-record-work-directory) - (run-hook-with-args 'ido-before-fallback-functions fallback) - (funcall fallback filename)) + (run-hook-with-args 'ido-before-fallback-functions ido-fallback) + (funcall ido-fallback filename)) ((eq method 'insert) (ido-record-work-file filename) -- 2.14.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 08:19:13 2018 Received: (at 31783) by debbugs.gnu.org; 11 Jun 2018 12:19:13 +0000 Received: from localhost ([127.0.0.1]:42857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSLmy-0006Av-Qc for submit@debbugs.gnu.org; Mon, 11 Jun 2018 08:19:12 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:44550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSLmx-0006Ad-DR; Mon, 11 Jun 2018 08:19:11 -0400 Received: by mail-io0-f172.google.com with SMTP id g7-v6so23577451ioh.11; Mon, 11 Jun 2018 05:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=L2K3rCNHSC/6AuVZTNTZWcHlPyT+HFdH589lEPU+daI=; b=M4VA4c45TIELMm89iHYHfI9ukzyrcrtWYtb1m5R/K4785Jhf0j9p6/mrWAs07sktvF fb1Wt+rstSSMNgA4rcKK0KILbwili61WQuYDYDt58kYKzxYGRuvXEcnwDkhKzFSUQbB/ 1FhU4/K3NoYDNuo14F0+r3tg8IX6c6uvvSUCyi0qSt5HeuCdK9GOi7E1TW+s/i6IcW12 f+GQ4k/UtAmq9UkbST9j2Nh+qQRLDLQAmbWMzwpcTvMm9hXCZ85fSH9dHRaPD0pLiJXB VVei9X3oaROioGi3qgRb04JebRgKVeSC1kZq1foXnHh84R2aOROnr09w5Z3F0eoCOA8F NB6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=L2K3rCNHSC/6AuVZTNTZWcHlPyT+HFdH589lEPU+daI=; b=bhp8yV0f+jX1yuiJ6fKs6FrZzCzsu0N/TgU3JA7cIKo6Fe/rI4yIkE1EdN+Z3KkZwV 6WSAZ2dwhaLs2CzYVuR6PylrJ1Jj/TrP/C0C2bHwlYwfGzuaLhNMCkZEytKobgknIPdG d7KrAbdg5MHVwlOpDQPR/qdtQtnzyEVrJlnEptF+6jU9Fu+BGNzDtvJDmjZH2789m+gY oAZxI35Iq2ioP3EpBkw/f8r5Z35kHJkWcA3GS5OTV1CeNTi18a434xWzI9CNGfhxu7Rr 3Mo3JpH8pq5zFLvzNg6VMEgXLcj7TITKmaNabSpesY109XhR8ZmUwve2Lj3cmI0PJccq q/3w== X-Gm-Message-State: APt69E29mBxm4XOH5XxtNcbnQkYvBBchsWXLn5kDu1Ukxgg59mY3ppAx 19ur4WV4nlkF/HIiL+GCfbuFNw== X-Google-Smtp-Source: ADUXVKJHWbe/x92zkteTWFkg4gQFEZANR+Jk2SWo16ChnPLYD33ClZOERrm96wH2DKpvM7RiyngCXg== X-Received: by 2002:a6b:8e0d:: with SMTP id q13-v6mr13861304iod.169.1528719545710; Mon, 11 Jun 2018 05:19:05 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 16-v6sm4069527itk.17.2018.06.11.05.19.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 05:19:05 -0700 (PDT) From: Noam Postavsky To: Christophe Junke Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> Date: Mon, 11 Jun 2018 08:19:03 -0400 In-Reply-To: <20180611082340.28727-1-junke.christophe@gmail.com> (Christophe Junke's message of "Mon, 11 Jun 2018 10:23:40 +0200") Message-ID: <87efhdzfbc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31783 Cc: 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 31783 31707 quit Christophe Junke writes: > I agree that it is simpler to rename the existing variable, and just > add a defvar declaration. Here is a different version of the patch > which does only this. > +;; Indicates which fallback command to call when ido-exit is 'fallback. > +(defvar ido-fallback nil) > -(defun ido-buffer-internal (method &optional fallback prompt default initial switch-cmd) > +(defun ido-buffer-internal (method &optional ido-fallback prompt default initial switch-cmd) I believe this doesn't work, function parameters are always lexically bound. Compare ; -*- lexical-binding: t -*- (setq lexical-binding t) ; for use in *scratch* (defvar x nil) (disassemble (lambda (x y) (+ x y))) (let ((x 1)) (disassemble (lambda (y) (+ x y)))) So I think your first patch was fine. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 08:55:29 2018 Received: (at 31783) by debbugs.gnu.org; 11 Jun 2018 12:55:29 +0000 Received: from localhost ([127.0.0.1]:42915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSMM5-0002Zw-AB for submit@debbugs.gnu.org; Mon, 11 Jun 2018 08:55:29 -0400 Received: from mail-ot0-f172.google.com ([74.125.82.172]:40284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSMM4-0002Zi-Fg for 31783@debbugs.gnu.org; Mon, 11 Jun 2018 08:55:28 -0400 Received: by mail-ot0-f172.google.com with SMTP id w9-v6so18112549otj.7 for <31783@debbugs.gnu.org>; Mon, 11 Jun 2018 05:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LzmCSLPRIloSQxxlzzidM8+CuAens+lqc4bCxjtX8F8=; b=Yr9eN4TFC1T/y3Ztxmxso1OJuK49g22dBMeS/K7/ZU9NTeRURptYIxxYiad7ZOQQ0C Ky+fbvEJ6N2meBSTC/a+OKX4k7fHKLjyCGov815K2w1U7HLDiJNBuNnHt1v8MxiGNHou f8oVc/e8nK1f4HKhD0Nh6dcR1KFqxlY415FHvBFZ9X4hpVWoaGvhHgH4NVfXm0Yd9Dik TtTHlV7QHxbL2CQGjSFOi5BYNtafy45fwM6IGGCqWIRYMnc9GZ76OJZDqvYsvhSo7OuJ ElruA6gP000j/KcAkM0ECUGt5C9VlRmx0vZ73PbMfr6j1YSr+aONitxg6Kvjpr20rUBN hgGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LzmCSLPRIloSQxxlzzidM8+CuAens+lqc4bCxjtX8F8=; b=OeHZjIbhL2TskCaRCmCydYFCFNf0d07b/D5jh5R6pJietkAO9vkMH6+2MrKxVdLVQu ndPUhRmMMPm665vIZXxARHwf402ypGOOyR4GIiMJb7GWo2qe9kd8GyQ/FiBEpK7Qg+ee nIyOK1QIyVV2B3Chd/vz+4WtU9jodYFEI7NGtAd6GC1sOmYYYS3KPklNkIl6ws+9q3ks XUam0xncP4vGQ8ADZ7q38pQ7hcIhU8sDtdNuYmD2p1+pGU5ZuwuWB1hQsUlFPE1uSKxI z5bVsgt+BZyT0JQZ+LkTPrNTn422qaty/1BgesRENiR/sodEARaK5vIdZnV6DR9YkIDB TmNQ== X-Gm-Message-State: APt69E2Drqysm0SqB4ge9YozNBZ+g33EG+hWom8F22+JSM4Utb5JVYM1 GmHhzr5th7mD7kULRDlFfvK6D9/malDiDjnQjdQ= X-Google-Smtp-Source: ADUXVKKM2NRaT8SWb4QLlu8uXbuP88gkIeaZTxJLhXgMy1ePKfuOqjne+WQ9Y7WOg+G2wjZ5FutEdTp67sz7CvqLKxg= X-Received: by 2002:a9d:7208:: with SMTP id u8-v6mr9205272otj.200.1528721722714; Mon, 11 Jun 2018 05:55:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:13c3:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 05:54:52 -0700 (PDT) In-Reply-To: <87efhdzfbc.fsf@gmail.com> References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> From: Christophe Junke Date: Mon, 11 Jun 2018 14:54:52 +0200 Message-ID: Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable To: Noam Postavsky Content-Type: multipart/alternative; boundary="0000000000003e30b4056e5d432a" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31783 Cc: 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003e30b4056e5d432a Content-Type: text/plain; charset="UTF-8" > I believe this doesn't work, function parameters are always lexically bound. Indeed, there is even a warning from disassemble about the lexical argument shadowing the dynamic one. Thank you for noticing that. > So I think your first patch was fine. Fine. To recap, the first patch also redefines "ido-fallback-command" so that it accepts an optional parameter (the fallback command). Is that ok for you? The idea was to let Ido be exited with a custom fallback command through a function, and without requiring other packages to set a variable directly. Thank you. On Mon, Jun 11, 2018 at 2:19 PM, Noam Postavsky wrote: > merge 31783 31707 > quit > > Christophe Junke writes: > > > I agree that it is simpler to rename the existing variable, and just > > add a defvar declaration. Here is a different version of the patch > > which does only this. > > > +;; Indicates which fallback command to call when ido-exit is 'fallback. > > +(defvar ido-fallback nil) > > > -(defun ido-buffer-internal (method &optional fallback prompt default > initial switch-cmd) > > +(defun ido-buffer-internal (method &optional ido-fallback prompt > default initial switch-cmd) > > I believe this doesn't work, function parameters are always lexically > bound. Compare > > ; -*- lexical-binding: t -*- > (setq lexical-binding t) ; for use in *scratch* > > (defvar x nil) > > (disassemble (lambda (x y) > (+ x y))) > > (let ((x 1)) > (disassemble (lambda (y) > (+ x y)))) > > So I think your first patch was fine. > --0000000000003e30b4056e5d432a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=C2=A0> I believe this doesn't work, function param= eters are always lexically bound.

Indeed, there is even = a warning from disassemble about the lexical argument shadowing the dynamic= one.

Thank you for noticing that.

<= /div>
>=20 So I think your first patch was fine.

Fine.

To recap, the first patch = also redefines "ido-fallback-command" so that it accepts an optio= nal parameter (the fallback command).
Is that ok for y= ou? The idea was to let Ido be exited with a custom fallback command throug= h a function, and without requiring other packages to set a variable direct= ly.


Thank you= .



<= br>
On Mon, Jun 11, 2018 at 2:19 PM, Noam Postavs= ky <npostavs@gmail.com> wrote:
merge 31783 31707
quit

Christophe Junke <junke.ch= ristophe@gmail.com> writes:

> I agree that it is simpler to rename the existing variable, and just > add a defvar declaration. Here is a different version of the patch
> which does only this.

> +;; Indicates which fallback command to call when ido-exit is 'fal= lback.
> +(defvar ido-fallback nil)

> -(defun ido-buffer-internal (method &optional fallback prompt defa= ult initial switch-cmd)
> +(defun ido-buffer-internal (method &optional ido-fallback prompt = default initial switch-cmd)

I believe this doesn't work, function parameters are always lexically bound.=C2=A0 Compare

=C2=A0 =C2=A0 ; -*- lexical-binding: t -*-
=C2=A0 =C2=A0 (setq lexical-binding t) ; for use in *scratch*

=C2=A0 =C2=A0 (defvar x nil)

=C2=A0 =C2=A0 (disassemble (lambda (x y)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(+ x y= )))

=C2=A0 =C2=A0 (let ((x 1))
=C2=A0 =C2=A0 =C2=A0 (disassemble (lambda (y)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(+ x y))))

So I think your first patch was fine.

--0000000000003e30b4056e5d432a-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 11:28:18 2018 Received: (at 31783) by debbugs.gnu.org; 11 Jun 2018 15:28:18 +0000 Received: from localhost ([127.0.0.1]:43580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOjw-0001j7-60 for submit@debbugs.gnu.org; Mon, 11 Jun 2018 11:28:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOjv-0001iw-CS for 31783@debbugs.gnu.org; Mon, 11 Jun 2018 11:28:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOjl-000602-Vm for 31783@debbugs.gnu.org; Mon, 11 Jun 2018 11:28:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOjl-0005zy-SN; Mon, 11 Jun 2018 11:28:05 -0400 Received: from [176.228.60.248] (port=2076 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSOjl-0004kJ-CN; Mon, 11 Jun 2018 11:28:05 -0400 Date: Mon, 11 Jun 2018 18:28:13 +0300 Message-Id: <83h8m9qr5e.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87efhdzfbc.fsf@gmail.com> (message from Noam Postavsky on Mon, 11 Jun 2018 08:19:03 -0400) Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31783 Cc: junke.christophe@gmail.com, 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Mon, 11 Jun 2018 08:19:03 -0400 > Cc: 31783@debbugs.gnu.org > > Christophe Junke writes: > > > I agree that it is simpler to rename the existing variable, and just > > add a defvar declaration. Here is a different version of the patch > > which does only this. > > > +;; Indicates which fallback command to call when ido-exit is 'fallback. > > +(defvar ido-fallback nil) > > > -(defun ido-buffer-internal (method &optional fallback prompt default initial switch-cmd) > > +(defun ido-buffer-internal (method &optional ido-fallback prompt default initial switch-cmd) > > I believe this doesn't work, function parameters are always lexically > bound. Compare > > ; -*- lexical-binding: t -*- > (setq lexical-binding t) ; for use in *scratch* > > (defvar x nil) > > (disassemble (lambda (x y) > (+ x y))) > > (let ((x 1)) > (disassemble (lambda (y) > (+ x y)))) > > So I think your first patch was fine. There's some misunderstanding here, most probably mine. Sorry; please help me understand what am I missing. The original report said that the problem was caused by using lexical-binding in ido.el, so I proposed to defvar the offending variable to make it dynamically bound, which is the boilerplate solution for all such problems. I thought that was all that was needed, and I definitely didn't suggest to rename anything. What did I miss? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 12:55:51 2018 Received: (at 31783) by debbugs.gnu.org; 11 Jun 2018 16:55:51 +0000 Received: from localhost ([127.0.0.1]:43625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQ6h-0005l8-Gp for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:55:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQ6f-0005kv-Gi for 31783@debbugs.gnu.org; Mon, 11 Jun 2018 12:55:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSQ6R-0000OU-9L for 31783@debbugs.gnu.org; Mon, 11 Jun 2018 12:55:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSQ6Q-0000O6-OT; Mon, 11 Jun 2018 12:55:35 -0400 Received: from [176.228.60.248] (port=2189 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSQ6Q-0005tl-5M; Mon, 11 Jun 2018 12:55:34 -0400 Date: Mon, 11 Jun 2018 19:55:42 +0300 Message-Id: <837en5qn3l.fsf@gnu.org> From: Eli Zaretskii To: Christophe Junke In-reply-to: (message from Christophe Junke on Mon, 11 Jun 2018 18:16:07 +0200) Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31783 Cc: 31783@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Christophe Junke > Date: Mon, 11 Jun 2018 18:16:07 +0200 > > With respect to naming: my possibly wrong understanding of > Emacs Lisp coding conventions is that special variables should be > prefixed by the package's name, and that's why I (re)named > the variable ido-fallback in both patches. > > Also, here is a summary of the original problem, as I see it. Ah, okay. Thanks for explaining this, I agree that your original change was TRT. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 14:52:45 2018 Received: (at 31783) by debbugs.gnu.org; 11 Jun 2018 18:52:45 +0000 Received: from localhost ([127.0.0.1]:43703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSRvo-00023P-Ra for submit@debbugs.gnu.org; Mon, 11 Jun 2018 14:52:45 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:43674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSRvn-00023D-CQ for 31783@debbugs.gnu.org; Mon, 11 Jun 2018 14:52:43 -0400 Received: by mail-ot0-f196.google.com with SMTP id i19-v6so25039817otk.10 for <31783@debbugs.gnu.org>; Mon, 11 Jun 2018 11:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Chjw5cozRh0pMGbf52Bft/HF+hl66gPnDShf6CHOwsU=; b=nTPwOg3DPZmnrHrw9sl5Iecq1Ngq3v0Mc/I5sMnep/1t42s8n1rzbjXvYN32QvgdQo 3rbL/qStjzMjOnstvkrrEMxroEt4604LtqNMs+KPGaTcrmt2yKX6SeNxtun+hbBAxZcl h3rOCTph7WEr9yWZySh4c7bEfiRprk1bGDPvcUOmahlLDT3ngb+jLyrt68AUBNwfXSVY apmoWpAHQIyECoRsundbNncF1qUG8KqQf+sfJtWLSG7LH2c8YIJ7iX6qzhv9OORj68Hi EBhzmGk9lKRwo22NbrtajEXVoT2BeOJ6lNj9qllJUYNuW/BMnDHDq7/rudGzfgWYPSp1 6qPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Chjw5cozRh0pMGbf52Bft/HF+hl66gPnDShf6CHOwsU=; b=Dn41O5aRTdGDCKPv10tdUo9JHE605clBNcsfq9/Vunefdx8X/0i3xOoA6GB5SFV3Bj BE7qOTcruqqTapYb9jp6RvKBPEG8N+EmWmASr6Qpp4TfCYqCY4WAcqHB9eK5IlHY0x1e JXYWgLGZfT8pDyGDUrP0JYwxDv7Vsz/1neFyGZxTYgT35/rc0B24WvFyZuPBK8vrixe1 R0zl7LIY4SjVpNJPT3mLwdaxesis8RWcebtxEl0IErf/Q/BF/v88iboT6hM9Ioy8XK6P edpaBkH44aAdZBj5hso/yPfLRuV97V5lukJJAOydFMCZLBdpELzykxH495mSRKDOEAU+ IbhA== X-Gm-Message-State: APt69E0WFCl1/+MTKGOdwBZM78ym3R4UxCBk2Yr0NYZpaapZyjRZ37Or g9ifWZb0copY4t6ieG9uH/GiafAzP8YXuu33raY1Tg== X-Google-Smtp-Source: ADUXVKJlDCrDBab+sOZCiLPP2uNabi0aH+aLegNy4RuQWMJHkoVJ8PkugVmDn+mhter+wGhdHOUe3a+VgnlRgsZ/ROg= X-Received: by 2002:a9d:caf:: with SMTP id b44-v6mr246858otb.270.1528743157448; Mon, 11 Jun 2018 11:52:37 -0700 (PDT) MIME-Version: 1.0 References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> In-Reply-To: From: Christophe Junke Date: Mon, 11 Jun 2018 20:52:07 +0200 Message-ID: Subject: [PATCH v2] ido.el: define a special ido-fallback variable To: 31783@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000da44bf056e6240cc" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31783 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000da44bf056e6240cc Content-Type: text/plain; charset="UTF-8" (I forgot to cc the list, here is the message I sent previously) > I thought that was all that was needed, and I definitely didn't suggest to rename anything. > What did I miss? With respect to naming: my possibly wrong understanding of Emacs Lisp coding conventions is that special variables should be prefixed by the package's name, and that's why I (re)named the variable ido-fallback in both patches. Also, here is a summary of the original problem, as I see it. Consider an IDO function which accepts a parameter named FALLBACK, and which calls PROMPT. Inside PROMPT, we set FALLBACK to another value. For example: ;; -*- lexical-binding: nil -*- (defun prompt () (setf fallback 10)) (defun ido (fallback) (prompt) fallback) When the above is evaluated with lexical binding being nil, the fallback variable is set from within "prompt" and the result from calling ido is always 10, no matter its input argument. This is not the case if the code is evaluated with lexical-binding set to T, in which case "ido" returns the value bound to the lexical fallback variable: (ido 5) returns 5. The intent of the patches was to allow fallback to be changed again. As I learnt with the second patch, globally declaring "fallback" as a special variable with defvar, with lexical-binding set to T, does not give the same behaviour as with dynamic scoping rules: the "fallback" parameter is still bound lexically, shadowing the dynamic binding. The first patch introduces a globally scoped ido-fallback variable, different from the "fallback" argument. Yet another possibility would be to get rid of the optional "fallback" argument and keep only a global "ido-fallback", like "ido-exit", but that requires to change all call sites. I hope this is clear. Suggestions are welcome, please tell me if I misunderstood something or if there are better ways to reach the original goal. On Mon, Jun 11, 2018 at 5:28 PM, Eli Zaretskii wrote: > > From: Noam Postavsky > > Date: Mon, 11 Jun 2018 08:19:03 -0400 > > Cc: 31783@debbugs.gnu.org > > > > Christophe Junke writes: > > > > > I agree that it is simpler to rename the existing variable, and just > > > add a defvar declaration. Here is a different version of the patch > > > which does only this. > > > > > +;; Indicates which fallback command to call when ido-exit is > 'fallback. > > > +(defvar ido-fallback nil) > > > > > -(defun ido-buffer-internal (method &optional fallback prompt default > initial switch-cmd) > > > +(defun ido-buffer-internal (method &optional ido-fallback prompt > default initial switch-cmd) > > > > I believe this doesn't work, function parameters are always lexically > > bound. Compare > > > > ; -*- lexical-binding: t -*- > > (setq lexical-binding t) ; for use in *scratch* > > > > (defvar x nil) > > > > (disassemble (lambda (x y) > > (+ x y))) > > > > (let ((x 1)) > > (disassemble (lambda (y) > > (+ x y)))) > > > > So I think your first patch was fine. > > There's some misunderstanding here, most probably mine. Sorry; please > help me understand what am I missing. > > The original report said that the problem was caused by using > lexical-binding in ido.el, so I proposed to defvar the offending > variable to make it dynamically bound, which is the boilerplate > solution for all such problems. I thought that was all that was > needed, and I definitely didn't suggest to rename anything. > > What did I miss? > --000000000000da44bf056e6240cc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(I forgot to cc the list, here = is the message I sent previously)

> I thought that was all that was
needed, and I definitely didn't suggest to rename anything.
<= div>> What did I miss?

With respect to nami= ng: my possibly wrong understanding of
Emacs Lisp coding con= ventions is that special variables should be
prefixed by the= package's name, and that's why I (re)named
the vari= able ido-fallback in both patches.

Also, here= is a summary of the original problem, as I see it.

Consider an ID= O function which accepts a parameter named FALLBACK, and
which calls PRO= MPT. Inside PROMPT, we set FALLBACK to another
value. For example:
=C2=A0=C2=A0=C2=A0 ;; -*- lexical-binding: nil -*-

=C2=A0=C2=A0=C2= =A0 (defun prompt ()
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (setf fallback 10))<= br>=C2=A0=C2=A0=C2=A0
=C2=A0=C2=A0=C2=A0 (defun ido (fallback)
=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (prompt)
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fall= back)

When the above is evaluated with lexical binding being nil, th= e
fallback variable is set from within "prompt" and the result= from
calling ido is always 10, no matter its input argument.

Thi= s is not the case if the code is evaluated with lexical-binding set
to T= , in which case "ido" returns the value bound to the lexical
f= allback variable: (ido 5) returns 5.

The intent of t= he patches was to allow fallback to be changed again.

As I learnt with the second patch, globally declaring "fallback&quo= t; as a
special variable with defvar, with lexical-binding set to T, doe= s not
give the same behaviour as with dynamic scoping rules: the "f= allback"
parameter is still bound lexically, shadowing the dynamic = binding.

The first patch introduces a globally scoped ido-fallback v= ariable,
different from the "fallback" argument.

Yet another possibility would be to get rid of the optional= "fallback" argument
and keep only a global "= ido-fallback", like "ido-exit", but that requires to change =
all call sites.

I hope this is clear.
<= br>
Suggestions are welcome, please tell me if I misunderstood somethin= g or
if there are better ways to reach the original goal.




<= /div>




On Mon, Jun 11, 2018 at 5:28 PM, Eli Zaretskii <eliz@gnu.org= > wrote:
> From: Noam Po= stavsky <npostav= s@gmail.com>
> Date: Mon, 11 Jun 2018 08:19:03 -0400
> Cc: 31783@d= ebbugs.gnu.org
>
> Christophe Junke <junke.christophe@gmail.com> writes:
>
> > I agree that it is simpler to rename the existing variable, and j= ust
> > add a defvar declaration. Here is a different version of the patc= h
> > which does only this.
>
> > +;; Indicates which fallback command to call when ido-exit is = 9;fallback.
> > +(defvar ido-fallback nil)
>
> > -(defun ido-buffer-internal (method &optional fallback prompt= default initial switch-cmd)
> > +(defun ido-buffer-internal (method &optional ido-fallback pr= ompt default initial switch-cmd)
>
> I believe this doesn't work, function parameters are always lexica= lly
> bound.=C2=A0 Compare
>
>=C2=A0 =C2=A0 =C2=A0; -*- lexical-binding: t -*-
>=C2=A0 =C2=A0 =C2=A0(setq lexical-binding t) ; for use in *scratch*
>
>=C2=A0 =C2=A0 =C2=A0(defvar x nil)
>
>=C2=A0 =C2=A0 =C2=A0(disassemble (lambda (x y)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (= + x y)))
>
>=C2=A0 =C2=A0 =C2=A0(let ((x 1))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(disassemble (lambda (y)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (+ x y))))
>
> So I think your first patch was fine.

There's some misunderstanding here, most probably mine.=C2=A0 So= rry; please
help me understand what am I missing.

The original report said that the problem was caused by using
lexical-binding in ido.el, so I proposed to defvar the offending
variable to make it dynamically bound, which is the boilerplate
solution for all such problems.=C2=A0 I thought that was all that was
needed, and I definitely didn't suggest to rename anything.

What did I miss?

--000000000000da44bf056e6240cc-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 21 20:34:19 2018 Received: (at 31783) by debbugs.gnu.org; 22 Jun 2018 00:34:19 +0000 Received: from localhost ([127.0.0.1]:59531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWA1r-0000R2-5K for submit@debbugs.gnu.org; Thu, 21 Jun 2018 20:34:19 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:38949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWA1p-0000Qo-Dq for 31783@debbugs.gnu.org; Thu, 21 Jun 2018 20:34:17 -0400 Received: by mail-it0-f42.google.com with SMTP id p185-v6so585844itp.4 for <31783@debbugs.gnu.org>; Thu, 21 Jun 2018 17:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MvwKEt/e0wBuwpt0P6eQ4taJh+raYXUrJn29DHmln4U=; b=BGEmW7hvRHbnyvlJs7PjxYaz4YXIa3g1qxBUBZsRgElGkqqsDitoUt+fnVCh6eokIt tiUP/Mrabs83Pk0pxSA0lZkgvpMnjZzEJxwip9vU+qjJhxUEstGcsd5sGtLLO2V8DQgl xtzG8UZIfuA5kHfiMqNvod1FmJkiOnagR3zPk+Lx9UB3ZPxJkqiLpBAsTkRi9lNsatlk mqL+vSvkqGzHKtO1rjozgI2/w90IiPTQ31P5Qc1pJ9IgX8DZEAhSkLOxW/Vhbs63eGy5 cDc5jaMhY9Bh7k7h54fon1hiss0tQRXZ28Iy9lfYFcogs+J4QP2aAJ96ahufPacz9rN7 /9zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MvwKEt/e0wBuwpt0P6eQ4taJh+raYXUrJn29DHmln4U=; b=idsPtkVD10V22a6pROelrpcQjQSLI3RD7uJDCFCNCF5mKSS105UET5Q+EuhIudqsuw EpYjUZNt58BQx/49fiqLRbpM9C6Is97pp9Mx2etnHC8leudHD0e1Zj1rdxXd3bpmaW4L Bk3/IROSS4NAEueSBO1SmYjfZloJhPxX2kQyj3XQJFwKicdnGsoy3uBV9HkVaK4CFx6/ /9nuUnmBSNWpg/+CkNId4gGQu9Q/Npkc3N5Qwjs5ZEtL3STnwB+FkaYUWt5IUk6EDOsK vGYOk9c79udB+OkBuwPPAqHfASniiTmZwi6AhMgHbvCXLWAEkpdiBF7vi9FStluA1koC 5rjw== X-Gm-Message-State: APt69E1St83mZQTU/XsNaMfyVCa+ZJlUq8yrzc7w0yKPPQbxHSzbzNQ9 tm8fQju+GLhZkSF88R0c0PtYmA== X-Google-Smtp-Source: ADUXVKIb0oCx6f6QVuWq/3S4+fd4TjtZlUBDh8LAkU1wcOveSLGMRE5tCZTdBZFRrT0+W0a7LH88sA== X-Received: by 2002:a24:19c2:: with SMTP id b185-v6mr7104244itb.147.1529627651883; Thu, 21 Jun 2018 17:34:11 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z70-v6sm233245itb.14.2018.06.21.17.34.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jun 2018 17:34:11 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> Date: Thu, 21 Jun 2018 20:34:10 -0400 In-Reply-To: <837en5qn3l.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Jun 2018 19:55:42 +0300") Message-ID: <87h8lvr75p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31783 Cc: Christophe Junke , 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Christophe Junke >> Date: Mon, 11 Jun 2018 18:16:07 +0200 >> >> With respect to naming: my possibly wrong understanding of >> Emacs Lisp coding conventions is that special variables should be >> prefixed by the package's name, and that's why I (re)named >> the variable ido-fallback in both patches. >> >> Also, here is a summary of the original problem, as I see it. > > Ah, okay. Thanks for explaining this, I agree that your original > change was TRT. So should this go to emacs-26? It's introducing a new feature, but that makes up for a semi-accidental feature that was lost. And what's the copyright situation? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 02:35:00 2018 Received: (at 31783) by debbugs.gnu.org; 22 Jun 2018 06:35:01 +0000 Received: from localhost ([127.0.0.1]:59606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWFeu-0002P9-LG for submit@debbugs.gnu.org; Fri, 22 Jun 2018 02:35:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWFet-0002Ox-Ey for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 02:34:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWFel-0005Wf-9r for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 02:34:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWFel-0005WA-5y; Fri, 22 Jun 2018 02:34:51 -0400 Received: from [176.228.60.248] (port=2525 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fWFek-0006jA-K6; Fri, 22 Jun 2018 02:34:50 -0400 Date: Fri, 22 Jun 2018 09:34:58 +0300 Message-Id: <83h8lvqqgd.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87h8lvr75p.fsf@gmail.com> (message from Noam Postavsky on Thu, 21 Jun 2018 20:34:10 -0400) Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31783 Cc: junke.christophe@gmail.com, 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: Christophe Junke , 31783@debbugs.gnu.org > Date: Thu, 21 Jun 2018 20:34:10 -0400 > > > Ah, okay. Thanks for explaining this, I agree that your original > > change was TRT. > > So should this go to emacs-26? Yes, please. > It's introducing a new feature, but that makes up for a > semi-accidental feature that was lost. What new feature is being introduced there? I couldn't see anything new, just fixing a breakage. > And what's the copyright situation? There's no assignment. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 04:25:19 2018 Received: (at 31783) by debbugs.gnu.org; 22 Jun 2018 08:25:19 +0000 Received: from localhost ([127.0.0.1]:59647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWHNe-000531-Rb for submit@debbugs.gnu.org; Fri, 22 Jun 2018 04:25:18 -0400 Received: from mail-ot0-f169.google.com ([74.125.82.169]:38819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWHNd-00052m-3f for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 04:25:17 -0400 Received: by mail-ot0-f169.google.com with SMTP id p95-v6so6632198ota.5 for <31783@debbugs.gnu.org>; Fri, 22 Jun 2018 01:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=haKrxymFc0xT9LBy5+J+6ABLzvvnHEGnUkQ8HFgUSUo=; b=a/by9jHMnuL6HZnSuC96v+FdBX8+6gzi9d2P/MQgdnWXIz9Tz1lX3RTSDKq79LzXm1 llX0NFI2PxZ/p5+28pMvCu4sh9xmy4n9tsue83Ov0A6GJkLCDuUvNzut3sZxSif3360i dVStd6LlxU6A7ElwoJ4Wq2RZpAKwIC1hB+74MxaQeCJg2gi5xepqQTm/9g/Km05MGvLf v06XYM/vhYLXxfFOQAIw7+RZ67/7Pp1FYWNKjeHFSFSaIk0m0DdWVVkWvWBqg3KALsHk ZkiWyfyVCv0zFrhg144hh3BWQ2pufWLVRVDKZh+6kxI5KDrDh7KpPBgNU1ssLNZooGLa kaiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=haKrxymFc0xT9LBy5+J+6ABLzvvnHEGnUkQ8HFgUSUo=; b=pLp1JUcptwPcXGkQuzzYdS7wEH1n9Fs+BNmRa2j/Dg0SgRRQ4ni7V3l7cV7eFQv2uw CyDp5qi6ciHSjUpyvDGIQiNs2CibUwO/pHySzSFIpiQWxZNR3Nja92IFhzdJ8/jgqhOa w9eNaN41RmaYhGqdXsNOaHsKWtW9zBGKloGaNOEBdMTuGPkBLdaHUI58ZUatNo6iBFCg P/71WUdnoq8qTJrA+5YZF8+GxF/ZAtTafEPoJyVeHRwaPaNKdW8BsRi+WgMFWyvDOH8n j7Sxd6G+7vWFtYG1bDpP0VNB6HibtsHFEp1xUO5vDs93rMh4hzNXQle9ojGxc6T013az uApw== X-Gm-Message-State: APt69E1hJvrpxNTlqIUkg7J6qMDt3Bci/xdrPt5/kVFTbGSytol1IVe0 hf0Dp3jE98ixFl7lC/NssVC8How/UzUIhOjEpp8= X-Google-Smtp-Source: AAOMgpfmp0EXhIkkihqCMuGmCJ+p+s0rNPmMm9IUA9xomj4f5DCtHf/NvuV5oXQy/0V2Cd5G5JtBGQU4OOyWh09eOmQ= X-Received: by 2002:a9d:368a:: with SMTP id h10-v6mr317668otc.19.1529655911362; Fri, 22 Jun 2018 01:25:11 -0700 (PDT) MIME-Version: 1.0 References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> In-Reply-To: <83h8lvqqgd.fsf@gnu.org> From: Christophe Junke Date: Fri, 22 Jun 2018 10:24:44 +0200 Message-ID: Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000039b576056f36c50c" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31783 Cc: 31783@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000039b576056f36c50c Content-Type: text/plain; charset="UTF-8" > > > And what's the copyright situation? > > There's no assignment. > I am willing to assign copyright for this change (and future changes). Can you send me a form? Thanks. --00000000000039b576056f36c50c Content-Type: text/html; charset="UTF-8"
> And what's the copyright situation?

There's no assignment.

I am willing to assign copyright for this change (and future changes).
Can you send me a form?
Thanks.

--00000000000039b576056f36c50c-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 05:02:06 2018 Received: (at 31783) by debbugs.gnu.org; 22 Jun 2018 09:02:07 +0000 Received: from localhost ([127.0.0.1]:59671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWHxG-0005zP-J2 for submit@debbugs.gnu.org; Fri, 22 Jun 2018 05:02:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWHxF-0005yr-Df for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 05:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWHx5-000413-5q for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 05:02:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWHx5-00040q-2Y; Fri, 22 Jun 2018 05:01:55 -0400 Received: from [176.228.60.248] (port=3560 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fWHx4-0000n0-GL; Fri, 22 Jun 2018 05:01:54 -0400 Date: Fri, 22 Jun 2018 12:02:03 +0300 Message-Id: <83bmc3qjn8.fsf@gnu.org> From: Eli Zaretskii To: Christophe Junke In-reply-to: (message from Christophe Junke on Fri, 22 Jun 2018 10:24:44 +0200) Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31783 Cc: 31783@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Christophe Junke > Date: Fri, 22 Jun 2018 10:24:44 +0200 > Cc: Noam Postavsky , 31783@debbugs.gnu.org > > > And what's the copyright situation? > > There's no assignment. > > I am willing to assign copyright for this change (and future changes). > Can you send me a form? For sent off-list. However, this patch is small enough to be accepted without waiting for the legal paperwork to be completed. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 07:32:24 2018 Received: (at 31783) by debbugs.gnu.org; 22 Jun 2018 11:32:24 +0000 Received: from localhost ([127.0.0.1]:59706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWKIh-00057c-Se for submit@debbugs.gnu.org; Fri, 22 Jun 2018 07:32:24 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:52399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWKIg-00057O-2d for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 07:32:22 -0400 Received: by mail-it0-f49.google.com with SMTP id m194-v6so2418981itg.2 for <31783@debbugs.gnu.org>; Fri, 22 Jun 2018 04:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4UKWEuZNoE3z4NFHYP6zGLCWCj/b/hV3svKmTps5qkI=; b=SZUWuSY2HFyifGQzDOKK53pNnrCZ9yg26uh1rd2SbB5T1VpR+4bvKGD0qqeq8hiMtb BivNmvSp8908m+FLKTptgVgiC1yXpXjx70WyVi56ZDDO6hhgCJbrybflkYREnKgKzMcl 4p6YKLUrE4nhEFLyRIdNDsoHTkCboVQodQ8LsFIB7LW4BxZU1oqbZ4zMs+sLHSaidyLU /MShIWzb7UzY3/NipFslIlUxdn9Twk0OeXy5wyB4pbr9UlZCdOK/QVMQMZVMO+qEex3g Hid1UIxTXmKOQL3bNCbOn/5cd25LK75zsqJlkCVvcy+vyzdFKtn3Wo7cSyXS9Y9qFOw/ UeDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4UKWEuZNoE3z4NFHYP6zGLCWCj/b/hV3svKmTps5qkI=; b=G9kNsEPSNpcq4LnM7Kdp/IyWoKO0zmOKXdt4oFKkI+ipTWaqz5WROQPElD8U8jGv6z 2olpF1A6n7FZjBiJIxwb1nyhnwn7/v/7XZhxl/cE0RJt1RU8uv/q7a5AE/S3CJvVTlby udR1Hf2tNMTuYPQW4vYX/yk9BBaL6V78+aaQA2ru825+OFSthAncCi3C6p42Ldw4FDMA Gqb+l1ZnlwxWVJC9tqaj7XasVy4j8i7XlxQt9akpSlae9Bz72qw7rpnPMKpZMl5eYB7Y M6eR203Lht08mJ5Vj5X4cVY9xmYbJFjijmFMnMv+8DFnRjYjoO3VA1DZ5Kj3x4iIZ+mv L+uw== X-Gm-Message-State: APt69E1keLThXxCi7/b+5vO6oiEAPCNmTNlQRI4wcEMdNPliBxHbqoc1 L7q3UNSNUE1BBRPji2nL+gu4BQ== X-Google-Smtp-Source: ADUXVKIK1rAulSpPxsJaWE2fpEaDg4aNA1cROS/N9YAPZQk6GR1yTvcBzZvf8N98l3/l/dE346nFLQ== X-Received: by 2002:a02:918f:: with SMTP id p15-v6mr965490jag.95.1529667136508; Fri, 22 Jun 2018 04:32:16 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g26-v6sm1810373iti.0.2018.06.22.04.32.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Jun 2018 04:32:15 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> Date: Fri, 22 Jun 2018 07:32:14 -0400 In-Reply-To: <83h8lvqqgd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Jun 2018 09:34:58 +0300") Message-ID: <87a7rnqcox.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31783 Cc: junke.christophe@gmail.com, 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > > What new feature is being introduced there? I couldn't see anything > new, just fixing a breakage. The optional parameter to ido-fallback-command is new. The ido-fallback is sort of a new variable, although it's arguably just a proper prefixing of the old `fallback' one. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 08:45:23 2018 Received: (at 31783) by debbugs.gnu.org; 22 Jun 2018 12:45:23 +0000 Received: from localhost ([127.0.0.1]:59749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLRL-0000MA-2F for submit@debbugs.gnu.org; Fri, 22 Jun 2018 08:45:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWLRJ-0000Ly-8p for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 08:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWLRA-0004hc-Tz for 31783@debbugs.gnu.org; Fri, 22 Jun 2018 08:45:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWLRA-0004gq-QU; Fri, 22 Jun 2018 08:45:12 -0400 Received: from [176.228.60.248] (port=3814 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fWLR9-0002p7-Tn; Fri, 22 Jun 2018 08:45:12 -0400 Date: Fri, 22 Jun 2018 15:45:20 +0300 Message-Id: <837emrq9b3.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87a7rnqcox.fsf@gmail.com> (message from Noam Postavsky on Fri, 22 Jun 2018 07:32:14 -0400) Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> <87a7rnqcox.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31783 Cc: junke.christophe@gmail.com, 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: junke.christophe@gmail.com, 31783@debbugs.gnu.org > Date: Fri, 22 Jun 2018 07:32:14 -0400 > > Eli Zaretskii writes: > > > > What new feature is being introduced there? I couldn't see anything > > new, just fixing a breakage. > > The optional parameter to ido-fallback-command is new. > > The ido-fallback is sort of a new variable, although it's arguably just > a proper prefixing of the old `fallback' one. Maybe I'm confused about which patch will eventually go in. Can you show it? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 20:40:35 2018 Received: (at control) by debbugs.gnu.org; 26 Jun 2018 00:40:35 +0000 Received: from localhost ([127.0.0.1]:35470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXc27-0008Ag-Gc for submit@debbugs.gnu.org; Mon, 25 Jun 2018 20:40:35 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:37198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXc24-0008AN-DW; Mon, 25 Jun 2018 20:40:32 -0400 Received: by mail-io0-f171.google.com with SMTP id s26-v6so14296545ioj.4; Mon, 25 Jun 2018 17:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=X8ZG+JT4j2G90b7RedIMmfcnVdrGCZ2Eu2Kdrz3JZMM=; b=t5vMGnEXTo0nQSsHp/sovAGscEXYEBP+gughCaYeEYljTdKyig2iLd7pEfddwQ4Tcz K2MKAmKDPv7MSvmnXQyBnn933AthSlBzMQUeAXI4iUoLssYHg0GXH1hwDTk9Tvi/0LgI R3aUoUPjD9UYM0Wufv+TufdysUDKinUR0E6n4Fgg95UHTTcTsEye3/+YeXdvGdVg9mHu FkCcp8zf/QH+ikpY3DNgk6XeTK2d4JRsk88Rb9FDQqUYGA4Y2px3MHyNm/RvqJEs6lbg Ci55+h/dqb7jcHSgCw69dGtCZVLZUYLt3O/HCHeQBtuULt2hR+0dZZPurP0NYVQPEsza mAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=X8ZG+JT4j2G90b7RedIMmfcnVdrGCZ2Eu2Kdrz3JZMM=; b=U5czyyGhkKw645Mjc++PZTjjI1Q7LGCMu1UKE4DYaXYaRk5Zn4Pbk+r1vRODS5DvJc DrS+59PprocsOOjqqz2lN6+Ix8CTWYYLXaVdmSb/4p961xYTZJJ5JZ8i9qWA2pS8yx21 J6lJ3hUjjs8uSpsnFpc0JYsltssvphn+TFpwhSjoIgEjSMX/QkJq90KU65WKG3njR3hj PXW9XO7XAm3f5m5POprmBl1N94IQ2VM/eQLsXor7FuAImnt3At/pstSP3x9zj1xpjAlH +HtYwitYqaLDLFTkJFHNChcwCPUZIe8D1SWTaQvbp/gUUxf8AtthPRSfHeGcU33mzKpz jOfA== X-Gm-Message-State: APt69E3YCaigs1WBA1x5eeA7taLqPBeol+g22+c7zeslNB637Ot1ymVG 56Jdirc2vyHBdEOvcNEeaJGYyw== X-Google-Smtp-Source: ADUXVKKh+SiSqgbobYGHKZt8yhSbYrJMthwJxVVvvBhAmYVAf4uul2QYRAQwrdtMzj3zW0kpOaM3sA== X-Received: by 2002:a6b:988f:: with SMTP id a137-v6mr12573959ioe.212.1529973626696; Mon, 25 Jun 2018 17:40:26 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 20-v6sm351108itu.1.2018.06.25.17.40.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 17:40:25 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31707: [PATCH 1/1] ido: add ido-fallback special variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> <87a7rnqcox.fsf@gmail.com> <837emrq9b3.fsf@gnu.org> <87zhzlosrm.fsf_-_@gmail.com> <83a7rktety.fsf@gnu.org> Date: Mon, 25 Jun 2018 20:40:23 -0400 In-Reply-To: <83a7rktety.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jun 2018 17:54:33 +0300") Message-ID: <87in66peh4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: junke.christophe@gmail.com, 31707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31707 fixed close 31707 26.2 quit Eli Zaretskii writes: > No, I don't think this would be necessary. We are adding a variable > to fix breakage. I think this can go to emacs-26 as-is. Done. [1: 12c77f6918]: 2018-06-25 20:05:53 -0400 Add ido-fallback special variable (Bug#31707) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=12c77f6918c4a60dbbae3f716a58300b4026e8da From unknown Fri Jun 20 07:22:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Jul 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator