From unknown Sat Jun 14 00:08:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31776: guile-2.2: FTBFS on armhf: FAIL: gc.test: gc: after-gc-hook gets called Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 10 Jun 2018 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31776 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 31776@debbugs.gnu.org Cc: Emilio Pozuelo Monfort , 900652@bugs.debian.org, 900652-forwarded@bugs.debian.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152865194830969 (code B ref -1); Sun, 10 Jun 2018 17:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jun 2018 17:32:28 +0000 Received: from localhost ([127.0.0.1]:42527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS4CZ-00083Q-O3 for submit@debbugs.gnu.org; Sun, 10 Jun 2018 13:32:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS4CW-00083A-Ob for submit@debbugs.gnu.org; Sun, 10 Jun 2018 13:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS4CQ-0001Lz-Cy for submit@debbugs.gnu.org; Sun, 10 Jun 2018 13:32:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55861) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fS4CQ-0001Lo-9D for submit@debbugs.gnu.org; Sun, 10 Jun 2018 13:32:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS4CO-00079V-UM for bug-guile@gnu.org; Sun, 10 Jun 2018 13:32:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS4CL-0001He-QR for bug-guile@gnu.org; Sun, 10 Jun 2018 13:32:16 -0400 Received: from defaultvalue.org ([45.33.119.55]:53674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS4CL-0001Gd-K2 for bug-guile@gnu.org; Sun, 10 Jun 2018 13:32:13 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 480D22008C; Sun, 10 Jun 2018 12:32:12 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id E970F14E550; Sun, 10 Jun 2018 12:32:11 -0500 (CDT) From: Rob Browning In-Reply-To: <152796556058.30262.13172727695488534983.reportbug@tatooine> References: <152796556058.30262.13172727695488534983.reportbug@tatooine> Date: Sun, 10 Jun 2018 12:32:11 -0500 Message-ID: <874liar1ic.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) It looks like gc.test may be failing intermittently in Debian (see below). Searching around I saw at least one other report of this in the #guile logs from last year. For now, I'm wondering if if would be plausible to mark the test as unresolved to avoid guile-2.2's removal from Debian testing, or if the failure is likely to indicate a problem serious enough to warrant that removal. Emilio Pozuelo Monfort writes: > Your package failed to build on armhf: > > Running gc.test > FAIL: gc.test: gc: after-gc-hook gets called > [...] > Totals for this test run: > passes: 40732 > failures: 1 > unexpected passes: 0 > expected failures: 10 > unresolved test cases: 578 > untested test cases: 1 > unsupported test cases: 1 > errors: 0 > > FAIL: check-guile > ================================== > 1 of 1 test failed > > > Full log at https://buildd.debian.org/status/package.php?p=guile-2.2 Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From unknown Sat Jun 14 00:08:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31776: guile-2.2: FTBFS on armhf: FAIL: gc.test: gc: after-gc-hook gets called Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 16 Jun 2018 22:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31776 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 31776@debbugs.gnu.org Cc: Emilio Pozuelo Monfort , 900652@bugs.debian.org, 900652-forwarded@bugs.debian.org Received: via spool by 31776-submit@debbugs.gnu.org id=B31776.152918682728439 (code B ref 31776); Sat, 16 Jun 2018 22:08:01 +0000 Received: (at 31776) by debbugs.gnu.org; 16 Jun 2018 22:07:07 +0000 Received: from localhost ([127.0.0.1]:52198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUJLf-0007Od-Df for submit@debbugs.gnu.org; Sat, 16 Jun 2018 18:07:07 -0400 Received: from defaultvalue.org ([45.33.119.55]:48796 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUJLe-0007OV-B5 for 31776@debbugs.gnu.org; Sat, 16 Jun 2018 18:07:06 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 8F9B62038F; Sat, 16 Jun 2018 17:07:05 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 2706214E550; Sat, 16 Jun 2018 17:07:05 -0500 (CDT) From: Rob Browning In-Reply-To: <874liar1ic.fsf@trouble.defaultvalue.org> References: <152796556058.30262.13172727695488534983.reportbug@tatooine> <874liar1ic.fsf@trouble.defaultvalue.org> Date: Sat, 16 Jun 2018 17:07:05 -0500 Message-ID: <87muvuwfli.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rob Browning writes: > It looks like gc.test may be failing intermittently in Debian (see below). > Searching around I saw at least one other report of this in the #guile > logs from last year. > > For now, I'm wondering if if would be plausible to mark the test as > unresolved to avoid guile-2.2's removal from Debian testing, or if the > failure is likely to indicate a problem serious enough to warrant that > removal. Just wanted to check back about this. It's caused a build on the buildds to fail again. Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From unknown Sat Jun 14 00:08:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31776: guile-2.2: FTBFS on armhf: FAIL: gc.test: gc: after-gc-hook gets called Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 19 Jul 2018 16:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31776 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 31776@debbugs.gnu.org Cc: Emilio Pozuelo Monfort , 900652@bugs.debian.org, 900652-forwarded@bugs.debian.org, guile-devel@gnu.org Received: via spool by 31776-submit@debbugs.gnu.org id=B31776.15320170019804 (code B ref 31776); Thu, 19 Jul 2018 16:17:01 +0000 Received: (at 31776) by debbugs.gnu.org; 19 Jul 2018 16:16:41 +0000 Received: from localhost ([127.0.0.1]:48459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgBbd-0002Y3-Ey for submit@debbugs.gnu.org; Thu, 19 Jul 2018 12:16:41 -0400 Received: from defaultvalue.org ([45.33.119.55]:47372 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgBbb-0002Xv-N7 for 31776@debbugs.gnu.org; Thu, 19 Jul 2018 12:16:40 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id E3D8F2017D; Thu, 19 Jul 2018 11:16:38 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 3B21D14E551; Thu, 19 Jul 2018 11:16:38 -0500 (CDT) From: Rob Browning In-Reply-To: <87muvuwfli.fsf@trouble.defaultvalue.org> References: <152796556058.30262.13172727695488534983.reportbug@tatooine> <874liar1ic.fsf@trouble.defaultvalue.org> <87muvuwfli.fsf@trouble.defaultvalue.org> Date: Thu, 19 Jul 2018 11:16:38 -0500 Message-ID: <878t67td3t.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rob Browning writes: > Rob Browning writes: > >> It looks like gc.test may be failing intermittently in Debian (see below). >> Searching around I saw at least one other report of this in the #guile >> logs from last year. >> >> For now, I'm wondering if if would be plausible to mark the test as >> unresolved to avoid guile-2.2's removal from Debian testing, or if the >> failure is likely to indicate a problem serious enough to warrant that >> removal. > > Just wanted to check back about this. It's caused a build on the buildds > to fail again. As an update, If we don't resolve this, guile-2.2 will be removed from Debian testing this weekend. Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From unknown Sat Jun 14 00:08:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31776: guile-2.2: FTBFS on armhf: FAIL: gc.test: gc: after-gc-hook gets called Resent-From: =?UTF-8?Q?G=C3=B6ran?= Weinholt Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 06 Aug 2018 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31776 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Rob Browning Cc: Emilio Pozuelo Monfort , 900652-forwarded@bugs.debian.org, guile-devel@gnu.org, 31776@debbugs.gnu.org Received: via spool by 31776-submit@debbugs.gnu.org id=B31776.153356168120976 (code B ref 31776); Mon, 06 Aug 2018 13:22:01 +0000 Received: (at 31776) by debbugs.gnu.org; 6 Aug 2018 13:21:21 +0000 Received: from localhost ([127.0.0.1]:42370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmfRp-0005SF-8S for submit@debbugs.gnu.org; Mon, 06 Aug 2018 09:21:21 -0400 Received: from iustitia.weinholt.se ([46.16.232.230]:44560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmfRm-0005S6-3t for 31776@debbugs.gnu.org; Mon, 06 Aug 2018 09:21:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=weinholt.se ; s=iustitia2012; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z5lqLyFWaROAQXZSmu86tSXWLrk2IB5S+9FikuaZ2fA=; b=LpS6dMO/+9mNpI8CQLnZGQ0lOG Qr/be5xMSAiUNrGnNZxayV3a8cQAwSWL1zC6brwYWtrLXDoZuiilQFS86Wr1OMAZYHzCK3l/PKSzj dT94QxH4+TivzaLV/DXWshu2ZyVjDUlNJGxpnRIHmXSxMp7k8p7fckdpwr7L9sy4Hli6HSNd4Qoyx fNXpMF9ZSslkoYFwFy3uxg2IBDYAlud3XSZhIyY8wLfmgtNTwa5jsQ3vtIqTRMOKONgVBkxut1hov obhwJdSvuJdWlSUsJrmFRyv6W97glKpgE/0IVAAjnX02578161NKVTexnOvpDgfx5bsLfAUsv+RoS jeWgQQcA==; Received: from uucp by iustitia.weinholt.se with local-bsmtp (Exim 4.89) (envelope-from ) id 1fmfRj-0006rv-W7; Mon, 06 Aug 2018 15:21:15 +0200 Received: from weinholt by teapot.weinholt.se with local (Exim 4.91) (envelope-from ) id 1fmfRG-0001Q0-B0; Mon, 06 Aug 2018 15:20:46 +0200 From: =?UTF-8?Q?G=C3=B6ran?= Weinholt References: <152796556058.30262.13172727695488534983.reportbug@tatooine> <874liar1ic.fsf@trouble.defaultvalue.org> <87muvuwfli.fsf@trouble.defaultvalue.org> <878t67td3t.fsf@trouble.defaultvalue.org> X-Hashcash: 1:20:180806:rlb@defaultvalue.org::1XOGNh67rYq+Pg/8:000000000000000000000000000000000000000000TxB X-Hashcash: 1:20:180806:pochu@debian.org::WMF+TTuVtCZPHzmf:02gON X-Hashcash: 1:20:180806:31776@debbugs.gnu.org::9NwCLDxyBqPBJyr4:00000000000000000000000000000000000000002M4e X-Hashcash: 1:20:180806:900652@bugs.debian.org::8RXtj55ZIEevhr9J:0000000000000000000000000000000000000007Smu X-Hashcash: 1:20:180806:guile-devel@gnu.org::Iu2BML0bZtTJTXKM:000000000000000000000000000000000000000000CZYW X-Hashcash: 1:20:180806:900652-forwarded@bugs.debian.org::6MCef6OhG7n1kd4B:00000000000000000000000000000Lru9 Date: Mon, 06 Aug 2018 15:20:32 +0200 In-Reply-To: <878t67td3t.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Thu, 19 Jul 2018 11:16:38 -0500") Message-ID: <87mutz4onz.fsf@teapot.weinholt.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rob Browning writes: > Rob Browning writes: > >> Rob Browning writes: >> >>> It looks like gc.test may be failing intermittently in Debian (see belo= w). >>> Searching around I saw at least one other report of this in the #guile >>> logs from last year. >>> >>> For now, I'm wondering if if would be plausible to mark the test as >>> unresolved to avoid guile-2.2's removal from Debian testing, or if the >>> failure is likely to indicate a problem serious enough to warrant that >>> removal. >> >> Just wanted to check back about this. It's caused a build on the buildds >> to fail again. > > As an update, If we don't resolve this, guile-2.2 will be removed from > Debian testing this weekend. Hello Rob, The test fails with 2.2.4+1-1 on amd64 as well: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/guile-2.= 2.html It's really tricky to get it to fail predictably, but you can even your odds by testing only asyncs.test and gc.test: apt-get source guile-2.2 cd guile-2.2-2.2.4+1 dpkg-buildpackage -us -uc mkdir test-suite/async-tests cp test-suite/tests/{asyncs,gc}.test test-suite/async-tests/ meta/guile --debug -L $PWD/test-suite --no-auto-compile \ -e main -s $PWD/test-suite/guile-test \ --test-suite $PWD/test-suite/async-tests \ --log-file check-guile-async.log Try the last command around a dozen times and it'll fail eventually. I didn't get further with debugging than determining that something probably goes wrong in the interaction between queue_after_gc_hook(), scm_i_async_push() and scm_i_async_pop(). Every time there was a failure, this condition was false (the cdr was set to empty list): if (scm_is_false (SCM_CDR (after_gc_async_cell))) { SCM_SETCDR (after_gc_async_cell, t->pending_asyncs); t->pending_asyncs =3D after_gc_async_cell; } Regards, =2D-=20 G=C3=B6ran Weinholt Debian developer 73 de SA6CJK --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEq+9SWYIFojDzWUBw933wfyFewnMFAltoSyAACgkQ933wfyFe wnNFoA//ZkY6Uu+1p5d7p71YHxHaEDhRqV7jTHGVbDYGCL6IGtisEej8ZwvFrcVW 6AO7eVoeCNz4oIbapA8uFRzWegHxu36h89Nlk/P8235ZJ0WVQNyvpNwnWUNg0H47 9lOfFaV2Qf7XFYPfXNuVUvTZu69sGY5hXis5uONv4iNXEVEVQ2n3WB/1Yex3n4dJ +vh8ZvAfjkMSn5vB7hjMk5YEpL5UTw/KNdZmE3sX2s5ZtcC30M4F9D14x9PagTaP fACcqN84QOo5bmjWe1RnGziSqbgPr1x2ixbWXV91R8nsuXbQing6WtPjS7o1pu5N laCnCPtEj9rUEqm4WhtUAaHPqczbR8LF3zr/zKn+XLCY+YDhtmITu1irCN1gwcDM AKgMEkf2dF0ASaf6ePmmEb0kKCx7E0bYnqcm3KGO/oVw0k27dMRdSdLvhns80KCq T0WMlYdokZP3rJC3evsqgVsa/WEslK96TMMJHeh87GckWcsIqPr+eONNNHazXDy+ OMMZQYmSl5hP8J37BNk+PcBM5E3CrsEnN+uEGRS2fX/I8U85nhR0E7zdV0Xpbaq4 gF/wgQYBkeABRhUdOnAyLJIAgeeem5or5oXIfkoYLAUQ/uff0p+7iPyu23WxZZes ZrncyXtM+ml0kTatjdimL6MCa6H77/s3b8X5wZi7L7uhfGwFvog= =d6H/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 14 00:08:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31776: [PATCH] Fix gc.test "after-gc-hook gets called" failures Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 16 Apr 2019 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31776 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Andrea Azzarone Cc: guile-devel@gnu.org, 31776@debbugs.gnu.org Received: via spool by 31776-submit@debbugs.gnu.org id=B31776.155545078123874 (code B ref 31776); Tue, 16 Apr 2019 21:40:02 +0000 Received: (at 31776) by debbugs.gnu.org; 16 Apr 2019 21:39:41 +0000 Received: from localhost ([127.0.0.1]:38576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGVnp-0006D0-70 for submit@debbugs.gnu.org; Tue, 16 Apr 2019 17:39:41 -0400 Received: from world.peace.net ([64.112.178.59]:42850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGVnn-0006Ce-VU for 31776@debbugs.gnu.org; Tue, 16 Apr 2019 17:39:40 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hGVnh-0006mM-VI; Tue, 16 Apr 2019 17:39:34 -0400 From: Mark H Weaver References: Date: Tue, 16 Apr 2019 17:38:00 -0400 In-Reply-To: (Andrea Azzarone's message of "Thu, 11 Apr 2019 16:43:23 +0100") Message-ID: <87k1ft6370.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andrea, Andrea Azzarone writes: > "after-gc-hook gets called" test randomly fails as reported > downstream, for example: > - https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31776 > - https://bugs.launchpad.net/ubuntu/+source/guile-2.2/+bug/1823459 > > I'm attaching a patch that seems to fix the failures. > > From 2efba337d5b636cd975260f19ea74e27ecf0ca17 Mon Sep 17 00:00:00 2001 > From: Andrea Azzarone > Date: Thu, 11 Apr 2019 16:30:58 +0100 > Subject: Fix gc.test "after-gc-hook gets called" failures > > * libguile/scmsigs.c: Call scm_async_tick to give any pending asyncs a chance to > run before we block indefinitely waiting for a signal to arrive. Thanks for this. I pushed your commit (with minor reformatting) to our 'stable-2.2' branch as commit 546b0e87294b837ec29164d87cf17102e9aeee0c. I believe that this will prevent the problem from happening in the most common cases, e.g. when there's only one user-visible thread, or when there are no long-sleeping user-visible threads. However, it occurs to me that in a multithreaded Guile program, a user thread might trigger a GC and then sleep for a long time, without calling 'scm_async_tick' in between. If we're unlucky and the 'after_gc_async' gets queued in the wrong thread, it might be a long time before the hook runs. Fundamentally, the problem we face here is similar to the thorny problems faced with finalizers and signal handlers: we must choose a proper time and context for them to be run safely, when the data they need to access is in a consistent state, etc. To deal with the issues around finalizers, Guile recently gained a finalizer thread. It may be that we should arrange to run the 'after_gc_async' in the finalizer thread as well, instead of whatever random thread we happen to be in when GC is triggered. Thoughts? Regards, Mark