GNU bug report logs - #31774
[PATCH] Add maven

Previous Next

Full log

Message #137 received at 31774 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 31774 <at> debbugs.gnu.org
Subject: Re: [bug#31774] [PATCH 12/22] gnu: Add maven-core.
Date: Sun, 10 Jun 2018 19:16:43 +0200

[Message part 1 (text/plain, inline)]

Hi Julien,

On Sun, 10 Jun 2018 13:03:09 +0200
Julien Lepiller <julien <at> lepiller.eu> wrote:

> +                ;; FIXME: This should be taken care of by plexus-component-metadata directly

Is this possible now?

> +                (invoke "sh" "-c"
> +                        (string-append
> +                          "(cat build/classes/META-INF/plexus/components.t.xml |"
> +                          "sed -e 's|</component-set>||' -e 's|</components>||' ; "
> +                          "cat src/main/resources/META-INF/plexus/artifact-handlers.xml |"
> +                          " sed -e 's|<?xml.*||' -e 's|<component-set>||' -e 's|<components>||'"
> +                          " -e 's|</component-set>||' -e 's|</components>||'; "
> +                          "cat src/main/resources/META-INF/plexus/components.xml |"
> +                          " sed -e 's|<?xml.*||' -e 's|<component-set>||' -e 's|<components>||'"
> +                          " -e 's|</component-set>||' -e 's|</components>||'; "
> +                          "cat src/main/resources/META-INF/plexus/default-bindings.xml |"
> +                          " sed -e 's|<?xml.*||' -e 's|<component-set>||' -e 's|<components>||' )>"
> +                          "build/classes/META-INF/plexus/components.xml"))

XML isn't really line-based, so using (sxml simple) to merge would be more reliable.
Error reporting would be better, too.

https://www.gnu.org/software/guile/manual/html_node/Reading-and-Writing-XML.html#Reading-and-Writing-XML

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.