From unknown Sat Jun 21 10:37:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31772 <31772@debbugs.gnu.org> To: bug#31772 <31772@debbugs.gnu.org> Subject: Status: 26.1; (thing-at-point 'list) regression Reply-To: bug#31772 <31772@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:37:35 +0000 retitle 31772 26.1; (thing-at-point 'list) regression reassign 31772 emacs submitter 31772 Leo Liu severity 31772 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 23:58:57 2018 Received: (at submit) by debbugs.gnu.org; 10 Jun 2018 03:58:57 +0000 Received: from localhost ([127.0.0.1]:41658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRrVJ-00039r-9I for submit@debbugs.gnu.org; Sat, 09 Jun 2018 23:58:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRrVH-00039d-6M for submit@debbugs.gnu.org; Sat, 09 Jun 2018 23:58:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRrVB-000793-5O for submit@debbugs.gnu.org; Sat, 09 Jun 2018 23:58:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fRrVB-00078x-1e for submit@debbugs.gnu.org; Sat, 09 Jun 2018 23:58:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRrV9-0003Mu-Ui for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 23:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRrV6-00077M-UR for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 23:58:48 -0400 Received: from mail-pl0-x22d.google.com ([2607:f8b0:400e:c01::22d]:38577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRrV6-00076l-NT for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 23:58:44 -0400 Received: by mail-pl0-x22d.google.com with SMTP id b14-v6so10436116pls.5 for ; Sat, 09 Jun 2018 20:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=XIrLC/UB/yGj82iiBAeRsaoXQOwVbu0/85Jd/h437Vo=; b=MxXSBJxdOtd11CRcCG/Ig6P/776Hk0WU6ybyc8Imp86iGw1iXeUf/I6eFc6nyKOJUa c/9ljhh+Losv2395nBWECm5Pcq6bkyaP/UkedeEw8lbR2GLaUp6l5FFBVMPzluask0Mt 99tzjtgYbG7HipwkT3QJ4xRYimx61rcszSwyzaruXuH/SHmugSUu5Q2TN6a/YKi+Qy6p nxovwgp3gGcqdGNWR3bTAj51/K1eYQ+IRtkOjTa5A3WxkL3pGg9LNU1bDQjR59f0r2fk 7K3Q2Lb1XfSvV3AgSQFAFoetgCWI5NaVoWJUdFlO2ks779nFTncpBqv4zuuzGm/nqBPQ +1GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=XIrLC/UB/yGj82iiBAeRsaoXQOwVbu0/85Jd/h437Vo=; b=MkT8eKzGG9a23WtnvT2afaMKqaIN/hyX9L8bbax2InQfsCTTmfmOs2JXUPcgfGJiNu GiPgt+y2JUoNOYccsiUjbDiLb8Hk4Ko33LpNULFFbrLePmBLuWc/ytFpbaWLS/1AW/xC Nwagb/BOvWzZ4jphzRCxdBMXsrjkkegxwVez/nGmn+p+GoKdWSD9aTcyRoX6SsayYfUw 6qXvP6GzOB2uX9ENS9O5qMsKsFZAsY0JaEYX50TrB1C/3a1MorNkbN25nwnr8ygwWjDa k/9UDRfpw4xHmcIbYm+IKdaZglAFFUr3is1o9piHJaacFtWiGXREHVKwZSQ+CbNJa/XF mXgw== X-Gm-Message-State: APt69E05kUlRQ67hNwr3I0GJg2+BOXqBKTJDR1UoJBTZNxcYwmwlEU11 dE7/Qd1YlaqMOuMlSMOWcnFpAA== X-Google-Smtp-Source: ADUXVKJLi8Bm6G45x7voQllihRzuqsbP8iuwV8RmPLmlizTwL82I+kY+gRDBCE0W2VsesXbxtVNIeg== X-Received: by 2002:a17:902:7688:: with SMTP id m8-v6mr13143119pll.54.1528603123179; Sat, 09 Jun 2018 20:58:43 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([119.94.238.191]) by smtp.gmail.com with ESMTPSA id u13-v6sm32146403pfh.147.2018.06.09.20.58.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 20:58:42 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 26.1; (thing-at-point 'list) regression X-Debbugs-CC: tino.calancha@gmail.com Date: Sun, 10 Jun 2018 11:58:39 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Due to change commit 76e297c15f6312a83599aab216be0396e9aac5c5 Author: Tino Calancha Date: Thu Nov 3 20:33:19 2016 +0900 (thing-at-point 'list) no longer works in comments; always return nil. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 11:03:56 2018 Received: (at 31772) by debbugs.gnu.org; 10 Jun 2018 15:03:56 +0000 Received: from localhost ([127.0.0.1]:42400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS1sq-0004UK-Db for submit@debbugs.gnu.org; Sun, 10 Jun 2018 11:03:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS1sp-0004U8-Es for 31772@debbugs.gnu.org; Sun, 10 Jun 2018 11:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS1sj-0004fe-LW for 31772@debbugs.gnu.org; Sun, 10 Jun 2018 11:03:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS1sf-0004eP-O6; Sun, 10 Jun 2018 11:03:45 -0400 Received: from [176.228.60.248] (port=4380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fS1se-0002WP-6e; Sun, 10 Jun 2018 11:03:45 -0400 Date: Sun, 10 Jun 2018 18:03:50 +0300 Message-Id: <838t7msmy1.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Sun, 10 Jun 2018 11:58:39 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Date: Sun, 10 Jun 2018 11:58:39 +0800 > Cc: tino.calancha@gmail.com > > Due to change > > commit 76e297c15f6312a83599aab216be0396e9aac5c5 > Author: Tino Calancha > Date: Thu Nov 3 20:33:19 2016 +0900 > > (thing-at-point 'list) no longer works in comments; always return nil. Should it? AFACS, in Emacs 25 the above returned nonsensical values when invoked inside Lisp comments. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 11:21:51 2018 Received: (at 31772) by debbugs.gnu.org; 10 Jun 2018 15:21:52 +0000 Received: from localhost ([127.0.0.1]:42440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS2AB-0004xA-MD for submit@debbugs.gnu.org; Sun, 10 Jun 2018 11:21:51 -0400 Received: from mail-pl0-f52.google.com ([209.85.160.52]:40283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS2AA-0004ww-9u for 31772@debbugs.gnu.org; Sun, 10 Jun 2018 11:21:50 -0400 Received: by mail-pl0-f52.google.com with SMTP id t12-v6so10869087plo.7 for <31772@debbugs.gnu.org>; Sun, 10 Jun 2018 08:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wcEqlZHobZ4JbVxi3ov5Jn7g9JktPJe8Zq+ykn3RXE4=; b=fW8CRiYVAd5JvkIvHzcbNTvyDgyCm8gzs5xja8IJr78SCpHEOjs0tPtWcy5Mx3+QDs YeGP+OQGPBUO1wYNYHbAkIo9xElvkKelOPZQYXodX+UyguBBiwukI5pItGdAffG2r0hn xL1uRSo1vly2mWFSek489ss5wQZSmrBBZ61MXrqWnQov4TomJ9+aWKJy+Ibmm9wTiNsR t6x0V3jo44KRcEAnJyHY/pvVjyqEcF/pe9HnKvB5QC5O6qrCLakevoGMj1K9RXABzeHn lEm1FQDMPp+kaR7L5IKuimPoMA0qwc456KiaCISi3ULYIOHIlN5Gn46UHHKIM6forXEw b1Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wcEqlZHobZ4JbVxi3ov5Jn7g9JktPJe8Zq+ykn3RXE4=; b=uW1Ay9cJDbFGMdpFbUOQalOQWVNyKx2ju8q8xyBCgmmwreMR7908xM8chf6FgvJSf8 6rYkc/k8gS7ilW4+6W3w4zNORr3E53cQwexMHpWHcMK3VuEoIad5gyOWxVYR1z2ga/ra htDhz+I/JIOFPHRAoblnrevUGs/Eo2VdJEFdSTj93uuf86wYI2+I9cbnBffzdt3GbuvX dBOKQ3FPA5HuY6kZdhTy2BzwyV2qXzszoUeiBFsWqdIyNlxt7rd0FLKp5Dq/HeqHzZ9a h87lORCfd92oFTv/O7EwlfetPP7/wcd/ozBoZFtLFmJWXnZFRpoUYv91t144hnoJE0D0 l3rg== X-Gm-Message-State: APt69E0W1gC8aX9EKCt+81KR5Do97JLk5PiszdvgRMhWNN+OEcdAsWLU wSyuQzYXYPH7VuoGo7JVy0U= X-Google-Smtp-Source: ADUXVKJVGMJtaY2m+cCs51rIwwIdkIn+YYpRTTGK+SeU8j2nN5qbjdhAlANe14N8hcBqGVAmEc8Zog== X-Received: by 2002:a17:902:7685:: with SMTP id m5-v6mr14856283pll.76.1528644104519; Sun, 10 Jun 2018 08:21:44 -0700 (PDT) Received: from calancha-pc (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id x3-v6sm58246916pfm.2.2018.06.10.08.21.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Jun 2018 08:21:43 -0700 (PDT) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> Date: Mon, 11 Jun 2018 00:21:35 +0900 In-Reply-To: <838t7msmy1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jun 2018 18:03:50 +0300") Message-ID: <87k1r6acqo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, Noam Postavsky , tino.calancha@gmail.com, Dmitry Gutov , Andreas =?utf-8?Q?R=C3=B6hler?= , Leo Liu , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Due to change >> >> commit 76e297c15f6312a83599aab216be0396e9aac5c5 >> Author: Tino Calancha >> Date: Thu Nov 3 20:33:19 2016 +0900 >> >> (thing-at-point 'list) no longer works in comments; always return nil. > > Should it? AFACS, in Emacs 25 the above returned nonsensical values > when invoked inside Lisp comments. [CC the relevant thingatpt experts] Initially I thought that; after discuss with Emacs colleages I changed my mine. If you are in a buffer in emacs-lisp-mode, I just see one list of length 3 in the following line: ("foo" "(bar)" "baz") "(bar)" is a string. If we comment the line, then there is no list at all; just a comment. That is tested in thingatpt-tests.el (thing-at-point-bug24627). You could change to fundamental-mode, then you would get again the full list: because the line is not commented anymore. To me this behaviour has sense, and it's predictible. Maybe others disagree. PD: I must admit I am a bit worry everytime we start discussing about this lib... :-S From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 22:32:27 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 02:32:27 +0000 Received: from localhost ([127.0.0.1]:42692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSCd8-0007Jn-Oh for submit@debbugs.gnu.org; Sun, 10 Jun 2018 22:32:26 -0400 Received: from mail-pl0-f54.google.com ([209.85.160.54]:42261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSCd5-0007JZ-Uy for 31772@debbugs.gnu.org; Sun, 10 Jun 2018 22:32:24 -0400 Received: by mail-pl0-f54.google.com with SMTP id w17-v6so11429473pll.9 for <31772@debbugs.gnu.org>; Sun, 10 Jun 2018 19:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=WLWLOUUyqPGeySdhKLyDdjOfvgvP1O9D/6ekEFVwC1g=; b=YPR9JOv3d7DdjkHtlrDKFMQwjKnobLuYgYHyFC1fzeca1rfaEhxOjAekfLfeV9/miv LZ39wO4XvdUTx2tZOAjjN/G14XNIa/85OP/O2amKbrPY0I0x5GmPj9NvJEyEbWST8rV6 TUDqhY6vaTocyldkMiYJJjyePGm2EMkIP9N5/0BEjewPo7o5ljTcMJma21xGb3kedp54 6FCdNWHGEE2Qq0CAXh8G9voI0wmxXqeismF/5gPASovYQfLX+itol1mtSlttiMqfzQrY 1HNaE/56k6Wn7wuRN1S4ZXFbuzB3niyCAQ/U2xlb6pyRlha6A0BlEkR8vrTRwPtizwLK +5Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=WLWLOUUyqPGeySdhKLyDdjOfvgvP1O9D/6ekEFVwC1g=; b=ueM0Twu+Rw2y7C2PuT5ADMy5bMHlKp81vxru/8A4rkCcimQo/4hxmnoaLkfvuoDCp9 8PVnVtXE2sMJellOSScSow7PDLPkhjF/JJLSuL81skNlCEJxvtkj6/YoNSKBxL/j/+nY FhZH36LTBlSPw1uZxPhAIRyqLK6XfhW/dGiJlSP+lfRQz68vMHbIV8tC8dKgphOibkc5 zifnhrOBKICbyOzH+pQ5FUol/oDGKUEvNbsNLxj6HEmYFLG4K3CvVH76lMsZeS2yvqNE wW/iuVZOn0GhtaalqEnNwO1Eji4GsEqIWIuCcprunikqkNHW3qwfSt1HROgxd8nQLYf8 nxKg== X-Gm-Message-State: APt69E1vIIHTnMv+y4xbx71eOAC9EusKki7s4ob3U4D56KORGd+pqAGX CP9gpV5dxPuNI7tSfleHXtg= X-Google-Smtp-Source: ADUXVKJ+DqAHqTQlbZsstBqxkFLLjy7ir+hghV2DlVAFOW9QNQ+LTBNo18eJoAYqlANe0qezQwqWEg== X-Received: by 2002:a17:902:bd05:: with SMTP id p5-v6mr5379047pls.32.1528684338137; Sun, 10 Jun 2018 19:32:18 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([119.94.238.191]) by smtp.gmail.com with ESMTPSA id s14-v6sm28615833pfh.116.2018.06.10.19.32.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Jun 2018 19:32:16 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Mon, 11 Jun 2018 10:32:14 +0800 In-Reply-To: <838t7msmy1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jun 2018 18:03:50 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-06-10 18:03 +0300, Eli Zaretskii wrote: > Should it? AFACS, in Emacs 25 the above returned nonsensical values > when invoked inside Lisp comments. I just checked it and seem to behave beautifully and usefully. What do you see that are nonsensical? Leo From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 23:17:19 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 03:17:19 +0000 Received: from localhost ([127.0.0.1]:42700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSDKZ-0008J2-5m for submit@debbugs.gnu.org; Sun, 10 Jun 2018 23:17:19 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:41234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSDKW-0008Io-Va for 31772@debbugs.gnu.org; Sun, 10 Jun 2018 23:17:17 -0400 Received: by mail-pg0-f45.google.com with SMTP id l65-v6so9047605pgl.8 for <31772@debbugs.gnu.org>; Sun, 10 Jun 2018 20:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=vzEjyd8R5EaWokv7Q34vwz0PD0OoYllzI81xIsgDcdg=; b=o1k36xV8oJTzKjWyNS8QSmVVgMMRWNFC61qkJfl0p6Ek7piA0O7YesfuMVbUXebx2/ wIab7KM1gH1rs7JPLjA0fJmFtgTwt7iXQfO1K1mGu+8k/RdLPFdsSZ2yyLlzk6/u2HSY K7qXZZhuu+qvXxVcH5tJxdwSkdHNuzRcuHFKjR5j41S7oWM/22UcmPRJtiin/bOba6L4 S2XlDRqHrdUOocPkkrKyp0bVazqW1L9dnh00h1QQs4EJSIVPIehs15Sps5KLr3D6NR/J egDgT9QGzydoBviGoV98Vjh4yaoAeqI67ZUyRrCXe7OZ07Rv1aUwcbG29DrTPZcxc7wA Gd9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=vzEjyd8R5EaWokv7Q34vwz0PD0OoYllzI81xIsgDcdg=; b=EVWfEAVrBgm76jwqcOIHVyVP2TJveKG5jt9qgQsox/3CgJe/m5gxxja966asugYWce xEWG/6/mVvHi59QOvkp0k3OSjGbS5Pnd0mElC9N9q6QeN2fqEwgHMw6r93qpQubF6kUa cRyt4G+rgTWGTK8jxikZIjvQ90ZbkOhVrlKWmBaEfVx6bckYaqOPNl8KKssF0Xs26h8E EWzsJFWYra6/L8YXq9xruR6PauhXEFWN7/E2svfcc+SDB9jUQ7Qp+/2Ia8HyqORtfhUt sQcsTqgI+ku+tbcmvosSUlJG6gvXW96h/sNUHDp8wyo9xvGdEH2sRVipVbZyjPXzDUB4 ky+Q== X-Gm-Message-State: APt69E18DWiD/gpywzQiU+4EsdPhx50pmR7FRaGJ6DnO3zDFF66wWpQP ztwRKeBN202VqMyZpzxHREc= X-Google-Smtp-Source: ADUXVKLhQAoTKB0uf/jMc/pRLvAcFaGk3WD5LVpSJ2f2spvrr2vaNaDF9btV0LJVT2EQ5BzCUaj2+Q== X-Received: by 2002:a63:6e4e:: with SMTP id j75-v6mr13162902pgc.125.1528687031284; Sun, 10 Jun 2018 20:17:11 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([119.94.238.191]) by smtp.gmail.com with ESMTPSA id n70-v6sm71528252pfh.140.2018.06.10.20.17.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Jun 2018 20:17:10 -0700 (PDT) From: Leo Liu To: Tino Calancha Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Mon, 11 Jun 2018 11:17:08 +0800 In-Reply-To: <87k1r6acqo.fsf@gmail.com> (Tino Calancha's message of "Mon, 11 Jun 2018 00:21:35 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: Eli Zaretskii , 31772@debbugs.gnu.org, Dmitry Gutov , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-06-11 00:21 +0900, Tino Calancha wrote: > Initially I thought that; after discuss with Emacs colleages > I changed my mine. > > If you are in a buffer in emacs-lisp-mode, I just see > one list of length 3 in the following line: > ("foo" "(bar)" "baz") > > "(bar)" is a string. I think you are solving the problem the wrong way. The original behaviour of (thing-at-point 'list) relied on up-list and is intuitive and sensible. After all who doesn't use up-list/down-list/kill-sexp etc. (thing-at-point 'list) is well-aligned with them simply by letting up-list do it. But the point is a decade-old function that is functional and used in people's init or packages are changed in drastically incompatible way. I noticed the issue only after upgrade to emacs 26.1 a few days ago and discovered https://github.com/leoliu/easy-kill/issues/28. *SIDE NOTE* One of the issues with Emacs development (I feel it more deeply after I changed to use stable releases), people (in most cases only 1 user) find some feature doesn't entirely suit their needs and they change it often without full-perspective how it is used. For emacs 26.1 I have at least three irritating annoyances (not counting crashes which are often beyond my reach) that I need to code away one way or another. Leo From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 10:59:04 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 14:59:05 +0000 Received: from localhost ([127.0.0.1]:43549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOHg-00012l-Lq for submit@debbugs.gnu.org; Mon, 11 Jun 2018 10:59:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOHe-00012H-PS for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 10:59:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOHY-0001Fi-Mu for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 10:58:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOHU-0001Di-QF; Mon, 11 Jun 2018 10:58:52 -0400 Received: from [176.228.60.248] (port=1989 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSOHU-0003xA-4r; Mon, 11 Jun 2018 10:58:52 -0400 Date: Mon, 11 Jun 2018 17:58:59 +0300 Message-Id: <83r2ldqsi4.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Mon, 11 Jun 2018 10:32:14 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com > Date: Mon, 11 Jun 2018 10:32:14 +0800 > > I just checked it and seem to behave beautifully and usefully. What do > you see that are nonsensical? In "emacs -Q", go to the 'h' in "that" on the first line, and then: M-: (thing-at-point 'list) RET => #("hat" 0 3 (fontified nil face font-lock-comment-face)) That's not even a word, let alone a list. Is that useful? I think nil is more useful, since nothing should be a list inside a comment. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 11:06:40 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 15:06:40 +0000 Received: from localhost ([127.0.0.1]:43553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOP2-0001Dz-Ey for submit@debbugs.gnu.org; Mon, 11 Jun 2018 11:06:40 -0400 Received: from mail-pl0-f44.google.com ([209.85.160.44]:38381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOP1-0001Dn-2v for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 11:06:39 -0400 Received: by mail-pl0-f44.google.com with SMTP id b14-v6so12505559pls.5 for <31772@debbugs.gnu.org>; Mon, 11 Jun 2018 08:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=I8ZKu93lsbepXId8c61hjhteY+Odtyol+CVGhkGNnYY=; b=Ty8VWdUL3lOgdfsC4oG3O5Y6vhKFlJfGTSuImTetj9bXn+jrwvKjiQGPjMivZfuQ+V StMQEQSNk/jCbaLKgDgmZ9vYI5vEV4hXmD2GEQloq5Z9JriCJ0OWxhsuy5qQLh8WHtRn GJYw+D81/RUSEzY694pVg38aSaGLRwN1c3oB7tsmbkI8aMPDKY6aBw7tcdKg/1zsV2K+ xYyKCoHuLBkLQ/w/RF/+ge+jdDbpHvoSQPiuquMDBttbyRBX+AcBQvupS4pmzdO6dUC4 RrC6yzYjYtmPDRRoTQiBijxTJ7C2b6nmXiK018glG8coLVUca3faiWvWKYHlTi3NKkwv OE2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=I8ZKu93lsbepXId8c61hjhteY+Odtyol+CVGhkGNnYY=; b=pCQFdCMSq/R0BQChmsBk4dhzmhos2ueoOiOQzzC6e9fncSIMJQbtKIJCVrCydVHQ7h lCWMnUvvgb8HuZ+JOa/PTC3JyMRnvOr+X2DvugT05wchXyxXfKjnM/VELbDCB2OmyZIf K/uldA/AX3ykYufu6kUexC/OXxUF7aCaYsDBNqSHGuPld7gtmpv77E1mIHzlP7AgU80J IaY6/qrdJCTEh0SQT1lO5yrqnnmVS8pbFAJMBP4Cf9uTNJD89SjH5eh0+Z/wRRmW1pvE 1vyjxw5VKwAb4LH0RxAXfTXcg//Ke4FwWnlZvyYB7SfyX2kYKUzOgGoddc91Fk1E5FY5 2UWA== X-Gm-Message-State: APt69E2SVIL4jjwFXdxt5UaGESV/0Dv6kgbaiyO9knafsNRKKVjYyoMI Hw7Qc8UmPFg/XECnZRS4UlI= X-Google-Smtp-Source: ADUXVKKWK0zPY3xfeLEvXab8vz7pJw0e5qX642XbuCYkpTE8pIiOjk8cwtThlO1S9qoZSl/6f8Bm0A== X-Received: by 2002:a17:902:22cc:: with SMTP id o12-v6mr19242473plg.38.1528729593029; Mon, 11 Jun 2018 08:06:33 -0700 (PDT) Received: from calancha-pc (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id b2-v6sm85754705pfc.44.2018.06.11.08.06.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 08:06:32 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 12 Jun 2018 00:06:29 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Leo Liu Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression In-Reply-To: Message-ID: References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: Noam Postavsky , Eli Zaretskii , 31772@debbugs.gnu.org, Dmitry Gutov , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 11 Jun 2018, Leo Liu wrote: > *SIDE NOTE* > > One of the issues with Emacs development (I feel it more deeply after I > changed to use stable releases), people (in most cases only 1 user) find > some feature doesn't entirely suit their needs and they change it often > without full-perspective how it is used. For emacs 26.1 I have at least > three irritating annoyances (not counting crashes which are often beyond > my reach) that I need to code away one way or another. Thank you Leo, Since you seem a skilled Emacs user, you are very welcome to join us, all-volunteer Emacs developers, to keep improving Emacs and delight us with a 'full-perspective how to use it'. Honestly, I am really looking forward to you join us. I wish all the Emacs users happy. That would be awesome. Feel free also to propose any patch on this issue and discuss it here. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 11:11:03 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 15:11:03 +0000 Received: from localhost ([127.0.0.1]:43558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOTH-0001K5-2R for submit@debbugs.gnu.org; Mon, 11 Jun 2018 11:11:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSOTF-0001Ja-M1 for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 11:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOT6-0006fc-CW for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 11:10:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOSl-0006V1-Io; Mon, 11 Jun 2018 11:10:31 -0400 Received: from [176.228.60.248] (port=2003 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSOSk-0002Gj-Un; Mon, 11 Jun 2018 11:10:31 -0400 Date: Mon, 11 Jun 2018 18:10:38 +0300 Message-Id: <83po0xqryp.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Mon, 11 Jun 2018 11:17:08 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: npostavs@users.sourceforge.net, 31772@debbugs.gnu.org, dgutov@yandex.ru, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: Eli Zaretskii , 31772@debbugs.gnu.org, Noam Postavsky , Dmitry Gutov > Date: Mon, 11 Jun 2018 11:17:08 +0800 > > > If you are in a buffer in emacs-lisp-mode, I just see > > one list of length 3 in the following line: > > ("foo" "(bar)" "baz") > > > > "(bar)" is a string. > > I think you are solving the problem the wrong way. The original > behaviour of (thing-at-point 'list) relied on up-list and is intuitive > and sensible. But up-list signals an error in the comment in *scratch*, for example, so I'm not sure what consistency are we talking about here. > But the point is a decade-old function that is functional and used in > people's init or packages are changed in drastically incompatible way. I > noticed the issue only after upgrade to emacs 26.1 a few days ago and > discovered https://github.com/leoliu/easy-kill/issues/28. > > *SIDE NOTE* > > One of the issues with Emacs development (I feel it more deeply after I > changed to use stable releases), people (in most cases only 1 user) find > some feature doesn't entirely suit their needs and they change it often > without full-perspective how it is used. That's unfair, to say the least. During the entire development of Emacs 26, there was a conscious effort to avoid backward-incompatible changes as much as possible, and in many cases leave an option behind that would get previous behavior, sometimes people felt it was too zealous. Yes, several incompatible changes might have fallen through the cracks, but if you think it's too much, please consider being more active on the development list, and make sure your voice is heard when these decisions are made. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 12:08:39 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 16:08:39 +0000 Received: from localhost ([127.0.0.1]:43595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPN1-0004dl-CD for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:08:39 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:32801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPMz-0004dY-OF for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 12:08:38 -0400 Received: by mail-pf0-f182.google.com with SMTP id b17-v6so10487651pfi.0 for <31772@debbugs.gnu.org>; Mon, 11 Jun 2018 09:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=/KQF3ZU2D153VaJauIJ9pA160qGPgolAr0uwmw3DTd0=; b=LjiXZvdKMHSN0hTQg8jIclokACHlv6uaHPRrMrDhjokhlLtLnAPa2eZUcnx38voIe+ mhqT7vPZ8lpC6cg4UUKEM9pkK82+pTCbHL4T7QytQFfZTHo6+zqZDx5U7Ix4/JCD8jJQ B7udM1IcYTTb2TUGoIFbrr+RWx/jLgIOCqdc5sA7Ulfv27u1TP6Ma1ukVQakEx6RuE+2 5rSNG/vesfOFRDlZHbv9as1BONVHm5xdzSx4iyzEiau3RcsLmqO1r+0MsjclYUbp2y1y jV0xwLkp1WHQexgjY7eNHCs7PnsNvlbEihbqRszPJu3X9NxMtSJi0k8f3UaxaqNaHhXF LswA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=/KQF3ZU2D153VaJauIJ9pA160qGPgolAr0uwmw3DTd0=; b=hgbfxgy/IryRUNT+fY2Fg403PpTd/jE3JbeDikC43httHOkGYF1NVL5y6DNzymZgnI 7CU0nONqoJtuF0Ejs3+V4mCpCmXaoH2F8N6HSB+3S3Pjysd8litvj9alGPsplChA83N/ gw4fz0Pm9kClRG0U+YF0OFjRI+LUp2tSYSQU8uiVWmHNetkpkzIkJFY9uoO4s2pnTAqg VPY6PNNem69Pui7l7zF6YE1FjD7TGfIA9lK0xoQqfBgP+vAExff5QbJFt5sJk5vCXfpT GHKFId75nIeBoE6oVRPc8Tez+KhVl0xU2BhcPGaCeszEG+QMbHrKmZh6GN1h6vZUYbll FwmA== X-Gm-Message-State: APt69E2ZWPBWxfWuUxLMq1A36o9QKeqnlAQJsVgNwEhiYPN7LVpjxHG9 EUBSEzRDW1Paa6M6PgfLx1c62A== X-Google-Smtp-Source: ADUXVKIEvULGsTgKLY6OX5NXvgQ6wN5zewWM1vySi6l1oXw0K+YfoNrqfjDpMbOyQYIZSDjwMIlSVQ== X-Received: by 2002:a62:c918:: with SMTP id k24-v6mr18212515pfg.160.1528733311706; Mon, 11 Jun 2018 09:08:31 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([119.94.238.191]) by smtp.gmail.com with ESMTPSA id 10-v6sm48398797pfs.111.2018.06.11.09.08.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 09:08:30 -0700 (PDT) From: Leo Liu To: Tino Calancha Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Tue, 12 Jun 2018 00:08:27 +0800 In-Reply-To: (Tino Calancha's message of "Tue, 12 Jun 2018 00:06:29 +0900 (JST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-06-12 00:06 +0900, Tino Calancha wrote: > Since you seem a skilled Emacs user, you are very welcome to join us, > all-volunteer Emacs developers, to keep improving Emacs and delight us > with a 'full-perspective how to use it'. No one has a full-perspective. We all work with our partial perspective. That's not an issue. I am simply pointing out the irony it only takes one complaint to change something that's in Emacs for a long time but we often forget the majority that are happy with the feature never come and tell us from time to time what a great feature it is, they love it and don't change it. For example, a lot of lisp programmers use paredit (not part of emacs). Two or three major releases ago, the syntax of @ in (emacs-)lisp mode was changed so that some unusual function names containing ,@ could fontify properly, in doing so typing `,@(' in paredit gives you `,@ ()' instead of `,@()'. > Honestly, I am really looking forward to you join us. I wish all the > Emacs users happy. That would be awesome. I already joined in but I am a little short of time lately. Leo From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 12:25:25 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 16:25:25 +0000 Received: from localhost ([127.0.0.1]:43609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPdE-00053m-BQ for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:25:25 -0400 Received: from mail-pl0-f44.google.com ([209.85.160.44]:44720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPdC-00053Z-S3 for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 12:25:23 -0400 Received: by mail-pl0-f44.google.com with SMTP id z9-v6so12618660plk.11 for <31772@debbugs.gnu.org>; Mon, 11 Jun 2018 09:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=48SoFHOGxBK9NFQ/2Ho4czoZkoAyUI1TkzwqGffHAk0=; b=tj7ZjLXdr0pSGXkkA9wZs16BYU84EFDLUB3QasVhiU6wPJKcRI9eVImsBefRsIM1tr YEEta7f9w+XOzcMqFgBcTiOlrS5TSD5jsT0oS22uyHmQ+aH+Qzj6v3e9DcQ7RIzDNcSI 8GIvNDzVMxdIY4Cm5uoj15ZjbHCN79F28nW3q0r/T8l4ot183qcbVVPKW1FCC+PAoolA +DfabUdIdGjvXmC399EkhPUJ+53f57okOXqdEUMSTfFxTXnSikTL2JB8d3lYU3bWGIRh UWaMewnjg1Zq0HqzWCcBHJBRaxgtjwqGOjNOMokV2zio71JAf4HKnIPkQv7q4+jDEGrc Iyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=48SoFHOGxBK9NFQ/2Ho4czoZkoAyUI1TkzwqGffHAk0=; b=ty410mdLwF2Pdzv6oKD+EQwnbN/uX8skq9c8GkVqdr/pmJA90UoKIwKz9Uv4TxYCIF 3mRJcgxrP12PQygbWLDrBHs4tQ/Y5iNaLK7lKrcs0MQ6Nm8DXc1Oouh4fKpsCDSfjmbo 5gECirGGW2u2oYjd/w50Y39yOo5TFDTt3hBIzjy+8CwFIqBqHmS1gxenNUMi49DCulM1 4ujZQdBGEsYBFUxr2UgNpLyXA6IHd6qcooxq6P5Kwdr7R2h9PFNhXAOAq5rZkia0s/cg /KtP3gry5XfK9G2cTXAIV1eOJmMBlUA6STBkKXjLgUXLODp7ZiHocaAkdZUX8//o3HiP UsuA== X-Gm-Message-State: APt69E2Z9vtXsmahqa/AFeOJAmGh4BPPLzH9OmvNKDAkhE2wRKfh1d+N 9Q/345CqA/hin9LOghvQ6WM= X-Google-Smtp-Source: ADUXVKKOVZvFhKEuciMB6yDA2cZbRHA1SvudMK3wU0yMD04+o60zjUIk5Q7qX7AT22CqbyN/VkRI4w== X-Received: by 2002:a17:902:d716:: with SMTP id w22-v6mr19134393ply.98.1528734316952; Mon, 11 Jun 2018 09:25:16 -0700 (PDT) Received: from calancha-pc (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id u1-v6sm41820005pfn.59.2018.06.11.09.25.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 09:25:16 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 12 Jun 2018 01:25:12 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Leo Liu Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression In-Reply-To: Message-ID: References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: Eli Zaretskii , Noam Postavsky , 31772@debbugs.gnu.org, Dmitry Gutov , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 12 Jun 2018, Leo Liu wrote: > On 2018-06-12 00:06 +0900, Tino Calancha wrote: >> Since you seem a skilled Emacs user, you are very welcome to join us, >> all-volunteer Emacs developers, to keep improving Emacs and delight us >> with a 'full-perspective how to use it'. > > No one has a full-perspective. We all work with our partial perspective. > That's not an issue. I am simply pointing out the irony it only takes > one complaint to change something that's in Emacs for a long time but we > often forget the majority that are happy with the feature never come and > tell us from time to time what a great feature it is, they love it and > don't change it. > > For example, a lot of lisp programmers use paredit (not part of emacs). > Two or three major releases ago, the syntax of @ in (emacs-)lisp mode > was changed so that some unusual function names containing ,@ could > fontify properly, in doing so typing `,@(' in paredit gives you `,@ ()' > instead of `,@()'. You are not alone. This also happen to me. For example, Dmitry makes obsolote (to be more precise rebind Q to a new command) `dired-do-query-replace-regexp'. I like this command very much. I still use it and don't understand why it shouln't been bind by default to the classical Q. But it's also true that I wasn't collaborating with Emacs at the time that change was made. This people spent their free time to make Emacs great for free. I really thanks them so much, that I became one of them. I cannot blame Dmitry, just thanks him for his great contributions to the project and time invest on it. I think he is awesome, as all Emacs guys. >> Honestly, I am really looking forward to you join us. I wish all the >> Emacs users happy. That would be awesome. > > I already joined in but I am a little short of time lately. Oh so sad to heard that. I understand the work is the more important. That been said, if you can find some time in the future in your weekends, or just read the Emacs devel list, or the bug list and speak up when the people are asking for opinions, I would be very happy to listen your feedback. At the end we all want to make Emacs better and better. That's the only goal. We all love Emacs, right? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 12:34:45 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 16:34:45 +0000 Received: from localhost ([127.0.0.1]:43614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPmH-0005I7-FN for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:34:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPmG-0005Hv-F1 for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 12:34:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPm8-0004Z5-27 for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 12:34:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPm7-0004Ym-Vt; Mon, 11 Jun 2018 12:34:36 -0400 Received: from [176.228.60.248] (port=2164 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSPm7-0006km-B6; Mon, 11 Jun 2018 12:34:35 -0400 Date: Mon, 11 Jun 2018 19:34:42 +0300 Message-Id: <83a7s1qo2l.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Tue, 12 Jun 2018 00:08:27 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Date: Tue, 12 Jun 2018 00:08:27 +0800 > Cc: 31772@debbugs.gnu.org > > I am simply pointing out the irony it only takes one complaint to > change something that's in Emacs for a long time but we often forget > the majority that are happy with the feature never come and tell us > from time to time what a great feature it is, they love it and don't > change it. No, we never forget that. And one complaint is usually not enough to make such changes. on the contrary, sometimes the disputes about such complaints are too long and exhaustive. You can see many examples of that in the archives and on the bug tracker. But yes, the number of people here is relatively small, so each voice counts. Please be sure to voice yours, I'm certain it will have a significant effect on the outcome. > I already joined in but I am a little short of time lately. We all are. Thanks in advance for your contributions, both in opinions and in code. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 12:36:27 2018 Received: (at submit) by debbugs.gnu.org; 11 Jun 2018 16:36:27 +0000 Received: from localhost ([127.0.0.1]:43618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPnu-0005Kv-QJ for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:36:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSPnt-0005Kj-Bf for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:36:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPnn-0005WJ-Bd for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:36:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44489) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSPnn-0005WF-7i for submit@debbugs.gnu.org; Mon, 11 Jun 2018 12:36:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPnk-0002Yj-JE for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 12:36:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPnh-0005TQ-EE for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 12:36:16 -0400 Received: from [195.159.176.226] (port=53169 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSPnh-0005Rs-6k for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 12:36:13 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fSPlW-00078D-Pm for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 18:33:58 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression Date: Tue, 12 Jun 2018 00:36:00 +0800 Lines: 21 Message-ID: References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83po0xqryp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Cancel-Lock: sha1:zx8MCZgogfynv97BcVNKoumYfbM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) On 2018-06-11 18:10 +0300, Eli Zaretskii wrote: > But up-list signals an error in the comment in *scratch*, for example, > so I'm not sure what consistency are we talking about here. If you have a line of lisp code that is commented out, up-list/down-list behave just as well. If there is no list it signals an error. I think it has been like that for ages. > That's unfair, to say the least. During the entire development of > Emacs 26, there was a conscious effort to avoid backward-incompatible > changes as much as possible, and in many cases leave an option behind > that would get previous behavior, sometimes people felt it was too > zealous. Yes, several incompatible changes might have fallen through > the cracks, but if you think it's too much, please consider being more > active on the development list, and make sure your voice is heard when > these decisions are made. Sorry. After sending the email I also felt it might be a bit negative. I have sent another email just now to elaborate on what I meant. Leo From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 13:05:01 2018 Received: (at 31772) by debbugs.gnu.org; 11 Jun 2018 17:05:01 +0000 Received: from localhost ([127.0.0.1]:43635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQFY-000607-Ky for submit@debbugs.gnu.org; Mon, 11 Jun 2018 13:05:00 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQFW-0005zt-Gw for 31772@debbugs.gnu.org; Mon, 11 Jun 2018 13:04:58 -0400 Received: by mail-pf0-f170.google.com with SMTP id c22-v6so10156060pfi.2 for <31772@debbugs.gnu.org>; Mon, 11 Jun 2018 10:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=xarcMPkPA4eEJZzPw/qJs/pBREIKmHdt/mmMIhsY4DQ=; b=tny6cLRpJlM+5S2OnkYKuebCsvN6iq+0wTS9gNFB8pk/nkZa/0l5HW10ZWhzfZkJBG 5PG2EMatmHZg2lxj8OdTUDSf7CPyKgKlpJZI/s4Es28co/r/uL8UJ19vNm03r/l04c/p Uk6mHe8xmMQAOgqMNwTXeNnlkxmqnqnmW768Od8mQxpcG0fvWJsArM7i1tHVLpGelNyc MiEjm2PDvVy1RpRgrlVOatMq+jRjYEXNo3k2euUQwGnma2xUk9vlXkglfRQe1TDOHuMf Zz4EjotMPrnj/XrTuk/Ori3NnI+f66QtmhutLCAsudwJYIvmOQvr4ZWb/ug0vMuzyq9x gIOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=xarcMPkPA4eEJZzPw/qJs/pBREIKmHdt/mmMIhsY4DQ=; b=AOcIbicHm4LMv6USBCTz69T91O52PiwIleOxoX6t2e6fiV0qJaJ2Pe1DtIen/qYlET vX9GMpHNWGDKM3BVWHVkjqWLPuuS3tKBowfV5fzqRSyPR7yNhc2agDvcjFLjpOyWMG7a 2Y4GA6PL57gSIOKMj5/uN2qev5HmK3STyrqhLClbjxNsrjXh2T3cuUK0NcV8N6rmngAI BDNBEirSAiSPGzTt5dxHWcUviRF6/09tGTWEfXKaoVrvSIKX7d90tcY3n97YRJREuhSo Ezman2ILnQWiaR6KHl9ZUgOA52u3lJUsRAZyf0ZIdL5R6hIAFcQaZTKzBVVSCqxGMJMH g6Cg== X-Gm-Message-State: APt69E2Dv+zksX0pij99M2+6ISl9VwoCwY3K8UJ/Bxg1+ZdsHlTUiK10 n7pRrE3Sv316Ida2Kxr3SDY= X-Google-Smtp-Source: ADUXVKJuLEfxC+1JrJz99GXG4E2SEIjkfJDQEYRTtlis45NIQNf9D3Q1T65XceYX8vDHNbQVUcl0Vg== X-Received: by 2002:a62:660a:: with SMTP id a10-v6mr26000pfc.156.1528736692854; Mon, 11 Jun 2018 10:04:52 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([119.94.238.191]) by smtp.gmail.com with ESMTPSA id w1-v6sm83163000pgp.3.2018.06.11.10.04.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 10:04:51 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <83r2ldqsi4.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Tue, 12 Jun 2018 01:04:48 +0800 In-Reply-To: <83r2ldqsi4.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Jun 2018 17:58:59 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-06-11 17:58 +0300, Eli Zaretskii wrote: > In "emacs -Q", go to the 'h' in "that" on the first line, and then: > > M-: (thing-at-point 'list) RET > => #("hat" 0 3 (fontified nil face font-lock-comment-face)) > > That's not even a word, let alone a list. Is that useful? I think > nil is more useful, since nothing should be a list inside a comment. I have noticed this while coding easy-kill since it built on thingatpt.el. It was of minor annoyance so I ignored it. It seems to make a lot of sense to fallback on `sexp' as a degenerated case. Do you agree the previous behaviour of (thing-at-point 'list) is mostly sane? Additional points. show-paren-mode works inside comments and strings. One of the craziest things it does is if you have open paren in one string and a close paren in another, it works too. characters in and out of comments usually have the same syntax. so finding a list in comments or strings is not wrong. It's smart and it's useful. It serves us very well. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 06 06:37:25 2018 Received: (at 31772) by debbugs.gnu.org; 6 Sep 2018 10:37:25 +0000 Received: from localhost ([127.0.0.1]:47708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxrfA-0007l5-8x for submit@debbugs.gnu.org; Thu, 06 Sep 2018 06:37:25 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:37989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxrf7-0007kr-Ig for 31772@debbugs.gnu.org; Thu, 06 Sep 2018 06:37:22 -0400 Received: by mail-pl1-f169.google.com with SMTP id u11-v6so4788045plq.5 for <31772@debbugs.gnu.org>; Thu, 06 Sep 2018 03:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=lR3dKhVExgtMSo3wc3q/QZL+EvctYIK9RK+xzFvb6QQ=; b=UZ91EBlS0wBPXFm7rYlMaNP5mOCwDOwCAXuUO522/6leeF/hZFPXhg8hoqxt1nyp8s MKArFmrAz9/IK65c+vTdLdamUJZLXv5NJASRmJDCLp8+weUogK00q98vF6K5ooW192jf PT3pkSCY4Yw13UuTKZQkk/zFrWlxUhTtyrvikCUPGfrVvldSvspjWHlTcdLxZIzwfqlv 2urM7lTj0j7hfhybasJKS134J8Qex+Tzfrbk98FJ6Yr2HGuVpXHaq4kY61X1Dj+IHtmU Qbu5xVQE+YuxhiPX3K6LVVvDVKkEXAQU1Wb5IUSSwtYCzuY2VA+Tj3OBnbyJsJEtsztH l8MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=lR3dKhVExgtMSo3wc3q/QZL+EvctYIK9RK+xzFvb6QQ=; b=hndqbcZLGYOmnL1a7kWsY171MjrEkm3QhwQQK5P//cPh97mvtJyhATmpoKqErjyzXf iaVenrWuDiD/OJx+6RQKpSWNfvnXnGci0RkyQV+NE9fhw8li5C+vBw/U8Stdwb8Yzu/y DCjJGEFt5x18pzfLQUWhQxFO51LEQ4DlKMiMmBoFSlLxLI7xFdTN0rWTroxZqsplXSAU lr6kMZee1O4aRJDfPvsYVcpli+ODH5jHfEeLfYQfT+FMItMmykBPtr5mxvxYQHnrhHjc CEJjaAeGCiDaJSIVrawW54uZOP5A64Lslf8AZlFpSr+p74w1/ZwA6acNTfkvr3dlCrg/ mlFw== X-Gm-Message-State: APzg51AfgQHbu4UEh98gQc2FSmVQNJL3XQwd8KqG+3dnQkmF7vEUvqcs LqxzFHor2gkN52JtYKnxQ8I= X-Google-Smtp-Source: ANB0VdaiZ9hnXi0Kt3QmLS6SGV+W+HCG87WRs6ZgicMoRW8f9hR+KtcBgwQV1gRKdawUBE6eQtisWg== X-Received: by 2002:a17:902:b40c:: with SMTP id x12-v6mr1979263plr.163.1536230235541; Thu, 06 Sep 2018 03:37:15 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.219.22]) by smtp.gmail.com with ESMTPSA id k69-v6sm4797747pgd.9.2018.09.06.03.37.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Sep 2018 03:37:14 -0700 (PDT) From: Leo Liu To: 31772@debbugs.gnu.org Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Thu, 06 Sep 2018 18:37:11 +0800 In-Reply-To: (Tino Calancha's message of "Tue, 12 Jun 2018 01:25:12 +0900 (JST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: Eli Zaretskii , Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi there, I have been using 26.1 as my main editor for the last few months and this breakage remains a pain point in my day-to-day editing. For example whenever I rewrite a function, I normally comment out the old one (to keep the linter, pretty-printer or whatnot happy) and write the new one from scratch, occasionally copy things from the old one to save typing and this bug gets in the way many times a day. I propose a patch that doesn't divert too much from the old and tried behaviour. The idea that is currently in thing-at-point-bounds-of-list-at-point is fine for a higher level function such as list-at-point but doing it there affects all functions that build on it including some from thingatpt.el itself. I hope you can find time to review the patch and come to a solution for 26.2 which I very much look forward to. Thanks, Leo --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=thing.diff Content-Description: thing.diff diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 6a978fe9..8da31a03 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -221,15 +221,12 @@ The bounds of THING are determined by `bounds-of-thing-at-point'." "Return the bounds of the list at point. \[Internal function used by `bounds-of-thing-at-point'.]" (save-excursion - (let* ((st (parse-partial-sexp (point-min) (point))) - (beg (or (and (eq 4 (car (syntax-after (point)))) - (not (nth 8 st)) - (point)) - (nth 1 st)))) - (when beg - (goto-char beg) - (forward-sexp) - (cons beg (point)))))) + (if (ignore-errors (up-list -1)) + (ignore-errors (cons (point) (progn (forward-sexp) (point)))) + (let ((bound (bounds-of-thing-at-point 'sexp))) + (and bound + (<= (car bound) (point)) (< (point) (cdr bound)) + bound))))) ;; Defuns diff --git a/test/lisp/thingatpt-tests.el b/test/lisp/thingatpt-tests.el index cfb57de6..6093c209 100644 --- a/test/lisp/thingatpt-tests.el +++ b/test/lisp/thingatpt-tests.el @@ -84,20 +84,18 @@ position to retrieve THING.") (goto-char (nth 1 test)) (should (equal (thing-at-point (nth 2 test)) (nth 3 test)))))) -;; These tests reflect the actual behavior of -;; `thing-at-point-bounds-of-list-at-point'. -(ert-deftest thing-at-point-bug24627 () - "Test for https://debbugs.gnu.org/24627 ." +;; See bug#24627 and bug#31772. +(ert-deftest thing-at-point-bounds-of-list-at-point () (let ((string-result '(("(a \"b\" c)" . (a "b" c)) - (";(a \"b\" c)") + (";(a \"b\" c)" . (a "b" c)) ("(a \"b\" c\n)" . (a "b" c)) - ("\"(a b c)\"") + ("\"(a b c)\"" . (a b c)) ("(a ;(b c d)\ne)" . (a e)) - ("(foo\n(a ;(b c d)\ne) bar)" . (a e)) + ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar)) ("(foo\na ;(b c d)\ne bar)" . (foo a e bar)) - ("(foo\n(a \"(b c d)\"\ne) bar)" . (a "(b c d)" e)) - ("(b\n(a ;(foo c d)\ne) bar)" . (a e)) - ("(princ \"(a b c)\")" . (princ "(a b c)")) + ("(foo\n(a \"(b c d)\"\ne) bar)" . (foo (a "(b c d)" e) bar)) + ("(b\n(a ;(foo c d)\ne) bar)" . (b (a e) bar)) + ("(princ \"(a b c)\")" . (a b c)) ("(defun foo ()\n \"Test function.\"\n ;;(a b)\n nil)" . (defun foo nil "Test function." nil)))) (file (expand-file-name "lisp/thingatpt.el" source-directory)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 06 14:57:59 2018 Received: (at submit) by debbugs.gnu.org; 6 Sep 2018 18:57:59 +0000 Received: from localhost ([127.0.0.1]:48382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxzTb-0005qZ-CW for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxzTZ-0005qL-LE for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxzTT-0005nn-Ha for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxzTT-0005nF-Cp for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxzTS-00023j-HC for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:57:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxzTP-0005i6-8F for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:57:50 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:57167) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxzTO-0005eq-Tp for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:57:47 -0400 Received: from [192.168.178.35] ([188.102.48.98]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id 0Mgrp6-1gB6Vr3xlQ-00M3zC; Thu, 06 Sep 2018 20:57:44 +0200 Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression To: Leo Liu References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> Date: Thu, 6 Sep 2018 21:01:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:xlAB+trz1+hgz52qb3nDvsw/5Yx+dMJ1Fj9VKtT1UW0Ncxm2aqx t812eSKOgjjeickisMouVJYUWn9MdPPrmYsJz3i64NJi47z52woWU7EVQHnUSDG3SK0CSFE nTI7BTl/4D70RteIttkjWT2yAg4DjOnn5IUfYk22WLMQqPfHFTyI2NnfcPmYREGvFG6tdAg Tiv9HaB/NhM7s4bnewuVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:rcg+X95Sfh0=:rJ5oF6KL8AZ9XN0oQAa2jw i4Ia0TrQoiqNOQ1jPa/xbnjMiuI/FW8y4zFQZ5/O7yYmlstIgwJx/xafeGGxfeblnvysYM9g6 cc42BhgP/6mtEtGrngmSCr5o/XQqS7dy27hOO9Ofj6ITkRxU8QcAwGCgCffTGSbM6h3jWmbqu b1njOHxeaYVXsdA342fEjvTL54rlGCvsHp2qkbQBU24ZtAUekukjM3oK5BthEDwpAr0R6BmjB YuWflSZYKCjVZdP9tBnFYwMwwTPM6qrNNWwP7EhMEAtrMMtfTKCm8LKqLW5VM567LmSyK6+lM QWX0idHNsBneJRFguKqEsLpcJSXMU8pcyvFUhBVtIoT0NfU9hPIcXpswC+/3O7/JD5yU9LBlf IbtQUST2GcPvlpMdHJIkhf5+g1J7BDvurvd2sJVPA7xuOK49GDJg6Ut/Wv3atACnL2X4asNwG GA3b6ykxEpBw3/GdOo3VBBsu634EK0fvNLEbjJxuJmVdkWVwwv1Zrddc2t8KMQWaVmeje8JEe b4fbMz31mNqwSsDQiCv/yENDFDIHxVXyiQ2y76/NuY96dWeYk+6nHYpcHOJ+RcTWuy6iFH6+D i7kiZrPb8WkEbk1VAtQ6QNOm4pTS2usCL+M1eAef/4m1nhabQlFsz/OCXNlW/2GxImIUuhbXy 5t+9xtJCl1OHdlzjUYVB19F7iHkSgYvM8aIA7LGEaQgtNmtoN98iRHE7uJfWhGkVSX2NB0Dwp rXqDcyKneGtdk2qL X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) On 06.09.2018 12:37, Leo Liu wrote: > Hi there, > > I have been using 26.1 as my main editor for the last few months and > this breakage remains a pain point in my day-to-day editing. For example > whenever I rewrite a function, I normally comment out the old one (to > keep the linter, pretty-printer or whatnot happy) and write the new one > from scratch, occasionally copy things from the old one to save typing > and this bug gets in the way many times a day. I propose a patch that > doesn't divert too much from the old and tried behaviour. > > The idea that is currently in thing-at-point-bounds-of-list-at-point is > fine for a higher level function such as list-at-point but doing it > there affects all functions that build on it including some from > thingatpt.el itself. > > I hope you can find time to review the patch and come to a solution for > 26.2 which I very much look forward to. > > Thanks, > Leo > Hi Leo, lets consider the following proposed change of tests: - ("(foo\n(a ;(b c d)\ne) bar)" . (a e)) + ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar)) As the ert-test mentioned calls (re-search-backward "\\((a\\|^a\\)") point will be behind foo at "(a". I.e. "foo" belongs to outer list, not to list-at-point. The desired result shown by this change looks wrong, "(foo" should not be part of. Maybe I'm missing something. May you provide a standalone example where current behavior breaks your code? Thanks, Andreas gladly using GNU Emacs 27.0.50 (build 1, i686-pc-linux-gnu, GTK+ Version 3.14.5) of 2018-08-29 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 07 00:43:07 2018 Received: (at 31772) by debbugs.gnu.org; 7 Sep 2018 04:43:07 +0000 Received: from localhost ([127.0.0.1]:48656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fy8bq-0005Li-UA for submit@debbugs.gnu.org; Fri, 07 Sep 2018 00:43:07 -0400 Received: from mail-pg1-f182.google.com ([209.85.215.182]:36131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fy8bo-0005LC-NH for 31772@debbugs.gnu.org; Fri, 07 Sep 2018 00:43:05 -0400 Received: by mail-pg1-f182.google.com with SMTP id d1-v6so6350957pgo.3 for <31772@debbugs.gnu.org>; Thu, 06 Sep 2018 21:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=x9uSr0hoU3ZgDcjbFpfIsWqt96ZmRFUtGOjimO6x7NM=; b=NzGoGw5FRa9hY6Glt1BTTwbA8ltiixnHBc/ZMCCrCHtN1j2KMjqgP+rFAm4F9kYfd6 oVtyRVdDNpPT/ntT8oJrAvm2416Pyk1ewbkJ9VoMb6B92sySF3useyzqIEhD7xRA0KoU GKB3JvHray7vLW9g4mMrd+P3BLAh9tnCofmP0DHiZPynAfwQhq6cPDvWTgzD+WziMcnT 4I9l7ii8SR7kG3mwyKFM/+iJ1Xj0rioSSvkBmJaGgS/Zj+F17oujuRVSqTwsyHlGFUt8 PJ0l5nmOvJGeaOoEhBBOXb6059Wpch9t+mVwKg2a2XcezlBHcC+YtMSR+cy0hY7x7KDd 92ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=x9uSr0hoU3ZgDcjbFpfIsWqt96ZmRFUtGOjimO6x7NM=; b=H5Lryit31mNaDTQpticiB6Gj+Q3e2+xQVZkZKxTqUvKvOinB2xZbzumvKvI3sxOhzc tOQN01jWyjS0zeH5AV1pcyH7E7iejLASGoNOBm0x/iYlBi6VRiVrZ6qPMo6QPql8blwz iqfwLU8xC9xYruurjnSJOXOEFy53n5gU3zYR8YfXg3FihSz2iKPB9wt0aSeAFyG+HkkO 3KUjODKywIF31UrGoPSpHaJGG76qVMuQkOEIEm8VJCILm2OTeV5PzMYdDk9QxwveZ9fB avwxIXNqo2TTAJi0+QlnDNsCd6tyXKzAiwhpHq2upXf0pe7Mns30oVZ2lk5WHbFe6s39 kdmg== X-Gm-Message-State: APzg51DmhsFGb+KZDfQavQH6qo2CR85QzelOGRKCyCK4OxxhQC7IeVkK bBul/okZXALlHyel3SOovODxzV5w+BY= X-Google-Smtp-Source: ANB0VdYVEynJ9zBuQ+WN1werY/Iz8PjyHf2iAyDZFsxx/QQI5GPc8nUL5VTAuzHxoZp5Nb10YUoUFg== X-Received: by 2002:a63:7f06:: with SMTP id a6-v6mr6292859pgd.296.1536295378504; Thu, 06 Sep 2018 21:42:58 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.219.22]) by smtp.gmail.com with ESMTPSA id 22-v6sm9711151pfl.126.2018.09.06.21.42.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Sep 2018 21:42:57 -0700 (PDT) From: Leo Liu To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Fri, 07 Sep 2018 12:42:55 +0800 In-Reply-To: <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> ("Andreas \=\?iso-8859-1\?Q\?R\=F6hler\=22's\?\= message of "Thu, 6 Sep 2018 21:01:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-09-06 21:01 +0200, Andreas R=F6hler wrote: > Hi Leo, > > lets consider the following proposed change of tests: > > - ("(foo\n(a ;(b c d)\ne) bar)" . (a e)) > + ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar)) > > As the ert-test mentioned calls (re-search-backward "\\((a\\|^a\\)") > > point will be behind foo at "(a". I.e. "foo" belongs to outer list, > not to list-at-point. The desired result shown by this change looks > wrong, "(foo" should not be part of. > > Maybe I'm missing something. > May you provide a standalone example where current behavior breaks > your code? I carefully considered this case when preparing the patch. In the last 10 years (thing-at-point 'list) always returns the enclosing list so I opted to keep this for now. It is confusing and I don't like it personally. It can be tweaked to look at "list" at point first if that's what everybody wants. Cheers, Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 07 04:13:09 2018 Received: (at 31772) by debbugs.gnu.org; 7 Sep 2018 08:13:09 +0000 Received: from localhost ([127.0.0.1]:48737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyBt7-0002UV-ER for submit@debbugs.gnu.org; Fri, 07 Sep 2018 04:13:09 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:46151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyBt5-0002UC-R4 for 31772@debbugs.gnu.org; Fri, 07 Sep 2018 04:13:08 -0400 Received: from [192.168.178.35] ([94.223.84.66]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N9dkD-1fmWdS49f3-015e1M; Fri, 07 Sep 2018 10:13:00 +0200 Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression To: Leo Liu References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <6daeb4a2-09f4-7758-9d44-8608ab35cbad@easy-emacs.de> Date: Fri, 7 Sep 2018 10:17:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:5xuLjgxkv0ricugnecJTE+sL1/n0zTr0LHfdXYqZta8W0BkCb28 XulYaQUdf2nBpLdSwCJ6m85E8cXU6tas+asH05Dhrxjei0nElJGzKJZ3XKshH7bVG43dhry nblPzj3J3DsTXztjaVfpwC37fRJgk9pcf09xp1CDeXCAuyOitkq2Um8Ihc4ds9nZSKfEYA1 g75oIf++kggI7AxrDpwuA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ybXN0dxnAVI=:SxdvFXcEfrXOEj4ec91q76 ftIcQ2hAfGUcQpvKNDAUOyzgQC11AhJstyDEEnYYxG7gOfEA4HbtyPMY0BW0seAym/LR2D0rG Bci0lFjHqXjq/M5ws5OyPU+eMnXmB24v8wbUyGhrlYT4zjM2D8A05NPHZX9rRVot8A3Psz06Y wGI0ifUrLl6iXdMTko2IwH3PFufPHvjwqDIrlIkNWxcmizXNorYEGR8kLuRS/lCAStnr2xUfq 9VSd6uZIDdgI2g7RlWAteMY/PdRKgAQwcyoHbQI1TfoNUc6DuRyo5MDt51ODFWTVayYMqbbIW Ak11JhHJdc13T+TRlHzZm0viOMgfNyfOJJFbJA9uVFv53+IAQ5Oz+95ncGBP7IMwx+IDa/Ecl 4ON526R4s/AewRKjKn4FEqYcCaXl7y23xxr52ZM1WKMUScqoP2BcW9KdjH5Skyi8De7j2sZvo J1CNCpBGNLunCyUT24pg4y0bLyey4J2wQPAlOCTylRMWWYmrlHWSGJukw5146cev0YY1Tkp4j 6YDGF/tXSaeh7wVxhEc46gutAVoN/y8TwubloEj+SXz3CFn9XP+V0dQxLzYfsw9fD0gEWHj2C yzXvXibgwo9vkt52/RX1jVp0fkVdm0Xvkumo4NobQvJGnWYpkMuN3pQiQD0ILXjeY5wrzgoa9 MUPlbyVi7YSeeA9k4kDSqvWNUvSJPowK5Id9zLoyibaxXBP4GmTLsWAtG0H8DCLnbeO2Zbj0h J88xAdWIJpy/ad1j X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 07.09.2018 06:42, Leo Liu wrote: > On 2018-09-06 21:01 +0200, Andreas Röhler wrote: >> Hi Leo, >> >> lets consider the following proposed change of tests: >> >> - ("(foo\n(a ;(b c d)\ne) bar)" . (a e)) >> + ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar)) >> >> As the ert-test mentioned calls (re-search-backward "\\((a\\|^a\\)") >> >> point will be behind foo at "(a". I.e. "foo" belongs to outer list, >> not to list-at-point. The desired result shown by this change looks >> wrong, "(foo" should not be part of. >> >> Maybe I'm missing something. >> May you provide a standalone example where current behavior breaks >> your code? > > I carefully considered this case when preparing the patch. > > In the last 10 years (thing-at-point 'list) always returns the enclosing > list so I opted to keep this for now. It is confusing and I don't like > it personally. To check the current correct behavior insert the following lines and try the command provided below: (foo\n(a ;(b c d) e) bar) (defun mylist () (interactive) (save-excursion (goto-char (point-min)) (search-forward "(a") (forward-char -1) (thing-at-point 'list t))) From "(" it reads the list opened at point. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 07 20:09:57 2018 Received: (at 31772) by debbugs.gnu.org; 8 Sep 2018 00:09:57 +0000 Received: from localhost ([127.0.0.1]:49928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyQp2-0005cX-Uo for submit@debbugs.gnu.org; Fri, 07 Sep 2018 20:09:57 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:43722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyQp1-0005cE-GP for 31772@debbugs.gnu.org; Fri, 07 Sep 2018 20:09:56 -0400 Received: by mail-pl1-f173.google.com with SMTP id h3-v6so3896203plh.10 for <31772@debbugs.gnu.org>; Fri, 07 Sep 2018 17:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bvzFPU3/pKu7A9CsU+Z3RmQ7xIxNFEH9olp3Kyq4KGM=; b=AEuXsk3d+nZf1axOhU/JFVYrx1efCFyZdSttSF40MmBzom0nmJGxHfHmZ7wn0z8lAh /yOUGhTap/yi1BLvfs027PTgtsc6hyPowWakehwVi2Nkn2LEfiQSAhqXH8uAiI0CbKff QubDIdi2pQv5+akM+IiC/AVZjyrQuMKKnj+XJXBIHAAnl4bB8KRmU5MCZR80fyo11s/d eu5+mlHARl9D/H1mvd/cj6ayOnvqlVVAhTuNJf31r9JrmNJPke9YlAjsL/Ohi/TCAC+U d8bIbHaGDkYKUCP8Q0QRsLPAxD4/gFfO0522B8C+O1DmTtKBIC16EMvn7VA7F2kq/1cw nTxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=bvzFPU3/pKu7A9CsU+Z3RmQ7xIxNFEH9olp3Kyq4KGM=; b=mbshbd4N/yutGV4KsD3geyqIlLlQWQn+ZP6OEnfM9vf7R/4YUe9MdkkgMrmfP5Ck7/ scZyNuaxx5MShSQt3N03tLzdUyPLSV1jqvdj38JfgepGN4+PothDobfu4i34katYMWRi gnFSng+jKNo2A6PZC4mBF073Par0+CVpo5aKQH66t5oRs4Y27n3G+b+7t9wBJQ36oD8o NCNhk2lUwLMM74hXX1SDEvENSVTAnPuzeI2xtStdOCtJgR4kIa4PxVIPq4F9jVM0YpuX /tiORwCQPWYo9n9FsyU48TLBLUssLx1YUa/G5UMhIW2CNGVBiimLXWUMWtV2OY8eFf8D 9SzQ== X-Gm-Message-State: APzg51DL6gfcEQmLp3qOlUyqPR+5p/iy3L/Ie+RW/o6OtRfEWaREeC7N 0xqJnvloPdUP1a2AKOGov+nTLskLvd4= X-Google-Smtp-Source: ANB0VdZAzl2u6pMEC7pZtA4QKNMF0bQUyCXE5TccSalJIDtsuBcV/3AW0S9ForvJPKr98mgwAhkCBg== X-Received: by 2002:a17:902:2804:: with SMTP id e4-v6mr10328389plb.327.1536365389290; Fri, 07 Sep 2018 17:09:49 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([139.59.241.182]) by smtp.gmail.com with ESMTPSA id u17-v6sm21941856pfa.176.2018.09.07.17.09.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Sep 2018 17:09:47 -0700 (PDT) From: Leo Liu To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> <6daeb4a2-09f4-7758-9d44-8608ab35cbad@easy-emacs.de> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Sat, 08 Sep 2018 08:09:44 +0800 In-Reply-To: <6daeb4a2-09f4-7758-9d44-8608ab35cbad@easy-emacs.de> ("Andreas \=\?iso-8859-1\?Q\?R\=F6hler\=22's\?\= message of "Fri, 7 Sep 2018 10:17:12 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-09-07 10:17 +0200, Andreas R=F6hler wrote: > To check the current correct behavior insert the following lines With all due respect that is not the issue at stake. The issue with the code in 26.1 is changing the semantics abruptly without consideration for backwards compatibility. It is a change that is broadly not in line with everything else in Emacs. Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 04:31:53 2018 Received: (at 31772) by debbugs.gnu.org; 11 Sep 2018 08:31:53 +0000 Received: from localhost ([127.0.0.1]:36125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fze5R-0006Vs-G7 for submit@debbugs.gnu.org; Tue, 11 Sep 2018 04:31:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fze5Q-0006Vf-5g for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 04:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fze5J-0002eR-2m for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 04:31:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fze5B-0002cg-CX; Tue, 11 Sep 2018 04:31:37 -0400 Received: from [176.228.60.248] (port=4663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fze5A-0000ai-Cs; Tue, 11 Sep 2018 04:31:37 -0400 Date: Tue, 11 Sep 2018 11:31:43 +0300 Message-Id: <83y3c8mo40.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Thu, 06 Sep 2018 18:37:11 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: Eli Zaretskii , Tino Calancha > Date: Thu, 06 Sep 2018 18:37:11 +0800 > > I have been using 26.1 as my main editor for the last few months and > this breakage remains a pain point in my day-to-day editing. For example > whenever I rewrite a function, I normally comment out the old one (to > keep the linter, pretty-printer or whatnot happy) and write the new one > from scratch, occasionally copy things from the old one to save typing > and this bug gets in the way many times a day. I propose a patch that > doesn't divert too much from the old and tried behaviour. Thanks. Can you summarize how the behavior with your patch will be different from what we had in Emacs 25 and before? > The idea that is currently in thing-at-point-bounds-of-list-at-point is > fine for a higher level function such as list-at-point but doing it > there affects all functions that build on it including some from > thingatpt.el itself. Would it be possible to modify list-at-point so that it keeps the current behavior, perhaps as an option? I'd like to find a solution that doesn't just revert to the old behavior, but allows those who need the new behavior to have it in some reasonable way. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 06:26:50 2018 Received: (at 31772) by debbugs.gnu.org; 11 Sep 2018 10:26:50 +0000 Received: from localhost ([127.0.0.1]:36210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzfsg-00033O-8V for submit@debbugs.gnu.org; Tue, 11 Sep 2018 06:26:50 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:34346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzfse-000336-Bj for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 06:26:49 -0400 Received: by mail-pf1-f182.google.com with SMTP id k19-v6so12029108pfi.1 for <31772@debbugs.gnu.org>; Tue, 11 Sep 2018 03:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=b6wGKDwyJVdQULTcjP7WdK/rorTOBGh06OCzPaUnR48=; b=KFu3cYZkEWkHCEVZ2RiAd80lAMhHLK6xrordvvNpnGWt/1zHpfj4Js7Kkl3UxmiGK2 uzTAhKiH345HwvxqRw+vaE/Rw/YIiromwZaAwKvWMO/Kw0Q8utwd9ufDVYTn0kH/TSd3 9U+rkPTXTlv43GHd3Pct/Ww+Mjz2/N6gxKszwCFXYWq6F4HtuJ4LkYcVpa6HxK7xDccq 8DVMROw7lD/ZS5hem+sfhXu7HwIqmrYBU9HKCRufotNXh44Xz5XxBU0wXN9yZKyld5NW mkRYR//4pqhHlP3vQaueaRrKZ7Sdp0enXWL9qbosk62RJFsXROyf4oYsqNAPjQp6ylmy Wkug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=b6wGKDwyJVdQULTcjP7WdK/rorTOBGh06OCzPaUnR48=; b=CQYKOhdqicwRZzjnCS+uDCAK92DJ3ymW0bTlB8G492H/FeRjTrPOt6yIbILg+qfDWa 3+BFyytfveH0PWWwSgTyhFHWGkDOII8ZlZVRKkIUTYnsEloAIxCzC91ymAgSq7ISPULj 7iRaoAnZ+FyshsHdpVGTKYkhU8mNJwhm4R6/UQfroHuQpKZNjB8SxFl9JYCs66IPD+XE s7NdexIDMbouEdlEGh+I2QDw9bTR/wEEcVyXdhmBDpb1hhzxYpmsTDH3lMVaThWXxQ/2 Lfd1XAGhYYHE6twdPkfG3s24dNCJMIo62NewXg8rYtqOIlcNT2CRgZRG+aiB7vwXyo64 K5og== X-Gm-Message-State: APzg51CTAaHsPokhPbIVKehcqCTV5nUg6lUtAWPN87CQBlrhOkEVdnYC dtLenliuj9M4eAOhE3XMdFY= X-Google-Smtp-Source: ANB0VdYCd4nU+IjoKMqZUVanJ98+ZgQULWeIX2brwwNwtUbc9ac+gzEMPYZ9hq+HEKzVH6qZZ3wUHQ== X-Received: by 2002:a62:6c85:: with SMTP id h127-v6mr28816488pfc.65.1536661600175; Tue, 11 Sep 2018 03:26:40 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.219.22]) by smtp.gmail.com with ESMTPSA id p73-v6sm27724038pfk.186.2018.09.11.03.26.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 03:26:39 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Tue, 11 Sep 2018 18:26:36 +0800 In-Reply-To: <83y3c8mo40.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Sep 2018 11:31:43 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-09-11 11:31 +0300, Eli Zaretskii wrote: [snipped 13 lines] > Thanks. Can you summarize how the behavior with your patch will be > different from what we had in Emacs 25 and before? The difference is on what to return when (up-list -1) fails. They both try to return the sexp at point but the patched behaviour try returning the whole sexp while the one in <= 25.1 cut off the sexp from point. Looking at the code in 25.1 it looks to me the original author had a thinko i.e. he/she meant to write: (if (>= opoint (point)) (cons (point) end)) but instead write (if (>= opoint (point)) (cons opoint end)) which resulted in some weird cases that you mentioned in previous email. [snipped 6 lines] > Would it be possible to modify list-at-point so that it keeps the > current behavior, perhaps as an option? I'd like to find a solution > that doesn't just revert to the old behavior, but allows those who > need the new behavior to have it in some reasonable way. Yes, this can be done. For example: (defun list-at-point (&optional ignore-comment-or-string) "Return the Lisp list at point, or nil if none is found. If IGNORE-COMMENT-OR-STRING is non-nil comments and strings are treated as white space." (let ((ppss (and ignore-comment-or-string (syntax-ppss)))) (save-excursion (goto-char (or (nth 8 ppss) (point))) (form-at-point 'list 'listp)))) > > Thanks. Thanks. -Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 07:16:05 2018 Received: (at 31772) by debbugs.gnu.org; 11 Sep 2018 11:16:05 +0000 Received: from localhost ([127.0.0.1]:36233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzgeL-0004LU-Dj for submit@debbugs.gnu.org; Tue, 11 Sep 2018 07:16:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzgeI-0004Kk-GQ for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 07:16:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzgeC-0008JU-H6 for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 07:15:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzge6-0008E3-Ro; Tue, 11 Sep 2018 07:15:50 -0400 Received: from [176.228.60.248] (port=3372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fzge6-0004Fg-FX; Tue, 11 Sep 2018 07:15:50 -0400 Date: Tue, 11 Sep 2018 14:16:00 +0300 Message-Id: <83tvmwmgi7.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Tue, 11 Sep 2018 18:26:36 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com > Date: Tue, 11 Sep 2018 18:26:36 +0800 > > The difference is on what to return when (up-list -1) fails. They both > try to return the sexp at point but the patched behaviour try returning > the whole sexp while the one in <= 25.1 cut off the sexp from point. > > Looking at the code in 25.1 it looks to me the original author had a > thinko i.e. he/she meant to write: > > (if (>= opoint (point)) > (cons (point) end)) > > but instead write > > (if (>= opoint (point)) > (cons opoint end)) > > which resulted in some weird cases that you mentioned in previous email. Right. > > Would it be possible to modify list-at-point so that it keeps the > > current behavior, perhaps as an option? I'd like to find a solution > > that doesn't just revert to the old behavior, but allows those who > > need the new behavior to have it in some reasonable way. > > Yes, this can be done. For example: > > (defun list-at-point (&optional ignore-comment-or-string) > "Return the Lisp list at point, or nil if none is found. > If IGNORE-COMMENT-OR-STRING is non-nil comments and strings are > treated as white space." > (let ((ppss (and ignore-comment-or-string (syntax-ppss)))) > (save-excursion > (goto-char (or (nth 8 ppss) (point))) > (form-at-point 'list 'listp)))) Would you mind submitting a patch that includes the above, and also fixes/augments the tests accordingly? I think these changes then could go into the emacs-26 branch, unless someone raises objections. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 07:48:42 2018 Received: (at submit) by debbugs.gnu.org; 11 Sep 2018 11:48:42 +0000 Received: from localhost ([127.0.0.1]:36253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzh9t-00076j-Nr for submit@debbugs.gnu.org; Tue, 11 Sep 2018 07:48:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzh9s-00076X-7v for submit@debbugs.gnu.org; Tue, 11 Sep 2018 07:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzh9m-0002FV-5h for submit@debbugs.gnu.org; Tue, 11 Sep 2018 07:48:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzh9l-0002Ez-Vj for submit@debbugs.gnu.org; Tue, 11 Sep 2018 07:48:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzh9l-0004YP-2b for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 07:48:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzh9h-0002BM-MP for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 07:48:32 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:35183) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fzh9h-0002AZ-Bm for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 07:48:29 -0400 Received: from [192.168.178.35] ([88.74.26.136]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MT3QL-1gOkxj2TbB-00Rms3 for ; Tue, 11 Sep 2018 13:48:26 +0200 Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression To: bug-gnu-emacs@gnu.org References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <40ce4d6f-406b-2a9b-6105-804a11ce133b@easy-emacs.de> Date: Tue, 11 Sep 2018 13:52:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83tvmwmgi7.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:sA+rbeLR5PrBmydJlo5ousjKwDsa8M9vMvVyZn4Y7oSMdWsqkYG tu+GslWrTARFQqoB5GPtHtZIsqY+0Weyc6mSdsqHJ1vIIO+xk0W/K+OH+s8ciYYluylDn92 O9xwqmFUSB2L6q7JCAmRiCI6EyeSfI3OtIyxBtunRjyOsAFHw5pzb9y3HwEeCrQUHzn1F6P lgFDhQpaRkiTmzGgqVc0Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:OY2+d0m87i8=:cJINH5PD2kfR2+S9deK6PH A0PPpwSAoU9LEgk6+dvdRPOFi5E35s1Dv6lRkmXcWzueAsmDcDjf1p2IXpPTvyT/7A9h35iQn E5QL2XjEVkwFAf4PoHIowcRzw8uOyEwEFIDzARl+Qgms8HWKcYa5DKhm/XcLv/Xat2QcX04Xk TBF0aMO1KRpRqEDzM5QP9RF/H2CVPDJThJdFSH7hKZ6LKNYmIUB8MgTBV+JOIpC72JaAOA4fg 3fLt/j5B3xpuin1+pkrRAldEZAhPDy3rkK3keS+GrsSWIERgE+ebIUnvjU5eC96HGpKBLJT1C dtJp4c+D9VMxT3N02g7K89xw//t4pmJGSO3UzFITui/3U+ttSzyeeQPLNTld/Gu7YzSH3CeVg SO5FrvxO8SLHvsAUECROiBaYPP2LK+z5liJnNr0ob3Tu5tpsHHeLFry4YROh/H6QooyXg1LYP BceGvivFwz5sRlAVnEDbmoejB35BAhh6wNFTA6R+Ij8K14aTJjp5xkg16jAxR+PKHj2hIYqxL 35yOpx7+QPuQ1SJBFDM94sZBI12jRFnkg90g4ihSiY6CyGlJYH32hjXq/uoyn/cD54oaw60oy azW9XSzqgAGzRczAQOtv1d2Y7m4u4l9Q5PjV4pBVFs9iiO26GE9UiNcIVHEWw4033oNBCH65z 2Lt12tK9VLxgDNG7R8InlN3j3Mbxq9GlqzF2GqBl8bcnQDTDm1Wr0SiTWSBLU6AnHfS9qopkW stAUsmzGWsZmAzrC X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) On 11.09.2018 13:16, Eli Zaretskii wrote: >> From: Leo Liu >> Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com >> Date: Tue, 11 Sep 2018 18:26:36 +0800 >> >> The difference is on what to return when (up-list -1) fails. They both >> try to return the sexp at point but the patched behaviour try returning >> the whole sexp while the one in <= 25.1 cut off the sexp from point. >> >> Looking at the code in 25.1 it looks to me the original author had a >> thinko i.e. he/she meant to write: >> >> (if (>= opoint (point)) >> (cons (point) end)) >> >> but instead write >> >> (if (>= opoint (point)) >> (cons opoint end)) >> >> which resulted in some weird cases that you mentioned in previous email. > > Right. > >>> Would it be possible to modify list-at-point so that it keeps the >>> current behavior, perhaps as an option? I'd like to find a solution >>> that doesn't just revert to the old behavior, but allows those who >>> need the new behavior to have it in some reasonable way. >> >> Yes, this can be done. For example: >>optional ignore-comment-or-string) >> "Return the Lisp list at >> (defun list-at-point (& point, or nil if none is found. >> If IGNORE-COMMENT-OR-STRING is non-nil comments and strings are >> treated as white space." >> (let ((ppss (and ignore-comment-or-string (syntax-ppss)))) >> (save-excursion >> (goto-char (or (nth 8 ppss) (point))) >> (form-at-point 'list 'listp)))) > > Would you mind submitting a patch that includes the above, and also > fixes/augments the tests accordingly? I think these changes then > could go into the emacs-26 branch, unless someone raises objections. > > Thanks. > > > The basic decision to make is to put some section as comment or not. If code is commented out, it looses its lisp-syntax. It's plain text. Therefor no lisp-list can exist and no need for a var ignore-comment-or-string. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 08:10:07 2018 Received: (at 31772) by debbugs.gnu.org; 11 Sep 2018 12:10:07 +0000 Received: from localhost ([127.0.0.1]:36270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzhUd-0007c6-4n for submit@debbugs.gnu.org; Tue, 11 Sep 2018 08:10:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzhUc-0007bU-9B for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 08:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzhUT-0003HM-Oo for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 08:10:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzhUT-0003H9-J3; Tue, 11 Sep 2018 08:09:57 -0400 Received: from [176.228.60.248] (port=2851 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fzhUT-0005iN-5J; Tue, 11 Sep 2018 08:09:57 -0400 Date: Tue, 11 Sep 2018 15:10:06 +0300 Message-Id: <83r2i0me01.fsf@gnu.org> From: Eli Zaretskii To: Andreas =?utf-8?Q?R=C3=B6hler?= In-reply-to: <40ce4d6f-406b-2a9b-6105-804a11ce133b@easy-emacs.de> (message from Andreas =?utf-8?Q?R=C3=B6hler?= on Tue, 11 Sep 2018 13:52:42 +0200) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> <40ce4d6f-406b-2a9b-6105-804a11ce133b@easy-emacs.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Andreas Röhler > Date: Tue, 11 Sep 2018 13:52:42 +0200 > > If code is commented out, it looses its lisp-syntax. It's plain text. > Therefor no lisp-list can exist and no need for a var > ignore-comment-or-string. I think I agree with Leo on this and disagree with you. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 08:37:07 2018 Received: (at 31772) by debbugs.gnu.org; 11 Sep 2018 12:37:07 +0000 Received: from localhost ([127.0.0.1]:36296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzhuk-0008KN-Tl for submit@debbugs.gnu.org; Tue, 11 Sep 2018 08:37:07 -0400 Received: from mail-pg1-f169.google.com ([209.85.215.169]:40039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzhui-0008Js-PE for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 08:37:05 -0400 Received: by mail-pg1-f169.google.com with SMTP id l63-v6so12196609pga.7 for <31772@debbugs.gnu.org>; Tue, 11 Sep 2018 05:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=mq6EN8SoloUFXDTa5PX9Kg7E2adiaogr6IYseTWiW+g=; b=QVTg+8GEDNbSPzkQcMNWsPo74bDrNUKL2PUcoKODNNFV1VhiwZSuYovHyTWpWQsyUf rNv50QcDPAdLGisa/9T9BeYExaV0v5iv+0/OWQIF94/f52MF8QhaxmyXP0J+TNKmg9QB MBZZ8Tbx1kg8QEyw5YcQVDu7HcMS2GTj0m2SdFbd3I1uJbciOW+W6ktJX43rDjc9xjJV YJ7jmGKomNpcG5j3r85oVkscGovQ4NxhNRkrxYTsEmq3rWcBo+r9LggGi6pImDx2LrZl h5n+nkx7ZmJwg8Ei/BbtQX5bhLFDZ3WWdOBcMdt/HlDzZ+6XX5U1N9PIpwoY0Dl2Khr/ TdIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=mq6EN8SoloUFXDTa5PX9Kg7E2adiaogr6IYseTWiW+g=; b=GidsLTo/HfVHNsJTvwTWeXSfL1FOqnV48zt3OJroH1jW2uoeMybWgNDDIIRBnDIgn0 2yptGWza66N5ABEzj0FiEGZSrRhcMc06ir+wfdfiFILdTB5pI5dY946fngLspPA2q9wu hSS6NZyaR+z9aI8S2jUvOPv9Gwh/M+gAb7FqZr+JHJR64iWINVNutmHvbSqJGW4q5jVI U0tWNpdMVdcHoT1uxiXjXQ1sriy96RzAs/eJLrrQSVDsvn1T04a8T4Qd/5Ry2MNgXUWo 7soD05rzYL9SP9N+T3P4KJdJb8qNSfTiN2wYY8Li2dfzCYTCc0OmAs5EyKEYvQdN+nNA Y1Jg== X-Gm-Message-State: APzg51AAdo+dGeUn4lWwjUpwxEFxJ6xCAfyi1Mj9QWXK16JncQXpr6CB 6tPm7PppfA5fMryMFez/fMM= X-Google-Smtp-Source: ANB0VdZKH9NOKD6jexPGwmbmgfwmlI0f9tr9JACmdAahsuWY5tsRyydaevlkvvuZlAGlDp88uvoR7Q== X-Received: by 2002:a62:cac5:: with SMTP id y66-v6mr29079233pfk.187.1536669418759; Tue, 11 Sep 2018 05:36:58 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.219.22]) by smtp.gmail.com with ESMTPSA id 22-v6sm28920897pfl.126.2018.09.11.05.36.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 05:36:57 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Tue, 11 Sep 2018 20:36:53 +0800 In-Reply-To: <83tvmwmgi7.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Sep 2018 14:16:00 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2018-09-11 14:16 +0300, Eli Zaretskii wrote: > Would you mind submitting a patch that includes the above, and also > fixes/augments the tests accordingly? I think these changes then > could go into the emacs-26 branch, unless someone raises objections. Please find the new patch in the attachment. Thanks a lot for helping straighten this out. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=thing.diff Content-Description: thing.diff diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 6a978fe9..fdc12f32 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -221,15 +221,12 @@ The bounds of THING are determined by `bounds-of-thing-at-point'." "Return the bounds of the list at point. \[Internal function used by `bounds-of-thing-at-point'.]" (save-excursion - (let* ((st (parse-partial-sexp (point-min) (point))) - (beg (or (and (eq 4 (car (syntax-after (point)))) - (not (nth 8 st)) - (point)) - (nth 1 st)))) - (when beg - (goto-char beg) - (forward-sexp) - (cons beg (point)))))) + (if (ignore-errors (up-list -1)) + (ignore-errors (cons (point) (progn (forward-sexp) (point)))) + (let ((bound (bounds-of-thing-at-point 'sexp))) + (and bound + (<= (car bound) (point)) (< (point) (cdr bound)) + bound))))) ;; Defuns @@ -608,8 +605,13 @@ Signal an error if the entire string was not used." (put 'number 'thing-at-point 'number-at-point) ;;;###autoload -(defun list-at-point () - "Return the Lisp list at point, or nil if none is found." - (form-at-point 'list 'listp)) +(defun list-at-point (&optional ignore-comment-or-string) + "Return the Lisp list at point, or nil if none is found. +If IGNORE-COMMENT-OR-STRING is non-nil comments and strings are +treated as white space." + (let ((ppss (and ignore-comment-or-string (syntax-ppss)))) + (save-excursion + (goto-char (or (nth 8 ppss) (point))) + (form-at-point 'list 'listp)))) ;;; thingatpt.el ends here diff --git a/test/lisp/thingatpt-tests.el b/test/lisp/thingatpt-tests.el index cfb57de6..43172f4f 100644 --- a/test/lisp/thingatpt-tests.el +++ b/test/lisp/thingatpt-tests.el @@ -84,41 +84,44 @@ position to retrieve THING.") (goto-char (nth 1 test)) (should (equal (thing-at-point (nth 2 test)) (nth 3 test)))))) -;; These tests reflect the actual behavior of -;; `thing-at-point-bounds-of-list-at-point'. -(ert-deftest thing-at-point-bug24627 () - "Test for https://debbugs.gnu.org/24627 ." - (let ((string-result '(("(a \"b\" c)" . (a "b" c)) - (";(a \"b\" c)") - ("(a \"b\" c\n)" . (a "b" c)) - ("\"(a b c)\"") - ("(a ;(b c d)\ne)" . (a e)) - ("(foo\n(a ;(b c d)\ne) bar)" . (a e)) - ("(foo\na ;(b c d)\ne bar)" . (foo a e bar)) - ("(foo\n(a \"(b c d)\"\ne) bar)" . (a "(b c d)" e)) - ("(b\n(a ;(foo c d)\ne) bar)" . (a e)) - ("(princ \"(a b c)\")" . (princ "(a b c)")) - ("(defun foo ()\n \"Test function.\"\n ;;(a b)\n nil)" . (defun foo nil "Test function." nil)))) - (file - (expand-file-name "lisp/thingatpt.el" source-directory)) - buf) - ;; Test for `thing-at-point'. - (when (file-exists-p file) - (unwind-protect - (progn - (setq buf (find-file file)) - (goto-char (point-max)) - (forward-line -1) - (should-not (thing-at-point 'list))) - (kill-buffer buf))) - ;; Tests for `list-at-point'. - (dolist (str-res string-result) - (with-temp-buffer - (emacs-lisp-mode) - (insert (car str-res)) - (re-search-backward "\\((a\\|^a\\)") - (should (equal (list-at-point) - (cdr str-res))))))) +;; See bug#24627 and bug#31772. +(ert-deftest thing-at-point-bounds-of-list-at-point () + (cl-macrolet ((with-test-buffer (str &rest body) + `(with-temp-buffer + (emacs-lisp-mode) + (insert ,str) + (search-backward "|") + (delete-char 1) + ,@body))) + (let ((tests1 + '(("|(a \"b\" c)" (a "b" c)) + (";|(a \"b\" c)" (a "b" c) nil) + ("|(a \"b\" c\n)" (a "b" c)) + ("\"|(a b c)\"" (a b c) nil) + ("|(a ;(b c d)\ne)" (a e)) + ("(foo\n|(a ;(b c d)\ne) bar)" (foo (a e) bar)) + ("(foo\n|a ;(b c d)\ne bar)" (foo a e bar)) + ("(foo\n|(a \"(b c d)\"\ne) bar)" (foo (a "(b c d)" e) bar)) + ("(b\n|(a ;(foo c d)\ne) bar)" (b (a e) bar)) + ("(princ \"|(a b c)\")" (a b c) (princ "(a b c)")) + ("(defun foo ()\n \"Test function.\"\n ;;|(a b)\n nil)" + (defun foo nil "Test function." nil) + (defun foo nil "Test function." nil)))) + (tests2 + '(("|list-at-point" . "list-at-point") + ("list-|at-point" . "list-at-point") + ("list-at-point|" . nil) + ("|(a b c)" . "(a b c)") + ("(a b c)|" . nil)))) + ;; Tests for `list-at-point'. + (dolist (test tests1) + (with-test-buffer (car test) + (should (equal (list-at-point) (cl-second test))) + (when (cddr test) + (should (equal (list-at-point t) (cl-third test)))))) + (dolist (test tests2) + (with-test-buffer (car test) + (should (equal (thing-at-point 'list) (cdr test)))))))) (ert-deftest thing-at-point-url-in-comment () (with-temp-buffer --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 08:39:28 2018 Received: (at 31772) by debbugs.gnu.org; 11 Sep 2018 12:39:28 +0000 Received: from localhost ([127.0.0.1]:36300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzhx2-0008Nz-F1 for submit@debbugs.gnu.org; Tue, 11 Sep 2018 08:39:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzhx0-0008Nh-Gx for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 08:39:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzhwu-0000EH-EJ for 31772@debbugs.gnu.org; Tue, 11 Sep 2018 08:39:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzhws-0000Bb-NN; Tue, 11 Sep 2018 08:39:18 -0400 Received: from [176.228.60.248] (port=4697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fzhws-0006bJ-AD; Tue, 11 Sep 2018 08:39:18 -0400 Date: Tue, 11 Sep 2018 15:39:28 +0300 Message-Id: <83musomcn3.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Tue, 11 Sep 2018 20:36:53 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com > Date: Tue, 11 Sep 2018 20:36:53 +0800 > > On 2018-09-11 14:16 +0300, Eli Zaretskii wrote: > > Would you mind submitting a patch that includes the above, and also > > fixes/augments the tests accordingly? I think these changes then > > could go into the emacs-26 branch, unless someone raises objections. > > Please find the new patch in the attachment. Thanks a lot for helping > straighten this out. Thanks, let's wait for a few days to let people comment, raise objections, etc. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 10:55:21 2018 Received: (at 31772-done) by debbugs.gnu.org; 14 Sep 2018 14:55:21 +0000 Received: from localhost ([127.0.0.1]:40822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0pVA-0005jd-T4 for submit@debbugs.gnu.org; Fri, 14 Sep 2018 10:55:21 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:44708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0pV9-0005jQ-Lm for 31772-done@debbugs.gnu.org; Fri, 14 Sep 2018 10:55:20 -0400 Received: by mail-pl1-f176.google.com with SMTP id ba4-v6so4321826plb.11 for <31772-done@debbugs.gnu.org>; Fri, 14 Sep 2018 07:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=5PeNIs7DWDkPzGNQpQ+KTDQ54ljIWUhjBrQWU9wnbN4=; b=f5ZOYMhVUIvTTtYoIbzGrxY37MJLQo9weer4iq9BbgEiq+y1N3s0LAFGlWOlhZ986M t4zjSODTFu7MFgzIStZ+UpiW2qQRT+i3O5Bu3gSjpiRrRgvzUWJ6ru24j85yNShP4Sqy JVLm5M734PUjFSyiEOtstsBwO6mHOI5xk/tI1UP6qVzQeys0Ru4Z9eEHh7qM2zFjqqsV pmmkSZabGxje4UH3xfVJ4Ilp9UEnowB4T2POTfOrH104xbo0FrIosVyO7tpNeUEzD/+s NILRPN5QxWPaKhwQIYunkCaYoGUWBF4N9otmU/Huw5bexieBx5bCZj2Jsk3um2Jve9PN VW4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=5PeNIs7DWDkPzGNQpQ+KTDQ54ljIWUhjBrQWU9wnbN4=; b=q61jpi7lTeYzKeavMac1Vlov75VWDFudoQ2X+5Zp3RNtbrhu7vUecIISWxKY/RO7AO 6grUJp1qtdcgGrL2uSCUwi9fHyviLpW7+/h/DlhwkGtKVzj+P2CJgVvrbjF0yjNFg/mp f47cL5suKT7nklfEqE/eeKjPsz5eSqqqMsrJnqZRrLmI46FheKOq+rh3DEfF0UofPmV6 rAb6hhIp92xYn1tV8eJzLvNo96bbD+nAUBaaAxJl1L7uxOmEOV+eYJvdk//8c/olGT3x qhhuzw1+t5V4SUuHFIudiIJD2rmdDcs5NczIdwtvZyQnA9z6K7eXpkTwZ0jcP02Ehf4f kdSg== X-Gm-Message-State: APzg51ACEP+aK9f5tEX6F3rMv6bL1PwA+CA8gyCqhrX9cDJuc4loftAq /Ej9sbgIcy/U3HqP86kpUoM= X-Google-Smtp-Source: ANB0VdYilwCy5yYnuBP+d5+C73c0wc1hRziljeKxAQRyq1HbEl8Gv+A+bJfTQZzcjvISxTBywqac7A== X-Received: by 2002:a17:902:8345:: with SMTP id z5-v6mr12475240pln.147.1536936913809; Fri, 14 Sep 2018 07:55:13 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.219.22]) by smtp.gmail.com with ESMTPSA id p73-v6sm11729877pfk.186.2018.09.14.07.55.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Sep 2018 07:55:12 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> <83musomcn3.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Fri, 14 Sep 2018 22:55:08 +0800 In-Reply-To: <83musomcn3.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Sep 2018 15:39:28 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772-done Cc: 31772-done@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixed in 26.2. On 2018-09-11 15:39 +0300, Eli Zaretskii wrote: > Thanks, let's wait for a few days to let people comment, raise > objections, etc. I just pushed it to emacs-26. Thanks again. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 05:06:23 2018 Received: (at 31772) by debbugs.gnu.org; 15 Sep 2018 09:06:23 +0000 Received: from localhost ([127.0.0.1]:41103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g16X0-0000B1-RB for submit@debbugs.gnu.org; Sat, 15 Sep 2018 05:06:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g16Wz-0000Am-AA for 31772@debbugs.gnu.org; Sat, 15 Sep 2018 05:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g16Wt-0005BE-Mb for 31772@debbugs.gnu.org; Sat, 15 Sep 2018 05:06:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g16Wo-00054t-M9; Sat, 15 Sep 2018 05:06:10 -0400 Received: from [176.228.60.248] (port=3542 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g16Wo-0006A7-9j; Sat, 15 Sep 2018 05:06:10 -0400 Date: Sat, 15 Sep 2018 12:06:02 +0300 Message-Id: <83worni0zp.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Fri, 14 Sep 2018 22:55:08 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> <83musomcn3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: 31772-done@debbugs.gnu.org, tino.calancha@gmail.com > Date: Fri, 14 Sep 2018 22:55:08 +0800 > > Fixed in 26.2. Thanks, but that was too fast, especially for a somewhat controversial change such as this one. Please in the future allow at least one week in such cases. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 08:58:19 2018 Received: (at 31772) by debbugs.gnu.org; 15 Sep 2018 12:58:19 +0000 Received: from localhost ([127.0.0.1]:41175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1A9S-0008Ad-Ng for submit@debbugs.gnu.org; Sat, 15 Sep 2018 08:58:18 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:40999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1A9R-0008AQ-5m for 31772@debbugs.gnu.org; Sat, 15 Sep 2018 08:58:17 -0400 Received: by mail-pl1-f169.google.com with SMTP id b12-v6so5395838plr.8 for <31772@debbugs.gnu.org>; Sat, 15 Sep 2018 05:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=fqQSxPjroT56i8VlnyZ8B5f+dy4ONNED5ccgJthryTI=; b=J2WgV426q14o94v9QLbQ6gPNLvH8cJsfaomcl5VgCYZmqzo+hYsrE/VpRvB/mt+1rn 6RR5zMRlCjQqHJQgu4Eh2eWDEkV1AoHqlRkFZkAMb4e9YrsIndvc2dzzTKpJ2lRI0pyG pfJ40quTmRCn5ooKdBNOTFlGR0yCCOZTJCgmCdNf1CqOE3aXUam7OCgw74rT0Yf+QYFW EeLQNzJUubuAJj9hRv/ZFl/Vkyzwdj5E0Zex87tjZnpHGUUFtXtFhXHSSpz+wZjzG/xg Y0oz2TFgQcdi0e3GZGZ2/aegrPU03r++7hfqmNVG9FkURhgEjM7hPa0Yra4L4jG7ZEd5 YWfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=fqQSxPjroT56i8VlnyZ8B5f+dy4ONNED5ccgJthryTI=; b=A7LgloeuCEqtktkuQLXsx4ttHZ5yspaHZ9zEg6ukXVa0Ptc8siVSnbHmY1mTKckZMn PBJLFMPeZq2FLwXDZ9rePKoM6x+/nvSO8u0eKPPSQ9MYw36PGoVm/IyHpJPgvU/JdJUP mBlQnyygU9amtVlf7omxhVfonxXOfeHg9Px5fQUNUEXlfGcuv3RMiS/9gnQhdIE+5I/z fckft541GI4JqHzJg0Kdal0HbJyKJKkJBtnZynRQ0ycKcnaICQKLv+Ba0SmTqyKUiDmU vpjo/z0Bl3Fyr7bRgY7VVWcw7xtBmGugqfaDTNRGUY0UgWAgsDqlbTHklA2kYuDg0nFM r06g== X-Gm-Message-State: APzg51A5pe9QRZKD7qWm81OllnJY5E95XOccW8Uu7hqWig6BWnwyYZHN 8LiJYgTwFxad47ew+j3sSAE= X-Google-Smtp-Source: ANB0VdbQ5QsY9DQKa0kvB2WLVuT1k552YMcF6yVkSm0kVp2+YXaUhnswd/P3Vrb6uKNO8ILDGo7KoQ== X-Received: by 2002:a17:902:c6b:: with SMTP id 98-v6mr16748083pls.233.1537016291298; Sat, 15 Sep 2018 05:58:11 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.250.110]) by smtp.gmail.com with ESMTPSA id m21-v6sm18890912pgd.6.2018.09.15.05.58.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Sep 2018 05:58:10 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> <83musomcn3.fsf@gnu.org> <83worni0zp.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Sat, 15 Sep 2018 20:58:06 +0800 In-Reply-To: <83worni0zp.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Sep 2018 12:06:02 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (macOS 10.12.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-09-15 12:06 +0300, Eli Zaretskii wrote: > Thanks, but that was too fast, especially for a somewhat controversial > change such as this one. Please in the future allow at least one week > in such cases. Absolutely, Eli. I was expecting a storm (said to be the worst of the year) and was also travelling early next day (which was rescheduled to Monday). I was expecting no internnet for at least a Month, so I thought I made the commit considering there were also some local minor tweaks. Otherwise I would have left it here knowing someone would eventually take are of it. BTW, thanks for adding the detailed News entry. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 09:28:22 2018 Received: (at 31772) by debbugs.gnu.org; 15 Sep 2018 13:28:22 +0000 Received: from localhost ([127.0.0.1]:41182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1AcY-0000Ri-5y for submit@debbugs.gnu.org; Sat, 15 Sep 2018 09:28:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1AcW-0000RW-GR for 31772@debbugs.gnu.org; Sat, 15 Sep 2018 09:28:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1AcQ-0002vE-I8 for 31772@debbugs.gnu.org; Sat, 15 Sep 2018 09:28:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1AcM-0002lL-M2; Sat, 15 Sep 2018 09:28:10 -0400 Received: from [176.228.60.248] (port=4738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g1AcM-00021n-7f; Sat, 15 Sep 2018 09:28:10 -0400 Date: Sat, 15 Sep 2018 16:28:02 +0300 Message-Id: <83o9cyj3fh.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Sat, 15 Sep 2018 20:58:06 +0800) Subject: Re: bug#31772: 26.1; (thing-at-point 'list) regression References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> <83y3c8mo40.fsf@gnu.org> <83tvmwmgi7.fsf@gnu.org> <83musomcn3.fsf@gnu.org> <83worni0zp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31772 Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Leo Liu > Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com > Date: Sat, 15 Sep 2018 20:58:06 +0800 > > On 2018-09-15 12:06 +0300, Eli Zaretskii wrote: > > Thanks, but that was too fast, especially for a somewhat controversial > > change such as this one. Please in the future allow at least one week > > in such cases. > > Absolutely, Eli. > > I was expecting a storm (said to be the worst of the year) and was also > travelling early next day (which was rescheduled to Monday). I was > expecting no internnet for at least a Month, so I thought I made the > commit considering there were also some local minor tweaks. Otherwise I > would have left it here knowing someone would eventually take are of it. Understood, and thanks for working on this. From unknown Sat Jun 21 10:37:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Oct 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator