GNU bug report logs - #31760
26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Petko Bordjukov <bordjukov <at> gmail.com>
Cc: 31760 <at> debbugs.gnu.org, Bozhidar Batsov <bozhidar <at> batsov.com>, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists
Date: Sat, 16 Jun 2018 16:32:21 +0100

Petko Bordjukov <bordjukov <at> gmail.com> writes:

> Again, I appreciate this feature, but do not leave it on by default --
> it will be just another bad Emacs default.
>

I'd just like to chime in briefly with two points:

* IMO Petko has a point: Emacs is expected to be conservative about
  tooling support: unless some optional tool is widely adopted, optional
  things are made... err... optional.  Of course this is for some value
  of "widely adpted"; one that the maintainer of said tool probably has
  a particularly generous conception of, ehehe.

  There was little discussion on this before 26.1 because it was all
  kinda rushed, because Dmitry is the maintainer of ruby-mode, and most
  importantly, nobody objected (much less I, who welcomed the enthusiasm
  for using the new API).  So even though Emacs 26.1 is a month old, the
  conservative stance is now to keep default.

* On the practical front, I personally dislike defcustom and prefer
  having flymake backends separate, so instead of having
  ruby-flymake-auto checks the defcustom, I advise Petko to use a
  directory-local variable in the project configuring
  flymake-diagnostic-functions to either ruby-flymake-simple or
  ruby-flymake-rubocop, i.e. some .dir-locals.el containing this

     (...
      (ruby-mode . (...
                    (flymake-diagnostic-functions ruby-flymake-simple)
                    ...))
      ...)
  
  Won't this suffice as a per-project (almost zero) configuration?

João
  

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.