GNU bug report logs - #31757
'guix system disk-image --format=iso9660' includes more than the OS closure

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31757: closed ('guix system disk-image --format=iso9660'
 includes more than the OS closure)
Date: Tue, 26 Jun 2018 12:32:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 26 Jun 2018 14:30:59 +0200
with message-id <874lhp6870.fsf <at> gnu.org>
and subject line Re: bug#31757: 'guix system disk-image --format=iso9660' includes more than the OS closure
has caused the debbugs.gnu.org bug report #31757,
regarding 'guix system disk-image --format=iso9660' includes more than the OS closure
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31757: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31757
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guix <at> gnu.org
Subject: 'guix system disk-image --format=iso9660' includes more than the OS
 closure
Date: Fri, 08 Jun 2018 15:23:27 +0200

Hey hey!

Turns out ‘guix system disk-image --format=iso9660’ includes not sure
the closure of the given OS, but everything that’s in the build
environment’s store.  So typically, we end up with QEMU and all in
addition to the store’s closure.

This stems from the fact that ‘make-iso9660-image’ does:

--8<---------------cut here---------------start------------->8---
    (apply invoke
           `(,grub-mkrescue "-o" ,target
                            ,(string-append "boot/grub/grub.cfg=" config-file)
                            ,(string-append "gnu/store=" os-drv "/..")
                            "etc=/tmp/root/etc"
                            "var=/tmp/root/var"
                            "run=/tmp/root/run"
                            ;; /mnt is used as part of the installation
                            ;; process, as the mount point for the target
                            ;; file system, so create it.
                            "mnt=/tmp/root/mnt"
                            "--"
                            "-volid" ,(string-upcase volume-id)
                            ,@(if volume-uuid
                                  `("-volume_date" "uuid"
                                    ,(string-filter (lambda (value)
                                                      (not (char=? #\- value)))
                                                    (iso9660-uuid->string
                                                     volume-uuid)))
                                  `())))
--8<---------------cut here---------------end--------------->8---

The “gnu/store=…” argument means we’re adding the whole store to the ISO.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: 31757-done <at> debbugs.gnu.org
Subject: Re: bug#31757: 'guix system disk-image --format=iso9660' includes
 more than the OS closure
Date: Tue, 26 Jun 2018 14:30:59 +0200

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Turns out ‘guix system disk-image --format=iso9660’ includes not sure
> the closure of the given OS, but everything that’s in the build
> environment’s store.  So typically, we end up with QEMU and all in
> addition to the store’s closure.

Fixed in 718d44cc9ff1a7e97b4e4ce028cc273c2e20cf93.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.