From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 06 21:50:05 2018 Received: (at submit) by debbugs.gnu.org; 7 Jun 2018 01:50:05 +0000 Received: from localhost ([127.0.0.1]:37276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQk3w-0003Hf-U7 for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:50:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQk3v-0003H8-5I for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:50:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQk3o-00072W-6z for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:49:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40748) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQk3o-00071q-1f for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:49:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQk3m-0001jd-6z for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 21:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQk3j-0006xq-1p for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 21:49:54 -0400 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]:37957) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQk3i-0006xQ-N7 for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 21:49:50 -0400 Received: by mail-io0-x22d.google.com with SMTP id l19-v6so9949761ioj.5 for ; Wed, 06 Jun 2018 18:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=Apky4rRGocB8rpWj0Hn0J0YQl6NftdvaH8ZI7T8ymPk=; b=l9eXa1GZmQppL53rH28o4dPv3kLk4u4RIL1hGGYTAiUOTwXVC+qToJjXBRkEOAM1Zw QzXQ0+xlirHHNpUQBpx6CJjRyxsN4xb7giOIG2TBWn6XRJk5UM6qD+XTZykmyCBBRvEf xP1P9x6E4m/rZxGxVOA/WIvYhRYWe6THYb4mFXw4T5Tqs936F3PiT3RCrVweO2Mw80n6 sg3BGrbmHv+RhqhgCaHd9R4IxoM6FRvtIpRZGBnigvGcFmTYYmEdrO6sXxWzl52og2Kx KweMTz2d5JjBV2hY7pxMEE40fW8l74qu6TQn9qpqiua1BK5gzXjFysFGMdckH7+Cl943 MlrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Apky4rRGocB8rpWj0Hn0J0YQl6NftdvaH8ZI7T8ymPk=; b=oiwi8VHyvHM2hu0F+lVQCp/nP35SYuIE5nuxB7IWLcj6mYRcEGemZMn4s9jr0eses/ H2Viq/v6ovJErxPNJE3lQjkr6WXcEhr/ESj9j+RSBgwwh3BwXu02Cl/zySOKAz3AmriH 8hqvXPTvgcHe2d9X5BRAsb8FZxyh21Egv0OIEnIRDYgzGxpJZuIissyhPo7+mUaKYYsL RdYq2CqgzTZ1tw+aHx4ytvxuoXnGG3BDtDfjhrtT5m7CbwdykPO3uVekMBW4bZBC+b/r gfS9SSaVVBwy+QCZHuXRN1YN8rpkZwTNFmHLNkGD0h5QLYCAXjcmYBo9yAFeSQ7IJGcR 9dUQ== X-Gm-Message-State: APt69E3VFGZ70DbakNa+yK2r4FO/TeYH1rf6evOJeBsRiGnMLrvuLICe AxUquCDsTvjVRwxeWItAPntbDA== X-Google-Smtp-Source: ADUXVKKD5SpbSALUeTu+vqZ6v1Xri2YRQnsFvHzl2T3AFuYyJ6NqaG9+11Ec/f3MIy8BRdTIY6kG8w== X-Received: by 2002:a6b:9dc3:: with SMTP id g186-v6mr5033132ioe.205.1528336189700; Wed, 06 Jun 2018 18:49:49 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k139-v6sm242914itk.27.2018.06.06.18.49.48 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jun 2018 18:49:48 -0700 (PDT) From: Noam Postavsky To: bug-gnu-emacs@gnu.org Subject: 26.1; Improvements to make tags and make -C test Date: Wed, 06 Jun 2018 21:49:47 -0400 Message-ID: <87muw72wn8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Severity: wishlist Tags: patch Some quality-of-life improvements in make targets. I hope these can go to emacs-26; although the test/Makefile.in changes aren't bug fixes, that file isn't distributed in the tarball. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-tags-targets-quieter-in-with-silent-rules-modes.patch Content-Description: patch >From 511a31788d63bdc7ee6dc877e1690dd79ad89c6d Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 7 Dec 2017 04:31:47 -0500 Subject: [PATCH 1/4] Make 'tags' targets quieter in --with-silent-rules modes * lisp/Makefile.in (TAGS): * src/Makefile.in (TAGS): Use AM_V_GEN and AM_V_at. --- lisp/Makefile.in | 6 +++--- src/Makefile.in | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/Makefile.in b/lisp/Makefile.in index d4709bd79d..05fca9579f 100644 --- a/lisp/Makefile.in +++ b/lisp/Makefile.in @@ -259,9 +259,9 @@ ${ETAGS}: ## compile-main. But maybe this is not even necessary any more now ## that this uses relative filenames. TAGS: ${ETAGS} ${tagsfiles} - rm -f $@ - touch $@ - ls ${tagsfiles} | xargs $(XARGS_LIMIT) "${ETAGS}" -a -o $@ + $(AM_V_at)rm -f $@ + $(AM_V_at)touch $@ + $(AM_V_GEN)ls ${tagsfiles} | xargs $(XARGS_LIMIT) "${ETAGS}" -a -o $@ # The src/Makefile.in has its own set of dependencies and when they decide diff --git a/src/Makefile.in b/src/Makefile.in index 15ca1667d6..d914dfebbd 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -680,7 +680,7 @@ ctagsfiles2 = ## because etags "--include" only includes a pointer to the file, ## rather than the file contents. TAGS: ${ETAGS} $(ctagsfiles1) $(ctagsfiles2) - ${ETAGS} --include=../lisp/TAGS --include=$(lwlibdir)/TAGS \ + $(AM_V_GEN)${ETAGS} --include=../lisp/TAGS --include=$(lwlibdir)/TAGS \ --regex='{c}/[ ]*DEFVAR_[A-Z_ (]+"\([^"]+\)"/\1/' \ --regex='{c}/[ ]*DEFVAR_[A-Z_ (]+"[^"]+",[ ]\([A-Za-z0-9_]+\)/\1/' \ $(ctagsfiles1) \ -- 2.11.0 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-Make-TAGS-file-in-the-srcdir-for-out-of-tree-builds.patch Content-Description: patch >From 83bc64364d21712865913ca5b4627c3ea8ec0071 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 13 Dec 2017 21:12:21 -0500 Subject: [PATCH 2/4] Make TAGS file in the srcdir for out-of-tree builds * Makefile.in: * lisp/Makefile.in: * lwlib/Makefile.in: * src/Makefile.in: Create TAGS files in ${srcdir}, not build dir. --- Makefile.in | 2 +- lisp/Makefile.in | 2 +- lwlib/Makefile.in | 6 +++--- src/Makefile.in | 18 ++++++++++-------- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/Makefile.in b/Makefile.in index 238df40ded..8a0a505320 100644 --- a/Makefile.in +++ b/Makefile.in @@ -929,7 +929,7 @@ extraclean: $(extraclean_dirs: # The src subdir knows how to do the right thing # even when the build directory and source dir are different. .PHONY: TAGS tags -TAGS tags: lib lib-src src +${srcdir}/TAGS tags: lib lib-src src $(MAKE) -C src tags .PHONY: have-tests diff --git a/lisp/Makefile.in b/lisp/Makefile.in index 05fca9579f..373ce60d12 100644 --- a/lisp/Makefile.in +++ b/lisp/Makefile.in @@ -258,7 +258,7 @@ ${ETAGS}: ## etags. It might be better to use find in a similar way to ## compile-main. But maybe this is not even necessary any more now ## that this uses relative filenames. -TAGS: ${ETAGS} ${tagsfiles} +${srcdir}/TAGS: ${ETAGS} ${tagsfiles} $(AM_V_at)rm -f $@ $(AM_V_at)touch $@ $(AM_V_GEN)ls ${tagsfiles} | xargs $(XARGS_LIMIT) "${ETAGS}" -a -o $@ diff --git a/lwlib/Makefile.in b/lwlib/Makefile.in index 32d7a91f9b..1cb35337c9 100644 --- a/lwlib/Makefile.in +++ b/lwlib/Makefile.in @@ -129,8 +129,8 @@ ctagsfiles= FORCE: .PHONY: tags FORCE -tags: TAGS -TAGS: ${ETAGS} $(ctagsfiles) - ${ETAGS} $(ctagsfiles) +tags: ${srcdir}/TAGS +${srcdir}/TAGS: ${ETAGS} $(ctagsfiles) + $(AM_V_GEN)${ETAGS} -o $@ $(ctagsfiles) ### Makefile.in ends here diff --git a/src/Makefile.in b/src/Makefile.in index d914dfebbd..cb4f8ae6c6 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -674,13 +674,15 @@ ${ETAGS}: ctagsfiles1 = $(wildcard ${srcdir}/*.[hc]) ctagsfiles2 = $(wildcard ${srcdir}/*.m) -## FIXME? In out-of-tree builds, should TAGS be generated in srcdir? +## In out-of-tree builds, TAGS should be generated in srcdir. ## This does not need to depend on ../lisp and ../lwlib TAGS files, ## because etags "--include" only includes a pointer to the file, -## rather than the file contents. -TAGS: ${ETAGS} $(ctagsfiles1) $(ctagsfiles2) - $(AM_V_GEN)${ETAGS} --include=../lisp/TAGS --include=$(lwlibdir)/TAGS \ +## rather than the file contents. The "--include" reference is +## relative to the location of the generated TAGS file, so it doesn't +## need to use ${srcdir}. +${srcdir}/TAGS: ${ETAGS} $(ctagsfiles1) $(ctagsfiles2) + $(AM_V_GEN)${ETAGS} -o $@ --include=../lisp/TAGS --include=$(lwlibdir)/TAGS \ --regex='{c}/[ ]*DEFVAR_[A-Z_ (]+"\([^"]+\)"/\1/' \ --regex='{c}/[ ]*DEFVAR_[A-Z_ (]+"[^"]+",[ ]\([A-Za-z0-9_]+\)/\1/' \ $(ctagsfiles1) \ @@ -690,13 +692,13 @@ TAGS: ## Arrange to make tags tables for ../lisp and ../lwlib, ## which the above TAGS file for the C files includes by reference. -../lisp/TAGS: FORCE - $(MAKE) -C ../lisp TAGS ETAGS="$(ETAGS)" +${srcdir}/../lisp/TAGS: FORCE + $(MAKE) -C ../lisp ${top_srcdir}/lisp/TAGS ETAGS="$(ETAGS)" -$(lwlibdir)/TAGS: FORCE +${srcdir}/$(lwlibdir)/TAGS: FORCE $(MAKE) -C $(lwlibdir) TAGS ETAGS="$(ETAGS)" -tags: TAGS ../lisp/TAGS $(lwlibdir)/TAGS +tags: ${srcdir}/TAGS ${srcdir}/../lisp/TAGS ${srcdir}/$(lwlibdir)/TAGS .PHONY: tags -- 2.11.0 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0003-test-Makefile.in-Add-TEST_INTERACTIVE-option.patch Content-Description: patch >From 02d9d15d5ead3a4f6e1451e3f2cc2d6e49cafa24 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 16 Dec 2017 20:06:11 -0500 Subject: [PATCH 3/4] ; test/Makefile.in: Add TEST_INTERACTIVE option. --- test/Makefile.in | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/test/Makefile.in b/test/Makefile.in index e6b3f77523..8c5c3a38d0 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -81,7 +81,7 @@ EMACS_EXTRAOPT= # Command line flags for Emacs. # Apparently MSYS bash would convert "-L :" to "-L ;" anyway, # but we might as well be explicit. -EMACSOPT = -batch --no-site-file --no-site-lisp -L "$(SEPCHAR)$(srcdir)" $(EMACS_EXTRAOPT) +EMACSOPT = --no-init-file --no-site-file --no-site-lisp -L "$(SEPCHAR)$(srcdir)" $(EMACS_EXTRAOPT) # Prevent any settings in the user environment causing problems. unexport EMACSDATA EMACSDOC EMACSPATH GREP_OPTIONS @@ -94,6 +94,15 @@ GDB = # supported everywhere. TEST_LOCALE = C +# Set this to 'yes' to run the tests in an interactive instance. +TEST_INTERACTIVE ?= no + +ifeq ($(TEST_INTERACTIVE),yes) +TEST_RUN_ERT = --eval "(ert ${SELECTOR_ACTUAL})" +else +TEST_RUN_ERT = --batch --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG} +endif + # Whether to run tests from .el files in preference to .elc, we do # this by default since it gives nicer stacktraces. TEST_LOAD_EL ?= yes @@ -128,7 +137,7 @@ all: SELECTOR_DEFAULT = (quote (not (or (tag :expensive-test) (tag :unstable)))) SELECTOR_EXPENSIVE = (quote (not (tag :unstable))) -SELECTOR_ALL = nil +SELECTOR_ALL = t ifdef SELECTOR SELECTOR_ACTUAL=$(SELECTOR) else ifndef MAKECMDGOALS @@ -145,7 +154,7 @@ SELECTOR_ACTUAL= ## Byte-compile all test files to test for errors. %.elc: %.el - $(AM_V_ELC)$(emacs) -f batch-byte-compile $< + $(AM_V_ELC)$(emacs) --batch -f batch-byte-compile $< ## Save logs, and show logs for failed tests. WRITE_LOG = > $@ 2>&1 || { STAT=$$?; cat $@; exit $$STAT; } @@ -160,7 +169,7 @@ testloadfile = $(AM_V_at)${MKDIR_P} $(dir $@) $(AM_V_GEN)HOME=/nonexistent $(emacs) \ -l ert ${ert_opts} -l $(testloadfile) \ - --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG} + $(TEST_RUN_ERT) ifeq (@HAVE_MODULES@, yes) maybe_exclude_module_tests := @@ -260,8 +269,15 @@ .PHONY: ## We can't put LOGFILES as prerequisites, because that would stop the ## summarizing step from running when there is an error. check-doit: +ifeq ($(TEST_INTERACTIVE), yes) + HOME=/nonexistent $(emacs) \ + -l ert ${ert_opts} \ + $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \ + $(TEST_RUN_ERT) +else -@${MAKE} -k ${LOGFILES} - @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} + @$(emacs) --batch -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} +endif .PHONY: mostlyclean clean bootstrap-clean distclean maintainer-clean -- 2.11.0 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0004-Reduce-amount-of-quoting-for-SELECTOR-arg-in-make-C-.patch Content-Description: patch >From 9f84e96771d755f06c5e1c6dc0eb5dc85272991d Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 6 Jun 2018 21:25:52 -0400 Subject: [PATCH 4/4] ; Reduce amount of quoting for SELECTOR arg in 'make -C test' Before: make -C test SELECTOR='\"foo\"' make -C test SELECTOR='(quote (tag :some-tag))' After: make -C test SELECTOR='"foo"' make -C test SELECTOR='(tag :some-tag)' * test/Makefile.in: Use single quotes around the command line call to ert, this means the user doesn't have to backslash escape double quotes when writing lisp strings for the selector. Also wrap the SELECTOR value in (quote ...) so the user won't have to type it in (and not get tempted to use the '... form which would now fail to work due to using single quotes around the whole shell arg). --- test/Makefile.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/Makefile.in b/test/Makefile.in index 8c5c3a38d0..bc4140879d 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -98,9 +98,9 @@ TEST_LOCALE = TEST_INTERACTIVE ?= no ifeq ($(TEST_INTERACTIVE),yes) -TEST_RUN_ERT = --eval "(ert ${SELECTOR_ACTUAL})" +TEST_RUN_ERT = --eval '(ert (quote ${SELECTOR_ACTUAL}))' else -TEST_RUN_ERT = --batch --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG} +TEST_RUN_ERT = --batch --eval '(ert-run-tests-batch-and-exit (quote ${SELECTOR_ACTUAL}))' ${WRITE_LOG} endif # Whether to run tests from .el files in preference to .elc, we do @@ -135,8 +135,8 @@ .PHONY: all: check -SELECTOR_DEFAULT = (quote (not (or (tag :expensive-test) (tag :unstable)))) -SELECTOR_EXPENSIVE = (quote (not (tag :unstable))) +SELECTOR_DEFAULT = (not (or (tag :expensive-test) (tag :unstable))) +SELECTOR_EXPENSIVE = (not (tag :unstable)) SELECTOR_ALL = t ifdef SELECTOR SELECTOR_ACTUAL=$(SELECTOR) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 11:39:07 2018 Received: (at 31744) by debbugs.gnu.org; 8 Jun 2018 15:39:07 +0000 Received: from localhost ([127.0.0.1]:39851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRJTn-00087B-0V for submit@debbugs.gnu.org; Fri, 08 Jun 2018 11:39:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRJTl-00086i-9Y for 31744@debbugs.gnu.org; Fri, 08 Jun 2018 11:39:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRJTc-0004hX-Ud for 31744@debbugs.gnu.org; Fri, 08 Jun 2018 11:39:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRJTc-0004hR-QK; Fri, 08 Jun 2018 11:38:56 -0400 Received: from [176.228.60.248] (port=1685 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRJTb-0004le-OD; Fri, 08 Jun 2018 11:38:56 -0400 Date: Fri, 08 Jun 2018 18:38:53 +0300 Message-Id: <83zi05thiq.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87muw72wn8.fsf@gmail.com> (message from Noam Postavsky on Wed, 06 Jun 2018 21:49:47 -0400) Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test References: <87muw72wn8.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Wed, 06 Jun 2018 21:49:47 -0400 > > Some quality-of-life improvements in make targets. I hope these can go > to emacs-26; although the test/Makefile.in changes aren't bug fixes, > that file isn't distributed in the tarball. Thanks for your work on this. A few comments below: > * src/Makefile.in: Create TAGS files in ${srcdir}, not build dir. I'm not sure I agree with this. Other projects I looked at produce TAGS in the build directory (but reference source files in srcdir, of course). Why do you think TAGS should go to the source directory? > +ifeq ($(TEST_INTERACTIVE), yes) > + HOME=/nonexistent $(emacs) \ > + -l ert ${ert_opts} \ > + $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \ > + $(TEST_RUN_ERT) > +else > -@${MAKE} -k ${LOGFILES} > - @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} > + @$(emacs) --batch -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} > +endif Not sure I understand the HOME trick: why not use -Q? > Subject: [PATCH 4/4] ; Reduce amount of quoting for SELECTOR arg in 'make -C > test' > > Before: > > make -C test SELECTOR='\"foo\"' > make -C test SELECTOR='(quote (tag :some-tag))' > > After: > > make -C test SELECTOR='"foo"' > make -C test SELECTOR='(tag :some-tag)' > > * test/Makefile.in: Use single quotes around the command line call to > ert, this means the user doesn't have to backslash escape double > quotes when writing lisp strings for the selector. Also wrap the > SELECTOR value in (quote ...) so the user won't have to type it > in (and not get tempted to use the '... form which would now fail to > work due to using single quotes around the whole shell arg). This should be explained in some README in the test suite, I think. I have no objections to making these changes on the emacs-26 branch. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 12:04:11 2018 Received: (at 31744) by debbugs.gnu.org; 8 Jun 2018 16:04:11 +0000 Received: from localhost ([127.0.0.1]:39875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRJs3-0000Fq-0e for submit@debbugs.gnu.org; Fri, 08 Jun 2018 12:04:11 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:38178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRJs1-0000Fc-AU for 31744@debbugs.gnu.org; Fri, 08 Jun 2018 12:04:09 -0400 Received: by mail-wr0-f171.google.com with SMTP id e18-v6so5671841wrs.5 for <31744@debbugs.gnu.org>; Fri, 08 Jun 2018 09:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=genBmUfg3vtaPTyIdNBDxr7KDs6V0sv3uzZKm3hoS/s=; b=YU81c6xzZvWd149KO2u4QvvMC+Yocfo7rDUWvjVGPxy6GsTFF0CVEUMtotrci/UxUj 78P5VL+ddIAPIXnKWqR+KX9S0v0AoyGObHcI2vfeBd/etzIQ/B+Nl8/t1GyRY/dxtmw2 A9N8/oEef2JdGuh3Rd0779egw7W6z04Igae0jx0nAY1zyMhWYR++qk0T74WXSiSSC/Cm K4+yj3vshfpw9Ngr5UYvnJveaJF9btk3YPFAd598ViPQyABqpHOL8cQRJE2bVTyON5i7 rbgR5Ai8OKWMYI28n+Ms2IfYv9Ol9QZkgjc6z7LKyYlfwgkvNL35EBFOWCX+0gmjvhLd XeXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=genBmUfg3vtaPTyIdNBDxr7KDs6V0sv3uzZKm3hoS/s=; b=V1Kp6WT8OhlLMxsTIeyoBCuoRxJGL1rxwc/bWPAC9Iy4rh4gUWI/Y3W/d/Ql2JTs4z 9qFBMJnd4PuYUXTh4P1CkASzaeyRMwQ8nXMUgSg90EqFBAfxBxpp3rirbUoOgAMMmIoo kGLktn1H8Gbkvu1Ydoh0vvaLj75LBNZakXTF045QNnvXSVOUgkGWvO0Iw7zrMGHYpJJU Ylk8kkhpZWihDUQIHEYuc2uo6IQyy5SoM4hhqi2DWmYHbA1HwnRr3dd3W6qU4Qpz5m/W 8M64DehCtwnkTrRZ0zJxonr1naW8tfbdo63gCaJqXilf47rRT9itAM1YToRcWizoWvuY dkrA== X-Gm-Message-State: APt69E18FIBQY7H7CRd27R+8ch2ev9VUoBkPmechF0WWtGq65dpNn+o3 pUD3V3BKMiVjDTk1xD9snF5dZuPXSnw= X-Google-Smtp-Source: ADUXVKL+h91ednbrDY5+wKURQm1n3tGDFDPPo7/meTe4jrvOxXtxnb33fMBQIj7MAu2DgMkYLuwdjA== X-Received: by 2002:adf:f344:: with SMTP id e4-v6mr5507552wrp.161.1528473843404; Fri, 08 Jun 2018 09:04:03 -0700 (PDT) Received: from rpluim (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id u3-v6sm33170987wrm.60.2018.06.08.09.04.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 09:04:02 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test References: <87muw72wn8.fsf@gmail.com> <83zi05thiq.fsf@gnu.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 08 Jun 2018 18:04:01 +0200 In-Reply-To: <83zi05thiq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Jun 2018 18:38:53 +0300") Message-ID: <87po11jmdq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Wed, 06 Jun 2018 21:49:47 -0400 >> >> Some quality-of-life improvements in make targets. I hope these can go >> to emacs-26; although the test/Makefile.in changes aren't bug fixes, >> that file isn't distributed in the tarball. > > Thanks for your work on this. A few comments below: > >> * src/Makefile.in: Create TAGS files in ${srcdir}, not build dir. > > I'm not sure I agree with this. Other projects I looked at produce > TAGS in the build directory (but reference source files in srcdir, of > course). Why do you think TAGS should go to the source directory? They should not. Source should be able to be mounted read-only, and all build products should be stored elsewhere. Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 21:12:15 2018 Received: (at 31744) by debbugs.gnu.org; 9 Jun 2018 01:12:15 +0000 Received: from localhost ([127.0.0.1]:40167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRSQP-0000Bb-Uv for submit@debbugs.gnu.org; Fri, 08 Jun 2018 21:12:15 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:42854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRSQO-0000BK-8w for 31744@debbugs.gnu.org; Fri, 08 Jun 2018 21:12:12 -0400 Received: by mail-io0-f178.google.com with SMTP id r24-v6so17860316ioh.9 for <31744@debbugs.gnu.org>; Fri, 08 Jun 2018 18:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ys4nwgteVStSc74StpPcH6xw+/5CtpomisWGM05PauI=; b=IP32MLAOJxRIqWJYPdOGwcxOcb+d//R3HVKT3JPMDyo4KVWzxuqFtYuFqQ+c536sDo U7PNJ2dS+YoI6iZ3N7OPlJSnSqeT7b7aoGC5c63a4CWBD4nP4xn7a54f7vlAhAzgbSqa OtSRgS8has9bEDq0ypf1rpDe5LKNRD0nDp5zJQmLfF+PrEZnzrmrKGUh/n7BrPeGQ7az 662rP0hLY3hUrPuFjggizywerab4lUFqPHVIyvgscBHELXmUYMg3uM3wcpiuTJFppoaZ r0AsXZ2qoZsdIcJLF7VJMEFQy8/4Sc/fUYmWeaBhvLLenwvaShDuJXthxzDTbq6Fv7t3 TtBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ys4nwgteVStSc74StpPcH6xw+/5CtpomisWGM05PauI=; b=fV+CIQCXO+xqZVvpArmoI+Q7me+o7Dv7zZle7FzPoHkN1dcGzusGSH2419K8V/VqST 2/W7QWRly15mpWOUwXx3fXCP11vnukoGtsfgEol9bRB6Kphqd7ywZBCfE0PwugGShGAz QuSRY/6Gxer3nH40pNP0BOvajHGaCYbjtlMnBFanSgJUwLd323/66kRYrtCOGvUPCu88 PVJ57KesdXL0wO29BUu2MGdQtxs/VLsEQdisJ+MZW8qBzhuUDeGjKPW7gHtoOr+Zw9Em 0NU7NUFiS/CSqgTixQxnXbuEX6RG4rrqOTjN1o7a0xAKrKk3mXPFA1Vzr5C5xk62LVxT yOFg== X-Gm-Message-State: APt69E2o4+YUMujgrCD4nlXq/SXGQvlmgmcImFjc3AroOkO7gZPd3BKQ eOF9YYf8/Q45vPhR2JAkyoFmgQ== X-Google-Smtp-Source: ADUXVKIkZxUjA5FtrVz2Vaa3XaIEJPXcde9HSrnVdZEiT976eYvq7IHOqlx00AtxOMrWjr8gJq65Fw== X-Received: by 2002:a6b:9403:: with SMTP id w3-v6mr232225iod.108.1528506726740; Fri, 08 Jun 2018 18:12:06 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c102-v6sm2833134itd.3.2018.06.08.18.12.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 18:12:05 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test References: <87muw72wn8.fsf@gmail.com> <83zi05thiq.fsf@gnu.org> <87po11jmdq.fsf@gmail.com> Date: Fri, 08 Jun 2018 21:12:04 -0400 In-Reply-To: <87po11jmdq.fsf@gmail.com> (Robert Pluim's message of "Fri, 08 Jun 2018 18:04:01 +0200") Message-ID: <87po10226z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> * src/Makefile.in: Create TAGS files in ${srcdir}, not build dir. >> >> I'm not sure I agree with this. Other projects I looked at produce >> TAGS in the build directory (but reference source files in srcdir, of >> course). Why do you think TAGS should go to the source directory? Oh, hmm. The original reason, is that when looking at a source file in Emacs, and then hitting M-. I get a prompt to visit the TAGS table, which starts from the source directory. Then I have to go looking for the TAGS file in the corresponding build directory. This seems kind of silly, especially since every build directory will have identical TAGS files anyway (meaning I either have to make TAGS redundantly per-build directory, or remember exactly which build directory has the TAGS file). I saw the FIXME in Makefile.in, so I assumed (oops!) this was some well-known problem, and that nobody had bothered to make the obvious fix yet. > They should not. Source should be able to be mounted read-only, and > all build products should be stored elsewhere. Emacs puts .elc files in the source directory. I was under the impression that the general principal is that arch & config dependent files go in the build directory, and arch & config independent ones go in the source directory. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 02:21:01 2018 Received: (at 31744) by debbugs.gnu.org; 9 Jun 2018 06:21:01 +0000 Received: from localhost ([127.0.0.1]:40239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXFF-0007WB-GF for submit@debbugs.gnu.org; Sat, 09 Jun 2018 02:21:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXFE-0007Vy-Cm for 31744@debbugs.gnu.org; Sat, 09 Jun 2018 02:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRXF6-0003XX-48 for 31744@debbugs.gnu.org; Sat, 09 Jun 2018 02:20:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRXF5-0003XN-Vw; Sat, 09 Jun 2018 02:20:52 -0400 Received: from [176.228.60.248] (port=2475 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRXF4-0008V9-DO; Sat, 09 Jun 2018 02:20:51 -0400 Date: Sat, 09 Jun 2018 09:20:53 +0300 Message-Id: <83fu1wtr96.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87po10226z.fsf@gmail.com> (message from Noam Postavsky on Fri, 08 Jun 2018 21:12:04 -0400) Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test References: <87muw72wn8.fsf@gmail.com> <83zi05thiq.fsf@gnu.org> <87po11jmdq.fsf@gmail.com> <87po10226z.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: 31744@debbugs.gnu.org > Date: Fri, 08 Jun 2018 21:12:04 -0400 > > >>> * src/Makefile.in: Create TAGS files in ${srcdir}, not build dir. > >> > >> I'm not sure I agree with this. Other projects I looked at produce > >> TAGS in the build directory (but reference source files in srcdir, of > >> course). Why do you think TAGS should go to the source directory? > > Oh, hmm. The original reason, is that when looking at a source file in > Emacs, and then hitting M-. I get a prompt to visit the TAGS table, > which starts from the source directory. Then I have to go looking for > the TAGS file in the corresponding build directory. I have grown a habit a long time ago to "M-x visit-tags-table" before I issue the first "M-." command. The default prompt is fine, because what else would you expect Emacs to do in that case? But no one said that default is correct in every single use case. E.g., a project could have one TAGS file in a top-level directory, and you may be visiting a file in a subdirectory. > especially since every build directory will have identical TAGS > files anyway That's what happens currently, but it isn't carved in stone. We could, for example, have TAGS reflect only the files that are compiled in on the current platform; other projects (like GDB, for example) do just that. Then each build will have a different TAGS file. > > They should not. Source should be able to be mounted read-only, and > > all build products should be stored elsewhere. > > Emacs puts .elc files in the source directory. *.elc files are generated at bootstrap time; when you build a tarball, they are already there. By contrast, TAGS is built at build time and doesn't come with the release tarball. > I was under the impression that the general principal is that arch & > config dependent files go in the build directory, and arch & config > independent ones go in the source directory. No, I think the principle is that the source tree holds everything that comes with a release tarball. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 15:16:13 2018 Received: (at 31744) by debbugs.gnu.org; 9 Jun 2018 19:16:14 +0000 Received: from localhost ([127.0.0.1]:41509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRjLP-0004YL-E4 for submit@debbugs.gnu.org; Sat, 09 Jun 2018 15:16:11 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:36177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRjLN-0004Y8-8I for 31744@debbugs.gnu.org; Sat, 09 Jun 2018 15:16:09 -0400 Received: by mail-it0-f53.google.com with SMTP id j135-v6so6480578itj.1 for <31744@debbugs.gnu.org>; Sat, 09 Jun 2018 12:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=zGCD8XMs0GZeuRcYpdwH2thhUlhKIT5XL8mSk3AiP7s=; b=BWUIQ72sa4wmd6YegEWdvVW/1Wf7Qg2XIyI9xkF3FU8kaRn/lYlz4DQ57AtcN7XAcz WMjXjt4IvV4ILj1ATyf4zOac+viXqdlTfiuZQrudd1rR5xYq+fkM/wKIAPmL4X7acaEy l9jvkf2hBGXIK6KCRuGfnNq/z8MZzom4De6l0M3Baqg01sm7zJsLRMGOxkWQkFa9kwww YW8vszNUO5DT1oa73xItCGZVQI9ORNy//1p4AFiGjtWy9eI8/A9ad1d+ozBjXrS2HwrU 9c8qqzjQwySyvJMwkugYqEQrQE2Iz817+pyz2XEBo5N11BjdB/vZNhhNvBMbiGfyEYgV 0xmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=zGCD8XMs0GZeuRcYpdwH2thhUlhKIT5XL8mSk3AiP7s=; b=ipNtorOUYRw3cU1OZjDRXKtsg0oyNwy+KWG7CwkSqN96TEiqCAauLW6tAgcmOMLYL1 lunXteeYZjpNrP/wgEOv6bTTpAYzyjl45cEkpSiwGj6HGdZWuppaY6/7t81Ca6Zg/NK4 jXvKEMsuMDFtz5Stp1d1if9vVL5mDRlEWyC8Psk9xrfAm7VDN0SGNSWhYw0dIwHYE6WD J6XbWHDheXbsOErJGQz36KYSwupKy53b5N1PGGqOximlGZtUygq0Q4Sl6pBoGmNimiwS 2jjsbiJ01yZi96/5KST8Ya8WCK7HDi5mRNlP9RiHELcZ+zwwH/WE9/z+JIPTs/KuVOeN nxSQ== X-Gm-Message-State: APt69E3MhRXySMSCXXUHBwu0CdOE+3AdwM9gQ0aERWwpi8q+QUETjGbI KD8dU9Hdvahgsq/POoMg5eVZLw== X-Google-Smtp-Source: ADUXVKKW46AahSMSh7lGDuJ46q2Z6HaNYvdScNyD+1s5rtjq3URk7IKzvwxtEsfH1DNU0kMbnbCoww== X-Received: by 2002:a24:42d2:: with SMTP id i201-v6mr2019067itb.125.1528571763548; Sat, 09 Jun 2018 12:16:03 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m13-v6sm8959074iob.86.2018.06.09.12.16.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 12:16:02 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test In-Reply-To: <83fu1wtr96.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Jun 2018 09:20:53 +0300") References: <87muw72wn8.fsf@gmail.com> <83zi05thiq.fsf@gnu.org> <87po11jmdq.fsf@gmail.com> <87po10226z.fsf@gmail.com> <83fu1wtr96.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Sat, 09 Jun 2018 15:16:00 -0400 Message-ID: <878t7n22kv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Oh, hmm. The original reason, is that when looking at a source file in >> Emacs, and then hitting M-. I get a prompt to visit the TAGS table, >> which starts from the source directory. Then I have to go looking for >> the TAGS file in the corresponding build directory. > > I have grown a habit a long time ago to "M-x visit-tags-table" before > I issue the first "M-." command. > > The default prompt is fine, because what else would you expect Emacs > to do in that case? Yeah, there's no way for Emacs to know where the build directory is. Maybe I'll add symlinks locally to work around this. >> especially since every build directory will have identical TAGS >> files anyway > > That's what happens currently, but it isn't carved in stone. We > could, for example, have TAGS reflect only the files that are compiled > in on the current platform; other projects (like GDB, for example) do > just that. Then each build will have a different TAGS file. I hope not, that sounds inconvenient to me. > No, I think the principle is that the source tree holds everything > that comes with a release tarball. Okay, I dropped this change, and updated the FIXME comment to mention this instead. Going back to a question from earlier in the thread: >> +ifeq ($(TEST_INTERACTIVE), yes) >> + HOME=/nonexistent $(emacs) \ >> + -l ert ${ert_opts} \ >> + $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \ >> + $(TEST_RUN_ERT) >> +else >> -@${MAKE} -k ${LOGFILES} >> - @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} >> + @$(emacs) --batch -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} >> +endif > Not sure I understand the HOME trick: why not use -Q? $(emacs) already includes -Q (or rather, the equivalent long options --no-init-file --no-site-file --no-site-lisp). The HOME trick was added in [d17aa3e535] and [412c38aa28]. I can't find a specific discussion, but http://lists.gnu.org/archive/html/emacs-devel/2017-05/msg00641.html seems related. I've added a comment to explain this better. [412c38aa28]: 2017-05-30 08:39:39 -0700 Stop make check interacting with HOME https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=412c38aa28dd7e8363b481a09d1df62c40f9a5b7 [d17aa3e535]: 2017-05-30 12:50:54 -0400 Reduce scope of recent test/Makefile HOME change https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d17aa3e535bba5e93ff188d5460c91001074255e --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v2-0001-Make-tags-targets-respect-with-silent-rules-Bug-3.patch Content-Description: patch >From 9078572053aed5e7cd9aa26d9dcff9409b7148e4 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 7 Dec 2017 04:31:47 -0500 Subject: [PATCH v2 1/3] Make 'tags' targets respect --with-silent-rules (Bug#31744) * lwlib/Makefile.in (TAGS): * lisp/Makefile.in (TAGS): * src/Makefile.in (TAGS): Use AM_V_GEN and AM_V_at. * src/Makefile.in: Note that TAGS are generated in build dir. --- lisp/Makefile.in | 6 +++--- lwlib/Makefile.in | 2 +- src/Makefile.in | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/lisp/Makefile.in b/lisp/Makefile.in index d4709bd79d..05fca9579f 100644 --- a/lisp/Makefile.in +++ b/lisp/Makefile.in @@ -259,9 +259,9 @@ ${ETAGS}: ## compile-main. But maybe this is not even necessary any more now ## that this uses relative filenames. TAGS: ${ETAGS} ${tagsfiles} - rm -f $@ - touch $@ - ls ${tagsfiles} | xargs $(XARGS_LIMIT) "${ETAGS}" -a -o $@ + $(AM_V_at)rm -f $@ + $(AM_V_at)touch $@ + $(AM_V_GEN)ls ${tagsfiles} | xargs $(XARGS_LIMIT) "${ETAGS}" -a -o $@ # The src/Makefile.in has its own set of dependencies and when they decide diff --git a/lwlib/Makefile.in b/lwlib/Makefile.in index 32d7a91f9b..6bd2608381 100644 --- a/lwlib/Makefile.in +++ b/lwlib/Makefile.in @@ -131,6 +131,6 @@ FORCE: .PHONY: tags FORCE tags: TAGS TAGS: ${ETAGS} $(ctagsfiles) - ${ETAGS} $(ctagsfiles) + $(AM_V_GEN)${ETAGS} $(ctagsfiles) ### Makefile.in ends here diff --git a/src/Makefile.in b/src/Makefile.in index 15ca1667d6..6ed8f3cc91 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -674,13 +674,14 @@ ${ETAGS}: ctagsfiles1 = $(wildcard ${srcdir}/*.[hc]) ctagsfiles2 = $(wildcard ${srcdir}/*.m) -## FIXME? In out-of-tree builds, should TAGS be generated in srcdir? +## In out-of-tree builds, TAGS are generated in the build dir, like +## other non-bootstrap build products (see Bug#31744). ## This does not need to depend on ../lisp and ../lwlib TAGS files, ## because etags "--include" only includes a pointer to the file, ## rather than the file contents. TAGS: ${ETAGS} $(ctagsfiles1) $(ctagsfiles2) - ${ETAGS} --include=../lisp/TAGS --include=$(lwlibdir)/TAGS \ + $(AM_V_GEN)${ETAGS} --include=../lisp/TAGS --include=$(lwlibdir)/TAGS \ --regex='{c}/[ ]*DEFVAR_[A-Z_ (]+"\([^"]+\)"/\1/' \ --regex='{c}/[ ]*DEFVAR_[A-Z_ (]+"[^"]+",[ ]\([A-Za-z0-9_]+\)/\1/' \ $(ctagsfiles1) \ -- 2.11.0 --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v2-0002-test-Makefile.in-Add-TEST_INTERACTIVE-option-Bug-.patch Content-Description: patch >From 2c2dfd66718d464288c91824ecff8564ee6f3d91 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 16 Dec 2017 20:06:11 -0500 Subject: [PATCH v2 2/3] ; test/Makefile.in: Add TEST_INTERACTIVE option (Bug#31744). * test/README: Note the new option. --- test/Makefile.in | 33 +++++++++++++++++++++++++++------ test/README | 6 ++++++ 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/test/Makefile.in b/test/Makefile.in index e6b3f77523..451513a747 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -81,7 +81,7 @@ EMACS_EXTRAOPT= # Command line flags for Emacs. # Apparently MSYS bash would convert "-L :" to "-L ;" anyway, # but we might as well be explicit. -EMACSOPT = -batch --no-site-file --no-site-lisp -L "$(SEPCHAR)$(srcdir)" $(EMACS_EXTRAOPT) +EMACSOPT = --no-init-file --no-site-file --no-site-lisp -L "$(SEPCHAR)$(srcdir)" $(EMACS_EXTRAOPT) # Prevent any settings in the user environment causing problems. unexport EMACSDATA EMACSDOC EMACSPATH GREP_OPTIONS @@ -94,6 +94,15 @@ GDB = # supported everywhere. TEST_LOCALE = C +# Set this to 'yes' to run the tests in an interactive instance. +TEST_INTERACTIVE ?= no + +ifeq ($(TEST_INTERACTIVE),yes) +TEST_RUN_ERT = --eval "(ert ${SELECTOR_ACTUAL})" +else +TEST_RUN_ERT = --batch --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG} +endif + # Whether to run tests from .el files in preference to .elc, we do # this by default since it gives nicer stacktraces. TEST_LOAD_EL ?= yes @@ -120,6 +129,11 @@ emacs = EMACS_TEST_DIRECTORY=$(abspath $(srcdir)) \ $(GDB) "$(EMACS)" $(MODULES_EMACSOPT) $(EMACSOPT) +# Set HOME to a nonexistent directory to prevent tests from accessing +# it accidentally (e.g., popping up a gnupg dialog if ~/.authinfo.gpg +# exists, or writing to ~/.bzr.log when running bzr commands). +TEST_HOME = /nonexistent + test_module_dir := $(srcdir)/data/emacs-module .PHONY: all check @@ -128,7 +142,7 @@ all: SELECTOR_DEFAULT = (quote (not (or (tag :expensive-test) (tag :unstable)))) SELECTOR_EXPENSIVE = (quote (not (tag :unstable))) -SELECTOR_ALL = nil +SELECTOR_ALL = t ifdef SELECTOR SELECTOR_ACTUAL=$(SELECTOR) else ifndef MAKECMDGOALS @@ -145,7 +159,7 @@ SELECTOR_ACTUAL= ## Byte-compile all test files to test for errors. %.elc: %.el - $(AM_V_ELC)$(emacs) -f batch-byte-compile $< + $(AM_V_ELC)$(emacs) --batch -f batch-byte-compile $< ## Save logs, and show logs for failed tests. WRITE_LOG = > $@ 2>&1 || { STAT=$$?; cat $@; exit $$STAT; } @@ -158,9 +172,9 @@ testloadfile = %.log: %.elc $(AM_V_at)${MKDIR_P} $(dir $@) - $(AM_V_GEN)HOME=/nonexistent $(emacs) \ + $(AM_V_GEN)HOME=$(TEST_HOME) $(emacs) \ -l ert ${ert_opts} -l $(testloadfile) \ - --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG} + $(TEST_RUN_ERT) ifeq (@HAVE_MODULES@, yes) maybe_exclude_module_tests := @@ -260,8 +274,15 @@ .PHONY: ## We can't put LOGFILES as prerequisites, because that would stop the ## summarizing step from running when there is an error. check-doit: +ifeq ($(TEST_INTERACTIVE), yes) + HOME=$(TEST_HOME) $(emacs) \ + -l ert ${ert_opts} \ + $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \ + $(TEST_RUN_ERT) +else -@${MAKE} -k ${LOGFILES} - @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} + @$(emacs) --batch -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} +endif .PHONY: mostlyclean clean bootstrap-clean distclean maintainer-clean diff --git a/test/README b/test/README index 1cd9db3bb8..c1dde2e0d0 100644 --- a/test/README +++ b/test/README @@ -50,6 +50,12 @@ nicer backtraces. To run the compiled version of a test use make TEST_LOAD_EL=no ... +The tests are run in batch mode by default; sometimes it's useful to +get precisely the same environment but run in interactive mode for +debugging. To do that, use + + make TEST_INTERACTIVE=yes ... + (Also, see etc/compilation.txt for compilation mode font lock tests.) -- 2.11.0 --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v2-0003-Reduce-quoting-for-SELECTOR-in-make-C-test-Bug-31.patch Content-Description: patch >From a86a31659937556059f34beb75df1cbff73c5464 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 6 Jun 2018 21:25:52 -0400 Subject: [PATCH v2 3/3] ; Reduce quoting for SELECTOR in 'make -C test' (Bug#31744) Before: make -C test SELECTOR='\"foo\"' make -C test SELECTOR='(quote (tag :some-tag))' After: make -C test SELECTOR='"foo"' make -C test SELECTOR='(tag :some-tag)' * test/Makefile.in: Use single quotes around the command line call to ert, this means the user doesn't have to backslash escape double quotes when writing lisp strings for the selector. Also wrap the SELECTOR value in (quote ...) so the user won't have to type it in (and not get tempted to use the '... reader syntax form which would now fail to work due to using single quotes around the whole shell arg). * test/README: Update instructions accordingly. --- test/Makefile.in | 8 ++++---- test/README | 5 ++++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/test/Makefile.in b/test/Makefile.in index 451513a747..597ef91311 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -98,9 +98,9 @@ TEST_LOCALE = TEST_INTERACTIVE ?= no ifeq ($(TEST_INTERACTIVE),yes) -TEST_RUN_ERT = --eval "(ert ${SELECTOR_ACTUAL})" +TEST_RUN_ERT = --eval '(ert (quote ${SELECTOR_ACTUAL}))' else -TEST_RUN_ERT = --batch --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG} +TEST_RUN_ERT = --batch --eval '(ert-run-tests-batch-and-exit (quote ${SELECTOR_ACTUAL}))' ${WRITE_LOG} endif # Whether to run tests from .el files in preference to .elc, we do @@ -140,8 +140,8 @@ .PHONY: all: check -SELECTOR_DEFAULT = (quote (not (or (tag :expensive-test) (tag :unstable)))) -SELECTOR_EXPENSIVE = (quote (not (tag :unstable))) +SELECTOR_DEFAULT = (not (or (tag :expensive-test) (tag :unstable))) +SELECTOR_EXPENSIVE = (not (tag :unstable)) SELECTOR_ALL = t ifdef SELECTOR SELECTOR_ACTUAL=$(SELECTOR) diff --git a/test/README b/test/README index c1dde2e0d0..e473248c9e 100644 --- a/test/README +++ b/test/README @@ -42,7 +42,10 @@ except the tests tagged as expensive. If your test file contains the tests "test-foo", "test2-foo" and "test-foo-remote", and you want to run only the former two tests, you -could use a selector regexp: "make SELECTOR='\"foo$$\"'". +could use a selector regexp (note that the "$" needs to be doubled to +protect against "make" variable expansion): + + make SELECTOR='"foo$$"' Note that although the test files are always compiled (unless they set no-byte-compile), the source files will be run by default, to give -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 12:59:45 2018 Received: (at 31744) by debbugs.gnu.org; 10 Jun 2018 16:59:45 +0000 Received: from localhost ([127.0.0.1]:42514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS3gv-0007IE-GG for submit@debbugs.gnu.org; Sun, 10 Jun 2018 12:59:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS3gu-0007Hw-KS for 31744@debbugs.gnu.org; Sun, 10 Jun 2018 12:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS3gm-0004Mb-4w for 31744@debbugs.gnu.org; Sun, 10 Jun 2018 12:59:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS3gm-0004MK-0a; Sun, 10 Jun 2018 12:59:36 -0400 Received: from [176.228.60.248] (port=4502 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fS3gl-0001Cs-7K; Sun, 10 Jun 2018 12:59:35 -0400 Date: Sun, 10 Jun 2018 19:59:41 +0300 Message-Id: <83y3fmr30i.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <878t7n22kv.fsf@gmail.com> (message from Noam Postavsky on Sat, 09 Jun 2018 15:16:00 -0400) Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test References: <87muw72wn8.fsf@gmail.com> <83zi05thiq.fsf@gnu.org> <87po11jmdq.fsf@gmail.com> <87po10226z.fsf@gmail.com> <83fu1wtr96.fsf@gnu.org> <878t7n22kv.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: 31744@debbugs.gnu.org > Date: Sat, 09 Jun 2018 15:16:00 -0400 > > >> especially since every build directory will have identical TAGS > >> files anyway > > > > That's what happens currently, but it isn't carved in stone. We > > could, for example, have TAGS reflect only the files that are compiled > > in on the current platform; other projects (like GDB, for example) do > > just that. Then each build will have a different TAGS file. > > I hope not, that sounds inconvenient to me. It depends. When you work in the build tree, it is reasonable to assume you are interested only in the files relevant to that build, so you won't want to see, e.g., w32term.c when you are working on an X build. > Going back to a question from earlier in the thread: > > >> +ifeq ($(TEST_INTERACTIVE), yes) > >> + HOME=/nonexistent $(emacs) \ > >> + -l ert ${ert_opts} \ > >> + $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \ > >> + $(TEST_RUN_ERT) > >> +else > >> -@${MAKE} -k ${LOGFILES} > >> - @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} > >> + @$(emacs) --batch -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES} > >> +endif > > > Not sure I understand the HOME trick: why not use -Q? > > $(emacs) already includes -Q (or rather, the equivalent long options > --no-init-file --no-site-file --no-site-lisp). The HOME trick was added > in [d17aa3e535] and [412c38aa28]. I can't find a specific discussion, > but http://lists.gnu.org/archive/html/emacs-devel/2017-05/msg00641.html > seems related. I've added a comment to explain this better. Thanks, I have no more comments. Please go ahead, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 07:49:41 2018 Received: (at 31744) by debbugs.gnu.org; 12 Jun 2018 11:49:41 +0000 Received: from localhost ([127.0.0.1]:44173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fShnx-0002M2-Mn for submit@debbugs.gnu.org; Tue, 12 Jun 2018 07:49:41 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:36178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fShnv-0002Lj-SY; Tue, 12 Jun 2018 07:49:40 -0400 Received: by mail-io0-f170.google.com with SMTP id k3-v6so13621198iog.3; Tue, 12 Jun 2018 04:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=V2mmTERXHOHmy74DFweFs1Rlk+NIr9PtD5rVxmWEVZk=; b=QIKNqYKIPYzTxJi7aQZpzmt84KLS8EgSdSmzodXrVYzkWZoIbGyLSnWYvGSzbFKJ8I 9LleGHVpcgTU2C3TuvfizrETR+bIrSX0omAxJj7em+cfAzBg2+qKvYsPSsKvBY/bo+w5 CFS8crp5U12twkUGiBw+4y9knCLnYF0LKeI8OXYHZ2k7qkxlz90sr3tfb3X1T2Hrr32q koErJhinudX2LuNrtBOKsfm8hiOU6IEYcQOJQ9Lo3JbpWuxXVgab6y3ZV7xgie5aLbgy AUysHtVjHBO4YLaAXbVxk3Y4lA2fTUZMHAlIgneyIefpt2vNZhtoBKUONKeLH9xCseOP cklQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=V2mmTERXHOHmy74DFweFs1Rlk+NIr9PtD5rVxmWEVZk=; b=MOu67GI0ec+dUwYvAi4Xs/4wKBlfi6b3XywTfIPICIzuEYzfiLq08N7bt0h1TIMQt3 Idum3KSJA7YvpbSv3IUwIeOGdtI6k/Oeyq2sFT8RPn9lV+f0n6iN1JXtfS+lrTA7+AnY sQAMSsHv/aCYHvX14Yk1F7LfKCBe/VbEeeR5sE/rPFV07ssDVJnQu4Mg6Ts/D+qPYaVT dbue7P9m/PGgMYsqXo/ARuRl+oZEWi5S4UBkQEiHfljJOfznbAv7NBJFRVWS4egqRF9c BmFrOKELS5AI1gka/V5Hm24dBIMDLv3qLbaClv5FAecOEkFKRqazxpXtfF+WN5FrRurM BDUA== X-Gm-Message-State: APt69E3iycUda88rsf+/h7OVkDyDpRrFUU2NqJT670k1YtG2Z8Wapwmk XcK5VwUw07asoDZJvvGfkNBXQQ== X-Google-Smtp-Source: ADUXVKKlgDumzoHslhF/amtlAQedE0NqKcOiqDpyz/XuFyxt2wI5ZJwYuE6hPYN4hs6hHv54S+bbsg== X-Received: by 2002:a6b:1e4d:: with SMTP id e74-v6mr65822ioe.36.1528804174394; Tue, 12 Jun 2018 04:49:34 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b128-v6sm88828itb.3.2018.06.12.04.49.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Jun 2018 04:49:33 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31744: 26.1; Improvements to make tags and make -C test References: <87muw72wn8.fsf@gmail.com> <83zi05thiq.fsf@gnu.org> <87po11jmdq.fsf@gmail.com> <87po10226z.fsf@gmail.com> <83fu1wtr96.fsf@gnu.org> <878t7n22kv.fsf@gmail.com> <83y3fmr30i.fsf@gnu.org> Date: Tue, 12 Jun 2018 07:49:32 -0400 In-Reply-To: <83y3fmr30i.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jun 2018 19:59:41 +0300") Message-ID: <87sh5sxm0j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31744 Cc: 31744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31744 fixed close 31744 26.2 quit Eli Zaretskii writes: > Thanks, I have no more comments. Please go ahead, and thanks. Pushed. [1: 1aa906f10d]: 2018-06-12 07:26:06 -0400 Make 'tags' targets respect --with-silent-rules (Bug#31744) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1aa906f10d3a5dc3905c2f74cddbfd8c6cb8eb7a [2: b6b793bd77]: 2018-06-12 07:26:06 -0400 ; test/Makefile.in: Add TEST_INTERACTIVE option (Bug#31744). https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b6b793bd77cb8be0a2d2745262e53037dc6798a0 [3: 5bdc344780]: 2018-06-12 07:26:06 -0400 ; Reduce quoting for SELECTOR in 'make -C test' (Bug#31744) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5bdc344780faabbc91b7e55306b2071dffb44fa2 From unknown Sat Aug 16 18:47:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Jul 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator