From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 06 21:07:38 2018 Received: (at submit) by debbugs.gnu.org; 7 Jun 2018 01:07:38 +0000 Received: from localhost ([127.0.0.1]:37254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQjOr-0002It-Rx for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:07:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQjOp-0002Ih-Go for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:07:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQjOj-00089r-2S for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:07:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45669) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQjOi-00089j-UU for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:07:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQjOh-0006MI-Lm for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 21:07:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQjOe-00087k-GR for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 21:07:27 -0400 Received: from mail-it0-x229.google.com ([2607:f8b0:4001:c0b::229]:54553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQjOe-00087J-8w for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 21:07:24 -0400 Received: by mail-it0-x229.google.com with SMTP id 76-v6so10685446itx.4 for ; Wed, 06 Jun 2018 18:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=sMUulrIYicxtHVFp7zy9cAzylmrBboWqsKZ3D6zwcGA=; b=vZwZ0ImePiWBr9zwut7hn2mZ2IJUshzn40rwIPGAti9OZIfgxpyeUisbDNg9bCpfxE OU0j7GNZBD+9218epoLbuTS8S3BeI6WryN3pPJzC7lww0lvhSg9NIDrzhJwAa4dkaCWR nDd5hc+L+tSnlzI+f75vgXu+zTiK4KAbeB1W7rbhsrRGa8A65fZdAK7g6OnyBfR8Ot9r 5x7SO3c8wcXUuP9O89QQPtiba+uMfTpr56Cw9Sf9RWokyNpiUoeArXe4ZEItNjzeWX+T oUOheK/BJEijIK/4QZdGa9vC7Hs38Hj2293fN5LpXysH8/aJIA/aTbiMQnEN9M42vDAN D3rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=sMUulrIYicxtHVFp7zy9cAzylmrBboWqsKZ3D6zwcGA=; b=BfwBiFA+xoV1yeNLzV8jao2sDUbo6m2Q+8SkPyP2twDoUiOWfYIM8s5vbg/1+P+XwC dagC/gu1MrEPjTh9DL8X9OwFkwWuMMZVZMxGBQ7nPwV8LznAxrsh19tckiopro7e44Mo tjn0dG7U/IjvmWAoSNW8RdBO3Pxw8Afjqw6qqj/UOaf0DD+d7+FFo+gIRIh7kXUKcAnV cNd5SoPVbL/JpB+83DgBueipDTTo0YoK/Srx+N3NyHPA1HluYv5Xh3IXiDqdUTDmQpkS CDumuX6R1pwOUyzfbfFd4uPdTphO3qqTJ3CvjobEULAwfo/KdrxHomH2AF0S2AyMziya Uibw== X-Gm-Message-State: APt69E0y4OB+npGYfQADF4EPQb81RYh8e31xea3yQM2qZEjmx55NXftg yLBp+3eUdEeCa5sSfAWx+eAOq4zg X-Google-Smtp-Source: ADUXVKIK1oNbgBhQCk35/Z5DGEjZGRAtNewvrfak+NrqsfQtyhFu/yQkXUI1Injmx0d1hlwsvbCV4g== X-Received: by 2002:a24:de0b:: with SMTP id d11-v6mr162071itg.5.1528333643013; Wed, 06 Jun 2018 18:07:23 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id k130-v6sm186362itb.0.2018.06.06.18.07.21 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jun 2018 18:07:22 -0700 (PDT) From: Thomas Fitzsimmons To: bug-gnu-emacs@gnu.org Subject: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Date: Wed, 06 Jun 2018 21:07:21 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=-=-= Content-Type: text/plain Hi, An Excorporate user reported an issue when running on Emacs 26.1 that didn't happen in Emacs 25.3. The error message, when trying to retrieve calendar items on a given day is: soap-find-operation: Wrong type argument: soap-binding, ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding") The simplest workaround is: M-x package-reinstall RET excorporate RET I narrowed the cause down to what seems to be an incompatibility between 25.x bytecode and 26.1. This issue only happens when excorporate.elc has been byte compiled in Emacs 25.x (the .x doesn't seem to matter; I replicated it on Emacs 25.1) and is then run in Emacs 26.1. It doesn't happen with a fresh package install on 25.x or 26.1. When in the failure state, if I re-eval this function: (defun exco--bind-wsdl (wsdl service-url port-name target-namespace binding-name) "Create a WSDL binding. Create a binding port for WSDL from SERVICE-URL, PORT-NAME, TARGET-NAMESPACE and BINDING-NAME." (let* ((namespace (soap-wsdl-find-namespace target-namespace wsdl)) (port (make-soap-port :name port-name :binding (cons target-namespace binding-name) :service-url service-url))) (soap-namespace-put port namespace) (push port (soap-wsdl-ports wsdl)) (soap-resolve-references port wsdl) wsdl)) everything works. In terms higher level functionality, it seems like the call to soap-resolve-references has no effect. I'm attaching the 25.1 and 26.1 bytecode for this function, disassembled. Maybe someone can identify what's wrong or suggest next steps? Thank you, Thomas --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=exco--bind-wsdl-dump-25.1.txt byte code for exco--bind-wsdl: doc: Create a WSDL binding. ... args: (arg1 arg2 arg3 arg4 arg5) 0 constant soap-wsdl-find-namespace 1 stack-ref 2 2 stack-ref 6 4 call 2 5 constant vector 6 constant cl-struct-soap-port 7 stack-ref 5 8 constant nil 9 stack-ref 8 11 stack-ref 7 13 stack-ref 7 15 cons 16 call 5 17 constant soap-namespace-put 18 stack-ref 1 19 stack-ref 3 20 call 2 21 discard 22 stack-ref 6 24 constant 0 25 aref 26 varref cl-struct-soap-wsdl-tags 27 memq 28 goto-if-not-nil 1 31 constant signal 32 constant wrong-type-argument 33 constant soap-wsdl 34 stack-ref 9 36 list2 37 call 2 38 discard 39:1 stack-ref 6 41 dup 42 constant 4 43 stack-ref 3 44 stack-ref 3 45 constant 4 46 aref 47 cons 48 aset 49 discardN 2 51 constant soap-resolve-references 52 stack-ref 1 53 stack-ref 8 55 call 2 56 discard 57 stack-ref 6 59 return --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=exco--bind-wsdl-dump-26.1.txt byte code for exco--bind-wsdl: doc: Create a WSDL binding. ... args: (arg1 arg2 arg3 arg4 arg5) 0 constant soap-wsdl-find-namespace 1 stack-ref 2 2 stack-ref 6 4 call 2 5 constant record 6 constant soap-port 7 stack-ref 5 8 constant nil 9 stack-ref 8 11 stack-ref 7 13 stack-ref 7 15 cons 16 call 5 17 constant soap-namespace-put 18 stack-ref 1 19 stack-ref 3 20 call 2 21 discard 22 constant type-of 23 stack-ref 7 25 call 1 26 varref cl-struct-soap-wsdl-tags 27 memq 28 goto-if-not-nil 1 31 constant signal 32 constant wrong-type-argument 33 constant soap-wsdl 34 stack-ref 9 36 list2 37 call 2 38 discard 39:1 stack-ref 6 41 dup 42 constant 4 43 stack-ref 3 44 stack-ref 3 45 constant 4 46 aref 47 cons 48 aset 49 discardN 2 51 constant soap-resolve-references 52 stack-ref 1 53 stack-ref 8 55 call 2 56 discard 57 stack-ref 6 59 return --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 06 21:14:57 2018 Received: (at 31742) by debbugs.gnu.org; 7 Jun 2018 01:14:58 +0000 Received: from localhost ([127.0.0.1]:37260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQjVx-0002TC-Nq for submit@debbugs.gnu.org; Wed, 06 Jun 2018 21:14:57 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:36557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQjVv-0002Sy-AV for 31742@debbugs.gnu.org; Wed, 06 Jun 2018 21:14:55 -0400 Received: by mail-io0-f177.google.com with SMTP id d73-v6so9890267iog.3 for <31742@debbugs.gnu.org>; Wed, 06 Jun 2018 18:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ZOV4tLJXfM3+u7bw1zGkGTnJ4e5KTsfvJ2F3sGBJ+yk=; b=jvMBH2pPn0VuwrahYxKcscfzz1js4Q7o4a3Hv1wD0T1IGBjJQwuuhCPbsdLlHMt7Ka gu09UAvCcwXt7sFhzrGovyCXfkzq/MpLqkHjQ0i4noce7tYkWP3oRPCv5LLNfWCqa/B2 CojhpBqE5uFmaeZ+PsrfCUyDKuDE9ydggxrCMVLfqoJGzTo5IkPckXbbWfxXItexPzeC FXUAVfgcG42A4wr9LV2BxW1bN9raKqX7mTNxZKgPMzo/2fkmwdt+gaRhRq/DZL4wXsdb JajqwdOOutDs+3y9basefD14O3cjEejYfSJuajNI1GqWZ9agrx2ZNFY5sJfl7hY6Pg2h yfuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ZOV4tLJXfM3+u7bw1zGkGTnJ4e5KTsfvJ2F3sGBJ+yk=; b=Ute2IinKkdc96+NITgUfON5qJV7FhtG/HB4PJyHKn63Jxqa7zQPlp6WRTdc5NOcoDI S6t2KnjqXUdw6YN0ZUAXdagIsc/1QJXubojzh2abb0KzmGGRH2YNvFJ3b6J7UKNckL+K ARRJVXhQLfqaWHzxvV6t+8p65g+28BNlAOtabAxFARiy1QIScvOWHYByoF4moAmWHqRD bGZX+n5bspz76xKeeGW4qH0RV5c76q1dq2lS0QCAfYC+mBioyuhFtojZfFW0625iY4mK aClb8RDa9OU3ifZPRAxvjbYS0mYOFphCsFnLhePGFh6lQIudoEXgk81p7dnS2dXYWTaY 2n/g== X-Gm-Message-State: APt69E2QQZ1zXW1wXMIGCCC+7KJ2jFzzHOka8xcfpBaFhcNiTNUXxDoa uiZsMmhVRJiwS+sEiDcjVnyMEg== X-Google-Smtp-Source: ADUXVKI8KGr7BME5KreWLWNnHvMEHhXgCTkcuXsMmMNsvlMttN394zUdlLpASOfA+n9cX1ZD0AghGg== X-Received: by 2002:a6b:e603:: with SMTP id g3-v6mr5329480ioh.216.1528334089651; Wed, 06 Jun 2018 18:14:49 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s130-v6sm75399ita.2.2018.06.06.18.14.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jun 2018 18:14:49 -0700 (PDT) From: Noam Postavsky To: Thomas Fitzsimmons Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: Date: Wed, 06 Jun 2018 21:14:47 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 06 Jun 2018 21:07:21 -0400") Message-ID: <87po132y9k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Thomas Fitzsimmons writes: > soap-find-operation: Wrong type argument: soap-binding, ("http://schemas.= microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding") > byte code for exco--bind-wsdl: > doc: Create a WSDL binding. ... > args: (arg1 arg2 arg3 arg4 arg5) > 0 constant soap-wsdl-find-namespace > 1 stack-ref 2 > 2 stack-ref 6 > 4 call 2 > 5 constant vector > 6 constant cl-struct-soap-port > byte code for exco--bind-wsdl: > doc: Create a WSDL binding. ... > args: (arg1 arg2 arg3 arg4 arg5) > 0 constant soap-wsdl-find-namespace > 1 stack-ref 2 > 2 stack-ref 6 > 4 call 2 > 5 constant record > 6 constant soap-port Looks like it's due to the change in how cl-struct works. Does enabling cl-old-struct-compat-mode help? cl-old-struct-compat-mode is an interactive autoloaded compiled Lisp function in =E2=80=98cl-lib.el=E2=80=99. (cl-old-struct-compat-mode &optional ARG) Enable backward compatibility with old-style structs. This can be needed when using code byte-compiled using the old macro-expansion of =E2=80=98cl-defstruct=E2=80=99 that used vectors obj= ects instead of record objects. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 06 22:01:51 2018 Received: (at 31742) by debbugs.gnu.org; 7 Jun 2018 02:01:51 +0000 Received: from localhost ([127.0.0.1]:37283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQkFL-0003Zk-As for submit@debbugs.gnu.org; Wed, 06 Jun 2018 22:01:51 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:35910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQkFJ-0003ZX-K3 for 31742@debbugs.gnu.org; Wed, 06 Jun 2018 22:01:49 -0400 Received: by mail-it0-f48.google.com with SMTP id j135-v6so395392itj.1 for <31742@debbugs.gnu.org>; Wed, 06 Jun 2018 19:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mPi5Jc/Eaxbl3r5MhHFFZUCAH5PvzNbkSRSqDZq617c=; b=qZ3Mz7pKc0NXf0v5Ir0eeAus7DjgIdJKBiHj/gcAvaXVmEgFyuXixR6nouBW9n5g3r yMOhh8gFMxWQXyft16ge+HiO54kKCxnw1dO7bkbEkZpK7sITtuvpI2BAefw3JJcf1QwF e55ODjhDHgoGJIZr+hQyD3tg7j0GzuCQrLy9Kigb0vY6jII4i6O1rrjRjendvoLCC32+ C6c81gMa2sIi1rHadss8B5QhDZywJXHA1yw9Ga26LGCPGZm/RDHYkJYbO/y/+ZwozpXh KHpQlcdwND2/Nr19wqEMvtIUcOlkER1OJcaoXhY+RmyjMMNn286NhM+meeRuoty3iyOT jfWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=mPi5Jc/Eaxbl3r5MhHFFZUCAH5PvzNbkSRSqDZq617c=; b=f02BCiZfR6m1Qr/ow6wia0JqXhXXUMSoM5Q7Ef6gUBCCBNj8GJ46PahOPgG4AHtBGM t0myNBVuVC7mkKMfbPA0vsFo1PpTH6fm+JrI+XL4hTTn6TOpdoAKwR6038eCi9kr0vgv UedZtm8rttCvxmQ53+NK6R7WnCjWKTjyeQ70aA0LDG0c+XGO3IEPbvIiPWK8E9LQ4QD7 jFzF/wanvk+dWmy6Vytv6IfeOcKFYsrUFe0evg7nS0sd2lN417tM+o/Y3ShBVuunAWJ5 SjRXr6socjBiFsW2OWcGNqFguOt3HSilnnx5Ihs17HMFusCp7XWJd4ThNzu4jvN9sitQ 1ybg== X-Gm-Message-State: APt69E3Hg5ogAZxAiTlTmj25Izx7kEV1AtPBXvkh0kgvtGdOqU3FC6+W v93vT18KBEPHd/1iisLtWXzh/tcRgfs= X-Google-Smtp-Source: ADUXVKJ4fRrkgaWENpU+/m0gk4AafaTB6bdb4Re9suUFNL1ruTeIg/5Ok5I7L1hM63jALv8I49SvJw== X-Received: by 2002:a24:270a:: with SMTP id g10-v6mr236471ita.21.1528336903847; Wed, 06 Jun 2018 19:01:43 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 63-v6sm7605985ioz.71.2018.06.06.19.01.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jun 2018 19:01:43 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> Date: Wed, 06 Jun 2018 22:01:42 -0400 In-Reply-To: <87po132y9k.fsf@gmail.com> (Noam Postavsky's message of "Wed, 06 Jun 2018 21:14:47 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Thomas Fitzsimmons writes: > >> soap-find-operation: Wrong type argument: soap-binding, ("http://schemas= .microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding") > >> byte code for exco--bind-wsdl: >> doc: Create a WSDL binding. ... >> args: (arg1 arg2 arg3 arg4 arg5) >> 0 constant soap-wsdl-find-namespace >> 1 stack-ref 2 >> 2 stack-ref 6 >> 4 call 2 >> 5 constant vector >> 6 constant cl-struct-soap-port > >> byte code for exco--bind-wsdl: >> doc: Create a WSDL binding. ... >> args: (arg1 arg2 arg3 arg4 arg5) >> 0 constant soap-wsdl-find-namespace >> 1 stack-ref 2 >> 2 stack-ref 6 >> 4 call 2 >> 5 constant record >> 6 constant soap-port > > Looks like it's due to the change in how cl-struct works. Does enabling > cl-old-struct-compat-mode help? > > cl-old-struct-compat-mode is an interactive autoloaded compiled Lisp > function in =E2=80=98cl-lib.el=E2=80=99. > > (cl-old-struct-compat-mode &optional ARG) > > Enable backward compatibility with old-style structs. > This can be needed when using code byte-compiled using the old > macro-expansion of =E2=80=98cl-defstruct=E2=80=99 that used vectors o= bjects instead > of record objects. Hmm, that does look related, however I just retried with and without it. That mode was already enabled when the failure happened (when I ran M-x cl-old-struct-compat-mode, it output "Cl-Old-Struct-Compat mode disabled"). If I disable the mode, then I get a different failure earlier: (wrong-type-argument soap-element [cl-struct-soap-port "ExchangeServicePort= " nil "https://mail.cisco.com/ews/exchange.asmx" ("http://schemas.microsoft= .com/exchange/services/2006/messages" . "ExchangeServiceBinding")]) So it seems like cl-old-struct-compat-mode being enabled is having a positive effect, but maybe it does not handle the specific incompatibility I'm running into. Thomas From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 08:21:38 2018 Received: (at 31742) by debbugs.gnu.org; 7 Jun 2018 12:21:38 +0000 Received: from localhost ([127.0.0.1]:37528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQtv8-0007W7-Ag for submit@debbugs.gnu.org; Thu, 07 Jun 2018 08:21:38 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:37425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQtv6-0007Vu-9R for 31742@debbugs.gnu.org; Thu, 07 Jun 2018 08:21:36 -0400 Received: by mail-io0-f178.google.com with SMTP id s26-v6so11557618ioj.4 for <31742@debbugs.gnu.org>; Thu, 07 Jun 2018 05:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N1FrJQW/J64rDoay783CYEE3LCEppzWCXGqb7Rb0Th0=; b=uYv3aOZCdxf8sa0t7ne0l/tJQ+k+dXWycUFjksuuyO9HCxNPvI2TN1asv6c6YBcWfL jm97FZ+Bm+fc82zB5WyyhtYEEYVrb36/UwIFzk5Me0PShajC0sqmvCQkv7LdA3ilxySI ERTM0sQQfd47FJqG/EKex0WB7eeO8NFKzA0T2rEWo22xsoBPOcULCEbhEsVBniG/emuP lazDBkUXzIakAShTCrYydjva4eUE6qlwiN6J+rWuOvOju3D1/QWWqDlxLVSPYikalvUy mybx18GUGQifGmCoy0qkdBuayQ6xqvkHfoVawX9e7yTsvMYvNhDCUqXfCGBhPp7Bdm7j yMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N1FrJQW/J64rDoay783CYEE3LCEppzWCXGqb7Rb0Th0=; b=MzrJRFaDTszDpfaU2prNVvA5L5SXZNdMOSqzjH3OBk20zT2QzdIvD3jzOyeeADSrHB q+vfcWfEoTPNFw+Yer0WPLYt5rg02YnLVJXHNz3bh6gyikyRoK4upNUJwwBe/j6Vr85j qEEVEtDsAjl5NWt4xBy2w8ml3EDPoZV0eE1lmgWRCweFArp+eVXhQYHVWVf8LgqyPod0 zJ74dOliRAS9DAjRDcy8MG/8b7VSaK4LxyuaCJCBXIRBNjtAbRzS1ZjxlOWTPUi8Qy7P 18npXM2AcK04B3nD39cZBE0ViALQezFUyrRWEjV+g0PXm71YALLevPCVb1pFUFpF9zaQ fd7A== X-Gm-Message-State: APt69E097LVR0r9DbGuaIAutvqhyDuXn4Bgpipp3ZpHjkOVWnFYik9Xr hfst/dkD4TXr+moPUiAMcAneMA== X-Google-Smtp-Source: ADUXVKKgmDHvv1Og4usKaaSjunKfPFGJIDccvkNSLIMR15lsNdRxKkyj3zX86xRMJ/FHhhfmwUZ58g== X-Received: by 2002:a6b:16c7:: with SMTP id 190-v6mr840053iow.221.1528374089851; Thu, 07 Jun 2018 05:21:29 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x16-v6sm7160538iob.75.2018.06.07.05.21.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 05:21:28 -0700 (PDT) From: Noam Postavsky To: Thomas Fitzsimmons Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> Date: Thu, 07 Jun 2018 08:21:27 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 06 Jun 2018 22:01:42 -0400") Message-ID: <87h8me3hyw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > So it seems like cl-old-struct-compat-mode being enabled is having a > positive effect, but maybe it does not handle the specific > incompatibility I'm running into. Hmm, can't see anything else in the bytecode. Can you post the full backtrace from the failure? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 10:06:15 2018 Received: (at 31742) by debbugs.gnu.org; 7 Jun 2018 14:06:15 +0000 Received: from localhost ([127.0.0.1]:38272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQvYN-0005aY-Ic for submit@debbugs.gnu.org; Thu, 07 Jun 2018 10:06:15 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:37852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQvYL-0005aH-Pe for 31742@debbugs.gnu.org; Thu, 07 Jun 2018 10:06:14 -0400 Received: by mail-io0-f169.google.com with SMTP id s26-v6so11958466ioj.4 for <31742@debbugs.gnu.org>; Thu, 07 Jun 2018 07:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mg/h+0iVhGQ9D5AeMdArrbMamvhzCxxWXOdKsUyMqa8=; b=wKNP4WpQA79mOX1Afqwgd5gZ3r6ygbYcd2HrCplyFP66k/ssUNGS7w6Duo9/7z54++ 0YWJ8CIHV17s9hv++fou/vH7L85xe8fKvXVx5i+AiWnbS0o2ZJ/LhnZdgs+HjhYyiaxi SI8KC0LzLl/Zs07GBLwjx7UDo6Cg+dfBXaq1otIa4dXIhj70cUvtY1xueNVKpXly7f+l jsQEgb4el075sQtD7YwIwmKHXMKePF68Ww6vUyPeJ3FJaIPfZigEQx4bS9BgAFn3+31j jjqa7jqZTEcN8cFCjLynxU71xSwJEr6X5TWpjZGGng4lNpXn28mf9kn7LeBq4+xasUL/ Rb4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=mg/h+0iVhGQ9D5AeMdArrbMamvhzCxxWXOdKsUyMqa8=; b=WGcTZ+40O9czmJRseRT4AsC6xSzOoI0mj3LSnKIXQM1hc5C91zSSsZnpHaqxNAPizo JyA2xQL+IoooJUiEbpyONGs3vExD0jZURmW8j8JU9NXpWR+aHSDrizEuqNibq7w7uhm4 2v04er0iRKxnlsI6QQIzVcQJEdJB6Z6wZ+GkaZ9jHPDFvXUZvYXSJIKn2ml4Kfticnji zh2YQExhnDYO2+brlsIwhznQpeS0FNS9xmDGJp+02BCpXp7QIYEhE9zroES8Ab2l1YMm xxuv8yxMAJoHQlQ6t0BpceOraQrpFwvtuebXQO+r6t+Z6pcmi4GTtQ3d3gpSpVUGUEeM +YXA== X-Gm-Message-State: APt69E1nIjAuGhnX+kN8z0lPmwIL9kDujcPZXTe5jQKvCTSSfi+zdJS2 gl88Rk9/dc9G6IsGnFWKrZILLrWQHVU= X-Google-Smtp-Source: ADUXVKJj44pzHCvvNtCwnMwJqE11lMG+rV2jwU/+bTyd1ab2HQ+BCkzDineaLkRShAIENZeVdTROfw== X-Received: by 2002:a6b:c38b:: with SMTP id t133-v6mr1616774iof.197.1528380367763; Thu, 07 Jun 2018 07:06:07 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id z6-v6sm4869100iob.15.2018.06.07.07.06.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 07:06:06 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> Date: Thu, 07 Jun 2018 10:06:03 -0400 In-Reply-To: <87h8me3hyw.fsf@gmail.com> (Noam Postavsky's message of "Thu, 07 Jun 2018 08:21:27 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Noam Postavsky writes: > Thomas Fitzsimmons writes: > >> So it seems like cl-old-struct-compat-mode being enabled is having a >> positive effect, but maybe it does not handle the specific >> incompatibility I'm running into. > > Hmm, can't see anything else in the bytecode. Can you post the full > backtrace from the failure? Yes, but the error that produces the backtrace happens much later via a different entry point, M-x exco-calendar-show-day: Debugger entered--Lisp error: (wrong-type-argument soap-binding ("http://sc= hemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBind= ing")) signal(wrong-type-argument (soap-binding ("http://schemas.microsoft.com/e= xchange/services/2006/messages" . "ExchangeServiceBinding"))) soap-find-operation(#s(soap-port :name "ExchangeServicePort" :namespace-t= ag nil :service-url "https://redacted/ews/exchange.asmx" :binding ("http://= schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBi= nding")) "FindItem") soap-operation-arity(#s(soap-wsdl :origin "https://redacted/ews/exchange.= asmx" :current-file nil :xmlschema-imports nil :ports (#s(soap-port :name "= ExchangeServicePort" :namespace-tag nil :service-url "https://redacted/ews/= exchange.asmx" :binding ("http://schemas.microsoft.com/exchange/services/20= 06/messages" . "ExchangeServiceBinding"))) :alias-table (("ns3" . "http://s= chemas.microsoft.com/exchange/services/2006/messages") ("ns2" . "http://sch= emas.microsoft.com/exchange/services/2006/types") ("ns1" . "urn:ExchangeSer= vicePortType") ("soapenc" . "http://schemas.xmlsoap.org/soap/encoding/") ("= xsd" . "http://www.w3.org/2001/XMLSchema")) :namespaces (#s(soap-namespace = :name "urn:ExchangeServicePortType" :elements #) #s(soap-namespace :name "http://schemas.microsoft.com/exchange/se= rvices/2006/types" :elements #) #s(soap= -namespace :name "http://schemas.microsoft.com/exchange/services/2006/messa= ges" :elements #) #s(soap-namespace :n= ame "http://schemas.xmlsoap.org/soap/encoding/" :elements #) #s(soap-namespace :name "http://www.w3.org/2001/XMLSche= ma" :elements #))) "ExchangeServicePort" = "FindItem") exco-get-meetings-for-day(("fitzsim@cisco.com" . "https://redacted/ews/ex= change.asmx") 6 7 2018 #f(compiled-function (&rest arguments) #)) #f(compiled-function (identifier callback) #)(("fitzs= im@cisco.com" . "https://redacted/ews/exchange.asmx") #f(compiled-function = (&rest arguments) #)) exco-connection-iterate(exco-org-initialize-buffer #f(compiled-function (= identifier callback) #) exco-org-insert-meetings exco-o= rg-finalize-buffer) exco-org-show-day(6 7 2018) apply(exco-org-show-day (6 7 2018)) exco-calendar-show-day() funcall-interactively(exco-calendar-show-day) call-interactively(exco-calendar-show-day nil nil) command-execute(exco-calendar-show-day) The initial problem in exco--bind-wsdl (via the M-x excorporate entry point) does not throw an error. Basically, in the failure case, parsing of the WSDL XML is incomplete, and the later error is due to that. I printed the value of port from 26.1; with 25.1 bytecode it is: [cl-struct-soap-port ExchangeServicePort nil https://mail.cisco.com/ews/exc= hange.asmx (http://schemas.microsoft.com/exchange/services/2006/messages . = ExchangeServiceBinding)] and with 26.1 bytecode it is: #s(soap-port ExchangeServicePort nil https://mail.cisco.com/ews/exchange.as= mx (http://schemas.microsoft.com/exchange/services/2006/messages . Exchange= ServiceBinding)) Thomas From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 13:36:26 2018 Received: (at 31742) by debbugs.gnu.org; 7 Jun 2018 17:36:26 +0000 Received: from localhost ([127.0.0.1]:38410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQypl-0007xw-U6 for submit@debbugs.gnu.org; Thu, 07 Jun 2018 13:36:26 -0400 Received: from mail-ot0-f175.google.com ([74.125.82.175]:37464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQypi-0007xe-1E for 31742@debbugs.gnu.org; Thu, 07 Jun 2018 13:36:24 -0400 Received: by mail-ot0-f175.google.com with SMTP id 101-v6so12501486oth.4 for <31742@debbugs.gnu.org>; Thu, 07 Jun 2018 10:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=b8o/T4kqXx18t0+4u2YStYoKBheUtMa67yJGcEoNLkA=; b=S57nPW0ezb9JNRmTrRbSkmHL+ujNvik+yJEcCQp3gBE6owgyY1RDJrOd5IwBWnQg95 2KSA90XrwF3unJBJpQBG66QV6HB++lwtPDFIZdg8NwDv/pCQRQpIqvuc9gq820pvWrqk aXJGLxH3w7nHiLIqeVqOBI9ymvyRU555UvdXkfg0tMkPwlfNZRGXZsFHLCjWjM00UypS yF6zG+ymIQldTA4bnqEPBeqTNsn19SV2aknfClDpeOl0O7aYwBocfmrYkg3fgtJzu6nC WQGUwGekQxvKTpSQ2rPY2SzV1VR2eg45w56GthS6l7i75JVbseukeslM10NZASpOCoMA w02A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=b8o/T4kqXx18t0+4u2YStYoKBheUtMa67yJGcEoNLkA=; b=LgLdjZBwyHpFIkWZp9VndgTYgDEGUR2idCtWzFx6+yAAfeWHY//J6TfstneCb8ZPSi GmQOoYb0M5+wXvt7fnoBoG1m4x8x5dyQbEbppBHYesTWE++DUpuh75GKFrHO3VWIxn3v 0jwWTaLMtK5tZy9bBOIjVDsATnWnJUz1xFt+/t1hHL/AxppTVZDzwNRvlVNAwyV2obla +rNAS9YOugzemy6c0lTgkpU1Ji3JwacKobZicdMaKyNrg1DnZKEGaHnevbmSEwIdijdn qpxIlpx1oKa6FBxjUj/dKuH8gMWaqUKx7s8yDUKMnwx+cEA/EBAze/XRNHwSWZzVW+kA FhZw== X-Gm-Message-State: APt69E3VfxqzKuXunnUD+lI3VBYXLFtdt1On68uVmkAZp8etNA0yTwC3 lKEIscMRlSJyX1iaJvABUVdfGmizldV/wUgBy1g= X-Google-Smtp-Source: ADUXVKIvGxU7bPkfMl1MRJVycJ1Npyu9xI7glbQsfcmzuKK6nUp7TuVWQw3AUA96mLBlyQiTiFOda5DqYmmBafPWpmA= X-Received: by 2002:a9d:577d:: with SMTP id x58-v6mr1681680oti.196.1528392976251; Thu, 07 Jun 2018 10:36:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:3b84:0:0:0:0:0 with HTTP; Thu, 7 Jun 2018 10:36:15 -0700 (PDT) In-Reply-To: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> From: Noam Postavsky Date: Thu, 7 Jun 2018 13:36:15 -0400 Message-ID: Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 To: Thomas Fitzsimmons Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 7 June 2018 at 10:06, Thomas Fitzsimmons wrote: > Yes, but the error that produces the backtrace happens much later > via a different entry point, M-x exco-calendar-show-day: > > Debugger entered--Lisp error: (wrong-type-argument soap-binding ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding")) > signal(wrong-type-argument (soap-binding ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding"))) > soap-find-operation(#s(soap-port :name "ExchangeServicePort" :namespace-tag nil :service-url "https://redacted/ews/exchange.asmx" :binding ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding")) "FindItem") > The initial problem in exco--bind-wsdl (via the M-x excorporate entry > point) does not throw an error. Basically, in the failure case, parsing > of the WSDL XML is incomplete, and the later error is due to that. Right, if I just evaluate the following in 26.1 without any 25.1 bytecode I get a similar error: (let ((port (make-soap-port :name "ExchangeServicePort" :namespace-tag nil :service-url "https://redacted/ews/exchange.asmx" :binding '("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding")))) (soap-find-operation port "FindItem")) I don't quite understand how it's supposed to work successfully though. Is there a way to see it working without having to run a server on the other end (i.e., can you give some elisp forms to evaluate that make the above work)? I'm guessing the problem is with some old and new structs not matching according to `equal' and/or `sxhash', which cl-old-struct-compat-mode doesn't do anything about. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 21:13:45 2018 Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 01:13:45 +0000 Received: from localhost ([127.0.0.1]:38528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR5yK-0003fN-T1 for submit@debbugs.gnu.org; Thu, 07 Jun 2018 21:13:45 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:36658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR5yI-0003f8-Ql for 31742@debbugs.gnu.org; Thu, 07 Jun 2018 21:13:43 -0400 Received: by mail-io0-f175.google.com with SMTP id k3-v6so18378iog.3 for <31742@debbugs.gnu.org>; Thu, 07 Jun 2018 18:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=q53LCAKCtYnUsoZCClupDkET0wtQhEGAt+JCbVU7UqA=; b=0ocVr+wJ0dF2nvoOsyZo3ChwKfhOuHxp7A9Y2GlHkVpoNFwB00fYC5+OBUpoPVqzY8 ZJpDR36xP+JXIZp28SZ27MEa0MTu/SEAJGIetVtVGI80//oBGIni6AqrsgnrJ2t8CiiA /+1dYVa3EWWPYKNVmZi+mt3mIFLD0hS2mM/Vn2McsP4IgnCiHucUcabCfwvuQ9ZWUYVE yYM4FeDov0xU1UNAjJZ2qSljMcQZLdMK3ad7oBFYo41+MjXwYIrK64jNz+TC/mgN3UKx 1CvrIuU0NkbqNJ/ARXzy5eiMeKrwSO7UVQ0MHaS9Ayc9pOciX/OaPuHLw0M1PpTJqsnp 84Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=q53LCAKCtYnUsoZCClupDkET0wtQhEGAt+JCbVU7UqA=; b=e0IT1BRx+FNF3vbc503vTZRQNqtJVbv80Ln1i1/QDkfnv7G9UjfYN7r0Cm9enO0AG7 Q4S95Pg74hCh69UEXSs1RzmyA3Xe5xiWY2jEDS49kd7WIq8v/f5/GlH/7AbXd0xcWDZ3 5Sr3hnzsLL9vESC2OrcVav6BWwdUbzcn7MnW2R/ZlUffj7RZz4F9mjHZBLA5V/UGZ6l9 hHvqf+39/z+xh08wyBmbbiwnhcbykQfmsgjbpMUwQ+g0yknCzIh8y+7mYqBFwe0Scgr3 YSf0l6v0T4p8p7wEV05KDTkdNXSD6PJklqB3/DBpEcUmbfIpSQTHsuNiqoUYLh+AC/oy ESQg== X-Gm-Message-State: APt69E2Z/8ft3nJdrMWDLpJqKQcBdDqcMiK5IexGMkDsKCRNth9JqcqS LnBPPc3v4jranP4ycUCClske4tKz2UU= X-Google-Smtp-Source: ADUXVKK0KFg3ciJbkAm+3KZWVPsciqfEcsk7Sg8Q+UCqhe5tjoAFu2LLWqDxl771MuOZE4gZPF/4WA== X-Received: by 2002:a6b:a282:: with SMTP id l124-v6mr3603032ioe.256.1528420416067; Thu, 07 Jun 2018 18:13:36 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id c136-v6sm179879itc.36.2018.06.07.18.13.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 18:13:35 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> Date: Thu, 07 Jun 2018 21:13:34 -0400 In-Reply-To: (Noam Postavsky's message of "Thu, 7 Jun 2018 13:36:15 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > On 7 June 2018 at 10:06, Thomas Fitzsimmons wrote: > >> Yes, but the error that produces the backtrace happens much later >> via a different entry point, M-x exco-calendar-show-day: >> >> Debugger entered--Lisp error: (wrong-type-argument soap-binding ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding")) >> signal(wrong-type-argument (soap-binding ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding"))) >> soap-find-operation(#s(soap-port :name "ExchangeServicePort" :namespace-tag nil :service-url "https://redacted/ews/exchange.asmx" :binding ("http://schemas.microsoft.com/exchange/services/2006/messages" . "ExchangeServiceBinding")) "FindItem") > >> The initial problem in exco--bind-wsdl (via the M-x excorporate entry >> point) does not throw an error. Basically, in the failure case, parsing >> of the WSDL XML is incomplete, and the later error is due to that. > > Right, if I just evaluate the following in 26.1 without any 25.1 > bytecode I get a similar error: > > (let ((port (make-soap-port > :name "ExchangeServicePort" > :namespace-tag nil > :service-url "https://redacted/ews/exchange.asmx" > :binding > '("http://schemas.microsoft.com/exchange/services/2006/messages" > . "ExchangeServiceBinding")))) > (soap-find-operation port "FindItem")) > > I don't quite understand how it's supposed to work successfully > though. Is there a way to see it working without having to run a > server on the other end (i.e., can you give some elisp forms to > evaluate that make the above work)? > > I'm guessing the problem is with some old and new structs not matching > according to `equal' and/or `sxhash', which cl-old-struct-compat-mode > doesn't do anything about. I did some more narrowing and found that the issue is with the use of symbol properties in soap-resolve-references. I added debugging: (defun soap-resolve-references (element wsdl) "Replace names in ELEMENT with the referenced objects in the WSDL. This is a generic function which invokes a specific resolver function depending on the type of the ELEMENT. If ELEMENT has no resolver function, it is silently ignored." (when (equal (soap-element-name element) "ExchangeServicePort") (message "1: %s" element) (message "2: %s" (aref element 0)) (message "3: %s" (get (aref element 0) 'soap-resolve-references))) (let ((resolver (get (aref element 0) 'soap-resolve-references))) (when resolver (funcall resolver element wsdl)))) In the working case, I get: 1: #s(soap-port ExchangeServicePort nil https://mail.cisco.com/ews/exchange.asmx (http://schemas.microsoft.com/exchange/services/2006/messages . ExchangeServiceBinding)) 2: soap-port 3: soap-resolve-references-for-port while in the failing case, I get: 1: [cl-struct-soap-port ExchangeServicePort nil https://mail.cisco.com/ews/exchange.asmx (http://schemas.microsoft.com/exchange/services/2006/messages . ExchangeServiceBinding)] 2: cl-struct-soap-port 3: nil This means the resolver fails to run and the ExchangeServicePort element is not expanded, which results in exco-calendar-show-day's subsequent failure. It seems like soap-client's use of symbol properties is not safe across major Emacs versions. Thomas From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 21:57:47 2018 Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 01:57:47 +0000 Received: from localhost ([127.0.0.1]:38554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR6ex-0004fR-BO for submit@debbugs.gnu.org; Thu, 07 Jun 2018 21:57:47 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:39654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR6eu-0004fE-W7 for 31742@debbugs.gnu.org; Thu, 07 Jun 2018 21:57:45 -0400 Received: by mail-io0-f174.google.com with SMTP id f1-v6so14145090ioh.6 for <31742@debbugs.gnu.org>; Thu, 07 Jun 2018 18:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pd1ryO3h+qEWCwBKGVj7lkv/LXaeLC8qAkpz+II2QHE=; b=I2JO251EAvYXpawoaEUatayeev1TGudQZbg6b7Hq4HgiNR+HlTlFjL23pJQNC52rI8 R5lo6YlGxS0cr50XQmO3IXK3JFidUTaelzaTsnpjRCEBYdSJ8z/v162F3Lg3ONiejHim Lb902rUvPklZ8NdWixw5TvgWCP0fjLKPlIMBn5kLob5vX9V4VPkWvVk9vC6qN1MG4NAg wYbhXvQOxQXRC4mfjquRqYFwe0wflQJARo7U5Ru9Pn/WrmDwbXtyd7MI8DaZA7FLng0s kn4cyLxHcU9LxLGMswrHOnsKazBeP43IYgmSRNcmf4dxd+bSGLAE/xpzNVADS9Vi1yyc sL5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pd1ryO3h+qEWCwBKGVj7lkv/LXaeLC8qAkpz+II2QHE=; b=szQECay6aaTd6vDQiEvrdx3JhNuMRe5n0Ow9dmEDO6L5lQskwKXqbSblW2v3cuXSAa owohb8jwN59ob9dRvxSR84lbLIPER9I2+URl9jppDdSDA/pc/p68LLDA/vXpZn9ewzN2 G/H3S3/5NbY/umAOHuWDGnm1I2xRMIYty4vqWdJffS/BwawzsRJSG6p2k1e3RarYpaOs sU5N/Y6KXNDfR7lHsR4/VV9wMsdw5pIfPyMkW/ROGctzxtQZDcVze5NXhIVZV3/rJzPO fmVghzA+tlcAkRXYuWKnSaeir1nxw91YdEgx8H1lJtNVmH90FtLXEcqMwejWWmFXV7Ph 1PjA== X-Gm-Message-State: APt69E3PEqMiM7eBpySjVOPY5KfGF10uoykYNzoEFq79fpojit/0TZN7 ZslwBja7InzunvhwnvdJsDjxnw== X-Google-Smtp-Source: ADUXVKKBWa5j+fK8+1KJlG15449a5i1/abg9WbBEyTBcdcA3ugdmYBu2EPfTn5tyfn3WaBAs7CKmSQ== X-Received: by 2002:a6b:b513:: with SMTP id e19-v6mr3874578iof.250.1528423059350; Thu, 07 Jun 2018 18:57:39 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c184-v6sm257919itc.12.2018.06.07.18.57.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 18:57:38 -0700 (PDT) From: Noam Postavsky To: Thomas Fitzsimmons Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> Date: Thu, 07 Jun 2018 21:57:37 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Thu, 07 Jun 2018 21:13:34 -0400") Message-ID: <87zi0611m6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Thomas Fitzsimmons writes: > (defun soap-resolve-references (element wsdl) > (let ((resolver (get (aref element 0) 'soap-resolve-references))) Ah, then it should work to replace the (aref element 0) with (type-of element) as long as cl-old-struct-compat-mode is enabled. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 07 22:17:24 2018 Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 02:17:24 +0000 Received: from localhost ([127.0.0.1]:38559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR6xw-00057c-46 for submit@debbugs.gnu.org; Thu, 07 Jun 2018 22:17:24 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:35990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR6xu-00057L-Nx for 31742@debbugs.gnu.org; Thu, 07 Jun 2018 22:17:23 -0400 Received: by mail-it0-f45.google.com with SMTP id j135-v6so576372itj.1 for <31742@debbugs.gnu.org>; Thu, 07 Jun 2018 19:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kwWHV5rtZy/hMIH8PTBp5PiYiqEy7P1mn42ED/p2sjY=; b=iiMYbX53IvnXfHXgN5Y9wDRZ2q/F/ZX8cQBdKY9lKjitxZBfw7P4OfepGPRdxw2UwJ yj+CQBL1lN3gr0Y9qi5Ff+zDuAxajScJ6519+/irTDeZ+OZ7FjzIS9DhsXguq/KM5f89 fdFXfgncCC+Irqms9BzQDjK1r6QQsUNpXoyIJU3WNYaF7zOEzgBuf/pzxXV/h+rKOi9D 50hFu2AFRyEABW+te93H9GlMF72/8xSoNUevgSzU3qSO5J1ZrDZVKAWBv836dfISGr7z nDgHA0ZkG+wxOqLC5gH4NIH2SDGubUs59rOZ2MmU6sRy91VbWbNfxGxwRrHlSMl3l8L/ OvQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kwWHV5rtZy/hMIH8PTBp5PiYiqEy7P1mn42ED/p2sjY=; b=FhXmX/lA5DZ4CJGeXKzVRjDsYleWhqW5muWAuQ9K5G6focQb+LLF1i+UpeRWzfY4jb vDozPBNIb65g7I7hvgBnWrzZ7ZUTvK05Y/78Lfr6ppEvf50QWT96XmTLoRgo1UkMVi/L iT/wUHLvK/3Uxbpw3tyZiHuvR/sbO1jo28jzOh7BEVBAEOR+glOaxTfKQ1oO3ouDSi/o SyEn6Zae/5lb+uEEtOdGbvn0DLDyCDIt17Bz37uGRHB+6Ic7BVdd3pWizmA5nnNZqjb3 d8ro+Lv3xUSLwvLOJySqXYjav7omeDCM20g3HKxkD6eVQ0oMwwTgxTOd/jtDqEtVwg5O NhgA== X-Gm-Message-State: APt69E04uSUfk2QqojuingUEF9fW6LB7HDqggosQgJE5slOowF/xRXjl rTyp07THDS4TTAznYQkzlgugnMgq62M= X-Google-Smtp-Source: ADUXVKJVTMLuEpJ2qXqYzvSS9cNVaowRU9YCvMmcMLPifgLnN34soZLNqDLBwNuZTbvVE81RRKQB/g== X-Received: by 2002:a24:3d8b:: with SMTP id n133-v6mr166385itn.33.1528424237077; Thu, 07 Jun 2018 19:17:17 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id t130-v6sm263925ita.19.2018.06.07.19.17.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 19:17:16 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> Date: Thu, 07 Jun 2018 22:17:15 -0400 In-Reply-To: <87zi0611m6.fsf@gmail.com> (Noam Postavsky's message of "Thu, 07 Jun 2018 21:57:37 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Thomas Fitzsimmons writes: > >> (defun soap-resolve-references (element wsdl) > >> (let ((resolver (get (aref element 0) 'soap-resolve-references))) > > Ah, then it should work to replace the (aref element 0) with (type-of > element) as long as cl-old-struct-compat-mode is enabled. Yes, I retested with that change and it does work. I guess I should submit a patch to change all those occurrences in soap-client. I'm hoping cl-old-struct-compat-mode will continue to be enabled by default for a long time. Thanks for looking into this. Thomas From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 08:19:56 2018 Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 12:19:56 +0000 Received: from localhost ([127.0.0.1]:38881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRGN1-0000E8-O7 for submit@debbugs.gnu.org; Fri, 08 Jun 2018 08:19:55 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:56200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRGN0-0000Dw-3d for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 08:19:54 -0400 Received: by mail-it0-f44.google.com with SMTP id x25-v6so598672ith.5 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 05:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BchMWff3NHRg7Y+446MAZIzYi34tohHOuzWP+ztuRUw=; b=AQb2606zuHzHCBt47K5nr4mez+K7HpdAV5eVN1SVclDh2yP68+PwMPDMGK1J+JWfHt SdL0oZwms0GEw0RH0TMoaq9uPl+pfoYeYEhLF0+Q6IYRyqqYLblNkRM1p2XpGx3HeCGQ ZKD+lmRtdAtQ52qhBMg6hyguP+xOjas0HD8BceKUC8k4cLH3Ijsp8CGuyaUiHp7VHRGf lvJLpAmLxbBb9uTRtS9bTTX/12zhNpKNy6aQwxjCahzUfT2nKbCCEf6J3FtaqLX+GTBg luCgK6MEmXJ/iQGrCkhH+cj7iEelnp+6bV5/E4KgbjT9eJuesijDWMFbMLj2mCtvmRvy 6gog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BchMWff3NHRg7Y+446MAZIzYi34tohHOuzWP+ztuRUw=; b=idMKPdlepUMRApOrtfbho0dA7dwtoCwvfsigAyxd2tzIMDSoQ2qG9VqDRZyqMmRcou px0a7q9ZnzBev7S/7Yg2nWX87VBg7nYPK6FJBXc/FSY6tVKrNWY2bkgG5AibLXQYRrcG lrjbpJVCSbilHdGcOK/bOY/jKapSOptTRU+TaRf71g1Z1CKMtmPJACdzO/KaOgO5xy+N rkBz7zlPADbADIjzNppivulTaxZwVv8j/uvzZynSrlJI2lixz2QOGKyUY/880NvhfNNk pzCAhCqGeesTuoyoIuQI48yft/OmYqxWX5ED5jHR3KIZI0Hnnq5DLRYihtunQ4T/uYTe rMGA== X-Gm-Message-State: APt69E3XaWj2ZluUMFNz2TQdm0orqZg290nde96G0NYUmlsbo2lDCKxw dNEkbeZBbH09xzqjQgrP5a0WXg== X-Google-Smtp-Source: ADUXVKL1KM6uQDg6X7Rz8i+injOZJeGdLgyt/jzRhHdS6A/I2ASqHSptLC7C4J4RpKALhDychC1tpw== X-Received: by 2002:a24:b611:: with SMTP id g17-v6mr1525310itf.63.1528460388384; Fri, 08 Jun 2018 05:19:48 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g26-v6sm1968279iti.0.2018.06.08.05.19.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 05:19:46 -0700 (PDT) From: Noam Postavsky To: Thomas Fitzsimmons Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> Date: Fri, 08 Jun 2018 08:19:45 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Thu, 07 Jun 2018 22:17:15 -0400") Message-ID: <87vaat1ndq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thomas Fitzsimmons writes: > Noam Postavsky writes: > >> Thomas Fitzsimmons writes: >> >>> (defun soap-resolve-references (element wsdl) >> >>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >> >> Ah, then it should work to replace the (aref element 0) with (type-of >> element) as long as cl-old-struct-compat-mode is enabled. > > Yes, I retested with that change and it does work. I guess I should > submit a patch to change all those occurrences in soap-client. I just noticed soap-client is also an ELPA package; then there is the additional complication that type-of will give the wrong answer in Emacs versions 25 and older. So you would need something like (let ((type (type-of element))) (if (eq type 'vector) (aref element 0) ; For Emacs 25 and earlier. type)) > I'm hoping cl-old-struct-compat-mode will continue to be enabled by > default for a long time. I was going to say, it's currently not enabled by default, but it looks like it gets enabled automagically when you load code from the old cl-defstruct: (defun cl-struct-define (name docstring parent type named slots children-sym tag print) (unless type ;; Legacy defstruct, using tagged vectors. Enable backward compatibility. (cl-old-struct-compat-mode 1)) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 10:18:28 2018 Received: (at 31742) by debbugs.gnu.org; 8 Jun 2018 14:18:28 +0000 Received: from localhost ([127.0.0.1]:39715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIDk-0005v0-CM for submit@debbugs.gnu.org; Fri, 08 Jun 2018 10:18:28 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:38526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIDi-0005uf-62 for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 10:18:27 -0400 Received: by mail-io0-f194.google.com with SMTP id l19-v6so16078923ioj.5 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 07:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+Z1RUEijAjEhIst77KfTEPJThaNV6NTDpcEkVKIJUdU=; b=iQZdHv0Ni32gfmooiAeuQPPHWORLUkgtfYmFiuyiQmDi62EuW7i7dq8NiX2I9n1tJc GsJAAoVrC6IKwSYS30RxXfzeemIQua1J/1p2sSJ0DjRqDGxNlcp1jNYZj1vIl1JGqveI CqarptRg+8oTgLZ4YdlYj5xqR84/CHEEK9EagRbFRp5DwwRLpd1qf5GvJq87jlQtf9Bd IKvHKXDmVMjuk2yBatPUzLcL8MTfNVCXVKmUgs/RR5ylFHK8K7L2Y+ax2tkVglugYg+U 3uYs0F9LjPwFfJB91hQLeL8QwU1WLv8qvslQbwuYtgvSVYkKkuB7G8davkfKy42bv0S1 Y7gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+Z1RUEijAjEhIst77KfTEPJThaNV6NTDpcEkVKIJUdU=; b=Dv60G5uxDNf3nO1y/AEK4Ef4s4PU3I8182aHDF+nLI9mCBjTyp2D/E57fCPXZVR3PF c9cyk0vA62/4tPg3klTtf+KyuAiPYPuIM9533m4NRKB/SxfWa7DwjwITweGcn5K05ggE lyGhCobyiFeyh4bB3o8gbW6Ia+O2ClaoErFYQl3F2fYpCHgiuYa0FKS7iXtOkbCER+Ti 0s0mUN2N57yH356tPtmvNaBy7NmUEFfiQxhn4bX5ZR4LgwC5GUToqDFR5dlOWK+oN+4q pMK3B14QzDaD/Nq5CHqQWlqhgfAjkCFRT1oRyF5A/7kpwvVbAHfXjZZVTgUhDT36logO AZPQ== X-Gm-Message-State: APt69E2hKdiOZG2dhihJwAt/Cx9djZfmlm3cfEkWMlYTM0UH3xTIPreq NWWv3tSK4i6UfWw2Jrv9D+qkmw== X-Google-Smtp-Source: ADUXVKIsBWyxDL+ahpde/1WHQ0E4flF6Lxcp7Avpz9fGM3pSCkVgVDwONaagbzPbPVc2XyaUDE2tcA== X-Received: by 2002:a6b:5d0f:: with SMTP id r15-v6mr5601902iob.178.1528467500684; Fri, 08 Jun 2018 07:18:20 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id u10-v6sm7759239iof.78.2018.06.08.07.18.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 07:18:19 -0700 (PDT) From: Thomas Fitzsimmons To: Noam Postavsky Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Fri, 08 Jun 2018 10:18:18 -0400 In-Reply-To: <87vaat1ndq.fsf@gmail.com> (Noam Postavsky's message of "Fri, 08 Jun 2018 08:19:45 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 31742 Cc: Alexandru Harsanyi , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) (CCing Alex Harsanyi.) Noam Postavsky writes: > Thomas Fitzsimmons writes: > >> Noam Postavsky writes: >> >>> Thomas Fitzsimmons writes: >>> >>>> (defun soap-resolve-references (element wsdl) >>> >>>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >>> >>> Ah, then it should work to replace the (aref element 0) with (type-of >>> element) as long as cl-old-struct-compat-mode is enabled. >> >> Yes, I retested with that change and it does work. I guess I should >> submit a patch to change all those occurrences in soap-client. > > I just noticed soap-client is also an ELPA package; then there is the > additional complication that type-of will give the wrong answer in Emacs > versions 25 and older. So you would need something like > > (let ((type (type-of element))) > (if (eq type 'vector) > (aref element 0) ; For Emacs 25 and earlier. > type)) OK, I had that on my list to investigate before patching soap-client, the compatibility range of type-of, but you've done it for me, thanks. A soap-type-of compatibility function probably makes sense to replace the (aref ... 0) occurrences in soap-client and soap-inspect. >> I'm hoping cl-old-struct-compat-mode will continue to be enabled by >> default for a long time. > > I was going to say, it's currently not enabled by default, but it looks > like it gets enabled automagically when you load code from the old > cl-defstruct: > > (defun cl-struct-define (name docstring parent type named slots children-sym > tag print) > (unless type > ;; Legacy defstruct, using tagged vectors. Enable backward compatibility. > (cl-old-struct-compat-mode 1)) Ah, great, so that logic can stay in Emacs indefinitely without negatively affecting sessions that don't load old byte-code. Thomas From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 22:54:27 2018 Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 02:54:27 +0000 Received: from localhost ([127.0.0.1]:40178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRU1L-0002gK-4R for submit@debbugs.gnu.org; Fri, 08 Jun 2018 22:54:27 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:40356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRU1J-0002g5-EM for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 22:54:26 -0400 Received: by mail-it0-f66.google.com with SMTP id 188-v6so3790094ita.5 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 19:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XOg9YuETgpQLjb7sqqkQR/BRAKLo233iVPX5DrO9cTI=; b=GTAV3uFj5ARVbccase6N86ruTHz0bHgayISKrF/1fR+VU1AKgYN1acy6smRCOpCYEb oyrLRHY8LaqAKqYNlybYUiWPSVsWQPreJIpzgGmZu+skKUwdp7RS4cyvEhmgnzxqCikm a74WKe2IrgtUvDlxAO6p5zGz1xL6tSlATHVGk8BdiJE/UyejfzmTwBGA0WCxL8D299LU l1UkE1XN5nPCGQea0x2qf2yxzw3Omfcz0koxImG5DXpWS0pjFiVtZ1oNX+blv3buFom7 lrQbbsiqoZ6TJhP2fuDk+itPsWAygIupH/wT8BF5Lp1Oc7YNtHeC9w4sXqH4xqay5Gui ctGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XOg9YuETgpQLjb7sqqkQR/BRAKLo233iVPX5DrO9cTI=; b=sCAo+xMiyfVq52vomSqvOqhvFFd6VGubqAQv6zbUf6frv438jDFsUeYG/nMfzjCUxU 4f9mw3pMhhZtIhSGnCpJVu0dhiuK5lH6WMMfGGYGB07NDmF21ocFCwbFsdAX9Iz8W3oL tSeFMMhoSlF0vfNM+/o532rgJg11f73dYOGplqwMOMRlC+p08XgxZ8ZlNFPky/+mo2c9 KsbgqPKGUrmOH4HON8OZLkHNPUFZahos0E7gedxzsAS9/UBhlZ2OUNdXdofXPXMYFte9 XOrzPyK4UwV7pVbQbdqlHmlfbl70Ow/s+4CBRwp5i3s0//tgYJrA/v4APtIC8CwCffah WBoQ== X-Gm-Message-State: APt69E3yUzNlYmpxcf5B4MogV+LVclg2rfMEIDixzBRfoUhuwVjS4jfT RIW5ie/zYYMM8YD7iOIRp3INLpE4rGM= X-Google-Smtp-Source: ADUXVKIZfC2uO0clBOqUMH/twO9HDjppSSqjxzLB/7ghB828VVKB0U07MTj0M9dELK+TvQQ2UgVkqg== X-Received: by 2002:a24:4c6:: with SMTP id 189-v6mr4067138itb.53.1528512859635; Fri, 08 Jun 2018 19:54:19 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id l22-v6sm3342972ioc.25.2018.06.08.19.54.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 19:54:18 -0700 (PDT) From: Thomas Fitzsimmons To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Fri, 08 Jun 2018 22:54:17 -0400 In-Reply-To: (Alex Harsanyi's message of "Sat, 9 Jun 2018 08:01:31 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: Noam Postavsky , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Alex Harsanyi writes: > On Fri, Jun 8, 2018 at 10:18 PM, Thomas Fitzsimmons wrote: >> (CCing Alex Harsanyi.) >> >> Noam Postavsky writes: >> >>> Thomas Fitzsimmons writes: >>> >>>> Noam Postavsky writes: >>>> >>>>> Thomas Fitzsimmons writes: >>>>> >>>>>> (defun soap-resolve-references (element wsdl) >>>>> >>>>>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >>>>> >>>>> Ah, then it should work to replace the (aref element 0) with (type-of >>>>> element) as long as cl-old-struct-compat-mode is enabled. >>>> >>>> Yes, I retested with that change and it does work. I guess I should >>>> submit a patch to change all those occurrences in soap-client. >>> >>> I just noticed soap-client is also an ELPA package; then there is the >>> additional complication that type-of will give the wrong answer in Emacs >>> versions 25 and older. So you would need something like >>> >>> (let ((type (type-of element))) >>> (if (eq type 'vector) >>> (aref element 0) ; For Emacs 25 and earlier. >>> type)) >> >> OK, I had that on my list to investigate before patching soap-client, >> the compatibility range of type-of, but you've done it for me, thanks. >> A soap-type-of compatibility function probably makes sense to replace >> the (aref ... 0) occurrences in soap-client and soap-inspect. >> >>>> I'm hoping cl-old-struct-compat-mode will continue to be enabled by >>>> default for a long time. >>> > > The `(aref element 0)` trick is the only one that `soap-client` uses. All > other struct usage is via accessor functions, the rest of the code does not > assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is > not needed. OK. > Thomas, will you prepare the patch for soap-client? How about the attached? I tested it in 26.1 with 25.1 excorporate.elc byte-code, as well as with our test suite against 24.1, 25.1 and 26.1, so it should be OK for GNU ELPA as well. If this looks OK, I'll bump the soap-client.el version to 3.1.4 when I push. Thomas --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-soap-client-Add-byte-code-compatibility-function.patch >From 1638f42e494334696c3d3dc87c25af664086acaf Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 8 Jun 2018 22:41:28 -0400 Subject: [PATCH] soap-client: Add byte-code compatibility function * lisp/net/soap-client.el (soap-type-of): New function. (soap-resolve-references, soap-decode-type) (soap-encode-attributes, soap-encode-value): Replace aref calls with calls to soap-type-of. * lisp/net/soap-inspect.el (soap-sample-value, soap-inspect): Replace aref calls with calls to soap-type-of. Co-authored-by: Noam Postavsky --- lisp/net/soap-client.el | 44 ++++++++++++++++++++++++++------------------ lisp/net/soap-inspect.el | 44 ++++++++++++++++++++++---------------------- 2 files changed, 48 insertions(+), 40 deletions(-) diff --git a/lisp/net/soap-client.el b/lisp/net/soap-client.el index 3996da0..2535c34 100644 --- a/lisp/net/soap-client.el +++ b/lisp/net/soap-client.el @@ -685,8 +685,15 @@ soap-decode-xs-basic-type (anyType (soap-decode-any-type node)) (Array (soap-decode-array node)))))) +(defun soap-type-of (element) + "Return the type of ELEMENT." + (let ((type (type-of element))) + (if (eq type 'vector) + (aref element 0) ; For Emacs 25 and earlier. + type))) + ;; Register methods for `soap-xs-basic-type' -(let ((tag (aref (make-soap-xs-basic-type) 0))) +(let ((tag (soap-type-of (make-soap-xs-basic-type)))) (put tag 'soap-attribute-encoder #'soap-encode-xs-basic-type-attributes) (put tag 'soap-encoder #'soap-encode-xs-basic-type) (put tag 'soap-decoder #'soap-decode-xs-basic-type)) @@ -915,7 +922,7 @@ soap-decode-xs-element (soap-decode-type type node))) ;; Register methods for `soap-xs-element' -(let ((tag (aref (make-soap-xs-element) 0))) +(let ((tag (soap-type-of (make-soap-xs-element)))) (put tag 'soap-resolve-references #'soap-resolve-references-for-xs-element) (put tag 'soap-attribute-encoder #'soap-encode-xs-element-attributes) (put tag 'soap-encoder #'soap-encode-xs-element) @@ -1011,7 +1018,7 @@ soap-resolve-references-for-xs-attribute (setf (soap-xs-attribute-reference attribute) (soap-wsdl-get reference wsdl predicate))))) -(put (aref (make-soap-xs-attribute) 0) +(put (soap-type-of (make-soap-xs-attribute)) 'soap-resolve-references #'soap-resolve-references-for-xs-attribute) (defun soap-resolve-references-for-xs-attribute-group (attribute-group wsdl) @@ -1036,7 +1043,7 @@ soap-resolve-references-for-xs-attribute-group (setf (soap-xs-attribute-group-attribute-groups attribute-group) (soap-xs-attribute-group-attribute-groups resolved)))))) -(put (aref (make-soap-xs-attribute-group) 0) +(put (soap-type-of (make-soap-xs-attribute-group)) 'soap-resolve-references #'soap-resolve-references-for-xs-attribute-group) ;;;;; soap-xs-simple-type @@ -1374,7 +1381,7 @@ soap-decode-xs-simple-type (soap-validate-xs-simple-type value type)))) ;; Register methods for `soap-xs-simple-type' -(let ((tag (aref (make-soap-xs-simple-type) 0))) +(let ((tag (soap-type-of (make-soap-xs-simple-type)))) (put tag 'soap-resolve-references #'soap-resolve-references-for-xs-simple-type) (put tag 'soap-attribute-encoder #'soap-encode-xs-simple-type-attributes) @@ -1927,7 +1934,7 @@ soap-decode-xs-complex-type (soap-xs-complex-type-indicator type))))) ;; Register methods for `soap-xs-complex-type' -(let ((tag (aref (make-soap-xs-complex-type) 0))) +(let ((tag (soap-type-of (make-soap-xs-complex-type)))) (put tag 'soap-resolve-references #'soap-resolve-references-for-xs-complex-type) (put tag 'soap-attribute-encoder #'soap-encode-xs-complex-type-attributes) @@ -2147,7 +2154,7 @@ soap-resolve-references function depending on the type of the ELEMENT. If ELEMENT has no resolver function, it is silently ignored." - (let ((resolver (get (aref element 0) 'soap-resolve-references))) + (let ((resolver (get (soap-type-of element) 'soap-resolve-references))) (when resolver (funcall resolver element wsdl)))) @@ -2272,13 +2279,13 @@ soap-resolve-references-for-port ;; Install resolvers for our types (progn - (put (aref (make-soap-message) 0) 'soap-resolve-references + (put (soap-type-of (make-soap-message)) 'soap-resolve-references 'soap-resolve-references-for-message) - (put (aref (make-soap-operation) 0) 'soap-resolve-references + (put (soap-type-of (make-soap-operation)) 'soap-resolve-references 'soap-resolve-references-for-operation) - (put (aref (make-soap-binding) 0) 'soap-resolve-references + (put (soap-type-of (make-soap-binding)) 'soap-resolve-references 'soap-resolve-references-for-binding) - (put (aref (make-soap-port) 0) 'soap-resolve-references + (put (soap-type-of (make-soap-port)) 'soap-resolve-references 'soap-resolve-references-for-port)) (defun soap-wsdl-resolve-references (wsdl) @@ -2685,16 +2692,17 @@ soap-decode-type (cond ((listp type) (catch 'done (dolist (union-member type) - (let* ((decoder (get (aref union-member 0) + (let* ((decoder (get (soap-type-of union-member) 'soap-decoder)) (result (ignore-errors (funcall decoder union-member node)))) (when result (throw 'done result)))))) (t - (let ((decoder (get (aref type 0) 'soap-decoder))) + (let ((decoder (get (soap-type-of type) 'soap-decoder))) (cl-assert decoder nil - "no soap-decoder for %s type" (aref type 0)) + "no soap-decoder for %s type" + (soap-type-of type)) (funcall decoder type node)))))))))) (defun soap-decode-any-type (node) @@ -2878,9 +2886,9 @@ soap-encode-attributes Attributes are inserted in the current buffer at the current position." - (let ((attribute-encoder (get (aref type 0) 'soap-attribute-encoder))) + (let ((attribute-encoder (get (soap-type-of type) 'soap-attribute-encoder))) (cl-assert attribute-encoder nil - "no soap-attribute-encoder for %s type" (aref type 0)) + "no soap-attribute-encoder for %s type" (soap-type-of type)) (funcall attribute-encoder value type))) (defun soap-encode-value (value type) @@ -2892,8 +2900,8 @@ soap-encode-value is to be encoded. This is a generic function which finds an encoder function based on TYPE and calls that encoder to do the work." - (let ((encoder (get (aref type 0) 'soap-encoder))) - (cl-assert encoder nil "no soap-encoder for %s type" (aref type 0)) + (let ((encoder (get (soap-type-of type) 'soap-encoder))) + (cl-assert encoder nil "no soap-encoder for %s type" (soap-type-of type)) (funcall encoder value type)) (when (soap-element-namespace-tag type) (add-to-list 'soap-encoded-namespaces (soap-element-namespace-tag type)))) diff --git a/lisp/net/soap-inspect.el b/lisp/net/soap-inspect.el index 050be45..252b1f3 100644 --- a/lisp/net/soap-inspect.el +++ b/lisp/net/soap-inspect.el @@ -49,10 +49,10 @@ soap-sample-value This is a generic function, depending on TYPE a specific function will be called." - (let ((sample-value (get (aref type 0) 'soap-sample-value))) + (let ((sample-value (get (soap-type-of type) 'soap-sample-value))) (if sample-value (funcall sample-value type) - (error "Cannot provide sample value for type %s" (aref type 0))))) + (error "Cannot provide sample value for type %s" (soap-type-of type))))) (defun soap-sample-value-for-xs-basic-type (type) "Provide a sample value for TYPE, an xs-basic-type. @@ -174,31 +174,31 @@ soap-sample-value-for-message (progn ;; Install soap-sample-value methods for our types - (put (aref (make-soap-xs-basic-type) 0) + (put (soap-type-of (make-soap-xs-basic-type)) 'soap-sample-value 'soap-sample-value-for-xs-basic-type) - (put (aref (make-soap-xs-element) 0) + (put (soap-type-of (make-soap-xs-element)) 'soap-sample-value 'soap-sample-value-for-xs-element) - (put (aref (make-soap-xs-attribute) 0) + (put (soap-type-of (make-soap-xs-attribute)) 'soap-sample-value 'soap-sample-value-for-xs-attribute) - (put (aref (make-soap-xs-attribute) 0) + (put (soap-type-of (make-soap-xs-attribute)) 'soap-sample-value 'soap-sample-value-for-xs-attribute-group) - (put (aref (make-soap-xs-simple-type) 0) + (put (soap-type-of (make-soap-xs-simple-type)) 'soap-sample-value 'soap-sample-value-for-xs-simple-type) - (put (aref (make-soap-xs-complex-type) 0) + (put (soap-type-of (make-soap-xs-complex-type)) 'soap-sample-value 'soap-sample-value-for-xs-complex-type) - (put (aref (make-soap-message) 0) + (put (soap-type-of (make-soap-message)) 'soap-sample-value 'soap-sample-value-for-message)) @@ -222,7 +222,7 @@ soap-inspect The buffer is populated with information about ELEMENT with links to its sub elements. If ELEMENT is the WSDL document itself, the entire WSDL can be inspected." - (let ((inspect (get (aref element 0) 'soap-inspect))) + (let ((inspect (get (soap-type-of element) 'soap-inspect))) (unless inspect (error "Soap-inspect: no inspector for element")) @@ -507,39 +507,39 @@ soap-inspect-wsdl (progn ;; Install the soap-inspect methods for our types - (put (aref (make-soap-xs-basic-type) 0) 'soap-inspect + (put (soap-type-of (make-soap-xs-basic-type)) 'soap-inspect 'soap-inspect-xs-basic-type) - (put (aref (make-soap-xs-element) 0) 'soap-inspect + (put (soap-type-of (make-soap-xs-element)) 'soap-inspect 'soap-inspect-xs-element) - (put (aref (make-soap-xs-simple-type) 0) 'soap-inspect + (put (soap-type-of (make-soap-xs-simple-type)) 'soap-inspect 'soap-inspect-xs-simple-type) - (put (aref (make-soap-xs-complex-type) 0) 'soap-inspect + (put (soap-type-of (make-soap-xs-complex-type)) 'soap-inspect 'soap-inspect-xs-complex-type) - (put (aref (make-soap-xs-attribute) 0) 'soap-inspect + (put (soap-type-of (make-soap-xs-attribute)) 'soap-inspect 'soap-inspect-xs-attribute) - (put (aref (make-soap-xs-attribute-group) 0) 'soap-inspect + (put (soap-type-of (make-soap-xs-attribute-group)) 'soap-inspect 'soap-inspect-xs-attribute-group) - (put (aref (make-soap-message) 0) 'soap-inspect + (put (soap-type-of (make-soap-message)) 'soap-inspect 'soap-inspect-message) - (put (aref (make-soap-operation) 0) 'soap-inspect + (put (soap-type-of (make-soap-operation)) 'soap-inspect 'soap-inspect-operation) - (put (aref (make-soap-port-type) 0) 'soap-inspect + (put (soap-type-of (make-soap-port-type)) 'soap-inspect 'soap-inspect-port-type) - (put (aref (make-soap-binding) 0) 'soap-inspect + (put (soap-type-of (make-soap-binding)) 'soap-inspect 'soap-inspect-binding) - (put (aref (make-soap-port) 0) 'soap-inspect + (put (soap-type-of (make-soap-port)) 'soap-inspect 'soap-inspect-port) - (put (aref (soap-make-wsdl "origin") 0) 'soap-inspect + (put (soap-type-of (soap-make-wsdl "origin")) 'soap-inspect 'soap-inspect-wsdl)) (provide 'soap-inspect) -- 1.8.3.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 02:25:35 2018 Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 06:25:35 +0000 Received: from localhost ([127.0.0.1]:40242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXJf-0007dE-3e for submit@debbugs.gnu.org; Sat, 09 Jun 2018 02:25:35 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:44670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRRK6-0006x0-4Z for 31742@debbugs.gnu.org; Fri, 08 Jun 2018 20:01:38 -0400 Received: by mail-io0-f194.google.com with SMTP id g7-v6so17739212ioh.11 for <31742@debbugs.gnu.org>; Fri, 08 Jun 2018 17:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cAqpVI5ZHB+NpccNHqlWjHJHYKFI7/hVlU04WjOqROQ=; b=IaHxaXXtOsmCpt+p1o4NVr0wWDzxegmmE4XLqkqTbAobLo+WV2Mm51tONfB8Oaewli yU7D8DTnpsLIbQuZDdwTJlbw98zsplbqJEO4Wrpz5ubRcy1w2H/lhdHhVlbB10on2IDT gwpsdDvsME4NZrkgwosgdKEV+phw/x5cZawx1XH892ZUhEiIjc7BNTrk68gG//qbH4MD T9HK48pxt/TXfSu/Unvy77B/ywytSt2iqS5q/PZ93DwucQzBiCD2bjlkJ5d7hgOnNmEF wywQS1NzTMF9Wj7shKGTh80MuEEdZOijx+TY5tGa776+hT3GhBeROZpwobfZyfHpkPpo QTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cAqpVI5ZHB+NpccNHqlWjHJHYKFI7/hVlU04WjOqROQ=; b=N0PoC0rwPrZHfUzBGf0F2E6oVpZaBZo1Skz/vwLxhBAuu3W9jVVavWlUpVV9ZIUfsU ACLEqY70pl32XSkcjhFy9JVbr6w5+7DFd9E8chUJBbkZCJmW3U0gz4ah3v2ETbDW4KYS RidQ1v/RPorhRolB0NXnHw/L1rEHEecoY8JEaezREmVAAlmWx/xYmjrnrbAZnRAEsK/9 lFjdTW6xhznU/QmQrBvh5Qshp+fpLl3KN2agf0h6Yb5xderV6XSswK1TuTK1OYBnN/4v /jYnWQ884ucn0Bxyf9VA3Xbq/cBVRkDy+4lzjckC2QV6AGNuHlVMy7V9a6N6Xzg4NTYk XE3A== X-Gm-Message-State: APt69E3P2R+1/PzELCJsjArSFJpkAs+YyI940GFKh2dw+h2Q2A1pDLVN b46/BrXEYeqoEcJ8jEy+Mp2kw/Bso7obSQwciA4= X-Google-Smtp-Source: ADUXVKLnq8zKZAd7nW0XVJkqfWE42XPb7yFsIMFsdI3IO7QRTtUt3OS5uHr3nRG9UQMGY7ArVUYos5foFzEsZem2e4w= X-Received: by 2002:a6b:87d8:: with SMTP id r85-v6mr7587737ioi.243.1528502492399; Fri, 08 Jun 2018 17:01:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5e:c116:0:0:0:0:0 with HTTP; Fri, 8 Jun 2018 17:01:31 -0700 (PDT) In-Reply-To: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> From: Alex Harsanyi Date: Sat, 9 Jun 2018 08:01:31 +0800 Message-ID: Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 To: Thomas Fitzsimmons Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 31742 X-Mailman-Approved-At: Sat, 09 Jun 2018 02:25:33 -0400 Cc: Noam Postavsky , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On Fri, Jun 8, 2018 at 10:18 PM, Thomas Fitzsimmons wrote: > (CCing Alex Harsanyi.) > > Noam Postavsky writes: > >> Thomas Fitzsimmons writes: >> >>> Noam Postavsky writes: >>> >>>> Thomas Fitzsimmons writes: >>>> >>>>> (defun soap-resolve-references (element wsdl) >>>> >>>>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >>>> >>>> Ah, then it should work to replace the (aref element 0) with (type-of >>>> element) as long as cl-old-struct-compat-mode is enabled. >>> >>> Yes, I retested with that change and it does work. I guess I should >>> submit a patch to change all those occurrences in soap-client. >> >> I just noticed soap-client is also an ELPA package; then there is the >> additional complication that type-of will give the wrong answer in Emacs >> versions 25 and older. So you would need something like >> >> (let ((type (type-of element))) >> (if (eq type 'vector) >> (aref element 0) ; For Emacs 25 and earlier. >> type)) > > OK, I had that on my list to investigate before patching soap-client, > the compatibility range of type-of, but you've done it for me, thanks. > A soap-type-of compatibility function probably makes sense to replace > the (aref ... 0) occurrences in soap-client and soap-inspect. > >>> I'm hoping cl-old-struct-compat-mode will continue to be enabled by >>> default for a long time. >> The `(aref element 0)` trick is the only one that `soap-client` uses. All other struct usage is via accessor functions, the rest of the code does not assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is not needed. Thomas, will you prepare the patch for soap-client? Thanks, Alex. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 05:13:38 2018 Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 09:13:38 +0000 Received: from localhost ([127.0.0.1]:40303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRZwI-000352-Ij for submit@debbugs.gnu.org; Sat, 09 Jun 2018 05:13:38 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:54346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRZwF-00034m-7u for 31742@debbugs.gnu.org; Sat, 09 Jun 2018 05:13:37 -0400 Received: by mail-it0-f48.google.com with SMTP id 76-v6so5152403itx.4 for <31742@debbugs.gnu.org>; Sat, 09 Jun 2018 02:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=k5PLsjnkdmK5bLJbx/PXXeto5lPX35BWMnXxYfnrPzM=; b=K6hzDI37fPphsdmYzLnmPY3dA2KTkIaJ7UI8mMQt53kLNDrH7OHbl3uhf1nNTPblny inw0OTXbOoPq8j+SuPJFkCHF5K/RUcPQ5POgFOoqmpT5nqlAfMrRYIwpFMDCTLEdHjEQ JlAuJFZ+sxD5Yr3Q1bBbMlX6+TLHDR3rx2mQAzXNfTnJZnnoI8Z++hyqZLyXfm2zdNl2 NyO9iXPIe4hn7cwCTA6yt4E7PERG1am0twlM9xbws4ZhT7zRG3vM4iMgZWEu79oDR8zE R1eaK91OW2Aeotxk0r7yiGed9l4cwCxbdIArqzzu4z/tHyFAMiakniE9eYHGpirek1V5 sQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=k5PLsjnkdmK5bLJbx/PXXeto5lPX35BWMnXxYfnrPzM=; b=LaVMIm5DUlqnoHSjyFiiJN1u1RO8rPu1srNq1LgHdnTWgN6j+PfpIN2HACUcBvyj1W V+AzTQ6nBrjdhsP7XXAFmsGdP6wge+Vn+guWPBpqfy4Z0AzTaXULScME04+7ZAPSZ69p 3okWRVH+zQHug1ofXOjPmVEFgu5am2+bPh2SOXNjLbqoJC5qiER1eTUEloV92dPImxdD O3WpmGumMgfT9xKoyOMzN7cBgxIYEubHajGdm32ZkMHk25WuJtv7myZM1jvjjXN6M7rF ZZqBvgc5Lh18zF4SDe/rhRRDrK7VsSwXuGm/jV6nVn54NkfOXQkT4FNaKl3C+zgYwz74 vAdQ== X-Gm-Message-State: APt69E2/Fs88pNIRC6Kf72zDm4y3WW+O5gI5Q+s6HzDrqOQV9Vi7cWuJ tMgez/+CA76U0rxIPDZ+nLXIjT2chdyNbJBxLSI= X-Google-Smtp-Source: ADUXVKKMgOz2GGuh6tP1HbJ07I4ybBdiz1s+UG26VgDbzt/qD4yz+2RJz7ee3zAiAlFHrehH4zAOe0YwTTsTC7Qibng= X-Received: by 2002:a24:c887:: with SMTP id w129-v6mr4303798itf.122.1528535609547; Sat, 09 Jun 2018 02:13:29 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5e:c116:0:0:0:0:0 with HTTP; Sat, 9 Jun 2018 02:13:28 -0700 (PDT) In-Reply-To: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> From: Alex Harsanyi Date: Sat, 9 Jun 2018 17:13:28 +0800 Message-ID: Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 To: Thomas Fitzsimmons Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: Noam Postavsky , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 9, 2018 at 10:54 AM, Thomas Fitzsimmons wrote: > > How about the attached? I tested it in 26.1 with 25.1 excorporate.elc > byte-code, as well as with our test suite against 24.1, 25.1 and 26.1, > so it should be OK for GNU ELPA as well. > > If this looks OK, I'll bump the soap-client.el version to 3.1.4 when I > push. Can you please add a comment referencing this bug to the definition of `soap-type-of`. Other than that, it looks good to me. Alex. > > Thomas > From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 06:30:30 2018 Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 10:30:30 +0000 Received: from localhost ([127.0.0.1]:40352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRb8g-0006wg-98 for submit@debbugs.gnu.org; Sat, 09 Jun 2018 06:30:30 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:33575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRb8e-0006wR-KE for 31742@debbugs.gnu.org; Sat, 09 Jun 2018 06:30:29 -0400 Received: by mail-io0-f180.google.com with SMTP id d185-v6so18706894ioe.0 for <31742@debbugs.gnu.org>; Sat, 09 Jun 2018 03:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=yTcpfIWd6WvXsDqSe4NijMtr09zABmAid4YyZe0qDZU=; b=R5K7shpvO6dNuJi3r12c0xIvviINHj9R11P8J1ufuQaXuc9IHgpD7DP1neksgnnS4b 0vdIXKd+2WdXzJuJqKGn/hnypXxUHhh7PnStglchQfzZZXVRvIfXstpwYjAuet5yxKc7 wDqGFOl+CPpLnNYH9v4r4Bl7damvG6Wp9b29Xq+MxBp5j+nb/gW3u3ryG7peNtmdPnqH qWrGOK/6lIRdnwcwV9OvsJKg3eMZHPxa1HdEw3CEhIg+MLuocdyAkU11LNKozl7Eexxp 6QeLSN1RQNcFrJbqL50KvhWmNP2y9HULEmtmQm6dio7xeLW7sPW5/VoYfGM89Wij6Mjd lRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=yTcpfIWd6WvXsDqSe4NijMtr09zABmAid4YyZe0qDZU=; b=PRORCcl/65OQNmjQmsoz9YSW1RqZKExti3COsq7y6q9wLLsH7wl1lEFdw8rH8S3RHT zAf3hLBqjZqldKmq/UZS9Bvb6CAUNPJp+ApLwYStbKBfIw80Ao04J3GVu77S4kc01JxE MbR5eyRG7kEYdLDNdTO02ORgPttJ5t0i2pFWfYCIkeEvCnz+Wyzqg8ZyPOJc+zziQdQb ttPKXQ20iwyNF4Qmeros9sl7ATvxplb4S/p7xIDTUdm9gbyL0K2XcdfMlVRlXBXloaOC WjJC07yOir4uYr1Ij33hYGnFvRHdge3EGXiod3go0ExWjli+NKp9Izt6U8aK5QnPHvxw gduw== X-Gm-Message-State: APt69E2uTTF4H3xyZLrs0faPtiZtRKT1pYTH26b9R0HiZHEr5PGo6IoT fmp6LJRKbu0WOChPacMu5dImNzOWV1o= X-Google-Smtp-Source: ADUXVKJ3shlFF8gT/Tgv+psPO1hzJ6lixK9AgjUUGSryVAD/zw1SqTo4Kedon87VcWclN2vWLI4Qvw== X-Received: by 2002:a6b:f00a:: with SMTP id w10-v6mr8769209ioc.176.1528540222834; Sat, 09 Jun 2018 03:30:22 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id k19-v6sm1916339itb.35.2018.06.09.03.30.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 03:30:22 -0700 (PDT) From: Thomas Fitzsimmons To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 In-Reply-To: (Alex Harsanyi's message of "Sat, 9 Jun 2018 08:01:31 +0800") References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Date: Sat, 09 Jun 2018 06:30:21 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: Noam Postavsky , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Harsanyi writes: > On Fri, Jun 8, 2018 at 10:18 PM, Thomas Fitzsimmons wrote: >> (CCing Alex Harsanyi.) >> >> Noam Postavsky writes: >> >>> Thomas Fitzsimmons writes: >>> >>>> Noam Postavsky writes: >>>> >>>>> Thomas Fitzsimmons writes: >>>>> >>>>>> (defun soap-resolve-references (element wsdl) >>>>> >>>>>> (let ((resolver (get (aref element 0) 'soap-resolve-references))) >>>>> >>>>> Ah, then it should work to replace the (aref element 0) with (type-of >>>>> element) as long as cl-old-struct-compat-mode is enabled. >>>> >>>> Yes, I retested with that change and it does work. I guess I should >>>> submit a patch to change all those occurrences in soap-client. >>> >>> I just noticed soap-client is also an ELPA package; then there is the >>> additional complication that type-of will give the wrong answer in Emacs >>> versions 25 and older. So you would need something like >>> >>> (let ((type (type-of element))) >>> (if (eq type 'vector) >>> (aref element 0) ; For Emacs 25 and earlier. >>> type)) >> >> OK, I had that on my list to investigate before patching soap-client, >> the compatibility range of type-of, but you've done it for me, thanks. >> A soap-type-of compatibility function probably makes sense to replace >> the (aref ... 0) occurrences in soap-client and soap-inspect. >> >>>> I'm hoping cl-old-struct-compat-mode will continue to be enabled by >>>> default for a long time. >>> > > The `(aref element 0)` trick is the only one that `soap-client` uses. All > other struct usage is via accessor functions, the rest of the code does not > assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is > not needed. I went back and tested with cl-old-struct-compat-mode disabled, with the soap-type-of patch, and I get an earlier failure, via M-x excorporate: Debugger entered--Lisp error: (wrong-type-argument soap-element [cl-struct-soap-port "ExchangeServicePort" [...] signal(wrong-type-argument (soap-element [cl-struct-soap-port "ExchangeServicePort" nil [...] (or (and (memq (type-of element) cl-struct-soap-element-tags) t) (signal 'wrong-type-argument (list 'soap-ele [...] (progn (or (and (memq (type-of element) cl-struct-soap-element-tags) t) (signal 'wrong-type-argument (list 's [...] (let ((name (progn (or (and (memq (type-of element) cl-struct-soap-element-tags) t) (signal 'wrong-type-argum [...] soap-namespace-put([cl-struct-soap-port "ExchangeServicePort" nil "https://[redacted]/ews/exchange.asmx" [...] exco--bind-wsdl(#s(soap-wsdl :origin "https://[redacted]/ews/exchange.asmx" :current-file nil :xmlschema- [...] #f(compiled-function (fsm state-data) #)(fsm-exco--fsm-47 (:identifier ("fitzsim@cisco. [...] fsm-update(fsm-exco--fsm-47 :retrieving-data (:identifier ("fitzsim@cisco.com" . "https://[redacted]/ews [...] fsm-send-sync(fsm-exco--fsm-47 t nil) apply(fsm-send-sync (fsm-exco--fsm-47 t nil)) timer-event-handler([t 23323 41935 594437 nil fsm-send-sync (fsm-exco--fsm-47 t nil) nil 155000]) The old/new cl-struct mixing happens because excorporate.elc (25.1 byte-code) calls make-soap-port, and passes the result to soap-client (26.1). So at least for Excorporate, cl-old-struct-compat-mode is needed (in addition to the (aref ... 0) -> (soap-type-of ...) soap-client change). Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 06:32:33 2018 Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 10:32:33 +0000 Received: from localhost ([127.0.0.1]:40359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRbAe-00070p-Nt for submit@debbugs.gnu.org; Sat, 09 Jun 2018 06:32:33 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:34752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRbAd-0006zX-10 for 31742@debbugs.gnu.org; Sat, 09 Jun 2018 06:32:31 -0400 Received: by mail-io0-f173.google.com with SMTP id e15-v6so18711516iog.1 for <31742@debbugs.gnu.org>; Sat, 09 Jun 2018 03:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iSuyylACoUCxpCf9JXA193miknrrySOxD3t+UcUtP/U=; b=NZK4xlwwgNkuW2+Hl2WIY2ynwYEsDpgHpP+iz4mInM7WCRv3g5U/OYNZpIq7h8DWhu p6RaMsNLn2+bovS/oWBTpswCMK8rCHv/2e4XhcTqizi6/SuUNDr4QMy4OGx7AlPfoKab S07n90cPO+zkjQF8kImHeUq615XJZDOacpbxIAk/3zZvAMNAVLtHTf0JSf8u1z9myLCi hXAngmgLtLejjw2XawFuKldayF3ydjWi0FDp+1opyt4UEUIvSckN/l7VH4xn8mncnQZ0 4E9AERVoFDuScwt+URk0XVf+HEftNhrHZKttmiSpZOyPIpAfx7jGebSjdiFvMKw0Vpcu bn3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iSuyylACoUCxpCf9JXA193miknrrySOxD3t+UcUtP/U=; b=F3unj0Urxn4WGKrNSX6i4zxa1P42Xf8r8V61qEhu1EOeWsFoTEIYCdPwLac9yJXx/A mWk1S3UwESPh58l+atq8Kg1XHDkXLAACYh6vt+bZhrO+agUUTAQJxfpFIAUrHQ1y1qdt x6ZjFRvnfNDO3HWcr5ylQq5r8/sQ2yIVzIynrlJvdppHHUxXxaLSUZkXeIDGvGNfDOyx ZzVk93FGvbtg5dAyOWFQmvduRUGIdt99I0jJUEnGGLpoLgy369l3Ri3JjqcV1q57zmgQ 1mV16LXyOKIGF9d7sQoqqaeeLpW2jKl4ElVZh1a3uk72Y8emAYJGy/EB+5q5RQGlJPH8 eFiw== X-Gm-Message-State: APt69E3MeYzK427JrPXy7+MaTWMYE7RaSGDJVdTK8+IRF+MtIIfPuzHe yFt0D5dTXSB0KMrDbiCYGlHxBec6Qxk= X-Google-Smtp-Source: ADUXVKLHiYkAr2/O8RWruBSEbUFAWEqkjZvUPklaF7C22/jn1Ga1k5z97MSkmeh5i4cpAjMxjd8yaw== X-Received: by 2002:a6b:9403:: with SMTP id w3-v6mr1265042iod.108.1528540345508; Sat, 09 Jun 2018 03:32:25 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id d199-v6sm11383455ioe.51.2018.06.09.03.32.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 03:32:24 -0700 (PDT) From: Thomas Fitzsimmons To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Sat, 09 Jun 2018 06:32:23 -0400 In-Reply-To: (Alex Harsanyi's message of "Sat, 9 Jun 2018 17:13:28 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 31742 Cc: Noam Postavsky , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Alex Harsanyi writes: > On Sat, Jun 9, 2018 at 10:54 AM, Thomas Fitzsimmons wrote: > >> >> How about the attached? I tested it in 26.1 with 25.1 excorporate.elc >> byte-code, as well as with our test suite against 24.1, 25.1 and 26.1, >> so it should be OK for GNU ELPA as well. >> >> If this looks OK, I'll bump the soap-client.el version to 3.1.4 when I >> push. > > Can you please add a comment referencing this bug to the definition of > `soap-type-of`. Other than that, it looks good to me. OK, will do. I think I should put this on the emacs-26 branch, and also on master so that it'll automatically get updated in GNU ELPA. Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 08:13:13 2018 Received: (at 31742) by debbugs.gnu.org; 9 Jun 2018 12:13:13 +0000 Received: from localhost ([127.0.0.1]:40411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRck4-0002sC-QE for submit@debbugs.gnu.org; Sat, 09 Jun 2018 08:13:12 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:35225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRck3-0002rz-BT for 31742@debbugs.gnu.org; Sat, 09 Jun 2018 08:13:11 -0400 Received: by mail-io0-f172.google.com with SMTP id u4-v6so18868712iof.2 for <31742@debbugs.gnu.org>; Sat, 09 Jun 2018 05:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TWcd8vxb63d1zKB5WIPNf8rc7ddX3SXx1BskJzZVETs=; b=rGJUFqf2mcSopvf8gaV6zLwh+j9bsbvQvdPZfppvaVAh2uKnLZrOs+UdH79mnkfiPK R1KNMZ1DAf+K+rXH+/d5Odkmpgv8pFsgOK4x6o1pzXcn9wgNIMMZICF2fVCLA+e6/mjU l15x5SoKKcI6HREPc9KCdtd9fiyCm7GUkGEh6jYejDnymEHFCF64MhY5FsgjCVWCuMqV 79PSVF+IFeBafZXfx5P6t9ww9+QY/S7wCIApTECFxVPIj1paD02pbxYw0GrhXyzlq5yA ADZjTNYmXoBrNGYKRAZLChGfq8siOwZeV/i8KrqET95I319dS8jbA+zb68NwovM4CBgq Ah1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TWcd8vxb63d1zKB5WIPNf8rc7ddX3SXx1BskJzZVETs=; b=BASxcmMVnH3rOjFbMqwN45KV+oLeiqnJPVkqn9SPh7d8/Wy6mKMsouV7TB1hEdL0Nc ANb0wZ6S8SZ87XJHwJggacoIiiJFg1DOIPts0PYa7u71QBBPuqmwwFqVz3uNDHnNQqgc 2zpZMbNI5z1510ZVCHO0AVidHIRucQZJmHJOMOzxsfCZzRPdVknG428JiT+32Aehk/vF bbE5mJrF2aJD0n1pejg6ElCoap3tfKCwnFZN5jjW2aTy4ihNezwxtcF3t43/wW+MUOez o8xhuCgEfFRlSyyNpbOKsR0fkwKDrLNvXqlxyeQtiLiX4QYbZp4UWUGnDEpkusTVlBjB CAeQ== X-Gm-Message-State: APt69E22/21tn5n7nB0XSIQHKHtYyYdlC21EAPoY2KplLfshkV++1hcb r1HIVdsJ39V0vuP7BwHlloCBxA== X-Google-Smtp-Source: ADUXVKIRNqn4mKO9+tl4ehEpSaJvm7fcz9iTi8p99Nlqw6a0xRxssC00kMCqxPiBRVAF8t0ZJR+O0A== X-Received: by 2002:a6b:214a:: with SMTP id h71-v6mr7810598ioh.229.1528546385572; Sat, 09 Jun 2018 05:13:05 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z70-v6sm1983890itb.14.2018.06.09.05.13.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 05:13:04 -0700 (PDT) From: Noam Postavsky To: Thomas Fitzsimmons Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Sat, 09 Jun 2018 08:13:03 -0400 In-Reply-To: (Thomas Fitzsimmons's message of "Sat, 09 Jun 2018 06:30:21 -0400") Message-ID: <87muw417lc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: Alex Harsanyi , 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The `(aref element 0)` trick is the only one that `soap-client` uses. All >> other struct usage is via accessor functions, the rest of the code does not >> assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is >> not needed. > I went back and tested with cl-old-struct-compat-mode disabled, with the > soap-type-of patch, and I get an earlier failure, via M-x excorporate: > So at least for Excorporate, cl-old-struct-compat-mode is > needed (in addition to the (aref ... 0) -> (soap-type-of ...) > soap-client change). Yeah, and for (type-of element) to properly substitute for (aref element 0) without cl-old-struct-compat-mode you would need (defun soap-type-of (element) "Return the type of ELEMENT." (let ((type (type-of element))) (unless (eq type 'vector) ; For Emacs 25 and earlier. (setq type (aref element 0))) (if (string-match "\\`cl-struct-" (symbol-name type)) ; Old-style struct. (intern (substring (symbol-name type) (match-end 0))) type))) But since cl-old-struct-compat-mode activates automagically, may as well take advantage of it. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 21:55:57 2018 Received: (at 31742-done) by debbugs.gnu.org; 12 Jun 2018 01:55:57 +0000 Received: from localhost ([127.0.0.1]:43840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSYXN-0007Dt-1g for submit@debbugs.gnu.org; Mon, 11 Jun 2018 21:55:57 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:53611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSYXL-0007Df-N5 for 31742-done@debbugs.gnu.org; Mon, 11 Jun 2018 21:55:56 -0400 Received: by mail-it0-f54.google.com with SMTP id a195-v6so12764996itd.3 for <31742-done@debbugs.gnu.org>; Mon, 11 Jun 2018 18:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qltFq7UKExKdP67r6mneMs82aUBgg7Nhn6G5gxBhcOA=; b=chpZwCv8+3NDzudw+dVBZiCpF5bm2uWdf+TkPAFrMWxSwmYDV/ZbJOc6VEU7PIOhSU wnCu/uFUr9iOCqaTtBotbboXx7adE+HWudB2q/jXq+CRL0sH9iv7s0q66j3hrhGpZ1Ui RViA8RSrOEZRWDF8rjDGmIlyyZ8BKFglXaTL6ZU++XjvZS6ieUp3KgMcGXEJ0uvjgLjS JOg9UOSPh0TPjuBQgJOmHoKJRUAQSnXichr0TWr+qAr7K74ZGwuWrFwlp/ti8ctBOpYF zr5cJ+8bIEtW8wFNsb01jbvyQXmqPfbEdt4bPO7YXuHtWjFijJsvZ2CAE/cHEg+JBJdd FCCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qltFq7UKExKdP67r6mneMs82aUBgg7Nhn6G5gxBhcOA=; b=pwVLls+6/WgesQjRCkK35WkMbNPgOVmlEi7GJaRCbs7Kk/3QFgNq6qIUlkp41YLLt4 YkdnLdZCm2mfqGJaQjwlLZp0r8QQcjfqYvFurgnl2Xz29vWLf2swdGE+C73Z+b9UNL8x tWgJhoWeR9gL0jm76UH05YEH0bGdiREKtYbKF7M3Wm/SK6ISRy6sqtxRquTCfgnifWpA EPRaEaJmjgJryaqLUYcevOhFO8IsUM5Z1Ttn/k8HGl6wE1NfPWZHNoHCUKf/jtNBlYC3 w/ErpdVYjOyq4RS6IisJlruYD3dIwpKd9tTkA2JcPft89P43z5xOaidDvpyTZGDBlr+p bRDA== X-Gm-Message-State: APt69E1JBDMtbRpoJ6N505HS83qnJqG9gpp75KOiLEkfQGLYpjyALsJy t5DV+Xo57wdNt3DS2AL0LIvMubAT X-Google-Smtp-Source: ADUXVKIYntUk1wryx7ihbA1GOqTlGdMejAAbSzog+T8GcBqNY2J99RU9fS/XAjk/XsBtTAEEP0sOCw== X-Received: by 2002:a24:8201:: with SMTP id t1-v6mr1341251itd.51.1528768549696; Mon, 11 Jun 2018 18:55:49 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id s130-v6sm4799381ita.2.2018.06.11.18.55.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 18:55:48 -0700 (PDT) From: Thomas Fitzsimmons To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Mon, 11 Jun 2018 21:55:48 -0400 In-Reply-To: (Alex Harsanyi's message of "Sat, 9 Jun 2018 17:13:28 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742-done Cc: Noam Postavsky , 31742-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Harsanyi writes: > On Sat, Jun 9, 2018 at 10:54 AM, Thomas Fitzsimmons wrote: > >> >> How about the attached? I tested it in 26.1 with 25.1 excorporate.elc >> byte-code, as well as with our test suite against 24.1, 25.1 and 26.1, >> so it should be OK for GNU ELPA as well. >> >> If this looks OK, I'll bump the soap-client.el version to 3.1.4 when I >> push. > > Can you please add a comment referencing this bug to the definition of > `soap-type-of`. Other than that, it looks good to me. I added the comment, bumped the soap-client version to 3.1.4 and pushed the patch to master so that GNU ELPA will be regenerated tonight. I also backported the patch to the emacs-26 branch since it fixes a functional regression. Thomas From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 13:11:49 2018 Received: (at 31742) by debbugs.gnu.org; 12 Jun 2018 17:11:49 +0000 Received: from localhost ([127.0.0.1]:45295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSmph-0005Yw-5B for submit@debbugs.gnu.org; Tue, 12 Jun 2018 13:11:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSmpf-0005Yh-IL for 31742@debbugs.gnu.org; Tue, 12 Jun 2018 13:11:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSmpX-0004t9-CZ for 31742@debbugs.gnu.org; Tue, 12 Jun 2018 13:11:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSmpX-0004t5-8T; Tue, 12 Jun 2018 13:11:39 -0400 Received: from [176.228.60.248] (port=4180 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSmpW-0005rU-JC; Tue, 12 Jun 2018 13:11:39 -0400 Date: Tue, 12 Jun 2018 20:11:49 +0300 Message-Id: <83po0w3p62.fsf@gnu.org> From: Eli Zaretskii To: Thomas Fitzsimmons In-reply-to: (message from Thomas Fitzsimmons on Mon, 11 Jun 2018 21:55:48 -0400) Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Thomas Fitzsimmons > Date: Mon, 11 Jun 2018 21:55:48 -0400 > Cc: Noam Postavsky , 31742-done@debbugs.gnu.org > > I added the comment, bumped the soap-client version to 3.1.4 and pushed > the patch to master so that GNU ELPA will be regenerated tonight. I > also backported the patch to the emacs-26 branch since it fixes a > functional regression. Thanks, but please in the future always ask before pushing stuff to the release branch. Not every regression fix should go to emacs-26, only those which we consider "safe enough". Also, if a change should be both on master and on emacs-26, push only to the latter, and it will be later merged to master together with other changes in emacs-26. We only backport from master if initially we didn't intend for a change to be on emacs-26; otherwise we merge in the other direction. (This is all explained in CONTRIBUTE under "Branches".) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 21:39:47 2018 Received: (at 31742) by debbugs.gnu.org; 13 Jun 2018 01:39:47 +0000 Received: from localhost ([127.0.0.1]:45576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSulG-0001uu-QN for submit@debbugs.gnu.org; Tue, 12 Jun 2018 21:39:47 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:40391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSulF-0001ui-Aw for 31742@debbugs.gnu.org; Tue, 12 Jun 2018 21:39:45 -0400 Received: by mail-it0-f47.google.com with SMTP id 188-v6so1806123ita.5 for <31742@debbugs.gnu.org>; Tue, 12 Jun 2018 18:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=O7TsLALJXfyvVtz/oEHJrXbVXhAjvxFUarSvscEYs10=; b=E01IUdz9npGEpDqtFWKc4ISjg54o6cSkRsJfRCBw9+2aNW/cDBoshfh2LTDFNSbYLz s9Sp+c6yeJETy/H4mv31I5Kjlut48WFLyXRLl9PXndhE3i9gjH6+Xb47DWOjHTeP3zGL Cp+Lx4LVUMzljd8DgTdxqvsomm94i5r4HZBnKIIkUQP5HmJ5KtK8yvANZ9QIyZPTd5PY qNQFOJSFQ9HMgv9kAkPsfGJrjsKneny2z4BfanHeoIuWnzOKFgjmR1KV7gI3yhuNEeLS Y8AX3ZinOSllO9XqfT3y+rOVO+wqfzHk+lUdU/Yjzu5BIjJ+x/5So1RN3uhFyrJ1KSi+ dpHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=O7TsLALJXfyvVtz/oEHJrXbVXhAjvxFUarSvscEYs10=; b=VEut8RuvEjzbpMesaTMahoC+du0tt+ChbS1pkXgI32vVAvE1PQOBXtnHj3TsQAyiYQ 82ahB+OHF7Gbz1cgYn2BUQZXF2rVztLG7teHFMHBMNTpJ2nmqn62yHZIon8qULxnjt4+ dYo5Vb8cjojBBUacWpAKj9ZFhl7aANlXmtoiVemem+072ZhNhxbDj6JOxUoZmug/4ecS ivacsDaVB9H2WLKZu3fnokNVpgs9v2iXnVVNmosVYSCWiW1dgTUoGZihqjwq+5g0uuxr ZYTzMIFfDzt080MyaK1yxSJRUvlI+23heJ/dhP6lfQzOdKPF/vOjNAHi3M1qPiENwwM9 quUQ== X-Gm-Message-State: APt69E3u+3KzqxQI9Mq7Fgv+oTKl0/wWL63NIpKywSgTqklxmFjOlNpw KpsZDfYtwZKK+6ioQWuFtqd1I65y X-Google-Smtp-Source: ADUXVKIkHbgie3byMybuuTP96Wq2SDk37m8LIdVa5NIGfT5euiJKVQDH9VbFvZ/8ZGU1Y8pTTCV8jA== X-Received: by 2002:a24:4e8f:: with SMTP id r137-v6mr3025224ita.9.1528853979518; Tue, 12 Jun 2018 18:39:39 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 16-v6sm1076733itk.17.2018.06.12.18.39.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Jun 2018 18:39:38 -0700 (PDT) From: Thomas Fitzsimmons To: Eli Zaretskii Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> <83po0w3p62.fsf@gnu.org> Date: Tue, 12 Jun 2018 21:39:37 -0400 In-Reply-To: <83po0w3p62.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Jun 2018 20:11:49 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Thomas Fitzsimmons >> Date: Mon, 11 Jun 2018 21:55:48 -0400 >> Cc: Noam Postavsky , 31742-done@debbugs.gnu.org >> >> I added the comment, bumped the soap-client version to 3.1.4 and pushed >> the patch to master so that GNU ELPA will be regenerated tonight. I >> also backported the patch to the emacs-26 branch since it fixes a >> functional regression. > > Thanks, but please in the future always ask before pushing stuff to > the release branch. Not every regression fix should go to emacs-26, > only those which we consider "safe enough". OK, will do, sorry about that. > Also, if a change should be both on master and on emacs-26, push only > to the latter, and it will be later merged to master together with > other changes in emacs-26. We only backport from master if initially > we didn't intend for a change to be on emacs-26; otherwise we merge in > the other direction. (This is all explained in CONTRIBUTE under > "Branches".) Yes, I knew about the preferred emacs-26 -> master merge direction, but in this case I wanted to get the soap-client change out to GNU ELPA ASAP so that users could unbreak their Emacs 25 byte-code. A GNU ELPA rebuild of soap-client requires a push to master. I guess I should have undertaken a full gitmerge run myself after having had the patch reviewed for emacs-26 on emacs-devel; I considered doing so, but I thought the master -> emacs-26-backport approach would be less risky. But in the future I'll attempt the gitmerge route in cases like this. Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 16 20:12:27 2018 Received: (at 31742-done) by debbugs.gnu.org; 17 Jun 2018 00:12:27 +0000 Received: from localhost ([127.0.0.1]:52314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fULIx-0007np-Lb for submit@debbugs.gnu.org; Sat, 16 Jun 2018 20:12:27 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:54158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fULIv-0007nb-Mw for 31742-done@debbugs.gnu.org; Sat, 16 Jun 2018 20:12:26 -0400 Received: by mail-it0-f45.google.com with SMTP id a195-v6so7471840itd.3 for <31742-done@debbugs.gnu.org>; Sat, 16 Jun 2018 17:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aM4TQ30n3KOXZaKwU0d1UZOSLv9ftptDZDN7rhQslIw=; b=M0VKpxmlO2wLEOYoteHMyveSswme8e+ZIipAC+Z25oDEkd0M1ggDJRajBk1+G/B1gZ QuSAeqCGifNJcma36nZklXbgW8Z4ks7tAk7DPEa+iuKUOIpo+TZLVNxxc8qRASZm6DMn F+X6XPyMriCzeaIvW/FJut3pxBof+OF19ikDywhQkKesBT3v3hTOOXL8407E4DU40Mws 0zv/KAs81odSUNylaPNx0HWvJDei2mEZJWbiYyIYBbm1TIPuzkKkaMY5AmhzLfYilBjv ATfM84E5YMgpe4IqwDaWVglb5M9Qt/XPIzDYlKzMc58NhyVA4JYHP5WNERo+vTr5RD76 K9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aM4TQ30n3KOXZaKwU0d1UZOSLv9ftptDZDN7rhQslIw=; b=t6GwZnvKj7/xymiZOZn50b4kC/V850oICjVJ+Ap6iiXvMFaeIkBWB3srlKgHY96gZm xz5kE/3stlHnIe8/x6JyO3R5ORdItAodiMuBvA9KMl+BVGu6gZ9xXJ4gE8OO44n5U/fT KkzvftQJQuHW6CH/9GwqcQrZDlyWAaNUMf7f/XEZd2KeUV7xn4rHYmDh1/qb2fosZKXX VxFb5KW27SyLTrhJ90gCsnrEFbMVKC6BX7DkNZm5zJpLBPyKiWLeNtr63mBwwSvWz+Tf nBHr5GT+ingp46naafejw2zuZMBtr7FcZnU++0KGq+RaweYYgYB47IX3V/0Wnf3zKQJR k/Yg== X-Gm-Message-State: APt69E03onngfx5EUpALN1w2X8c5sCsCAWhYeWqAy8TObFqb0ZlecCgk t8OPrvVtgF7K48JzAlYnP/AZfoDg93SE1mMonrw= X-Google-Smtp-Source: ADUXVKLmeGr9vL+2/F3IzfKtyHlMj5JXWkAtbFGHeZ+KDm3w5xVyFEmD3+MY27EikwbuKQsLImYg3gx0m3Q9zpH2PkY= X-Received: by 2002:a24:310d:: with SMTP id y13-v6mr5346617ity.122.1529194340292; Sat, 16 Jun 2018 17:12:20 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5e:c116:0:0:0:0:0 with HTTP; Sat, 16 Jun 2018 17:12:19 -0700 (PDT) In-Reply-To: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> From: Alex Harsanyi Date: Sun, 17 Jun 2018 08:12:19 +0800 Message-ID: Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 To: Thomas Fitzsimmons Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742-done Cc: Noam Postavsky , 31742-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jun 12, 2018 at 9:55 AM, Thomas Fitzsimmons wrote: > I added the comment, bumped the soap-client version to 3.1.4 and pushed > the patch to master so that GNU ELPA will be regenerated tonight. I > also backported the patch to the emacs-26 branch since it fixes a > functional regression. Hi Thomas, Can you let me know where did you push the soap-client changes? I can see that the package was released at gnu.elpa.org, but the changes were not pushed either to the elpa.git repository at https://git.savannah.gnu.org/git/emacs/elpa.git, or to my own copy of it at https://github.com/alex-hhh/emacs-soap-client. Thanks, Alex. > > Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 16 20:36:33 2018 Received: (at 31742-done) by debbugs.gnu.org; 17 Jun 2018 00:36:33 +0000 Received: from localhost ([127.0.0.1]:52338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fULgG-0008Ln-SA for submit@debbugs.gnu.org; Sat, 16 Jun 2018 20:36:33 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:46622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fULgF-0008La-9J for 31742-done@debbugs.gnu.org; Sat, 16 Jun 2018 20:36:31 -0400 Received: by mail-io0-f180.google.com with SMTP id d22-v6so13834780iof.13 for <31742-done@debbugs.gnu.org>; Sat, 16 Jun 2018 17:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jcllN9Qef3w9Bu/rDCADSq4ovxRkht69fqPTzpB6QgQ=; b=Mn7MtOL7WIwtFiahORf3dNtOU+beIUgvs7dUT6k9eIWJmck9kdiuvAcUhU+aCsu/1g 9os3nQTBfQHQ2NNpWLyCmiZZBznQxR1HiwN3GoabHYE+I42ekEC6cNhMNRiGe5MMOpnR nXlFsr0TwLyfL5BrZLz4nQOM09j38v6FEQRuBu1ch2iHqvuLJDVWB2aWgR4DSDRV1/UM oHdGwFPS3unC0sOPDAisppdxTYCTTuZJs+06X2gd7t9xMw17J3wV1255/BT/V16s1+z/ mr1ADcWVgwaZMyDHoZ6YX7NhJrpbKoCuCImFeMqkgLP8kip0Vpfo+6aaRC0gLG3sSQ0j 0P1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jcllN9Qef3w9Bu/rDCADSq4ovxRkht69fqPTzpB6QgQ=; b=IfEHUSQpvy6+hF2TWABouyL3FtTfggf1fadbzuO5H4/PrrjVymHbXyJZ760lwwDY4+ /gn5QJogrmYpb44RLJwab6+dJiMNJxVyjpOsdkO5vmBCe8NPxXFf6J4Ftoizo2s8CT1P mOMjPwUHBETWXWdwKTgKhHVx0A/3ZlA8+A7J/Ekk4HrQmYFuYkCjlYvPKv5482VuygzS TPGLALLtkWZKbYRB1cFB6zK9pWmHbkjkHZ+DjwRsHy/ZzBMhtPpTIVvndW/ieFSZf236 yBYwDNDG8GjNfzUqSjltiFOZZ2zkmsSHRP6y5CBpMsqLaiN4BzMADknMycF6DZ69eaMw kwyg== X-Gm-Message-State: APt69E3Qb42B7NwucQfFQRbCIf2rRem9QkrxE4ueLBf5+Spc92AuCcvB CFJiq1/OxXnt2IU9LzYJeOr7lgz/ X-Google-Smtp-Source: ADUXVKLAoIVtD87PtDVfdc0GZ5WIqIg/se7xsSPlumFrNIsfOsahgjMAkXiu17m/aOMlFpcpplpe/w== X-Received: by 2002:a6b:582:: with SMTP id 124-v6mr5604010iof.94.1529195785495; Sat, 16 Jun 2018 17:36:25 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id e28-v6sm2808321itd.35.2018.06.16.17.36.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Jun 2018 17:36:24 -0700 (PDT) From: Thomas Fitzsimmons To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Sat, 16 Jun 2018 20:36:23 -0400 In-Reply-To: (Alex Harsanyi's message of "Sun, 17 Jun 2018 08:12:19 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742-done Cc: Noam Postavsky , 31742-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Harsanyi writes: > On Tue, Jun 12, 2018 at 9:55 AM, Thomas Fitzsimmons wrote: > >> I added the comment, bumped the soap-client version to 3.1.4 and pushed >> the patch to master so that GNU ELPA will be regenerated tonight. I >> also backported the patch to the emacs-26 branch since it fixes a >> functional regression. > > Hi Thomas, > > Can you let me know where did you push the soap-client changes? > > I can see that the package was released at gnu.elpa.org, but the > changes were not pushed either to the elpa.git repository at > https://git.savannah.gnu.org/git/emacs/elpa.git, or to my own copy of > it at https://github.com/alex-hhh/emacs-soap-client. I pushed it to the emacs.git master and emacs-26 branches: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1feb2e221349f26ec26bc684e0cce2acecbed3ca GNU ELPA pulls soap-client.el and soap-inspect.el from emacs.git's master branch. Let me know if you also want me to push the patch to https://github.com/alex-hhh/emacs-soap-client. Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 16 21:31:44 2018 Received: (at 31742-done) by debbugs.gnu.org; 17 Jun 2018 01:31:44 +0000 Received: from localhost ([127.0.0.1]:52377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUMXf-00018X-Na for submit@debbugs.gnu.org; Sat, 16 Jun 2018 21:31:43 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:42197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUMXd-00018K-Bz for 31742-done@debbugs.gnu.org; Sat, 16 Jun 2018 21:31:41 -0400 Received: by mail-io0-f177.google.com with SMTP id r24-v6so13902832ioh.9 for <31742-done@debbugs.gnu.org>; Sat, 16 Jun 2018 18:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=P3mBV0qBMRcSbkjZcW9MxctHZ5o7I/RzOEk/s/7BiDE=; b=XULJyExBTsouaahtnT7iorTNmD95LhAiGizMvlqgjhtInjKT+UKc1vMnMzncEO0+va 3AurJllPiv1K4kiLcu3+ezD+oh5rmsZ4U8XrOImq2HM84Joc0R2Sj67xfOu9FGQgQiYG YsNDKQUy4PiKEM0hlDd1jluO9xMVZK5pgPV3xDgt3vGiM848pvxpIbScruS+sedOF3to +Prkan72uv/+r4JgIa++vO/G01RsGFI0G6gb4AtbspzpysE/Ix9fgSKREX4PseshmG8K YPZHF0MdE8GR+lj3aLw+ovwd/CRObYQTBo6IRm+Aw2l623WjILqCwDLlKUtZQf1LXMYT wsEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=P3mBV0qBMRcSbkjZcW9MxctHZ5o7I/RzOEk/s/7BiDE=; b=NZS4qXv5537FcZnyGuKAaUy0qRc7DDlUAb2i7dxXcA3kZCBY8khYQFxAhJfHmQG7BY FKTXDp21KDNsWryGJrv8PdlArXmBhBIGPIT/rZXSzlxoZ5GSbik4zIcxDwpw1MPn7uYp ara01JAuaMNZNGnhnMsFKnWVfIrh5e7jBySRNwMVAIyASWbUifgwTXQ8b/rikhz/bLY4 jq+eU5Zl9viTRcfa1Tr7VhqxQF3jq19IzKdBBA0YZ3Ccf38kqidI3ca7YaVkjtEeRuP3 HSG4A10zMVVmkkLYlTJfTjswGWNUVwtQRqYGWIbQ5KGRcmrmaOOGHfgdeEpHVMptqrvA 0Q2Q== X-Gm-Message-State: APt69E16yEm/iIy5G+ow8weeI9evl9JoRynitcs1Uu0Y4g3cjo95qCfT 5DR+JdgDaCO82Yyxoqgn1Je576xeqx1NEm6nu5s= X-Google-Smtp-Source: ADUXVKL2cdNGK36vAo4BZmj/kEqXA68KJ4JaMx5elGR4OC42LS3oNuwjCT9p31+X8JNo45UZPEDlh/532x726gcWXO8= X-Received: by 2002:a6b:fb04:: with SMTP id h4-v6mr6374049iog.193.1529199095819; Sat, 16 Jun 2018 18:31:35 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5e:c116:0:0:0:0:0 with HTTP; Sat, 16 Jun 2018 18:31:35 -0700 (PDT) In-Reply-To: References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> From: Alex Harsanyi Date: Sun, 17 Jun 2018 09:31:35 +0800 Message-ID: Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 To: Thomas Fitzsimmons Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742-done Cc: Noam Postavsky , 31742-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Thomas, I was not aware that the soap-client.el in the GNU Emacs source has been updated -- the maintainers at the time wanted a version that just worked with debbugs, and put the most recent version in ELPA. There are two inconsistencies with the current system, which can cause some confusion: * the soap-client web page on elpa.gnu.org has a link to the elpa.git repository, but there is nothing there (the CGit and Gitweb links): http://elpa.gnu.org/packages/soap-client.html * in the GNU Emacs source code, soap-client.el has a "Homepage" link that points back to my GitHub repository, which is now out of date. I think we need to decide on where to keep the "official" development history for this package. As I see it, there are a few options: * Keep it on GitHub, where it is now. In this case, I think you should push the patch and the 3.1.4 tag there, and the ELPA links need to be fixed. * Import it into elpa.git, as a separate branch (I see other packages are maintained like that). In this case, the "Homepage" link should be updated to point to this source. * Keep it in the GNU Emacs source tree (this will loose the git history, but maybe it is not important). In this case the, both the "Homepage" link and the ELPA web page should be updated. I have no strong preference for either option, apart for making it easier for people to know where to go for the package source. If the GitHub repository is no longer the latest source code, I can archive it and point to the new location. Alex. On Sun, Jun 17, 2018 at 8:36 AM, Thomas Fitzsimmons wrote: > Alex Harsanyi writes: > >> On Tue, Jun 12, 2018 at 9:55 AM, Thomas Fitzsimmons wrote: >> >>> I added the comment, bumped the soap-client version to 3.1.4 and pushed >>> the patch to master so that GNU ELPA will be regenerated tonight. I >>> also backported the patch to the emacs-26 branch since it fixes a >>> functional regression. >> >> Hi Thomas, >> >> Can you let me know where did you push the soap-client changes? >> >> I can see that the package was released at gnu.elpa.org, but the >> changes were not pushed either to the elpa.git repository at >> https://git.savannah.gnu.org/git/emacs/elpa.git, or to my own copy of >> it at https://github.com/alex-hhh/emacs-soap-client. > > I pushed it to the emacs.git master and emacs-26 branches: > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1feb2e221349f26ec26bc684e0cce2acecbed3ca > > GNU ELPA pulls soap-client.el and soap-inspect.el from emacs.git's > master branch. > > Let me know if you also want me to push the patch to > https://github.com/alex-hhh/emacs-soap-client. > > Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 16 21:37:09 2018 Received: (at 31742) by debbugs.gnu.org; 17 Jun 2018 01:37:09 +0000 Received: from localhost ([127.0.0.1]:52383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUMcu-0001Fp-N2 for submit@debbugs.gnu.org; Sat, 16 Jun 2018 21:37:08 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:36170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUMct-0001FY-Jm; Sat, 16 Jun 2018 21:37:07 -0400 Received: by mail-io0-f182.google.com with SMTP id k3-v6so13936457iog.3; Sat, 16 Jun 2018 18:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Zf8thppoz3o7hzYonl2p4urmIg9P1WoCEQL1mwu99ug=; b=K+02cyDKtMT2v/ocvXn2P0GBy2B/af6VNsvom4nfLLHKrWzY3W+xZndvT/4OnhXuwA pA7CCSXomr6T+b3g2a5EVIiKJxVg/FcLIQU0UENNM9OY16h/0qi1RtAao8UmcYjdTcC7 XNP5sq41IfrPfO2GCD7TNfWLuSIRts4GjWbFUcFAYVbpcdz7S7FwHlTFezoJ1+Fiz2qt 8BSiMX+Hq7+fq4uapirBvJJqa6t7gYwrJMvShCZxgQSvW/bpDygRsADaCZdhVcDs5xv+ 5Aps1jZKDY1uSCylFZqOIfkkYDAACW3JubkGsb+5/CJ+n46uFGirPiku20WqbTEoTkcT e/RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Zf8thppoz3o7hzYonl2p4urmIg9P1WoCEQL1mwu99ug=; b=YXFgOiP4Nsbpl0Q7mhEqUTcJgsHasNtvjEjMXDKt72XC0HMJ8GDBYSaYyJfbcnMWg/ azZxOuj04yZ9NYh3XRThOgTuG84Nl/XKz7kcM7JK0fxYmjs22mtaY0Be+eiBMB4iJAJg A53d/RoANkfRDShyfIEVRNrhakDfAyA9d95W5r+qlkv6CLGeTPXT6eLegRy9zn9HdpZi KISKYdvvqyDyc6XgI3dH0bAJh8zPm4SRc3cIIcfxqpjGwm7j5TCmldiiM7FO2uSt0Vrl I018UKfRJVuZhlItxAdGOpdfSaRhusV46tKFjUHAyOFR2cm3F3dza+yENbpKVpjZFXgz w4nA== X-Gm-Message-State: APt69E3DK4LL/xrE/EgQelLncTIQsQ01d9F9VVoqSetw9gsAK2MEJvS5 +bpxetv33AzBVrl2pLN4dWfe+rGB X-Google-Smtp-Source: ADUXVKIq1GcmNRc+b0WIcZlQLVOxvMEDJAaYl4uN1ib/hEyKEj0tOtketkr529QQeZgv/n20Ox0Nuw== X-Received: by 2002:a6b:f812:: with SMTP id o18-v6mr5761282ioh.235.1529199421898; Sat, 16 Jun 2018 18:37:01 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id l82-v6sm2814480itl.25.2018.06.16.18.36.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Jun 2018 18:37:01 -0700 (PDT) From: Noam Postavsky To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Sat, 16 Jun 2018 21:36:58 -0400 In-Reply-To: (Alex Harsanyi's message of "Sun, 17 Jun 2018 09:31:35 +0800") Message-ID: <87fu1mtcqt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31742 Cc: Thomas Fitzsimmons , 31742-done@debbugs.gnu.org, 31742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Harsanyi writes: > * the soap-client web page on elpa.gnu.org has a link to the elpa.git > repository, but there is nothing there (the CGit and Gitweb links): > http://elpa.gnu.org/packages/soap-client.html To clarify, the version served from elpa.gnu.org is from the emacs.git repository. See externals-list in the elpa.git repository: ;; List of packages that are maintained externally. ;; The list is made of elements of the form (NAME KIND URL OPTS...). [...] ;; KIND can be one of: [...] ;; :core = part of GNU Emacs repository. [...] ("soap-client" :core ("lisp/net/soap-client.el" "lisp/net/soap-inspect.el")) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 17 09:02:51 2018 Received: (at 31742-done) by debbugs.gnu.org; 17 Jun 2018 13:02:51 +0000 Received: from localhost ([127.0.0.1]:52681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUXKV-0006Yp-Bh for submit@debbugs.gnu.org; Sun, 17 Jun 2018 09:02:51 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:50267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUXKT-0006Ya-Ei for 31742-done@debbugs.gnu.org; Sun, 17 Jun 2018 09:02:50 -0400 Received: by mail-it0-f54.google.com with SMTP id u4-v6so8513583itg.0 for <31742-done@debbugs.gnu.org>; Sun, 17 Jun 2018 06:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vJoBrjfjOwFo6nC1GHLHZnz2vsuTr05lZalyqDXGJNU=; b=Gd7wiYcpCndcEjdrgiIqQ/3LNxP7GtB37/u0dEkv7PskdzVtELn4Qm/z6YUAK6zoWU Lgf1A+jSxM4MUOR4OuvZCNqquWXaW6swyzvUkC4HZ4KN9CJSEM+i3P3UJQFyhln8I/Ob onjvvWl5YmN+P0DSUbjrcGWRRar2fbsmLKVMU/SPf9qlxu8BfruF+aWDfHKqx63flSqI lak5m3rXPaKVaOA2OHn2SRv9LUbGWeQ1hYM5UgKcH5BZ9AsV1NhoFASft/df4RRB6E/p WCQfCslfXQz/31x/bqvM7PPO0wJmd0RZjvyhof+M8/7U6qf2tvL8wvYdpIhnnpRP8ia6 zrKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vJoBrjfjOwFo6nC1GHLHZnz2vsuTr05lZalyqDXGJNU=; b=adJPL7VuQ7zSzj2U8i8n07sff5S7DSgjdo+XazDZhA4nDz2L/5Q4RKaUQPpXwa/YAp uqIqwbP7RO4UX1Gg3RaI/raJvb6rnUUV9k8mate6XN1DATrv385BUG8PkwFL17RvzdGp coVXcEemdrbKdobd947QfiH4DiWsQEPPJd61mefEyFWpBOgl7qTLf9sEis+EEFV97p9+ f5S4Gz2ZuPDHjtMsyf39qndAazj/Zv0V5E1JVRSgh/tGCB0uIBthmelpEqzof4xP+I1H c7yxlDfGwlg6SgtsVARbUWh9yYMTYGT067z8z2X2VZJ/51to8chq6wRY2uBI5cIYMJQH KHEA== X-Gm-Message-State: APt69E2u4FsTsiyB2+t2xDcbWnJr7tIYs6JnWmx/sgf9cTtiLt3ROKoq fuSY4MUKNWvZXogq9QnW6cKX5cLv X-Google-Smtp-Source: ADUXVKI20r6mOt09V6DBJT+oT5faZxysLROwpIBPSgkldzYrD266MqgpsoRUh3ny05PbPpfadtrelA== X-Received: by 2002:a02:9914:: with SMTP id r20-v6mr6633337jaj.144.1529240563508; Sun, 17 Jun 2018 06:02:43 -0700 (PDT) Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id n202-v6sm3048649itg.23.2018.06.17.06.02.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Jun 2018 06:02:42 -0700 (PDT) From: Thomas Fitzsimmons To: Alex Harsanyi Subject: Re: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 References: <87po132y9k.fsf@gmail.com> <87h8me3hyw.fsf@gmail.com> <87zi0611m6.fsf@gmail.com> <87vaat1ndq.fsf@gmail.com> Date: Sun, 17 Jun 2018 09:02:41 -0400 In-Reply-To: (Alex Harsanyi's message of "Sun, 17 Jun 2018 09:31:35 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31742-done Cc: Noam Postavsky , 31742-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Alex, I pushed the patch and the 3.1.4 tag to https://github.com/alex-hhh/emacs-soap-client.git so at least everything is consistent again, except that the ELPA page doesn't point to "Homepage". I think that's a bug in GNU ELPA's generation scripts though -- can you file a bug report for this? As for repository organization, I'm fine with things as-is, I just have to remember to push to GitHub anytime I push to emacs.git. Right now the history is almost the same between emacs.git and emacs-soap-client.git, and the files on the master branches are identical. Maybe in the future when elpa.git and emacs.git integration is better we can use the elpa.git-separate-branch approach, and emacs.git will automatically clone elpa.git as a submodule and everything will work in core and for GNU ELPA updates. In fact, soap-client is probably a good non-trivial package to experiment with different Git organization approaches for such core-and-GNU-ELPA packages. There was a thread on emacs-devel about this recently, in the context of adding BBDB to core. I'm not working on this Git integration effort directly right now, but I think some people are from time to time. Thomas Alex Harsanyi writes: > Hi Thomas, > > I was not aware that the soap-client.el in the GNU Emacs source has been > updated -- the maintainers at the time wanted a version that just worked with > debbugs, and put the most recent version in ELPA. > > There are two inconsistencies with the current system, which can cause some > confusion: > > * the soap-client web page on elpa.gnu.org has a link to the elpa.git > repository, but there is nothing there (the CGit and Gitweb links): > http://elpa.gnu.org/packages/soap-client.html > > * in the GNU Emacs source code, soap-client.el has a "Homepage" link that > points back to my GitHub repository, which is now out of date. > > I think we need to decide on where to keep the "official" development history > for this package. As I see it, there are a few options: > > * Keep it on GitHub, where it is now. In this case, I think you should push > the patch and the 3.1.4 tag there, and the ELPA links need to be fixed. > > * Import it into elpa.git, as a separate branch (I see other packages are > maintained like that). In this case, the "Homepage" link should be updated > to point to this source. > > * Keep it in the GNU Emacs source tree (this will loose the git history, but > maybe it is not important). In this case the, both the "Homepage" link and > the ELPA web page should be updated. > > I have no strong preference for either option, apart for making it easier for > people to know where to go for the package source. If the GitHub repository > is no longer the latest source code, I can archive it and point to the new > location. > > > Alex. > > On Sun, Jun 17, 2018 at 8:36 AM, Thomas Fitzsimmons wrote: >> Alex Harsanyi writes: >> >>> On Tue, Jun 12, 2018 at 9:55 AM, Thomas Fitzsimmons wrote: >>> >>>> I added the comment, bumped the soap-client version to 3.1.4 and pushed >>>> the patch to master so that GNU ELPA will be regenerated tonight. I >>>> also backported the patch to the emacs-26 branch since it fixes a >>>> functional regression. >>> >>> Hi Thomas, >>> >>> Can you let me know where did you push the soap-client changes? >>> >>> I can see that the package was released at gnu.elpa.org, but the >>> changes were not pushed either to the elpa.git repository at >>> https://git.savannah.gnu.org/git/emacs/elpa.git, or to my own copy of >>> it at https://github.com/alex-hhh/emacs-soap-client. >> >> I pushed it to the emacs.git master and emacs-26 branches: >> >> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1feb2e221349f26ec26bc684e0cce2acecbed3ca >> >> GNU ELPA pulls soap-client.el and soap-inspect.el from emacs.git's >> master branch. >> >> Let me know if you also want me to push the patch to >> https://github.com/alex-hhh/emacs-soap-client. >> >> Thomas From unknown Fri Sep 05 20:36:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Jul 2018 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator