From unknown Sun Aug 17 10:25:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31738: 27.0.50; Flymake manual doesn't mention that syntax checking is started in after-save-hook Resent-From: =?UTF-8?Q?Micha=C5=82?= Kondraciuk Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jun 2018 19:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31738 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31738@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152831507716167 (code B ref -1); Wed, 06 Jun 2018 19:58:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jun 2018 19:57:57 +0000 Received: from localhost ([127.0.0.1]:37061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQeZA-0004Ch-OD for submit@debbugs.gnu.org; Wed, 06 Jun 2018 15:57:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQeZA-0004CW-4i for submit@debbugs.gnu.org; Wed, 06 Jun 2018 15:57:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQeZ4-0001ak-1x for submit@debbugs.gnu.org; Wed, 06 Jun 2018 15:57:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQeZ3-0001ag-Uf for submit@debbugs.gnu.org; Wed, 06 Jun 2018 15:57:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQeZ2-0007xz-Ih for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 15:57:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQeYz-0001XU-GT for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 15:57:48 -0400 Received: from sender-pp-092.zoho.com ([135.84.80.237]:25350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQeYz-0001UL-6c for bug-gnu-emacs@gnu.org; Wed, 06 Jun 2018 15:57:45 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=to:from:subject:message-id:date:user-agent:mime-version:content-type; b=JWXO34iDCwIU7DZ4br41vZno/KpaekLVj7cH1FEX2Kbgq5O1OoF5E+Ji1UP6j8Z/eEedrOxk+ANW HAvaL1kl4R6ZNsvz/oZzsqgUo57OAce6/oSWJNK221HsR1ts4rlz Received: from [192.168.0.87] (84-10-171-192.static.chello.pl [84.10.171.192]) by mx.zohomail.com with SMTPS id 1528315051720803.5472309041045; Wed, 6 Jun 2018 12:57:31 -0700 (PDT) From: =?UTF-8?Q?Micha=C5=82?= Kondraciuk Message-ID: <65eb4dc7-9cc0-3e63-5b69-90d414107c87@zoho.com> Date: Wed, 6 Jun 2018 21:57:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The Flymake manual says that syntax checking is started whenever - ‘flymake-mode’ is started, unless ‘flymake-start-on-flymake-mode’ is nil; - a newline character is added to the buffer, unless ‘flymake-start-syntax-check-on-newline’ is nil; - some changes were made to the buffer more than ‘0.5’ seconds ago But it doesn't mention that Flymake also starts in 'after-save-hook. Also, I think there should be an option to disable checking the buffer on save. In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9) of 2018-06-06 built on mkc Repository revision: 4a51deb993d923767f0eddd4f350e636fe8d7c0b From unknown Sun Aug 17 10:25:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31738: 27.0.50; Flymake manual doesn't mention that syntax checking is started in after-save-hook Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jun 2018 21:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31738 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Micha=C5=82?= Kondraciuk Cc: 31738@debbugs.gnu.org Received: via spool by 31738-submit@debbugs.gnu.org id=B31738.15283216401052 (code B ref 31738); Wed, 06 Jun 2018 21:48:02 +0000 Received: (at 31738) by debbugs.gnu.org; 6 Jun 2018 21:47:20 +0000 Received: from localhost ([127.0.0.1]:37138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQgH2-0000Gu-5C for submit@debbugs.gnu.org; Wed, 06 Jun 2018 17:47:20 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:47044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQgH0-0000GT-An for 31738@debbugs.gnu.org; Wed, 06 Jun 2018 17:47:18 -0400 Received: by mail-io0-f171.google.com with SMTP id d22-v6so9381047iof.13 for <31738@debbugs.gnu.org>; Wed, 06 Jun 2018 14:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LCL6C1DuitNCUI5m1GJtXUK7wXIpe7NnZSfNO12eSKw=; b=UsjULRnth2A50LfoGXBEYvCfJHyZM7937e1XSHep1ZZmj65FPt5l9PXMIylVOW6BKW A/Cm9KLNmBlQMDSTkgsPMEmm1sBPd+pf3/11GQZ+asCSD1TfLX4we3v6GE8P+NHpGtxX npilVN6/RY0iYZIDgWFYS/NQCIyxShbUxwjGVSdD54IIUvSZNrQjuVHptlxZBNqlOdpk E8ivq5mqibl8yYXHKTya3w96ythiFm+nye2pzzyTszyXoiVwbrHBYuIkJobzoBinCPpE VU3Vkx2Cs23F36rrB0OS63AT2UPFDjsdLq3lLbTJ/GUxo5ShsjyFO33drdI0HRs4wpMC sxIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LCL6C1DuitNCUI5m1GJtXUK7wXIpe7NnZSfNO12eSKw=; b=KxvX5/luoVzZvM8GFUi+zRVRDFcYQBiZOSquvr2pHjWRWfv3RQ5YLE47OE3/WmCz66 WqAc0Wzu3Oe7VU+krjHB47uSR+4STy/vHpFLq6NF75ZqOKYK2wztv7djf8ycd5Qf/CkU uzDquhKwofjIVRZkgZME3iMYew9ah39cAVZ0RVvIjhFGwO0URLC8JtvsH2DLgjRx+9um hAo3f8uKKb2imXGOcugnNyv8itSKyDnEEZ61EwWg3u7mOIwJ8i0xctRybAQwSZQBPCur zkjftrpy3jo9uVaMycP9QcSZmVRmXcUu94Ugs16mnfOfDjjejSEZ+Sg/YFMyYqvFLTdQ BGrg== X-Gm-Message-State: APt69E0C1K5z3yxVv+pjAi/CtBArPBDvuVDhJLmDPe4mwy6Jb+2hY9vL znLMHatd/SUu5zgIjLCtWYwiVQCYK2+Qi2KZb+5m8Q== X-Google-Smtp-Source: ADUXVKKmStj6c+9n2ZiSci19z3xorCtqM3U9vWe37qiJ5xao9XIc4F3/xw7Trz6WQmKIqXehHrXmg3+KKI9oeLsXaKM= X-Received: by 2002:a6b:d40c:: with SMTP id l12-v6mr4728436iog.37.1528321632847; Wed, 06 Jun 2018 14:47:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:2246:0:0:0:0:0 with HTTP; Wed, 6 Jun 2018 14:46:52 -0700 (PDT) In-Reply-To: <65eb4dc7-9cc0-3e63-5b69-90d414107c87@zoho.com> References: <65eb4dc7-9cc0-3e63-5b69-90d414107c87@zoho.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Wed, 6 Jun 2018 22:46:52 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000751cb056e001c5c" X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --0000000000000751cb056e001c5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > On Wed, Jun 6, 2018 at 8:57 PM, Micha=C5=82 Kondraciuk > wrote: > > > > The Flymake manual says that syntax checking is started whenever > > > > - =E2=80=98flymake-mode=E2=80=99 is started, unless =E2=80=98flymake-st= art-on-flymake-mode=E2=80=99 > > is nil; > > - a newline character is added to the buffer, unless > > =E2=80=98flymake-start-syntax-check-on-newline=E2=80=99 is nil; > > - some changes were made to the buffer more than =E2=80=980.5=E2=80=99 = seconds ago > > > > > > But it doesn't mention that Flymake also starts in 'after-save-hook. > > Also, I think there should be an option to disable checking the buffer > > on save. > > Well, you can (add-hook 'flymake-mode-hook (lambda () (remove-hook 'after-save-hook 'flymake-after-save-hook t))) But an option makes more sense. Regarding the manual, you are also right. I will do this for 26.2. Jo=C3=A3o --0000000000000751cb056e001c5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jun 6, 2018 at 8:57 PM, Micha=C5=82 Kond= raciuk <k.michal@zoho.com> w= rote:
>
> The Flymake manual says that syntax checking is start= ed whenever
>
> - =E2=80=98flymake-mode=E2=80=99 is started, un= less =E2=80=98flymake-start-on-flymake-mode=E2=80=99
> =C2=A0 =C2=A0 = =C2=A0is nil;
> - a newline character is added to the buffer, unless<= br>> =C2=A0 =C2=A0 =C2=A0=E2=80=98flymake-start-syntax-check-on-newline= =E2=80=99 is nil;
> - some changes were made to the buffer more than = =E2=80=980.5=E2=80=99 seconds ago
>
>
> But it doesn'= t mention that Flymake also starts in 'after-save-hook.
> Also, I= think there should be an option to disable checking the buffer
> on = save.

Well, you can=C2=A0

(add-hook 'flymake-mode-hook=C2=A0
=C2=A0 (lambda () (remove= -hook 'after-save-hook 'flymake-after-save-hook t)))

=
But an option makes more sense.=C2=A0 Regarding the manual, you = are also right.
I will do this for 26.2.

Jo=C3=A3o
--0000000000000751cb056e001c5c-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 08 14:44:17 2018 Received: (at control) by debbugs.gnu.org; 8 Jun 2018 18:44:17 +0000 Received: from localhost ([127.0.0.1]:39971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRMMz-0005wH-5c for submit@debbugs.gnu.org; Fri, 08 Jun 2018 14:44:17 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:54739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRMMx-0005w3-UD for control@debbugs.gnu.org; Fri, 08 Jun 2018 14:44:16 -0400 Received: by mail-wm0-f46.google.com with SMTP id o13-v6so4916483wmf.4 for ; Fri, 08 Jun 2018 11:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject:mime-version :content-transfer-encoding; bh=iBrj7DXFUl5B+1vbbsImpAXxeeu2bfRHyuXgwyMvEtw=; b=rgS25To5RAX4yon2lZE/2JojBriYePoBOmYv5oi1lx3mlco8GsQ4Hz4oFt2S8hTkE3 22OqO7VUJvvg4u5qvv8S/9NOW3pO3mdfn9pi+Sb+XBI5CtQsHqTdWaMiaDKhdM1woolG KQDNnlzhclfs0Aj8Ch5KWqxGvA8D6eGtvfnUxO/mhAAVI9siB3Vpvm5/nAkohsw3wToo jY+cvOGPF2M0zchzU7rfT65D/Mo9SSn3IUr3al6rnqYHS3ZZIEG+oiRNr01nODIcqixh i9FON8S0GrD2rNkj9VguPkseS9aoi1m4YYaN0fPrh/W4YgbnMYBKQ46Op4auKVxjkZPt DLWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject:mime-version :content-transfer-encoding; bh=iBrj7DXFUl5B+1vbbsImpAXxeeu2bfRHyuXgwyMvEtw=; b=T3+lVIij874sfLcbzTEOm2l1XVFygZTHxH+wb/Rd0GoLn/cAqP5am8gFJ3Xm0iCEwJ AOzi/ZxrfLoAmvA0zTGZYez9AyNKiwRmZBID+0dZzUp85aJX07Trc+vTBgz0b+0Vp8Qb mzTmBm901XX7uLeD3L+0UULEL/ZxrhWW4v1wltH46mTLJxMh7sSEEHfNoHPHdGCe9lQ/ I9Y5IGWUyxd5WI2dz0aEa1Pem2V4WkFn6ZATP19bSKARefj43XmCC3TC9eCGpkiwvrbE iV7gmyhqRiJ+wJSfvfZVHTq3IjBl1gp9ehChXA2GiNTiCpiECKtWsKz8k214Mvl5pJ7I tftw== X-Gm-Message-State: APt69E2x5j2pNEwC57m/bGX8jxWDeLnzH0DcDsVKJShbxi7pu/q4rzrL mE44hfV+1axsRFmGzP4qC+abEKpqdFs= X-Google-Smtp-Source: ADUXVKJn5rwZgTNmiEmvm/qW3iCSe4A3muwh41oh5da+ol8d/crPZa9FVw+V72/xqSZNBZHvOrKd+Q== X-Received: by 2002:a1c:b18a:: with SMTP id a132-v6mr2142784wmf.18.1528483450093; Fri, 08 Jun 2018 11:44:10 -0700 (PDT) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id g4-v6sm15374902wrq.32.2018.06.08.11.44.09 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 11:44:09 -0700 (PDT) Date: Fri, 08 Jun 2018 19:44:08 +0100 Message-Id: <87o9gli0ef.fsf@gmail.com> To: control@debbugs.gnu.org From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: control message for bug #31738 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) tags 31738 fixed close 31738 27.1