GNU bug report logs - #31736
[PATCH] Add an opam importer

Previous Next

Full log

Message #22 received at 31736-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31736-done <at> debbugs.gnu.org
Subject: Re: [bug#31736] [PATCH] Add an opam importer
Date: Tue, 10 Jul 2018 13:47:58 +0200

Le Mon, 09 Jul 2018 14:44:20 +0200,
ludo <at> gnu.org (Ludovic Courtès) a écrit :

> Hello Julien,
> 
> Julien Lepiller <julien <at> lepiller.eu> skribis:
> 
> > Here is a new version. What do you think?  
> 
> I think it looks great.  :-)
> 
> > From b3fd75a804a4264cb083584591a3e589886d96c8 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien <at> lepiller.eu>
> > Date: Wed, 6 Jun 2018 19:14:39 +0200
> > Subject: [PATCH] guix: Add opam importer.
> >
> > * guix/scripts/import.scm (importers): Add opam.
> > * guix/scripts/import/opam.scm: New file.
> > * guix/import/opam.scm: New file.
> > * tests/opam.scm: New file.
> > * Makefile.am: Add them.
> > * doc/guix.texi (Invoking guix import): Document it.  
> 
> [...]
> 
> > +@item opam
> > +@cindex opam
> > +@cindex ocaml
> > +Import metadata from the @uref{https://opam.ocaml.org/, Opam}
> > package +repository used by the OCaml community.  
> 
> Nitpick: the proper spelling is “OPAM” and “OCaml”, so I think you
> need to fix these above (in the concept index as well.)
> 
> Otherwise LGTM!
> 
> As a next step, you can add an OPAM updater, which will hopefully take
> you no more than a few lines of code (see the bottom of cpam.scm, for
> example.)
> 
> :-)
> 
> Thank you!
> 
> Ludo’.

Pushed as b24443bff9f9f3f36353eea2ef35e6dc3745a417

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.