Subject: Re: [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5.

From: Kei Kebreau <[email-masked]>
Date: Thu, 14 Jun 2018 10:53:49 -0400

Hi Pierre,

> * gnu/packages/crypto.scm (encfs): Update to 1.9.5.

Don't forget to mention the new 'make-unittests' phase!

> ---
>  gnu/packages/crypto.scm | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
> index f96fe0490..4707355f3 100644
> --- a/gnu/packages/crypto.scm
> +++ b/gnu/packages/crypto.scm
> @@ -216,7 +216,7 @@ communication.")
>  (define-public encfs
>    (package
>      (name "encfs")
> -    (version "1.9.1")
> +    (version "1.9.5")
>      (source
>       (origin
>         (method url-fetch)
> @@ -225,7 +225,7 @@ communication.")
>                         version "/encfs-" version ".tar.gz"))
>         (sha256
>          (base32
> -         "1906254dg5hwljh0h4gyrw09ms3b57dlhjfzhfzffv50yzpkl837"))
> +         "0qzxavvv20577bxvly8s7d3y7bqasqclc2mllp0ddfncjm9z02a7"))
>         (modules '((guix build utils)))
>         ;; Remove bundled dependencies in favour of proper inputs.
>         (snippet '(for-each delete-file-recursively
> @@ -244,7 +244,12 @@ communication.")
>         ("openssl" ,openssl)
>         ("tinyxml2" ,tinyxml2)))
>      (arguments
> -     `(#:configure-flags (list "-DUSE_INTERNAL_TINYXML=OFF")))
> +     `(#:configure-flags (list "-DUSE_INTERNAL_TINYXML=OFF")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'make-unittests
> +           (lambda _
> +             (zero? (system* "make" "unittests")))))))

Any particular reason you decided to use '(zero? (system* ...))' rather
than '(invoke ...)' for this phase? I tried it with 'invoke' and it
worked fine.

>      (home-page "https://vgough.github.io/encfs")
>      (synopsis "Encrypted virtual file system")
>      (description

Other than the above, this patch looks good! :)