From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: haskell-mode fails to build with (at least) Emacs 26.1 Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 05 Jun 2018 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 31726@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1528217025308 (code B ref -1); Tue, 05 Jun 2018 16:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jun 2018 16:43:45 +0000 Received: from localhost ([127.0.0.1]:35435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQF3h-00004t-JB for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:43:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQEnz-00087g-5e for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:27:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQEns-0005Y5-St for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:27:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQEns-0005Xx-Ot for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:27:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQEnr-0001wd-IM for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQEnm-0005Vg-J2 for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:23 -0400 Received: from mccarthy.hcoop.net ([69.90.123.73]:51335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQEnm-0005Uq-De for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:18 -0400 Received: from marsh.hcoop.net ([165.227.79.103]) by mccarthy.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84) (envelope-from ) id 1fQEnj-0004Ay-Ln for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:15 -0400 Date: Tue, 5 Jun 2018 12:27:14 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-475699377-1264737684-1528216035=:1480" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Tue, 05 Jun 2018 12:43:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---475699377-1264737684-1528216035=:1480 Content-Type: text/plain; format=flowed; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT I'm running guix (GNU Guix) 19b662ea7c53a28270a783f10ca033d8c9d2a954, and have /gnu/store/s32nba6rxx9x2kibsn6wsm1ixzhv64nl-emacs-26.1 installed. When I then try to install haskell-mode with guix package -i haskell-mode the derivation build fails with haskell-process.el:160:1:Error: Unused lexical variable ˇmove-point-in-windows˘ This is the same error as a failed build on Hydra[0]. I have opened an upstream bug report[1], but have not yet done more troubleshooting. Best, Jack [0] https://hydra.gnu.org/build/2766429/nixlog/1 [1] https://github.com/haskell/haskell-mode/issues/1601 ---475699377-1264737684-1528216035=:1480-- From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: Acknowledgement (haskell-mode fails to build with (at least) Emacs 26.1) Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 05 Jun 2018 21:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.152823253923072 (code B ref 31726); Tue, 05 Jun 2018 21:03:01 +0000 Received: (at 31726) by debbugs.gnu.org; 5 Jun 2018 21:02:19 +0000 Received: from localhost ([127.0.0.1]:35514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQJ5u-000604-Rn for submit@debbugs.gnu.org; Tue, 05 Jun 2018 17:02:19 -0400 Received: from mccarthy.hcoop.net ([69.90.123.73]:47911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQJ5s-0005zl-SL for 31726@debbugs.gnu.org; Tue, 05 Jun 2018 17:02:17 -0400 Received: from marsh.hcoop.net ([165.227.79.103]) by mccarthy.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84) (envelope-from ) id 1fQJ5n-0003qc-Av for 31726@debbugs.gnu.org; Tue, 05 Jun 2018 17:02:11 -0400 Date: Tue, 5 Jun 2018 17:02:10 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It looks like this may be fixed in upstream commit cee22450ee30e79952f594796721dc6b17798ee6 [0], which has not ended up in a release. I have not verified yet, but it looks like commit would address the problem. [0] https://github.com/haskell/haskell-mode/commit/cee22450ee30e79952f594796721dc6b17798ee6 From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: Acknowledgement (haskell-mode fails to build with (at least) Emacs 26.1) Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 07 Jun 2018 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.15283880688206 (code B ref 31726); Thu, 07 Jun 2018 16:15:02 +0000 Received: (at 31726) by debbugs.gnu.org; 7 Jun 2018 16:14:28 +0000 Received: from localhost ([127.0.0.1]:38369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQxYR-00028I-RL for submit@debbugs.gnu.org; Thu, 07 Jun 2018 12:14:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQxYQ-000286-FZ for 31726@debbugs.gnu.org; Thu, 07 Jun 2018 12:14:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQxYH-0000vR-Dl for 31726@debbugs.gnu.org; Thu, 07 Jun 2018 12:14:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQxYH-0000vM-B5; Thu, 07 Jun 2018 12:14:17 -0400 Received: from [193.50.110.75] (port=41190 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fQxYG-00063v-DC; Thu, 07 Jun 2018 12:14:16 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 Prairial an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 07 Jun 2018 18:14:14 +0200 In-Reply-To: (Jack Hill's message of "Tue, 5 Jun 2018 17:02:10 -0400 (EDT)") Message-ID: <87602ubmll.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Jack Hill skribis: > It looks like this may be fixed in upstream commit > cee22450ee30e79952f594796721dc6b17798ee6 [0], which has not ended up > in a release. I have not verified yet, but it looks like commit would > address the problem. > > > [0] https://github.com/haskell/haskell-mode/commit/cee22450ee30e79952f594= 796721dc6b17798ee6 Could you propose a patch to apply this commit to our haskell-mode package? Thanks for digging into this! Ludo=E2=80=99. From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: confirming proposed change References: In-Reply-To: Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 07 Jun 2018 21:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.152840783728451 (code B ref 31726); Thu, 07 Jun 2018 21:44:01 +0000 Received: (at 31726) by debbugs.gnu.org; 7 Jun 2018 21:43:57 +0000 Received: from localhost ([127.0.0.1]:38479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2hI-0007Oo-Mz for submit@debbugs.gnu.org; Thu, 07 Jun 2018 17:43:56 -0400 Received: from mccarthy.hcoop.net ([69.90.123.73]:54982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR2hG-0007Ob-Qn for 31726@debbugs.gnu.org; Thu, 07 Jun 2018 17:43:55 -0400 Received: from marsh.hcoop.net ([165.227.79.103]) by mccarthy.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84) (envelope-from ) id 1fR2hB-0001HC-3R for 31726@debbugs.gnu.org; Thu, 07 Jun 2018 17:43:49 -0400 Date: Thu, 7 Jun 2018 17:43:48 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-475699377-333212385-1528407435=:1480" Content-ID: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---475699377-333212385-1528407435=:1480 Content-Type: text/plain; FORMAT=flowed; CHARSET=ISO-8859-7 Content-Transfer-Encoding: 8BIT Content-ID: Ludo˘, Sure, I'll give make a path a go. You're thinking that I should try applying the changes that the commit introduced as part of our package definition? Best, Jack ---475699377-333212385-1528407435=:1480-- From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: confirming proposed change Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 08 Jun 2018 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.152846826624633 (code B ref 31726); Fri, 08 Jun 2018 14:32:02 +0000 Received: (at 31726) by debbugs.gnu.org; 8 Jun 2018 14:31:06 +0000 Received: from localhost ([127.0.0.1]:39721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIPy-0006PF-HU for submit@debbugs.gnu.org; Fri, 08 Jun 2018 10:31:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIPx-0006On-VY for 31726@debbugs.gnu.org; Fri, 08 Jun 2018 10:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRIPo-0004lS-NJ for 31726@debbugs.gnu.org; Fri, 08 Jun 2018 10:31:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRIPo-0004lM-JB; Fri, 08 Jun 2018 10:30:56 -0400 Received: from [193.50.110.75] (port=52346 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRIPo-0000KX-0A; Fri, 08 Jun 2018 10:30:56 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: Date: Fri, 08 Jun 2018 16:30:53 +0200 In-Reply-To: (Jack Hill's message of "Thu, 7 Jun 2018 17:43:48 -0400 (EDT)") Message-ID: <87po11l59e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi, Jack Hill skribis: > Sure, I'll give make a path a go. You're thinking that I should try > applying the changes that the commit introduced as part of our package > definition? Yes, either that or use a snapshot of upstream haskell-mode. Thanks, Ludo=E2=80=99. From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: confirming proposed change Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 08 Jun 2018 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.15284872243883 (code B ref 31726); Fri, 08 Jun 2018 19:48:02 +0000 Received: (at 31726) by debbugs.gnu.org; 8 Jun 2018 19:47:04 +0000 Received: from localhost ([127.0.0.1]:40060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRNLe-00010D-NK for submit@debbugs.gnu.org; Fri, 08 Jun 2018 15:47:03 -0400 Received: from mccarthy.hcoop.net ([69.90.123.73]:57896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRNLZ-0000zy-F4 for 31726@debbugs.gnu.org; Fri, 08 Jun 2018 15:46:57 -0400 Received: from marsh.hcoop.net ([165.227.79.103]) by mccarthy.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84) (envelope-from ) id 1fRNLT-0000ll-PX; Fri, 08 Jun 2018 15:46:47 -0400 Date: Fri, 8 Jun 2018 15:46:46 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87po11l59e.fsf@gnu.org> Message-ID: References: <87po11l59e.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-475699377-1606939286-1528487207=:1480" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---475699377-1606939286-1528487207=:1480 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Fri, 8 Jun 2018, Ludovic Courtès wrote: > Hi, > > Jack Hill skribis: > >> Sure, I'll give make a path a go. You're thinking that I should try >> applying the changes that the commit introduced as part of our package >> definition? > > Yes, either that or use a snapshot of upstream haskell-mode. I have started workign on a patch implementing the former. I've included what I have so far below, but it's not ready to be included in the distribution because not all of the tests pass. Maybe this is because the one patch shouldn't be applied in issolation and it would be bettter to take the snapshot approach? Otherwise, is what I did with the package revision reasonable? Thanks, Jack >From 62ae1a14c48f3d70e6f47ffd6de60a0b9af9d43f Mon Sep 17 00:00:00 2001 From: Jack Hill Date: Thu, 7 Jun 2018 22:54:12 -0400 Subject: [PATCH] Patch haskell-mode to remove unused lexical variables --- gnu/packages/emacs.scm | 174 +++++++++++---------- ...ell-mode-removed-unused-lexical-variables.patch | 42 +++++ 2 files changed, 131 insertions(+), 85 deletions(-) create mode 100644 gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index e90660a23..5e93cd2b8 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -631,92 +631,96 @@ only a handful of functions that are not resource-specific.") (license license:gpl3+))) (define-public haskell-mode - (package - (name "haskell-mode") - (version "16.1") - (source (origin - (method url-fetch) - (file-name (string-append name "-" version ".tar.gz")) - (uri (string-append - "https://github.com/haskell/haskell-mode/archive/v" - version ".tar.gz")) - (sha256 - (base32 "0g6lcjw7lcgavv3yrd8xjcyqgfyjl787y32r1z14amw2f009m78h")))) - (inputs - `(("emacs-el-search" ,emacs-el-search) ; for tests - ("emacs-stream" ,emacs-stream))) ; for tests - (propagated-inputs - `(("emacs-dash" ,emacs-dash))) - (native-inputs - `(("emacs" ,emacs-minimal) - ("texinfo" ,texinfo))) - (build-system gnu-build-system) - (arguments - `(#:make-flags (list (string-append "EMACS=" - (assoc-ref %build-inputs "emacs") - "/bin/emacs")) - #:modules ((ice-9 match) - (srfi srfi-26) - ,@%gnu-build-system-modules) - #:phases - (modify-phases %standard-phases - (delete 'configure) - (add-before - 'build 'pre-build - (lambda* (#:key inputs #:allow-other-keys) - (define (el-dir store-dir) - (match (find-files store-dir "\\.el$") - ((f1 f2 ...) (dirname f1)) - (_ ""))) - - (let ((sh (string-append (assoc-ref inputs "bash") "/bin/sh"))) - (define emacs-prefix? (cut string-prefix? "emacs-" <>)) - - (setenv "SHELL" "sh") - (setenv "EMACSLOADPATH" - (string-concatenate - (map (match-lambda - (((? emacs-prefix? name) . dir) - (string-append (el-dir dir) ":")) - (_ "")) - inputs))) - (substitute* (find-files "." "\\.el") (("/bin/sh") sh)) - (substitute* "tests/haskell-code-conventions.el" - ;; Function name recently changed in "emacs-el-search". - (("el-search--search-pattern") "el-search-forward") - ;; Don't contact home. - (("\\(when \\(>= emacs-major-version 25\\)") - "(require 'el-search) (when nil")) - #t))) - (replace - 'install - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (el-dir (string-append out "/share/emacs/site-lisp")) - (doc (string-append - out "/share/doc/haskell-mode-" ,version)) - (info (string-append out "/share/info"))) - (define (copy-to-dir dir files) - (for-each (lambda (f) - (install-file f dir)) - files)) - - (with-directory-excursion "doc" - (unless (zero? (system* "makeinfo" "haskell-mode.texi")) - (error "makeinfo failed")) - (install-file "haskell-mode.info" info)) - (copy-to-dir doc '("CONTRIBUTING.md" "NEWS" "README.md")) - (copy-to-dir el-dir (find-files "." "\\.elc?")) - ;; These are part of other packages. - (with-directory-excursion el-dir - (for-each delete-file '("dash.el" "ert.el"))) - #t)))))) - (home-page "https://github.com/haskell/haskell-mode") - (synopsis "Haskell mode for Emacs") - (description - "This is an Emacs mode for editing, debugging and developing Haskell + (let ((release "16.1") + (revision "1")) + (package + (name "haskell-mode") + (version (string-append release "-" revision)) + (source (origin + (method url-fetch) + (file-name (string-append name "-" release ".tar.gz")) + (uri (string-append + "https://github.com/haskell/haskell-mode/archive/v" + release ".tar.gz")) + (sha256 + (base32 "0g6lcjw7lcgavv3yrd8xjcyqgfyjl787y32r1z14amw2f009m78h")) + (patches + (search-patches "haskell-mode-removed-unused-lexical-variables.patch")))) + (inputs + `(("emacs-el-search" ,emacs-el-search) ; for tests + ("emacs-stream" ,emacs-stream))) ; for tests + (propagated-inputs + `(("emacs-dash" ,emacs-dash))) + (native-inputs + `(("emacs" ,emacs-minimal) + ("texinfo" ,texinfo))) + (build-system gnu-build-system) + (arguments + `(#:make-flags (list (string-append "EMACS=" + (assoc-ref %build-inputs "emacs") + "/bin/emacs")) + #:modules ((ice-9 match) + (srfi srfi-26) + ,@%gnu-build-system-modules) + #:phases + (modify-phases %standard-phases + (delete 'configure) + (add-before + 'build 'pre-build + (lambda* (#:key inputs #:allow-other-keys) + (define (el-dir store-dir) + (match (find-files store-dir "\\.el$") + ((f1 f2 ...) (dirname f1)) + (_ ""))) + + (let ((sh (string-append (assoc-ref inputs "bash") "/bin/sh"))) + (define emacs-prefix? (cut string-prefix? "emacs-" <>)) + + (setenv "SHELL" "sh") + (setenv "EMACSLOADPATH" + (string-concatenate + (map (match-lambda + (((? emacs-prefix? name) . dir) + (string-append (el-dir dir) ":")) + (_ "")) + inputs))) + (substitute* (find-files "." "\\.el") (("/bin/sh") sh)) + (substitute* "tests/haskell-code-conventions.el" + ;; Function name recently changed in "emacs-el-search". + (("el-search--search-pattern") "el-search-forward") + ;; Don't contact home. + (("\\(when \\(>= emacs-major-version 25\\)") + "(require 'el-search) (when nil")) + #t))) + (replace + 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (el-dir (string-append out "/share/emacs/site-lisp")) + (doc (string-append + out "/share/doc/haskell-mode-" ,version)) + (info (string-append out "/share/info"))) + (define (copy-to-dir dir files) + (for-each (lambda (f) + (install-file f dir)) + files)) + + (with-directory-excursion "doc" + (unless (zero? (system* "makeinfo" "haskell-mode.texi")) + (error "makeinfo failed")) + (install-file "haskell-mode.info" info)) + (copy-to-dir doc '("CONTRIBUTING.md" "NEWS" "README.md")) + (copy-to-dir el-dir (find-files "." "\\.elc?")) + ;; These are part of other packages. + (with-directory-excursion el-dir + (for-each delete-file '("dash.el" "ert.el"))) + #t)))))) + (home-page "https://github.com/haskell/haskell-mode") + (synopsis "Haskell mode for Emacs") + (description + "This is an Emacs mode for editing, debugging and developing Haskell programs.") - (license license:gpl3+))) + (license license:gpl3+)))) (define-public flycheck (package diff --git a/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch b/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch new file mode 100644 index 000000000..a618df5fb --- /dev/null +++ b/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch @@ -0,0 +1,42 @@ +From cee22450ee30e79952f594796721dc6b17798ee6 Mon Sep 17 00:00:00 2001 +From: Sascha Wilde +Date: Fri, 23 Sep 2016 15:35:59 +0200 +Subject: [PATCH] Removed unused lexical variables. + +--- + haskell-lexeme.el | 3 +-- + haskell-process.el | 4 +--- + 2 files changed, 2 insertions(+), 5 deletions(-) + +diff --git a/haskell-lexeme.el b/haskell-lexeme.el +index 4256a79..b832560 100644 +--- a/haskell-lexeme.el ++++ b/haskell-lexeme.el +@@ -138,8 +138,7 @@ When match is successful, match-data will contain: + (match-text 2) - whole qualified identifier + (match-text 3) - unqualified part of identifier + (match-text 4) - closing backtick" +- (let ((begin (point)) +- (match-data-old (match-data)) ++ (let ((match-data-old (match-data)) + first-backtick-start + last-backtick-start + qid-start +diff --git a/haskell-process.el b/haskell-process.el +index b4efba2..4f3f859 100644 +--- a/haskell-process.el ++++ b/haskell-process.el +@@ -160,9 +160,7 @@ HPTYPE is the result of calling `'haskell-process-type`' function." + (defun haskell-process-log (msg) + "Effective append MSG to the process log (if enabled)." + (when haskell-process-log +- (let* ((append-to (get-buffer-create "*haskell-process-log*")) +- (windows (get-buffer-window-list append-to t t)) +- move-point-in-windows) ++ (let* ((append-to (get-buffer-create "*haskell-process-log*"))) + (with-current-buffer append-to + ;; point should follow insertion so that it stays at the end + ;; of the buffer +-- +2.11.0 + -- 2.11.0 ---475699377-1606939286-1528487207=:1480-- From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: confirming proposed change Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 09 Jun 2018 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.15285764637036 (code B ref 31726); Sat, 09 Jun 2018 20:35:01 +0000 Received: (at 31726) by debbugs.gnu.org; 9 Jun 2018 20:34:23 +0000 Received: from localhost ([127.0.0.1]:41546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRkZ5-0001pQ-9O for submit@debbugs.gnu.org; Sat, 09 Jun 2018 16:34:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRkZ0-0001pA-FU for 31726@debbugs.gnu.org; Sat, 09 Jun 2018 16:34:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRkYq-0003dL-G0 for 31726@debbugs.gnu.org; Sat, 09 Jun 2018 16:34:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRkYq-0003dE-BL; Sat, 09 Jun 2018 16:34:08 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50894 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRkYp-0003Mn-IB; Sat, 09 Jun 2018 16:34:08 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87po11l59e.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 Prairial an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 09 Jun 2018 22:34:05 +0200 In-Reply-To: (Jack Hill's message of "Fri, 8 Jun 2018 15:46:46 -0400 (EDT)") Message-ID: <87fu1vhf7m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi, Jack Hill skribis: >> Jack Hill skribis: >> >>> Sure, I'll give make a path a go. You're thinking that I should try >>> applying the changes that the commit introduced as part of our package >>> definition? >> >> Yes, either that or use a snapshot of upstream haskell-mode. > > I have started workign on a patch implementing the former. I've > included what I have so far below, but it's not ready to be included > in the distribution because not all of the tests pass. Maybe this is > because the one patch shouldn't be applied in issolation and it would > be bettter to take the snapshot approach? > > Otherwise, is what I did with the package revision reasonable? Yes, definitely. > From 62ae1a14c48f3d70e6f47ffd6de60a0b9af9d43f Mon Sep 17 00:00:00 2001 > From: Jack Hill > Date: Thu, 7 Jun 2018 22:54:12 -0400 > Subject: [PATCH] Patch haskell-mode to remove unused lexical variables > > --- > gnu/packages/emacs.scm | 174 +++++++++++----= ------ > ...ell-mode-removed-unused-lexical-variables.patch | 42 +++++ > 2 files changed, 131 insertions(+), 85 deletions(-) > create mode 100644 gnu/packages/patches/haskell-mode-removed-unused-lexi= cal-variables.patch You=E2=80=99ll need to add the patch to gnu/local.mk. > --- /dev/null > +++ b/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.= patch Please add a line or two with the URL of the upstream bug report or patch, and maybe a few words on what the patch is about. Thank you! Ludo=E2=80=99. From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: Attempt to use git reference for haskell-mode References: In-Reply-To: Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 20 Jul 2018 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.153211675323035 (code B ref 31726); Fri, 20 Jul 2018 20:00:02 +0000 Received: (at 31726) by debbugs.gnu.org; 20 Jul 2018 19:59:13 +0000 Received: from localhost ([127.0.0.1]:49979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgbYS-0005zL-5a for submit@debbugs.gnu.org; Fri, 20 Jul 2018 15:59:13 -0400 Received: from mccarthy.hcoop.net ([69.90.123.73]:54709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgbYM-0005yl-67 for 31726@debbugs.gnu.org; Fri, 20 Jul 2018 15:59:06 -0400 Received: from marsh.hcoop.net ([165.227.79.103]) by mccarthy.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84) (envelope-from ) id 1fgbYG-0002CA-HY; Fri, 20 Jul 2018 15:58:56 -0400 Date: Fri, 20 Jul 2018 15:58:55 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-475699377-174529274-1532116736=:11087" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---475699377-174529274-1532116736=:11087 Content-Type: text/plain; format=flowed; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT Ludo˘, I've returned to working on the haskell-mode fixes for Emacs 26.1. However, I'm afraid that I'll need a bit more guidance about the best path forward to prepare a patch that is suitable for inclusion in Guix. When I left off, in addition to your comments, I was concerned with test failures, so I tried to instead to define the package using a git reference (patch below (I have not yet worked on the commit message). Unfortunately, more of the tests fail than before. I was able to get more of the tests to pass by adding ghc as an input. With test disabled, I am able to install the package and load it in Emacs. A breakdown of the number of failing test is as follows: 16.1 version with patch -- 4 git version without ghc -- 11 git version with ghc -- 7 I'm not sure which version to prefer, or how to proceed making that decision. Version 16.1 was released in September 2016. By moving to the git version, we would no longer need to run a substitution in haskell-code-conventions.el as that file has been removed upstream. What additional information would be useful? Would it be acceptable to disable the tests? Thanks, Jack >From 79c41a7a3ad29441c164042b27ce5e2e3dcaf807 Mon Sep 17 00:00:00 2001 From: Jack Hill Date: Thu, 7 Jun 2018 22:54:12 -0400 Subject: [PATCH] Switch haskell-mode to use git-reference. This change is needed for compatibility with new Emacs (the last released version was in 2016). Add ghc as an input as it is used in some of the tests. --- gnu/packages/emacs.scm | 168 ++++++++++----------- ...ell-mode-removed-unused-lexical-variables.patch | 42 ++++++ 2 files changed, 126 insertions(+), 84 deletions(-) create mode 100644 gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index fa790dba8..677c43fde 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -113,6 +113,7 @@ #:use-module (gnu packages xdisorg) #:use-module (gnu packages shells) #:use-module (gnu packages gnupg) + #:use-module (gnu packages haskell) #:use-module (guix utils) #:use-module (srfi srfi-1) #:use-module (ice-9 match)) @@ -636,91 +637,90 @@ only a handful of functions that are not resource-specific.") (license license:gpl3+))) (define-public haskell-mode - (package - (name "haskell-mode") - (version "16.1") - (source (origin - (method url-fetch) - (file-name (string-append name "-" version ".tar.gz")) - (uri (string-append - "https://github.com/haskell/haskell-mode/archive/v" - version ".tar.gz")) - (sha256 - (base32 "0g6lcjw7lcgavv3yrd8xjcyqgfyjl787y32r1z14amw2f009m78h")))) - (inputs - `(("emacs-el-search" ,emacs-el-search) ; for tests - ("emacs-stream" ,emacs-stream))) ; for tests - (propagated-inputs - `(("emacs-dash" ,emacs-dash))) - (native-inputs - `(("emacs" ,emacs-minimal) - ("texinfo" ,texinfo))) - (build-system gnu-build-system) - (arguments - `(#:make-flags (list (string-append "EMACS=" - (assoc-ref %build-inputs "emacs") - "/bin/emacs")) - #:modules ((ice-9 match) - (srfi srfi-26) - ,@%gnu-build-system-modules) - #:phases - (modify-phases %standard-phases - (delete 'configure) - (add-before - 'build 'pre-build - (lambda* (#:key inputs #:allow-other-keys) - (define (el-dir store-dir) - (match (find-files store-dir "\\.el$") - ((f1 f2 ...) (dirname f1)) - (_ ""))) - - (let ((sh (string-append (assoc-ref inputs "bash") "/bin/sh"))) - (define emacs-prefix? (cut string-prefix? "emacs-" <>)) - - (setenv "SHELL" "sh") - (setenv "EMACSLOADPATH" - (string-concatenate - (map (match-lambda - (((? emacs-prefix? name) . dir) - (string-append (el-dir dir) ":")) - (_ "")) - inputs))) - (substitute* (find-files "." "\\.el") (("/bin/sh") sh)) - (substitute* "tests/haskell-code-conventions.el" - ;; Function name recently changed in "emacs-el-search". - (("el-search--search-pattern") "el-search-forward") - ;; Don't contact home. - (("\\(when \\(>= emacs-major-version 25\\)") - "(require 'el-search) (when nil")) - #t))) - (replace - 'install - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (el-dir (string-append out "/share/emacs/site-lisp")) - (doc (string-append - out "/share/doc/haskell-mode-" ,version)) - (info (string-append out "/share/info"))) - (define (copy-to-dir dir files) - (for-each (lambda (f) - (install-file f dir)) - files)) - - (with-directory-excursion "doc" - (invoke "makeinfo" "haskell-mode.texi") - (install-file "haskell-mode.info" info)) - (copy-to-dir doc '("CONTRIBUTING.md" "NEWS" "README.md")) - (copy-to-dir el-dir (find-files "." "\\.elc?")) - ;; These are part of other packages. - (with-directory-excursion el-dir - (for-each delete-file '("dash.el" "ert.el"))) - #t)))))) - (home-page "https://github.com/haskell/haskell-mode") - (synopsis "Haskell mode for Emacs") - (description - "This is an Emacs mode for editing, debugging and developing Haskell + (let ((release "16.1") + (revision "1") + (commit "dd0ea640fa449d021399a17db65e4d50d3f0f2a9")) + (package + (name "haskell-mode") + (version (string-append release "-" revision "-" + (string-take commit 7))) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/haskell/haskell-mode.git") + (commit commit))) + (sha256 + (base32 "0cc8mhjn4qhn3zs3x7azkjnvalg156b6h0n13b8wzlvyp9ka28yj")))) + (inputs + `(("emacs-el-search" ,emacs-el-search) ; for tests + ("emacs-stream" ,emacs-stream) ; for tests + ("ghc" ,ghc))) ; for tests + (propagated-inputs + `(("emacs-dash" ,emacs-dash))) + (native-inputs + `(("emacs" ,emacs-minimal) + ("texinfo" ,texinfo))) + (build-system gnu-build-system) + (arguments + `(#:make-flags (list (string-append "EMACS=" + (assoc-ref %build-inputs "emacs") + "/bin/emacs")) + #:modules ((ice-9 match) + (srfi srfi-26) + ,@%gnu-build-system-modules) + #:phases + (modify-phases %standard-phases + (delete 'configure) + (add-before + 'build 'pre-build + (lambda* (#:key inputs #:allow-other-keys) + (define (el-dir store-dir) + (match (find-files store-dir "\\.el$") + ((f1 f2 ...) (dirname f1)) + (_ ""))) + + (let ((sh (string-append (assoc-ref inputs "bash") "/bin/sh"))) + (define emacs-prefix? (cut string-prefix? "emacs-" <>)) + + (setenv "SHELL" "sh") + (setenv "EMACSLOADPATH" + (string-concatenate + (map (match-lambda + (((? emacs-prefix? name) . dir) + (string-append (el-dir dir) ":")) + (_ "")) + inputs))) + (substitute* (find-files "." "\\.el") (("/bin/sh") sh)) + #t))) + (replace + 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (el-dir (string-append out "/share/emacs/site-lisp")) + (doc (string-append + out "/share/doc/haskell-mode-" ,version)) + (info (string-append out "/share/info"))) + (define (copy-to-dir dir files) + (for-each (lambda (f) + (install-file f dir)) + files)) + + (with-directory-excursion "doc" + (unless (zero? (system* "makeinfo" "haskell-mode.texi")) + (error "makeinfo failed")) + (install-file "haskell-mode.info" info)) + (copy-to-dir doc '("CONTRIBUTING.md" "NEWS" "README.md")) + (copy-to-dir el-dir (find-files "." "\\.elc?")) + ;; These are part of other packages. + (with-directory-excursion el-dir + (for-each delete-file '("dash.el" "ert.el"))) + #t)))))) + (home-page "https://github.com/haskell/haskell-mode") + (synopsis "Haskell mode for Emacs") + (description + "This is an Emacs mode for editing, debugging and developing Haskell programs.") - (license license:gpl3+))) + (license license:gpl3+)))) (define-public flycheck (package diff --git a/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch b/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch new file mode 100644 index 000000000..a618df5fb --- /dev/null +++ b/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch @@ -0,0 +1,42 @@ +From cee22450ee30e79952f594796721dc6b17798ee6 Mon Sep 17 00:00:00 2001 +From: Sascha Wilde +Date: Fri, 23 Sep 2016 15:35:59 +0200 +Subject: [PATCH] Removed unused lexical variables. + +--- + haskell-lexeme.el | 3 +-- + haskell-process.el | 4 +--- + 2 files changed, 2 insertions(+), 5 deletions(-) + +diff --git a/haskell-lexeme.el b/haskell-lexeme.el +index 4256a79..b832560 100644 +--- a/haskell-lexeme.el ++++ b/haskell-lexeme.el +@@ -138,8 +138,7 @@ When match is successful, match-data will contain: + (match-text 2) - whole qualified identifier + (match-text 3) - unqualified part of identifier + (match-text 4) - closing backtick" +- (let ((begin (point)) +- (match-data-old (match-data)) ++ (let ((match-data-old (match-data)) + first-backtick-start + last-backtick-start + qid-start +diff --git a/haskell-process.el b/haskell-process.el +index b4efba2..4f3f859 100644 +--- a/haskell-process.el ++++ b/haskell-process.el +@@ -160,9 +160,7 @@ HPTYPE is the result of calling `'haskell-process-type`' function." + (defun haskell-process-log (msg) + "Effective append MSG to the process log (if enabled)." + (when haskell-process-log +- (let* ((append-to (get-buffer-create "*haskell-process-log*")) +- (windows (get-buffer-window-list append-to t t)) +- move-point-in-windows) ++ (let* ((append-to (get-buffer-create "*haskell-process-log*"))) + (with-current-buffer append-to + ;; point should follow insertion so that it stays at the end + ;; of the buffer +-- +2.11.0 + -- 2.11.0 ---475699377-174529274-1532116736=:11087-- From unknown Sat Aug 16 19:16:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31726: Attempt to use git reference for haskell-mode Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 23 Jul 2018 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31726 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: 31726@debbugs.gnu.org Received: via spool by 31726-submit@debbugs.gnu.org id=B31726.15323340472866 (code B ref 31726); Mon, 23 Jul 2018 08:21:02 +0000 Received: (at 31726) by debbugs.gnu.org; 23 Jul 2018 08:20:47 +0000 Received: from localhost ([127.0.0.1]:53043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhW5H-0000kA-Hw for submit@debbugs.gnu.org; Mon, 23 Jul 2018 04:20:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhW5D-0000jq-52 for 31726@debbugs.gnu.org; Mon, 23 Jul 2018 04:20:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhW52-0008B5-TT for 31726@debbugs.gnu.org; Mon, 23 Jul 2018 04:20:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhW52-0008B1-PP; Mon, 23 Jul 2018 04:20:32 -0400 Received: from [193.50.110.227] (port=34486 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhW52-0007fP-C5; Mon, 23 Jul 2018 04:20:32 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Thermidor an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 23 Jul 2018 10:20:30 +0200 In-Reply-To: (Jack Hill's message of "Fri, 20 Jul 2018 15:58:55 -0400 (EDT)") Message-ID: <87y3e2uzw1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello Jack, Jack Hill skribis: > I've returned to working on the haskell-mode fixes for Emacs > 26.1. However, I'm afraid that I'll need a bit more guidance about the > best path forward to prepare a patch that is suitable for inclusion in > Guix. > > When I left off, in addition to your comments, I was concerned with > test failures, so I tried to instead to define the package using a git > reference (patch below (I have not yet worked on the commit > message). Unfortunately, more of the tests fail than before. I was > able to get more of the tests to pass by adding ghc as an input. With > test disabled, I am able to install the package and load it in Emacs. > > A breakdown of the number of failing test is as follows: > 16.1 version with patch -- 4 > git version without ghc -- 11 > git version with ghc -- 7 > > I'm not sure which version to prefer, or how to proceed making that > decision. Version 16.1 was released in September 2016. By moving to > the git version, we would no longer need to run a substitution in > haskell-code-conventions.el as that file has been removed upstream. >From what you=E2=80=99re saying and from the previous discussion, it seems = clear to me that we=E2=80=99d rather use a recent Git snapshot. > Would it be acceptable to disable the tests? If there are 7 failing tests, perhaps that indicates a real issue. Could you take a look at the test log to see if this is something benign? Sometimes it=E2=80=99s just hard-coded /usr/bin file names or simi= lar that cause tests to fail, and that is easy to fix. Now, if haskell-mode has been failing to build for 2+ months, an update without tests is still preferable over the status quo. So if you don=E2=80= =99t see an immediate solution to the test failures, I suppose we could go ahead and apply the patch. Thank you, Ludo=E2=80=99. From unknown Sat Aug 16 19:16:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jack Hill Subject: bug#31726: closed (Re: [bug#32608] [PATCH] gnu: haskell-mode: Fix test failure.) Message-ID: References: <87r2ic6iou.fsf@gnu.org> X-Gnu-PR-Message: they-closed 31726 X-Gnu-PR-Package: guix Reply-To: 31726@debbugs.gnu.org Date: Sun, 02 Sep 2018 15:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1535900942-11203-1" This is a multi-part message in MIME format... ------------=_1535900942-11203-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31726: haskell-mode fails to build with (at least) Emacs 26.1 which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31726@debbugs.gnu.org. --=20 31726: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31726 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1535900942-11203-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31726-done) by debbugs.gnu.org; 2 Sep 2018 15:08:27 +0000 Received: from localhost ([127.0.0.1]:43170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwTzG-0002tV-Vg for submit@debbugs.gnu.org; Sun, 02 Sep 2018 11:08:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwTzF-0002tD-Bp for 31726-done@debbugs.gnu.org; Sun, 02 Sep 2018 11:08:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwTz9-0006Cj-17 for 31726-done@debbugs.gnu.org; Sun, 02 Sep 2018 11:08:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwTz8-0006CP-SB; Sun, 02 Sep 2018 11:08:18 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40776 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fwTz8-0005ne-Kx; Sun, 02 Sep 2018 11:08:18 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Vong Subject: Re: [bug#32608] [PATCH] gnu: haskell-mode: Fix test failure. References: <87ftys3ff6.fsf@gmail.com> Date: Sun, 02 Sep 2018 17:08:17 +0200 In-Reply-To: <87ftys3ff6.fsf@gmail.com> (Alex Vong's message of "Sun, 02 Sep 2018 08:34:53 +0800") Message-ID: <87r2ic6iou.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31726-done Cc: 32608-done@debbugs.gnu.org, 31726-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Alex, Alex Vong skribis: > I manage to fix all test failures of haskell-mode (which FTBFS for a > long time). I use Jack's bug report > as a starting > point and continue from there. The fix consists of backporting 2 commits > from upstream and hard-coding the filename in the tests. (This is okay > since the tests will not be installed.)=20 Awesome. > Let's write some Haskell for good (`=EF=BD=A5=CF=89=EF=BD=A5=C2=B4) :-) > From 99fefcd43adbe8effe24480e64f9fa0b461b8fe5 Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Sun, 2 Sep 2018 07:47:05 +0800 > Subject: [PATCH] gnu: haskell-mode: Fix test failure. > > Thanks to Jack Hill for exploring differnt solutio= ns > at . > > * gnu/packages/patches/haskell-mode-Removed-unused-lexical-variables.patc= h, > gnu/packages/patches/haskell-mode-removed-check-conventions-from-make.pat= ch: > New files. > * gnu/local.mk (dist_patch_DATA): Add them. > * gnu/packages/emacs.scm (haskell-mode)[source]: Use them. > [arguments]: Adjust 'pre-build' phase to embed filename. I=E2=80=99ve shorted the patch file names as suggested by =E2=80=98guix lin= t=E2=80=99, added a =E2=80=9CFixes=E2=80=9D line in the commit log, and applied. Thanks to both of you! Ludo=E2=80=99. ------------=_1535900942-11203-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Jun 2018 16:43:45 +0000 Received: from localhost ([127.0.0.1]:35435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQF3h-00004t-JB for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:43:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQEnz-00087g-5e for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:27:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQEns-0005Y5-St for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:27:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQEns-0005Xx-Ot for submit@debbugs.gnu.org; Tue, 05 Jun 2018 12:27:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQEnr-0001wd-IM for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQEnm-0005Vg-J2 for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:23 -0400 Received: from mccarthy.hcoop.net ([69.90.123.73]:51335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQEnm-0005Uq-De for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:18 -0400 Received: from marsh.hcoop.net ([165.227.79.103]) by mccarthy.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84) (envelope-from ) id 1fQEnj-0004Ay-Ln for bug-guix@gnu.org; Tue, 05 Jun 2018 12:27:15 -0400 Date: Tue, 5 Jun 2018 12:27:14 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: bug-guix@gnu.org Subject: haskell-mode fails to build with (at least) Emacs 26.1 Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-475699377-1264737684-1528216035=:1480" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 05 Jun 2018 12:43:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---475699377-1264737684-1528216035=:1480 Content-Type: text/plain; format=flowed; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT I'm running guix (GNU Guix) 19b662ea7c53a28270a783f10ca033d8c9d2a954, and have /gnu/store/s32nba6rxx9x2kibsn6wsm1ixzhv64nl-emacs-26.1 installed. When I then try to install haskell-mode with guix package -i haskell-mode the derivation build fails with haskell-process.el:160:1:Error: Unused lexical variable ˇmove-point-in-windows˘ This is the same error as a failed build on Hydra[0]. I have opened an upstream bug report[1], but have not yet done more troubleshooting. Best, Jack [0] https://hydra.gnu.org/build/2766429/nixlog/1 [1] https://github.com/haskell/haskell-mode/issues/1601 ---475699377-1264737684-1528216035=:1480-- ------------=_1535900942-11203-1--