GNU bug report logs - #31710
26.1; sh-mode doesn't highlight aliases with dots correctly

Previous Next

Package: emacs;

Reported by: Aria Edm <aria <at> ar1as.space>

Date: Mon, 4 Jun 2018 12:15:02 UTC

Severity: minor

Tags: fixed

Found in version 26.1

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 31710 <at> debbugs.gnu.org, Aria Edm <aria <at> ar1as.space>
Subject: bug#31710: 26.1; sh-mode doesn't highlight aliases with dots correctly
Date: Sat, 13 Jul 2019 17:34:35 +0200
On Jul 13 2019, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Surely foo[....]="bar" isn't valid bash syntax?

Of course it is.

> I've installed the following patch on the Emacs trunk:
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
> index ae90531a7f..64608f1930 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -582,7 +582,7 @@ sh-assignment-regexp
>      ;; actually spaces are only supported in let/(( ... ))
>      (ksh88 . ,(concat "\\<\\([[:alnum:]_]+\\)\\(\\[.+\\]\\)?"
>                        "[ \t]*\\(?:[-+*/%&|~^]\\|<<\\|>>\\)?="))
> -    (bash . "\\<\\([[:alnum:]_]+\\)\\(\\[.+\\]\\)?\\+?=")
> +    (bash . "\\<\\([[:alnum:]_]+\\)\\([.+]\\)?\\+?=")

That doesn't make sense.  A dot or a plus isn't a valid character in a
shell variable.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."




This bug report was last modified 5 years and 315 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.