From unknown Wed Jun 18 00:24:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31707 <31707@debbugs.gnu.org> To: bug#31707 <31707@debbugs.gnu.org> Subject: Status: [PATCH 1/1] ido: add ido-fallback special variable Reply-To: bug#31707 <31707@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:24:35 +0000 retitle 31707 [PATCH 1/1] ido: add ido-fallback special variable reassign 31707 emacs submitter 31707 Christophe Junke severity 31707 normal tag 31707 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 04 05:00:50 2018 Received: (at submit) by debbugs.gnu.org; 4 Jun 2018 09:00:50 +0000 Received: from localhost ([127.0.0.1]:60849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPlMA-00085L-0L for submit@debbugs.gnu.org; Mon, 04 Jun 2018 05:00:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPl24-0007Vs-5p for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPl1x-0004UL-UK for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:39:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48854) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPl1x-0004UF-Qf for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:39:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPl1w-0004tF-GO for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:39:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPl1r-0004SX-Eg for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:39:56 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:39350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPl1r-0004SJ-7G for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:39:51 -0400 Received: by mail-wm0-x235.google.com with SMTP id p11-v6so12657231wmc.4 for ; Mon, 04 Jun 2018 01:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=1hBUhHlCS+vpYK1UCJWzVw2h0NdXhaCk+Bj/JC1l+Qg=; b=Fz5U1j+6vJDQtPpGj//2Dsvg/1mvLaB9EXSXz7GO995cXa11z9Si6cQlQ610aPwsH4 r3/Z9KVBeFJyb8ZjAeo1kM3vulp/sMse/uIxm18BRPnvb9vEqzAxgsfuT7Ci6rsbxE0c XAimoYDxqANp9MLGoCcLzfoQVzsJZz9EegnytISbOYNpf0u/7hNRWP4rcNBxt+VPycdk 67mKFQTVIY2k/HrnwG/jxAeNin+YOMYjI7eEnRSVuumvKIqEj27rUHPUoqpHnp/ElN0+ SriR/3BwrktybMm1vX6taHw9ee34HzQtuMruYG9DfiojVre2LF2ioeRFr4rA5zKDtrpC s/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1hBUhHlCS+vpYK1UCJWzVw2h0NdXhaCk+Bj/JC1l+Qg=; b=FzVY9rjY86Qfpe6zqpWFmNiuHJHThQsNmuwK+LC1U2T6hUNz9YvwB4874v0UiJHxuI xV3sMoT74Rqsb/StHHJvX+jK97y0vOhJ+XK1/54HFhS2mKEbnH25DeaNgjQDajSO7MWO VeMqogJV3AOky9LL0PlPXwGPxNJ8GRRGtSgXZnbdW7w8qXi8ZSz74cC0jZJTE00CAVsF HooebUpCFuVKINBvDmvvvAzCuSKRivPtYRED0Y1Y07RBPiIdBMaV1yg8s145bZmTFRuE SlO6a87E4xw3xezpcDwuUaeOXTJ8akwB6bbV2ZxV0e1VrFJmNHYhe1tJ6zqzzTYrH+c8 x+6A== X-Gm-Message-State: APt69E0xh2YclHomgyxCR0zvAM3W3RLrAZna2mBWOg4SaAreAGUQ6cFi W14s4bhwYtM/pxUEqPA3amFXgcQX X-Google-Smtp-Source: ADUXVKIEKFYbpN9U6kVEszyXMlxLacVbhy45aUArr9CoCaSIkQdv7U6bIICXFO58OGUytS581+VNLQ== X-Received: by 2002:a1c:aa0c:: with SMTP id t12-v6mr8989948wme.56.1528101589725; Mon, 04 Jun 2018 01:39:49 -0700 (PDT) Received: from PAD2018L060.Parrot.Biz (smtp.parrot.biz. [62.23.167.188]) by smtp.gmail.com with ESMTPSA id 44-v6sm102909926wrv.47.2018.06.04.01.39.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 01:39:48 -0700 (PDT) From: Christophe Junke To: bug-gnu-emacs@gnu.org Subject: [PATCH 1/1] ido: add ido-fallback special variable Date: Mon, 4 Jun 2018 10:39:43 +0200 Message-Id: <20180604083943.13769-1-junke.christophe@gmail.com> X-Mailer: git-send-email 2.14.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 04 Jun 2018 05:00:49 -0400 Cc: Christophe Junke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The Ido module has been compiled with "lexical-binding: t" for some time now. Previously, when the bindings were dynamic, it was possible for other packages to modify the "fallback" variables declared inside "ido-file-internal" and "ido-buffer-internal". In particular, that was the case in magit-extras.el, which runs magit-status on current path when exiting Ido. This feature is now broken since "fallback" is lexical. For reference, the current code for "ido-enter-magit-status" does the following: (with-no-warnings ; FIXME these are internal variables (setq ido-exit 'fallback fallback 'magit-status)) (exit-minibuffer) I think it would be cleaner to have it do: (ido-fallback-command 'magit-status) The current patch: - Introduces an ido-fallback special variable, which, when set, overrides the local, lexical, "fallback" variable; it does so only when ido-exit is set to 'fallback. - Adds an optional parameter to "ido-fallback-command" that is used to specify which fallback command to run on exit. * lisp/ido.el (ido-fallback): add new variable, (ido-buffer-internal): reset ido-fallback to nil before prompting user, (ido-buffer-internal): use ido-fallback when ido-exit is 'fallback, (ido-file-internal): reset ido-fallback to nil before prompting user, (ido-file-internal): use ido-fallback when ido-exit is 'fallback, (ido-fallback-command): add optional argument fallback-command --- lisp/ido.el | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lisp/ido.el b/lisp/ido.el index 705e7dd630..00d0f4f446 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -1242,6 +1242,9 @@ Only used if `ido-use-virtual-buffers' is non-nil.") ;; Dynamically bound in ido-read-internal. (defvar ido-completing-read) +;; If dynamically set when ido-exit is 'fallback, overrides fallback command. +(defvar ido-fallback nil) + ;;; FUNCTIONS (defun ido-active (&optional merge) @@ -2220,6 +2223,7 @@ If cursor is not at the end of the user input, move to end of input." (run-hook-with-args 'ido-before-fallback-functions (or fallback 'switch-to-buffer)) (call-interactively (or fallback 'switch-to-buffer))) + (setq ido-fallback nil) (let* ((ido-context-switch-command switch-cmd) (ido-current-directory nil) (ido-directory-nonreadable nil) @@ -2245,7 +2249,7 @@ If cursor is not at the end of the user input, move to end of input." ((eq ido-exit 'fallback) (let ((read-buffer-function nil)) - (setq this-command (or fallback 'switch-to-buffer)) + (setq this-command (or ido-fallback fallback 'switch-to-buffer)) (run-hook-with-args 'ido-before-fallback-functions this-command) (call-interactively this-command))) @@ -2341,6 +2345,7 @@ If cursor is not at the end of the user input, move to end of input." ;; Internal function for ido-find-file and friends (unless item (setq item 'file)) + (setq ido-fallback nil) (let ((ido-current-directory (ido-expand-directory default)) (ido-context-switch-command switch-cmd) ido-directory-nonreadable ido-directory-too-big @@ -2412,7 +2417,7 @@ If cursor is not at the end of the user input, move to end of input." ;; we don't want to change directory of current buffer. (let ((default-directory ido-current-directory) (read-file-name-function nil)) - (setq this-command (or fallback 'find-file)) + (setq this-command (or ido-fallback fallback 'find-file)) (run-hook-with-args 'ido-before-fallback-functions this-command) (call-interactively this-command))) @@ -2821,13 +2826,15 @@ If no buffer or file exactly matching the prompt exists, maybe create a new one. (setq ido-exit 'takeprompt) (exit-minibuffer)) -(defun ido-fallback-command () - "Fallback to non-Ido version of current command." +(defun ido-fallback-command (&optional fallback-command) + "Fallback to non-Ido version of current command. +The optional fallback-command argument indicates which command to run." (interactive) (let ((i (length ido-text))) (while (> i 0) (push (aref ido-text (setq i (1- i))) unread-command-events))) (setq ido-exit 'fallback) + (setq ido-fallback fallback-command) (exit-minibuffer)) (defun ido-enter-find-file () -- 2.14.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 03:01:04 2018 Received: (at 31707) by debbugs.gnu.org; 9 Jun 2018 07:01:05 +0000 Received: from localhost ([127.0.0.1]:40257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXrz-0008Ts-M9 for submit@debbugs.gnu.org; Sat, 09 Jun 2018 03:01:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXry-0008TH-Ar for 31707@debbugs.gnu.org; Sat, 09 Jun 2018 03:01:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRXrq-00013z-6s for 31707@debbugs.gnu.org; Sat, 09 Jun 2018 03:00:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRXrq-00013l-2s; Sat, 09 Jun 2018 03:00:54 -0400 Received: from [176.228.60.248] (port=2555 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRXro-00006x-Nz; Sat, 09 Jun 2018 03:00:53 -0400 Date: Sat, 09 Jun 2018 10:00:56 +0300 Message-Id: <83bmcktpef.fsf@gnu.org> From: Eli Zaretskii To: Christophe Junke In-reply-to: <20180604083943.13769-1-junke.christophe@gmail.com> (message from Christophe Junke on Mon, 4 Jun 2018 10:39:43 +0200) Subject: Re: bug#31707: [PATCH 1/1] ido: add ido-fallback special variable References: <20180604083943.13769-1-junke.christophe@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31707 Cc: 31707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Christophe Junke > Date: Mon, 4 Jun 2018 10:39:43 +0200 > Cc: Christophe Junke > > The Ido module has been compiled with "lexical-binding: t" for some > time now. Previously, when the bindings were dynamic, it was possible > for other packages to modify the "fallback" variables declared inside > "ido-file-internal" and "ido-buffer-internal". > > In particular, that was the case in magit-extras.el, which runs > magit-status on current path when exiting Ido. This feature is now > broken since "fallback" is lexical. For reference, the current code > for "ido-enter-magit-status" does the following: > > (with-no-warnings ; FIXME these are internal variables > (setq ido-exit 'fallback fallback 'magit-status)) > (exit-minibuffer) > > I think it would be cleaner to have it do: > > (ido-fallback-command 'magit-status) > > The current patch: > > - Introduces an ido-fallback special variable, which, when set, > overrides the local, lexical, "fallback" variable; it does so only > when ido-exit is set to 'fallback. > > - Adds an optional parameter to "ido-fallback-command" that is used to > specify which fallback command to run on exit. Thanks. However, if the problem was caused by using lexical-binding in ido.el, then I wonder why you need anything except one additional line: (defvar ido-fallback) This should make ido-fallback a dynamically-bound variable, and all the rest should "just work" as it did before. Right? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 11 08:19:12 2018 Received: (at control) by debbugs.gnu.org; 11 Jun 2018 12:19:12 +0000 Received: from localhost ([127.0.0.1]:42855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSLmy-0006As-IL for submit@debbugs.gnu.org; Mon, 11 Jun 2018 08:19:12 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:44550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSLmx-0006Ad-DR; Mon, 11 Jun 2018 08:19:11 -0400 Received: by mail-io0-f172.google.com with SMTP id g7-v6so23577451ioh.11; Mon, 11 Jun 2018 05:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=L2K3rCNHSC/6AuVZTNTZWcHlPyT+HFdH589lEPU+daI=; b=M4VA4c45TIELMm89iHYHfI9ukzyrcrtWYtb1m5R/K4785Jhf0j9p6/mrWAs07sktvF fb1Wt+rstSSMNgA4rcKK0KILbwili61WQuYDYDt58kYKzxYGRuvXEcnwDkhKzFSUQbB/ 1FhU4/K3NoYDNuo14F0+r3tg8IX6c6uvvSUCyi0qSt5HeuCdK9GOi7E1TW+s/i6IcW12 f+GQ4k/UtAmq9UkbST9j2Nh+qQRLDLQAmbWMzwpcTvMm9hXCZ85fSH9dHRaPD0pLiJXB VVei9X3oaROioGi3qgRb04JebRgKVeSC1kZq1foXnHh84R2aOROnr09w5Z3F0eoCOA8F NB6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=L2K3rCNHSC/6AuVZTNTZWcHlPyT+HFdH589lEPU+daI=; b=bhp8yV0f+jX1yuiJ6fKs6FrZzCzsu0N/TgU3JA7cIKo6Fe/rI4yIkE1EdN+Z3KkZwV 6WSAZ2dwhaLs2CzYVuR6PylrJ1Jj/TrP/C0C2bHwlYwfGzuaLhNMCkZEytKobgknIPdG d7KrAbdg5MHVwlOpDQPR/qdtQtnzyEVrJlnEptF+6jU9Fu+BGNzDtvJDmjZH2789m+gY oAZxI35Iq2ioP3EpBkw/f8r5Z35kHJkWcA3GS5OTV1CeNTi18a434xWzI9CNGfhxu7Rr 3Mo3JpH8pq5zFLvzNg6VMEgXLcj7TITKmaNabSpesY109XhR8ZmUwve2Lj3cmI0PJccq q/3w== X-Gm-Message-State: APt69E29mBxm4XOH5XxtNcbnQkYvBBchsWXLn5kDu1Ukxgg59mY3ppAx 19ur4WV4nlkF/HIiL+GCfbuFNw== X-Google-Smtp-Source: ADUXVKJHWbe/x92zkteTWFkg4gQFEZANR+Jk2SWo16ChnPLYD33ClZOERrm96wH2DKpvM7RiyngCXg== X-Received: by 2002:a6b:8e0d:: with SMTP id q13-v6mr13861304iod.169.1528719545710; Mon, 11 Jun 2018 05:19:05 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 16-v6sm4069527itk.17.2018.06.11.05.19.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 05:19:05 -0700 (PDT) From: Noam Postavsky To: Christophe Junke Subject: Re: bug#31783: [PATCH v2] ido.el: define a special ido-fallback variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> Date: Mon, 11 Jun 2018 08:19:03 -0400 In-Reply-To: <20180611082340.28727-1-junke.christophe@gmail.com> (Christophe Junke's message of "Mon, 11 Jun 2018 10:23:40 +0200") Message-ID: <87efhdzfbc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 31783@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 31783 31707 quit Christophe Junke writes: > I agree that it is simpler to rename the existing variable, and just > add a defvar declaration. Here is a different version of the patch > which does only this. > +;; Indicates which fallback command to call when ido-exit is 'fallback. > +(defvar ido-fallback nil) > -(defun ido-buffer-internal (method &optional fallback prompt default initial switch-cmd) > +(defun ido-buffer-internal (method &optional ido-fallback prompt default initial switch-cmd) I believe this doesn't work, function parameters are always lexically bound. Compare ; -*- lexical-binding: t -*- (setq lexical-binding t) ; for use in *scratch* (defvar x nil) (disassemble (lambda (x y) (+ x y))) (let ((x 1)) (disassemble (lambda (y) (+ x y)))) So I think your first patch was fine. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 23 21:52:39 2018 Received: (at 31707) by debbugs.gnu.org; 24 Jun 2018 01:52:39 +0000 Received: from localhost ([127.0.0.1]:33568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWuCk-00005F-Tp for submit@debbugs.gnu.org; Sat, 23 Jun 2018 21:52:39 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:34339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWuCj-00004u-3k for 31707@debbugs.gnu.org; Sat, 23 Jun 2018 21:52:37 -0400 Received: by mail-io0-f180.google.com with SMTP id e15-v6so9405144iog.1 for <31707@debbugs.gnu.org>; Sat, 23 Jun 2018 18:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=j5OGf2p0/SX4AqXBT26KhosEWgeTRZfvYrXvMyQb8dM=; b=XVXyFQpW1wFcemmdaWxRgizXb7zECwnQBXmr+GMhb3SjSI9NC3D6K9C+dCCYv1CN3Q oq8XCH3riKT5UexgY4r+oYPxGpO67IjOSEE781kLPvD3q/qypGBVuFcFT/YUEetb6URQ wIo3qLenyADfnXLgL0iCf5JlV0srhrDl5AyjmjcneNuZVW1lK3f3JGpocezNGo+xRqlk VpOTr76f5NhQYIep7sQmOLt2dTZIgOp8W6OiaQLmE62TucDTwjLQcD10Kik5sakgpRXg NAPY6spJauWxUXJxfOnuPrwTwF/BYeT/RzqiZ/VgDsTxZpiEiY3dDnhfW/YuWu0YU+2F pSRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=j5OGf2p0/SX4AqXBT26KhosEWgeTRZfvYrXvMyQb8dM=; b=DVEJ6Y+SiDZ8F8gTIqAyWYY07h3kGGqdlbgzEiP6zFlAQSzmssIKrdF5/RnIYE8AHc hqv2hslH24ZSQfe/BFPkYKx4oCCBJInHG7ysobqRh0z4HLhboI7ubDwR5Qgnnkh4MQ2p wj8QH3SC+cBHhSYufdydaP4eQei8xjerISmuriyOF/NfTiNKjoDqOZYQbYS9VMPjOpE5 HKUKMGd+homFPF56QrgXKpuD9MSFqrgT8igGwYXmf4ZPsVQ8BfMacqPeDr7K0EGmlW5m VnMtSs3A5ql4U0HtgP6rJzH+KZwG12KCze+K0w73sR6L5ymT9E3LXPZXcAYP4JvP8ZyM 25Bw== X-Gm-Message-State: APt69E3VTs+tRPLvecD5WaYPCFeamlhdKdkRPPHc8JoYvXPOVNPBNF01 lnC1he0pgr1edbaqb64fccOUZA== X-Google-Smtp-Source: AAOMgpfYZClEBqkQaypU9z0WFx228cTp+kdfcuHYCTr5jcW8FctYG9IP6wC5P/u9QDqqNakTe1lQxw== X-Received: by 2002:a6b:b717:: with SMTP id h23-v6mr3362275iof.164.1529805151427; Sat, 23 Jun 2018 18:52:31 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g26-v6sm3230659iti.0.2018.06.23.18.52.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jun 2018 18:52:30 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31707: [PATCH 1/1] ido: add ido-fallback special variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> <87a7rnqcox.fsf@gmail.com> <837emrq9b3.fsf@gnu.org> Date: Sat, 23 Jun 2018 21:52:29 -0400 In-Reply-To: <837emrq9b3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Jun 2018 15:45:20 +0300") Message-ID: <87zhzlosrm.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 31707 Cc: junke.christophe@gmail.com, 31707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [moving discussion in #31783 back to original #31707] Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: junke.christophe@gmail.com, 31783@debbugs.gnu.org >> Date: Fri, 22 Jun 2018 07:32:14 -0400 >> >> Eli Zaretskii writes: >> > >> > What new feature is being introduced there? I couldn't see anything >> > new, just fixing a breakage. >> >> The optional parameter to ido-fallback-command is new. >> >> The ido-fallback is sort of a new variable, although it's arguably just >> a proper prefixing of the old `fallback' one. > > Maybe I'm confused about which patch will eventually go in. Can you > show it? The one in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31707#5. Depending how strict we want to be about changes, we could split off the ido-fallback-command parameter addition from the ido-fallback variable. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 24 10:54:48 2018 Received: (at 31707) by debbugs.gnu.org; 24 Jun 2018 14:54:48 +0000 Received: from localhost ([127.0.0.1]:34032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX6Pg-0007Zp-E6 for submit@debbugs.gnu.org; Sun, 24 Jun 2018 10:54:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX6Pf-0007Zb-1E for 31707@debbugs.gnu.org; Sun, 24 Jun 2018 10:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fX6PU-0002g5-DO for 31707@debbugs.gnu.org; Sun, 24 Jun 2018 10:54:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fX6PU-0002fy-8t; Sun, 24 Jun 2018 10:54:36 -0400 Received: from [176.228.60.248] (port=1265 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fX6PT-0001Xt-Lz; Sun, 24 Jun 2018 10:54:36 -0400 Date: Sun, 24 Jun 2018 17:54:33 +0300 Message-Id: <83a7rktety.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87zhzlosrm.fsf_-_@gmail.com> (message from Noam Postavsky on Sat, 23 Jun 2018 21:52:29 -0400) Subject: Re: bug#31707: [PATCH 1/1] ido: add ido-fallback special variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> <87a7rnqcox.fsf@gmail.com> <837emrq9b3.fsf@gnu.org> <87zhzlosrm.fsf_-_@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31707 Cc: junke.christophe@gmail.com, 31707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: junke.christophe@gmail.com, 31707@debbugs.gnu.org > Date: Sat, 23 Jun 2018 21:52:29 -0400 > > >> > What new feature is being introduced there? I couldn't see anything > >> > new, just fixing a breakage. > >> > >> The optional parameter to ido-fallback-command is new. > >> > >> The ido-fallback is sort of a new variable, although it's arguably just > >> a proper prefixing of the old `fallback' one. > > > > Maybe I'm confused about which patch will eventually go in. Can you > > show it? > > The one in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31707#5. So I wasn't confused, thanks. > Depending how strict we want to be about changes, we could split off the > ido-fallback-command parameter addition from the ido-fallback variable. No, I don't think this would be necessary. We are adding a variable to fix breakage. I think this can go to emacs-26 as-is. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 20:40:36 2018 Received: (at 31707) by debbugs.gnu.org; 26 Jun 2018 00:40:36 +0000 Received: from localhost ([127.0.0.1]:35472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXc27-0008Ai-O1 for submit@debbugs.gnu.org; Mon, 25 Jun 2018 20:40:35 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:37198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXc24-0008AN-DW; Mon, 25 Jun 2018 20:40:32 -0400 Received: by mail-io0-f171.google.com with SMTP id s26-v6so14296545ioj.4; Mon, 25 Jun 2018 17:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=X8ZG+JT4j2G90b7RedIMmfcnVdrGCZ2Eu2Kdrz3JZMM=; b=t5vMGnEXTo0nQSsHp/sovAGscEXYEBP+gughCaYeEYljTdKyig2iLd7pEfddwQ4Tcz K2MKAmKDPv7MSvmnXQyBnn933AthSlBzMQUeAXI4iUoLssYHg0GXH1hwDTk9Tvi/0LgI R3aUoUPjD9UYM0Wufv+TufdysUDKinUR0E6n4Fgg95UHTTcTsEye3/+YeXdvGdVg9mHu FkCcp8zf/QH+ikpY3DNgk6XeTK2d4JRsk88Rb9FDQqUYGA4Y2px3MHyNm/RvqJEs6lbg Ci55+h/dqb7jcHSgCw69dGtCZVLZUYLt3O/HCHeQBtuULt2hR+0dZZPurP0NYVQPEsza mAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=X8ZG+JT4j2G90b7RedIMmfcnVdrGCZ2Eu2Kdrz3JZMM=; b=U5czyyGhkKw645Mjc++PZTjjI1Q7LGCMu1UKE4DYaXYaRk5Zn4Pbk+r1vRODS5DvJc DrS+59PprocsOOjqqz2lN6+Ix8CTWYYLXaVdmSb/4p961xYTZJJ5JZ8i9qWA2pS8yx21 J6lJ3hUjjs8uSpsnFpc0JYsltssvphn+TFpwhSjoIgEjSMX/QkJq90KU65WKG3njR3hj PXW9XO7XAm3f5m5POprmBl1N94IQ2VM/eQLsXor7FuAImnt3At/pstSP3x9zj1xpjAlH +HtYwitYqaLDLFTkJFHNChcwCPUZIe8D1SWTaQvbp/gUUxf8AtthPRSfHeGcU33mzKpz jOfA== X-Gm-Message-State: APt69E3YCaigs1WBA1x5eeA7taLqPBeol+g22+c7zeslNB637Ot1ymVG 56Jdirc2vyHBdEOvcNEeaJGYyw== X-Google-Smtp-Source: ADUXVKKh+SiSqgbobYGHKZt8yhSbYrJMthwJxVVvvBhAmYVAf4uul2QYRAQwrdtMzj3zW0kpOaM3sA== X-Received: by 2002:a6b:988f:: with SMTP id a137-v6mr12573959ioe.212.1529973626696; Mon, 25 Jun 2018 17:40:26 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 20-v6sm351108itu.1.2018.06.25.17.40.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 17:40:25 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#31707: [PATCH 1/1] ido: add ido-fallback special variable References: <83bmcktpef.fsf@gnu.org> <20180611082340.28727-1-junke.christophe@gmail.com> <87efhdzfbc.fsf@gmail.com> <83h8m9qr5e.fsf@gnu.org> <837en5qn3l.fsf@gnu.org> <87h8lvr75p.fsf@gmail.com> <83h8lvqqgd.fsf@gnu.org> <87a7rnqcox.fsf@gmail.com> <837emrq9b3.fsf@gnu.org> <87zhzlosrm.fsf_-_@gmail.com> <83a7rktety.fsf@gnu.org> Date: Mon, 25 Jun 2018 20:40:23 -0400 In-Reply-To: <83a7rktety.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jun 2018 17:54:33 +0300") Message-ID: <87in66peh4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31707 Cc: junke.christophe@gmail.com, 31707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31707 fixed close 31707 26.2 quit Eli Zaretskii writes: > No, I don't think this would be necessary. We are adding a variable > to fix breakage. I think this can go to emacs-26 as-is. Done. [1: 12c77f6918]: 2018-06-25 20:05:53 -0400 Add ido-fallback special variable (Bug#31707) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=12c77f6918c4a60dbbae3f716a58300b4026e8da From unknown Wed Jun 18 00:24:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Jul 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator