From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Van L Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2018 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31706@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152810079227439 (code B ref -1); Mon, 04 Jun 2018 08:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jun 2018 08:26:32 +0000 Received: from localhost ([127.0.0.1]:60830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPkoy-00078U-FV for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPkox-00078F-59 for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPkoq-0005VO-Vl for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPkoq-0005VE-SA for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPkop-0000XT-O8 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:26:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPkom-0005Qt-H1 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:26:23 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55861) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPkom-0005On-AF for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:26:20 -0400 X-Originating-IP: 123.243.250.252 Received: from epi.local (123-243-250-252.tpgi.com.au [123.243.250.252]) (Authenticated sender: van@scratch.space) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3558360025 for ; Mon, 4 Jun 2018 10:26:16 +0200 (CEST) From: Van L Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-Id: Date: Mon, 4 Jun 2018 18:26:11 +1000 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Hello. After a vc-pull on a git directory, a vc-git buffer shows with links to = files that have changed. =E2=80=94 example Running "git pull"... =46rom git://github.com/apple/foundationdb ab5bfad..ce6a2f0 master -> origin/master Updating ab5bfad..ce6a2f0 Fast-forward fdbclient/CoordinationInterface.h | 2 +- fdbclient/DatabaseContext.h | 3 +- fdbclient/Knobs.cpp | 1 + fdbclient/Knobs.h | 1 + fdbclient/MasterProxyInterface.h | 2 +- fdbclient/MonitorLeader.actor.cpp | 84 = +++++++++++++++++++---------------- fdbclient/NativeAPI.actor.cpp | 17 ++++--- fdbclient/NativeAPI.h | 2 +- fdbclient/ReadYourWrites.h | 1 - fdbrpc/batcher.actor.h | 20 ++++++--- fdbserver/Knobs.cpp | 4 ++ fdbserver/Knobs.h | 4 ++ fdbserver/LeaderElection.actor.cpp | 30 ++++++------- fdbserver/MasterProxyServer.actor.cpp | 32 +++++++++---- fdbserver/fdbserver.actor.cpp | 7 ++- flow/error_definitions.h | 1 + flow/network.h | 1 + 17 files changed, 131 insertions(+), 81 deletions(-) =E2=80=94 end example Clicking on a link causes the ,system default open, to call the = operating system=E2=80=99s file manager to open that file. Expected desired behavior is that Emacs 26.1 simply visits the = ,flow/network.h, file (on event ,mouse-1: visit this file,) Trying to find the elisp function the mouse click calls, I do: 1. C-h k 2. 3. the echo area shows: mouse-1- if I click the mouse a second time I get the explanation for: = (mouse-drag-region START-EVENT) =46rom experience in Org Mode I know C-x customize ; search for ,org = app, ; you can set Emacs to be the default app for unrecognized files. After C-x customize, I search for A. git app B. vc app but there is no setting like `Org File Apps` to let Emacs open those = links in the vc-git buffer. =E2=80=94 (if '(you like avocado on toast) '(then you'll like Daniel Stone's "The Food Explorer".)) From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Acknowledgement (Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull) Resent-From: Van L Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2018 08:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 31706@debbugs.gnu.org Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152810216929873 (code B ref 31706); Mon, 04 Jun 2018 08:50:01 +0000 Received: (at 31706) by debbugs.gnu.org; 4 Jun 2018 08:49:29 +0000 Received: from localhost ([127.0.0.1]:60846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPlBA-0007lk-SM for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:49:29 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:42459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPlB9-0007lc-5E for 31706@debbugs.gnu.org; Mon, 04 Jun 2018 04:49:27 -0400 X-Originating-IP: 123.243.250.252 Received: from epi.local (123-243-250-252.tpgi.com.au [123.243.250.252]) (Authenticated sender: van@scratch.space) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4233DC000A for <31706@debbugs.gnu.org>; Mon, 4 Jun 2018 10:49:27 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Van L In-Reply-To: Date: Mon, 4 Jun 2018 18:49:18 +1000 Content-Transfer-Encoding: quoted-printable Message-Id: <903A938A-5DB6-4009-81F4-5E82117B3006@scratch.space> References: X-Mailer: Apple Mail (2.3124) X-Spam-Level: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > If you wish to submit further information on this problem, please > send it to 31706@debbugs.gnu.org. Running `emacs -Q` also presents the problem of being unable to click to = open file in Emacs after vc-pull. Clicking on link for lisp/org-src.el does not open the file in Emacs, in = the following example of vc-git buffer. =E2=80=94 example Running "git pull"... =46rom https://code.orgmode.org/bzg/org-mode cbb48611e..ed7d1dc6d master -> origin/master c9d49a40e..164862778 emacs-sync -> origin/emacs-sync 388254e0d..8fbdf0ce1 maint -> origin/maint * [new branch] next -> origin/next * [new branch] org-tempo -> origin/org-tempo * [new tag] release_9.1.13 -> release_9.1.13 Updating cbb48611e..ed7d1dc6d Fast-forward .dir-locals.el | 10 +- .gitignore | 1 + contrib/lisp/ob-clojure-literate.el | 15 +- doc/Documentation_Standards.org | 4 +- doc/Makefile | 6 + doc/org-manual.org | 538 +- doc/org.texi | 21806 = ---------------------------------- doc/orgguide.texi | 10 +- etc/ORG-NEWS | 2 +- lisp/ob-C.el | 8 +- lisp/ob-J.el | 2 +- lisp/ob-calc.el | 2 +- lisp/ob-clojure.el | 2 +- lisp/ob-comint.el | 2 +- lisp/ob-core.el | 15 +- lisp/ob-exp.el | 3 +- lisp/ob-forth.el | 2 +- lisp/ob-fortran.el | 5 +- lisp/ob-gnuplot.el | 2 +- lisp/ob-haskell.el | 3 +- lisp/ob-js.el | 10 +- lisp/ob-latex.el | 2 +- lisp/ob-lisp.el | 2 +- lisp/ob-lua.el | 7 +- lisp/ob-ocaml.el | 2 +- lisp/ob-octave.el | 8 +- lisp/ob-python.el | 7 +- lisp/ob-ref.el | 2 +- lisp/ob-ruby.el | 2 +- lisp/ob-scheme.el | 7 +- lisp/ob-shell.el | 2 +- lisp/ob-table.el | 3 +- lisp/ob-tangle.el | 6 +- lisp/ob-vala.el | 3 +- lisp/org-agenda.el | 686 +- lisp/org-capture.el | 55 +- lisp/org-clock.el | 2 +- lisp/org-colview.el | 6 +- lisp/org-compat.el | 34 +- lisp/org-element.el | 12 +- lisp/org-entities.el | 10 +- lisp/org-eshell.el | 2 +- lisp/org-feed.el | 2 +- lisp/org-footnote.el | 17 +- lisp/org-goto.el | 4 +- lisp/org-indent.el | 2 +- lisp/org-lint.el | 13 +- lisp/org-list.el | 53 +- lisp/org-macs.el | 58 +- lisp/org-pcomplete.el | 22 +- lisp/org-protocol.el | 20 +- lisp/org-src.el | 133 +- lisp/org-table.el | 96 +- lisp/org-tempo.el | 2 + lisp/org-w3m.el | 18 +- lisp/org.el | 326 +- lisp/ox-beamer.el | 9 +- lisp/ox-html.el | 50 +- lisp/ox-publish.el | 2 +- lisp/ox-texinfo.el | 13 +- lisp/ox.el | 2 +- mk/org-fixup.el | 7 + testing/README | 2 +- testing/lisp/test-ob-lob.el | 4 +- testing/lisp/test-ob.el | 4 +- testing/lisp/test-org-agenda.el | 3 +- testing/lisp/test-org-attach.el | 19 +- testing/lisp/test-org-capture.el | 16 + testing/lisp/test-org-element.el | 4 +- testing/lisp/test-org-lint.el | 12 + testing/lisp/test-org-list.el | 102 +- testing/lisp/test-org-timer.el | 6 +- testing/lisp/test-org.el | 31 +- 73 files changed, 1358 insertions(+), 23002 deletions(-) delete mode 100644 doc/org.texi =E2=80=94 end example Version: emacs 26.1, NS port =E2=80=94 (if '(you like avocado on toast) '(then you'll like Daniel Stone's "The Food Explorer".)) From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jun 2018 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Van L Cc: 31706@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152812748217344 (code B ref 31706); Mon, 04 Jun 2018 15:52:01 +0000 Received: (at 31706) by debbugs.gnu.org; 4 Jun 2018 15:51:22 +0000 Received: from localhost ([127.0.0.1]:33487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPrlS-0004Vg-6S for submit@debbugs.gnu.org; Mon, 04 Jun 2018 11:51:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPrlM-0004V1-Ey for 31706@debbugs.gnu.org; Mon, 04 Jun 2018 11:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPrlG-0005Dl-6U for 31706@debbugs.gnu.org; Mon, 04 Jun 2018 11:51:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrlG-0005DY-1j; Mon, 04 Jun 2018 11:51:10 -0400 Received: from [176.228.60.248] (port=2216 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fPrlF-0006WI-HO; Mon, 04 Jun 2018 11:51:09 -0400 Date: Mon, 04 Jun 2018 18:51:18 +0300 Message-Id: <834liiczyh.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Van L on Mon, 4 Jun 2018 18:26:11 +1000) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Van L > Date: Mon, 4 Jun 2018 18:26:11 +1000 > > After a vc-pull on a git directory, a vc-git buffer shows with links to files that have changed. > > — example > Running "git pull"... > From git://github.com/apple/foundationdb > ab5bfad..ce6a2f0 master -> origin/master > Updating ab5bfad..ce6a2f0 > Fast-forward > fdbclient/CoordinationInterface.h | 2 +- > fdbclient/DatabaseContext.h | 3 +- > fdbclient/Knobs.cpp | 1 + > fdbclient/Knobs.h | 1 + > fdbclient/MasterProxyInterface.h | 2 +- > fdbclient/MonitorLeader.actor.cpp | 84 +++++++++++++++++++---------------- > fdbclient/NativeAPI.actor.cpp | 17 ++++--- > fdbclient/NativeAPI.h | 2 +- > fdbclient/ReadYourWrites.h | 1 - > fdbrpc/batcher.actor.h | 20 ++++++--- > fdbserver/Knobs.cpp | 4 ++ > fdbserver/Knobs.h | 4 ++ > fdbserver/LeaderElection.actor.cpp | 30 ++++++------- > fdbserver/MasterProxyServer.actor.cpp | 32 +++++++++---- > fdbserver/fdbserver.actor.cpp | 7 ++- > flow/error_definitions.h | 1 + > flow/network.h | 1 + > 17 files changed, 131 insertions(+), 81 deletions(-) > > — end example > > Clicking on a link causes the ,system default open, to call the operating system’s file manager to open that file. > > Expected desired behavior is that Emacs 26.1 simply visits the ,flow/network.h, file (on event ,mouse-1: visit this file,) I cannot reproduce this. I get exactly the behavior you expect. Could be some problem specific to your platform (which is what, btw?). > Trying to find the elisp function the mouse click calls, I do: > > 1. C-h k > 2. > 3. the echo area shows: mouse-1- > > if I click the mouse a second time I get the explanation for: (mouse-drag-region START-EVENT) Try "M-x describe-text-properties RET" with point on one of the links. (I guess "C-h k" needs to be extended to be smarter in this case.) From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Van L Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jun 2018 03:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 31706@debbugs.gnu.org Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152817024820025 (code B ref 31706); Tue, 05 Jun 2018 03:45:01 +0000 Received: (at 31706) by debbugs.gnu.org; 5 Jun 2018 03:44:08 +0000 Received: from localhost ([127.0.0.1]:33850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQ2tD-0005Cv-Tt for submit@debbugs.gnu.org; Mon, 04 Jun 2018 23:44:08 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:49261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQ2tA-0005Cl-FC for 31706@debbugs.gnu.org; Mon, 04 Jun 2018 23:44:06 -0400 X-Originating-IP: 220.245.108.24 Received: from epi.local (220-245-108-24.tpgi.com.au [220.245.108.24]) (Authenticated sender: van@scratch.space) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 4A6E720003; Tue, 5 Jun 2018 05:44:07 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Van L In-Reply-To: <834liiczyh.fsf@gnu.org> Date: Tue, 5 Jun 2018 13:43:56 +1000 Content-Transfer-Encoding: quoted-printable Message-Id: <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> References: <834liiczyh.fsf@gnu.org> X-Mailer: Apple Mail (2.3124) X-Spam-Level: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Eli Zaretskii writes: >=20 > Could be some problem specific to your platform (which is what, btw?). GNU Emacs 26.1=20 NS port macos "GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.6.0, NS appkit-1404.47 = Version 10.11.6 (Build 15G19009)) of 2018-06-02" > Try "M-x describe-text-properties RET" with point on one of the links. In the example below,=20 I invoked `emacs -Q`,=20 then vc-pull,=20 in the vc-git buffer,=20 I leave point on the O in etc/HISTORY link,=20 and `M-x describe-text-properties RET` produces the following result: =E2=80=94 result Text content at position 1812: There are text properties here: compilation-message [Show] font-lock-face (compilation-info underline) fontified t help-echo "mouse-2: visit this file" keymap compilation-button-map mouse-face highlight =E2=80=94 end result The hover over the link label shows ,mouse-1: visit this file, (On right-handed mouse) left or middle mouse button click on=20 the O in etc/HISTORY link=20 causes the macos Finder file manager to present window for choosing a = file to open. Expected, desired behavior is for Emacs 26.1 to visit file in new = buffer. =E2=80=94 example Running "git pull"... =46rom git://git.sv.gnu.org/emacs 58d0642e1c..1dafa4a02e master -> origin/master b8e7749b33..55c9bb9f3c emacs-26 -> origin/emacs-26 * [new branch] scratch/np/backports-26.2 -> = origin/scratch/np/backports-26.2 * [new branch] scratch/support-plists-in-jsonc-autodetect -> = origin/scratch/support-plists-in-jsonc-autodetect Updating cc130d13d4..1dafa4a02e Fast-forward ChangeLog.3 | 525 +++++++++++++++++- admin/authors.el | 2 +- admin/notes/multi-tty | 2 +- configure.ac | 9 +- doc/emacs/files.texi | 9 +- doc/emacs/macos.texi | 4 +- doc/emacs/misc.texi | 2 +- doc/emacs/msdos.texi | 2 +- doc/lispintro/emacs-lisp-intro.texi | 124 +++-- doc/lispref/buffers.texi | 22 +- doc/lispref/control.texi | 967 = ++++++++++++++++++++++++++------- doc/lispref/display.texi | 2 +- doc/lispref/elisp.texi | 5 +- doc/lispref/errors.texi | 2 +- doc/lispref/files.texi | 18 +- doc/lispref/searching.texi | 2 + doc/lispref/streams.texi | 15 + doc/lispref/syntax.texi | 12 +- doc/lispref/text.texi | 7 +- doc/misc/autotype.texi | 2 +- doc/misc/emacs-mime.texi | 2 +- doc/misc/org.texi | 4 +- doc/misc/tramp.texi | 187 +++++-- doc/misc/viper.texi | 2 +- doc/misc/wisent.texi | 2 +- etc/AUTHORS | 141 +++-- etc/HELLO | 15 +- etc/HISTORY | 2 + etc/NEWS | 29 + etc/NEWS.26 | 45 ++ etc/PROBLEMS | 12 +- lisp/emacs-lisp/cl-macs.el | 8 +- lisp/emacs-lisp/cl-print.el | 115 ++-- lisp/emacs-lisp/eieio.el | 8 +- lisp/emacs-lisp/pcase.el | 143 ++--- lisp/emacs-lisp/radix-tree.el | 2 + lisp/emacs-lisp/rmc.el | 18 +- lisp/emacs-lisp/rx.el | 20 +- lisp/epa-file.el | 2 - lisp/epa-mail.el | 4 +- lisp/epa.el | 57 +- lisp/epg-config.el | 29 +- lisp/epg.el | 120 +--- lisp/files.el | 227 ++++---- lisp/frame.el | 3 + lisp/gnus/message.el | 4 +- lisp/help.el | 4 +- lisp/hexl.el | 14 +- lisp/image.el | 1 + lisp/ldefs-boot.el | 135 +++-- lisp/net/tramp-adb.el | 9 +- lisp/net/tramp-cache.el | 6 +- lisp/net/tramp-gvfs.el | 48 +- lisp/net/tramp-sh.el | 50 +- lisp/net/tramp-smb.el | 24 +- lisp/net/tramp.el | 145 ++--- lisp/newcomment.el | 5 +- lisp/progmodes/cc-mode.el | 41 +- lisp/progmodes/flymake-cc.el | 140 +++++ lisp/progmodes/gud.el | 7 +- lisp/progmodes/sql.el | 272 +++++++--- lisp/replace.el | 7 +- lisp/subr.el | 7 +- lisp/term.el | 68 ++- lisp/term/ns-win.el | 4 + lisp/textmodes/bibtex.el | 41 +- lisp/textmodes/css-mode.el | 66 ++- src/.gdbinit | 2 +- src/Makefile.in | 5 + src/dired.c | 9 +- src/emacs.c | 2 +- src/filelock.c | 5 +- src/gtkutil.c | 4 +- src/image.c | 2 +- src/nsterm.m | 30 +- src/print.c | 11 +- src/search.c | 5 +- src/w32.c | 291 ++++++++++ src/w32.h | 2 + src/w32fns.c | 81 +++ src/xdisp.c | 7 +- src/xterm.c | 12 +- test/lisp/emacs-lisp/cl-print-tests.el | 25 + test/lisp/files-tests.el | 489 ++++++++++++++--- test/lisp/net/tramp-tests.el | 21 +- test/lisp/replace-tests.el | 119 ++-- test/lisp/term-tests.el | 7 + test/lisp/textmodes/css-mode-tests.el | 15 +- test/src/print-tests.el | 36 ++ 89 files changed, 3858 insertions(+), 1350 deletions(-) create mode 100644 lisp/progmodes/flymake-cc.el =E2=80=94 end example= From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jun 2018 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Van L Cc: 31706@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152820873221578 (code B ref 31706); Tue, 05 Jun 2018 14:26:01 +0000 Received: (at 31706) by debbugs.gnu.org; 5 Jun 2018 14:25:32 +0000 Received: from localhost ([127.0.0.1]:35242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQCtv-0005by-S6 for submit@debbugs.gnu.org; Tue, 05 Jun 2018 10:25:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQCtu-0005bl-2W for 31706@debbugs.gnu.org; Tue, 05 Jun 2018 10:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQCtk-0006Hs-Uj for 31706@debbugs.gnu.org; Tue, 05 Jun 2018 10:25:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQCtk-0006Hc-Jw; Tue, 05 Jun 2018 10:25:20 -0400 Received: from [176.228.60.248] (port=3815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fQCtk-0003pp-11; Tue, 05 Jun 2018 10:25:20 -0400 Date: Tue, 05 Jun 2018 17:25:30 +0300 Message-Id: <83efhlb99h.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> (message from Van L on Tue, 5 Jun 2018 13:43:56 +1000) References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Van L > Date: Tue, 5 Jun 2018 13:43:56 +1000 > Cc: 31706@debbugs.gnu.org > > > Could be some problem specific to your platform (which is what, btw?). > > GNU Emacs 26.1 > NS port macos > > "GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G19009)) > of 2018-06-02" So it could be something specific to NS. Can someone with access to NS port please try reproducing this? > > Try "M-x describe-text-properties RET" with point on one of the links. > [...] > There are text properties here: > compilation-message [Show] > font-lock-face (compilation-info underline) > fontified t > help-echo "mouse-2: visit this file" > keymap compilation-button-map > mouse-face highlight This tells you that the binding to be looked for is in compilation-button-map. > The hover over the link label shows ,mouse-1: visit this file, Yes, that's a feature that mouse-2 in the help-echo is replaced with mouse-1. > Expected, desired behavior is for Emacs 26.1 to visit file in new buffer. Yes, and that's what I get on my system. From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Van L Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jun 2018 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 31706@debbugs.gnu.org Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152821125416366 (code B ref 31706); Tue, 05 Jun 2018 15:08:01 +0000 Received: (at 31706) by debbugs.gnu.org; 5 Jun 2018 15:07:34 +0000 Received: from localhost ([127.0.0.1]:35334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQDYb-0004Ft-B0 for submit@debbugs.gnu.org; Tue, 05 Jun 2018 11:07:34 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:33219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQDYZ-0004Fk-GL for 31706@debbugs.gnu.org; Tue, 05 Jun 2018 11:07:32 -0400 X-Originating-IP: 220.245.108.24 Received: from epi.local (220-245-108-24.tpgi.com.au [220.245.108.24]) (Authenticated sender: van@scratch.space) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id C677420019; Tue, 5 Jun 2018 17:07:35 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Van L In-Reply-To: <83efhlb99h.fsf@gnu.org> Date: Wed, 6 Jun 2018 01:07:24 +1000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> X-Mailer: Apple Mail (2.3124) X-Spam-Level: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Eli Zaretskii writes: >=20 > So it could be something specific to NS. Can someone with access to > NS port please try reproducing this? I had this problem in org mode for org store/insert link to file which = was solved by the following.=20 =E2=80=94 quote '(org-file-apps (quote ((auto-mode . emacs) ("\\.mm\\'" . default) ("\\.x?html?\\'" . default) ("\\.pdf\\'" . default) (t . emacs)))) ; This tells Emacs to open any = unrecognized file. =E2=80=94 end quote From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jun 2018 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Van L , 31706@debbugs.gnu.org Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152840477316393 (code B ref 31706); Thu, 07 Jun 2018 20:53:01 +0000 Received: (at 31706) by debbugs.gnu.org; 7 Jun 2018 20:52:53 +0000 Received: from localhost ([127.0.0.1]:38449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR1ts-0004GK-Q6 for submit@debbugs.gnu.org; Thu, 07 Jun 2018 16:52:53 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:36103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fR1tr-0004G8-5m for 31706@debbugs.gnu.org; Thu, 07 Jun 2018 16:52:51 -0400 Received: by mail-wr0-f174.google.com with SMTP id f16-v6so11206750wrm.3 for <31706@debbugs.gnu.org>; Thu, 07 Jun 2018 13:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aI06qiKanE0PnJZxXjZI1kqTWVHNN3BfKxpoR3CqLvk=; b=gNh277nhnD/JDiXuu0xMW+4D5IDMVPHp1ZTKsmKXJU/0Qwq1Ofue6nRcPGFKphRP0V y2s5KT/odc1zP6bLQTnHIearp2G71oPJagCAie6jUMsLvZRIkJOrVBNniSkcvUjkoQmM 1qBsQGitz+Oa+ou+Fnn7gB3fAbmqT959N5pAybo4iGeDeA7wwliOfTNnoUTfXVZel3XI tm9nzxFOWW75eHMFVGrDSvUOixbSslHrmla6Jqb+17huLleuKdiAtGZ1XyscM3VeFllf hTQqU1Tz7FFvJKnPmogFoLopWNxJU4pGhYKVxCrtzOxQ0QaZOcB3HWkaTwwzvupniTrE Jx3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=aI06qiKanE0PnJZxXjZI1kqTWVHNN3BfKxpoR3CqLvk=; b=fYXCBQJWuL7x4UfPcwKhc5AsLnQzrv94mYt2HUVVro9pKiz8OCvKbU/o+MvBNBuDgQ NoxNsl8jVgbJU7F71exGA2w6HvJyRU1o9x+SwH20rDzZG28ZUFDyZmUpXnetP8omKIRu esVJX5O4tQYKN9GsnxTS6wfaLBCNFZQ7k2nr0wRfzUe/sj901p07jE2U+wHz6/8GlPZr MAgpUsZvskEdi4OfKgmDgCz6Fyvz+zPujWnTQa/8YlP6lhWEwde70hTnQlWDS5LhCAC4 IMvzt2gaiSF9hpkCAxQoboXJBrDUUubvjNxuT5CLSe7V0GUr+6l1H5KJlP60Lk2HcQAq PlJA== X-Gm-Message-State: APt69E2212YjmabWNxPFYgzlwRuzjtvnx6YcJcD4PTAww7SlTSXkxJyN VGzupZF1+o1fH6QByJ7znkM= X-Google-Smtp-Source: ADUXVKJsGKitCRlYPrqYh+c6TU2L3QGPlxo7T+Xtu8sS+KOQDIBWT9y+CgXHut2deSJs9cBMXSxTOQ== X-Received: by 2002:adf:9aa5:: with SMTP id a34-v6mr3065578wrc.50.1528404765205; Thu, 07 Jun 2018 13:52:45 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-acd0-c556-d8b1-5ceb.holly.idiocy.org. [2001:8b0:3f8:8129:acd0:c556:d8b1:5ceb]) by smtp.gmail.com with ESMTPSA id l7-v6sm2708621wmh.1.2018.06.07.13.52.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 13:52:44 -0700 (PDT) Date: Thu, 7 Jun 2018 21:52:42 +0100 From: Alan Third Message-ID: <20180607205242.GA26012@breton.holly.idiocy.org> References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83efhlb99h.fsf@gnu.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Tue, Jun 05, 2018 at 05:25:30PM +0300, Eli Zaretskii wrote: > > From: Van L > > Date: Tue, 5 Jun 2018 13:43:56 +1000 > > Cc: 31706@debbugs.gnu.org > > > > > Could be some problem specific to your platform (which is what, btw?). > > > > GNU Emacs 26.1 > > NS port macos > > > > "GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G19009)) > > of 2018-06-02" > > So it could be something specific to NS. Can someone with access to > NS port please try reproducing this? I can reproduce this on Emacs 25, and all versions of Emacs 26 that I tried, but not on master. -- Alan Third From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jun 2018 06:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Third Cc: van@scratch.space, 31706@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152844000918361 (code B ref 31706); Fri, 08 Jun 2018 06:41:01 +0000 Received: (at 31706) by debbugs.gnu.org; 8 Jun 2018 06:40:09 +0000 Received: from localhost ([127.0.0.1]:38619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRB4C-0004m5-Qc for submit@debbugs.gnu.org; Fri, 08 Jun 2018 02:40:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRB4B-0004ls-Iq for 31706@debbugs.gnu.org; Fri, 08 Jun 2018 02:40:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRB43-0005ih-6v for 31706@debbugs.gnu.org; Fri, 08 Jun 2018 02:40:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRB43-0005iW-21; Fri, 08 Jun 2018 02:39:59 -0400 Received: from [176.228.60.248] (port=4708 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRB41-0001HV-SP; Fri, 08 Jun 2018 02:39:58 -0400 Date: Fri, 08 Jun 2018 09:39:59 +0300 Message-Id: <83wov9vl1c.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <20180607205242.GA26012@breton.holly.idiocy.org> (message from Alan Third on Thu, 7 Jun 2018 21:52:42 +0100) References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Thu, 7 Jun 2018 21:52:42 +0100 > From: Alan Third > Cc: Van L , 31706@debbugs.gnu.org > > > So it could be something specific to NS. Can someone with access to > > NS port please try reproducing this? > > I can reproduce this on Emacs 25, and all versions of Emacs 26 that I > tried, but not on master. Thanks. Do you have an idea why it happens and what change on master fixed it? From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jun 2018 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: van@scratch.space, 31706@debbugs.gnu.org Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152864496520596 (code B ref 31706); Sun, 10 Jun 2018 15:37:02 +0000 Received: (at 31706) by debbugs.gnu.org; 10 Jun 2018 15:36:05 +0000 Received: from localhost ([127.0.0.1]:42483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS2Nw-0005M7-Tn for submit@debbugs.gnu.org; Sun, 10 Jun 2018 11:36:05 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:38568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS2Nu-0005LX-PG for 31706@debbugs.gnu.org; Sun, 10 Jun 2018 11:36:03 -0400 Received: by mail-wr0-f171.google.com with SMTP id e18-v6so9575236wrs.5 for <31706@debbugs.gnu.org>; Sun, 10 Jun 2018 08:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=o+uq4c0YGWW3CiXIFyFhvYjeAInAjpewGGEAH2V5lNk=; b=oak75ofVokgvWrHvjHOQNV/IQQmkDirkFle62aXwhcYs8XnWxGF6TxJzJ9AoJmuk/4 MdvRpuACnga4IpKncjiOTi2UpAROzf1aKYNdgRzxUCp1z/3YqKrxNsN+fOVuIjar+IIE o/hRgaMFyL0W+hx1FjLMJn2K3BKNWrW3MtFnGXzNI2RhVqDHfeBrZGfw2rBuDnj5mWj/ d1AXs9G+WHLvbq3lkZha826nc9iy9gzXBQlS42z5CwSH+xTi2n4a78kOzAMGuYKbbMl4 k28S+c9c/NHeS1hzWjbFn5rGMI+TyUKMgEnuiMP+EgdEXqZ5JcrGkTe6pFImQT151H0p 4xjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=o+uq4c0YGWW3CiXIFyFhvYjeAInAjpewGGEAH2V5lNk=; b=UIM42Koq2JbSvBvqXkLnulmTcc7eMdLq1C1hC07fEA5J/v7jVB4C33E4cBNV0kSNNa ggd81tepbuYDC4a9Qzezign+AYVvaQ3OYSalZ9nisX4wn+B9V6qWJYFWcPPw4xzOtGpE k5AuMW7kb2OLKrIHUjk8yi4uC83tKhhyLPMhL0qZuoLrLpT1mxbrS+fzvHJF5wrSsdeX YQgaKbLQ8DOP7+DDtvaUrDEnOPh3lCXI6SmHqHgnwHKlvGB3pmmJEQYah6LQAxjaKMdm HqYQ12RDpsXA0BUZN9XvIsysUrFi4b0p1OVM6A0ZWE1CQP9oTBmgc1I3SRkUMer+mlFu FOAw== X-Gm-Message-State: APt69E2Kck4VdYEVwDBsI75g6i3ljPtxQPpr2O41rrtEAhAbG9K65oo0 SjNXouknId01T9LLrbQvAMw= X-Google-Smtp-Source: ADUXVKKzD2vMPeFvth22Cyi/YN47t4DUU70gGtojegIhqXymc7th1M3v5DlXnJ+t8DFVPY+mVPrKog== X-Received: by 2002:adf:9769:: with SMTP id r96-v6mr11083624wrb.57.1528644957049; Sun, 10 Jun 2018 08:35:57 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-acd0-c556-d8b1-5ceb.holly.idiocy.org. [2001:8b0:3f8:8129:acd0:c556:d8b1:5ceb]) by smtp.gmail.com with ESMTPSA id h11-v6sm12928987wrs.85.2018.06.10.08.35.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jun 2018 08:35:56 -0700 (PDT) Date: Sun, 10 Jun 2018 16:35:54 +0100 From: Alan Third Message-ID: <20180610153554.GA54205@breton.holly.idiocy.org> References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> <83wov9vl1c.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83wov9vl1c.fsf@gnu.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Fri, Jun 08, 2018 at 09:39:59AM +0300, Eli Zaretskii wrote: > > Date: Thu, 7 Jun 2018 21:52:42 +0100 > > From: Alan Third > > Cc: Van L , 31706@debbugs.gnu.org > > > > > So it could be something specific to NS. Can someone with access to > > > NS port please try reproducing this? > > > > I can reproduce this on Emacs 25, and all versions of Emacs 26 that I > > tried, but not on master. > > Thanks. Do you have an idea why it happens and what change on master > fixed it? It’s commit 5ea5b2536ef580fe4b17b6dbd62df90d51e73e5f. I don’t understand why, though. -- Alan Third From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jun 2018 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Third Cc: van@scratch.space, 31706@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152864699723774 (code B ref 31706); Sun, 10 Jun 2018 16:10:01 +0000 Received: (at 31706) by debbugs.gnu.org; 10 Jun 2018 16:09:57 +0000 Received: from localhost ([127.0.0.1]:42493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS2uh-0006BM-VD for submit@debbugs.gnu.org; Sun, 10 Jun 2018 12:09:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS2ug-0006B7-5D for 31706@debbugs.gnu.org; Sun, 10 Jun 2018 12:09:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS2uX-0003Bh-Pk for 31706@debbugs.gnu.org; Sun, 10 Jun 2018 12:09:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS2uX-0003BV-M2; Sun, 10 Jun 2018 12:09:45 -0400 Received: from [176.228.60.248] (port=4437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fS2uW-0006bd-OU; Sun, 10 Jun 2018 12:09:45 -0400 Date: Sun, 10 Jun 2018 19:09:50 +0300 Message-Id: <8336xusjw1.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <20180610153554.GA54205@breton.holly.idiocy.org> (message from Alan Third on Sun, 10 Jun 2018 16:35:54 +0100) References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> <83wov9vl1c.fsf@gnu.org> <20180610153554.GA54205@breton.holly.idiocy.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sun, 10 Jun 2018 16:35:54 +0100 > From: Alan Third > Cc: van@scratch.space, 31706@debbugs.gnu.org > > > Thanks. Do you have an idea why it happens and what change on master > > fixed it? > > It’s commit 5ea5b2536ef580fe4b17b6dbd62df90d51e73e5f. I don’t > understand why, though. I presume just the vc-git part of that fixes the bug? Maybe we should simply backport both the above commit and its predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53? From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jun 2018 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: van@scratch.space, 31706@debbugs.gnu.org Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152866169412828 (code B ref 31706); Sun, 10 Jun 2018 20:15:01 +0000 Received: (at 31706) by debbugs.gnu.org; 10 Jun 2018 20:14:54 +0000 Received: from localhost ([127.0.0.1]:42575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS6jm-0003Kp-EY for submit@debbugs.gnu.org; Sun, 10 Jun 2018 16:14:54 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:42597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS6jj-0003KZ-R5 for 31706@debbugs.gnu.org; Sun, 10 Jun 2018 16:14:52 -0400 Received: by mail-wr0-f179.google.com with SMTP id w10-v6so18219474wrk.9 for <31706@debbugs.gnu.org>; Sun, 10 Jun 2018 13:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LhbtVKEU9qYa2cbJEcByFx3hB5AvZk4PsvLuCzmnCLs=; b=mSOAuzWxeA4DMFrebHubT5Msa5z2SFNnoFnKq+gyvTH2L2LFjbXZZFTQqGzoWkyL3Z 9n9jT20OMyVbUPk0WoeEX52fgy1WraGW5Hb1/ipFFjd987yfvBxX0CpxlEP+vFOKmifF Ld3OhGHwUy6+3zE23vmc48SpJL2UCOWCIY+8kD5ymA0/niLYWhhTcSPRXW5hdpwsZFSq P5qyRS9UaPFX8K0iiGct0lfGY4lC7JVk9btjIZqJ8AQEwkOKNRzx2MOX/fmlB97HD8Tx WKT2v0WTHpsWL6I81qGyzoSOHNiVxshiF+s0JBJcFZRGPzYM8Wq/zfgklwM8SSG9DghU 8R0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=LhbtVKEU9qYa2cbJEcByFx3hB5AvZk4PsvLuCzmnCLs=; b=NUR9dL+sDdPdyHJ9XztMYeCgv6+EItEq7X8os2tc4GJltoR5d3Ev/4Oj2AMD8WDHe6 K7BVDGOtjDfCUkCT+VsaEn/HQqAL0UvRKDHMRLaXariW0TrKNXMjV9FsKNquZO2alAnf 3bcnjnqlZSKapWS2mj/KRDPINKHwHO4RsNZsOxMSeMukuAq3A78oEiLPQFFvc7aBmO1u aPf3bmCrd/AWaHnFihLDB979dbKkm+qIn3Li5iQKm777jG2oHJDnnEgnjFQXuS/KP7T0 LZzIwkQf/qWmJiO0l61BhdpCoKnO75TJF4BQhjvd060Ml+gNfLeFZFSLZEhNJrd03iQS 1HHA== X-Gm-Message-State: APt69E1Cy7NMte8gnxeaCjOCHZpUTJrclFirM/aoTGwF5oIxCp194GTf SVtPY6939VhoQKyjFqcZQ8U= X-Google-Smtp-Source: ADUXVKLVLy3wsy8sPg16WlBWOHcX86wf5npEe5so9ORi5o+boHGr2SkQV0zNE5BulyqYPntexd+qdA== X-Received: by 2002:adf:a851:: with SMTP id l75-v6mr10433424wrc.140.1528661685939; Sun, 10 Jun 2018 13:14:45 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-68c5-3e02-66c2-2683.holly.idiocy.org. [2001:8b0:3f8:8129:68c5:3e02:66c2:2683]) by smtp.gmail.com with ESMTPSA id j21-v6sm5279424wme.36.2018.06.10.13.14.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jun 2018 13:14:45 -0700 (PDT) Date: Sun, 10 Jun 2018 21:14:42 +0100 From: Alan Third Message-ID: <20180610201442.GA22241@breton.holly.idiocy.org> References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> <83wov9vl1c.fsf@gnu.org> <20180610153554.GA54205@breton.holly.idiocy.org> <8336xusjw1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8336xusjw1.fsf@gnu.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Jun 10, 2018 at 07:09:50PM +0300, Eli Zaretskii wrote: > > Date: Sun, 10 Jun 2018 16:35:54 +0100 > > From: Alan Third > > Cc: van@scratch.space, 31706@debbugs.gnu.org > > > > > Thanks. Do you have an idea why it happens and what change on master > > > fixed it? > > > > It’s commit 5ea5b2536ef580fe4b17b6dbd62df90d51e73e5f. I don’t > > understand why, though. > > I presume just the vc-git part of that fixes the bug? > > Maybe we should simply backport both the above commit and its > predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53? They both apply cleanly to emacs-26. I wouldn’t have thought this was a big enough problem for Emacs 26.2, though? -- Alan Third From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jun 2018 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Third Cc: van@scratch.space, 31706@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31706-submit@debbugs.gnu.org id=B31706.152868405627646 (code B ref 31706); Mon, 11 Jun 2018 02:28:02 +0000 Received: (at 31706) by debbugs.gnu.org; 11 Jun 2018 02:27:36 +0000 Received: from localhost ([127.0.0.1]:42688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSCYS-0007Bq-5s for submit@debbugs.gnu.org; Sun, 10 Jun 2018 22:27:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSCYQ-0007Bb-AS for 31706@debbugs.gnu.org; Sun, 10 Jun 2018 22:27:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSCYI-0000YH-2B for 31706@debbugs.gnu.org; Sun, 10 Jun 2018 22:27:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCYH-0000Y6-V4; Sun, 10 Jun 2018 22:27:25 -0400 Received: from [176.228.60.248] (port=1336 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSCYH-0001HS-CJ; Sun, 10 Jun 2018 22:27:25 -0400 Date: Mon, 11 Jun 2018 05:27:32 +0300 Message-Id: <83vaaqqcq3.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <20180610201442.GA22241@breton.holly.idiocy.org> (message from Alan Third on Sun, 10 Jun 2018 21:14:42 +0100) References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> <83wov9vl1c.fsf@gnu.org> <20180610153554.GA54205@breton.holly.idiocy.org> <8336xusjw1.fsf@gnu.org> <20180610201442.GA22241@breton.holly.idiocy.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sun, 10 Jun 2018 21:14:42 +0100 > From: Alan Third > Cc: van@scratch.space, 31706@debbugs.gnu.org > > > Maybe we should simply backport both the above commit and its > > predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53? > > They both apply cleanly to emacs-26. > > I wouldn’t have thought this was a big enough problem for Emacs 26.2, > though? But the commits are quite safe, don't you think? And fix a long-standing problem. So I see no reason not to backport. From unknown Tue Jun 17 22:27:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Van L Subject: bug#31706: closed (Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull) Message-ID: References: <20180612202350.GD889@breton.holly.idiocy.org> X-Gnu-PR-Message: they-closed 31706 X-Gnu-PR-Package: emacs Reply-To: 31706@debbugs.gnu.org Date: Tue, 12 Jun 2018 20:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1528835042-28672-1" This is a multi-part message in MIME format... ------------=_1528835042-28672-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-= pull which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 31706@debbugs.gnu.org. --=20 31706: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31706 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1528835042-28672-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 31706-done) by debbugs.gnu.org; 12 Jun 2018 20:24:00 +0000 Received: from localhost ([127.0.0.1]:45413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSppf-0007SD-Qi for submit@debbugs.gnu.org; Tue, 12 Jun 2018 16:24:00 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:34503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSppe-0007S1-RL for 31706-done@debbugs.gnu.org; Tue, 12 Jun 2018 16:23:59 -0400 Received: by mail-wr0-f174.google.com with SMTP id a12-v6so344541wro.1 for <31706-done@debbugs.gnu.org>; Tue, 12 Jun 2018 13:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=aw0tV3JSt9WWY2EWB1hoXWxOLijEOXYfSBENV4b0Ngg=; b=BmNqi2EnlE2Frt/CrGSNQ8WV/cLqCwPdgTBbUG47H5eq904dPLun31dY7Lea4OmFR/ kfCvYAS5dqyeXs8xsZVvg4UUVggQ7Fy4WvidICqS8LpOW7DH7JLQ6/MqPutW+7uCRjF7 M8vgvwMSwY63DlAXiyDypr0mEpe0FdAH2/i206lj2WsW/IE5W4V/DRqPHbuoxMUvROMs wAZRjTKHbdhS+kCWVpU9cLGWI49aztI7Fuq+wMnkI64nT4Z3oQFpq4jwRT/TMLcG0NHX WaBCu/Y5btMpWkhHvVe0H+LUBSGxo0iO1OiBZavlcSbgUbtvEDEqkjebVjlZLjh5A9W3 QjyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=aw0tV3JSt9WWY2EWB1hoXWxOLijEOXYfSBENV4b0Ngg=; b=fnXApk9/FKDjGGEQ4K2gLftP9D9CM8kNB47GtZpP7f6fp/SeSw7I+29Zeq1NrCa0N/ g4nknAYhAlS1l1gf5MW6sRJYmNpacXx+ZSRAMU3Z2iV5cjGla8eGBTm0iZZ7ZhKhK2JB 0jkYbhFJw5NUVpABgoY+WMizohI6FCj6ZWkp4+iFZRUDS/W4dZkP1dRC0Q64srA4+Ag/ K42kaRBvBHLVMpK6AbFM+kYbwWke6xvBFH5nQJbco19jdx2KjS4P2BUuZi2GGpS8YzNc T5bFy+D4sQq/Gt/32H/aJtAY4nFfYOgvN/rS7IzPXZ3Q1rA5kP4pKdmv8y+xzLQNGGtT s8pQ== X-Gm-Message-State: APt69E1vvcp0ieCj+NZAFtVTm2+GsIXXsT6lwzCEa0TtJGzP0hR76gtw BExTqBRNv6RwAr1STQy2RedKhvf3 X-Google-Smtp-Source: ADUXVKJR57v4nv0zACbljiy4pUCWPOhgcRtEJFl7d2v8gjQ1R9kgHUCqpqAWDJiYmV8SvEmBmzwPDQ== X-Received: by 2002:adf:f712:: with SMTP id r18-v6mr1857887wrp.85.1528835033128; Tue, 12 Jun 2018 13:23:53 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-2050-339f-0e48-d89b.holly.idiocy.org. [2001:8b0:3f8:8129:2050:339f:e48:d89b]) by smtp.gmail.com with ESMTPSA id b74-v6sm1927037wmi.13.2018.06.12.13.23.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jun 2018 13:23:52 -0700 (PDT) Date: Tue, 12 Jun 2018 21:23:50 +0100 From: Alan Third To: Eli Zaretskii Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Message-ID: <20180612202350.GD889@breton.holly.idiocy.org> References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> <83wov9vl1c.fsf@gnu.org> <20180610153554.GA54205@breton.holly.idiocy.org> <8336xusjw1.fsf@gnu.org> <20180610201442.GA22241@breton.holly.idiocy.org> <83vaaqqcq3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83vaaqqcq3.fsf@gnu.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 31706-done Cc: van@scratch.space, 31706-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Mon, Jun 11, 2018 at 05:27:32AM +0300, Eli Zaretskii wrote: > > Date: Sun, 10 Jun 2018 21:14:42 +0100 > > From: Alan Third > > Cc: van@scratch.space, 31706@debbugs.gnu.org > > > > > Maybe we should simply backport both the above commit and its > > > predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53? > > > > They both apply cleanly to emacs-26. > > > > I wouldn’t have thought this was a big enough problem for Emacs 26.2, > > though? > > But the commits are quite safe, don't you think? And fix a > long-standing problem. So I see no reason not to backport. Yes, I think I was just misunderstanding the status of the emacs-26 branch. I’ve pushed them to emacs-26. -- Alan Third ------------=_1528835042-28672-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jun 2018 08:26:32 +0000 Received: from localhost ([127.0.0.1]:60830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPkoy-00078U-FV for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPkox-00078F-59 for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPkoq-0005VO-Vl for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPkoq-0005VE-SA for submit@debbugs.gnu.org; Mon, 04 Jun 2018 04:26:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPkop-0000XT-O8 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:26:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPkom-0005Qt-H1 for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:26:23 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55861) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPkom-0005On-AF for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 04:26:20 -0400 X-Originating-IP: 123.243.250.252 Received: from epi.local (123-243-250-252.tpgi.com.au [123.243.250.252]) (Authenticated sender: van@scratch.space) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3558360025 for ; Mon, 4 Jun 2018 10:26:16 +0200 (CEST) From: Van L Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Message-Id: Date: Mon, 4 Jun 2018 18:26:11 +1000 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Hello. After a vc-pull on a git directory, a vc-git buffer shows with links to = files that have changed. =E2=80=94 example Running "git pull"... =46rom git://github.com/apple/foundationdb ab5bfad..ce6a2f0 master -> origin/master Updating ab5bfad..ce6a2f0 Fast-forward fdbclient/CoordinationInterface.h | 2 +- fdbclient/DatabaseContext.h | 3 +- fdbclient/Knobs.cpp | 1 + fdbclient/Knobs.h | 1 + fdbclient/MasterProxyInterface.h | 2 +- fdbclient/MonitorLeader.actor.cpp | 84 = +++++++++++++++++++---------------- fdbclient/NativeAPI.actor.cpp | 17 ++++--- fdbclient/NativeAPI.h | 2 +- fdbclient/ReadYourWrites.h | 1 - fdbrpc/batcher.actor.h | 20 ++++++--- fdbserver/Knobs.cpp | 4 ++ fdbserver/Knobs.h | 4 ++ fdbserver/LeaderElection.actor.cpp | 30 ++++++------- fdbserver/MasterProxyServer.actor.cpp | 32 +++++++++---- fdbserver/fdbserver.actor.cpp | 7 ++- flow/error_definitions.h | 1 + flow/network.h | 1 + 17 files changed, 131 insertions(+), 81 deletions(-) =E2=80=94 end example Clicking on a link causes the ,system default open, to call the = operating system=E2=80=99s file manager to open that file. Expected desired behavior is that Emacs 26.1 simply visits the = ,flow/network.h, file (on event ,mouse-1: visit this file,) Trying to find the elisp function the mouse click calls, I do: 1. C-h k 2. 3. the echo area shows: mouse-1- if I click the mouse a second time I get the explanation for: = (mouse-drag-region START-EVENT) =46rom experience in Org Mode I know C-x customize ; search for ,org = app, ; you can set Emacs to be the default app for unrecognized files. After C-x customize, I search for A. git app B. vc app but there is no setting like `Org File Apps` to let Emacs open those = links in the vc-git buffer. =E2=80=94 (if '(you like avocado on toast) '(then you'll like Daniel Stone's "The Food Explorer".)) ------------=_1528835042-28672-1-- From unknown Tue Jun 17 22:27:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jun 2018 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Third Cc: van@scratch.space, 31706-done@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 31706-done@debbugs.gnu.org id=D31706.152885702011748 (code D ref 31706); Wed, 13 Jun 2018 02:31:02 +0000 Received: (at 31706-done) by debbugs.gnu.org; 13 Jun 2018 02:30:20 +0000 Received: from localhost ([127.0.0.1]:45595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSvYC-00033P-LG for submit@debbugs.gnu.org; Tue, 12 Jun 2018 22:30:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSvY9-00033B-Rd for 31706-done@debbugs.gnu.org; Tue, 12 Jun 2018 22:30:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSvY0-0003AY-6d for 31706-done@debbugs.gnu.org; Tue, 12 Jun 2018 22:30:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSvY0-0003AS-3F; Tue, 12 Jun 2018 22:30:08 -0400 Received: from [176.228.60.248] (port=4802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSvXz-0005mF-HU; Tue, 12 Jun 2018 22:30:07 -0400 Date: Wed, 13 Jun 2018 05:30:19 +0300 Message-Id: <83k1r34dvo.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <20180612202350.GD889@breton.holly.idiocy.org> (message from Alan Third on Tue, 12 Jun 2018 21:23:50 +0100) References: <834liiczyh.fsf@gnu.org> <890A98FF-63A7-4E46-8097-FA97D0EDF844@scratch.space> <83efhlb99h.fsf@gnu.org> <20180607205242.GA26012@breton.holly.idiocy.org> <83wov9vl1c.fsf@gnu.org> <20180610153554.GA54205@breton.holly.idiocy.org> <8336xusjw1.fsf@gnu.org> <20180610201442.GA22241@breton.holly.idiocy.org> <83vaaqqcq3.fsf@gnu.org> <20180612202350.GD889@breton.holly.idiocy.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Tue, 12 Jun 2018 21:23:50 +0100 > From: Alan Third > Cc: van@scratch.space, 31706-done@debbugs.gnu.org > > > But the commits are quite safe, don't you think? And fix a > > long-standing problem. So I see no reason not to backport. > > Yes, I think I was just misunderstanding the status of the emacs-26 > branch. > > I’ve pushed them to emacs-26. Thanks.