GNU bug report logs - #31706
Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull

Previous Next

Package: emacs;

Reported by: Van L <van <at> scratch.space>

Date: Mon, 4 Jun 2018 08:27:02 UTC

Severity: minor

Done: Alan Third <alan <at> idiocy.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31706 in the body.
You can then email your comments to 31706 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Mon, 04 Jun 2018 08:27:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Van L <van <at> scratch.space>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 04 Jun 2018 08:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratch.space>
To: bug-gnu-emacs <at> gnu.org
Subject: Emacs 26.1 unable to visit files in vc-git buffer's links after
 vc-pull
Date: Mon, 4 Jun 2018 18:26:11 +1000
Hello.

After a vc-pull on a git directory, a vc-git buffer shows with links to files that have changed.

— example
Running "git pull"...
From git://github.com/apple/foundationdb
   ab5bfad..ce6a2f0  master     -> origin/master
Updating ab5bfad..ce6a2f0
Fast-forward
 fdbclient/CoordinationInterface.h     |  2 +-
 fdbclient/DatabaseContext.h           |  3 +-
 fdbclient/Knobs.cpp                   |  1 +
 fdbclient/Knobs.h                     |  1 +
 fdbclient/MasterProxyInterface.h      |  2 +-
 fdbclient/MonitorLeader.actor.cpp     | 84 +++++++++++++++++++----------------
 fdbclient/NativeAPI.actor.cpp         | 17 ++++---
 fdbclient/NativeAPI.h                 |  2 +-
 fdbclient/ReadYourWrites.h            |  1 -
 fdbrpc/batcher.actor.h                | 20 ++++++---
 fdbserver/Knobs.cpp                   |  4 ++
 fdbserver/Knobs.h                     |  4 ++
 fdbserver/LeaderElection.actor.cpp    | 30 ++++++-------
 fdbserver/MasterProxyServer.actor.cpp | 32 +++++++++----
 fdbserver/fdbserver.actor.cpp         |  7 ++-
 flow/error_definitions.h              |  1 +
 flow/network.h                        |  1 +
 17 files changed, 131 insertions(+), 81 deletions(-)

— end example

Clicking on a link causes the ,system default open, to call the operating system’s file manager to open that file.

Expected desired behavior is that Emacs 26.1 simply visits the ,flow/network.h, file (on event ,mouse-1: visit this file,)

Trying to find the elisp function the mouse click calls, I do:

 1. C-h k
 2. <mouse click on ,flow/network.h,>
 3. the echo area shows: mouse-1-

if I click the mouse a second time I get the explanation for: (mouse-drag-region START-EVENT)

From experience in Org Mode I know C-x customize ; search for ,org app, ; you can set Emacs to be the default app for unrecognized files.

After C-x customize, I search for

 A. git app
 B. vc app

but there is no setting like `Org File Apps` to let Emacs open those links in the vc-git buffer.



—
(if '(you like avocado on toast)
    '(then you'll like Daniel Stone's "The Food Explorer".))





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Mon, 04 Jun 2018 08:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratch.space>
To: 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Acknowledgement (Emacs 26.1 unable to visit files in
 vc-git buffer's links after vc-pull)
Date: Mon, 4 Jun 2018 18:49:18 +1000
> If you wish to submit further information on this problem, please
> send it to 31706 <at> debbugs.gnu.org.

Running `emacs -Q` also presents the problem of being unable to click to open file in Emacs after vc-pull.

Clicking on link for lisp/org-src.el does not open the file in Emacs, in the following example of vc-git buffer.

— example
Running "git pull"...
From https://code.orgmode.org/bzg/org-mode
   cbb48611e..ed7d1dc6d  master     -> origin/master
   c9d49a40e..164862778  emacs-sync -> origin/emacs-sync
   388254e0d..8fbdf0ce1  maint      -> origin/maint
 * [new branch]          next       -> origin/next
 * [new branch]          org-tempo  -> origin/org-tempo
 * [new tag]             release_9.1.13 -> release_9.1.13
Updating cbb48611e..ed7d1dc6d
Fast-forward
 .dir-locals.el                      |    10 +-
 .gitignore                          |     1 +
 contrib/lisp/ob-clojure-literate.el |    15 +-
 doc/Documentation_Standards.org     |     4 +-
 doc/Makefile                        |     6 +
 doc/org-manual.org                  |   538 +-
 doc/org.texi                        | 21806 ----------------------------------
 doc/orgguide.texi                   |    10 +-
 etc/ORG-NEWS                        |     2 +-
 lisp/ob-C.el                        |     8 +-
 lisp/ob-J.el                        |     2 +-
 lisp/ob-calc.el                     |     2 +-
 lisp/ob-clojure.el                  |     2 +-
 lisp/ob-comint.el                   |     2 +-
 lisp/ob-core.el                     |    15 +-
 lisp/ob-exp.el                      |     3 +-
 lisp/ob-forth.el                    |     2 +-
 lisp/ob-fortran.el                  |     5 +-
 lisp/ob-gnuplot.el                  |     2 +-
 lisp/ob-haskell.el                  |     3 +-
 lisp/ob-js.el                       |    10 +-
 lisp/ob-latex.el                    |     2 +-
 lisp/ob-lisp.el                     |     2 +-
 lisp/ob-lua.el                      |     7 +-
 lisp/ob-ocaml.el                    |     2 +-
 lisp/ob-octave.el                   |     8 +-
 lisp/ob-python.el                   |     7 +-
 lisp/ob-ref.el                      |     2 +-
 lisp/ob-ruby.el                     |     2 +-
 lisp/ob-scheme.el                   |     7 +-
 lisp/ob-shell.el                    |     2 +-
 lisp/ob-table.el                    |     3 +-
 lisp/ob-tangle.el                   |     6 +-
 lisp/ob-vala.el                     |     3 +-
 lisp/org-agenda.el                  |   686 +-
 lisp/org-capture.el                 |    55 +-
 lisp/org-clock.el                   |     2 +-
 lisp/org-colview.el                 |     6 +-
 lisp/org-compat.el                  |    34 +-
 lisp/org-element.el                 |    12 +-
 lisp/org-entities.el                |    10 +-
 lisp/org-eshell.el                  |     2 +-
 lisp/org-feed.el                    |     2 +-
 lisp/org-footnote.el                |    17 +-
 lisp/org-goto.el                    |     4 +-
 lisp/org-indent.el                  |     2 +-
 lisp/org-lint.el                    |    13 +-
 lisp/org-list.el                    |    53 +-
 lisp/org-macs.el                    |    58 +-
 lisp/org-pcomplete.el               |    22 +-
 lisp/org-protocol.el                |    20 +-
 lisp/org-src.el                     |   133 +-
 lisp/org-table.el                   |    96 +-
 lisp/org-tempo.el                   |     2 +
 lisp/org-w3m.el                     |    18 +-
 lisp/org.el                         |   326 +-
 lisp/ox-beamer.el                   |     9 +-
 lisp/ox-html.el                     |    50 +-
 lisp/ox-publish.el                  |     2 +-
 lisp/ox-texinfo.el                  |    13 +-
 lisp/ox.el                          |     2 +-
 mk/org-fixup.el                     |     7 +
 testing/README                      |     2 +-
 testing/lisp/test-ob-lob.el         |     4 +-
 testing/lisp/test-ob.el             |     4 +-
 testing/lisp/test-org-agenda.el     |     3 +-
 testing/lisp/test-org-attach.el     |    19 +-
 testing/lisp/test-org-capture.el    |    16 +
 testing/lisp/test-org-element.el    |     4 +-
 testing/lisp/test-org-lint.el       |    12 +
 testing/lisp/test-org-list.el       |   102 +-
 testing/lisp/test-org-timer.el      |     6 +-
 testing/lisp/test-org.el            |    31 +-
 73 files changed, 1358 insertions(+), 23002 deletions(-)
 delete mode 100644 doc/org.texi

— end example

Version: emacs 26.1, NS port

—
(if '(you like avocado on toast)
    '(then you'll like Daniel Stone's "The Food Explorer".))





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Mon, 04 Jun 2018 15:52:01 GMT) Full text and rfc822 format available.

Message #11 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Van L <van <at> scratch.space>
Cc: 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Mon, 04 Jun 2018 18:51:18 +0300
> From: Van L <van <at> scratch.space>
> Date: Mon, 4 Jun 2018 18:26:11 +1000
> 
> After a vc-pull on a git directory, a vc-git buffer shows with links to files that have changed.
> 
> — example
> Running "git pull"...
> From git://github.com/apple/foundationdb
>    ab5bfad..ce6a2f0  master     -> origin/master
> Updating ab5bfad..ce6a2f0
> Fast-forward
>  fdbclient/CoordinationInterface.h     |  2 +-
>  fdbclient/DatabaseContext.h           |  3 +-
>  fdbclient/Knobs.cpp                   |  1 +
>  fdbclient/Knobs.h                     |  1 +
>  fdbclient/MasterProxyInterface.h      |  2 +-
>  fdbclient/MonitorLeader.actor.cpp     | 84 +++++++++++++++++++----------------
>  fdbclient/NativeAPI.actor.cpp         | 17 ++++---
>  fdbclient/NativeAPI.h                 |  2 +-
>  fdbclient/ReadYourWrites.h            |  1 -
>  fdbrpc/batcher.actor.h                | 20 ++++++---
>  fdbserver/Knobs.cpp                   |  4 ++
>  fdbserver/Knobs.h                     |  4 ++
>  fdbserver/LeaderElection.actor.cpp    | 30 ++++++-------
>  fdbserver/MasterProxyServer.actor.cpp | 32 +++++++++----
>  fdbserver/fdbserver.actor.cpp         |  7 ++-
>  flow/error_definitions.h              |  1 +
>  flow/network.h                        |  1 +
>  17 files changed, 131 insertions(+), 81 deletions(-)
> 
> — end example
> 
> Clicking on a link causes the ,system default open, to call the operating system’s file manager to open that file.
> 
> Expected desired behavior is that Emacs 26.1 simply visits the ,flow/network.h, file (on event ,mouse-1: visit this file,)

I cannot reproduce this.  I get exactly the behavior you expect.
Could be some problem specific to your platform (which is what, btw?).

> Trying to find the elisp function the mouse click calls, I do:
> 
>  1. C-h k
>  2. <mouse click on ,flow/network.h,>
>  3. the echo area shows: mouse-1-
> 
> if I click the mouse a second time I get the explanation for: (mouse-drag-region START-EVENT)

Try "M-x describe-text-properties RET" with point on one of the links.
(I guess "C-h k" needs to be extended to be smarter in this case.)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Tue, 05 Jun 2018 03:45:01 GMT) Full text and rfc822 format available.

Message #14 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratch.space>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Tue, 5 Jun 2018 13:43:56 +1000
> Eli Zaretskii writes:
> 
> Could be some problem specific to your platform (which is what, btw?).

GNU Emacs 26.1 
NS port macos

"GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G19009))
 of 2018-06-02"

> Try "M-x describe-text-properties RET" with point on one of the links.


In the example below, 
I invoked `emacs -Q`, 
then vc-pull, 
in the vc-git buffer, 
I leave point on the O in etc/HISTORY link, 
and `M-x describe-text-properties RET` produces the following result:

— result
Text content at position 1812:


There are text properties here:
  compilation-message  [Show]
  font-lock-face       (compilation-info underline)
  fontified            t
  help-echo            "mouse-2: visit this file"
  keymap               compilation-button-map
  mouse-face           highlight

— end result


The hover over the link label shows ,mouse-1: visit this file,

(On right-handed mouse) left or middle mouse button click on 
the O in etc/HISTORY link 
causes the macos Finder file manager to present window for choosing a file to open.

Expected, desired behavior is for Emacs 26.1 to visit file in new buffer.

— example

Running "git pull"...
From git://git.sv.gnu.org/emacs
   58d0642e1c..1dafa4a02e  master     -> origin/master
   b8e7749b33..55c9bb9f3c  emacs-26   -> origin/emacs-26
 * [new branch]            scratch/np/backports-26.2 -> origin/scratch/np/backports-26.2
 * [new branch]            scratch/support-plists-in-jsonc-autodetect -> origin/scratch/support-plists-in-jsonc-autodetect
Updating cc130d13d4..1dafa4a02e
Fast-forward
 ChangeLog.3                            | 525 +++++++++++++++++-
 admin/authors.el                       |   2 +-
 admin/notes/multi-tty                  |   2 +-
 configure.ac                           |   9 +-
 doc/emacs/files.texi                   |   9 +-
 doc/emacs/macos.texi                   |   4 +-
 doc/emacs/misc.texi                    |   2 +-
 doc/emacs/msdos.texi                   |   2 +-
 doc/lispintro/emacs-lisp-intro.texi    | 124 +++--
 doc/lispref/buffers.texi               |  22 +-
 doc/lispref/control.texi               | 967 ++++++++++++++++++++++++++-------
 doc/lispref/display.texi               |   2 +-
 doc/lispref/elisp.texi                 |   5 +-
 doc/lispref/errors.texi                |   2 +-
 doc/lispref/files.texi                 |  18 +-
 doc/lispref/searching.texi             |   2 +
 doc/lispref/streams.texi               |  15 +
 doc/lispref/syntax.texi                |  12 +-
 doc/lispref/text.texi                  |   7 +-
 doc/misc/autotype.texi                 |   2 +-
 doc/misc/emacs-mime.texi               |   2 +-
 doc/misc/org.texi                      |   4 +-
 doc/misc/tramp.texi                    | 187 +++++--
 doc/misc/viper.texi                    |   2 +-
 doc/misc/wisent.texi                   |   2 +-
 etc/AUTHORS                            | 141 +++--
 etc/HELLO                              |  15 +-
 etc/HISTORY                            |   2 +
 etc/NEWS                               |  29 +
 etc/NEWS.26                            |  45 ++
 etc/PROBLEMS                           |  12 +-
 lisp/emacs-lisp/cl-macs.el             |   8 +-
 lisp/emacs-lisp/cl-print.el            | 115 ++--
 lisp/emacs-lisp/eieio.el               |   8 +-
 lisp/emacs-lisp/pcase.el               | 143 ++---
 lisp/emacs-lisp/radix-tree.el          |   2 +
 lisp/emacs-lisp/rmc.el                 |  18 +-
 lisp/emacs-lisp/rx.el                  |  20 +-
 lisp/epa-file.el                       |   2 -
 lisp/epa-mail.el                       |   4 +-
 lisp/epa.el                            |  57 +-
 lisp/epg-config.el                     |  29 +-
 lisp/epg.el                            | 120 +---
 lisp/files.el                          | 227 ++++----
 lisp/frame.el                          |   3 +
 lisp/gnus/message.el                   |   4 +-
 lisp/help.el                           |   4 +-
 lisp/hexl.el                           |  14 +-
 lisp/image.el                          |   1 +
 lisp/ldefs-boot.el                     | 135 +++--
 lisp/net/tramp-adb.el                  |   9 +-
 lisp/net/tramp-cache.el                |   6 +-
 lisp/net/tramp-gvfs.el                 |  48 +-
 lisp/net/tramp-sh.el                   |  50 +-
 lisp/net/tramp-smb.el                  |  24 +-
 lisp/net/tramp.el                      | 145 ++---
 lisp/newcomment.el                     |   5 +-
 lisp/progmodes/cc-mode.el              |  41 +-
 lisp/progmodes/flymake-cc.el           | 140 +++++
 lisp/progmodes/gud.el                  |   7 +-
 lisp/progmodes/sql.el                  | 272 +++++++---
 lisp/replace.el                        |   7 +-
 lisp/subr.el                           |   7 +-
 lisp/term.el                           |  68 ++-
 lisp/term/ns-win.el                    |   4 +
 lisp/textmodes/bibtex.el               |  41 +-
 lisp/textmodes/css-mode.el             |  66 ++-
 src/.gdbinit                           |   2 +-
 src/Makefile.in                        |   5 +
 src/dired.c                            |   9 +-
 src/emacs.c                            |   2 +-
 src/filelock.c                         |   5 +-
 src/gtkutil.c                          |   4 +-
 src/image.c                            |   2 +-
 src/nsterm.m                           |  30 +-
 src/print.c                            |  11 +-
 src/search.c                           |   5 +-
 src/w32.c                              | 291 ++++++++++
 src/w32.h                              |   2 +
 src/w32fns.c                           |  81 +++
 src/xdisp.c                            |   7 +-
 src/xterm.c                            |  12 +-
 test/lisp/emacs-lisp/cl-print-tests.el |  25 +
 test/lisp/files-tests.el               | 489 ++++++++++++++---
 test/lisp/net/tramp-tests.el           |  21 +-
 test/lisp/replace-tests.el             | 119 ++--
 test/lisp/term-tests.el                |   7 +
 test/lisp/textmodes/css-mode-tests.el  |  15 +-
 test/src/print-tests.el                |  36 ++
 89 files changed, 3858 insertions(+), 1350 deletions(-)
 create mode 100644 lisp/progmodes/flymake-cc.el


— end example



Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Tue, 05 Jun 2018 14:26:01 GMT) Full text and rfc822 format available.

Message #17 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Van L <van <at> scratch.space>
Cc: 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Tue, 05 Jun 2018 17:25:30 +0300
> From: Van L <van <at> scratch.space>
> Date: Tue, 5 Jun 2018 13:43:56 +1000
> Cc: 31706 <at> debbugs.gnu.org
> 
> > Could be some problem specific to your platform (which is what, btw?).
> 
> GNU Emacs 26.1 
> NS port macos
> 
> "GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G19009))
>  of 2018-06-02"

So it could be something specific to NS.  Can someone with access to
NS port please try reproducing this?

> > Try "M-x describe-text-properties RET" with point on one of the links.
> [...]
> There are text properties here:
>   compilation-message  [Show]
>   font-lock-face       (compilation-info underline)
>   fontified            t
>   help-echo            "mouse-2: visit this file"
>   keymap               compilation-button-map
>   mouse-face           highlight

This tells you that the binding to be looked for is in
compilation-button-map.

> The hover over the link label shows ,mouse-1: visit this file,

Yes, that's a feature that mouse-2 in the help-echo is replaced with
mouse-1.

> Expected, desired behavior is for Emacs 26.1 to visit file in new buffer.

Yes, and that's what I get on my system.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Tue, 05 Jun 2018 15:08:01 GMT) Full text and rfc822 format available.

Message #20 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratch.space>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Wed, 6 Jun 2018 01:07:24 +1000
> Eli Zaretskii writes:
> 
> So it could be something specific to NS.  Can someone with access to
> NS port please try reproducing this?

I had this problem in org mode for org store/insert link to file which was solved by the following. 

— quote

 '(org-file-apps
   (quote
    ((auto-mode . emacs)
     ("\\.mm\\'" . default)
     ("\\.x?html?\\'" . default)
     ("\\.pdf\\'" . default)
     (t . emacs))))            ; This tells Emacs to open any unrecognized file.

— end quote






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Thu, 07 Jun 2018 20:53:01 GMT) Full text and rfc822 format available.

Message #23 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Van L <van <at> scratch.space>, 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Thu, 7 Jun 2018 21:52:42 +0100
On Tue, Jun 05, 2018 at 05:25:30PM +0300, Eli Zaretskii wrote:
> > From: Van L <van <at> scratch.space>
> > Date: Tue, 5 Jun 2018 13:43:56 +1000
> > Cc: 31706 <at> debbugs.gnu.org
> > 
> > > Could be some problem specific to your platform (which is what, btw?).
> > 
> > GNU Emacs 26.1 
> > NS port macos
> > 
> > "GNU Emacs 26.1 (build 1, x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G19009))
> >  of 2018-06-02"
> 
> So it could be something specific to NS.  Can someone with access to
> NS port please try reproducing this?

I can reproduce this on Emacs 25, and all versions of Emacs 26 that I
tried, but not on master.
-- 
Alan Third




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Fri, 08 Jun 2018 06:41:01 GMT) Full text and rfc822 format available.

Message #26 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Fri, 08 Jun 2018 09:39:59 +0300
> Date: Thu, 7 Jun 2018 21:52:42 +0100
> From: Alan Third <alan <at> idiocy.org>
> Cc: Van L <van <at> scratch.space>, 31706 <at> debbugs.gnu.org
> 
> > So it could be something specific to NS.  Can someone with access to
> > NS port please try reproducing this?
> 
> I can reproduce this on Emacs 25, and all versions of Emacs 26 that I
> tried, but not on master.

Thanks.  Do you have an idea why it happens and what change on master
fixed it?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Sun, 10 Jun 2018 15:37:02 GMT) Full text and rfc822 format available.

Message #29 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Sun, 10 Jun 2018 16:35:54 +0100
On Fri, Jun 08, 2018 at 09:39:59AM +0300, Eli Zaretskii wrote:
> > Date: Thu, 7 Jun 2018 21:52:42 +0100
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: Van L <van <at> scratch.space>, 31706 <at> debbugs.gnu.org
> > 
> > > So it could be something specific to NS.  Can someone with access to
> > > NS port please try reproducing this?
> > 
> > I can reproduce this on Emacs 25, and all versions of Emacs 26 that I
> > tried, but not on master.
> 
> Thanks.  Do you have an idea why it happens and what change on master
> fixed it?

It’s commit 5ea5b2536ef580fe4b17b6dbd62df90d51e73e5f. I don’t
understand why, though.
-- 
Alan Third




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Sun, 10 Jun 2018 16:10:01 GMT) Full text and rfc822 format available.

Message #32 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Sun, 10 Jun 2018 19:09:50 +0300
> Date: Sun, 10 Jun 2018 16:35:54 +0100
> From: Alan Third <alan <at> idiocy.org>
> Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
> 
> > Thanks.  Do you have an idea why it happens and what change on master
> > fixed it?
> 
> It’s commit 5ea5b2536ef580fe4b17b6dbd62df90d51e73e5f. I don’t
> understand why, though.

I presume just the vc-git part of that fixes the bug?

Maybe we should simply backport both the above commit and its
predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Sun, 10 Jun 2018 20:15:01 GMT) Full text and rfc822 format available.

Message #35 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Sun, 10 Jun 2018 21:14:42 +0100
On Sun, Jun 10, 2018 at 07:09:50PM +0300, Eli Zaretskii wrote:
> > Date: Sun, 10 Jun 2018 16:35:54 +0100
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
> > 
> > > Thanks.  Do you have an idea why it happens and what change on master
> > > fixed it?
> > 
> > It’s commit 5ea5b2536ef580fe4b17b6dbd62df90d51e73e5f. I don’t
> > understand why, though.
> 
> I presume just the vc-git part of that fixes the bug?
> 
> Maybe we should simply backport both the above commit and its
> predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53?

They both apply cleanly to emacs-26.

I wouldn’t have thought this was a big enough problem for Emacs 26.2,
though?
-- 
Alan Third




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Mon, 11 Jun 2018 02:28:02 GMT) Full text and rfc822 format available.

Message #38 received at 31706 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Mon, 11 Jun 2018 05:27:32 +0300
> Date: Sun, 10 Jun 2018 21:14:42 +0100
> From: Alan Third <alan <at> idiocy.org>
> Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
> 
> > Maybe we should simply backport both the above commit and its
> > predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53?
> 
> They both apply cleanly to emacs-26.
> 
> I wouldn’t have thought this was a big enough problem for Emacs 26.2,
> though?

But the commits are quite safe, don't you think?  And fix a
long-standing problem.  So I see no reason not to backport.




Reply sent to Alan Third <alan <at> idiocy.org>:
You have taken responsibility. (Tue, 12 Jun 2018 20:24:02 GMT) Full text and rfc822 format available.

Notification sent to Van L <van <at> scratch.space>:
bug acknowledged by developer. (Tue, 12 Jun 2018 20:24:02 GMT) Full text and rfc822 format available.

Message #43 received at 31706-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: van <at> scratch.space, 31706-done <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Tue, 12 Jun 2018 21:23:50 +0100
On Mon, Jun 11, 2018 at 05:27:32AM +0300, Eli Zaretskii wrote:
> > Date: Sun, 10 Jun 2018 21:14:42 +0100
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: van <at> scratch.space, 31706 <at> debbugs.gnu.org
> > 
> > > Maybe we should simply backport both the above commit and its
> > > predecessor 8f36155e8f83164c6aec98a5d1d475f28b513b53?
> > 
> > They both apply cleanly to emacs-26.
> > 
> > I wouldn’t have thought this was a big enough problem for Emacs 26.2,
> > though?
> 
> But the commits are quite safe, don't you think?  And fix a
> long-standing problem.  So I see no reason not to backport.

Yes, I think I was just misunderstanding the status of the emacs-26
branch.

I’ve pushed them to emacs-26.
-- 
Alan Third




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#31706; Package emacs. (Wed, 13 Jun 2018 02:31:02 GMT) Full text and rfc822 format available.

Message #46 received at 31706-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: van <at> scratch.space, 31706-done <at> debbugs.gnu.org
Subject: Re: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's
 links after vc-pull
Date: Wed, 13 Jun 2018 05:30:19 +0300
> Date: Tue, 12 Jun 2018 21:23:50 +0100
> From: Alan Third <alan <at> idiocy.org>
> Cc: van <at> scratch.space, 31706-done <at> debbugs.gnu.org
> 
> > But the commits are quite safe, don't you think?  And fix a
> > long-standing problem.  So I see no reason not to backport.
> 
> Yes, I think I was just misunderstanding the status of the emacs-26
> branch.
> 
> I’ve pushed them to emacs-26.

Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 11 Jul 2018 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 341 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.