From unknown Sat Aug 16 18:46:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31699 <31699@debbugs.gnu.org> To: bug#31699 <31699@debbugs.gnu.org> Subject: Status: 26.1.50; find-face-definition defaults to non-face symbol Reply-To: bug#31699 <31699@debbugs.gnu.org> Date: Sun, 17 Aug 2025 01:46:21 +0000 retitle 31699 26.1.50; find-face-definition defaults to non-face symbol reassign 31699 emacs submitter 31699 "Basil L. Contovounesios" severity 31699 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 03 14:32:55 2018 Received: (at submit) by debbugs.gnu.org; 3 Jun 2018 18:32:55 +0000 Received: from localhost ([127.0.0.1]:60542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXoF-00008O-0X for submit@debbugs.gnu.org; Sun, 03 Jun 2018 14:32:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXoD-000089-Ob for submit@debbugs.gnu.org; Sun, 03 Jun 2018 14:32:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPXo7-0003LU-RQ for submit@debbugs.gnu.org; Sun, 03 Jun 2018 14:32:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fPXo7-0003LN-OK for submit@debbugs.gnu.org; Sun, 03 Jun 2018 14:32:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPXo6-0000nU-NE for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:32:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPXo2-0003J2-4x for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:32:46 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:50368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPXo1-0003Ii-TK for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:32:42 -0400 Received: by mail-wm0-x232.google.com with SMTP id t11-v6so11418702wmt.0 for ; Sun, 03 Jun 2018 11:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=pcO8hkBv0P5buwhILSBBvrkoMggUeMf+h8vKocvsdwU=; b=nzjocyvqaswiCau+5WD033iCKSj82zgleGYzw9dALRb7sRTriUvekYGFS/KJgtQ3NI mZOY1+zKbSgjtLoMZYDqTk8juk9gnmyW+3R0jeOv3ADRjFQWCbzqYivUKZm8tuSWF5Ln 7M5ZuiKazTvL+aS20/ODuzdSV4eLTG6AosANRjeJLtvnk9QOK4dMdxPdLsuYid9Utmp9 yic+RjvEVXQWvbeBpti2DfdwbcCwANN6gZXj1f37/M9ixNCyggK4iibfqYopdUgyTW0n J/4s0xApZfc2q+rrDQOzAvqvCrtxoreYassN/y7cECm6zx2V0TQf5+hzBiyCxfPpGffE +xCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=pcO8hkBv0P5buwhILSBBvrkoMggUeMf+h8vKocvsdwU=; b=Fngn/ChFbcVxFWo4fmU6YaUlylIEbWx/d5EUdeOqwJWspOp+YhPsZhw8hdMcWQtbzG Vo3+LpNbZop+q9pM/q8EFVAzy0MN7ns8WH+rKlXGI3/SptIjW6JxODMbrN3M6Q0QEMnJ DB7NadV4SXoqIkNv1ZYBIMxcSG5xujUpskcDMFtzToXCXGrNOyudGALsQKMORCt0T2by rBI6Jd7XsnQh/erzniV4u4kIT6Dy/XmCsdAedXpCSShKM+HAl5T22eFTasTbO0YXB0u2 L5tTYUSGRtoTJH3WLhwK7FOtjt2YMOIwAMCgt7RHFeQZmxItF7/+3O2wfVX743rGIzFU O4Rw== X-Gm-Message-State: APt69E3i6hsUBUj+7Yd6fQOwFnPv1CmSYZCcg8PreWQ5RMJecxuLk5NM aH5EdRFKCzlvPoFRgPLYCXdVt5o0 X-Google-Smtp-Source: ADUXVKL8zBKtVx1K6NyQ86vu15fmD+GhLzYS0LDGJ4GfL4SVsNyZZK+VsSzEByJFLN3Exbfp30qShQ== X-Received: by 2002:a50:b003:: with SMTP id i3-v6mr5075661edd.293.1528050760573; Sun, 03 Jun 2018 11:32:40 -0700 (PDT) Received: from localhost ([213.233.149.4]) by smtp.gmail.com with ESMTPSA id x3-v6sm20110648eda.55.2018.06.03.11.32.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jun 2018 11:32:39 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 26.1.50; find-face-definition defaults to non-face symbol Date: Sun, 03 Jun 2018 19:32:38 +0100 Message-ID: <87fu23ra9l.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) The following: 1. emacs -Q 2. M-: (insert "major-mode") RET 3. M-x find-face-definition RET RET results in the following *Messages* line: find-function-search-for-symbol: Don=E2=80=99t know where =E2=80=98major-mode=E2=80=99 is defined This is due to find-function-read using (variable-at-point t) instead of (face-at-point t) to calculate the default completion candidate, even when given an argument of 'defface. Patch to follow. Thanks, --=20 Basil In GNU Emacs 26.1.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll= bars) of 2018-06-03 built on thunk Repository revision: 16e8541b743a6beb1926fef53cf1bfaed9c346db Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux testing (buster) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 03 14:39:46 2018 Received: (at 31699) by debbugs.gnu.org; 3 Jun 2018 18:39:46 +0000 Received: from localhost ([127.0.0.1]:60547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXur-0000IH-Pv for submit@debbugs.gnu.org; Sun, 03 Jun 2018 14:39:45 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXup-0000I1-Mv for 31699@debbugs.gnu.org; Sun, 03 Jun 2018 14:39:44 -0400 Received: by mail-wm0-f41.google.com with SMTP id z6-v6so11484260wma.0 for <31699@debbugs.gnu.org>; Sun, 03 Jun 2018 11:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=qsTRfo6vRvI8ISOyXrWnMmfi7UnY8An5Vt3utSXJ9n4=; b=uUUdfDIl6IBZOOSmn1DgJoyivW2kHpLb9I9TBuAEqLbRf8GbaZkKsnlayWVGzWFkTg CQ3DY85bMxU0EffQg5u+ScNYctG+sFqcFwXV2UZZfEzOdJEMt0d3Byvb/GCMoUTnVI8v uMbdSdOXOYykMW1lV/SxB6dEzEBm9qM+ktt0SMfhceLjXellmQZuvFy3cqLMBHDfuKIC 76Zi5TvMwjF2+fmfTeTnQ+5D9egrWA4mSnfhvOtlGZCD4HPr5mT738lAr5tVMyQNtI2g 6/H0+0VGFT4k3SD/yT0GLmDki6EAgAMKmr4I7TKa5YS3CxxbW4mdNFoenZWw3a/LS9pN snFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qsTRfo6vRvI8ISOyXrWnMmfi7UnY8An5Vt3utSXJ9n4=; b=dZdva6/N3atWDdjPxo4OnhB8QaU1xsDx9Fup4qmYNLsNc2meNTDwTtnKNRYr7b/D4O Xfy8GD1b7IzLop8yXlt9JNdew+30NhKargZWWrUsrtiSGKAncGLHhPonp8xubnV1GavK 8RiWvc5hFlgwyl6QDh9+ofbpLgBJFPG1EmNYkGcTa2MYUsNqvAFLWw2ez56Dt/1lgFzz UCZehkHQbLMTpHl+0FkIKXtLkOYZsrtXCRwb1/+5Z2dhE39knuKdnprNT6hsZZ9j3559 7v4R22+6PyQ5ztf4nvj2AwQPZsRAOMmK9EAqBBBr02G6rxot27bx+U6F5Ash6JdZbbUg vz1Q== X-Gm-Message-State: ALKqPwdd3z0Dl4uJ8Yk43fTWnWTITF+GmLTPpDT0bbL+GuTcL/iBmF8J 4TitWodSgbOq38ThymvO8n65f7DW X-Google-Smtp-Source: ADUXVKLlp/daKh3aCrL9CY/EPH9ZoPXO8kI1PhHshV9yjCLKNElr/uFRN+QUu2qXpK8aoJ4zAt6xJA== X-Received: by 2002:a50:8c44:: with SMTP id p62-v6mr20949048edp.38.1528051176604; Sun, 03 Jun 2018 11:39:36 -0700 (PDT) Received: from localhost ([213.233.149.2]) by smtp.gmail.com with ESMTPSA id o25-v6sm23998223edq.62.2018.06.03.11.39.35 for <31699@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jun 2018 11:39:35 -0700 (PDT) From: "Basil L. Contovounesios" To: 31699@debbugs.gnu.org Subject: Re: bug#31699: 26.1.50; find-face-definition defaults to non-face symbol References: <87fu23ra9l.fsf@tcd.ie> Date: Sun, 03 Jun 2018 19:39:34 +0100 In-Reply-To: <87fu23ra9l.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 03 Jun 2018 19:32:38 +0100") Message-ID: <87bmcrr9y1.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31699 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Patch to follow. As promised: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-default-candidate-of-find-face-definition.patch >From e129903ed87acedcadef203711b597a880ac36e0 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sun, 3 Jun 2018 19:34:37 +0100 Subject: [PATCH] Fix default candidate of find-face-definition * lisp/emacs-lisp/find-func.el (find-function-read): Use face-at-point instead of variable-at-point for faces. (bug#31699) --- lisp/emacs-lisp/find-func.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index ed8dc74506..13bbd9a7ec 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -464,6 +464,7 @@ find-function-read otherwise uses `variable-at-point'." (let* ((symb1 (cond ((null type) (function-called-at-point)) ((eq type 'defvar) (variable-at-point)) + ((eq type 'defface) (face-at-point t)) (t (variable-at-point t)))) (symb (unless (eq symb1 0) symb1)) (predicate (cdr (assq type '((nil . fboundp) -- 2.17.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 09 02:57:43 2018 Received: (at 31699-done) by debbugs.gnu.org; 9 Jun 2018 06:57:43 +0000 Received: from localhost ([127.0.0.1]:40251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXol-0008NH-6o for submit@debbugs.gnu.org; Sat, 09 Jun 2018 02:57:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRXoj-0008N5-PQ for 31699-done@debbugs.gnu.org; Sat, 09 Jun 2018 02:57:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRXob-0008IZ-Cn for 31699-done@debbugs.gnu.org; Sat, 09 Jun 2018 02:57:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRXob-0008IV-A9; Sat, 09 Jun 2018 02:57:33 -0400 Received: from [176.228.60.248] (port=2553 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRXoa-0008B5-CP; Sat, 09 Jun 2018 02:57:32 -0400 Date: Sat, 09 Jun 2018 09:57:34 +0300 Message-Id: <83d0x0tpk1.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-reply-to: <87bmcrr9y1.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#31699: 26.1.50; find-face-definition defaults to non-face symbol References: <87fu23ra9l.fsf@tcd.ie> <87bmcrr9y1.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31699-done Cc: 31699-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: "Basil L. Contovounesios" > Date: Sun, 03 Jun 2018 19:39:34 +0100 > > "Basil L. Contovounesios" writes: > > > Patch to follow. > > As promised: Thanks, pushed to the master branch. From unknown Sat Aug 16 18:46:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Jul 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator