GNU bug report logs - #31699
26.1.50; find-face-definition defaults to non-face symbol

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31699 in the body.
You can then email your comments to 31699 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1.50; find-face-definition defaults to non-face symbol
Date: Sun, 03 Jun 2018 19:32:38 +0100

The following:

1. emacs -Q
2. M-: (insert "major-mode") RET
3. M-x find-face-definition RET RET

results in the following *Messages* line:

  find-function-search-for-symbol:
    Don’t know where ‘major-mode’ is defined

This is due to find-function-read using (variable-at-point t) instead of
(face-at-point t) to calculate the default completion candidate, even
when given an argument of 'defface.

Patch to follow.

Thanks,

-- 
Basil

In GNU Emacs 26.1.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-06-03 built on thunk
Repository revision: 16e8541b743a6beb1926fef53cf1bfaed9c346db
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description:	Debian GNU/Linux testing (buster)

Message #8 received at 31699 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 31699 <at> debbugs.gnu.org
Subject: Re: bug#31699: 26.1.50;
 find-face-definition defaults to non-face symbol
Date: Sun, 03 Jun 2018 19:39:34 +0100

[Message part 1 (text/plain, inline)]

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Patch to follow.

As promised:

[0001-Fix-default-candidate-of-find-face-definition.patch (text/x-diff, inline)]

From e129903ed87acedcadef203711b597a880ac36e0 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Date: Sun, 3 Jun 2018 19:34:37 +0100
Subject: [PATCH] Fix default candidate of find-face-definition

* lisp/emacs-lisp/find-func.el (find-function-read): Use
face-at-point instead of variable-at-point for faces. (bug#31699)
---
 lisp/emacs-lisp/find-func.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index ed8dc74506..13bbd9a7ec 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -464,6 +464,7 @@ find-function-read
 otherwise uses `variable-at-point'."
   (let* ((symb1 (cond ((null type) (function-called-at-point))
                       ((eq type 'defvar) (variable-at-point))
+                      ((eq type 'defface) (face-at-point t))
                       (t (variable-at-point t))))
          (symb  (unless (eq symb1 0) symb1))
          (predicate (cdr (assq type '((nil . fboundp)
-- 
2.17.1

[Message part 3 (text/plain, inline)]

Thanks,

-- 
Basil

Message #13 received at 31699-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 31699-done <at> debbugs.gnu.org
Subject: Re: bug#31699: 26.1.50;
 find-face-definition defaults to non-face symbol
Date: Sat, 09 Jun 2018 09:57:34 +0300

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Date: Sun, 03 Jun 2018 19:39:34 +0100
> 
> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
> 
> > Patch to follow.
> 
> As promised:

Thanks, pushed to the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.