GNU bug report logs - #31696
27.0.50; dotimes-with-progress-reporter: Polimorphic 2nd argument

Previous Next

Full log

Message #22 received at 31696-done <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 31696-done <at> debbugs.gnu.org
Subject: Re: bug#31696: 27.0.50;
 dotimes-with-progress-reporter: Polimorphic 2nd argument
Date: Sun, 17 Jun 2018 18:36:56 +0900

Tino Calancha <tino.calancha <at> gmail.com> writes:

> On Sun, 3 Jun 2018, Noam Postavsky wrote:
>
>> Tino Calancha <tino.calancha <at> gmail.com> writes:
>>
>>> +(defmacro dotimes-with-progress-reporter (spec reporter-or-message &rest body)
>>
>>> +  (let ((prep (make-symbol "--dotimes-prep--"))
>>> +        ((end (make-symbol "--dotimes-end--"))))
>>> +    `(let ((,prep ,reporter-or-message)
>>> +           (,end ,(cadr spec)))
>>> +       (when (stringp ,prep)
>>> +         (setq ,prep (make-progress-reporter ,prep 0 ,end)))
>>> +       (dotimes ,spec
>>
>> That's still going to evaluate (cadr spec) twice.  You need to change
>> the spec passed to `dotimes' so that it also uses `end'.
> I did it in Bug#31697 but forgot here :-|
> Thank you very much for let me know!
Implemented in master branch as commit
'dotimes-with-progress-reporter: Polymorphic 2nd argument'
(5099b3abb2b623ce949b8efc37bee8c41d5ad754)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.