GNU bug report logs - #31692
aggressive-indent-mode causes Emacs to sometimes drop key events

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: michael_heerdegen <at> web.de, radon.neon <at> gmail.com, 31692 <at> debbugs.gnu.org
Subject: bug#31692: Emacs sometimes drops key events
Date: Thu, 07 Jun 2018 18:52:49 +0300

> From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
> Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, radon.neon <at> gmail.com,
>         31692 <at> debbugs.gnu.org
> Date: Thu, 07 Jun 2018 11:30:58 -0400
> 
> I don't understand the (throw 'throw-on-input t)
> (throw throw-on-input t) would make more sense, but in any case we're
> just about to exit that `catch` so throwing won't have any real effect.

I hoped the comment explained that, but evidently not.

> I think instead of (throw 'throw-on-input t) what is needed here is
> 
>     (setq quit-flag nil)
> 
> which will also make the body return nil (rather than t like (throw
> throw-on-input t) would), which I believe is also the right thing.

I believe we need to return t here, because input did arrive.  We
could indeed just return t instead of throwing, but that's not the
main issue for which I wanted your opinion.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.