GNU bug report logs - #31687
[PATCH] services: Add dnsmasq-service-type.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: iyzsong <at> member.fsf.org (宋文武)
Cc: 31687 <at> debbugs.gnu.org
Subject: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Date: Fri, 08 Jun 2018 21:37:00 +0200

iyzsong <at> member.fsf.org (宋文武) skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:

[...]

>> Minor issues:
>>
>>   • The general guideline is to avoid abbreviations in identifiers—we’re
>>     using the language that comes with ‘call-with-current-continuation’,
>>     after all.  ;-)
>>
>>   • Another guideline is to avoid double-negations and the likes.
>>
>> So in this example, I would recommend:
>>
>>   ‘negative-caching?’ (default: #t)
>>
>
> Agree, I like this naming guideline, pushed :-)

Thank you!

>> I think there’s a couple of other abbreviations.
>
> It’s not clear to me whether other options are abbreviations or not or
> worth to expand.  eg: ‘no-hosts?’ and ‘no-resolv?’, they’re refer to the
> well-known ‘/etc/hosts’ and ‘/etc/resolv.conf’ files, what could we use
> instead?

Oh you’re right, these are fine.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.