GNU bug report logs - #31687
[PATCH] services: Add dnsmasq-service-type.

Previous Next

Package: guix-patches;

Reported by: 宋文武 <iyzsong <at> member.fsf.org>

Date: Sat, 2 Jun 2018 15:29:01 UTC

Severity: normal

Tags: patch

Done: iyzsong <at> member.fsf.org (宋文武)

Bug is archived. No further changes may be made.

Full log

Message #13 received at 31687 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong <at> member.fsf.org>
Cc: 31687 <at> debbugs.gnu.org
Subject: Re: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Date: Fri, 08 Jun 2018 16:43:40 +0200

Hello!

Thanks for this patch, that looks like a useful service to have!

宋文武 <iyzsong <at> member.fsf.org> skribis:

> +@item @code{no-negcache?} (default: @code{#f})
> +When true, disable negative caching.

Minor issues:

  • The general guideline is to avoid abbreviations in identifiers—we’re
    using the language that comes with ‘call-with-current-continuation’,
    after all.  ;-)

  • Another guideline is to avoid double-negations and the likes.

So in this example, I would recommend:

  ‘negative-caching?’ (default: #t)

I think there’s a couple of other abbreviations.

Ludo’.
This bug report was last modified 7 years and 67 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.