GNU bug report logs - #31682
for to tags/emacs-26.2: Add NS style text scale keybindings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31682 in the body.
You can then email your comments to 31682 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratchspace.com.au>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: for to tags/emacs-26.2: Add NS style text scale keybindings
Date: Sat, 02 Jun 2018 02:45:28 -0400

[Message part 1 (text/plain, inline)]

Alan Third writes:

> >     ;;
> >     ;; Allow Command-Plus-or-Minus to text-scale fontsize.
> >     ;;

> I’ve attached a patch for this.

I've re-created the patch based on tags/emacs-26.1 for to 26.2.

[0001-Add-NS-style-text-scale-keybindings.patch (text/plain, attachment)]

[0001-Add-NS-style-text-scale-keybindings-1.patch (application/octet-stream, attachment)]

Message #8 received at 31682 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Van L <van <at> scratchspace.com.au>, Alan Third <alan <at> idiocy.org>
Cc: 31682 <at> debbugs.gnu.org
Subject: Re: bug#31682: for to tags/emacs-26.2: Add NS style text scale
 keybindings
Date: Sat, 02 Jun 2018 10:46:10 +0300

> Date: Sat, 02 Jun 2018 02:45:28 -0400
> From: Van L <van <at> scratchspace.com.au>
> 
> Alan Third writes:
> 
> > >     ;;
> > >     ;; Allow Command-Plus-or-Minus to text-scale fontsize.
> > >     ;;
> 
> > I’ve attached a patch for this.
> 
> I've re-created the patch based on tags/emacs-26.1 for to 26.2.

But this is not a bug, is it?  If not, it should go to master, not the
emacs-26 branch.

Thanks.

Message #11 received at 31682 <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratchspace.com.au>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Alan Third <alan <at> idiocy.org>,
 "31682 <at> debbugs.gnu.org" <31682 <at> debbugs.gnu.org>
Subject: Re: bug#31682: for to tags/emacs-26.2: Add NS style text scale
 keybindings
Date: Sat, 02 Jun 2018 04:04:49 -0400

Eli Zaretskii writes:

> But this is not a bug, is it? If not, it should go to master, not the
> 
> emacs-26 branch.

I don't know the relationship between branch 27 and 26.

I assume 26 is a stable conservative uncontroversial branch shadowing 27's unfettered evolution.

The change can be argued as a `UI experience bug fix` since NS style copy, paste, kill keybindings are there and NS style zooming on the fontsize is expected to be, too.

A different perspective would see it as a new feature not bug.

Message #14 received at 31682 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Van L <van <at> scratchspace.com.au>
Cc: alan <at> idiocy.org, 31682 <at> debbugs.gnu.org
Subject: Re: bug#31682: for to tags/emacs-26.2: Add NS style text scale
 keybindings
Date: Sat, 02 Jun 2018 11:53:55 +0300

> Date: Sat, 02 Jun 2018 04:04:49 -0400
> From: Van L <van <at> scratchspace.com.au>
> Cc: Alan Third <alan <at> idiocy.org>, "31682 <at> debbugs.gnu.org" <31682 <at> debbugs.gnu.org>
> Feedback-ID: CZzD_FB3wty_FyuJcLjvdwM27wBazNtT4ncACjM2IIhF0RODvRhWTfVmRC__RsdKPob4nJOCfPmzZRKgdFxGdQ==:Ext:ProtonMail
> 
> Eli Zaretskii writes:
> 
> > But this is not a bug, is it? If not, it should go to master, not the
> > 
> > emacs-26 branch.
> 
> I don't know the relationship between branch 27 and 26.

The emacs-26 branch should only receive bugfixes, i.e. changes that
fix problems in existing code.  New features should go to master,
which will become Emacs 27.1.

Message #17 received at 31682 <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratchspace.com.au>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "alan <at> idiocy.org" <alan <at> idiocy.org>,
 "31682 <at> debbugs.gnu.org" <31682 <at> debbugs.gnu.org>
Subject: Re: bug#31682: for to tags/emacs-26.2: Add NS style text scale
 keybindings
Date: Sat, 02 Jun 2018 09:46:08 -0400

Eli Zaretskii writes:

> > 
> > I don't know the relationship between branch 27 and 26.
> 
> The emacs-26 branch should only receive bugfixes, i.e. changes that
> 
> fix problems in existing code. New features should go to master,
> 
> which will become Emacs 27.1.

Then Alan T's patch will go in master.

Thanks Eli.

Message #22 received at 31682-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Van L <van <at> scratchspace.com.au>
Cc: Eli Zaretskii <eliz <at> gnu.org>,
 "31682 <at> debbugs.gnu.org" <31682-done <at> debbugs.gnu.org>
Subject: Re: bug#31682: for to tags/emacs-26.2: Add NS style text scale
 keybindings
Date: Sun, 03 Jun 2018 20:33:09 +0100

Van L <van <at> scratchspace.com.au> writes:

> Eli Zaretskii writes:
>
>> > 
>> > I don't know the relationship between branch 27 and 26.
>> 
>> The emacs-26 branch should only receive bugfixes, i.e. changes that
>> 
>> fix problems in existing code. New features should go to master,
>> 
>> which will become Emacs 27.1.
>
> Then Alan T's patch will go in master.

Pushed it to master.

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.