GNU bug report logs - #31678
[PATCH 0/2] Elixir and Erlang improvements

Previous Next

Full log

Message #17 received at 31678 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Christopher Baines <mail <at> cbaines.net>
Cc: 31678 <at> debbugs.gnu.org
Subject: Re: [bug#31678] [PATCH 2/2] gnu: elixir: Enable more tests and remove
 patch.
Date: Sun, 10 Jun 2018 12:51:22 +0800

Christopher Baines <mail <at> cbaines.net> writes:

> Previously, due to issues in the erlang package, many tests would fail, and
> the package would also nondeterministically fail to build. This is now
> fixed (by patching occurances of /bin/sh in the erlang package), so all the
> tests can be run.
>
> * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is no
> longer necessary, as all the tests now pass.
> [arguments]: Remove the fix-or-disable-tests phase, all the tests now
> pass. Add a new set-home phase to set the HOME environment variable prior to
> running the tests, as that was previously done at the start of the
> fix-or-disable-tests phase.
> * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this file,
> as it is now unused.

I think generally we only need to mention the ‘what’ parts, not the
‘why’ parts (“as …”) in the per-file details, but I guess it’s nothing
wrong to do it :-)

> * gnu/local.mk: Remove now deleted patch.
* gnu/local.mk (GNU_SYSTEM_MODULES): ...

> ---
>  gnu/local.mk                                  |   1 -
>  gnu/packages/elixir.scm                       |  36 +--
>  .../elixir-disable-failing-tests.patch        | 284 ------------------
>  3 files changed, 6 insertions(+), 315 deletions(-)

Cool, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.