From unknown Sat Aug 16 21:17:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31678 <31678@debbugs.gnu.org> To: bug#31678 <31678@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Elixir and Erlang improvements Reply-To: bug#31678 <31678@debbugs.gnu.org> Date: Sun, 17 Aug 2025 04:17:46 +0000 retitle 31678 [PATCH 0/2] Elixir and Erlang improvements reassign 31678 guix-patches submitter 31678 Christopher Baines severity 31678 normal tag 31678 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 01 09:46:30 2018 Received: (at submit) by debbugs.gnu.org; 1 Jun 2018 13:46:30 +0000 Received: from localhost ([127.0.0.1]:56996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOkNy-0000Q1-Et for submit@debbugs.gnu.org; Fri, 01 Jun 2018 09:46:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOkNu-0000Pl-V6 for submit@debbugs.gnu.org; Fri, 01 Jun 2018 09:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOkNo-0004Gl-VP for submit@debbugs.gnu.org; Fri, 01 Jun 2018 09:46:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fOkNo-0004GX-Rj for submit@debbugs.gnu.org; Fri, 01 Jun 2018 09:46:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOkNn-00085O-ID for guix-patches@gnu.org; Fri, 01 Jun 2018 09:46:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOkNj-00048S-EK for guix-patches@gnu.org; Fri, 01 Jun 2018 09:46:19 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:37646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOkNj-00047i-7s for guix-patches@gnu.org; Fri, 01 Jun 2018 09:46:15 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 25D721640F; Fri, 1 Jun 2018 14:46:14 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 6AD711640C for ; Fri, 1 Jun 2018 14:46:13 +0100 (BST) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b7481f5a for ; Fri, 1 Jun 2018 13:46:13 +0000 (UTC) User-agent: mu4e 1.0; emacs 26.1 From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH 0/2] Elixir and Erlang improvements Date: Fri, 01 Jun 2018 14:46:10 +0100 Message-ID: <87o9gumxgd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Fix the erlang package to use sh from the store, and not hardcode /bin/sh. This means that the elixir package no longer nondeterministically fails to build, and allows for getting all the tests to pass as well. These are the related bug reports: - https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28034 - https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29655 Christopher Baines (2): gnu: erlang: Patch occurrences of /bin/sh in the source. gnu: elixir: Enable more tests and remove patch. gnu/local.mk | 1 - gnu/packages/elixir.scm | 36 +-- gnu/packages/erlang.scm | 21 ++ .../elixir-disable-failing-tests.patch | 284 ------------------ 4 files changed, 27 insertions(+), 315 deletions(-) delete mode 100644 gnu/packages/patches/elixir-disable-failing-tests.patch --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlsRTiJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcZHg//U69cTsLr1nKcqeSWB/AZsXCvRJ6XD1dtP+F9/qhrpYqXtoHKCkB7WPUI T8mouPuU02Pt/Q1dTOn8rmNJltsXU5ucLCLjFTjJZ9/riTR5+QS+4BpO+JxA9Jno UOtjq1/7e33n30WGC0ejYKiIzNzAKaWW55fY7n2pmHBvKc4HKvvBhhkdU2CLfPQc dy8ev85dLThhAG5/ygj1MsX8T3ukhcih0bDhhRM9h0btE8Vl55AStvkDFtLBRHXX AIN1wsQTYAaLIfHcWt9UDpuWrd1UpNPPk7reviXO5MlRp0padHoc75prAN+t+pNF UuxdjkHuZ7PbWL2Pd5+R+KNPbTcy2BVR8gdLYoUUCh3FxYDUCioAEMDmCRI6J5av NEVeyD5Rd7jpHhCAbi8UOes63+IPoMd4mtHSfN4W2VFHIdLYmKiWfE3I2ANys7Hu a9GKwvEMBBGJDsLXGpoen0Lxtb5q34nCQaNuoAEgnzYRBMtEm9ajJt7I6sLDTxBn pUoPbVcFZKF4eN2Uleit7yIbpKhQShldyvtUJQEdB1zIFr9i8IRps+NCJo3Lh95d wPVKf1O6k5Br89hpVyqNuuP4omABRB/sv3NxeBy4ZAeWX8mGXgzJfPE17Dup7IC2 60Deo4QR3OIjfhuoUu+1Nxy5pBu/OsL9OYCfCyIZgEX1/dTrxjo= =seSs -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 01 09:51:10 2018 Received: (at 31678) by debbugs.gnu.org; 1 Jun 2018 13:51:10 +0000 Received: from localhost ([127.0.0.1]:57002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOkSU-0000XU-22 for submit@debbugs.gnu.org; Fri, 01 Jun 2018 09:51:10 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:49968 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOkSS-0000XK-0M for 31678@debbugs.gnu.org; Fri, 01 Jun 2018 09:51:08 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 62A401640F; Fri, 1 Jun 2018 14:51:07 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 323D81640F for <31678@debbugs.gnu.org>; Fri, 1 Jun 2018 14:51:07 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id e4cc871a for <31678@debbugs.gnu.org>; Fri, 1 Jun 2018 13:51:06 +0000 (UTC) From: Christopher Baines To: 31678@debbugs.gnu.org Subject: [PATCH 1/2] gnu: erlang: Patch occurrences of /bin/sh in the source. Date: Fri, 1 Jun 2018 14:51:05 +0100 Message-Id: <20180601135106.32680-1-mail@cbaines.net> X-Mailer: git-send-email 2.17.1 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31678 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Previously, the elixir package would often fail to build, as running :os:cmd would fail, as /bin/sh doesn't exist when building the elixir package. These changes fix that issue. * gnu/packages/erlang.scm (erlang)[arguments]: Add new patch-/bin/sh phase to replace hardcoded references to /bin/sh with a file in the store. --- gnu/packages/erlang.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm index 0e2b7b5bc..1fce57388 100644 --- a/gnu/packages/erlang.scm +++ b/gnu/packages/erlang.scm @@ -127,6 +127,27 @@ (date->string source-date-epoch "{H,Mi,S} = {~H,~M,~S},"))) #t))) + (add-after 'unpack 'patch-/bin/sh + (lambda _ + (substitute* "erts/etc/unix/run_erl.c" + (("sh = \"/bin/sh\";") + (string-append "sh = \"" + (which "sh") + "\";"))) + + (substitute* "erts/emulator/sys/unix/sys_drivers.c" + (("SHELL \"/bin/sh\"") + (string-append "SHELL \"" + (which "sh") + "\""))) + (substitute* "erts/emulator/sys/unix/erl_child_setup.c" + (("SHELL \"/bin/sh\"") + (string-append "SHELL \"" + (which "sh") + "\""))) + + (substitute* "lib/kernel/src/os.erl" + (("/bin/sh") (which "sh"))))) (add-after 'patch-source-shebangs 'patch-source-env (lambda _ (let ((escripts -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 01 09:51:13 2018 Received: (at 31678) by debbugs.gnu.org; 1 Jun 2018 13:51:13 +0000 Received: from localhost ([127.0.0.1]:57004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOkSW-0000Xj-Cz for submit@debbugs.gnu.org; Fri, 01 Jun 2018 09:51:12 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:49970 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOkSS-0000XM-DD for 31678@debbugs.gnu.org; Fri, 01 Jun 2018 09:51:10 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id ECACD16412; Fri, 1 Jun 2018 14:51:07 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 4FBB116410 for <31678@debbugs.gnu.org>; Fri, 1 Jun 2018 14:51:07 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 16350e94 for <31678@debbugs.gnu.org>; Fri, 1 Jun 2018 13:51:06 +0000 (UTC) From: Christopher Baines To: 31678@debbugs.gnu.org Subject: [PATCH 2/2] gnu: elixir: Enable more tests and remove patch. Date: Fri, 1 Jun 2018 14:51:06 +0100 Message-Id: <20180601135106.32680-2-mail@cbaines.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180601135106.32680-1-mail@cbaines.net> References: <20180601135106.32680-1-mail@cbaines.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31678 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Previously, due to issues in the erlang package, many tests would fail, and the package would also nondeterministically fail to build. This is now fixed (by patching occurances of /bin/sh in the erlang package), so all the tests can be run. * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is no longer necessary, as all the tests now pass. [arguments]: Remove the fix-or-disable-tests phase, all the tests now pass. Add a new set-home phase to set the HOME environment variable prior to running the tests, as that was previously done at the start of the fix-or-disable-tests phase. * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this file, as it is now unused. * gnu/local.mk: Remove now deleted patch. --- gnu/local.mk | 1 - gnu/packages/elixir.scm | 36 +-- .../elixir-disable-failing-tests.patch | 284 ------------------ 3 files changed, 6 insertions(+), 315 deletions(-) delete mode 100644 gnu/packages/patches/elixir-disable-failing-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index db04ee0cd..1a6ffecc0 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -637,7 +637,6 @@ dist_patch_DATA = \ %D%/packages/patches/dvd+rw-tools-add-include.patch \ %D%/packages/patches/eigen-arm-neon-fixes.patch \ %D%/packages/patches/elfutils-tests-ptrace.patch \ - %D%/packages/patches/elixir-disable-failing-tests.patch \ %D%/packages/patches/einstein-build.patch \ %D%/packages/patches/emacs-browse-at-remote-cgit-gnu.patch \ %D%/packages/patches/emacs-exec-path.patch \ diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm index ceabc2a6c..ed6bd0023 100644 --- a/gnu/packages/elixir.scm +++ b/gnu/packages/elixir.scm @@ -40,15 +40,7 @@ (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "0acnxfwvkx1m1d0h5z051mz95n35zm468hcvc3wpmn17c15h5ihg")) - ;; FIXME: 27 tests (out of 4K) had to be disabled as - ;; they fail in the build environment. Common failures - ;; are: - ;; - Mix.Shell.cmd() fails with error 130 - ;; - The git_repo fixture cannot be found - ;; - Communication with spawned processes fails with EPIPE - ;; - Failure to copy files - (patches (search-patches "elixir-disable-failing-tests.patch")))) + "0acnxfwvkx1m1d0h5z051mz95n35zm468hcvc3wpmn17c15h5ihg")))) (build-system gnu-build-system) (arguments `(#:test-target "test" @@ -70,27 +62,6 @@ (("#!/usr/bin/env elixir") (string-append "#!" out "/bin/elixir")))) #t)) - (add-after 'unpack 'fix-or-disable-tests - (lambda* (#:key inputs #:allow-other-keys) - ;; Some tests require access to a home directory. - (setenv "HOME" "/tmp") - - ;; FIXME: These tests fail because the "git_repo" fixture does - ;; not exist or cannot be found. - (delete-file "lib/mix/test/mix/tasks/deps.git_test.exs") - - ;; FIXME: Mix.Shell.cmd() always fails with error code 130. - (delete-file "lib/mix/test/mix/shell_test.exs") - - ;; FIXME: - ;; disabled failing impure tests to make it build again. - ;; related discussion: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28034#14 - (delete-file "lib/elixir/test/elixir/kernel/cli_test.exs") - (delete-file "lib/elixir/test/elixir/kernel/dialyzer_test.exs") - (delete-file "lib/iex/test/iex/helpers_test.exs") - (delete-file "lib/ex_unit/test/ex_unit/capture_io_test.exs") - - #t)) (add-before 'build 'make-current ;; The Elixir compiler checks whether or not to compile files by ;; inspecting their timestamps. When the timestamp is equal to the @@ -102,6 +73,11 @@ (utime file recent recent 0 0))) (find-files "." ".*")) #t)) + (add-before 'check 'set-home + (lambda* (#:key inputs #:allow-other-keys) + ;; Some tests require access to a home directory. + (setenv "HOME" "/tmp") + #t)) (delete 'configure)))) (inputs `(("erlang" ,erlang) diff --git a/gnu/packages/patches/elixir-disable-failing-tests.patch b/gnu/packages/patches/elixir-disable-failing-tests.patch deleted file mode 100644 index 547598b29..000000000 --- a/gnu/packages/patches/elixir-disable-failing-tests.patch +++ /dev/null @@ -1,284 +0,0 @@ -Most of these tests fail for unknown reasons when run in the chroot -environment of a Guix build process. - -Common failures are: - - * Mix.Shell.cmd() fails with error 130 - * The git_repo fixture cannot be found - * Communication with spawned processes fails with EPIPE - * Failure to copy files - - -diff --git a/lib/elixir/test/elixir/kernel/cli_test.exs b/lib/elixir/test/elixir/kernel/cli_test.exs -index 3ffd56c..1232d19 100644 ---- a/lib/elixir/test/elixir/kernel/cli_test.exs -+++ b/lib/elixir/test/elixir/kernel/cli_test.exs -@@ -39,6 +39,7 @@ end - defmodule Kernel.CLI.OptionParsingTest do - use ExUnit.Case, async: true - -+ @tag :skip - test "properly parses paths" do - root = fixture_path("../../..") |> to_charlist - list = elixir('-pa "#{root}/*" -pz "#{root}/lib/*" -e "IO.inspect(:code.get_path, limit: :infinity)"') -@@ -57,6 +58,7 @@ end - defmodule Kernel.CLI.AtExitTest do - use ExUnit.Case, async: true - -+ @tag :skip - test "invokes at_exit callbacks" do - assert elixir(fixture_path("at_exit.exs") |> to_charlist) == - 'goodbye cruel world with status 1\n' -@@ -66,6 +68,7 @@ end - defmodule Kernel.CLI.ErrorTest do - use ExUnit.Case, async: true - -+ @tag :skip - test "properly format errors" do - assert :string.str('** (throw) 1', elixir('-e "throw 1"')) == 0 - assert :string.str('** (ErlangError) erlang error: 1', elixir('-e "error 1"')) == 0 -@@ -86,6 +89,7 @@ defmodule Kernel.CLI.CompileTest do - {:ok, [tmp_dir_path: tmp_dir_path, beam_file_path: beam_file_path, fixture: fixture]} - end - -+ @tag :skip - test "compiles code", context do - assert elixirc('#{context[:fixture]} -o #{context[:tmp_dir_path]}') == '' - assert File.regular?(context[:beam_file_path]) -@@ -96,6 +100,7 @@ defmodule Kernel.CLI.CompileTest do - Code.delete_path context[:tmp_dir_path] - end - -+ @tag :skip - test "fails on missing patterns", context do - output = elixirc('#{context[:fixture]} non_existing.ex -o #{context[:tmp_dir_path]}') - assert :string.str(output, 'non_existing.ex') > 0, "expected non_existing.ex to be mentioned" -@@ -103,6 +108,7 @@ defmodule Kernel.CLI.CompileTest do - refute File.exists?(context[:beam_file_path]), "expected the sample to not be compiled" - end - -+ @tag :skip - test "fails on missing write access to .beam file", context do - compilation_args = '#{context[:fixture]} -o #{context[:tmp_dir_path]}' - -diff --git a/lib/elixir/test/elixir/kernel/dialyzer_test.exs b/lib/elixir/test/elixir/kernel/dialyzer_test.exs -index 801d852..40fc5bc 100644 ---- a/lib/elixir/test/elixir/kernel/dialyzer_test.exs -+++ b/lib/elixir/test/elixir/kernel/dialyzer_test.exs -@@ -60,16 +60,19 @@ defmodule Kernel.DialyzerTest do - assert_dialyze_no_warnings! context - end - -+ @tag :skip - test "no warnings on rewrites", context do - copy_beam! context, Dialyzer.Rewrite - assert_dialyze_no_warnings! context - end - -+ @tag :skip - test "no warnings on raise", context do - copy_beam! context, Dialyzer.Raise - assert_dialyze_no_warnings! context - end - -+ @tag :skip - test "no warnings on macrocallback", context do - copy_beam! context, Dialyzer.Macrocallback - copy_beam! context, Dialyzer.Macrocallback.Impl -diff --git a/lib/elixir/test/elixir/system_test.exs b/lib/elixir/test/elixir/system_test.exs -index aafa559..0f9c178 100644 ---- a/lib/elixir/test/elixir/system_test.exs -+++ b/lib/elixir/test/elixir/system_test.exs -@@ -53,7 +53,8 @@ defmodule SystemTest do - assert System.endianness in [:little, :big] - assert System.endianness == System.compiled_endianness - end -- -+ -+ @tag :skip - test "argv/0" do - list = elixir('-e "IO.inspect System.argv" -- -o opt arg1 arg2 --long-opt 10') - {args, _} = Code.eval_string list, [] -diff --git a/lib/mix/test/mix/dep_test.exs b/lib/mix/test/mix/dep_test.exs -index fff3351..d6ed1b3 100644 ---- a/lib/mix/test/mix/dep_test.exs -+++ b/lib/mix/test/mix/dep_test.exs -@@ -244,6 +244,7 @@ defmodule Mix.DepTest do - end - end - -+ @tag :skip - test "remote converger" do - deps = [{:deps_repo, "0.1.0", path: "custom/deps_repo"}, - {:git_repo, "0.2.0", git: MixTest.Case.fixture_path("git_repo")}] -@@ -301,6 +302,7 @@ defmodule Mix.DepTest do - end - end - -+ @tag :skip - test "remote converger is not invoked if deps diverge" do - deps = [{:deps_repo, "0.1.0", path: "custom/deps_repo"}, - {:git_repo, "0.2.0", git: MixTest.Case.fixture_path("git_repo"), only: :test}] - -diff --git a/lib/mix/test/mix/shell/io_test.exs b/lib/mix/test/mix/shell/io_test.exs -index 9bfb6b4..d982ef3 100644 ---- a/lib/mix/test/mix/shell/io_test.exs -+++ b/lib/mix/test/mix/shell/io_test.exs -@@ -29,6 +29,7 @@ defmodule Mix.Shell.IOTest do - assert capture_io("", fn -> refute yes?("Ok?") end) - end - -+ @tag :skip - test "runs a given command" do - assert capture_io("", fn -> assert cmd("echo hello") == 0 end) == "hello\n" - -diff --git a/lib/mix/test/mix/shell/quiet_test.exs b/lib/mix/test/mix/shell/quiet_test.exs -index 626429b..99fab35 100644 ---- a/lib/mix/test/mix/shell/quiet_test.exs -+++ b/lib/mix/test/mix/shell/quiet_test.exs -@@ -29,6 +29,7 @@ defmodule Mix.Shell.QuietTest do - assert capture_io("", fn -> refute yes?("Ok?") end) - end - -+ @tag :skip - test "runs a given command" do - assert capture_io("", fn -> assert cmd("echo hello") == 0 end) == "" - -diff --git a/lib/mix/test/mix/tasks/cmd_test.exs b/lib/mix/test/mix/tasks/cmd_test.exs -index db4bf06..4d441f7 100644 ---- a/lib/mix/test/mix/tasks/cmd_test.exs -+++ b/lib/mix/test/mix/tasks/cmd_test.exs -@@ -3,6 +3,7 @@ Code.require_file "../../test_helper.exs", __DIR__ - defmodule Mix.Tasks.CmdTest do - use MixTest.Case - -+ @tag :skip - test "runs the command for each app" do - in_fixture "umbrella_dep/deps/umbrella", fn -> - Mix.Project.in_project(:umbrella, ".", fn _ -> -diff --git a/lib/mix/test/mix/tasks/deps.tree_test.exs b/lib/mix/test/mix/tasks/deps.tree_test.exs -index 4f09ff3..c371997 100644 ---- a/lib/mix/test/mix/tasks/deps.tree_test.exs -+++ b/lib/mix/test/mix/tasks/deps.tree_test.exs -@@ -29,6 +29,7 @@ defmodule Mix.Tasks.Deps.TreeTest do - end - end - -+ @tag :skip - test "shows the dependency tree", context do - Mix.Project.push ConvergedDepsApp - -@@ -109,6 +110,7 @@ defmodule Mix.Tasks.Deps.TreeTest do - end - end - -+ @tag :skip - test "shows the dependency tree in DOT graph format", context do - Mix.Project.push ConvergedDepsApp - -diff --git a/lib/mix/test/mix/tasks/deps_test.exs b/lib/mix/test/mix/tasks/deps_test.exs -index b061777..cc45cf8 100644 ---- a/lib/mix/test/mix/tasks/deps_test.exs -+++ b/lib/mix/test/mix/tasks/deps_test.exs -@@ -96,6 +96,7 @@ - end - end - -+ @tag :skip - test "prints list of dependencies and their lock status" do - Mix.Project.push DepsApp - -@@ -409,6 +409,7 @@ defmodule Mix.Tasks.DepsTest do - end - end - -+ @tag :skip - test "fails on diverged dependencies by requirement" do - Mix.Project.push ConvergedDepsApp - -@@ -440,6 +441,7 @@ defmodule Mix.Tasks.DepsTest do - end - end - -+ @tag :skip - test "fails on diverged dependencies even when optional" do - Mix.Project.push ConvergedDepsApp - -@@ -469,6 +471,7 @@ defmodule Mix.Tasks.DepsTest do - end - end - -+ @tag :skip - test "works with converged dependencies" do - Mix.Project.push ConvergedDepsApp - -@@ -491,6 +494,7 @@ defmodule Mix.Tasks.DepsTest do - purge [GitRepo, GitRepo.Mixfile] - end - -+ @tag :skip - test "works with overridden dependencies" do - Mix.Project.push OverriddenDepsApp - -diff --git a/lib/mix/test/mix/umbrella_test.exs b/lib/mix/test/mix/umbrella_test.exs -index 69f9428..406668a 100644 ---- a/lib/mix/test/mix/umbrella_test.exs -+++ b/lib/mix/test/mix/umbrella_test.exs -@@ -98,6 +98,7 @@ defmodule Mix.UmbrellaTest do - end - end - -+ @tag :skip - test "loads umbrella child dependencies in all environments" do - in_fixture "umbrella_dep/deps/umbrella", fn -> - Mix.Project.in_project :umbrella, ".", fn _ -> - -diff --git a/lib/elixir/test/elixir/kernel/dialyzer_test.exs b/lib/elixir/test/elixir/kernel/dialyzer_test.exs -index 792222c..e90beb9 100644 ---- a/lib/elixir/test/elixir/kernel/dialyzer_test.exs -+++ b/lib/elixir/test/elixir/kernel/dialyzer_test.exs -@@ -54,6 +54,7 @@ defmodule Kernel.DialyzerTest do - {:ok, [outdir: dir, dialyzer: dialyzer]} - end - -+ @tag :skip - test "no warnings on valid remote calls", context do - copy_beam! context, Dialyzer.RemoteCall - assert_dialyze_no_warnings! context -@@ -78,11 +79,13 @@ defmodule Kernel.DialyzerTest do - assert_dialyze_no_warnings! context - end - -+ @tag :skip - test "no warnings on struct update", context do - copy_beam! context, Dialyzer.StructUpdate - assert_dialyze_no_warnings! context - end - -+ @tag :skip - test "no warnings on protocol calls with opaque types", context do - copy_beam! context, Dialyzer.ProtocolOpaque - copy_beam! context, Dialyzer.ProtocolOpaque.Entity -@@ -90,6 +93,7 @@ defmodule Kernel.DialyzerTest do - assert_dialyze_no_warnings! context - end - -+ @tag :skip - test "no warnings on and/2 and or/2", context do - copy_beam! context, Dialyzer.BooleanCheck - assert_dialyze_no_warnings! context - -diff --git a/Makefile b/Makefile -index 2fc4f9a..aef8366 100644 ---- a/Makefile -+++ b/Makefile -@@ -201,7 +201,7 @@ $(TEST_EBIN)/%.beam: $(TEST_ERL)/%.erl - $(Q) mkdir -p $(TEST_EBIN) - $(Q) $(ERLC) -o $(TEST_EBIN) $< - --test_elixir: test_stdlib test_ex_unit test_logger test_mix test_eex test_iex -+test_elixir: test_stdlib test_ex_unit test_logger test_eex test_iex - - test_stdlib: compile - @ echo "==> elixir (exunit)" - -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 00:42:03 2018 Received: (at 31678) by debbugs.gnu.org; 10 Jun 2018 04:42:03 +0000 Received: from localhost ([127.0.0.1]:41671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRsB0-00049X-Tz for submit@debbugs.gnu.org; Sun, 10 Jun 2018 00:42:03 -0400 Received: from rezeros.cc ([45.76.207.221]:33950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRsAz-000497-5e for 31678@debbugs.gnu.org; Sun, 10 Jun 2018 00:42:02 -0400 Received: from localhost (223.87.207.28 [223.87.207.28]) by rezeros.cc (OpenSMTPD) with ESMTPSA id df0cd3f8 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 10 Jun 2018 04:41:56 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id baa42e43; Sun, 10 Jun 2018 04:41:20 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Christopher Baines Subject: Re: [bug#31678] [PATCH 1/2] gnu: erlang: Patch occurrences of /bin/sh in the source. References: <87o9gumxgd.fsf@cbaines.net> <20180601135106.32680-1-mail@cbaines.net> Date: Sun, 10 Jun 2018 12:41:20 +0800 In-Reply-To: <20180601135106.32680-1-mail@cbaines.net> (Christopher Baines's message of "Fri, 1 Jun 2018 14:51:05 +0100") Message-ID: <87wov7gsnj.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Christopher Baines writes: > Previously, the elixir package would often fail to build, as running :os:cmd > would fail, as /bin/sh doesn't exist when building the elixir package. These > changes fix that issue. > > * gnu/packages/erlang.scm (erlang)[arguments]: Add new patch-/bin/sh phase to > replace hardcoded references to /bin/sh with a file in the store. > --- > gnu/packages/erlang.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm > index 0e2b7b5bc..1fce57388 100644 > --- a/gnu/packages/erlang.scm > +++ b/gnu/packages/erlang.scm > @@ -127, 6 +127, 27 @@ > (date->string source-date-epoch > "{H,Mi,S} = {~H,~M,~S},"))) > #t))) > + (add-after 'unpack 'patch-/bin/sh > + (lambda _ > + (substitute* "erts/etc/unix/run_erl.c" > + (("sh = \"/bin/sh\"; ") > + (string-append "sh = \"" > + (which "sh") > + "\"; "))) > + > + (substitute* "erts/emulator/sys/unix/sys_drivers.c" > + (("SHELL \"/bin/sh\"") > + (string-append "SHELL \"" > + (which "sh") > + "\""))) > + (substitute* "erts/emulator/sys/unix/erl_child_setup.c" > + (("SHELL \"/bin/sh\"") > + (string-append "SHELL \"" > + (which "sh") > + "\""))) > + > + (substitute* "lib/kernel/src/os.erl" > + (("/bin/sh") (which "sh"))))) [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 31678 Cc: 31678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Christopher Baines writes: > Previously, the elixir package would often fail to build, as running :os:= cmd > would fail, as /bin/sh doesn't exist when building the elixir package. Th= ese > changes fix that issue. > > * gnu/packages/erlang.scm (erlang)[arguments]: Add new patch-/bin/sh phas= e to > replace hardcoded references to /bin/sh with a file in the store. > --- > gnu/packages/erlang.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm > index 0e2b7b5bc..1fce57388 100644 > --- a/gnu/packages/erlang.scm > +++ b/gnu/packages/erlang.scm > @@ -127,6 +127,27 @@ > (date->string source-date-epoch > "{H,Mi,S} =3D {~H,~M,~S},"))) > #t))) > + (add-after 'unpack 'patch-/bin/sh > + (lambda _ > + (substitute* "erts/etc/unix/run_erl.c" > + (("sh =3D \"/bin/sh\";") > + (string-append "sh =3D \"" > + (which "sh") > + "\";"))) > + > + (substitute* "erts/emulator/sys/unix/sys_drivers.c" > + (("SHELL \"/bin/sh\"") > + (string-append "SHELL \"" > + (which "sh") > + "\""))) > + (substitute* "erts/emulator/sys/unix/erl_child_setup.c" > + (("SHELL \"/bin/sh\"") > + (string-append "SHELL \"" > + (which "sh") > + "\""))) > + > + (substitute* "lib/kernel/src/os.erl" > + (("/bin/sh") (which "sh"))))) It should return =E2=80=98#t=E2=80=99, otherwise look good to me! From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 00:51:53 2018 Received: (at 31678) by debbugs.gnu.org; 10 Jun 2018 04:51:53 +0000 Received: from localhost ([127.0.0.1]:41675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRsKW-0004Mv-ST for submit@debbugs.gnu.org; Sun, 10 Jun 2018 00:51:53 -0400 Received: from rezeros.cc ([45.76.207.221]:33958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRsKR-0004Mj-RT for 31678@debbugs.gnu.org; Sun, 10 Jun 2018 00:51:51 -0400 Received: from localhost (223.87.207.28 [223.87.207.28]) by rezeros.cc (OpenSMTPD) with ESMTPSA id 1dc401be (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 10 Jun 2018 04:51:44 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 82ad278e; Sun, 10 Jun 2018 04:51:22 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Christopher Baines Subject: Re: [bug#31678] [PATCH 2/2] gnu: elixir: Enable more tests and remove patch. References: <20180601135106.32680-1-mail@cbaines.net> <20180601135106.32680-2-mail@cbaines.net> Date: Sun, 10 Jun 2018 12:51:22 +0800 In-Reply-To: <20180601135106.32680-2-mail@cbaines.net> (Christopher Baines's message of "Fri, 1 Jun 2018 14:51:06 +0100") Message-ID: <87tvqbgs6t.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Christopher Baines writes: > Previously, due to issues in the erlang package, many tests would fail, and > the package would also nondeterministically fail to build. This is now > fixed (by patching occurances of /bin/sh in the erlang package), so all the > tests can be run. > > * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is no > longer necessary, as all the tests now pass. > [arguments]: Remove the fix-or-disable-tests phase, all the tests now > pass. Add a new set-home phase to set the HOME environment variable prior to > running the tests, as that was previously done at the start of the > fix-or-disable-tests phase. > * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this file, > as it is now unused. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 31678 Cc: 31678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Christopher Baines writes: > Previously, due to issues in the erlang package, many tests would fail, a= nd > the package would also nondeterministically fail to build. This is now > fixed (by patching occurances of /bin/sh in the erlang package), so all t= he > tests can be run. > > * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is = no > longer necessary, as all the tests now pass. > [arguments]: Remove the fix-or-disable-tests phase, all the tests now > pass. Add a new set-home phase to set the HOME environment variable prior= to > running the tests, as that was previously done at the start of the > fix-or-disable-tests phase. > * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this fi= le, > as it is now unused. I think generally we only need to mention the =E2=80=98what=E2=80=99 parts,= not the =E2=80=98why=E2=80=99 parts (=E2=80=9Cas =E2=80=A6=E2=80=9D) in the per-fil= e details, but I guess it=E2=80=99s nothing wrong to do it :-) > * gnu/local.mk: Remove now deleted patch. * gnu/local.mk (GNU_SYSTEM_MODULES): ... > --- > gnu/local.mk | 1 - > gnu/packages/elixir.scm | 36 +-- > .../elixir-disable-failing-tests.patch | 284 ------------------ > 3 files changed, 6 insertions(+), 315 deletions(-) Cool, thank you! From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 10 02:00:49 2018 Received: (at 31678) by debbugs.gnu.org; 10 Jun 2018 06:00:50 +0000 Received: from localhost ([127.0.0.1]:41703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRtPF-0006JN-MM for submit@debbugs.gnu.org; Sun, 10 Jun 2018 02:00:49 -0400 Received: from rezeros.cc ([45.76.207.221]:33980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRtPC-0006JC-RW for 31678@debbugs.gnu.org; Sun, 10 Jun 2018 02:00:47 -0400 Received: from localhost (223.87.207.28 [223.87.207.28]) by rezeros.cc (OpenSMTPD) with ESMTPSA id e476b7f5 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 10 Jun 2018 06:00:43 +0000 (UTC) Received: from gift (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 1216cb8f; Sun, 10 Jun 2018 06:00:07 +0000 (UTC) From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) To: Christopher Baines Subject: Re: [bug#31678] [PATCH 1/2] gnu: erlang: Patch occurrences of /bin/sh in the source. References: <87o9gumxgd.fsf@cbaines.net> <20180601135106.32680-1-mail@cbaines.net> <87wov7gsnj.fsf@member.fsf.org> Date: Sun, 10 Jun 2018 14:00:07 +0800 In-Reply-To: <87wov7gsnj.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?= =?utf-8?B?cw==?= message of "Sun, 10 Jun 2018 12:41:20 +0800") Message-ID: <87in6rgp08.fsf@member.fsf.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: iyzsong@member.fsf.org (宋文武) writes: > Christopher Baines writes: > >> Previously, the elixir package would often fail to build, as running :os:cmd >> would fail, as /bin/sh doesn't exist when building the elixir package. These >> changes fix that issue. >> >> * gnu/packages/erlang.scm (erlang)[arguments]: Add new patch-/bin/sh phase to >> replace hardcoded references to /bin/sh with a file in the store. >> --- >> gnu/packages/erlang.scm | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm >> index 0e2b7b5bc..1fce57388 100644 >> --- a/gnu/packages/erlang.scm >> +++ b/gnu/packages/erlang.scm >> @@ -127,6 +127,27 @@ >> (date->string source-date-epoch >> "{H,Mi,S} = {~H,~M,~S},"))) >> #t))) >> + (add-after 'unpack 'patch-/bin/sh >> + (lambda _ >> + (substitute* "erts/etc/unix/run_erl.c" >> + (("sh = \"/bin/sh\";") >> + (string-append "sh = \"" >> + (which "sh") >> + "\";"))) >> + >> + (substitute* "erts/emulator/sys/unix/sys_drivers.c" >> + (("SHELL \"/bin/sh\"") >> + (string-append "SHELL \"" >> + (which "sh") >> + "\""))) >> + (substitute* "erts/emulator/sys/unix/erl_child_setup.c" >> + (("SHELL \"/bin/sh\"") >> + (string-append "SHELL \"" >> + (which "sh") >> + "\""))) >> + >> + (substitute* "lib/kernel/src/os.erl" >> + (("/bin/sh") (which "sh"))))) > > It should return ‘#t’, otherwise look good to me! [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 FROM_EXCESS_BASE64 From: base64 encoded unnecessarily X-Debbugs-Envelope-To: 31678 Cc: 31678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > Christopher Baines writes: > >> Previously, the elixir package would often fail to build, as running :os= :cmd >> would fail, as /bin/sh doesn't exist when building the elixir package. T= hese >> changes fix that issue. >> >> * gnu/packages/erlang.scm (erlang)[arguments]: Add new patch-/bin/sh pha= se to >> replace hardcoded references to /bin/sh with a file in the store. >> --- >> gnu/packages/erlang.scm | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm >> index 0e2b7b5bc..1fce57388 100644 >> --- a/gnu/packages/erlang.scm >> +++ b/gnu/packages/erlang.scm >> @@ -127,6 +127,27 @@ >> (date->string source-date-epoch >> "{H,Mi,S} =3D {~H,~M,~S},"))) >> #t))) >> + (add-after 'unpack 'patch-/bin/sh >> + (lambda _ >> + (substitute* "erts/etc/unix/run_erl.c" >> + (("sh =3D \"/bin/sh\";") >> + (string-append "sh =3D \"" >> + (which "sh") >> + "\";"))) >> + >> + (substitute* "erts/emulator/sys/unix/sys_drivers.c" >> + (("SHELL \"/bin/sh\"") >> + (string-append "SHELL \"" >> + (which "sh") >> + "\""))) >> + (substitute* "erts/emulator/sys/unix/erl_child_setup.c" >> + (("SHELL \"/bin/sh\"") >> + (string-append "SHELL \"" >> + (which "sh") >> + "\""))) >> + >> + (substitute* "lib/kernel/src/os.erl" >> + (("/bin/sh") (which "sh"))))) > > It should return =E2=80=98#t=E2=80=99, otherwise look good to me! Oh, =E2=80=98substitute*=E2=80=99 does return =E2=80=98#t=E2=80=99 itself, = never mind :-) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 02:55:36 2018 Received: (at 31678-done) by debbugs.gnu.org; 12 Jun 2018 06:55:36 +0000 Received: from localhost ([127.0.0.1]:43970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSdDL-0007mx-Vp for submit@debbugs.gnu.org; Tue, 12 Jun 2018 02:55:36 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:57038 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSdDH-0007ml-Kw for 31678-done@debbugs.gnu.org; Tue, 12 Jun 2018 02:55:34 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 71ADA16414; Tue, 12 Jun 2018 07:55:30 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 9DAA9163BC; Tue, 12 Jun 2018 07:55:29 +0100 (BST) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id c4c59e54; Tue, 12 Jun 2018 06:55:29 +0000 (UTC) References: <20180601135106.32680-1-mail@cbaines.net> <20180601135106.32680-2-mail@cbaines.net> <87tvqbgs6t.fsf@member.fsf.org> User-agent: mu4e 1.0; emacs 26.1 From: Christopher Baines To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [bug#31678] [PATCH 2/2] gnu: elixir: Enable more tests and remove patch. In-reply-to: <87tvqbgs6t.fsf@member.fsf.org> Date: Tue, 12 Jun 2018 07:55:25 +0100 Message-ID: <87y3fk334y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31678-done Cc: 31678-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > Christopher Baines writes: > >> Previously, due to issues in the erlang package, many tests would fail, = and >> the package would also nondeterministically fail to build. This is now >> fixed (by patching occurances of /bin/sh in the erlang package), so all = the >> tests can be run. >> >> * gnu/packages/elixir.scm (elixir)[source]: Remove patches. The patch is= no >> longer necessary, as all the tests now pass. >> [arguments]: Remove the fix-or-disable-tests phase, all the tests now >> pass. Add a new set-home phase to set the HOME environment variable prio= r to >> running the tests, as that was previously done at the start of the >> fix-or-disable-tests phase. >> * gnu/packages/patches/elixir-disable-failing-tests.patch: Delete this f= ile, >> as it is now unused. > > I think generally we only need to mention the =E2=80=98what=E2=80=99 part= s, not the > =E2=80=98why=E2=80=99 parts (=E2=80=9Cas =E2=80=A6=E2=80=9D) in the per-f= ile details, but I guess it=E2=80=99s nothing > wrong to do it :-) I've pushed this now, thanks for taking a look :) I tweaked the changelog to not repeat the why parts. >> * gnu/local.mk: Remove now deleted patch. > * gnu/local.mk (GNU_SYSTEM_MODULES): ... Missed this bit, only just spotted what you were suggesting, sorry about that. >> --- >> gnu/local.mk | 1 - >> gnu/packages/elixir.scm | 36 +-- >> .../elixir-disable-failing-tests.patch | 284 ------------------ >> 3 files changed, 6 insertions(+), 315 deletions(-) > > Cool, thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlsfbl1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xeqzw/9HOLZY7FAnvRIcNZiUovzKAFonpwWwdk0dohA4A1blIe+MtLZtWxfm8rK WNDhEZS9fKNVKyr+opMbzwK8fJRc0Xvyd9/2UvS8bm2Vg2zF7f3IrND4riS+82b9 h3CXSqsixtLLv9wO3e27Mfc1lHFVIlR13/aL2Mvx69h3bcUHGxJdWNRgmXvlqlH0 lKvMklYlTTjpBk04fGLV7b8tCLC9W22kf1l5SAvkIyxbpJ8PpPxxOmy4ESq9XFmi ZZKKPHxMIwUyp+O/fSL4PizY67V5JpeoEJcPbOntEFXiEsRs0ucavtozYx6vdVMc P6gcAYSObmcGaKaeO78lsDQATvYP3kfes3t31A3kIcffkinOKjylWCAbnyOzW75f lKp2I5W9vJUS7AgxFXYHCD9WCDoZxLbJgFsUs2drXY0zBQb8iyzCE9bPJ5J+YsEp f2FedmxNKUAbRtbBFKOKXSGxmebr7rxM1j+fVAyV74xLvTMi9UWAf3ouGxzZjP5e SVmfpUAPTKatCSK3kY1dopMcmbfG96npZ95WPLlrvRAPt9JQpZ/TZDzNFBd1LnCL V4S07S8mWXuWg2DPYNuec84pCEJ7ADiepC2OF7JuJwNw2LC0gqQcuXl8ghtk+5OB 1qZMt6FZzsFyCjdL3h2LwKCNK7F3DL6tUzkbT+h6avnXKxTZu08= =l2Ft -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 02:56:46 2018 Received: (at 31678) by debbugs.gnu.org; 12 Jun 2018 06:56:46 +0000 Received: from localhost ([127.0.0.1]:43978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSdEU-0007p7-B4 for submit@debbugs.gnu.org; Tue, 12 Jun 2018 02:56:46 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:57050 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSdES-0007ox-HZ for 31678@debbugs.gnu.org; Tue, 12 Jun 2018 02:56:44 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 0D91F1647B; Tue, 12 Jun 2018 07:56:44 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id BFA3D16414; Tue, 12 Jun 2018 07:56:43 +0100 (BST) Received: from giedi (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 8f91a4ea; Tue, 12 Jun 2018 06:56:43 +0000 (UTC) References: <87o9gumxgd.fsf@cbaines.net> <20180601135106.32680-1-mail@cbaines.net> <87wov7gsnj.fsf@member.fsf.org> <87in6rgp08.fsf@member.fsf.org> User-agent: mu4e 1.0; emacs 26.1 From: Christopher Baines To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [bug#31678] [PATCH 1/2] gnu: erlang: Patch occurrences of /bin/sh in the source. In-reply-to: <87in6rgp08.fsf@member.fsf.org> Date: Tue, 12 Jun 2018 07:56:43 +0100 Message-ID: <87wov4332s.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31678 Cc: 31678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > >> Christopher Baines writes: >> >>> Previously, the elixir package would often fail to build, as running :o= s:cmd >>> would fail, as /bin/sh doesn't exist when building the elixir package. = These >>> changes fix that issue. >>> >>> * gnu/packages/erlang.scm (erlang)[arguments]: Add new patch-/bin/sh ph= ase to >>> replace hardcoded references to /bin/sh with a file in the store. >>> --- >>> gnu/packages/erlang.scm | 21 +++++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> >>> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm >>> index 0e2b7b5bc..1fce57388 100644 >>> --- a/gnu/packages/erlang.scm >>> +++ b/gnu/packages/erlang.scm >>> @@ -127,6 +127,27 @@ >>> (date->string source-date-epoch >>> "{H,Mi,S} =3D {~H,~M,~S},"))) >>> #t))) >>> + (add-after 'unpack 'patch-/bin/sh >>> + (lambda _ >>> + (substitute* "erts/etc/unix/run_erl.c" >>> + (("sh =3D \"/bin/sh\";") >>> + (string-append "sh =3D \"" >>> + (which "sh") >>> + "\";"))) >>> + >>> + (substitute* "erts/emulator/sys/unix/sys_drivers.c" >>> + (("SHELL \"/bin/sh\"") >>> + (string-append "SHELL \"" >>> + (which "sh") >>> + "\""))) >>> + (substitute* "erts/emulator/sys/unix/erl_child_setup.c" >>> + (("SHELL \"/bin/sh\"") >>> + (string-append "SHELL \"" >>> + (which "sh") >>> + "\""))) >>> + >>> + (substitute* "lib/kernel/src/os.erl" >>> + (("/bin/sh") (which "sh"))))) >> >> It should return =E2=80=98#t=E2=80=99, otherwise look good to me! > > Oh, =E2=80=98substitute*=E2=80=99 does return =E2=80=98#t=E2=80=99 itself= , never mind :-) I've added an explicit #t in there anyway, as I couldn't quite work out under what circumstances substitute* returned #t. The other phase in the erlang package using substitute* also explicitly returns #t. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlsfbqtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdDCA/6A+F/VU539BAfoncodK6CgrVuZLwk5y1LvfRF2qtrX4oX8qxcyBo/U1MF dAPDJnhOseRW6sI1haVv1RdMogwDGpFMmFoVHN8XVw7iGk1sGRRcESQ/beaC+xh1 9ZfWD0kC5iPwAA3kGKVu0wt5C18MvfshFG5ZrrWER0UjD+EPFFPP6zCcO37iS//o YoNm8h7GtK+uDJmAt/1rj64QGIxI23L81xzhiukDy7DD6YpyNh6rwzp5Gu5Vx6PZ 5wbtxYwTn7L2dRXGF9h54a47q+3dGNjUzSQhvP/ELty27UCAaY3v18wWyiMKbAUH 6T8Vyzx+XA4XOdnOmYxQML7S8s3f9rUPZhGch261F3wUViYmNKwmPgrrYznJdDAG dHFfQ9BvHi+d2gKxlVJpFeMA3YnvNHuVqJFxFOL+w5cORdQlmvWW5zulLh/kfRxT tYGUALkI0OccvVq1ErAiMj0zvirkL9wLYdp99r65XJdgjwMwKFj2PxecjOkhHAm/ RUMDHFawjwFlehC+47tdnYKGqg9HB4RGwwTe8hDu/UMgvTy6gBgvx0+wiwT7FdDq hGLdNBdi2xi4MOYccC5gKOz+y4yIucD2stLBD3qVWJfpFqSKZ+xYZOm/8rhukWQd ok1/O6bZVZcKPqtbB++R1KeDni3gT5RY/GtLXBxian+pjjMkCJY= =3Kc3 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 21:17:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 10 Jul 2018 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator