GNU bug report logs - #31673
[PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31673 in the body.
You can then email your comments to 31673 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
Date: Fri,  1 Jun 2018 00:01:50 +0300

* gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
'mariadb'.
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9c799aeff..4850f6327 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -8084,7 +8084,7 @@ object has been freed.")
              #t)))))
     (inputs
      `(("emacs-minimal" ,emacs-minimal)
-       ("mysql" ,mysql)
+       ("mariadb" ,mariadb)
        ("postgresql" ,postgresql)))
     (propagated-inputs
      `(("emacs-finalize" ,emacs-finalize)
-- 
2.17.0

Message #8 received at 31673 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 31673 <at> debbugs.gnu.org
Subject: Re: [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with
 mariadb input.
Date: Fri, 01 Jun 2018 00:07:47 +0300

[Message part 1 (text/plain, inline)]

Hello, Guix.

MySQL failed to build on core-updates branch and Mariadb is more Freedom
friendly.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31673 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31673 <at> debbugs.gnu.org
Subject: Re: [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with
 mariadb input.
Date: Fri, 01 Jun 2018 10:18:56 +0200

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
> 'mariadb'.

LGTM!

Probably we should stick to a policy regarding mariadb vs. mysql, namely
choosing a default and using that in all the packages.  (I think we’ve
informally done that already, but doing it formally and systematically
would make sense.)

Ludo’.

Message #14 received at 31673 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 31673 <at> debbugs.gnu.org, 31673-done <at> debbugs.gnu.org
Subject: Re: [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with
 mariadb input.
Date: Mon, 11 Jun 2018 11:53:09 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Apologies for a delay and thank you for the review.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> * gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
>> 'mariadb'.
>
> LGTM!

Pushed as e0cc7f669bec22c37481dd03a7941c7d11a64f1d to origin/master

> Probably we should stick to a policy regarding mariadb vs. mysql, namely
> choosing a default and using that in all the packages. […]

1+ :-)

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.