GNU bug report logs - #31662
[PATCH] fix double counting bug in term.el

Previous Next

Full log

Message #8 received at 31662 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: John Shahid <jvshahid <at> gmail.com>
Cc: 31662 <at> debbugs.gnu.org
Subject: Re: bug#31662: [PATCH] fix double counting bug in term.el
Date: Thu, 31 May 2018 18:51:06 -0400

John Shahid <jvshahid <at> gmail.com> writes:
>                    (when (not (or (eobp) term-insert-mode))
>                      (let ((pos (point)))
>                        (term-move-columns columns)
> -                      (delete-region pos (point))))
> +                      (delete-region pos (point))
> +                      (term-move-columns (- columns))))

I think it's a better idea to just reset term-current-column to nil,
like what happens in Emacs 26.

> +  (should (equal "abcde    j"
> +                 (term-test-screen-from-input
> +                  10 12 (concat "\e[mabcdefghij"
> +                                "\e[H"  ;move back to point-min
> +                                "\e[mabcde"
> +                                "\e[m    j"))))
> +

The "\e[m" is just to make the strings get processed separately, right?
You can pass a list of strings instead:

    (term-test-screen-from-input
     10 12 (list "abcdefghij"
                 "\e[H" ;move back to point-min
                 "abcde"
                 "    j"))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.